The checkstyle plugin in the 2021-03 version of Eclipse defaults to
version 8.43 of Checkstyle. This version of Checkstyle removes the
"scope" keyword from the JavadocMethod module, because it is redundant,
so the ONAP checkstyle onap-kava-style.xml file breaks.
This review:
- Removes the "scope" property from the "JavadocMethod" module, where it
is redundant anyhow (scope applies on the "MissingJavadocMethod" module
- Removes the "scope" property from the "MissingJavadocMethod" because
it defaults to the correct value for ONAP, that is "public"
Issue-ID: POLICY-3206
Change-Id: I62736ec812595929392b5eef0658acb77365c52a
Signed-off-by: liamfallon <liam.fallon@est.tech>
value="CLASS_DEF, INTERFACE_DEF, ENUM_DEF, METHOD_DEF, CTOR_DEF, VARIABLE_DEF" />
</module>
<module name="JavadocMethod">
value="CLASS_DEF, INTERFACE_DEF, ENUM_DEF, METHOD_DEF, CTOR_DEF, VARIABLE_DEF" />
</module>
<module name="JavadocMethod">
- <property name="scope" value="public" />
<property name="allowMissingParamTags" value="true" />
<property name="allowMissingReturnTag" value="true" />
<property name="allowedAnnotations" value="Override, Test" />
<property name="tokens" value="METHOD_DEF, CTOR_DEF, ANNOTATION_FIELD_DEF" />
</module>
<module name="MissingJavadocMethod">
<property name="allowMissingParamTags" value="true" />
<property name="allowMissingReturnTag" value="true" />
<property name="allowedAnnotations" value="Override, Test" />
<property name="tokens" value="METHOD_DEF, CTOR_DEF, ANNOTATION_FIELD_DEF" />
</module>
<module name="MissingJavadocMethod">
- <property name="scope" value="public" />
<property name="minLineCount" value="2" />
<property name="allowedAnnotations" value="Override, Test" />
<property name="tokens" value="METHOD_DEF, CTOR_DEF, ANNOTATION_FIELD_DEF" />
<property name="minLineCount" value="2" />
<property name="allowedAnnotations" value="Override, Test" />
<property name="tokens" value="METHOD_DEF, CTOR_DEF, ANNOTATION_FIELD_DEF" />
<dependency>
<groupId>com.puppycrawl.tools</groupId>
<artifactId>checkstyle</artifactId>
<dependency>
<groupId>com.puppycrawl.tools</groupId>
<artifactId>checkstyle</artifactId>
- <version>8.37</version>
+ <version>8.43</version>
</dependency>
</dependencies>
</plugin>
</dependency>
</dependencies>
</plugin>