Revert "[COMMON] add pre upgrade script for mariadb-galera"

This reverts the following commits:
  * eb9eb59171a43d25fb012aaad0a1d37ca86bc2bf
  * a72170b49e04aacb2ff476965904900fe5559fef

Reason for revert: upgrade script is not working well in all situations

Issue-ID: INT-1633
Signed-off-by: Sylvain Desbureaux <sylvain.desbureaux@orange.com>
Change-Id: Ia61a08d1e6cc4499525d82c5b2dfd83cf2d6a3e8

diff --git a/kubernetes/common/mariadb-galera/resources/create-deployment.yml b/kubernetes/common/mariadb-galera/resources/create-deployment.yml
deleted file mode 100644 (file)
index d81d640..0000000
--- a/kubernetes/common/mariadb-galera/resources/create-deployment.yml
+++ /dev/null
@@ -1,50 +0,0 @@
-apiVersion: apps/v1
-kind: Deployment
-metadata: {{- include "common.resourceMetadata" (dict "suffix" "upgrade-deployment" "dot" .) | nindent 4 }}
-spec:
-  replicas: 1
-  selector:
-    matchLabels:
-      app:  {{ include "common.fullname" . }}
-  template:
-    metadata:
-      labels:
-        app:  {{ include "common.fullname" . }}
-    spec:
-      containers:
-      - name: {{ include "common.name" . }}
-        image: "{{ include "common.repository" . }}/{{ .Values.image }}"
-        ports:
-        - containerPort: {{ .Values.service.internalPort }}
-          name: {{ .Values.service.portName }}
-        - containerPort: {{ .Values.service.sstPort }}
-          name: {{ .Values.service.sstPortName }}
-        - containerPort: {{ .Values.service.replicationPort }}
-          name: {{ .Values.service.replicationName }}
-        - containerPort: {{ .Values.service.istPort }}
-          name: {{ .Values.service.istPortName }}
-        env:
-        - name: POD_NAMESPACE
-          valueFrom:
-                fieldRef:
-                  apiVersion: v1
-                  fieldPath: metadata.namespace
-        - name: MYSQL_USER
-          valueFrom:
-            secretKeyRef:
-              key: login
-              name: {{ include "common.fullname" . }}-temp-upgrade-usercred
-        - name: MYSQL_PASSWORD
-          valueFrom:
-            secretKeyRef:
-              key: password
-              name: {{ include "common.fullname" . }}-temp-upgrade-usercred
-        - name: MYSQL_DATABASE
-          value: {{ default "" .Values.config.mysqlDatabase | quote }}
-        - name: MYSQL_ROOT_PASSWORD
-          valueFrom:
-            secretKeyRef:
-              key: password
-              name: {{ include "common.fullname" . }}-temp-upgrade-root
-      subdomain: {{ .Values.service.name }}
-      hostname: {{ .Values.nameOverride }}-upgrade-deployment

diff --git a/kubernetes/common/mariadb-galera/resources/post-upgrade-script.sh b/kubernetes/common/mariadb-galera/resources/post-upgrade-script.sh
deleted file mode 100644 (file)
index ec09df3..0000000
--- a/kubernetes/common/mariadb-galera/resources/post-upgrade-script.sh
+++ /dev/null
@@ -1,142 +0,0 @@
-#!/bin/bash
-
-TEMP_POD=$(kubectl get pod -n $NAMESPACE_ENV --selector \
-  app='{{ include "common.fullname" . }}' -o \
-  jsonpath='{.items[?(@.metadata.ownerReferences[].kind=="ReplicaSet")].metadata.name}')
-
-tmp_MYSQL_PASSWORD=$(echo -n $(kubectl exec -n $NAMESPACE_ENV $TEMP_POD -- printenv \
-  MYSQL_PASSWORD) | base64)
-
-tmp_ROOT_PASSWORD=$(echo -n $(kubectl exec -n $NAMESPACE_ENV $TEMP_POD -- printenv \
-  MYSQL_ROOT_PASSWORD) | base64)
-
-FLAG_EX_ROOT_SEC='{{ include "common.secret.getSecretNameFast" (dict "global" . "uid" (include "common.mariadb.secret.rootPassUID" .)) }}'
-
-FLAG_EX_SEC='{{ include "common.secret.getSecretNameFast" (dict "global" . "uid" (include "common.mariadb.secret.userCredentialsUID" .)) }}'
-
-kubectl patch secret $FLAG_EX_ROOT_SEC -p \
-  '{"data":{"password":"'"$tmp_ROOT_PASSWORD"'"}}'
-
-kubectl patch secret $FLAG_EX_SEC -p \
-  '{"data":{"password":"'"$tmp_MYSQL_PASSWORD"'"}}'
-
-MYSQL_USER=$(kubectl exec -n $NAMESPACE_ENV $TEMP_POD -- printenv MYSQL_USER)
-
-MYSQL_PASSWORD=$(echo -n $(kubectl exec -n $NAMESPACE_ENV $TEMP_POD -- printenv MYSQL_PASSWORD))
-
-MYSQL_ROOT_PASSWORD=$(kubectl exec -n $NAMESPACE_ENV $TEMP_POD -- printenv MYSQL_ROOT_PASSWORD)
-
-CURRENT_STS_REPLICA=$(kubectl get statefulsets -n $NAMESPACE_ENV \
-  {{ include "common.fullname" . }} -o jsonpath='{.status.replicas}')
-
-DEPLOYMENT_REPLICA=$(kubectl get deployment -n $NAMESPACE_ENV \
-  {{ include "common.fullname" . }}-upgrade-deployment -o \
-  jsonpath='{.status.replicas}')
-
-if [[ $CURRENT_STS_REPLICA == "0" ]]
-then
-  echo "Seems there was no upgrade of cluster and we will scale up cluster replicas back to $REPLICA_COUNT now"
-  kubectl scale statefulsets {{ include "common.fullname" . }} --replicas=$REPLICA_COUNT
-fi
-
-MY_REPLICA_NUMBER=$(kubectl get statefulsets -n $NAMESPACE_ENV \
-  {{ include "common.fullname" . }} -o jsonpath='{.status.replicas}')
-
-while [[ ! $MY_REPLICA_NUMBER == $REPLICA_COUNT ]]
-do
-    echo "The cluster is not scaled up to $REPLICA_COUNT yet. Please wait ..."
-    MY_REPLICA_NUMBER=$(kubectl get statefulsets -n $NAMESPACE_ENV \
-      {{ include "common.fullname" . }} -o jsonpath='{.status.replicas}')
-    echo "The current status of the cluster is $MY_REPLICA_NUMBER"
-    sleep 2
-    if [[ $MY_REPLICA_NUMBER == $REPLICA_COUNT ]]
-    then
-        break
-    fi
-done
-
-CLUSTER_NO=$(kubectl exec -n $NAMESPACE_ENV $TEMP_POD -- \
-  mysql --skip-column-names -h{{ $.Values.service.name }} -u$MYSQL_USER \
-  -p$MYSQL_PASSWORD -e "SHOW GLOBAL STATUS LIKE 'wsrep_cluster_size';" | \
-  awk '{print $2}')
-
-CLUSTER_STATE=$(kubectl exec -n $NAMESPACE_ENV $TEMP_POD -- \
-  mysql --skip-column-names -h{{ $.Values.service.name }} -u$MYSQL_USER \
-  -p$MYSQL_PASSWORD -e "SHOW GLOBAL STATUS LIKE 'wsrep_local_state_comment';" \
-  | awk '{print $2}')
-
-while [[ ! $CLUSTER_NO == $((REPLICA_COUNT+DEPLOYMENT_REPLICA)) ]] \
-   || [[ ! $CLUSTER_STATE == "Synced" ]]
-do
-    echo "$CLUSTER_NO and $CLUSTER_STATE"
-    CLUSTER_NO=$(kubectl exec -n $NAMESPACE_ENV $TEMP_POD -- mysql \
-      --skip-column-names -h{{ $.Values.service.name }} -u$MYSQL_USER \
-      -p$MYSQL_PASSWORD -e "SHOW GLOBAL STATUS LIKE 'wsrep_cluster_size';" \
-      | awk '{print $2}')
-    CLUSTER_STATE=$(kubectl exec -n $NAMESPACE_ENV $TEMP_POD -- mysql \
-      --skip-column-names -h{{ $.Values.service.name }} -u$MYSQL_USER \
-      -p$MYSQL_PASSWORD -e "SHOW GLOBAL STATUS LIKE 'wsrep_local_state_comment';" \
-      | awk '{print $2}')
-    sleep 2
-    if [[ $CLUSTER_NO == $((REPLICA_COUNT+DEPLOYMENT_REPLICA)) ]] \
-       && [[ $CLUSTER_STATE == "Synced" ]]
-    then
-        echo "The cluster has $CLUSTER_NO members and  $CLUSTER_STATE state."
-        break
-    fi
-done
-
-MYSQL_STATUS=$(kubectl exec -n $NAMESPACE_ENV {{ include "common.fullname" . }}-0 -- mysqladmin \
-  -uroot -p$MYSQL_ROOT_PASSWORD ping)
-
-while [[ ! $MYSQL_STATUS == "mysqld is alive" ]]
-do
-  echo "Mariadb deployment is not ready yet."
-  sleep 2
-  MYSQL_STATUS=$(kubectl exec -n $NAMESPACE_ENV {{ include "common.fullname" . }}-0 -- mysqladmin \
-  -uroot -p$MYSQL_ROOT_PASSWORD ping)
-  if [[ $MYSQL_STATUS == "mysqld is alive" ]]
-  then
-    echo "Mariadb deployment is ready and cluster size is $CLUSTER_NO"
-    break
-  fi
-done
-
-echo "Deleting upgrade deployment now"
-
-kubectl delete deployment -n $NAMESPACE_ENV {{ include "common.fullname" . }}-upgrade-deployment
-kubectl delete secret -n $NAMESPACE_ENV {{ include "common.fullname" . }}-temp-upgrade-root
-kubectl delete secret -n $NAMESPACE_ENV {{ include "common.fullname" . }}-temp-upgrade-usercred
-
-CLUSTER_NO=$(kubectl exec -n $NAMESPACE_ENV {{ include "common.fullname" . }}-0 -- \
-  mysql --skip-column-names -h{{ $.Values.service.name }} -u$MYSQL_USER \
-  -p$MYSQL_PASSWORD -e "SHOW GLOBAL STATUS LIKE 'wsrep_cluster_size';" | \
-  awk '{print $2}')
-
-CLUSTER_STATE=$(kubectl exec -n $NAMESPACE_ENV {{ include "common.fullname" . }}-0 -- \
-  mysql --skip-column-names -h{{ $.Values.service.name }} -u$MYSQL_USER \
-  -p$MYSQL_PASSWORD -e "SHOW GLOBAL STATUS LIKE 'wsrep_local_state_comment';" \
-  | awk '{print $2}')
-
-while [[ ! $CLUSTER_NO == $REPLICA_COUNT ]] \
-   || [[ ! $CLUSTER_STATE == "Synced" ]]
-do
-    echo "$CLUSTER_NO and $CLUSTER_STATE"
-    CLUSTER_NO=$(kubectl exec -n $NAMESPACE_ENV {{ include "common.fullname" . }}-0 -- mysql \
-      --skip-column-names -h{{ $.Values.service.name }} -u$MYSQL_USER \
-      -p$MYSQL_PASSWORD -e "SHOW GLOBAL STATUS LIKE 'wsrep_cluster_size';" \
-      | awk '{print $2}')
-    CLUSTER_STATE=$(kubectl exec -n $NAMESPACE_ENV {{ include "common.fullname" . }}-0 -- mysql \
-      --skip-column-names -h{{ $.Values.service.name }} -u$MYSQL_USER \
-      -p$MYSQL_PASSWORD -e "SHOW GLOBAL STATUS LIKE 'wsrep_local_state_comment';" \
-      | awk '{print $2}')
-    sleep 2
-    if [[ $CLUSTER_NO == $REPLICA_COUNT ]] \
-       && [[ $CLUSTER_STATE == "Synced" ]]
-    then
-        echo "The cluster has $CLUSTER_NO members and  $CLUSTER_STATE state."
-        break
-    fi
-done
-
-echo "The cluster upgrade is finished now"

diff --git a/kubernetes/common/mariadb-galera/resources/upgrade-scripts.sh b/kubernetes/common/mariadb-galera/resources/upgrade-scripts.sh
deleted file mode 100644 (file)
index ff44606..0000000
--- a/kubernetes/common/mariadb-galera/resources/upgrade-scripts.sh
+++ /dev/null
@@ -1,101 +0,0 @@
-#!/bin/bash
-MYSQL_USER=$(kubectl exec -n $NAMESPACE_ENV \
-  {{ include "common.fullname" . }}-0 -- printenv MYSQL_USER)
-
-MYSQL_PASSWORD=$(kubectl exec -n $NAMESPACE_ENV \
-  {{ include "common.fullname" . }}-0 -- printenv MYSQL_PASSWORD)
-
-MYSQL_ROOT_PASSWORD=$(kubectl exec -n $NAMESPACE_ENV \
-  {{ include "common.fullname" . }}-0 -- printenv MYSQL_ROOT_PASSWORD)
-
-kubectl create secret generic \
-  '{{ include "common.fullname" . }}'-temp-upgrade-root \
-  --from-literal=password=$MYSQL_ROOT_PASSWORD
-
-kubectl create secret generic \
-  '{{ include "common.fullname" . }}'-temp-upgrade-usercred \
-  --from-literal=login=$MYSQL_USER --from-literal=password=$MYSQL_PASSWORD
-
-kubectl create -f /upgrade/create-deployment.yml
-
-TEMP_POD=$(kubectl get pod -n $NAMESPACE_ENV --selector \
-  app='{{ include "common.fullname" . }}' -o \
-  jsonpath='{.items[?(@.metadata.ownerReferences[].kind=="ReplicaSet")].metadata.name}')
-
-CLUSTER_NO=$(kubectl exec -n $NAMESPACE_ENV $TEMP_POD -- \
-  mysql --skip-column-names -h{{ $.Values.service.name }} -u$MYSQL_USER \
-  -p$MYSQL_PASSWORD -e "SHOW GLOBAL STATUS LIKE 'wsrep_cluster_size';" | \
-  awk '{print $2}')
-
-CLUSTER_STATE=$(kubectl exec -n $NAMESPACE_ENV $TEMP_POD -- \
-  mysql --skip-column-names -h{{ $.Values.service.name }} -u$MYSQL_USER \
-  -p$MYSQL_PASSWORD -e "SHOW GLOBAL STATUS LIKE 'wsrep_local_state_comment';" \
-  | awk '{print $2}')
-
-STS_REPLICA=$(kubectl get statefulsets -n $NAMESPACE_ENV \
-  {{ include "common.fullname" . }} -o jsonpath='{.status.replicas}')
-
-DEPLOYMENT_REPLICA=$(kubectl get deployment -n $NAMESPACE_ENV \
-  {{ include "common.fullname" . }}-upgrade-deployment -o \
-  jsonpath='{.status.replicas}')
-
-while [[ ! $CLUSTER_NO == $((STS_REPLICA+DEPLOYMENT_REPLICA)) ]] \
-   || [[ ! $CLUSTER_STATE == "Synced" ]]
-do
-    echo "$CLUSTER_NO and $CLUSTER_STATE"
-    CLUSTER_NO=$(kubectl exec -n $NAMESPACE_ENV $TEMP_POD -- mysql \
-      --skip-column-names -h{{ $.Values.service.name }} -u$MYSQL_USER \
-      -p$MYSQL_PASSWORD -e "SHOW GLOBAL STATUS LIKE 'wsrep_cluster_size';" \
-      | awk '{print $2}')
-    CLUSTER_STATE=$(kubectl exec -n $NAMESPACE_ENV $TEMP_POD -- mysql \
-      --skip-column-names -h{{ $.Values.service.name }} -u$MYSQL_USER \
-      -p$MYSQL_PASSWORD -e "SHOW GLOBAL STATUS LIKE 'wsrep_local_state_comment';" \
-      | awk '{print $2}')
-    sleep 2
-    if [[ $CLUSTER_NO == $((STS_REPLICA+DEPLOYMENT_REPLICA)) ]] \
-       && [[ $CLUSTER_STATE == "Synced" ]]
-    then
-        echo "The cluster has $CLUSTER_NO members and  $CLUSTER_STATE state."
-        break
-    fi
-done
-
-MYSQL_STATUS=$(kubectl exec -n $NAMESPACE_ENV $TEMP_POD -- mysqladmin \
-  -uroot -p$MYSQL_ROOT_PASSWORD ping)
-
-while [[ ! $MYSQL_STATUS == "mysqld is alive" ]]
-do
-  echo "Mariadb deployment is not ready yet."
-  sleep 2
-  MYSQL_STATUS=$(kubectl exec -n $NAMESPACE_ENV $TEMP_POD -- mysqladmin \
-  -uroot -p$MYSQL_ROOT_PASSWORD ping)
-  if [[ $MYSQL_STATUS == "mysqld is alive" ]]
-  then
-    echo "Mariadb deployment is ready."
-    break
-  fi
-done
-
-kubectl scale statefulsets {{ include "common.fullname" . }} --replicas=0
-MY_REPLICA_NUMBER=$(kubectl get statefulsets -n $NAMESPACE_ENV \
-  {{ include "common.fullname" . }} -o jsonpath='{.status.replicas}')
-echo "The the cluster has $MY_REPLICA_NUMBER replicas."
-
-while [[ ! $MY_REPLICA_NUMBER == "0" ]]
-do
-    echo "The cluster is not scaled to 0 yet. Please wait ..."
-    MY_REPLICA_NUMBER=$(kubectl get statefulsets -n $NAMESPACE_ENV \
-      {{ include "common.fullname" . }} -o jsonpath='{.status.replicas}')
-    echo "The current status of the cluster is $MY_REPLICA_NUMBER"
-    sleep 2
-    if [[ $MY_REPLICA_NUMBER == "0" ]]
-    then
-        break
-    fi
-done
-
-for (( index=0; index<$STS_REPLICA; index+=1 ))
-do
-    kubectl delete pvc \
-    "{{ include "common.fullname" . }}-data-{{ include "common.fullname" . }}-$index"
-done

diff --git a/kubernetes/common/mariadb-galera/templates/configmap.yaml b/kubernetes/common/mariadb-galera/templates/configmap.yaml
index 685901f..6fe2979 100644 (file)
--- a/kubernetes/common/mariadb-galera/templates/configmap.yaml
+++ b/kubernetes/common/mariadb-galera/templates/configmap.yaml
@@ -41,38 +41,4 @@ metadata:
     release: {{ include "common.release" . }}
     heritage: {{ .Release.Service }}
 data:
-{{ tpl (.Files.Glob "resources/config/*").AsConfig . | indent 2 }}
----
-apiVersion: v1
-kind: ConfigMap
-metadata:
-  name: {{ include "common.fullname" . }}-upgrade-deployment
-  annotations:
-    "helm.sh/hook": "pre-upgrade"
-    "helm.sh/hook-weight": "0"
-    "helm.sh/hook-delete-policy": hook-succeeded
-  namespace: {{ include "common.namespace" . }}
-  labels:
-    app: {{ include "common.name" . }}
-    chart: {{ .Chart.Name }}-{{ .Chart.Version | replace "+" "_" }}
-    release: {{ .Release.Name }}
-    heritage: {{ .Release.Service }}
-data:
-{{ tpl (.Files.Glob "resources/*").AsConfig . | indent 2 }}
----
-apiVersion: v1
-kind: ConfigMap
-metadata:
-  name: {{ include "common.fullname" . }}-post-upgrade-deployment
-  annotations:
-    "helm.sh/hook": "post-upgrade"
-    "helm.sh/hook-weight": "0"
-    "helm.sh/hook-delete-policy": hook-succeeded
-  namespace: {{ include "common.namespace" . }}
-  labels:
-    app: {{ include "common.name" . }}
-    chart: {{ .Chart.Name }}-{{ .Chart.Version | replace "+" "_" }}
-    release: {{ .Release.Name }}
-    heritage: {{ .Release.Service }}
-data:
-{{ tpl (.Files.Glob "resources/post-upgrade-script.sh").AsConfig . | indent 2 }}
+{{ tpl (.Files.Glob "resources/config/*").AsConfig . | indent 2 }}
\ No newline at end of file

diff --git a/kubernetes/common/mariadb-galera/templates/job.yaml b/kubernetes/common/mariadb-galera/templates/job.yaml
deleted file mode 100644 (file)
index 5dc822a..0000000
--- a/kubernetes/common/mariadb-galera/templates/job.yaml
+++ /dev/null
@@ -1,109 +0,0 @@
-apiVersion: batch/v1
-kind: Job
-metadata:
-  name: {{ include "common.fullname" . }}-pre-upgrade
-  annotations:
-    "helm.sh/hook": "pre-upgrade"
-    "helm.sh/hook-weight": "1"
-    "helm.sh/hook-delete-policy": before-hook-creation,hook-succeeded
-spec:
-  template:
-    spec:
-      securityContext:
-        fsGroup: 1001
-        runAsUser: 1001
-      containers:
-      - name: mariadb-job-pre-upgrade
-        image: {{ .Values.global.kubectlImage}}
-        imagePullPolicy: IfNotPresent
-        env:
-          - name: NAMESPACE_ENV
-            valueFrom:
-                fieldRef:
-                  apiVersion: v1
-                  fieldPath: metadata.namespace
-        command: ["/bin/bash", "-c", "--"]
-        args: ["/upgrade/upgrade-scripts.sh"]
-        volumeMounts:
-        - name: config-mariadb-upgrade
-          mountPath: /upgrade
-      volumes:
-      - name: config-mariadb-upgrade
-        configMap:
-            name: {{ include "common.fullname" . }}-upgrade-deployment
-            defaultMode: 0777
-      restartPolicy: OnFailure
----
-apiVersion: batch/v1
-kind: Job
-metadata:
-  name: {{ include "common.fullname" . }}-post-upgrade
-  annotations:
-    "helm.sh/hook": "post-upgrade"
-    "helm.sh/hook-weight": "1"
-    "helm.sh/hook-delete-policy": before-hook-creation,hook-succeeded
-spec:
-  template:
-    spec:
-      securityContext:
-        fsGroup: 1001
-        runAsUser: 0
-      initContainers:
-      - image: "{{ include "common.repository" . }}/{{ .Values.global.readinessImage }}"
-        name: mariadb-galera-upgrade-readiness
-        env:
-        - name: NAMESPACE
-          valueFrom:
-            fieldRef:
-              apiVersion: v1
-              fieldPath: metadata.namespace
-        command:
-        - /app/ready.py
-        args:
-        - --container-name
-        - mariadb-galera
-      containers:
-      - name: mariadb-job-post-upgrade
-        image: {{ .Values.global.kubectlImage}}
-        imagePullPolicy: IfNotPresent
-        env:
-        - name: NAMESPACE_ENV
-          valueFrom:
-              fieldRef:
-                apiVersion: v1
-                fieldPath: metadata.namespace
-        - name: REPLICA_COUNT
-          value: "{{ .Values.replicaCount }}"
-        command: ["/bin/bash", "-c", "--"]
-        args: ["/upgrade/post-upgrade-script.sh"]
-        volumeMounts:
-        - name: config-mariadb-upgrade
-          mountPath: /upgrade
-      volumes:
-      - name: config-mariadb-upgrade
-        configMap:
-            name: {{ include "common.fullname" . }}-post-upgrade-deployment
-            defaultMode: 0777
-      restartPolicy: OnFailure
----
-apiVersion: batch/v1
-kind: Job
-metadata:
-  name: {{ include "common.fullname" . }}-post-delete
-  annotations:
-    "helm.sh/hook": "post-delete"
-    "helm.sh/hook-weight": "1"
-    "helm.sh/hook-delete-policy": before-hook-creation,hook-succeeded
-spec:
-  template:
-    spec:
-      containers:
-      - name: mariadb-job-post-delete
-        image: {{ .Values.global.kubectlImage}}
-        imagePullPolicy: IfNotPresent
-        command: ["/bin/bash", "-c", "--"]
-        args:
-        - for ((index=0;index<{{ $.Values.replicaCount }};index+=1));
-          do kubectl delete pvc "{{ include "common.fullname" . }}-data-{{ include "common.fullname" . }}-$index";
-          done; kubectl delete deployment {{ include "common.fullname" . }}-upgrade-deployment;
-      restartPolicy: OnFailure