swagger resource file contain try blocks use
try with resources construct as per SONAR
Issue-ID: HOLMES-145
Change-Id: Id977d6d7b70698b965b32a67c31e366e510e11e0
Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
import io.swagger.annotations.Api;
import io.swagger.annotations.SwaggerDefinition;
import io.swagger.annotations.Api;
import io.swagger.annotations.SwaggerDefinition;
-import java.io.BufferedReader;
-import java.io.File;
-import java.io.FileNotFoundException;
-import java.io.FileReader;
-import java.io.IOException;
import java.net.URL;
import java.net.URLDecoder;
import javax.ws.rs.GET;
import java.net.URL;
import java.net.URLDecoder;
import javax.ws.rs.GET;
URL url = SwaggerResource.class.getResource("/swagger.json");
String ret = "{}";
URL url = SwaggerResource.class.getResource("/swagger.json");
String ret = "{}";
- BufferedReader br = null;
try {
System.out.println(URLDecoder.decode(url.getPath(), "UTF-8"));
try {
System.out.println(URLDecoder.decode(url.getPath(), "UTF-8"));
- File file = new File(URLDecoder.decode(url.getPath(), "UTF-8"));
-
- br = new BufferedReader(new FileReader(file));
+ file = new File(URLDecoder.decode(url.getPath(), "UTF-8"));
+ } catch(IOException e) {
+ log.warn("An error occurred while reading swagger.json.", e);
+ return ret;
+ }
+ try(BufferedReader br = new BufferedReader(new FileReader(file));) {
StringBuffer buffer = new StringBuffer();
String line = " ";
while ((line = br.readLine()) != null) {
StringBuffer buffer = new StringBuffer();
String line = " ";
while ((line = br.readLine()) != null) {
log.warn("Failed to read the API description file.", e);
} catch (IOException e) {
log.warn("An error occurred while reading swagger.json.", e);
log.warn("Failed to read the API description file.", e);
} catch (IOException e) {
log.warn("An error occurred while reading swagger.json.", e);
- } finally {
- if (br != null) {
- try {
- br.close();
- } catch (IOException e) {
- log.warn("Failed to close the file reader. This may cause memory leak.");
- }
- }