bugfix - mis-removal of rules

Issue-ID: HOLMES-564
Signed-off-by: Guangrong Fu <fu.guangrong@zte.com.cn>
Change-Id: I2dcf9f1a3f2bec54a6018afa203adff369c64554

diff --git a/pom.xml b/pom.xml
index 53f24b5..fa02d1c 100644 (file)
--- a/pom.xml
+++ b/pom.xml
@@ -136,7 +136,7 @@
         <dependency>
             <groupId>org.onap.holmes.common</groupId>
             <artifactId>holmes-actions</artifactId>
-            <version>1.4.3</version>
+            <version>1.4.4</version>
             <exclusions>
                 <exclusion>
                     <groupId>io.swagger</groupId>

diff --git a/rulemgt/src/main/java/org/onap/holmes/rulemgt/dcae/ConfigFileScanningTask.java b/rulemgt/src/main/java/org/onap/holmes/rulemgt/dcae/ConfigFileScanningTask.java
index d24d567..650ebbb 100644 (file)
--- a/rulemgt/src/main/java/org/onap/holmes/rulemgt/dcae/ConfigFileScanningTask.java
+++ b/rulemgt/src/main/java/org/onap/holmes/rulemgt/dcae/ConfigFileScanningTask.java
@@ -186,6 +186,7 @@ public class ConfigFileScanningTask implements Runnable {
     private boolean deployRule(String clName, String contents) {
         RuleCreateRequest ruleCreateRequest = getRuleCreateRequest(clName, contents);
         if (JerseyClient.newInstance().header("Accept", MediaType.APPLICATION_JSON)
+                .header("username", DEFAULT_CREATOR)
                 .put(url, Entity.json(ruleCreateRequest)) == null) {
             LOGGER.error("Failed to deploy rule: {}.", clName);
             return false;
@@ -200,7 +201,6 @@ public class ConfigFileScanningTask implements Runnable {
         ruleCreateRequest.setContent(contents);
         ruleCreateRequest.setDescription("");
         ruleCreateRequest.setEnabled(1);
-        ruleCreateRequest.setCreator(DEFAULT_CREATOR);
         return ruleCreateRequest;
     }
 

diff --git a/rulemgt/src/main/java/org/onap/holmes/rulemgt/resources/RuleMgtResources.java b/rulemgt/src/main/java/org/onap/holmes/rulemgt/resources/RuleMgtResources.java
index 133e859..2c9a462 100644 (file)
--- a/rulemgt/src/main/java/org/onap/holmes/rulemgt/resources/RuleMgtResources.java
+++ b/rulemgt/src/main/java/org/onap/holmes/rulemgt/resources/RuleMgtResources.java
@@ -62,10 +62,9 @@ public class RuleMgtResources {
         try {\r
             ruleChangeResponse = ruleMgtWrapper\r
                     .addCorrelationRule(UserUtil.getUserName(request), ruleCreateRequest);\r
-            log.info("create rule:" + ruleCreateRequest.getRuleName() + " success.");\r
             return ruleChangeResponse;\r
         } catch (CorrelationException e) {\r
-            log.error("create rule:" + ruleCreateRequest.getRuleName() + " failed", e);\r
+            log.error(String.format("failed to create the rule: %s", ruleCreateRequest.getRuleName()), e);\r
             throw ExceptionUtil.buildExceptionResponse(e.getMessage());\r
         }\r
     }\r
@@ -85,7 +84,7 @@ public class RuleMgtResources {
             log.info("update rule:" + ruleUpdateRequest.getRuleId() + " successful");\r
             return ruleChangeResponse;\r
         } catch (CorrelationException e) {\r
-            log.error("update rule:" + ruleUpdateRequest.getContent() + " failed", e);\r
+            log.error(String.format("failed to update the rule: %s", ruleUpdateRequest.getRuleId()), e);\r
             throw ExceptionUtil.buildExceptionResponse(e.getMessage());\r
         }\r
     }\r
@@ -95,10 +94,9 @@ public class RuleMgtResources {
     public ResponseEntity deleteCorrelationRule(@PathVariable("ruleid") String ruleId) {\r
         try {\r
             ruleMgtWrapper.deleteCorrelationRule(new RuleDeleteRequest(ruleId));\r
-            log.info("delete rule:" + ruleId + " successful");\r
             return ResponseEntity.status(HttpStatus.NO_CONTENT).build();\r
         } catch (CorrelationException e) {\r
-            log.error("delete rule:" + ruleId + " failed", e);\r
+            log.error(String.format("failed to delete the rule: %s", ruleId), e);\r
             throw ExceptionUtil.buildExceptionResponse(e.getMessage());\r
         }\r
     }\r
@@ -118,10 +116,9 @@ public class RuleMgtResources {
         try {\r
             ruleQueryListResponse = ruleMgtWrapper\r
                     .getCorrelationRuleByCondition(ruleQueryCondition);\r
-            log.info("query rule successful by condition:" + ruleQueryCondition);\r
             return ruleQueryListResponse;\r
         } catch (CorrelationException e) {\r
-            log.error("query rule failed,cause query condition conversion failure", e);\r
+            log.error(String.format("failed to query the rule: %s", ruleQueryCondition.getName()), e);\r
             throw ExceptionUtil.buildExceptionResponse(e.getMessage());\r
         }\r
     }\r

diff --git a/rulemgt/src/main/resources/logback-spring.xml b/rulemgt/src/main/resources/logback-spring.xml
index 197057e..eda9c6b 100644 (file)
--- a/rulemgt/src/main/resources/logback-spring.xml
+++ b/rulemgt/src/main/resources/logback-spring.xml
@@ -1,7 +1,7 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <configuration debug="false">
     <property name="LOG_HOME" value="/var/log/ONAP/holmes"/>
-    <property name="LOG_PATTERN" value="%d{yyyy-MM-dd HH:mm:ss SSS} %-5p [%c][%t] - %msg%n" />
+    <property name="LOG_PATTERN" value="%d{yyyy-MM-dd HH:mm:ss SSS} %-5p [%c][%t][%X{RequestID}][%X{InvocationID}] - %m%n" />
 
     <appender name="Console" class="ch.qos.logback.core.ConsoleAppender">
         <encoder class="ch.qos.logback.classic.encoder.PatternLayoutEncoder">

diff --git a/rulemgt/src/test/java/org/onap/holmes/rulemgt/dcae/ConfigFileScanningTaskTest.java b/rulemgt/src/test/java/org/onap/holmes/rulemgt/dcae/ConfigFileScanningTaskTest.java
index a4ab15b..cc29103 100644 (file)
--- a/rulemgt/src/test/java/org/onap/holmes/rulemgt/dcae/ConfigFileScanningTaskTest.java
+++ b/rulemgt/src/test/java/org/onap/holmes/rulemgt/dcae/ConfigFileScanningTaskTest.java
@@ -28,6 +28,7 @@ import org.onap.holmes.rulemgt.bean.response.RuleQueryListResponse;
 import org.onap.holmes.rulemgt.bean.response.RuleResult4API;
 import org.powermock.api.easymock.PowerMock;
 import org.powermock.core.classloader.annotations.PrepareForTest;
+import org.powermock.core.classloader.annotations.SuppressStaticInitializationFor;
 import org.powermock.modules.junit4.PowerMockRunner;
 import org.powermock.reflect.Whitebox;
 
@@ -37,6 +38,7 @@ import static org.junit.Assert.assertThat;
 
 @RunWith(PowerMockRunner.class)
 @PrepareForTest({JerseyClient.class})
+@SuppressStaticInitializationFor({"org.onap.holmes.common.utils.JerseyClient"})
 public class ConfigFileScanningTaskTest {
 
     @Rule
@@ -81,7 +83,7 @@ public class ConfigFileScanningTaskTest {
         EasyMock.expect(jcMock.get(EasyMock.anyString(), EasyMock.anyObject())).andReturn(rqlr);
 
         // mock for deployRule
-        EasyMock.expect(jcMock.header(EasyMock.anyString(), EasyMock.anyObject())).andReturn(jcMock);
+        EasyMock.expect(jcMock.header(EasyMock.anyString(), EasyMock.anyObject())).andReturn(jcMock).times(2);
         EasyMock.expect(jcMock.put(EasyMock.anyString(), EasyMock.anyObject())).andReturn("");
 
         PowerMock.replayAll();
@@ -169,7 +171,7 @@ public class ConfigFileScanningTaskTest {
         EasyMock.expect(jcMock.delete(EasyMock.anyString())).andReturn("");
 
         // mock for deployRule
-        EasyMock.expect(jcMock.header(EasyMock.anyString(), EasyMock.anyObject())).andReturn(jcMock);
+        EasyMock.expect(jcMock.header(EasyMock.anyString(), EasyMock.anyObject())).andReturn(jcMock).times(2);
         EasyMock.expect(jcMock.put(EasyMock.anyString(), EasyMock.anyObject())).andReturn("");
 
         PowerMock.replayAll();

diff --git a/rulemgt/src/test/java/org/onap/holmes/rulemgt/resources/RuleMgtResourcesTest.java b/rulemgt/src/test/java/org/onap/holmes/rulemgt/resources/RuleMgtResourcesTest.java
index a515196..7cc0def 100644 (file)
--- a/rulemgt/src/test/java/org/onap/holmes/rulemgt/resources/RuleMgtResourcesTest.java
+++ b/rulemgt/src/test/java/org/onap/holmes/rulemgt/resources/RuleMgtResourcesTest.java
@@ -51,7 +51,7 @@ public class RuleMgtResourcesTest {
     private RuleMgtResources ruleMgtResources = new RuleMgtResources();\r
 \r
     @Before\r
-    public void setUp() throws Exception {\r
+    public void setUp() {\r
         Whitebox.setInternalState(ruleMgtResources, "ruleMgtWrapper", ruleMgtWrapper);\r
         PowerMock.resetAll();\r
     }\r
@@ -64,7 +64,7 @@ public class RuleMgtResourcesTest {
         final RuleCreateRequest ruleCreateRequest = new RuleCreateRequest();\r
         EasyMock.expect(ruleMgtWrapper.addCorrelationRule("admin", ruleCreateRequest))\r
                 .andThrow(new CorrelationException(EasyMock.anyObject(String.class)));\r
-        EasyMock.expect(request.getHeader("username")).andReturn("admin");\r
+        EasyMock.expect(request.getHeader("username")).andReturn("admin").times(2);\r
         PowerMock.replayAll();\r
         ruleMgtResources.addCorrelationRule(request, ruleCreateRequest);\r
         PowerMock.verifyAll();\r
@@ -76,7 +76,7 @@ public class RuleMgtResourcesTest {
         final RuleCreateRequest ruleCreateRequest = new RuleCreateRequest();\r
         EasyMock.expect(ruleMgtWrapper.addCorrelationRule("admin",\r
                 ruleCreateRequest)).andReturn(new RuleAddAndUpdateResponse());\r
-        EasyMock.expect(request.getHeader("username")).andReturn("admin");\r
+        EasyMock.expect(request.getHeader("username")).andReturn("admin").times(2);\r
         PowerMock.replayAll();\r
         ruleMgtResources.addCorrelationRule(request, ruleCreateRequest);\r
         PowerMock.verifyAll();\r
@@ -89,7 +89,7 @@ public class RuleMgtResourcesTest {
         final RuleUpdateRequest ruleUpdateRequest = new RuleUpdateRequest();\r
         EasyMock.expect(ruleMgtWrapper.updateCorrelationRule("admin", ruleUpdateRequest))\r
                 .andThrow(new CorrelationException(EasyMock.anyObject(String.class)));\r
-        EasyMock.expect(request.getHeader("username")).andReturn("admin");\r
+        EasyMock.expect(request.getHeader("username")).andReturn("admin").times(2);\r
         PowerMock.replayAll();\r
         ruleMgtResources.updateCorrelationRule(request, ruleUpdateRequest);\r
         PowerMock.verifyAll();\r
@@ -100,7 +100,7 @@ public class RuleMgtResourcesTest {
         final RuleUpdateRequest ruleUpdateRequest = new RuleUpdateRequest();\r
         EasyMock.expect(ruleMgtWrapper.updateCorrelationRule("admin",\r
                 ruleUpdateRequest)).andReturn(new RuleAddAndUpdateResponse());\r
-        EasyMock.expect(request.getHeader("username")).andReturn("admin");\r
+        EasyMock.expect(request.getHeader("username")).andReturn("admin").times(2);\r
         PowerMock.replayAll();\r
         ruleMgtResources.updateCorrelationRule(request, ruleUpdateRequest);\r
         PowerMock.verifyAll();\r