fix sonar flagged issue related to try catch
block and other simple issues
Issue-ID: HOLMES-144
Change-Id: I81c1ec08384b61f7ef21fa2695076943b4956f74
Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
new EngineDActiveApp().run(args);
}
new EngineDActiveApp().run(args);
}
public void run(EngineDAppConfig configuration, Environment environment) throws Exception {
super.run(configuration, environment);
public void run(EngineDAppConfig configuration, Environment environment) throws Exception {
super.run(configuration, environment);
@Service
public class EngineDAppConfig extends Configuration {
@Service
public class EngineDAppConfig extends Configuration {
- private String defaultName = "Correlation-Rule";
-
private String apidescription = "Holmes rule management rest API";
@JsonProperty
private String apidescription = "Holmes rule management rest API";
@JsonProperty
import java.util.HashMap;
import java.util.Iterator;
import java.util.Map;
import java.util.HashMap;
import java.util.Iterator;
import java.util.Map;
-import java.util.concurrent.ConcurrentHashMap;
import javax.annotation.PreDestroy;
import javax.inject.Inject;
import lombok.extern.slf4j.Slf4j;
import javax.annotation.PreDestroy;
import javax.inject.Inject;
import lombok.extern.slf4j.Slf4j;
@Service\r
public class DroolsEngine {\r
\r
@Service\r
public class DroolsEngine {\r
\r
- private final static int ENABLE = 1;\r
+ private static final int ENABLE = 1;\r
+ public static final String UTF_8 = "UTF-8";\r
+ public static final String K_BASE = "KBase";\r
+ private static final String RULES_FILE_NAME = "src/main/resources/rules/rule.drl";\r
private final Set<String> packageNames = new HashSet<String>();\r
private final Set<String> packageNames = new HashSet<String>();\r
@Inject\r
private RuleMgtWrapper ruleMgtWrapper;\r
\r
@Inject\r
private RuleMgtWrapper ruleMgtWrapper;\r
\r
private void deployRuleFromDB(String ruleContent) throws CorrelationException {\r
avoidDeployBug();\r
StringReader reader = new StringReader(ruleContent);\r
private void deployRuleFromDB(String ruleContent) throws CorrelationException {\r
avoidDeployBug();\r
StringReader reader = new StringReader(ruleContent);\r
- kfs.write("src/main/resources/rules/rule.drl",\r
- this.resources.newReaderResource(reader,"UTF-8").setResourceType(ResourceType.DRL));\r
+ kfs.write(RULES_FILE_NAME,\r
+ this.resources.newReaderResource(reader, UTF_8).setResourceType(ResourceType.DRL));\r
kieBuilder = ks.newKieBuilder(kfs).buildAll();\r
try {\r
InternalKieModule internalKieModule = (InternalKieModule)kieBuilder.getKieModule();\r
kieBuilder = ks.newKieBuilder(kfs).buildAll();\r
try {\r
InternalKieModule internalKieModule = (InternalKieModule)kieBuilder.getKieModule();\r
throws CorrelationException {\r
avoidDeployBug();\r
StringReader reader = new StringReader(rule.getContent());\r
throws CorrelationException {\r
avoidDeployBug();\r
StringReader reader = new StringReader(rule.getContent());\r
- kfs.write("src/main/resources/rules/rule.drl",\r
- this.resources.newReaderResource(reader,"UTF-8").setResourceType(ResourceType.DRL));\r
+ kfs.write(RULES_FILE_NAME,\r
+ this.resources.newReaderResource(reader, UTF_8).setResourceType(ResourceType.DRL));\r
kieBuilder = ks.newKieBuilder(kfs).buildAll();\r
\r
judgeRuleContent(locale, kieBuilder, true);\r
\r
InternalKieModule internalKieModule = (InternalKieModule)kieBuilder.getKieModule();;\r
kieBuilder = ks.newKieBuilder(kfs).buildAll();\r
\r
judgeRuleContent(locale, kieBuilder, true);\r
\r
InternalKieModule internalKieModule = (InternalKieModule)kieBuilder.getKieModule();;\r
- String packageName = internalKieModule.getKnowledgePackagesForKieBase("KBase").iterator().next().getName();\r
+ String packageName = internalKieModule.getKnowledgePackagesForKieBase(K_BASE).iterator().next().getName();\r
try {\r
kieContainer.updateToVersion(internalKieModule.getReleaseId());\r
} catch (Exception e) {\r
try {\r
kieContainer.updateToVersion(internalKieModule.getReleaseId());\r
} catch (Exception e) {\r
throws CorrelationException {\r
StringReader reader = new StringReader(content);\r
\r
throws CorrelationException {\r
StringReader reader = new StringReader(content);\r
\r
- kfs.write("src/main/resources/rules/rule.drl",\r
- this.resources.newReaderResource(reader,"UTF-8").setResourceType(ResourceType.DRL));\r
+ kfs.write(RULES_FILE_NAME,\r
+ this.resources.newReaderResource(reader, UTF_8).setResourceType(ResourceType.DRL));\r
\r
kieBuilder = ks.newKieBuilder(kfs).buildAll();\r
\r
\r
kieBuilder = ks.newKieBuilder(kfs).buildAll();\r
\r
if (internalKieModule == null) {\r
throw new CorrelationException("There are errors in the rule!");\r
}\r
if (internalKieModule == null) {\r
throw new CorrelationException("There are errors in the rule!");\r
}\r
- String packageName = internalKieModule.getKnowledgePackagesForKieBase("KBase").iterator().next().getName();\r
+ String packageName = internalKieModule.getKnowledgePackagesForKieBase(K_BASE).iterator().next().getName();\r
\r
if (queryAllPackage().contains(packageName) && judgePackageName) {\r
throw new CorrelationException("The rule " + packageName + " already exists in the drools engine.");\r
\r
if (queryAllPackage().contains(packageName) && judgePackageName) {\r
throw new CorrelationException("The rule " + packageName + " already exists in the drools engine.");\r
\r
private KieFileSystem createKieFileSystemWithKProject(KieServices ks) {\r
KieModuleModel kieModuleModel = ks.newKieModuleModel();\r
\r
private KieFileSystem createKieFileSystemWithKProject(KieServices ks) {\r
KieModuleModel kieModuleModel = ks.newKieModuleModel();\r
- KieBaseModel kieBaseModel = kieModuleModel.newKieBaseModel("KBase")\r
+ KieBaseModel kieBaseModel = kieModuleModel.newKieBaseModel(K_BASE)\r
.addPackage("rules")\r
.setDefault(true)\r
.setEqualsBehavior(EqualityBehaviorOption.EQUALITY)\r
.addPackage("rules")\r
.setDefault(true)\r
.setEqualsBehavior(EqualityBehaviorOption.EQUALITY)\r
private void avoidDeployBug() {\r
String tmp = Math.random() + "";\r
String rule = "package justInOrderToAvoidDeployBug" + tmp.substring(2);\r
private void avoidDeployBug() {\r
String tmp = Math.random() + "";\r
String rule = "package justInOrderToAvoidDeployBug" + tmp.substring(2);\r
- kfs.write("src/main/resources/rules/rule.drl", rule);\r
+ kfs.write(RULES_FILE_NAME, rule);\r
kieBuilder = ks.newKieBuilder(kfs).buildAll();\r
InternalKieModule internalKieModule = (InternalKieModule)kieBuilder.getKieModule();\r
kieBuilder = ks.newKieBuilder(kfs).buildAll();\r
InternalKieModule internalKieModule = (InternalKieModule)kieBuilder.getKieModule();\r
- String packageName = internalKieModule.getKnowledgePackagesForKieBase("KBase").iterator().next().getName();\r
+ String packageName = internalKieModule.getKnowledgePackagesForKieBase(K_BASE).iterator().next().getName();\r
kieRepository.addKieModule(internalKieModule);\r
kieContainer.updateToVersion(internalKieModule.getReleaseId());\r
\r
kieRepository.addKieModule(internalKieModule);\r
kieContainer.updateToVersion(internalKieModule.getReleaseId());\r
\r
*/
package org.onap.holmes.engine.request;
*/
package org.onap.holmes.engine.request;
-import com.fasterxml.jackson.annotation.JsonProperty;
import javax.validation.constraints.NotNull;
import lombok.Getter;
import lombok.Setter;
import javax.validation.constraints.NotNull;
import lombok.Getter;
import lombok.Setter;
import io.swagger.annotations.Api;
import io.swagger.annotations.ApiOperation;
import io.swagger.annotations.ApiParam;
import io.swagger.annotations.Api;
import io.swagger.annotations.ApiOperation;
import io.swagger.annotations.ApiParam;
-import java.io.BufferedReader;
-import java.io.IOException;
-import java.io.StringReader;
import java.util.Locale;
import java.util.regex.Matcher;
import java.util.regex.Pattern;
import java.util.Locale;
import java.util.regex.Matcher;
import java.util.regex.Pattern;
package org.onap.holmes.engine.resources;
package org.onap.holmes.engine.resources;
-import io.swagger.annotations.Api;
-import io.swagger.annotations.SwaggerDefinition;
import java.io.BufferedReader;
import java.io.File;
import java.io.BufferedReader;
import java.io.File;
-import java.io.FileNotFoundException;
import java.io.FileReader;
import java.io.IOException;
import java.io.FileReader;
import java.io.IOException;
-import java.io.UnsupportedEncodingException;
import java.net.URL;
import java.net.URLDecoder;
import javax.ws.rs.GET;
import java.net.URL;
import java.net.URLDecoder;
import javax.ws.rs.GET;
public String getSwaggerJson() {
URL url = SwaggerResource.class.getResource("/swagger.json");
String ret = "{}";
public String getSwaggerJson() {
URL url = SwaggerResource.class.getResource("/swagger.json");
String ret = "{}";
- BufferedReader br = null;
try {
System.out.println(URLDecoder.decode(url.getPath(), "UTF-8"));
try {
System.out.println(URLDecoder.decode(url.getPath(), "UTF-8"));
- File file = new File(URLDecoder.decode(url.getPath(), "UTF-8"));
+ file = new File(URLDecoder.decode(url.getPath(), "UTF-8"));
+ } catch (IOException e) {
+ log.warn("An error occurred while decoding url");
+ }
- br = new BufferedReader(new FileReader(file));
+ if (file == null) {
+ log.warn("Unable to get Swagger Json since API description file could not be read");
+ return ret;
+ }
+
+ try(BufferedReader br = new BufferedReader(new FileReader(file))) {
StringBuffer buffer = new StringBuffer();
String line = " ";
while ((line = br.readLine()) != null) {
buffer.append(line);
}
ret = buffer.toString();
StringBuffer buffer = new StringBuffer();
String line = " ";
while ((line = br.readLine()) != null) {
buffer.append(line);
}
ret = buffer.toString();
- } catch (FileNotFoundException e) {
- log.warn("Failed to read the API description file.");
} catch (IOException e) {
log.warn("An error occurred while reading swagger.json.");
} catch (IOException e) {
log.warn("An error occurred while reading swagger.json.");
- } finally {
- if (br != null) {
- try {
- br.close();
- } catch (IOException e) {
- log.warn("Failed to close the file reader. This may cause memory leak.");
- }
- }