Test Replace Jackson with GSON

Change-Id: I684770d078e92c07d082889dcc9cb73ee590fb77
Issue-ID: HOLMES-115
Signed-off-by: YiLi <li.yi101@zte.com.cn>

diff --git a/holmes-actions/pom.xml b/holmes-actions/pom.xml
index b13870a..7551cda 100644 (file)
--- a/holmes-actions/pom.xml
+++ b/holmes-actions/pom.xml
@@ -104,6 +104,12 @@
         <dependency>\r
             <groupId>com.google.guava</groupId>\r
             <artifactId>guava</artifactId>\r
+            <exclusions>\r
+                <exclusion>\r
+                    <groupId>com.fasterxml.jackson.core</groupId>\r
+                    <artifactId>jackson-core</artifactId>\r
+                </exclusion>\r
+            </exclusions>\r
         </dependency>\r
         <dependency>\r
             <groupId>org.apache.poi</groupId>\r
@@ -172,7 +178,7 @@
         <dependency>\r
             <groupId>commons-beanutils</groupId>\r
             <artifactId>commons-beanutils</artifactId>\r
-            <version>1.8.3</version>\r
+            <version>1.9.2</version>\r
         </dependency>\r
         <dependency>\r
             <groupId>com.google.code.gson</groupId>\r

diff --git a/holmes-actions/src/main/java/org/onap/holmes/common/aai/AaiQuery.java b/holmes-actions/src/main/java/org/onap/holmes/common/aai/AaiQuery.java
index 48e6ec0..b3005d5 100644 (file)
--- a/holmes-actions/src/main/java/org/onap/holmes/common/aai/AaiQuery.java
+++ b/holmes-actions/src/main/java/org/onap/holmes/common/aai/AaiQuery.java
@@ -14,6 +14,7 @@
 package org.onap.holmes.common.aai;
 
 import java.util.HashMap;
+import java.util.List;
 import java.util.Map;
 import javax.inject.Inject;
 import lombok.extern.slf4j.Slf4j;
@@ -65,7 +66,11 @@ public class AaiQuery {
 
     private String getVmResourceLinks(String vserverId, String vserverName) throws CorrelationException {
         String response = getResourceLinksResponse(vserverId, vserverName);
-        return aaiResponseUtil.convertJsonToVmResourceLink(response).get(0).getResourceLink();
+        List linkList = aaiResponseUtil.convertJsonToVmResourceLink(response);
+        if (linkList.size() != 0) {
+            return aaiResponseUtil.convertJsonToVmResourceLink(response).get(0).getResourceLink();
+        }
+        return  "";
     }
 
     private String getResourceLinksResponse(String vserverId, String vserverName) throws CorrelationException {
@@ -108,6 +113,9 @@ public class AaiQuery {
     }
 
     private String getMsbSuffixAddr(String suffixUrl) {
+        if (suffixUrl.length() <= 0) {
+            return "";
+        }
         String[] addrSplits = suffixUrl.substring(1).split("/");
         String[] conv = addrSplits[2].split("-");
         addrSplits[2] = conv[0];

diff --git a/holmes-actions/src/main/java/org/onap/holmes/common/aai/AaiResponseUtil.java b/holmes-actions/src/main/java/org/onap/holmes/common/aai/AaiResponseUtil.java
index a8d3c0d..748dde0 100644 (file)
--- a/holmes-actions/src/main/java/org/onap/holmes/common/aai/AaiResponseUtil.java
+++ b/holmes-actions/src/main/java/org/onap/holmes/common/aai/AaiResponseUtil.java
@@ -41,7 +41,7 @@ public class AaiResponseUtil {
         List<VmResourceLink> vmResourceLinkList = new ArrayList<>();
         String resultDataKey = "result-data";
         JSONObject jsonNode = JSON.parseObject(responseJson);
-        if (jsonNode.get(resultDataKey) != null) {
+        if (jsonNode != null && jsonNode.get(resultDataKey) != null) {
             JSONArray resultData = jsonNode.getJSONArray(resultDataKey);
             vmResourceLinkList = convertResultDataList(resultData);
         }