Merge "Sonar Major issues"
authorRam Koya <rk541m@att.com>
Thu, 20 Sep 2018 15:26:51 +0000 (15:26 +0000)
committerGerrit Code Review <gerrit@onap.org>
Thu, 20 Sep 2018 15:26:51 +0000 (15:26 +0000)
1  2 
src/main/java/com/att/dmf/mr/resources/CambriaOutboundEventStream.java

@@@ -45,7 -45,7 +45,7 @@@ import com.att.dmf.mr.utils.DMaaPRespon
  import com.att.dmf.mr.utils.Utils;
  import com.att.eelf.configuration.EELFLogger;
  import com.att.eelf.configuration.EELFManager;
- //import com.att.nsa.drumlin.till.nv.rrNvReadable;
  /*import com.att.sa.highlandPark.config.HpConfigContext;
  import com.att.sa.highlandPark.config.HpReaderException;
  import com.att.sa.highlandPark.events.HpJsonEvent;
@@@ -88,7 -88,7 +88,7 @@@ public class CambriaOutboundEventStrea
                private boolean fWithMeta;
                ArrayList<Consumer> fKafkaConsumerList;
  
-               // private int fOffset;
+               
                /**
                 * constructor it initializes all the consumer parameters
                 * 
                 */
                public Builder(Consumer c) {
                        this.fConsumer = c;
-                       // this.fSettings = settings;
+                       
  
                        fLimit = CambriaConstants.kNoTimeout;
                        fTimeoutMs = CambriaConstants.kNoLimit;
                        fTopicFilter = CambriaConstants.kNoFilter;
                        fPretty = false;
                        fWithMeta = false;
-                       //this.fKafkaConsumerList = consList;
+                       
                        // fOffset = CambriaEvents.kNextOffset;
                }
  
                }
  
                // public Builder atOffset ( int pos )
 -              // {
 +              
                // fOffset = pos;
                // return this;
                // }
                fConsumer = builder.fConsumer;
                fLimit = builder.fLimit;
                fTimeoutMs = builder.fTimeoutMs;
 -              // fSettings = builder.fSettings;
 +              
                fSent = 0;
                fPretty = builder.fPretty;
                fWithMeta = builder.fWithMeta;
                 * @param msg
                 * @throws IOException
                 */
 -              // void onMessage(int count, Message msg) throws IOException;
 +              
                void onMessage(int count, String msg, String transId, long offSet) throws IOException, JSONException;
        }
  
         *            throws IOException
         */
        public void write(final OutputStream os) throws IOException {
 -              // final boolean transactionEnabled = topic.isTransactionEnabled();
 +              
                // final boolean transactionEnabled = isTransEnabled();
                // final boolean transactionEnabled = istransEnable;
                // synchronized(this){
                                        entry.put("message", msg);
                                        os.write(entry.toString().getBytes());
                                } else {
 -                                      // os.write(message.getBytes());
 +                                      
                                                String jsonString = JSONObject.valueToString(msg);
                                        os.write(jsonString.getBytes());
                                }
                                        try {
                                                if (istransEnable && istransType) {
                                                        // final String transactionId =
 -                                                      // jsonMessage.getString("transactionId");
 +                                                      
                                                        // responseTransactionId = transId;
                                                        StringBuilder consumerInfo = new StringBuilder();
                                                        if (null != dmaapContext && null != dmaapContext.getRequest()) {
                        }
                });
  
 -              // if (null != dmaapContext && isTransactionEnabled()) {
 +              
                if (null != dmaapContext && istransEnable && istransType) {
  
                        dmaapContext.getResponse().setHeader("transactionId",
                if (null != strclose_out_stream)
                        close_out_stream = Boolean.parseBoolean(strclose_out_stream);
  
 -              // if (fSettings.getBoolean("close.output.stream", true)) {
 +              
                if (close_out_stream) {
                        os.close();
 -                      // }
 +                      
                }
        }
  
         * 
         * Checks whether filter is initialized
         */
 -      /*private boolean isFilterInitialized() {
 -              return (fHpAlarmFilter != null && fHppe != null);
 -      }
 -*/
 +      
 +              
 +      
 +
        /**
         * 
         * @param msg
         */
        private boolean filterMatches(String msg) {
                boolean result = true;
 -              /*if (isFilterInitialized()) {
 -                      try {
 -                              final HpJsonEvent e = new HpJsonEvent("e", new JSONObject(msg));
 -                              result = fHpAlarmFilter.matches(fHppe, e);
 -                      } catch (JSONException x) {
 -                              // the msg may not be JSON
 -                              result = false;
 -                              log.error("Failed due to " + x.getMessage());
 -                      } catch (Exception x) {
 -                              log.error("Error using filter: " + x.getMessage(), x);
 -                      }
 -              }*/
 +              
 +              
 +                              
 +                              
 +                      
 +                      
 +                      
 +                              
 +                      
 +                              
 +              
 +      
  
                return result;
        }
        private final Consumer fConsumer;
        private final int fLimit;
        private final int fTimeoutMs;
 -      // private final rrNvReadable fSettings;
 +      
        private final boolean fPretty;
        private final boolean fWithMeta;
        private int fSent;
 -//    private final HpAlarmFilter<HpJsonEvent> fHpAlarmFilter;
 +
        //private final HpProcessingEngine<HpJsonEvent> fHppe;
        private DMaaPContext dmaapContext;
        private String responseTransactionId;
        private ArrayList<Consumer> fKafkaConsumerList;
        private boolean istransType = true;
        // private static final Logger log =
 -      // Logger.getLogger(CambriaOutboundEventStream.class);
 +      
  
        private static final EELFLogger log = EELFManager.getInstance().getLogger(CambriaOutboundEventStream.class);
  }