Code Review / dmaap / messagerouter / dmaapclient.git / log
? search:
summary | shortlog | log | commit | commitdiff | review | tree
first ⋅ prev ⋅ next
dmaap/messagerouter/dmaapclient.git
5 years agoFix for a license issue 82/71482/1 casablanca 1.1.9
commit | commitdiff | tree
sunil unnava [Tue, 30 Oct 2018 16:28:04 +0000 (12:28 -0400)]
Fix for a license issue

Issue-ID: DMAAP-871
Change-Id: I648ae0e476a8a2a07e688637e85871afee125ace
Signed-off-by: sunil unnava <sunil.unnava@att.com>
5 years agoupdate oparent to 1.2.1 27/71327/1
commit | commitdiff | tree
sunil unnava [Fri, 26 Oct 2018 16:17:29 +0000 (12:17 -0400)]
update oparent to 1.2.1

Issue-ID: DMAAP-791
Change-Id: I2807172636c2ec815f15ef15a56f58b0ce25ba05
Signed-off-by: sunil unnava <sunil.unnava@att.com>
5 years agoupdate the package name 64/71064/1
commit | commitdiff | tree
sunil unnava [Tue, 23 Oct 2018 14:31:46 +0000 (10:31 -0400)]
update the package name

Issue-ID: DMAAP-858
Change-Id: Ia69621ea6ad2ec2ec525800af2a7d3f73aef82ed
Signed-off-by: sunil unnava <sunil.unnava@att.com>
5 years agoone more case added in DmaapClientUtilTest.java 93/69993/1
commit | commitdiff | tree
asgar [Mon, 8 Oct 2018 14:44:31 +0000 (20:14 +0530)]
one more case added in DmaapClientUtilTest.java

Change-Id: Ifaa597832166063a16f5b27c5cc9ad390dbe41b1
Issue-ID: DMAAP-838
Signed-off-by: Mohamed Asgar Samiulla <sammoham@in.ibm.com>
5 years agoMerge "test file added for DmaapClientUtil.java"
commit | commitdiff | tree
Ram Koya [Mon, 8 Oct 2018 12:51:21 +0000 (12:51 +0000)]
Merge "test file added for DmaapClientUtil.java"

5 years agotest file added for DmaapClientUtil.java 85/69985/1
commit | commitdiff | tree
asgar [Mon, 8 Oct 2018 12:33:31 +0000 (18:03 +0530)]
test file added for DmaapClientUtil.java

Change-Id: Ic26fb72f380aa200042ee4f2b9688887bb9ad260
Issue-ID: DMAAP-838
Signed-off-by: Mohamed Asgar Samiulla <sammoham@in.ibm.com>
5 years agofew more cases added to validatorutil.java 09/69809/2
commit | commitdiff | tree
asgar [Thu, 4 Oct 2018 10:36:43 +0000 (16:06 +0530)]
few more cases added to validatorutil.java

Change-Id: I544bec8b1da6f3fcc601eed109af923d0d97a3de
Issue-ID: DMAAP-809
Signed-off-by: Mohamed Asgar Samiulla <sammoham@in.ibm.com>
5 years agoadded some more test cases for ValidatorUtil.java 21/69721/1
commit | commitdiff | tree
asgar [Wed, 3 Oct 2018 08:47:38 +0000 (14:17 +0530)]
added some more test cases for ValidatorUtil.java

Change-Id: I5b64b56f4d1cb713547d4c8ac121188932eaf4c2
Issue-ID: DMAAP-809
Signed-off-by: Mohamed Asgar Samiulla <sammoham@in.ibm.com>
5 years agoadded couple of cases for ValidatorUtil.java 33/69333/1
commit | commitdiff | tree
asgar [Thu, 27 Sep 2018 14:24:29 +0000 (19:54 +0530)]
added couple of cases for ValidatorUtil.java

Change-Id: I9be3ab9ef2b745c3b2fc54ff73a780fec176ec40
Issue-ID: DMAAP-809
Signed-off-by: Mohamed Asgar Samiulla <sammoham@in.ibm.com>
5 years agoadded some more test cases ValidatorUtilTest.java 11/68911/1
commit | commitdiff | tree
asgar [Tue, 25 Sep 2018 16:06:19 +0000 (21:36 +0530)]
added some more test cases ValidatorUtilTest.java

Change-Id: Ia7a240aad73eff0c6d9944f845125677e6e5611b
Issue-ID: DMAAP-809
Signed-off-by: Mohamed Asgar Samiulla <sammoham@in.ibm.com>
5 years agoTest cases added for ValidatorUtil.java 97/68097/1
commit | commitdiff | tree
asgar [Thu, 20 Sep 2018 12:40:23 +0000 (18:10 +0530)]
Test cases added for ValidatorUtil.java

Change-Id: I56e3559f56e1da8143e290d4d1748da2ceaf650d
Issue-ID: DMAAP-809
Signed-off-by: Mohamed Asgar Samiulla <sammoham@in.ibm.com>
5 years agoMerge "Use managed guava version"
commit | commitdiff | tree
Ram Koya [Wed, 19 Sep 2018 02:25:59 +0000 (02:25 +0000)]
Merge "Use managed guava version"

5 years agosonar fixes in MRClientFactory.java 97/66597/1
commit | commitdiff | tree
asgar [Fri, 14 Sep 2018 09:45:54 +0000 (15:15 +0530)]
sonar fixes in MRClientFactory.java

Change-Id: Ic01e466f2a64bb02b614b48d13de65a7a48a8e74
Issue-ID: DMAAP-777
Signed-off-by: Mohamed Asgar Samiulla <sammoham@in.ibm.com>
5 years agocouple of fixes in MRClientBuilders.java 19/66019/1
commit | commitdiff | tree
asgar [Wed, 12 Sep 2018 08:22:24 +0000 (13:52 +0530)]
couple of fixes in MRClientBuilders.java

Change-Id: Iad8229ec47c2fc08390f203edeb51acd74058e61
Issue-ID: DMAAP-770
Signed-off-by: Mohamed Asgar Samiulla <sammoham@in.ibm.com>
5 years agoFix the typo error in the error message 57/64057/1 1.1.8
commit | commitdiff | tree
sunil unnava [Fri, 31 Aug 2018 18:39:10 +0000 (14:39 -0400)]
Fix the typo error in the error message

Issue-ID: DMAAP-688
Change-Id: I5457bf0829fa509e932e2e814ed4b9e9a21ce2e5
Signed-off-by: sunil unnava <su622b@att.com>
5 years agoRemove the username/password check 15/64015/1
commit | commitdiff | tree
sunil unnava [Fri, 31 Aug 2018 15:05:31 +0000 (11:05 -0400)]
Remove the username/password check

Issue-ID: DMAAP-689
Change-Id: I1b6528bd3aaa2d9d117d0970444123a3c93ac597
Signed-off-by: sunil unnava <su622b@att.com>
5 years agoFixes for NullpointerExceptiones 95/63895/1 1.1.7
commit | commitdiff | tree
sunil unnava [Thu, 30 Aug 2018 20:25:20 +0000 (16:25 -0400)]
Fixes for NullpointerExceptiones

Issue-ID: DMAAP-686
Change-Id: Ida4c81c05399387009ca5ba39b659da1cb94c210
Signed-off-by: sunil unnava <su622b@att.com>
5 years agoupdate patch version in version.properties 19/63119/1
commit | commitdiff | tree
sunil unnava [Mon, 27 Aug 2018 19:14:11 +0000 (15:14 -0400)]
update patch version in version.properties

Issue-ID: DMAAP-628
Change-Id: Iad9e821dfa8ade5e15224b16a9d53e590c1aced0
Signed-off-by: sunil unnava <su622b@att.com>
5 years agoUse managed guava version 23/62623/2
commit | commitdiff | tree
Gary Wu [Fri, 24 Aug 2018 22:22:40 +0000 (15:22 -0700)]
Use managed guava version

Use centrally managed guava version specified in
oparent.  Includes upgrade to oparent 1.2.0.

This change was submitted by script and may include
additional whitespace or formatting changes.

Change-Id: I2b9a2311c7c5d23406923c8d056fb8da8ae6a9be
Issue-ID: INT-619
Signed-off-by: Gary Wu <gary.i.wu@huawei.com>
5 years agoSonar major issues 63/62063/1
commit | commitdiff | tree
Surendra Reddy Katam [Thu, 23 Aug 2018 11:15:36 +0000 (16:45 +0530)]
Sonar major issues

 Replace the type specification in this constructor call with the diamond operator
Sonar Link:
https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.dmaapclient%3AdmaapClient&open=AV4-MbUO32hFUzlqc5g5&resolved=false&severities=MAJOR
Location:
src/main/java/com/att/nsa/mr/test/support/MRBatchingPublisherMock.java
Line No- L54 L88 L154 L178

Change-Id: I74e590275efd6221f6395a9a28d4e73a0bb643a4
Issue-ID: DMAAP-633
Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
5 years agoSonar major issues 55/62055/1
commit | commitdiff | tree
Surendra Reddy Katam [Thu, 23 Aug 2018 10:41:34 +0000 (16:11 +0530)]
Sonar major issues

 This block of commented-out lines of code should be removed
Sonar Link:
https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.dmaapclient%3AdmaapClient&open=AV4-MbSz32hFUzlqc5fZ&resolved=false&severities=MAJOR
Location:
src/main/java/com/att/nsa/mr/dme/client/SimpleExamplePublisher.java
Line No-125

Change-Id: I91d794bfea573e97831c773d4f7782998b08f76e
Issue-ID: DMAAP-632
Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
5 years agoSonar major issues 81/61981/1
commit | commitdiff | tree
Surendra Reddy Katam [Thu, 23 Aug 2018 06:13:43 +0000 (11:43 +0530)]
Sonar major issues

 Replace the type specification in this constructor call with the diamond operator
Sonar Link:
https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.dmaapclient%3AdmaapClient&open=AV4-MbUW32hFUzlqc5hE&resolved=false&severities=MAJOR
Location:
src/main/java/com/att/nsa/mr/test/support/MRConsumerMock.java
Line No- L50 L87 L117 L129

Change-Id: Iaf782f51002731df3e7b64b0b71d76057ab416d0
Issue-ID: DMAAP-631
Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
5 years agoSonar major issues 73/61973/1
commit | commitdiff | tree
Surendra Reddy Katam [Thu, 23 Aug 2018 05:49:16 +0000 (11:19 +0530)]
Sonar major issues

 Replace the type specification in this constructor call with the diamond operator
Sonar Link:
https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.dmaapclient%3AdmaapClient&open=AV4-MbU432hFUzlqc5hp&resolved=false&severities=MAJOR
Location:
src/main/java/com/att/nsa/mr/tools/MRCommandContext.java
Line No- L39 L65

Change-Id: Ia158fb6890cfd5e5d8675ee144ca3119e097cb89
Issue-ID: DMAAP-630
Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
5 years agoSonar major issues 61/61961/1
commit | commitdiff | tree
Surendra Reddy Katam [Thu, 23 Aug 2018 05:36:13 +0000 (11:06 +0530)]
Sonar major issues

 Use isEmpty() to check whether the collection is empty or not
Sonar Link:
https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.dmaapclient%3AdmaapClient&open=AV4-MbU532hFUzlqc5hw&resolved=false&severities=MAJOR
Location:
src/main/java/com/att/nsa/mr/tools/MRCommandContext.java
Line No-60

Change-Id: I5b579fc3648c422762cae9852a1f65af613d4a7e
Issue-ID: DMAAP-629
Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
5 years agoSonar major issues 19/61519/1
commit | commitdiff | tree
Surendra Reddy Katam [Tue, 21 Aug 2018 09:28:19 +0000 (14:58 +0530)]
Sonar major issues

 Use isEmpty() to check whether the collection is empty or not
Sonar Link:
https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.dmaapclient%3AdmaapClient&open=AV4-MbTf32hFUzlqc5gL&resolved=false&severities=MAJOR
Location:
src/main/java/com/att/nsa/mr/test/clients/SamplePublisher.java
Line No- L77 L45

Change-Id: I240d7411f80a644b119f28271bf9ee13298f770f
Issue-ID: DMAAP-620
Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
5 years agoSonar major issues 85/61485/1
commit | commitdiff | tree
Surendra Reddy Katam [Tue, 21 Aug 2018 07:18:19 +0000 (12:48 +0530)]
Sonar major issues

 Use isEmpty() to check whether the collection is empty or not
Sonar Link:
https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.dmaapclient%3AdmaapClient&open=AV4-MbVF32hFUzlqc5h5&resolved=false&rules=squid%3AS1155&severities=MAJOR
Location:
src/main/java/com/att/nsa/mr/tools/MessageCommand.java
Line No-116

Change-Id: I0ffaf59ffef7638642b4ce9997c56974c2190d31
Issue-ID: DMAAP-619
Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
5 years agoSonar major issues 83/61483/1
commit | commitdiff | tree
Surendra Reddy Katam [Tue, 21 Aug 2018 06:51:48 +0000 (12:21 +0530)]
Sonar major issues

 Use isEmpty() to check whether the collection is empty or not
Sonar Link:
https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.dmaapclient%3AdmaapClient&open=AV4-MbT632hFUzlqc5gr&resolved=false&severities=MAJOR
Location:
src/main/java/com/att/nsa/mr/test/clients/SimpleExamplePublisher.java
Line No- L57 L62 L71

Change-Id: I4ac3ebea88d03147a54676cd5f9c77f274dfd87a
Issue-ID: DMAAP-617
Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
5 years agoMerge "Sonar major issues"
commit | commitdiff | tree
Ram Koya [Mon, 20 Aug 2018 18:12:13 +0000 (18:12 +0000)]
Merge "Sonar major issues"

5 years agoSonar major issues 43/61243/1
commit | commitdiff | tree
Surendra Reddy Katam [Mon, 20 Aug 2018 09:55:10 +0000 (15:25 +0530)]
Sonar major issues

 Replace the type specification in this constructor call with the diamond operator
Sonar Link:
https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.dmaapclient%3AdmaapClient&open=AV4-MbTX32hFUzlqc5f3&resolved=false&severities=MAJOR
Location:
src/main/java/com/att/nsa/mr/test/clients/SampleConsumer.java
Line No- L44 L52

Change-Id: I3a2e2ce61aa27107bb4f70c22cd1b6fd5df6af21
Issue-ID: DMAAP-615
Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
5 years agoMerge changes Ie8852caf,I9e9d1156
commit | commitdiff | tree
Ram Koya [Thu, 16 Aug 2018 16:50:05 +0000 (16:50 +0000)]
Merge changes Ie8852caf,I9e9d1156

* changes:
  Sonar major issues
  Sonar major issues

5 years agoMerge "Sonar major issues"
commit | commitdiff | tree
Ram Koya [Thu, 16 Aug 2018 16:36:52 +0000 (16:36 +0000)]
Merge "Sonar major issues"

5 years agoSonar major issues 93/60893/1
commit | commitdiff | tree
Surendra Reddy Katam [Thu, 16 Aug 2018 11:02:22 +0000 (16:32 +0530)]
Sonar major issues

 This block of commented-out lines of code should be removed
Sonar Link:
https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.dmaapclient%3AdmaapClient&open=AV4-MbSM32hFUzlqc5es&resolved=false&severities=MAJOR
Location:
src/main/java/com/att/nsa/mr/dme/client/DefaultLoggingFailoverFaultHandler.java
Line No-L24 L29 L37 L40 L47 L50

Change-Id: I1ce6b3d5024c262e89db5c487a47ee006fd6eb30
Issue-ID: DMAAP-608
Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
5 years agoSonar major issues 83/60883/1
commit | commitdiff | tree
Surendra Reddy Katam [Thu, 16 Aug 2018 09:49:13 +0000 (15:19 +0530)]
Sonar major issues

 This block of commented-out lines of code should be removed
Sonar Link:
https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.dmaapclient%3AdmaapClient&open=AV4-MbSb32hFUzlqc5e5&resolved=false&severities=MAJOR
Location:
src/main/java/com/att/nsa/mr/dme/client/PreferredRouteReplyHandler.java
Line No-59

Change-Id: I7cd496f4f7901fc2d0e84fbe4d52943a28988db7
Issue-ID: DMAAP-607
Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
5 years agoSonar major issues 79/60879/1
commit | commitdiff | tree
Surendra Reddy Katam [Thu, 16 Aug 2018 09:18:07 +0000 (14:48 +0530)]
Sonar major issues

 This block of commented-out lines of code should be removed
Sonar Link:
https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.dmaapclient%3AdmaapClient&open=AV4-MbST32hFUzlqc5ex&resolved=false&severities=MAJOR
Location:
src/main/java/com/att/nsa/mr/dme/client/HeaderReplyHandler.java
Line No-51

Change-Id: I14afd297b87f473eb5674280e961cb4c06179f3c
Issue-ID: DMAAP-606
Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
5 years agoSonar major issues 73/60873/1
commit | commitdiff | tree
Surendra Reddy Katam [Thu, 16 Aug 2018 08:59:46 +0000 (14:29 +0530)]
Sonar major issues

 This block of commented-out lines of code should be removed
Sonar Link:
https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.dmaapclient%3AdmaapClient&open=AV4-MbST32hFUzlqc5ew&resolved=false&severities=MAJOR
Location:
src/main/java/com/att/nsa/mr/dme/client/HeaderReplyHandler.java
Line No-47

Change-Id: I84f659bc4ebd37f35f3e9e84f218878c059e19e4
Issue-ID: DMAAP-605
Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
5 years agoSonar major issues 55/60855/1
commit | commitdiff | tree
Surendra Reddy Katam [Thu, 16 Aug 2018 06:58:52 +0000 (12:28 +0530)]
Sonar major issues

 Use isEmpty() to check whether the collection is empty or not
Sonar Link:
https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.dmaapclient%3AdmaapClient&open=AV4-MbRu32hFUzlqc5ej&resolved=false&severities=MAJOR
Location:
src/main/java/com/att/nsa/mr/client/impl/MRSimplerBatchPublisher.java
Line No-421

Change-Id: Ie8852caff9e0130aa9b69c4a410bf3949c66713f
Issue-ID: DMAAP-604
Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
5 years agoSonar major issues 39/60839/1
commit | commitdiff | tree
Surendra Reddy Katam [Thu, 16 Aug 2018 05:46:55 +0000 (11:16 +0530)]
Sonar major issues

 This block of commented-out lines of code should be removed
Sonar Link:
https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.dmaapclient%3AdmaapClient&open=AV4-MbSS32hFUzlqc5ev&resolved=false&severities=MAJOR
Location:
src/main/java/com/att/nsa/mr/dme/client/HeaderReplyHandler.java
Line No-38

Change-Id: I9e9d1156a7852a9ffdea95b5eb4d40fddbd29f06
Issue-ID: DMAAP-602
Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
5 years agoSonar major issues 27/60427/1
commit | commitdiff | tree
Surendra Reddy Katam [Tue, 14 Aug 2018 05:16:31 +0000 (10:46 +0530)]
Sonar major issues

 Use isEmpty() to check whether the collection is empty or not
Sonar Link:
https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.dmaapclient%3AdmaapClient&open=AV4-MbRu32hFUzlqc5ei&resolved=false&severities=MAJOR
Location:
src/main/java/com/att/nsa/mr/client/impl/MRSimplerBatchPublisher.java
Line No-238

Change-Id: I7896ced67ab12816b92fe972322dad4ff4558cf8
Issue-ID: DMAAP-589
Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
5 years agoMerge "Sonar major issues"
commit | commitdiff | tree
Ram Koya [Mon, 13 Aug 2018 17:27:13 +0000 (17:27 +0000)]
Merge "Sonar major issues"

5 years agoSonar major issues 19/60219/1
commit | commitdiff | tree
Surendra Reddy Katam [Mon, 13 Aug 2018 07:27:46 +0000 (12:57 +0530)]
Sonar major issues

 This block of commented-out lines of code should be removed

Sonar Link:
https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.dmaapclient%3AdmaapClient&open=AWFBqtmH-08if2a6yPKL&resolved=false&severities=MAJOR
Location:
src/main/java/com/att/nsa/mr/client/impl/MRSimplerBatchPublisher.java
Line No-738

Change-Id: If1e94d7325011eb8acbc9fe25521675be7c7f10b
Issue-ID: DMAAP-588
Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
5 years agoSonar major issues 15/60215/1
commit | commitdiff | tree
Surendra Reddy Katam [Mon, 13 Aug 2018 07:16:57 +0000 (12:46 +0530)]
Sonar major issues

 This block of commented-out lines of code should be removed

Sonar Link:
https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.dmaapclient%3AdmaapClient&open=AWEpWaiz-08if2a6yEXI&resolved=false&severities=MAJOR
Location:
src/main/java/com/att/nsa/mr/client/impl/MRSimplerBatchPublisher.java
Line No-750

Change-Id: I92e78361839e919776a756fa3280a4d89070b8b9
Issue-ID: DMAAP-587
Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
5 years agoSonar major issues 11/60211/1
commit | commitdiff | tree
Surendra Reddy Katam [Mon, 13 Aug 2018 07:03:28 +0000 (12:33 +0530)]
Sonar major issues

 This block of commented-out lines of code should be removed
Sonar Link:
https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.dmaapclient%3AdmaapClient&open=AWE8fZBk-08if2a6yLVv&resolved=false&severities=MAJOR
Location:
src/main/java/com/att/nsa/mr/client/impl/MRSimplerBatchPublisher.java
Line No-301

Change-Id: Iacbd0033271e8ce5391d3f06ad50c160a5f24cb3
Issue-ID: DMAAP-586
Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
5 years agoSonar major issues 01/60201/1
commit | commitdiff | tree
Surendra Reddy Katam [Mon, 13 Aug 2018 06:39:32 +0000 (12:09 +0530)]
Sonar major issues

 This block of commented-out lines of code should be removed
Sonar Link:
https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.dmaapclient%3AdmaapClient&open=AV4-MbRo32hFUzlqc5dp&resolved=false&severities=MAJOR
Location:
src/main/java/com/att/nsa/mr/client/impl/MRSimplerBatchPublisher.java
Line No-797

Change-Id: I144634a122d5f9997ed74d324661f3950e36886c
Issue-ID: DMAAP-585
Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
5 years agoSonar major issues 97/60197/1
commit | commitdiff | tree
Surendra Reddy Katam [Mon, 13 Aug 2018 05:52:11 +0000 (11:22 +0530)]
Sonar major issues

 Use isEmpty() to check whether the collection is empty or not

Sonar Link:
https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.dmaapclient%3AdmaapClient&open=AV4-MbRu32hFUzlqc5eg&resolved=false&severities=MAJOR
Location:
src/main/java/com/att/nsa/mr/client/impl/MRSimplerBatchPublisher.java
Line No-180

Change-Id: I7f191d42a87ba5e70005ad282d3d8bbda71998f4
Issue-ID: DMAAP-584
Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
5 years agoSonar major issues 65/59965/1
commit | commitdiff | tree
Surendra Reddy Katam [Fri, 10 Aug 2018 07:10:10 +0000 (12:40 +0530)]
Sonar major issues

 This block of commented-out lines of code should be removed
Sonar Link:
https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.dmaapclient%3AdmaapClient&open=AV4-MbQH32hFUzlqc5YO&resolved=false&severities=MAJOR
Location:
src/main/java/com/att/nsa/mr/client/impl/MRBaseClient.java
Line No-330

Change-Id: Ide8bc7472363646d5f73d8ae94f1d3b7ce3a1865
Issue-ID: DMAAP-576
Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
5 years agoSonar major issues 33/59833/1
commit | commitdiff | tree
Surendra Reddy Katam [Thu, 9 Aug 2018 10:17:10 +0000 (15:47 +0530)]
Sonar major issues

 Use isEmpty() to check whether the collection is empty or not
Sonar Link:
https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.dmaapclient%3AdmaapClient&open=AV4-MbQb32hFUzlqc5Zk&resolved=false&severities=MAJOR
Location:
src/main/java/com/att/nsa/mr/client/impl/MRBatchPublisher.java
Line No-137

Change-Id: Ia3464cd19af992d4d48885e5a2dc4a75b726f9e7
Issue-ID: DMAAP-574
Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
5 years agoSonar major issues 29/59829/1
commit | commitdiff | tree
Surendra Reddy Katam [Thu, 9 Aug 2018 09:58:02 +0000 (15:28 +0530)]
Sonar major issues

 This block of commented-out lines of code should be removed
Sonar link:
https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.dmaapclient%3AdmaapClient&open=AWQDL3zlwGn37Jfbsse6&resolved=false&severities=MAJOR
Location:
src/main/java/com/att/nsa/mr/client/MRClientFactory.java
Line No-525

Change-Id: I1a80b95e4606acdfa62e529aef7c41578a42792e
Issue-ID: DMAAP-525
Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
5 years agoSonar major issues 97/59797/1
commit | commitdiff | tree
Surendra Reddy Katam [Thu, 9 Aug 2018 07:40:41 +0000 (13:10 +0530)]
Sonar major issues

 This block of commented-out lines of code should be removed
SonarLink:
https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.dmaapclient%3AdmaapClient&open=AV4-MbQH32hFUzlqc5YO&resolved=false&severities=MAJOR
Location:
 src/main/java/com/att/nsa/mr/client/impl/MRBaseClient.java
Line No-338

Change-Id: I3504b07bb4bf281477000dfee48d4a7b00c23833
Issue-ID: DMAAP-572
Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
5 years agoSonar major issues 09/59609/1
commit | commitdiff | tree
Surendra Reddy Katam [Wed, 8 Aug 2018 07:17:14 +0000 (12:47 +0530)]
Sonar major issues

 Use isEmpty() to check whether the collection is empty or not
Sonar Link:
https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.dmaapclient%3AdmaapClient&open=AV4-MbOi32hFUzlqc5Vg&resolved=false&severities=MAJOR
Location:
src/main/java/com/att/nsa/mr/client/HostSelector.java
Line No-130

Change-Id: Iab107c06d9463f42d34d98fff1073b4a358f7681
Issue-ID: DMAAP-567"
Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
5 years agoSonar critical issues 31/59331/1
commit | commitdiff | tree
Surendra Reddy Katam [Tue, 7 Aug 2018 06:51:54 +0000 (12:21 +0530)]
Sonar critical issues

 This block of commented-out lines of code should be removed
Sounar Link:
https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.dmaapclient%3AdmaapClient&open=AWE8fY_t-08if2a6yLVP&resolved=false&severities=MAJOR
Location:
src/main/java/com/att/nsa/mr/client/impl/MRBaseClient.java
Line No-327

Change-Id: I236ab91295afa11a7a0db9409bd00b6e3e4b4034
Issue-ID: DMAAP-563
Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
5 years agoMerge "Use try-with-resources"
commit | commitdiff | tree
Ram Koya [Tue, 24 Jul 2018 16:41:42 +0000 (16:41 +0000)]
Merge "Use try-with-resources"

5 years agoFix bug with host failover functionality 03/56103/2
commit | commitdiff | tree
Lee, Tian (tl5884) [Tue, 10 Jul 2018 14:03:19 +0000 (15:03 +0100)]
Fix bug with host failover functionality

DMaaP client does not failover to next configured host when the current
host returns an error status during event consumption.

Change-Id: I117ab993c3badea819876943e446d9ab45fd2db8
Issue-ID: DMAAP-541
Signed-off-by: Lee, Tian (tl5884) <TianL@amdocs.com>
5 years agoFix various Sonar issues in MRConsumerImpl 99/56099/3
commit | commitdiff | tree
Lee, Tian (tl5884) [Tue, 10 Jul 2018 13:15:52 +0000 (14:15 +0100)]
Fix various Sonar issues in MRConsumerImpl

Amendment 1: Restructure order of methods and fields according to Java convention.
Amendment 2: Remove bug fix that was accidentally included. This will be committed in a separate commit.

These changes do not affect the original functionality of the class.

Change-Id: I974a5e3fa94ca184704c4e26636bcbbfb5ce3320
Issue-ID: DMAAP-540
Signed-off-by: Lee, Tian (tl5884) <TianL@amdocs.com>
5 years agoUse try-with-resources 53/56053/1
commit | commitdiff | tree
Arindam Mondal [Tue, 10 Jul 2018 07:45:42 +0000 (16:45 +0900)]
Use try-with-resources

Issue-ID: DMAAP-539
Change-Id: Ic2c2eeb4ada3e05de695d108de37129a8aa39ad1
Signed-off-by: Arindam Mondal <arind.mondal@samsung.com>
5 years agoJUnit against ToolsUtil 31/55131/2
commit | commitdiff | tree
Marcin Migdal [Wed, 20 Jun 2018 12:56:52 +0000 (14:56 +0200)]
JUnit against ToolsUtil
Found missing one

Change-Id: Iee604b30e9b2dcdb88f42916b1be01bf3de965fe
Issue-ID: DMAAP-518
Signed-off-by: Marcin Migdal <marcin.migdal@nokia.com>
5 years agofixes for null pointer exceptions 93/54893/1
commit | commitdiff | tree
sunil unnava [Thu, 14 Jun 2018 22:05:40 +0000 (18:05 -0400)]
fixes for null pointer exceptions

Issue-ID: DMAAP-519
Change-Id: Ia32d0bd58c5f438b50e361221a96b988b00a1120
Signed-off-by: sunil unnava <su622b@att.com>
6 years agosupport for post requests with auth 65/42365/1 2.0.0-ONAP beijing 2.0.0-ONAP
commit | commitdiff | tree
su622b [Wed, 11 Apr 2018 23:56:37 +0000 (19:56 -0400)]
support for post requests with auth

Issue-ID: DMAAP-404
Change-Id: Iaa85ab5410472fca4dd6118d2a53efc1737609d5
Signed-off-by: su622b <sunil.unnava@att.com>
6 years agoMerge "Sonar critical issues"
commit | commitdiff | tree
varun gudisena [Mon, 9 Apr 2018 23:33:50 +0000 (23:33 +0000)]
Merge "Sonar critical issues"

6 years agoMerge "Sonar critical issues"
commit | commitdiff | tree
varun gudisena [Mon, 9 Apr 2018 23:22:21 +0000 (23:22 +0000)]
Merge "Sonar critical issues"

6 years agoMerge "Sonar critical issues"
commit | commitdiff | tree
varun gudisena [Mon, 9 Apr 2018 23:21:27 +0000 (23:21 +0000)]
Merge "Sonar critical issues"

6 years agoSupport for post without auth 29/41829/1 v1.1.5
commit | commitdiff | tree
su622b [Mon, 9 Apr 2018 22:51:28 +0000 (18:51 -0400)]
Support for post without auth

Issue-ID: DMAAP-399
Change-Id: I51f1ff8ed978e3e00fccd63edf421c794f6e7f32
Signed-off-by: su622b <sunil.unnava@att.com>
6 years agoSupport for post without auth 85/41785/1
commit | commitdiff | tree
su622b [Mon, 9 Apr 2018 18:47:27 +0000 (14:47 -0400)]
Support for post without auth

Issue-ID: DMAAP-399
Change-Id: I0e769c5554a8adf7a606bebe1c23b35fbab9c82c
Signed-off-by: su622b <sunil.unnava@att.com>
6 years agoSonar critical issues 19/41719/1
commit | commitdiff | tree
Surendra Reddy Katam [Mon, 9 Apr 2018 12:38:49 +0000 (18:08 +0530)]
Sonar critical issues

 Define and throw a dedicated exception instead of using a generic one
Sonar Link:
https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.dmaapclient%3AdmaapClient&open=AV4-MbUC32hFUzlqc5gx&resolved=false&severities=CRITICAL
Location:
src/main/java/com/att/nsa/mr/test/clients/SimpleExamplePublisherWithResponse.java
Line No-64

Change-Id: Ifc25038de09c95af253e40baa946a4aca9af66fb
Issue-ID: DMAAP-397
Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
6 years agoFixes for response parsing errors 17/41417/1 v1.1.4
commit | commitdiff | tree
su622b [Fri, 6 Apr 2018 17:19:14 +0000 (13:19 -0400)]
Fixes for response parsing errors

Issue-ID: DMAAP-396
Change-Id: I2d8fa85dfe5246d76cf4e2066f4c5e6859c4440f
Signed-off-by: su622b <sunil.unnava@att.com>
6 years agoSonar critical issues 55/41355/1
commit | commitdiff | tree
Surendra Reddy Katam [Fri, 6 Apr 2018 10:18:33 +0000 (15:48 +0530)]
Sonar critical issues

 Define and throw a dedicated exception instead of using a generic one
Sonar Link:
https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.dmaapclient%3AdmaapClient&open=AV4-MbT632hFUzlqc5gn&resolved=false&severities=CRITICAL
Location:
src/main/java/com/att/nsa/mr/dme/client/SimpleExamplePublisher.java
Line No-49

Change-Id: Ic2e6f3634cd63906accfa6e6cb594506cffc4ab9
Issue-ID: DMAAP-395
Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
6 years agoSonar critical issues 15/41315/1
commit | commitdiff | tree
Surendra Reddy Katam [Fri, 6 Apr 2018 05:19:00 +0000 (10:49 +0530)]
Sonar critical issues

 Either re-interrupt this method or rethrow the InterruptedException
Sonar Link:
https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.dmaapclient%3AdmaapClient&open=AV4-MbRr32hFUzlqc5eI&resolved=false&severities=CRITICAL
Location:
src/main/java/com/att/nsa/mr/client/impl/MRSimplerBatchPublisher.java
Line No-174

Change-Id: Ic9fd4b13bc0fd7c308b704f393b379f27b577391
Issue-ID: DMAAP-390
Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
6 years agoSonar critical issues 29/40929/1
commit | commitdiff | tree
Surendra Reddy Katam [Wed, 4 Apr 2018 10:52:02 +0000 (16:22 +0530)]
Sonar critical issues

 Define and throw a dedicated exception instead of using a generic one
Sonar Link:
https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.dmaapclient%3AdmaapClient&open=AV4-MbPQ32hFUzlqc5XF&resolved=false&severities=CRITICAL
Location:
src/main/java/com/att/nsa/mr/client/MRClientFactory.java
Line No-565

Change-Id: I4f5b03efd3cbc885680ded0ec6a496c60ecc793e
Issue-ID: DMAAP-385
Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
6 years agoSonar critical issues 97/40897/1
commit | commitdiff | tree
Surendra Reddy Katam [Wed, 4 Apr 2018 06:51:22 +0000 (12:21 +0530)]
Sonar critical issues

 Define and throw a dedicated exception instead of using a generic one
Sonar Link:
https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.dmaapclient%3AdmaapClient&open=AV4-MbO932hFUzlqc5WC&resolved=false&severities=CRITICAL
Location:
src/main/java/com/att/nsa/mr/client/MRClientBuilders.java
Line No-282

Change-Id: If2f14bde9756c3318cb98f4d6e352acf550dc20e
Issue-ID: DMAAP-384
Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
6 years agoSonar critical issues 91/40891/1
commit | commitdiff | tree
Surendra Reddy Katam [Wed, 4 Apr 2018 06:19:18 +0000 (11:49 +0530)]
Sonar critical issues

 Define and throw a dedicated exception instead of using a generic one
Sonar Link:
https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.dmaapclient%3AdmaapClient&open=AV4-MbQa32hFUzlqc5Zc&resolved=false&severities=CRITICAL
Location:
src/main/java/com/att/nsa/mr/client/impl/MRBatchPublisher.java
Line No-78

Change-Id: Idc4d8db66d4f2f9399885f940404d02aaeec35be
Issue-ID: DMAAP-383
Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
6 years agoSonar critical issues 89/40889/1
commit | commitdiff | tree
Surendra Reddy Katam [Tue, 3 Apr 2018 13:13:56 +0000 (18:43 +0530)]
Sonar critical issues

 Define and throw a dedicated exception instead of using a generic one
Sonar Link:
https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.dmaapclient%3AdmaapClient&open=AV4-MbQa32hFUzlqc5Zc&resolved=false&severities=CRITICAL
Location:
src/main/java/com/att/nsa/mr/client/impl/MRBatchPublisher.java
Line No-78

Change-Id: Ic9fa6e30b450ea1400be0cf8de237eeefdaeb34f
Issue-ID: DMAAP-383
Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
6 years agoSonar critical issues 85/40685/1
commit | commitdiff | tree
Surendra Reddy Katam [Tue, 3 Apr 2018 12:27:17 +0000 (17:57 +0530)]
Sonar critical issues

 Define and throw a dedicated exception instead of using a generic one
Sonar Link:
https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.dmaapclient%3AdmaapClient&open=AWEpWai0-08if2a6yEXQ&resolved=false&severities=CRITICAL
Location:
src/main/java/com/att/nsa/mr/client/impl/MRSimplerBatchPublisher.java
Line No-115

Change-Id: Icc1be632dc04090c0f8013e8aff0a51fe4dbb14c
Issue-ID: DMAAP-382
Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
6 years agoSonar critical issues 69/40669/1
commit | commitdiff | tree
Surendra Reddy Katam [Tue, 3 Apr 2018 09:50:54 +0000 (15:20 +0530)]
Sonar critical issues

 Define and throw a dedicated exception instead of using a generic one
Sonar Link:
https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.dmaapclient%3AdmaapClient&open=AV4-MbQp32hFUzlqc5Z2&resolved=false&severities=CRITICAL
Location:
src/main/java/com/att/nsa/mr/client/impl/MRConstants.java
Line No-47

Change-Id: If4112c62ebae83b70d6a6c657c07376738838af3
Issue-ID: DMAAP-381
Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
6 years agoSonar critical issues 63/40663/1
commit | commitdiff | tree
Surendra Reddy Katam [Tue, 3 Apr 2018 09:26:53 +0000 (14:56 +0530)]
Sonar critical issues

 Define and throw a dedicated exception instead of using a generic one
Sonar link:
https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.dmaapclient%3AdmaapClient&open=AV4-MbPQ32hFUzlqc5XH&resolved=false&severities=CRITICAL
Location:
src/main/java/com/att/nsa/mr/client/MRClientFactory.java
Line No-605

Change-Id: I4d2b43d8ae1585f6cd17b32d0c15987f9f5fe514
Issue-ID: DMAAP-380
Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
6 years agoSonar critical issues 03/40503/1
commit | commitdiff | tree
Surendra Reddy Katam [Mon, 2 Apr 2018 09:50:19 +0000 (15:20 +0530)]
Sonar critical issues

 Define and throw a dedicated exception instead of using a generic one
Sonar Link:
https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.dmaapclient%3AdmaapClient&open=AWE97JSU-08if2a6yOTq&resolved=false&severities=CRITICAL
Location:
src/main/java/com/att/nsa/mr/client/impl/MRSimplerBatchPublisher.java
Line No-108

Change-Id: I6a2cd881b55e49dc05cd6160a04ba5389eae9c65
Issue-ID: DMAAP-379
Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
6 years agoSonar critical issues 79/40479/1
commit | commitdiff | tree
Surendra Reddy Katam [Mon, 2 Apr 2018 05:45:06 +0000 (11:15 +0530)]
Sonar critical issues

 Define and throw a dedicated exception instead of using a generic one
Sonar Link:
https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.dmaapclient%3AdmaapClient&open=AWE8fY-w-08if2a6yLVJ&resolved=false&severities=CRITICAL
Location:
src/main/java/com/att/nsa/mr/client/MRClientFactory.java
Line No-587

Change-Id: Id1ee9768298af3f33cd67352e863a5f0f083ba64
Issue-ID: DMAAP-378
Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
6 years agoSonar critical issues 71/40471/1
commit | commitdiff | tree
Surendra Reddy Katam [Mon, 2 Apr 2018 05:08:36 +0000 (10:38 +0530)]
Sonar critical issues

 Define and throw a dedicated exception instead of using a generic one
Sonar Link:
https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.dmaapclient%3AdmaapClient&open=AV4-MbRs32hFUzlqc5eM&resolved=false&severities=CRITICAL
Location:
src/main/java/com/att/nsa/mr/client/impl/MRSimplerBatchPublisher.java
Line No-778

Change-Id: I3677fc5a44f66658c04dfcaefed974c748356bc9
Issue-ID: DMAAP-377
Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
6 years agoSonar critical issues 61/40361/1
commit | commitdiff | tree
Surendra Reddy Katam [Fri, 30 Mar 2018 10:49:02 +0000 (16:19 +0530)]
Sonar critical issues

 Define and throw a dedicated exception instead of using a generic one
Sonar Link:
https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.dmaapclient%3AdmaapClient&open=AWFShR4Oof9FJ6jfXJqo&resolved=false&severities=CRITICAL
Location:
src/main/java/com/att/nsa/mr/test/clients/SampleConsumer.java
Line No-84

Change-Id: Ic9fe6369a1b892e5b42760f569278fd09463a803
Issue-ID: DMAAP-373
Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
6 years agoSonar critical issues 55/40355/1
commit | commitdiff | tree
Surendra Reddy Katam [Fri, 30 Mar 2018 09:33:11 +0000 (15:03 +0530)]
Sonar critical issues

 Define and throw a dedicated exception instead of using a generic one
Sonar Link:
https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.dmaapclient%3AdmaapClient&open=AV4-MbO932hFUzlqc5WD&resolved=false&severities=CRITICAL
Location:
src/main/java/com/att/nsa/mr/client/MRClientBuilders.java
Line No-301

Change-Id: Ifdfd6bba9c6acbd2f5c4a6d7731dce19873fa551
Issue-ID: DMAAP-372
Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
6 years agoSonar critical issues 47/40347/1
commit | commitdiff | tree
Surendra Reddy Katam [Fri, 30 Mar 2018 09:11:51 +0000 (14:41 +0530)]
Sonar critical issues

 Define and throw a dedicated exception instead of using a generic one
Sonar Link:
https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.dmaapclient%3AdmaapClient&open=AV4-MbO932hFUzlqc5WB&resolved=false&severities=CRITICAL
Location:
src/main/java/com/att/nsa/mr/client/MRClientBuilders.java
Line No-134

Change-Id: I05e679d6c02be2c55ad7e378d4c5eabe3569546a
Issue-ID: DMAAP-371
Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
6 years agoSonar critical issues 45/40345/1
commit | commitdiff | tree
Surendra Reddy Katam [Fri, 30 Mar 2018 08:46:12 +0000 (14:16 +0530)]
Sonar critical issues

 Define and throw a dedicated exception instead of using a generic one
Sonar Link:
https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.dmaapclient%3AdmaapClient&open=AV4-MbPP32hFUzlqc5XD&resolved=false&severities=CRITICAL
Location:
src/main/java/com/att/nsa/mr/client/MRClientFactory.java
Line No-246

Change-Id: Ib75d5049b80817c65a4413b48863e0a78999d814
Issue-ID: DMAAP-370
Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
6 years agoSonar major issues 65/40065/1
commit | commitdiff | tree
Surendra Reddy Katam [Thu, 29 Mar 2018 07:15:57 +0000 (12:45 +0530)]
Sonar major issues

 Define and throw a dedicated exception instead of using a generic one
Sonar Link:
https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.dmaapclient%3AdmaapClient&open=AV4-MbPQ32hFUzlqc5XE&resolved=false&severities=CRITICAL
Location:
src/main/java/com/att/nsa/mr/client/MRClientFactory.java
Line No-542

Change-Id: Ic99472c3dfaf1bdebdce09688f5a20ce0fa16e9c
Issue-ID: DMAAP-369
Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
6 years agoSonar major issues 39/40039/1
commit | commitdiff | tree
Surendra Reddy Katam [Thu, 29 Mar 2018 06:03:12 +0000 (11:33 +0530)]
Sonar major issues

 This block of commented-out lines of code should be removed
Sonar Link:
https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.dmaapclient%3AdmaapClient&open=AV4-MbQo32hFUzlqc5Zx&resolved=false&severities=MAJOR
Location:
src/main/java/com/att/nsa/mr/client/impl/MRConstants.java
Line No-37

Change-Id: Ie2f97fe1542768bd97af09c4f6243332b0915cfc
Issue-ID: DMAAP-368
Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
6 years agoSonar major issues 99/39999/1
commit | commitdiff | tree
Surendra Reddy Katam [Thu, 29 Mar 2018 05:07:53 +0000 (10:37 +0530)]
Sonar major issues

 Use isEmpty() to check whether the collection is empty or not
Sonar Link:
https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.dmaapclient%3AdmaapClient&open=AV4-MbQb32hFUzlqc5Zl&resolved=false&severities=MAJOR
Location:
src/main/java/com/att/nsa/mr/client/impl/MRBatchPublisher.java
Line No-161

Change-Id: I19a085d5a602005807c56d75e2b5327050b311b2
Issue-ID: DMAAP-161
Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
6 years agoMerge "Sonar major issues"
commit | commitdiff | tree
varun gudisena [Wed, 28 Mar 2018 17:19:57 +0000 (17:19 +0000)]
Merge "Sonar major issues"

6 years agoMerge "Sonar major issues"
commit | commitdiff | tree
varun gudisena [Wed, 28 Mar 2018 17:19:53 +0000 (17:19 +0000)]
Merge "Sonar major issues"

6 years agoMerge "Sonar major issues"
commit | commitdiff | tree
varun gudisena [Wed, 28 Mar 2018 17:19:48 +0000 (17:19 +0000)]
Merge "Sonar major issues"

6 years agoMerge "Sonar major issues"
commit | commitdiff | tree
varun gudisena [Wed, 28 Mar 2018 17:19:42 +0000 (17:19 +0000)]
Merge "Sonar major issues"

6 years agoSonar major issues 47/39647/2
commit | commitdiff | tree
Surendra Reddy Katam [Wed, 28 Mar 2018 12:04:38 +0000 (17:34 +0530)]
Sonar major issues

 This block of commented-out lines of code should be removed
Sonar Link:
https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.dmaapclient%3AdmaapClient&open=AV4-MbQH32hFUzlqc5YM&resolved=false&severities=MAJOR
Location:
src/main/java/com/att/nsa/mr/client/impl/MRBaseClient.java
Line No-47

Change-Id: Ic168f908a0ac740ec152702a66f6ddb684b093b4
Issue-ID: DMAAP-365"
Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
6 years agoSonar major issues 27/39627/1
commit | commitdiff | tree
Surendra Reddy Katam [Wed, 28 Mar 2018 11:28:41 +0000 (16:58 +0530)]
Sonar major issues

 Use isEmpty() to check whether the collection is empty or not
Sonar Link:
https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.dmaapclient%3AdmaapClient&open=AV4-MbOi32hFUzlqc5Vf&resolved=false&severities=MAJOR
Location:
src/main/java/com/att/nsa/mr/client/HostSelector.java
Line No-57

Change-Id: I9c7b9d9f6765e61cf6dc34b6ea120e6fd23efa7a
Issue-ID: DMAAP-363
Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
6 years agoSonar major issues 11/39611/1
commit | commitdiff | tree
Surendra Reddy Katam [Wed, 28 Mar 2018 11:05:10 +0000 (16:35 +0530)]
Sonar major issues

 Use isEmpty() to check whether the collection is empty or not
Sonar Link:
https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.dmaapclient%3AdmaapClient&open=AV4-MbQb32hFUzlqc5Zn&resolved=false&severities=MAJOR
Location:
src/main/java/com/att/nsa/mr/client/impl/MRBatchPublisher.java
Line No-416

Change-Id: Ie1f85185d60e29004111003a55664e5217cd6ced
Issue-ID: DMAAP-362
Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
6 years agoSonar major issues 73/39573/1
commit | commitdiff | tree
Surendra Reddy Katam [Wed, 28 Mar 2018 10:10:56 +0000 (15:40 +0530)]
Sonar major issues

 Use isEmpty() to check whether the collection is empty or not
Sonar Link:
https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.dmaapclient%3AdmaapClient&open=AV4-MbQb32hFUzlqc5Zm&resolved=false&severities=MAJOR
Location:
src/main/java/com/att/nsa/mr/client/impl/MRBatchPublisher.java
Line No-322

Change-Id: Ifa4a91a303f49be0c264a9af2498bf70b8056168
Issue-ID: DMAAP-361
Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
6 years agoSonar major issues 65/39465/1
commit | commitdiff | tree
Surendra Reddy Katam [Wed, 28 Mar 2018 07:08:36 +0000 (12:38 +0530)]
Sonar major issues

 Use isEmpty() to check whether the collection is empty or not
Sonar Link:
https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.dmaapclient%3AdmaapClient&open=AV4-MbPA32hFUzlqc5WZ&resolved=false&severities=MAJOR
Location:
src/main/java/com/att/nsa/mr/client/MRClientBuilders.java
Line No-238

Change-Id: If5b14b4e2fe6964f4a02f980525b6bc1c8f95fdb
Issue-ID: DMAAP-360
Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
6 years agoSonar major issues 03/39103/1
commit | commitdiff | tree
Surendra Reddy Katam [Tue, 27 Mar 2018 14:01:58 +0000 (19:31 +0530)]
Sonar major issues

 This block of commented-out lines of code should be removed
Sonar Link:
https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.dmaapclient%3AdmaapClient&open=AV4-MbPN32hFUzlqc5W0&resolved=false&severities=MAJOR
Location:
src/main/java/com/att/nsa/mr/client/MRClientFactory.java
Line-No:660

Change-Id: Ie0651eca33be07eff6bd67ab51488eaa72f4fb1e
Issue-ID: DMAAP-357
Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
6 years agoSonar major issues 83/39083/1
commit | commitdiff | tree
Surendra Reddy Katam [Tue, 27 Mar 2018 12:58:34 +0000 (18:28 +0530)]
Sonar major issues

 This block of commented-out lines of code should be removed
Sonar Link:
https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.dmaapclient%3AdmaapClient&open=AWE8fY-v-08if2a6yLVH&resolved=false&severities=MAJOR
Location:
src/main/java/com/att/nsa/mr/client/MRClientFactory.java
Line-No:69

Change-Id: I130920f7125695cc9816cca8be671d7dc4f8188c
Issue-ID: DMAAP-356
Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
6 years agoSonar major issues 37/39037/1
commit | commitdiff | tree
Surendra Reddy Katam [Tue, 27 Mar 2018 10:43:58 +0000 (16:13 +0530)]
Sonar major issues

 Use isEmpty() to check whether the collection is empty or not
Sonar Link:
https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.dmaapclient%3AdmaapClient&open=AV4-MbPA32hFUzlqc5Wa&resolved=false&severities=MAJOR
Location:
src/main/java/com/att/nsa/mr/client/MRClientBuilders.java
Line-No:365

Change-Id: I523aab6449c47a78bc647f63bf1b41dc12ccb76f
Issue-ID: DMAAP-354
Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
6 years agoSonar critical issues 95/38895/1
commit | commitdiff | tree
Surendra Reddy Katam [Tue, 27 Mar 2018 06:31:02 +0000 (12:01 +0530)]
Sonar critical issues

 Either log or rethrow this exception
Sonar Link:
https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.dmaapclient%3AdmaapClient&open=AV4-MbQa32hFUzlqc5Zb&resolved=false&severities=CRITICAL
Location:
src/main/java/com/att/nsa/mr/client/impl/MRBatchPublisher.java
Line No-446

Change-Id: I46196f92299226325817f9c1a391abc549959247
Issue-ID: DMAAP-351
Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
6 years agoSonar critical issues 57/38857/1
commit | commitdiff | tree
Surendra Reddy Katam [Tue, 27 Mar 2018 05:43:15 +0000 (11:13 +0530)]
Sonar critical issues

 Either log or rethrow this exception
SOnar Link:
https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.dmaapclient%3AdmaapClient&open=AV4-MbQa32hFUzlqc5Za&resolved=false&severities=CRITICAL
Location:
src/main/java/com/att/nsa/mr/client/impl/MRBatchPublisher.java
Line No-462

Change-Id: I1bb8cad051834fb487f9cea04187f36a6877d88a
Issue-ID: DMAAP-350
Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
6 years agoSonar critical issues 39/38839/1
commit | commitdiff | tree
Surendra Reddy Katam [Tue, 27 Mar 2018 05:11:03 +0000 (10:41 +0530)]
Sonar critical issues

 Either log or rethrow this exception
Sonar Link:
https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.dmaapclient%3AdmaapClient&open=AV4-MbSb32hFUzlqc5e-&resolved=false&severities=CRITICAL
Location:
src/main/java/com/att/nsa/mr/dme/client/PreferredRouteReplyHandler.java
Line No-69

Change-Id: I5b32ee4e9f038d10e28349c211e869e7e3ca9c12
Issue-ID: DMAAP-349
Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
6 years agoSonar critical issues 07/38807/1
commit | commitdiff | tree
Surendra Reddy Katam [Tue, 27 Mar 2018 04:37:36 +0000 (10:07 +0530)]
Sonar critical issues

 Either log or rethrow this exception
Sonar Link:
https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.dmaapclient%3AdmaapClient&open=AV4-MbQ-32hFUzlqc5bm&resolved=false&severities=CRITICAL
Location:
src/main/java/com/att/nsa/mr/client/impl/MRConsumerImpl.java
Line No:509

Change-Id: I15c417bc47ceac7c7001ba96d1796ef883700886
Issue-ID: DMAAP-348
Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
6 years agoMerge "Sonar critical issues"
commit | commitdiff | tree
varun gudisena [Tue, 27 Mar 2018 03:52:03 +0000 (03:52 +0000)]
Merge "Sonar critical issues"

next
It's a message router client. uses DME2 ( Direct Messaging Engine ) library to locate the end point.