Sonar critical issues 63/40663/1
authorSurendra Reddy Katam <SK00524980@techmahindra.com>
Tue, 3 Apr 2018 09:26:53 +0000 (14:56 +0530)
committerSurendra Reddy Katam <SK00524980@techmahindra.com>
Tue, 3 Apr 2018 09:26:53 +0000 (14:56 +0530)
 Define and throw a dedicated exception instead of using a generic one
Sonar link:
https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.dmaapclient%3AdmaapClient&open=AV4-MbPQ32hFUzlqc5XH&resolved=false&severities=CRITICAL
Location:
src/main/java/com/att/nsa/mr/client/MRClientFactory.java
Line No-605

Change-Id: I4d2b43d8ae1585f6cd17b32d0c15987f9f5fe514
Issue-ID: DMAAP-380
Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
src/main/java/com/att/nsa/mr/client/MRClientFactory.java

index 8513129..496f94e 100644 (file)
@@ -602,7 +602,7 @@ public class MRClientFactory {
                try {
                        sub = new MRConsumerImpl(MRConsumerImpl.stringToList(host), topic, group, id, i, j, null, null, null);
                } catch (MalformedURLException e) {
-                       throw new RuntimeException(e);
+                       throw new IllegalArgumentException(e);
                }
                sub.setUsername(username);
                sub.setPassword(password);