Fixed Sonar Issues in NodeClass.java 89/63989/1
authorAmaresh Kumar <kamaresh@in.ibm.com>
Fri, 31 Aug 2018 12:34:15 +0000 (18:04 +0530)
committerAmaresh Kumar <kamaresh@in.ibm.com>
Fri, 31 Aug 2018 12:34:26 +0000 (18:04 +0530)
https://sonar.onap.org/project/issues?fileUuids=AWHFaQiuEU5FCDfKtnFN&id=org.onap.dmaap.datarouter%3Aparent&open=AWHFaQp1EU5FCDfKtnb5&resolved=false&severities=BLOCKER

Issue-ID: DMAAP-683
Change-Id: I49551fc807d455d656eb84661b2507b85f681d4e
Signed-off-by: Amaresh Kumar <kamaresh@in.ibm.com>
datarouter-prov/src/main/java/org/onap/dmaap/datarouter/provisioning/beans/NodeClass.java

index f3eb1eb..1b36851 100755 (executable)
@@ -105,13 +105,14 @@ public abstract class NodeClass extends Syncable {
     public static void reload() {\r
         Map<String, Integer> m = new HashMap<String, Integer>();\r
         PreparedStatement ps = null;\r
+        ResultSet rs=null;\r
         try {\r
             DB db = new DB();\r
             @SuppressWarnings("resource")\r
             Connection conn = db.getConnection();\r
             String sql = "select NODEID, NAME from NODES";\r
             ps = conn.prepareStatement(sql);\r
-            ResultSet rs = ps.executeQuery();\r
+            rs = ps.executeQuery();\r
             while (rs.next()) {\r
                 int id = rs.getInt("NODEID");\r
                 String name = rs.getString("NAME");\r
@@ -127,6 +128,9 @@ public abstract class NodeClass extends Syncable {
                 if(ps!=null){\r
                     ps.close();\r
                 }\r
+                if(rs!=null){\r
+                    rs.close();\r
+                }\r
 \r
             } catch (SQLException e) {\r
                 intLogger.error("PROV0005 doInsert: " + e.getMessage(),e);\r