Fixed Critical Sonar Issues in LogServlet.java 81/63281/1
authorAmaresh Kumar <kamaresh@in.ibm.com>
Tue, 28 Aug 2018 14:38:48 +0000 (20:08 +0530)
committerAmaresh Kumar <kamaresh@in.ibm.com>
Tue, 28 Aug 2018 14:46:51 +0000 (20:16 +0530)
https://sonar.onap.org/project/issues?fileUuids=AWHFaQitEU5FCDfKtnEp&id=org.onap.dmaap.datarouter%3Aparent&resolved=false&severities=BLOCKER

Issue-ID: DMAAP-668
Change-Id: I2d3990c446eabbfdf2a338ad109775a2f7aa0c1b
Signed-off-by: Amaresh Kumar <kamaresh@in.ibm.com>
datarouter-prov/src/main/java/org/onap/dmaap/datarouter/provisioning/LogServlet.java

index 8614a6e..101c9e6 100644 (file)
@@ -417,13 +417,13 @@ public class LogServlet extends BaseServlet {
         Connection conn = null;\r
         try {\r
             conn = db.getConnection();\r
-            Statement  stmt = conn.createStatement();\r
-            ResultSet rs = stmt.executeQuery(sql);\r
-            while (rs.next()) {\r
-                rh.handleRow(rs);\r
-            }\r
-            rs.close();\r
-            stmt.close();\r
+           try( Statement  stmt = conn.createStatement()){\r
+             try(ResultSet rs = stmt.executeQuery(sql)){\r
+                 while (rs.next()) {\r
+                     rh.handleRow(rs);\r
+                 }\r
+             }\r
+           }\r
         } catch (SQLException sqlException) {\r
             intlogger.info("Failed to get Records. Exception = " +sqlException.getMessage(),sqlException);\r
         } finally {\r