Merge "Logging improvements"
authorFiachra Corcoran <fiachra.corcoran@est.tech>
Wed, 26 Jun 2019 10:26:03 +0000 (10:26 +0000)
committerGerrit Code Review <gerrit@onap.org>
Wed, 26 Jun 2019 10:26:03 +0000 (10:26 +0000)
1  2 
datarouter-node/src/main/java/org/onap/dmaap/datarouter/node/Delivery.java

@@@ -28,7 -28,7 +28,7 @@@ import com.att.eelf.configuration.EELFM
  import java.io.File;
  import java.util.ArrayList;
  import java.util.Arrays;
 -import java.util.Hashtable;
 +import java.util.HashMap;
  import java.util.Objects;
  
  /**
@@@ -50,7 -50,7 +50,7 @@@ public class Delivery 
      private int threads;
      private int curthreads;
      private NodeConfigManager config;
 -    private Hashtable<String, DeliveryQueue> dqs = new Hashtable<>();
 +    private HashMap<String, DeliveryQueue> dqs = new HashMap<>();
      private DeliveryQueue[] queues = new DeliveryQueue[0];
      private int qpos = 0;
      private long nextcheck;
          cur = spoolfile.getUsableSpace();
          if (cur >= stop) {
              logger.info("NODE0503 Free disk space at or above yellow threshold.  current=" + cur + YELLOW + stop
-                     + TOTAL + tspace);
+                                 + TOTAL + tspace);
              return;
          }
          logger.warn(
          DestInfo[] alldis = config.getAllDests();
          DeliveryQueue[] nqs = new DeliveryQueue[alldis.length];
          qpos = 0;
 -        Hashtable<String, DeliveryQueue> ndqs = new Hashtable<>();
 +        HashMap<String, DeliveryQueue> ndqs = new HashMap<>();
          for (DestInfo di : alldis) {
              String spl = di.getSpool();
              DeliveryQueue dq = dqs.get(spl);
          cleardirs();
          while (curthreads < threads) {
              curthreads++;
-             (new Thread("Delivery Thread") {
+             (new Thread("del-thread-" + curthreads) {
                  @Override
                  public void run() {
                      dodelivery();
          for (DelItem item : items) {
              long amount = dqs.get(item.getSpool()).cancelTask(item.getPublishId());
              logger.info("NODE0502 Attempting to discard " + item.getSpool() + "/" + item.getPublishId()
-                     + " to free up disk");
+                                 + " to free up disk");
              if (amount > 0) {
                  cur += amount;
                  if (cur >= stop) {
          return false;
      }
  
 -    private static class DelItem implements Comparable<DelItem> {
 +    static class DelItem implements Comparable<DelItem> {
  
          private String pubid;
          private String spool;
              }
              DelItem delItem = (DelItem) object;
              return Objects.equals(pubid, delItem.pubid)
-                     && Objects.equals(getSpool(), delItem.getSpool());
+                            && Objects.equals(getSpool(), delItem.getSpool());
          }
  
          @Override