Sonar fix for DB.java

https://sonar.onap.org/project/issues?id=org.onap.dmaap.datarouter%3Aparent&open=AWUebYr6wGn37JfbxiDE&resolved=false&severities=BLOCKER&types=BUG

Issue-ID: DMAAP-680
Change-Id: I8760e8dd945e5b5e9792dfdaf3d0193f89c573a6
Signed-off-by: Amaresh Kumar <kamaresh@in.ibm.com>

diff --git a/datarouter-prov/src/main/java/org/onap/dmaap/datarouter/provisioning/utils/DB.java b/datarouter-prov/src/main/java/org/onap/dmaap/datarouter/provisioning/utils/DB.java
index bbcacb5..7f0d56b 100644 (file)
--- a/datarouter-prov/src/main/java/org/onap/dmaap/datarouter/provisioning/utils/DB.java
+++ b/datarouter-prov/src/main/java/org/onap/dmaap/datarouter/provisioning/utils/DB.java
@@ -112,13 +112,16 @@ public class DB {
                                 throw sqlEx;\r
                             }\r
                         }\r
+                        finally {\r
+                            if (connection != null && !connection.isValid(1)) {\r
+                                connection.close();\r
+                                connection = null;\r
+                            }\r
+                        }\r
                     } while (connection == null);\r
                 }\r
             }\r
-            if (connection != null && !connection.isValid(1)) {\r
-                connection.close();\r
-                connection = null;\r
-            }\r
+\r
         }\r
         return connection;\r
     }\r