Fix LogfileLoader vulnerabilities

Change-Id: I02b0c5907e99aa978def1dd04876d6f8e4095ee3
Signed-off-by: Ronan Keogh <ronan.keogh@ericsson.com>
Issue-ID: DMAAP-775

diff --git a/datarouter-prov/src/main/java/org/onap/dmaap/datarouter/provisioning/utils/LogfileLoader.java b/datarouter-prov/src/main/java/org/onap/dmaap/datarouter/provisioning/utils/LogfileLoader.java
index 110c63d..b6ad8e4 100644 (file)
--- a/datarouter-prov/src/main/java/org/onap/dmaap/datarouter/provisioning/utils/LogfileLoader.java
+++ b/datarouter-prov/src/main/java/org/onap/dmaap/datarouter/provisioning/utils/LogfileLoader.java
@@ -214,7 +214,6 @@ public class LogfileLoader extends Thread {
                 }\r
             } catch (Exception e) {\r
                 logger.warn("PROV0020: Caught exception in LogfileLoader: " + e);\r
-                e.printStackTrace();\r
             }\r
         }\r
     }\r
@@ -275,7 +274,7 @@ public class LogfileLoader extends Thread {
              }\r
             } catch (SQLException e) {\r
                 System.err.println(e);\r
-                e.printStackTrace();\r
+                logger.error(e);\r
             } finally {\r
                 db.release(conn);\r
             }\r
@@ -297,7 +296,7 @@ public class LogfileLoader extends Thread {
            }\r
          } catch (SQLException e) {\r
             System.err.println(e);\r
-            e.printStackTrace();\r
+            logger.error(e);\r
         } finally {\r
             db.release(conn);\r
         }\r
@@ -322,7 +321,7 @@ public class LogfileLoader extends Thread {
             }\r
            } catch (SQLException e) {\r
             System.err.println(e);\r
-            e.printStackTrace();\r
+            logger.error(e);\r
         } finally {\r
             db.release(conn);\r
         }\r
@@ -376,7 +375,7 @@ public class LogfileLoader extends Thread {
             logger.debug(String.format("initializeNextid, next ID is %d (%x)", nextid, nextid));\r
         } catch (SQLException e) {\r
             System.err.println(e);\r
-            e.printStackTrace();\r
+            logger.error(e);\r
         } finally {\r
             db.release(conn);\r
         }\r
@@ -417,19 +416,15 @@ public class LogfileLoader extends Thread {
                     } catch (SQLException e) {\r
                         logger.warn("PROV8003 Invalid value in record: " + line);\r
                         logger.debug(e);\r
-                        e.printStackTrace();\r
                     } catch (NumberFormatException e) {\r
                         logger.warn("PROV8004 Invalid number in record: " + line);\r
                         logger.debug(e);\r
-                        e.printStackTrace();\r
                     } catch (ParseException e) {\r
                         logger.warn("PROV8005 Invalid date in record: " + line);\r
                         logger.debug(e);\r
-                        e.printStackTrace();\r
                     } catch (Exception e) {\r
                         logger.warn("PROV8006 Invalid pattern in record: " + line);\r
                         logger.debug(e);\r
-                        e.printStackTrace();\r
                     }\r
                     total++;\r
                 }\r