cps.git
2 months agoGet Subscription Delta 72/137172/10
seanbeirne [Tue, 6 Feb 2024 10:37:02 +0000 (10:37 +0000)]
Get Subscription Delta

-Added @AllArgsConstructor to improve readability

Issue-ID: CPS-1953
Change-Id: Id457561edb8ce8c00c9c93a1453ec37da5174b38
Signed-off-by: seanbeirne <sean.beirne@est.tech>
2 months agoTests of CM-handle module upgrade & moduleSetTag 76/137276/2
danielhanrahan [Mon, 19 Feb 2024 09:55:37 +0000 (09:55 +0000)]
Tests of CM-handle module upgrade & moduleSetTag

Integration tests covering scenarios of the creation and upgrade of
CM-handles with:
- no moduleSetTag
- new moduleSetTag
- existing moduleSetTag
Failing tests are marked @Ignore.

Issue-ID: CPS-2102
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: Id5567e08a13d8c26dc7b6458f0af8449bef6f082

2 months agoAdd NCMP to integration-test module 14/137214/4
danielhanrahan [Tue, 13 Feb 2024 11:12:29 +0000 (11:12 +0000)]
Add NCMP to integration-test module

- Add NCMP to integration test base class
- Use MockRestServiceServer to mock DMI responses in groovy tests
- Added tests for CM-handle registration to READY and LOCKED states
- Add test of CM-handle deregistration

Issue-ID: CPS-2033
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: I89f9f8aab2bba9d4eb5b3136a2feb238e7cf1b06

2 months agoMerge "Mapper to form event for DMI Plugin"
Lee Anjella Macabuhay [Wed, 14 Feb 2024 14:26:52 +0000 (14:26 +0000)]
Merge "Mapper to form event for DMI Plugin"

2 months agoMerge "Clean up of integration-test base classes"
Lee Anjella Macabuhay [Wed, 14 Feb 2024 11:48:45 +0000 (11:48 +0000)]
Merge "Clean up of integration-test base classes"

2 months agoMerge "Faster absolute xpath query using parent path lookup"
Lee Anjella Macabuhay [Wed, 14 Feb 2024 11:30:37 +0000 (11:30 +0000)]
Merge "Faster absolute xpath query using parent path lookup"

2 months agoClean up of integration-test base classes 12/137212/4
danielhanrahan [Tue, 13 Feb 2024 11:12:29 +0000 (11:12 +0000)]
Clean up of integration-test base classes

- Remove TestConfig and instead use auto-configuration
- Add needed application.yml config
- Refactor helper methods for creating JSON

Issue-ID: CPS-2090
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: I4f618a1d4a83e9c75e468928c257b817d449c22f

2 months agoMerge "Remove liquibase test changelog"
Lee Anjella Macabuhay [Wed, 14 Feb 2024 11:13:01 +0000 (11:13 +0000)]
Merge "Remove liquibase test changelog"

2 months agoFaster absolute xpath query using parent path lookup 13/137213/3
danielhanrahan [Mon, 20 Nov 2023 16:37:46 +0000 (16:37 +0000)]
Faster absolute xpath query using parent path lookup

Issue-ID: CPS-2087
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: I62b452f34f08a32a6d80671c7af560fbceec1285

2 months agoMerge "Update release notes for Extending Module API retrieval"
Toine Siebelink [Wed, 14 Feb 2024 08:43:58 +0000 (08:43 +0000)]
Merge "Update release notes for Extending Module API retrieval"

2 months agoRemove liquibase test changelog 09/137209/2
danielhanrahan [Tue, 13 Feb 2024 09:53:07 +0000 (09:53 +0000)]
Remove liquibase test changelog

Complete liquibase changelog takes under 1 second to run,
so having separate changelog for integration tests offers
no benefit.

Issue-ID: CPS-2090
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: Ib0e928f35d401b91c23dfcb5dc82c77778a044dc

2 months agoMapper to form event for DMI Plugin 40/137140/5
mpriyank [Tue, 6 Feb 2024 13:39:29 +0000 (13:39 +0000)]
Mapper to form event for DMI Plugin

- cmSubscriptionPredicate to CmNotificationSubscriptionDmiInEvent mapper code and
  testware.
- Based on the delta we find , we will be sending the events to the dmi
  plugins. Finding delta code will be separate patchset

Issue-ID: CPS-2060
Change-Id: If1e15679b72c39352e3cf166651226df7e207ce0
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2 months agoUpdate release notes for Extending Module API retrieval 87/137187/2
halil.cakal [Thu, 8 Feb 2024 12:15:48 +0000 (12:15 +0000)]
Update release notes for Extending Module API retrieval

- Add the user story: CPS-1135 for CPS version 3.4.3

Issue-ID: CPS-1135

Change-Id: I9e9cdc5f648d38eb4dbd76cc98a884fed03a28b2
Signed-off-by: halil.cakal <halil.cakal@est.tech>
2 months agoPrefix with CmNotificationSubscription refactoring 10/137210/1
mpriyank [Tue, 13 Feb 2024 11:50:23 +0000 (11:50 +0000)]
Prefix with CmNotificationSubscription refactoring

- event schemas are now suffixed with CmNotificationSubscription
- testware updated appropriately

Issue-ID: CPS-2091
Change-Id: I9d0c4bdfaf7ea94812d35b071824d0fb083aa845
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2 months agoMerge "Update cm-data-subscriptions model"
Lee Anjella Macabuhay [Tue, 13 Feb 2024 10:54:02 +0000 (10:54 +0000)]
Merge "Update cm-data-subscriptions model"

2 months agoMerge "Add a configurable delay to the DMI stub"
Sourabh Sourabh [Tue, 13 Feb 2024 10:08:11 +0000 (10:08 +0000)]
Merge "Add a configurable delay to the DMI stub"

2 months agoMerge "Fix test failure by ordering leaf-lists"
Priyank Maheshwari [Tue, 13 Feb 2024 09:47:35 +0000 (09:47 +0000)]
Merge "Fix test failure by ordering leaf-lists"

2 months agoMerge "Create schemas for notification service in cps-core"
Priyank Maheshwari [Tue, 13 Feb 2024 09:24:00 +0000 (09:24 +0000)]
Merge "Create schemas for notification service in cps-core"

2 months agoUpdate cm-data-subscriptions model 05/137205/3
mpriyank [Mon, 12 Feb 2024 16:16:36 +0000 (16:16 +0000)]
Update cm-data-subscriptions model

- rename leaf-list subscribers to subscriptionIds
- code using the same also updated
- not creating a new version of model as nobody is using it at the
  moment

Issue-ID: CPS-2088
Change-Id: I43d679047bdfc665b56f262757acc4bbaba2733f
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2 months agoCmSubscription minor code refactoring 78/137178/10
mpriyank [Wed, 7 Feb 2024 14:55:03 +0000 (14:55 +0000)]
CmSubscription minor code refactoring

- As per discusstion , refactoring the naming of the classes and caches
- Combining the validation service with CmSubscriptionPersistence
  service
- removed dmiCmNotificationScopeFilter class and the attributes are part
  of Predicates only

Issue-ID: CPS-2078
Change-Id: Ic2b3ee28a150f3ae6e0911e88296f01e22604ef5
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2 months agoFix test failure by ordering leaf-lists 91/137191/8
danielhanrahan [Thu, 8 Feb 2024 15:04:05 +0000 (15:04 +0000)]
Fix test failure by ordering leaf-lists

YANG specifies two ways that leaf-lists can be ordered:
- ordered-by user: original order in JSON is preserved
- ordered-by system (default): it is up to the system how to order

For leaf-lists to preserve same order as the JSON, the Yang module
must specify 'ordered-by user'. To ensure consistent behaviour even
when system ordering is used, the leaf-list is sorted during parsing.

- Add 'ordered-by user' to authors field in bookstore.yang
- Sort leaf-list during parsing when using 'ordered-by system'
- Add new tests to verify ordering

Issue-ID: CPS-2057
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: I6ab688ec2fa4a22182e853d1a8b26642f278c40a

2 months agoInclude integration test results in Jacoco 02/137202/3
danielhanrahan [Fri, 9 Feb 2024 17:40:18 +0000 (17:40 +0000)]
Include integration test results in Jacoco

integration-test module is not recording code coverage due to
incorrectly overriding the maven surefire config from parent pom.

Issue-ID: CPS-2086
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: I774c64acedca546f5c01403597bd9f5010de73d2

2 months agoAdd a configurable delay to the DMI stub 96/137196/3
JvD_Ericsson [Wed, 31 Jan 2024 13:47:28 +0000 (13:47 +0000)]
Add a configurable delay to the DMI stub

Added realistic default delay to application.yaml
Added realistic default delay to docker-compose.yml

Issue-ID: CPS-2053
Signed-off-by: JvD_Ericsson <jeff.van.dam@est.tech>
Change-Id: I756774e9538926aa341f1338fcb6882951ce3e69

2 months agoCreate schemas for notification service in cps-core 07/137007/3
rajesh.kumar [Mon, 5 Feb 2024 13:37:11 +0000 (19:07 +0530)]
Create schemas for notification service in cps-core

Add schema files for notification service

Issue-ID:CPS-2066
Change-Id: I56c34400dc73c71b936a51260efd230205abbacd
Signed-off-by: rajesh.kumar <rk00747546@techmahindra.com>
2 months agoMerge "Add CSIT test: Delete CM Handle"
Toine Siebelink [Thu, 8 Feb 2024 16:40:21 +0000 (16:40 +0000)]
Merge "Add CSIT test: Delete CM Handle"

2 months agoMerge "Correct use of Spock setup and cleanup methods (no need for @Before @After)"
Toine Siebelink [Thu, 8 Feb 2024 16:38:37 +0000 (16:38 +0000)]
Merge "Correct use of Spock setup and cleanup methods (no need for @Before @After)"

2 months agoMerge "Revert "Introduce Hazelcast for alternateId-cmHandle relation pt. 2 - error...
Toine Siebelink [Thu, 8 Feb 2024 16:36:52 +0000 (16:36 +0000)]
Merge "Revert "Introduce Hazelcast for alternateId-cmHandle relation pt. 2 - error collection""

2 months agoRevert "Introduce Hazelcast for alternateId-cmHandle relation pt. 2 - error collection" 51/137051/1
Levente Csanyi [Thu, 8 Feb 2024 16:12:06 +0000 (16:12 +0000)]
Revert "Introduce Hazelcast for alternateId-cmHandle relation pt. 2 - error collection"

This reverts commit 67681820f2a7fea88cbc6cbe5b3d483dae506d55.

Reason for revert: does not work

Change-Id: I92c063b59261d25774ee34664d834399c269f0c2
Signed-off-by: leventecsanyi <levente.csanyi@est.tech>
2 months agoMerge "Introduce Hazelcast for alternateId-cmHandle relation pt. 2 - error collection"
Toine Siebelink [Thu, 8 Feb 2024 14:08:47 +0000 (14:08 +0000)]
Merge "Introduce Hazelcast for alternateId-cmHandle relation pt. 2 - error collection"

2 months agoIntroduce Hazelcast for alternateId-cmHandle relation pt. 2 - error collection 11/137111/16
leventecsanyi [Thu, 1 Feb 2024 12:35:52 +0000 (13:35 +0100)]
Introduce Hazelcast for alternateId-cmHandle relation pt. 2 - error collection

    - added business logic to check duplicated ids (create and update scenarios)
    - added new unit test for CmHandleIdMapperSpec
    - added test for the new registration scenario

Issue-ID: CPS-1988
Change-Id: I4bf2e25c87c57938d336f2fe70378b400bab07b0
Signed-off-by: leventecsanyi <levente.csanyi@est.tech>
2 months agoCorrect use of Spock setup and cleanup methods (no need for @Before @After) 82/137182/4
ToineSiebelink [Wed, 7 Feb 2024 17:07:25 +0000 (17:07 +0000)]
Correct use of Spock setup and cleanup methods (no need for @Before @After)

- unfortunately we copied the bad test code for logging about 4 times alraedy...
- simplified setup for WatchdogSchedulingConfigurerSpec

Issue-ID:CPS-465

Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
Change-Id: I8d068541263272fdf99a6e30d365d85e31726432

2 months agoMerge "CmHandle delete is failing with InternalServerError: Null key is not allowed...
Toine Siebelink [Thu, 8 Feb 2024 10:48:23 +0000 (10:48 +0000)]
Merge "CmHandle delete is failing with InternalServerError: Null key is not allowed - add missing unit test"

2 months agoAdd alternateId to legacy lcm-event 01/137101/4
JvD_Ericsson [Wed, 31 Jan 2024 15:01:31 +0000 (15:01 +0000)]
Add alternateId to legacy lcm-event

Issue-ID: CPS-2039
Signed-off-by: JvD_Ericsson <jeff.van.dam@est.tech>
Change-Id: I03863e986ea6b847fd7d25e55a24f948ca9a983d

2 months agoMerge "Replace sleep with PollingConditions"
Toine Siebelink [Wed, 7 Feb 2024 17:47:19 +0000 (17:47 +0000)]
Merge "Replace sleep with PollingConditions"

2 months agoMerge "Orphaned modules are removed from the DB before cmhandle removal"
Toine Siebelink [Wed, 7 Feb 2024 17:36:05 +0000 (17:36 +0000)]
Merge "Orphaned modules are removed from the DB before cmhandle removal"

2 months agoBump CPS to 3.4.4-SNAPSHOT 81/137181/1
danielhanrahan [Wed, 7 Feb 2024 16:07:27 +0000 (16:07 +0000)]
Bump CPS to 3.4.4-SNAPSHOT

- bump CPS to 3.4.4-SNAPSHOT and update the docs

Issue-ID: CPS-2077
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: I1658c83642c8e64903f4bc03b74b6f5726d0227e

2 months agoAdd CSIT test: Delete CM Handle 33/137133/8
halil.cakal [Tue, 6 Feb 2024 11:54:51 +0000 (11:54 +0000)]
Add CSIT test: Delete CM Handle

- Add new csit test to ncmp inventory

Issue-ID: CPS-2073
Change-Id: Ie683f043b2dc1cc742945a4874f19688a8702009
Signed-off-by: halil.cakal <halil.cakal@est.tech>
2 months agoAdd container yaml for CPS 3.4.3 80/137180/1
danielhanrahan [Wed, 7 Feb 2024 15:45:06 +0000 (15:45 +0000)]
Add container yaml for CPS 3.4.3

- added container yaml to release the docker images for CPS 3.4.3

Issue-ID: CPS-2077
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: I2e0563a1942d571135ce688c1a339cd4a56f7458

2 months agoAdd maven stage yaml for CPS 3.4.3 79/137179/1
danielhanrahan [Wed, 7 Feb 2024 15:39:22 +0000 (15:39 +0000)]
Add maven stage yaml for CPS 3.4.3

- maven stage yaml to release 3.4.3

Issue-ID: CPS-2077
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: Iaef72394a7ddc64999c95c96aed9873a6487be77

2 months agoUpdate release notes for CPS 3.4.3 76/137176/2
danielhanrahan [Wed, 7 Feb 2024 14:21:58 +0000 (14:21 +0000)]
Update release notes for CPS 3.4.3

- updated release notes for 3.4.3
- updated openapi files

Issue-ID: CPS-2077
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: I2ded94a243dbe93885525d73f90dde3dbbb79696

2 months agoReplace sleep with PollingConditions 10/137110/5
JvD_Ericsson [Thu, 1 Feb 2024 13:55:50 +0000 (13:55 +0000)]
Replace sleep with PollingConditions

Issue-ID: CPS-1950
Signed-off-by: JvD_Ericsson <jeff.van.dam@est.tech>
Change-Id: I0e23c697ef6b5a134295728f352f2dff7be05a62

2 months agoOrphaned modules are removed from the DB before cmhandle removal 51/137151/1
sourabh_sourabh [Wed, 7 Feb 2024 10:26:33 +0000 (10:26 +0000)]
Orphaned modules are removed from the DB before cmhandle removal

- changed sequence of delete schema set by cascade to remove unused yang
  resource modules at last.

Issue-ID: CPS-2031
Change-Id: Icefc075165231cc4b9b170e04a2d12af645529e9
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
2 months agoCmHandle delete is failing with InternalServerError: Null key is not allowed - add... 38/137138/2
leventecsanyi [Tue, 6 Feb 2024 12:56:13 +0000 (13:56 +0100)]
CmHandle delete is failing with InternalServerError: Null key is not allowed - add missing unit test

Issue-ID: CPS-2064
Change-Id: If765c25cae8d69796fff219fc39ab27455bfd957
Signed-off-by: leventecsanyi <levente.csanyi@est.tech>
2 months agoMerge "Fix: Documentation for Delta Feature"
Priyank Maheshwari [Wed, 7 Feb 2024 09:27:29 +0000 (09:27 +0000)]
Merge "Fix: Documentation for Delta Feature"

2 months agoMerge "Add integration test for extending API: Get Module Definitions"
Toine Siebelink [Tue, 6 Feb 2024 17:46:51 +0000 (17:46 +0000)]
Merge "Add integration test for extending API: Get Module Definitions"

2 months agoMerge "Add maven classifier to Spring Boot JAR"
Lee Anjella Macabuhay [Tue, 6 Feb 2024 14:35:04 +0000 (14:35 +0000)]
Merge "Add maven classifier to Spring Boot JAR"

2 months agoMerge "[BUG] Retry interval for kafka consumer"
Toine Siebelink [Tue, 6 Feb 2024 11:53:52 +0000 (11:53 +0000)]
Merge "[BUG] Retry interval for kafka consumer"

2 months agoFix: Documentation for Delta Feature 08/137008/1
Arpit Singh [Tue, 6 Feb 2024 11:24:50 +0000 (16:54 +0530)]
Fix: Documentation for Delta Feature

Issue-ID: CPS-2074
Signed-off-by: Arpit Singh <as00745003@techmahindra.com>
Change-Id: Ib32b4c75f7eb5402367f69a077c447a3eb062b0b

2 months agoMerge "Limit heap size in Groovy integration tests"
Priyank Maheshwari [Tue, 6 Feb 2024 11:10:25 +0000 (11:10 +0000)]
Merge "Limit heap size in Groovy integration tests"

2 months agoMerge "CmSubscription service layer method #1"
Lee Anjella Macabuhay [Tue, 6 Feb 2024 10:49:21 +0000 (10:49 +0000)]
Merge "CmSubscription service layer method #1"

2 months agoMerge "CmSubscription validate datastore"
Lee Anjella Macabuhay [Tue, 6 Feb 2024 10:49:01 +0000 (10:49 +0000)]
Merge "CmSubscription validate datastore"

2 months agoMerge "moduleSetTag and cmhandle upgrade functionalities fix"
Toine Siebelink [Tue, 6 Feb 2024 10:47:40 +0000 (10:47 +0000)]
Merge "moduleSetTag and cmhandle upgrade functionalities fix"

2 months ago[BUG] Retry interval for kafka consumer 31/137131/1
mpriyank [Tue, 6 Feb 2024 10:44:14 +0000 (10:44 +0000)]
[BUG] Retry interval for kafka consumer

- added retry interval of 10 seconds in case of any auth exception when
  consuming kafka messages.
- This fix prevents us from restarting the whole app inorder to restart
  the consumer.

Issue-ID: CPS-2070
Change-Id: Ie02d3cb686741cd92dd006dab1d49c3480d58720
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2 months agomoduleSetTag and cmhandle upgrade functionalities fix 79/136979/11
sourabh_sourabh [Fri, 12 Jan 2024 10:24:42 +0000 (10:24 +0000)]
moduleSetTag and cmhandle upgrade functionalities fix

- Insert only unmapped yang resources
- In case of removed module call dmi plugin service to get modules.

Issue-ID: CPS-2027
Change-Id: Ic1903c20169a913c835a3eee909357daec45f51e
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
2 months agoAdd maven classifier to Spring Boot JAR 04/136604/6
danielhanrahan [Fri, 2 Feb 2024 12:25:47 +0000 (12:25 +0000)]
Add maven classifier to Spring Boot JAR

Use a classifier so that both thin jar and spring boot jar are built.

Issue-ID: CPS-2072
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: Iafa35992db09abf01b82668cde0eb75f12db7258

2 months agoMerge "Set resource limits of docker-compose containers"
Lee Anjella Macabuhay [Tue, 6 Feb 2024 10:17:06 +0000 (10:17 +0000)]
Merge "Set resource limits of docker-compose containers"

2 months agoCmHandle delete is failing with InternalServerError: Null key is not allowed 19/137119/2
leventecsanyi [Mon, 5 Feb 2024 10:19:34 +0000 (11:19 +0100)]
CmHandle delete is failing with InternalServerError: Null key is not allowed

   - added null check to alt id removal from cache

Issue-ID: CPS-2064
Change-Id: Iee484b96f505106613ce2d646898ca7ee3873f28
Signed-off-by: leventecsanyi <levente.csanyi@est.tech>
2 months agoCmSubscription service layer method #1 06/137106/3
mpriyank [Thu, 1 Feb 2024 10:57:02 +0000 (10:57 +0000)]
CmSubscription service layer method #1

- adding a service layer method to check if we have an ongoing
  cmsubscription or not.
- test scenario for the same.
- Other service layer method to be introduced in the subsequent patches.

Issue-ID: CPS-2042
Change-Id: I33637138457a0c5d49b80dd4967057bd5bfa69d4
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2 months agoDocumentation update for Delta Feature 01/137001/7
Arpit Singh [Tue, 30 Jan 2024 05:21:28 +0000 (10:51 +0530)]
Documentation update for Delta Feature

 - Documantation about Delta Feature
 - Documantation on API 1: Delta between 2 anchors

Issue-ID: CPS-2056
Signed-off-by: Arpit Singh <as00745003@techmahindra.com>
Change-Id: I9841ea166f7c57ab6218fefa5b577b4053e39490

2 months agoAdd integration test for extending API: Get Module Definitions 99/137099/3
halil.cakal [Tue, 30 Jan 2024 18:46:45 +0000 (18:46 +0000)]
Add integration test for extending API: Get Module Definitions

- Add new module: bookstore-types
- Import the new module from stores module
- Change integration testwares to comply with
  the new module
- Add new integration test for retrieving module
  definition

Issue-ID: CPS-1135
Change-Id: Ib51c998ceeab50d3fcea212ed55c8ab50ca09257
Signed-off-by: halil.cakal <halil.cakal@est.tech>
2 months agoMerge "Extend API: Get Module Definitions"
Sourabh Sourabh [Thu, 1 Feb 2024 16:57:22 +0000 (16:57 +0000)]
Merge "Extend API: Get Module Definitions"

2 months agoExtend API: Get Module Definitions 85/137085/8
halil.cakal [Tue, 23 Jan 2024 10:05:36 +0000 (10:05 +0000)]
Extend API: Get Module Definitions

- add query parameters: module-name and revision to OpenAPI
- extend the controller method to hande the new parameters
- add the new method stack to the service layer
- extend the SQL query to support the new parameters
- add unit and integration testwares

Issue-ID: CPS-1135
Change-Id: I089ad2ad71effb58ac0ba809e9f441d6cdb59c4f
Signed-off-by: halil.cakal <halil.cakal@est.tech>
2 months agoCmSubscription validate datastore 08/137108/2
mpriyank [Thu, 1 Feb 2024 12:48:34 +0000 (12:48 +0000)]
CmSubscription validate datastore

- introduced isValidDatastore to check the incoming datastore against
  the valid datastore for this use case.
- Testware added

Issue-ID: CPS-2059
Change-Id: I2602396fe2f404789fc4e0f01850eeba2a75bd21
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2 months agoLimit heap size in Groovy integration tests 89/137089/3
danielhanrahan [Mon, 29 Jan 2024 14:28:06 +0000 (14:28 +0000)]
Limit heap size in Groovy integration tests

Configure maven to limit heap size in integration tests to
help detect OutOfMemory errors in groovy tests.
The figure 512MB was chosen as this is 25% of 2GB
(JVM by default uses 25% of total memory for heap).

Issue-ID: CPS-2052
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: Ie1160f85ba3970e4c43fccee41c2821dc83a8e53

2 months agoSet resource limits of docker-compose containers 88/137088/3
danielhanrahan [Mon, 29 Jan 2024 13:44:13 +0000 (13:44 +0000)]
Set resource limits of docker-compose containers

Without explicit limits, docker will use all available system
resources for containers. In order to better detect/reproduce
performance issues, limits are set to reflect those used in our
production deployment.

Issue-ID: CPS-2048
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: I0549b7f9e57dff10c8b09d839ffb4979d66c643e

2 months agoIntroduce Hazelcast for alternateId-cmHandle relation 74/136974/26
leventecsanyi [Thu, 11 Jan 2024 11:53:26 +0000 (12:53 +0100)]
Introduce Hazelcast for alternateId-cmHandle relation

    - added new Hazelcast config
    - added cache initialization in CmHandleIdMapper
    - added unit tests
    - updated deployment.rst
    - refactored cache updating

Issue-ID: CPS-1988
Change-Id: Iea6f884e584bf8cea8612ddbced4329e783c60a5
Signed-off-by: leventecsanyi <levente.csanyi@est.tech>
3 months agoFix: Add six as dependency for sphinxcontrib-swaggerdoc 03/137103/1
Jessica Wagantall [Wed, 31 Jan 2024 19:59:37 +0000 (11:59 -0800)]
Fix: Add six as dependency for sphinxcontrib-swaggerdoc

Issue-ID: CIMAN-33
Change-Id: Ic9f1fcc4e220163e20bf61da0511d7479eb4f180
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>
3 months agoMerge "Correct datastore names via DatastoreType Enum"
Priyank Maheshwari [Mon, 29 Jan 2024 13:33:05 +0000 (13:33 +0000)]
Merge "Correct datastore names via DatastoreType Enum"

3 months agoCorrect datastore names via DatastoreType Enum 78/137078/2
emaclee [Wed, 24 Jan 2024 18:46:15 +0000 (18:46 +0000)]
Correct datastore names via DatastoreType Enum

- Use existing DatastoreType enum in defining datastore name

Issue-ID: CPS-2046
Change-Id: I6f2f77c96b239546f7141267c0c01edfc599b445
Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
3 months agoCloudEvents support for cps-core 72/137072/5
mpriyank [Tue, 23 Jan 2024 15:48:07 +0000 (15:48 +0000)]
CloudEvents support for cps-core

- Moving cloud events dependencies to the cps-service module instead of
  cps-ncmp-service
- Testware has moved and new tests also introduced
- EventsPublisher also moved

Issue-ID: CPS-2040
Change-Id: Ibafb15e7e9efbdbe1e00e2b4f0da820bbcead004
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
3 months agoMerge "Omitting the basic auth header in healthcheck test"
Priyank Maheshwari [Thu, 25 Jan 2024 13:38:02 +0000 (13:38 +0000)]
Merge "Omitting the basic auth header in healthcheck test"

3 months agoOmitting the basic auth header in healthcheck test 81/137081/3
waqas.ikram [Thu, 25 Jan 2024 11:36:16 +0000 (11:36 +0000)]
Omitting the basic auth header in healthcheck test

as it is not required and adding v3 to uri of api-docs

Issue-ID: CPS-2045
Change-Id: If229bbd46a5c5187ddac242f8bfda00d5c951995
Signed-off-by: waqas.ikram <waqas.ikram@est.tech>
3 months agoMerge "CPS 1824: Delta Between 2 Anchors release notes"
Toine Siebelink [Thu, 25 Jan 2024 12:42:14 +0000 (12:42 +0000)]
Merge "CPS 1824: Delta Between 2 Anchors release notes"

3 months agoMerge "Add retry mechanism instead of sleep"
Toine Siebelink [Tue, 23 Jan 2024 12:02:12 +0000 (12:02 +0000)]
Merge "Add retry mechanism instead of sleep"

3 months agoAdd retry mechanism instead of sleep 61/137061/5
JvD_Ericsson [Mon, 22 Jan 2024 13:32:34 +0000 (13:32 +0000)]
Add retry mechanism instead of sleep

- replaced sleeps with retry mechanism
- removed unnecessary sleeps before polling
- changed formatting

Issue-ID: CPS-1093
Signed-off-by: JvD_Ericsson <jeff.van.dam@est.tech>
Change-Id: I7e26570eeedea09fd36f9c9bce87c4cd45906aa9

3 months agoCmSubscription review comments 68/137068/1
mpriyank [Mon, 22 Jan 2024 15:46:37 +0000 (15:46 +0000)]
CmSubscription review comments

- Removed the old deprecated cmSubscription json examples
- Incorporated minor review comments from myself

Issue-ID: CPS-1951
Change-Id: Ifadaa186cc210b81bb1b27f73f537e1c11bf461d
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
3 months agoRead and validate incoming sub create request from Kafka 96/136896/12
seanbeirne [Wed, 20 Dec 2023 16:37:37 +0000 (16:37 +0000)]
Read and validate incoming sub create request from Kafka

Issue-ID: CPS-1951
Signed-off-by: seanbeirne <sean.beirne@est.tech>
Change-Id: I402dacc47c93e77a4ca63598acebe27c780951de

3 months agoMerge "Remove Lambda & Restructure File"
Lee Anjella Macabuhay [Mon, 22 Jan 2024 09:40:02 +0000 (09:40 +0000)]
Merge "Remove Lambda & Restructure File"

3 months agoMerge "Use PollingConditions to improve intermittent test failure"
Toine Siebelink [Mon, 22 Jan 2024 08:35:36 +0000 (08:35 +0000)]
Merge "Use PollingConditions to improve intermittent test failure"

3 months agoMerge "Remove onboarding of old solution subscription model"
Priyank Maheshwari [Fri, 19 Jan 2024 13:56:22 +0000 (13:56 +0000)]
Merge "Remove onboarding of old solution subscription model"

3 months agoRemove Lambda & Restructure File 26/137026/2
seanbeirne [Wed, 17 Jan 2024 15:18:10 +0000 (15:18 +0000)]
Remove Lambda & Restructure File

-Removed Lambda from CompositeStateUtils
-Restructured CpsDataPersistenceServiceImpl to more logical layout

Issue-ID: CPS-1238
Change-Id: I09096dab474230d04b15c204cbea95a2f1285366
Signed-off-by: seanbeirne <sean.beirne@est.tech>
3 months agoCPS 1824: Delta Between 2 Anchors release notes 94/136994/1
Arpit Singh [Fri, 19 Jan 2024 08:16:03 +0000 (13:46 +0530)]
CPS 1824: Delta Between 2 Anchors release notes

Updated release notes for Delta Feature

Issue-ID: CPS-1824
Signed-off-by: Arpit Singh <as00745003@techmahindra.com>
Change-Id: I1c2403391e85aec6a9e34f0ff616c17b100bf6a9

3 months agoRemove onboarding of old solution subscription model 54/137054/2
emaclee [Thu, 18 Jan 2024 17:27:54 +0000 (17:27 +0000)]
Remove onboarding of old solution subscription model

-Remove onboarding of old subscription model
-Remove initial solution subscription model

Change-Id: Id930dcfd078d71e7c275d0a3ef1117f8fed2e9d3
Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
3 months agoMerge "CPS Delta API: Update action for delta service"
Toine Siebelink [Thu, 18 Jan 2024 16:51:48 +0000 (16:51 +0000)]
Merge "CPS Delta API: Update action for delta service"

3 months agoMerge "Create datastores for NCMP w/subscription model"
Priyank Maheshwari [Thu, 18 Jan 2024 15:07:38 +0000 (15:07 +0000)]
Merge "Create datastores for NCMP w/subscription model"

3 months agoUse PollingConditions to improve intermittent test failure 25/137025/3
JvD_Ericsson [Thu, 11 Jan 2024 11:57:17 +0000 (11:57 +0000)]
Use PollingConditions to improve intermittent test failure

Set timeOutInMilliSeconds to 100 (default was 0)

Issue-ID: CPS-1950
Signed-off-by: JvD_Ericsson <jeff.van.dam@est.tech>
Change-Id: I0028f0cd5e5e89d979d4200df77dbd7a42105622

3 months agoMerge "Remove deprecated cmSubscription code"
Lee Anjella Macabuhay [Thu, 18 Jan 2024 10:09:30 +0000 (10:09 +0000)]
Merge "Remove deprecated cmSubscription code"

3 months agoCreate datastores for NCMP w/subscription model 22/137022/4
emaclee [Wed, 17 Jan 2024 11:59:29 +0000 (11:59 +0000)]
Create datastores for NCMP w/subscription model

Issue-ID: CPS-2035
Change-Id: I80234c7ca93c5774ee50082803cdc102f693a5a7
Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
3 months agoRemove deprecated cmSubscription code 80/136980/13
mpriyank [Fri, 12 Jan 2024 11:12:13 +0000 (11:12 +0000)]
Remove deprecated cmSubscription code

- Newer approach for cm subscription is in progress so removing the
  deprecated code now
- Also deleted the old cache config
- Changes to trust level csit to fix the kafka unknown partition issue

Issue-ID: CPS-2028
Change-Id: Ieb19669e53f3f64cca876fa67d0b6409a97b2a09
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
3 months agoClear instance based Schema Context Cache upon validation errors 24/137024/3
ToineSiebelink [Tue, 16 Jan 2024 08:40:51 +0000 (08:40 +0000)]
Clear instance based Schema Context Cache upon validation errors

- retry yang parser exceptions one time by clearing cache
- split yangUtils into YangParserHelper (instance based) and YangUtils for non-parsering static methods
- removed public methods only used from test. Refactored to use variation with (empty) parent path
- removed use of optional for parentPath, easier to handle with just an empty string!
- make methods no longer used in production code in YangUtils are private
- udpate testware to use proper public methods instead of private methods of yang utils / parser (helper)

Issue-ID:CPS-2000

Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
Change-Id: I0c7590a5e1495d047006e7136f1bd873be37f7b0

3 months agoCPS Delta API: Update action for delta service 19/136619/29
Arpit Singh [Tue, 21 Nov 2023 15:31:43 +0000 (21:01 +0530)]
CPS Delta API: Update action for delta service

- Added code for Update action in Delta service
- added method to get updated Leaf data: getUpdatedLeavesBetweenSourceAndTargetDataNode
- added method to compare Leaf data common in source and target data
  node
- added method to process leaves unique to target data node
- added method to compare leaves: compareLeaves
- added method to store updated data to a DeltaReport: addUpdatedLeavesToDeltaReport
- Added corresponding testware

Issue-ID: CPS-1824
Signed-off-by: Arpit Singh <as00745003@techmahindra.com>
Change-Id: I3de07ea3227988784a0892f6a92c238ecf00a7fa

3 months agoAdd CSIT test for CPS Swagger UI 57/136957/4
halil.cakal [Wed, 10 Jan 2024 11:32:59 +0000 (11:32 +0000)]
Add CSIT test for CPS Swagger UI

- Test that CPS Swagerr UI is accessible.

Issue-ID: CPS-1916
Signed-off-by: halil.cakal <halil.cakal@est.tech>
Change-Id: Id8dba21f400412fc8b81892e29454f8606e53008

3 months agoTesting for jenkins plugin 90/136990/1
emaclee [Mon, 15 Jan 2024 12:58:27 +0000 (12:58 +0000)]
Testing for jenkins plugin

Issue-ID: CPS-1953
Change-Id: I3ee12576e75449c90c789de32a50f9b8e8757ff7
Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
3 months agoMerge "Create tests for EventPublisher error scenarios"
Toine Siebelink [Mon, 15 Jan 2024 10:29:14 +0000 (10:29 +0000)]
Merge "Create tests for EventPublisher error scenarios"

3 months agoBump CPS to 3.4.3-SNAPSHOT 75/136975/1
danielhanrahan [Thu, 11 Jan 2024 15:25:18 +0000 (15:25 +0000)]
Bump CPS to 3.4.3-SNAPSHOT

- bump CPS to 3.4.3-SNAPSHOT and update the docs

Issue-ID: CPS-2026
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: If0036c6245ddbae2a401b712cc13e3208491ed2f

3 months agoAdd container yaml for CPS 3.4.2 73/136973/1
danielhanrahan [Thu, 11 Jan 2024 15:05:08 +0000 (15:05 +0000)]
Add container yaml for CPS 3.4.2

- added container yaml to release the docker images for CPS 3.4.2

Issue-ID: CPS-2026
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: I6970a99894ceed26a982350663533cb344ec3e50

3 months agoAdd maven stage yaml for CPS 3.4.2 72/136972/1
danielhanrahan [Thu, 11 Jan 2024 14:52:50 +0000 (14:52 +0000)]
Add maven stage yaml for CPS 3.4.2

- maven stage yaml to release 3.4.2

Issue-ID: CPS-2026
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: Ibe7d85c81383e678783c10383bf142523c8cdf51

3 months agoCreate tests for EventPublisher error scenarios 56/136956/5
JvD_Ericsson [Wed, 10 Jan 2024 11:01:05 +0000 (11:01 +0000)]
Create tests for EventPublisher error scenarios

  - Added tests for error scenarios
  - Added tests for expected scenarios

Issue-ID: CPS-1978
Signed-off-by: JvD_Ericsson <jeff.van.dam@est.tech>
Change-Id: I6ba19ac456098f074e634f7cf70fdc141491c635

3 months agoMerge "Improve dmi plugin csit stub - Modified dmi plugin stub to return diff....
Toine Siebelink [Thu, 11 Jan 2024 14:25:42 +0000 (14:25 +0000)]
Merge "Improve dmi plugin csit stub   - Modified dmi plugin stub to return diff. modules based on cm handle     id"

3 months agoUpdate release notes for 3.4.2 68/136968/2
halil.cakal [Thu, 11 Jan 2024 11:10:17 +0000 (11:10 +0000)]
Update release notes for 3.4.2

- Add Trust Level epic to the release notes

Issue-ID: CPS-2024
Change-Id: Ie5425bca6e3d48b957c703af50c7542c4401d1b4
Signed-off-by: halil.cakal <halil.cakal@est.tech>