Remove "isTagged" mapping method 83/134083/1
authorlukegleeson <luke.gleeson@est.tech>
Wed, 12 Apr 2023 13:04:47 +0000 (14:04 +0100)
committerlukegleeson <luke.gleeson@est.tech>
Wed, 12 Apr 2023 13:06:27 +0000 (14:06 +0100)
Remove redundant mapping method causing sonarqube violation

Issue-ID: CPS-1394
Signed-off-by: lukegleeson <luke.gleeson@est.tech>
Change-Id: Ie3ed1411c05fcc3671e547b80b41826dcd6e1fab

cps-ncmp-service/src/main/java/org/onap/cps/ncmp/api/impl/event/avc/SubscriptionEventMapper.java

index 44f9abb..e18448d 100644 (file)
@@ -33,7 +33,7 @@ public interface SubscriptionEventMapper {
 
     @Mapping(source = "event.subscription.clientID", target = "clientId")
     @Mapping(source = "event.subscription.name", target = "subscriptionName")
-    @Mapping(source = "event.subscription.isTagged", target = "tagged", qualifiedByName = "mapIsTagged")
+    @Mapping(source = "event.subscription.isTagged", target = "tagged")
     @Mapping(source = "event.predicates.targets",
         target = "predicates.targetCmHandles", qualifiedByName = "mapTargetsToCmHandleTargets")
     @Mapping(source = "event.predicates.datastore", target = "predicates.datastore")
@@ -44,9 +44,4 @@ public interface SubscriptionEventMapper {
         return targets.stream().map(
             target -> new YangModelSubscriptionEvent.TargetCmHandle(target.toString())).collect(Collectors.toList());
     }
-
-    @Named("mapIsTagged")
-    default boolean mapIsTagged(Boolean isTagged) {
-        return (isTagged == null) ? false : isTagged;
-    }
 }