Fix sonar bugs

Fix Sonar bugs and bad comments in the code

Issue-ID: CLAMP-147
Change-Id: I4cc8e00a0d063396b7dd6ac6c7fcf408607f998e
Signed-off-by: Determe, Sebastien (sd378r) <sd378r@intl.att.com>

diff --git a/src/main/java/org/onap/clamp/clds/config/spring/CldsSdcControllerConfiguration.java b/src/main/java/org/onap/clamp/clds/config/spring/CldsSdcControllerConfiguration.java
index 09d4d63..c191dbc 100644 (file)
--- a/src/main/java/org/onap/clamp/clds/config/spring/CldsSdcControllerConfiguration.java
+++ b/src/main/java/org/onap/clamp/clds/config/spring/CldsSdcControllerConfiguration.java
@@ -75,7 +75,7 @@ public class CldsSdcControllerConfiguration {
             try {
                 e.closeSdc();
             } catch (SdcControllerException e1) {
-                logger.error("Exception caught during initialization of sdc controller", e);
+                logger.error("Exception caught during initialization of sdc controller", e1);
             }
         });
     }

diff --git a/src/main/java/org/onap/clamp/clds/service/CldsTemplateService.java b/src/main/java/org/onap/clamp/clds/service/CldsTemplateService.java
index 7a9ee70..f26d746 100644 (file)
--- a/src/main/java/org/onap/clamp/clds/service/CldsTemplateService.java
+++ b/src/main/java/org/onap/clamp/clds/service/CldsTemplateService.java
@@ -23,10 +23,6 @@
 
 package org.onap.clamp.clds.service;
 
-import com.fasterxml.jackson.core.JsonParseException;
-import com.fasterxml.jackson.databind.JsonMappingException;
-
-import java.io.IOException;
 import java.util.Date;
 import java.util.List;
 
@@ -147,9 +143,8 @@ public class CldsTemplateService extends SecureServiceBase {
      * REST service that saves a CLDS template by name in the database.
      *
      * @param templateName
-     * @throws IOException
-     * @throws JsonMappingException
-     * @throws JsonParseException
+     * @param cldsTemplate
+     * @return The CldsTemplate modified and saved in DB
      */
     @PUT
     @Path("/template/{templateName}")