Fix potential NPE 33/49133/1
authorDeterme, Sebastien (sd378r) <sd378r@intl.att.com>
Fri, 25 May 2018 14:37:10 +0000 (16:37 +0200)
committerDeterme, Sebastien (sd378r) <sd378r@intl.att.com>
Fri, 25 May 2018 14:37:10 +0000 (16:37 +0200)
Fix policyversion that can be null in getConfig method

Issue-ID: CLAMP-153
Change-Id: Idd26a2b1a33cd0ae82b45e6070746ff4f8b5e7ea
Signed-off-by: Determe, Sebastien (sd378r) <sd378r@intl.att.com>
src/main/java/org/onap/clamp/clds/client/req/policy/PolicyClient.java

index 9fff4ef..1e423ff 100644 (file)
@@ -336,8 +336,12 @@ public class PolicyClient {
         try {
             Collection<PolicyConfig> response = getPolicyEngine().getConfig(configRequestParameters);
             for (PolicyConfig policyConfig : response) {
-                Integer version = Integer.valueOf(policyConfig.getPolicyVersion());
-                versions.add(version);
+                if (policyConfig.getPolicyVersion() != null) {
+                    Integer version = Integer.valueOf(policyConfig.getPolicyVersion());
+                    versions.add(version);
+                } else {
+                    logger.warn("Policy version was null, unable to convert it to Integer");
+                }
             }
             Collections.sort(versions);
             logger.info("Policy versions.size()=" + versions.size());