Sonar fix: LeafListHolderNode.java

Fixed sonar isues/code-smells across this file

Issue-ID: CCSDK-885
Change-Id: I6c49463b3d0fa387caecc8023e2fdcac5a2c98c2
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>

diff --git a/restconf-client/provider/src/main/java/org/onap/ccsdk/sli/plugins/yangserializers/pnserializer/LeafListHolderNode.java b/restconf-client/provider/src/main/java/org/onap/ccsdk/sli/plugins/yangserializers/pnserializer/LeafListHolderNode.java
index 985bc1d..46ab5bb 100644 (file)
--- a/restconf-client/provider/src/main/java/org/onap/ccsdk/sli/plugins/yangserializers/pnserializer/LeafListHolderNode.java
+++ b/restconf-client/provider/src/main/java/org/onap/ccsdk/sli/plugins/yangserializers/pnserializer/LeafListHolderNode.java
@@ -4,6 +4,8 @@
  * ================================================================================
  * Copyright (C) 2018 Huawei Technologies Co., Ltd. All rights reserved.
  * ================================================================================
+ * Modifications Copyright © 2018 IBM
+ * ================================================================================
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
  * You may obtain a copy of the License at
@@ -28,6 +30,8 @@ import org.onap.ccsdk.sli.core.sli.SvcLogicException;
  */
 public class LeafListHolderNode extends HolderNode<LeafListHolderChild> implements DataNodeChild {
 
+    private static final String node = " holder node";
+
     /**
      * Creates an instance of LeafListHolderNode.
      *
@@ -50,7 +54,7 @@ public class LeafListHolderNode extends HolderNode<LeafListHolderChild> implemen
                                    Namespace valueNs,
                                    Object appInfo) throws SvcLogicException {
         throw new SvcLogicException("Leaf cannot be child of leaf-list" +
-                                                   " holder node");
+                                                   node);
     }
 
     @Override
@@ -58,7 +62,7 @@ public class LeafListHolderNode extends HolderNode<LeafListHolderChild> implemen
                                    NodeType type,
                                    Object appInfo) throws SvcLogicException {
         throw new SvcLogicException("Container cannot be child of leaf-list" +
-                                                   " holder node");
+                                                   node);
     }
 
     @Override
@@ -67,7 +71,7 @@ public class LeafListHolderNode extends HolderNode<LeafListHolderChild> implemen
                                    NodeType type,
                                    Object appInfo) throws SvcLogicException {
         throw new SvcLogicException("List cannot be child of leaf-list" +
-                                                   " holder node");
+                                                   node);
     }
 
     @Override