Fix Sonar Issue in sli/plugins module 29/12929/1
authorsurya-huawei <a.u.surya@huawei.com>
Sun, 17 Sep 2017 17:55:14 +0000 (23:25 +0530)
committersurya-huawei <a.u.surya@huawei.com>
Sun, 17 Sep 2017 17:55:14 +0000 (23:25 +0530)
One major issue
* move string literal to left side
of string comparison

Issue-Id: CCSDK-87

Change-Id: I1277c4c5515bd45ad6854c63cf6160f17b7725d0
Signed-off-by: surya-huawei <a.u.surya@huawei.com>
restapi-call-node/provider/src/main/java/org/onap/ccsdk/sli/plugins/restapicall/RestapiCallNode.java

index 4984d1b..ca227c7 100644 (file)
@@ -559,7 +559,7 @@ public class RestapiCallNode implements SvcLogicJavaPlugin {
         p.httpMethod = HttpMethod.fromString(parseParam(paramMap, "httpMethod", false, "post"));
         p.responsePrefix = parseParam(paramMap, "responsePrefix", false, null);
         String skipSendingStr = paramMap.get("skipSending");
-        p.skipSending = skipSendingStr != null && skipSendingStr.equalsIgnoreCase("true");
+        p.skipSending = "true".equalsIgnoreCase(skipSendingStr);
         return p;
     }