appc.git
4 years agoRelease appc 1.6.3
jenkins-releng [Wed, 11 Sep 2019 22:22:18 +0000 (22:22 +0000)]
Release appc

4 years agoChange to released parent 1.6.1 39/95539/1
Patrick Brady [Wed, 11 Sep 2019 18:31:45 +0000 (11:31 -0700)]
Change to released parent 1.6.1

Change-Id: Ieb506dd5bcc146a45c9e75ec27641f80245548e3
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1686

4 years agoIncrement version to 1.6.3-SNAPSHOT 18/95518/2
Patrick Brady [Wed, 11 Sep 2019 17:50:54 +0000 (10:50 -0700)]
Increment version to 1.6.3-SNAPSHOT

Change-Id: I2b1b8329dbad5a8d6cc5ae96e8c44af1ab3d54ea
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1686

4 years agoFix eelf resource not found 16/95416/2
Patrick Brady [Tue, 10 Sep 2019 19:55:45 +0000 (12:55 -0700)]
Fix eelf resource not found

The eelf package needs to be exported from appc-common
where the resource bundle is added. Doing this was
causing karaf to crash on install of artifact-handler.
The cause was all of the classes being exported by the
maven shade plugin of appc-yang-generator. Removing the
shade plugin seemed to have no bad consequences.

Change-Id: Ic0758b342b8109e28ec8e11a48b2693cea7b56db
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1713

4 years agoChanges to remove maven-staging-plugin 84/95084/2
Patrick Brady [Thu, 5 Sep 2019 19:12:34 +0000 (12:12 -0700)]
Changes to remove maven-staging-plugin

Root pom ccsdk version updated to latest and
dependency versions are fixed so that they are
compliant with the maven enforcer plugin.

Change-Id: If85006519678a14af6ace21268eb0bfc195e4215
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1686

4 years agoChanges to fix feature installs 03/94303/4
Patrick Brady [Mon, 26 Aug 2019 20:54:22 +0000 (13:54 -0700)]
Changes to fix feature installs

Feature installs were causing karaf to freeze following
the upgrade to the Fluorine SR2 version of ODL. These
changes correct the problems.

Change-Id: I8e5a41ba6816da782fea3ebaef3b6918cfc1ad4c
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1630

4 years agoUpdated jersey from com.sun.jersey to org.glassfish.jersey 50/93450/6
vmuthukrishnan [Tue, 13 Aug 2019 17:44:22 +0000 (17:44 +0000)]
Updated jersey from com.sun.jersey to org.glassfish.jersey

ODL upgrade

Change-Id: I1167ad7cdb429c9c3e2808db820e3fc26e605383
Signed-off-by: vmuthukrishnan <vmuthukrishnan@aarnanetworks.com>
Issue-ID: APPC-1630

4 years agoChange parent version to snapshot 08/94308/2
Patrick Brady [Mon, 26 Aug 2019 21:28:53 +0000 (14:28 -0700)]
Change parent version to snapshot

Changing the parent version to snapshot in order to
build with the new version of appc parent which has
the Fluorine SR2 ccsdk parent poms.

Change-Id: I03d9a0d38b6d97bab17cd887562ae42ed1b19611
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1630

4 years agoupdate INFO.yaml 26/94126/1
Taka Cho [Thu, 22 Aug 2019 14:25:47 +0000 (10:25 -0400)]
update INFO.yaml

Add change section

Issue-ID: APPC-1685
Change-Id: Ie4e2227dc1d6c35ba192613eaa245311796b4bd9
Signed-off-by: Taka Cho <takamune.cho@att.com>
4 years agoAPPC-1681- remove the thrown exception 'org.json.JSONException' which is a runtime... 78/92378/2
Thugutla Sailakshmi [Wed, 31 Jul 2019 15:24:03 +0000 (20:54 +0530)]
APPC-1681- remove the thrown exception 'org.json.JSONException' which is a runtime exception.

remove the thrown exception

Issue-ID: APPC-1681
Change-Id: I940a5dd42bfe7a52b39be81a016cf4cf47805cae
Signed-off-by: Thugutla Sailakshmi <tsaila10@in.ibm.com>
4 years agoAPPC-1681 -Rename this local variable to match the regular expression '^[a-z][a-zA... 69/92369/2
Thugutla Sailakshmi [Wed, 31 Jul 2019 14:54:36 +0000 (20:24 +0530)]
APPC-1681 -Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'.

APPC-1681 -Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'.

Issue-ID: APPC-1681
Change-Id: I7f6926bfa1a4f57d99d6732492281b36f041922f
Signed-off-by: Thugutla Sailakshmi <tsaila10@in.ibm.com>
4 years agoSonar Fix- ProviderOperation.java 34/92334/2
dinesha [Wed, 31 Jul 2019 09:10:52 +0000 (14:40 +0530)]
Sonar Fix- ProviderOperation.java

Fixed Sonar Issues accross the file

Issue-ID: APPC-1669
Change-Id: Idccc7e133a93f0af8d2352473d95f755f39f1ae7
Signed-off-by: dinesha <dineshgs@in.ibm.com>
4 years agoRevert changes to parent poms 38/93138/1
Patrick Brady [Fri, 9 Aug 2019 00:03:47 +0000 (17:03 -0700)]
Revert changes to parent poms

These changes did not work

Change-Id: Ie90d1bf4795cad916f8aea00af9a8cf5bcc847ed
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1686

4 years agoChange parent poms 32/93132/1
Patrick Brady [Thu, 8 Aug 2019 21:58:52 +0000 (14:58 -0700)]
Change parent poms

Changing the parent pom of appc-dispatcher and
appc-directed-graph so that they no longer point
to the root appc pom, instead they point to the
org.onap.appc.parent pom files.

Change-Id: I116bd06471482e19715a3c5ada506f9d700e5576
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1686

4 years agoAttempt to disable nexus staging 20/93120/1
Patrick Brady [Thu, 8 Aug 2019 19:16:26 +0000 (12:16 -0700)]
Attempt to disable nexus staging

Change-Id: Ice20bc6259d9f30438f23e9f8e6c875f4119fee3
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1686

4 years agoAdd 1.6.2 release file 73/92973/1
Patrick Brady [Wed, 7 Aug 2019 21:57:50 +0000 (14:57 -0700)]
Add 1.6.2 release file

Change-Id: Ib8f13865e9702099e99593b1fa301e1dc2da8ec2
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1686

4 years agoChange to release parent version 57/92957/1
Patrick Brady [Wed, 7 Aug 2019 20:12:28 +0000 (13:12 -0700)]
Change to release parent version

Change-Id: If572b36cdf00e3c6ada36181fb6c678fbd978e72
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1686

4 years agoIncrement version to 1.6.2 55/92955/1
Patrick Brady [Wed, 7 Aug 2019 20:05:39 +0000 (13:05 -0700)]
Increment version to 1.6.2

Change-Id: If6610d1addd323c1ad0f902a0841b979f017adc9
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1686

4 years agoAdd release file for 1.6.1 50/92750/1
Patrick Brady [Tue, 6 Aug 2019 05:38:23 +0000 (22:38 -0700)]
Add release file for 1.6.1

Change-Id: I19a543c1fea16823039d00290d4831dbeb35c1ea
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1686

4 years agoIncrement versions after release 36/92636/1
Patrick Brady [Sun, 4 Aug 2019 06:06:41 +0000 (23:06 -0700)]
Increment versions after release

Change-Id: I83b000b7c4ac94b5eba396b5e1856a970fa90623
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1686

4 years agoupdate INFO.yaml 58/92458/2
Taka Cho [Thu, 1 Aug 2019 12:15:28 +0000 (08:15 -0400)]
update INFO.yaml

remove Joss from committer

Issue-ID: APPC-1685
Change-Id: Id223a31e6870a00708e5a0aa3c36d725c4284524
Signed-off-by: Taka Cho <takamune.cho@att.com>
4 years agoAdd release file for 1.6.0 release 24/92424/2
Patrick Brady [Wed, 31 Jul 2019 23:10:43 +0000 (16:10 -0700)]
Add release file for 1.6.0 release

Change-Id: I9ba4c926097457c6d540bdb26efc1967a434249e
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1684

4 years agoSonar Fix- AnsibleServerEmulator.java 70/92170/4
dinesha [Mon, 29 Jul 2019 07:39:51 +0000 (13:09 +0530)]
Sonar Fix- AnsibleServerEmulator.java

Fixed Sonar issues accross the file

Issue-ID: APPC-1669
Change-Id: I49db3c6c23f5cf61fe8d898662abaeb14f7c4422
Signed-off-by: dinesha <dineshgs@in.ibm.com>
4 years agoSonar Fix- RestoreStack.java 98/92198/2
dinesha [Mon, 29 Jul 2019 13:02:12 +0000 (18:32 +0530)]
Sonar Fix- RestoreStack.java

Fixed Sonar issues accross the file

Issue-ID: APPC-1669
Change-Id: Icd598fa6c9954c22d4bfd7ab0155823e8b946638
Signed-off-by: dinesha <dineshgs@in.ibm.com>
4 years agoSonar- Unused Import 68/92268/1
anushadasari [Tue, 30 Jul 2019 11:45:17 +0000 (17:15 +0530)]
Sonar- Unused Import

The imports part of a file should be handled by the Integrated Development Environment (IDE), not manually by the developer.

Unused and useless imports should not occur if that is the case.

Issue-ID: APPC-1677
Change-Id: Ieb7f01df8fc1f639c232ca47eefa2145fe45d965
Signed-off-by: anushadasari <danush10@in.ibm.com>
4 years agoMajor- Unused "context" local variable. 55/92255/1
anushadasari [Tue, 30 Jul 2019 09:19:51 +0000 (14:49 +0530)]
Major- Unused "context" local variable.

If a local variable is declared but not used, it is dead code and should be removed. Doing so will improve maintainability because developers will not wonder what the variable is used for.

Issue-ID: APPC-1675
Change-Id: I9cccd6fd529591cbbe7095cce9d5687a712f42d9
Signed-off-by: anushadasari <danush10@in.ibm.com>
4 years agoAAPC-1659 removing unused import 36/91936/4
Thugutla Sailakshmi [Wed, 24 Jul 2019 10:13:38 +0000 (15:43 +0530)]
AAPC-1659 removing unused import

removing unused import

Issue-ID: APPC-1659
Change-Id: Ib7696e4e0fbefe329eda4eb56feb24701f17c4e6
Signed-off-by: Thugutla Sailakshmi <tsaila10@in.ibm.com>
4 years agoSonarFix- MigrateServer.java 75/92175/1
anushadasari [Mon, 29 Jul 2019 07:56:30 +0000 (13:26 +0530)]
SonarFix- MigrateServer.java

The imports part of a file should be handled by the Integrated Development Environment (IDE), not manually by the developer.
Unused and useless imports should not occur if that is the case.
Leaving them in reduces the code's readability, since their presence can be confusing.

Change-Id: Ic0af785e3d3863f4555ab9614d7a8b3b0f2150b3
Issue-ID: APPC-1670
Signed-off-by: anushadasari <danush10@in.ibm.com>
4 years agoAPPC-1663 63/91963/3
anushadasari [Wed, 24 Jul 2019 17:19:21 +0000 (22:49 +0530)]
APPC-1663

The imports part of a file should be handled by the Integrated Development Environment (IDE), not manually by the developer.
Unused and useless imports should not occur if that is the case.
Leaving them in reduces the code's readability, since their presence can be confusing.

Issue-ID: APPC-1663
Change-Id: I98a98f59847a4cdea298f82531530db4048b65b0
Signed-off-by: anushadasari <danush10@in.ibm.com>
4 years agoAAPC-1658 removing unused import 35/91935/3
Thugutla Sailakshmi [Wed, 24 Jul 2019 09:09:20 +0000 (14:39 +0530)]
AAPC-1658 removing unused import

removing unused import

Issue-ID: APPC-1658
Change-Id: I3eb674031487937b461d045c31d4aa9108b38de6
Signed-off-by: Thugutla Sailakshmi <tsaila10@in.ibm.com>
4 years agoSonarFix-Remove declaration of thrown exception 23/92023/2
anushadasari [Thu, 25 Jul 2019 16:01:56 +0000 (21:31 +0530)]
SonarFix-Remove declaration of thrown exception

Remove the declaration of thrown exception 'org.onap.appc.exceptions.APPCException', as it cannot be thrown from method's body.

Issue-ID: APPC-1664
Change-Id: I0c66da105d735b4ac97ee35d1e6bea122be80722
Signed-off-by: anushadasari <danush10@in.ibm.com>
4 years agoPrepared statements for DG services 96/91896/3
Patrick Brady [Tue, 23 Jul 2019 18:54:01 +0000 (11:54 -0700)]
Prepared statements for DG services

Convert sql queries to prepared statements in other
parts of appc.

Change-Id: If29225394de2ab286e4f2f7bdd17f6af6b286576
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: OJSI-25

4 years agoAdd value of the arguments 70/91770/2
Patrick Brady [Fri, 19 Jul 2019 20:03:02 +0000 (13:03 -0700)]
Add value of the arguments

Also apply the valueof to non svc context arguments.
The original code would always treat null arguments
as null strings. This replaces that functionality
in the prepared statements.

Change-Id: I88ab22c87b86a8f5ff41946757c40a399c37a6c3
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: OJSI-25

4 years agoAAPC-1655 61/91961/2
anushadasari [Wed, 24 Jul 2019 16:54:32 +0000 (22:24 +0530)]
AAPC-1655

The imports part of a file should be handled by the Integrated Development Environment (IDE), not manually by the developer.
Unused and useless imports should not occur if that is the case.
Leaving them in reduces the code's readability, since their presence can be confusing.

Issue-ID: APPC-1655
Change-Id: I64e50083b9b0fe40fa0ba32723e30adb0dbce08e
Signed-off-by: Dasari Anusha <danush10@in.ibm.com>
Signed-off-by: anushadasari <danush10@in.ibm.com>
4 years agoAAPC-1661-remove unused import 'java.util.TimeZone' 37/91937/1
Thugutla Sailakshmi [Wed, 24 Jul 2019 10:20:04 +0000 (15:50 +0530)]
AAPC-1661-remove unused import 'java.util.TimeZone'

remove unused import 'java.util.TimeZone'

Issue-ID: APPC-1661
Change-Id: I94d4c39a83fb815343fd373557a7d36b3e1213b8
Signed-off-by: Thugutla Sailakshmi <tsaila10@in.ibm.com>
4 years agoAPPC -1653 81/91781/5
anushadasari [Sun, 21 Jul 2019 15:23:51 +0000 (20:53 +0530)]
APPC -1653

The imports part of a file should be handled by the Integrated Development Environment (IDE), not manually by the developer.

Unused and useless imports should not occur if that is the case.

Leaving them in reduces the code's readability, since their presence can be confusing.

Issue-ID: APPC-1653
Change-Id: I9e3e3b7994cb689e14b70aab73d5dfea54fa4a1f
Signed-off-by: anushadasari <danush10@in.ibm.com>
4 years agoAPPC-1652- Removing Duplicate import 79/91779/4
anushadasari [Sun, 21 Jul 2019 15:05:13 +0000 (20:35 +0530)]
APPC-1652- Removing Duplicate import

Unused and useless imports should not occur if that is the case.

Leaving them in reduces the code's readability, since their presence can be confusing.

Issue-ID: APPC-1652
Change-Id: I64e50083b9b0fe40fa0ba32723e30adb0dbce08e
Signed-off-by: Dasari Anusha <danush10@in.ibm.com>
Signed-off-by: anushadasari <danush10@in.ibm.com>
Change-Id: I1ddafa429afb23a0eb6cb120a20a774ff9a032b8

4 years agoAPPC-1654 83/91783/2
anushadasari [Sun, 21 Jul 2019 16:52:03 +0000 (22:22 +0530)]
APPC-1654

Remove the declaration of thrown exception 'org.onap.appc.exceptions.APPCException', as it cannot be thrown from method's body.

Issue-ID: APPC-1654
Change-Id: Ib08561aaecf8dea445e0f5ceb3a6d35795dfd8bd
Signed-off-by: anushadasari <danush10@in.ibm.com>
4 years agoremove opendaylight-karaf-empty 50/91750/1
Taka Cho [Fri, 19 Jul 2019 14:28:36 +0000 (10:28 -0400)]
remove opendaylight-karaf-empty

opendaylight-karaf-empty is for testing
purpose and outdated

Issue-ID: APPC-1651
Change-Id: I768b7afa9a60db6413f71320fd11575b1fafce97
Signed-off-by: Taka Cho <takamune.cho@att.com>
4 years agoReplace Lists with new ArrayList 31/91631/1
Patrick Brady [Wed, 17 Jul 2019 22:02:37 +0000 (15:02 -0700)]
Replace Lists with new ArrayList

The Lists.newArrayList method is not being used here in a
way that provides significant benefit over new ArrayList
and Lists was causing a class not found exception.

Change-Id: I61bbfc5e55cb283c10f3681a7e336ae346347d03
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1613

4 years agoFixes for parameterized sql queries 28/91628/1
Patrick Brady [Wed, 17 Jul 2019 20:22:35 +0000 (13:22 -0700)]
Fixes for parameterized sql queries

The old non-parameterized queries would treat null entries in the SvcLogicContext
as "null" string values. The parameterized query treats these as NULL sql values.
This change keeps those values as "null" strings.

Change-Id: Iee7f7a1861bdd82dc65d59db2be7862b49cf1207
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1639

4 years agoSonar Fix - Removed unnecessary cast to Date 56/91256/2
Sudarshan Kumar [Thu, 11 Jul 2019 12:54:46 +0000 (18:24 +0530)]
Sonar Fix - Removed unnecessary cast to Date

Sonar Fix - Removed unnecessary cast to Date

Issue-ID: APPC-1629
Change-Id: Ie37c511ac63abd71708700b376a836e4ed03e92f
Signed-off-by: Sudarshan Kumar <sudars19@in.ibm.com>
4 years agoSonar Fix - Removed unused Variable Utils.java 42/91342/1
Sudarshan Kumar [Fri, 12 Jul 2019 10:50:50 +0000 (16:20 +0530)]
Sonar Fix - Removed unused Variable Utils.java

Sonar Fix - Removed unused Variable Utils.java

Issue-ID: APPC-1629
Change-Id: I557c065ff835834f5eed5eb80bd7136e182217f5
Signed-off-by: Sudarshan Kumar <sudars19@in.ibm.com>
4 years agoSonar Fix - String comparison 39/90939/4
Sudarshan Kumar [Fri, 5 Jul 2019 10:37:36 +0000 (16:07 +0530)]
Sonar Fix - String comparison

Sonar Fix - String comparison

Issue-ID: APPC-1629
Change-Id: I8ea38dfaf629c2be624552a1cf0b0f0e877117cb
Signed-off-by: Sudarshan Kumar <sudars19@in.ibm.com>
4 years agoSonar Fix - String Comparison 49/90949/2
Sudarshan Kumar [Fri, 5 Jul 2019 13:08:38 +0000 (18:38 +0530)]
Sonar Fix - String Comparison

Sonar Fix - String Comparison

Issue-ID: APPC-1629
Change-Id: Ia13da99f101d479aba7009ba4dffc201aa9a3ffe
Signed-off-by: Sudarshan Kumar <sudars19@in.ibm.com>
4 years agoMarked field transient 64/91064/3
jegadeeshbabu1 [Tue, 9 Jul 2019 06:08:14 +0000 (11:38 +0530)]
Marked field transient

Handled non-serializable fields

Issue-ID: APPC-1637
Change-Id: I3398620e396c3f8bc1504eca8d312bc35d3bbbfd
Signed-off-by: jegadeeshbabu1 <jegabab1@in.ibm.com>
4 years agoAdhered serializable class contracts 15/90915/3
jegadeeshbabu1 [Thu, 4 Jul 2019 16:12:37 +0000 (21:42 +0530)]
Adhered serializable class contracts

Marked member transient

Issue-ID: APPC-1634
Change-Id: I7bbbf941e692c2755122f3d40a7ca79c59f21749
Signed-off-by: jegadeeshbabu1 <jegabab1@in.ibm.com>
4 years agoUpdated to be an instance variable 94/90994/3
jegadeeshbabu1 [Sun, 7 Jul 2019 16:49:24 +0000 (22:19 +0530)]
Updated to be an instance variable

Removed static keyword

Issue-ID: APPC-1636
Change-Id: I507d306f50acc010db4d944a078b4d15f5c719a4
Signed-off-by: jegadeeshbabu1 <jegabab1@in.ibm.com>
4 years agoSonar Fix- Removed Unused private field 81/91081/1
Sudarshan Kumar [Tue, 9 Jul 2019 11:21:26 +0000 (16:51 +0530)]
Sonar Fix- Removed Unused private field

Sonar Fix- Removed Unused private field

Issue-ID: APPC-1629
Change-Id: Iaab259140e29200473147097c552f75783e5cd0d
Signed-off-by: Sudarshan Kumar <sudars19@in.ibm.com>
4 years agoFixed netconf-xml parsing issue 63/90163/3
Lathish [Wed, 19 Jun 2019 15:48:09 +0000 (15:48 +0000)]
Fixed netconf-xml parsing issue

Issue-ID: APPC-1624
Change-Id: I12aa5f1a42d5e09b5eb8886132ea9e5a2c84ef5e
Signed-off-by: Lathish <lathishbabu.ganesan@est.tech>
4 years agoParameterized queries 44/90244/5
Patrick Brady [Wed, 19 Jun 2019 19:35:08 +0000 (12:35 -0700)]
Parameterized queries

Convert all database queries to use java sql
parameterized queries to reduce risk of sql
injection attack.

Change-Id: I15876ce3a2f2e2dfbd6578f5141367deed75d097
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: OJSI-25

4 years agoupdate appc release note 79/90179/1
Taka Cho [Wed, 19 Jun 2019 18:29:33 +0000 (14:29 -0400)]
update appc release note

fix appc cluster issue
release new appc docker

Issue-ID: APPC-1293
Change-Id: Id4897669e29f3c7c156a3c4c945825758c268a51
Signed-off-by: Taka Cho <takamune.cho@att.com>
4 years agoAdded cvaas file name in Audit and Sync 74/90074/1
Lathish [Tue, 18 Jun 2019 10:16:16 +0000 (10:16 +0000)]
Added cvaas file name in Audit and Sync

Issue-ID: APPC-1590
Change-Id: I09345570fe6cd158102844070e62df7fb1a7aed9
Signed-off-by: Lathish <lathishbabu.ganesan@est.tech>
4 years agofix document error 23/89923/2
Taka Cho [Fri, 14 Jun 2019 18:42:56 +0000 (14:42 -0400)]
fix document error

missing underline

Issue-ID: APPC-1595
Change-Id: Ia1eb87c5f34c43c56e037e9bf925857ecbb9d758
Signed-off-by: Taka Cho <takamune.cho@att.com>
4 years agoupdate dublin release note 18/89518/3
Taka Cho [Thu, 6 Jun 2019 13:52:30 +0000 (09:52 -0400)]
update dublin release note

remove known-issue
APPC-1613

Issue-ID: APPC-1293
Change-Id: Ibacdb95bdc94bee2449596948055bbff3bd51e9e
Signed-off-by: Taka Cho <takamune.cho@att.com>
4 years agoFixed incorrect error message 44/89644/1
Lathish [Mon, 10 Jun 2019 13:43:55 +0000 (13:43 +0000)]
Fixed incorrect error message

Issue-ID: APPC-1623
Change-Id: Ib6c58be5e5ddb41c39788208238234335f72e7ea
Signed-off-by: Lathish <lathishbabu.ganesan@est.tech>
4 years agoDocument OJSI-185 vulnerability 36/89436/1
Krzysztof Opasiak [Wed, 5 Jun 2019 21:33:16 +0000 (23:33 +0200)]
Document OJSI-185 vulnerability

Issue-ID: OJSI-185
Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com>
Change-Id: I6cbe6a6cb0129bd4ac6ccba35cf018f4a04f80e5

4 years agoDocument OJSI-113 vulnerability 35/89435/1
Krzysztof Opasiak [Wed, 5 Jun 2019 21:32:50 +0000 (23:32 +0200)]
Document OJSI-113 vulnerability

Issue-ID: OJSI-113
Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com>
Change-Id: I9d0c35e01dd4f2b42bd115455863ca2d0b8dc3c7

4 years agoDocument OJSI-112 vulnerability 34/89434/1
Krzysztof Opasiak [Wed, 5 Jun 2019 21:32:21 +0000 (23:32 +0200)]
Document OJSI-112 vulnerability

Issue-ID: OJSI-112
Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com>
Change-Id: Id28f332ddcdd5c69f5a82758d05c10d19606faff

4 years agoDocument OJSI-95 vulnerability 33/89433/1
Krzysztof Opasiak [Wed, 5 Jun 2019 21:31:54 +0000 (23:31 +0200)]
Document OJSI-95 vulnerability

Issue-ID: OJSI-95
Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com>
Change-Id: Ica05a626601673f672cc0be6a8c6cdcbe94323f8

4 years agoDocument OJSI-63 (CVE-2019-12124) vulnerability 32/89432/1
Krzysztof Opasiak [Wed, 5 Jun 2019 21:30:42 +0000 (23:30 +0200)]
Document OJSI-63 (CVE-2019-12124) vulnerability

Issue-ID: OJSI-63
Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com>
Change-Id: Ide989877e0f2765302ad423c0b421e972b4e8046

4 years agoDocument OJSI-29 vulnerability 31/89431/1
Krzysztof Opasiak [Wed, 5 Jun 2019 21:30:08 +0000 (23:30 +0200)]
Document OJSI-29 vulnerability

Issue-ID: OJSI-29
Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com>
Change-Id: Ib8f54aa42fc78198c8b0043b2aa79580a5950672

4 years agoDocument OJSI-25 (CVE-2019-12316) vulnerability 30/89430/1
Krzysztof Opasiak [Wed, 5 Jun 2019 21:29:16 +0000 (23:29 +0200)]
Document OJSI-25 (CVE-2019-12316) vulnerability

Issue-ID: OJSI-25
Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com>
Change-Id: Ia880184484aadea9147fcac301c87063a00f92ab

4 years agoDocument fixed OJSI-104 vulnerability 29/89429/1
Krzysztof Opasiak [Wed, 5 Jun 2019 21:28:26 +0000 (23:28 +0200)]
Document fixed OJSI-104 vulnerability

Issue-ID: OJSI-104
Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com>
Change-Id: I42365c3038eb38f170b1543d9f78d68b2e5c9de4

4 years agoDocument fixed OJSI-146 vulnerability 28/89428/1
Krzysztof Opasiak [Wed, 5 Jun 2019 21:27:39 +0000 (23:27 +0200)]
Document fixed OJSI-146 vulnerability

Issue-ID: OJSI-146
Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com>
Change-Id: I9e02cc26f7cfa9c11941b4ce4aef5de561f4b764

4 years agoImprove security release notes 27/89427/1
Krzysztof Opasiak [Wed, 5 Jun 2019 21:11:16 +0000 (23:11 +0200)]
Improve security release notes

In order to provide users with more details of project's state in
terms of security let's divide the security release notes into three
sections:

- Fixed Security Issues
  Contains a list of security fixes merged during this
  release (especially those reported via OJSI tickets).

- Known Security Issues
  Contains a list of vulnerabilities detected in project during
  release which have not been fixed yet and thus should be mitigated
  by the user.

- Known Vulnerabilities in Used Modules
  Contains information about NexusIQ scan results

Issue-ID: SECCOM-238
Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com>
Change-Id: I9fee2338091ed5a879e0989d13501008d7d6013f

4 years agoFix for jackson annotation 14/89414/2
Patrick Brady [Wed, 5 Jun 2019 18:15:13 +0000 (11:15 -0700)]
Fix for jackson annotation

Fasterxml jackson annotations was not available during runtime
and was causing json property annotations to be ignored and
json was not parsing.

Change-Id: I1cb48e6fc54fc39d24bde1683cb141f1f64c9906
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1613

4 years agoFix for documentation of DistributeTrafficCheck 82/89382/1
Lukasz Rajewski [Wed, 5 Jun 2019 14:04:41 +0000 (16:04 +0200)]
Fix for documentation of DistributeTrafficCheck

Change-Id: I260ef22fb00755e6818868fdadd35bcd88162ffd
Signed-off-by: Lukasz Rajewski <lukasz.rajewski@orange.com>
Issue-ID: APPC-1447

4 years agoDocumentation for DistributeTraffic LCMs 65/89265/2
Lukasz Rajewski [Mon, 3 Jun 2019 13:21:29 +0000 (15:21 +0200)]
Documentation for DistributeTraffic LCMs

Documentation for Distribute Traffic and
Distribute Traffic Check LCMs

Change-Id: I8dc6ec3110c711857d8788f01edfcca87a887317
Signed-off-by: Lukasz Rajewski <lukasz.rajewski@orange.com>
Issue-ID: APPC-1447
(cherry picked from commit 284d93a4770224956138eec224479fef9d356fff)

4 years agoAPPC release note update 75/89075/4
Taka Cho [Fri, 31 May 2019 19:36:43 +0000 (15:36 -0400)]
APPC release note update

Updated Dublin release note

Issue-ID: APPC-1293
Change-Id: I86ebb4365aed65b90e13a46e8e691f39382ecfd4
Signed-off-by: Taka Cho <takamune.cho@att.com>
4 years agoFix for null dmaap return status 08/89208/2
Patrick Brady [Tue, 4 Jun 2019 05:13:50 +0000 (22:13 -0700)]
Fix for null dmaap return status

The setResponse method was returning before actually
setting the status values in cases where the status
field was not first initialized. This behavior did
not make sense since the status field would never be
initialized in cases where the OutgoingMessage was
generated using the IncomingMessage.toOutgoing().

Change-Id: Ib399daf3644095a2eeffe718d0f6a27473b01ee9
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1619

4 years agoInventoryNames in ansible adapter fixed 62/88662/1
Lukasz Rajewski [Mon, 27 May 2019 06:03:27 +0000 (08:03 +0200)]
InventoryNames in ansible adapter fixed

This change fixes support for InventoryNames parameter
in LCM request going to Ansible server. Also ansible
adapter DG has been modified to consider new parameter
added

Change-Id: I68aa8efa34b79ef2f669d81563510fea7bb0a730
Signed-off-by: Lukasz Rajewski <lukasz.rajewski@orange.com>
Issue-ID: APPC-1612
(cherry picked from commit 7155b808084ff6e49f6eef01ac7defd9a7754a3a)

4 years agofix CDT doc image reference 45/88245/2
Taka Cho [Wed, 22 May 2019 13:33:56 +0000 (09:33 -0400)]
fix CDT doc image reference

rename to image41

Issue-ID: APPC-1295
Change-Id: Iee331769a9a0e46e87631c14849142033b855e34
Signed-off-by: Taka Cho <takamune.cho@att.com>
4 years agoFix for support of InventoryNames 67/88267/1
Lukasz Rajewski [Wed, 22 May 2019 14:00:08 +0000 (16:00 +0200)]
Fix for support of InventoryNames

This change addes support for InventoryNames parameter
in LCM request going to Ansible server

Change-Id: I9aea0b5407460d5dc0b2691e73ba795f8fe2af15
Signed-off-by: Lukasz Rajewski <lukasz.rajewski@orange.com>
Issue-ID: APPC-1612

4 years agoFix escapeInternalJson method 90/88190/5
Patrick Brady [Tue, 21 May 2019 17:29:49 +0000 (10:29 -0700)]
Fix escapeInternalJson method

The method incorrectly handled cases where the json string contained
json objects internally. These cases should be handled correctly now.

Change-Id: I43b40414526bcb6577242ab737097dfb9119e618
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1576

4 years agoupdate APPC CDT GUI guide 95/88195/2
Taka Cho [Tue, 21 May 2019 17:57:21 +0000 (13:57 -0400)]
update APPC CDT GUI guide

added Admin tab user
guide

Issue-ID: APPC-1295
Change-Id: I21c7d3163796f405f809fb6c8a47537b736b1277
Signed-off-by: Taka Cho <takamune.cho@att.com>
4 years agoresolve base64 class not found 94/88194/2
Taka Cho [Sun, 19 May 2019 21:15:27 +0000 (17:15 -0400)]
resolve base64 class not found

add commons-codec in embedded-dependency
in event listener pom file

Issue-ID: APPC-1604
Change-Id: I7006ed41d412b1dcf21dd64987a84d1ad04c9093
Signed-off-by: Taka Cho <takamune.cho@att.com>
4 years agoUpdate parent version 32/88132/1
Patrick Brady [Tue, 21 May 2019 06:12:51 +0000 (23:12 -0700)]
Update parent version

Update the parent version to match the new 2.*
parent versioning.

Change-Id: I77280d8cf12de1de20c01249491dc85243f5d655
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1601

4 years agoUpdate message format for vFirewall 02/87602/2
Patrick Brady [Mon, 13 May 2019 23:16:58 +0000 (16:16 -0700)]
Update message format for vFirewall

The message format coming from policy has changed. This is the
corresponding update for appc to match the message format.

Change-Id: I8827e6c372be77dc69c0ee3579a002fde2515848
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1603

4 years agoAdd ConfigModify to if statement 94/87494/2
Patrick Brady [Fri, 10 May 2019 22:14:06 +0000 (15:14 -0700)]
Add ConfigModify to if statement

Requests from cdt with the action set to ConfigModify
did not have entries added to the device interface
protocol table. With this change the entry will be
made in the table.

Change-Id: I29835554a0ebf2fea29f1c8745b99ac1813c0d7d
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1593

4 years agoChange rest healthcheck to use appc parent poms 88/87288/2
Patrick Brady [Wed, 8 May 2019 22:14:49 +0000 (15:14 -0700)]
Change rest healthcheck to use appc parent poms

Change appc-rest-healthcheck over to the new style
of features using the org.onap.appc.parent pom files
as parents.

Change-Id: I781754f3ad5c31a937d17449ff46320d60db4975
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1586

4 years agoAdd method to escape json strings 78/86878/2
Patrick Brady [Thu, 2 May 2019 23:41:24 +0000 (16:41 -0700)]
Add method to escape json strings

All backslash escape characters are being stripped out of strings.
They need to be added back to strings containing json data.

Change-Id: Ic8d9ba95da904b96f65598752133971f8c324694
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1576

4 years agoFix for extra json quotes 76/86676/1
Patrick Brady [Tue, 30 Apr 2019 20:08:25 +0000 (13:08 -0700)]
Fix for extra json quotes

Substring method output was being lost, causing extra
quotes to stay in the String.

Change-Id: I35e9eee60756b7b743386600e3ab1d203cca036a
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1576

4 years agoFixed publish config issue 25/86625/2
Lathish [Tue, 30 Apr 2019 14:00:16 +0000 (14:00 +0000)]
Fixed publish config issue

Issue-ID: APPC-1588
Change-Id: I63e75c415d7f33c750eaad6799234e03741ad290
Signed-off-by: Lathish <lathishbabu.ganesan@est.tech>
4 years agoFixed public config issue in Audit 51/86651/3
Lathish [Tue, 30 Apr 2019 16:09:56 +0000 (16:09 +0000)]
Fixed public config issue in Audit

Issue-ID: APPC-1587
Change-Id: I7caa7fbf85f8a49beb5fc957c9372445f0d5e7ef
Signed-off-by: Lathish <lathishbabu.ganesan@est.tech>
5 years agoIncrement snapshot version 33/86433/1
Patrick Brady [Fri, 26 Apr 2019 19:36:25 +0000 (12:36 -0700)]
Increment snapshot version

Change from 1.5.0-SNAPSHOT to 1.6.0-SNAPSHOT to prepare
for next development cycle.

Change-Id: I187785ab4b11a37815289d20ba802c48e86cee7f
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1585

5 years agoFixed the package name in Audit DG 03/86403/2
Lathish [Fri, 26 Apr 2019 14:19:46 +0000 (14:19 +0000)]
Fixed the package name in Audit DG

Issue-ID: APPC-1584
Change-Id: I07a2b18b66c6e446324b37b5112e1839c197e538
Signed-off-by: Lathish <lathishbabu.ganesan@est.tech>
5 years agoremove commons-codec hardcoded 17/86217/1
Taka Cho [Thu, 25 Apr 2019 01:21:46 +0000 (21:21 -0400)]
remove commons-codec hardcoded

remove 1.9 version
commons-codec

Change-Id: I8ea5ca9c017b2d2b8917e38e2666996c5227d40b
Issue-ID: APPC-1579
Signed-off-by: Taka Cho <takamune.cho@att.com>
5 years agoEscape quotes in json strings 87/85987/5
Patrick Brady [Mon, 22 Apr 2019 20:12:14 +0000 (13:12 -0700)]
Escape quotes in json strings

The JSONObject parser strips all text of backslash escape characters, even if it is
treaing the object as a string and not a series of json keys. If a string contains a
json object within it, the removal of these escape characters causes problems. Adding
the JSONObject.quote method on all strings to automatically add escape characters to
any strings which contain characters requiring escapes.

Change-Id: Ifac68844dd132971ba35803f1b9c03a5372bd500
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1576

5 years agoFixed issue with FileParameters support 32/85432/1
Lukasz Rajewski [Tue, 16 Apr 2019 09:20:38 +0000 (11:20 +0200)]
Fixed issue with FileParameters support

Generic_AnsibleDG has missing support for FileParameters
payload parameter. It is added with this fix.

Change-Id: I71570c87a6a24934f4f975afd5f36eebced4d3e8
Issue-ID: APPC-1574
Signed-off-by: Lukasz Rajewski <lukasz.rajewski@orange.com>
5 years agoadded test cases to MetricRegistryImpl.java 19/85019/2
Sandeep J [Thu, 11 Apr 2019 07:37:14 +0000 (13:07 +0530)]
added test cases to MetricRegistryImpl.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: I8804c14c88fe0857be7106edd621ee74f4dd1243
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded file to test DispatchingFuntionMetricImpl 24/85024/2
Sandeep J [Thu, 11 Apr 2019 08:04:41 +0000 (13:34 +0530)]
added file to test DispatchingFuntionMetricImpl

to increase code coverage

Issue-ID: APPC-1086
Change-Id: I179c0d74f9ed14a34a02bb9eb0f31c51ca3f415c
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded file to test DispatchingFunctionMetric.java 22/85022/2
Sandeep J [Thu, 11 Apr 2019 07:57:37 +0000 (13:27 +0530)]
added file to test DispatchingFunctionMetric.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: Id99ba5312e98987aea8d38040f6d8ce23264523a
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded file to test DefaultPrimitiveCounter.java 20/85020/2
Sandeep J [Thu, 11 Apr 2019 07:48:01 +0000 (13:18 +0530)]
added file to test DefaultPrimitiveCounter.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: I9af062fee4122acb0a87dbc9f0bd1cd3b5198e62
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded test case to TestRestartServer.java 39/84539/2
Sandeep J [Mon, 8 Apr 2019 15:07:02 +0000 (20:37 +0530)]
added test case to TestRestartServer.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: Id64f507cb3cb4102c79dfb5c454785ac2814cec5
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded file to test ActionIdentifier.java 21/84621/2
Sandeep J [Tue, 9 Apr 2019 07:52:46 +0000 (13:22 +0530)]
added file to test ActionIdentifier.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: Iba0884ae878488575cda665ed15cca5b301b6b03
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded file to test ScopOverlap.jav 10/84810/2
Sandeep J [Wed, 10 Apr 2019 07:43:17 +0000 (13:13 +0530)]
added file to test ScopOverlap.jav

to increase code coverage

Issue-ID: APPC-1086
Change-Id: I21695f6515653e79a7bc09a462ce181aa617105b
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded file to test Request.java 07/84807/2
Sandeep J [Wed, 10 Apr 2019 07:37:26 +0000 (13:07 +0530)]
added file to test Request.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: I0afa6d99ba65243bfbae419d075800ecc45aafb6
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoFix for Ansible Healthcheck bug 38/78938/7
Joss Armstrong [Thu, 21 Feb 2019 15:19:07 +0000 (15:19 +0000)]
Fix for Ansible Healthcheck bug

Update to directed graph and merge JSON template code

Issue-ID: APPC-1472
Change-Id: I4332ad74d34f455261b1c001339d0542be4514fc
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agoadded test case to TestConnectionBuilder.java 96/84496/2
Sandeep J [Mon, 8 Apr 2019 09:27:24 +0000 (14:57 +0530)]
added test case to TestConnectionBuilder.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: Ie7d84cc28ebd112c2ce224cd6c544939ef376ed1
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>