Update message format for vFirewall 02/87602/2
authorPatrick Brady <patrick.brady@att.com>
Mon, 13 May 2019 23:16:58 +0000 (16:16 -0700)
committerPatrick Brady <patrick.brady@att.com>
Tue, 14 May 2019 06:29:04 +0000 (23:29 -0700)
The message format coming from policy has changed. This is the
corresponding update for appc to match the message format.

Change-Id: I8827e6c372be77dc69c0ee3579a002fde2515848
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1603

appc-event-listener/appc-event-listener-bundle/src/main/java/org/onap/appc/listener/demo/impl/ProviderOperations.java
appc-event-listener/appc-event-listener-bundle/src/main/java/org/onap/appc/listener/demo/model/CommonMessage.java
appc-event-listener/appc-event-listener-bundle/src/test/java/org/onap/appc/listener/AbstractListenerTest.java
appc-event-listener/appc-event-listener-bundle/src/test/java/org/onap/appc/listener/demo/model/TestCommonMessage.java
appc-event-listener/appc-event-listener-bundle/src/test/java/org/onap/appc/listener/demo/model/TestMessages.java

index 85de6bd..f51be28 100644 (file)
@@ -89,7 +89,7 @@ public class ProviderOperations {
             }
 
             //String body = buildReqest(msg.getId(), msg.getUrl(), msg.getIdentityUrl());
-            String body = buildReqest(msg.getHeader().getRequestID(), msg.getPayload().getGenericVnfId(), msg.getPayload().getPgStreams());
+            String body = buildReqest(msg.getHeader().getRequestID(), msg.getPayload().getGenericVnfId(), msg.getPayload().getStreams());
             StringEntity entity = new StringEntity(body);
             entity.setContentType("application/json");
             post.setEntity(new StringEntity(body));
index 45b99a9..e0dbbab 100644 (file)
@@ -268,25 +268,16 @@ public class CommonMessage implements Serializable {
             this.genericVnfId = genericVnfId;
         }
 
-        @JsonProperty("pg-streams")
-        private pgStreams pgStreams;
+        @JsonProperty("streams")
+        private Streams streams;
 
         /**
          * @return the TenantID
          */
 
-        public String getPgStreams() {
-            String r = "{\\\"pg-streams\\\": {\\\"pg-stream\\\":[";
-            boolean first = true;
-            for(pgStream p : this.pgStreams.streams){
-               String n = "{\\\"id\\\":\\\""+p.getId()+"\\\", \\\"is-enabled\\\":\\\""+p.getIsEnabled()+"\\\"}";
-               if(!first){
-                       r = r.concat(",");
-               }
-               first = false;
-               r = r.concat(n);
-            }
-           r=  r.concat("]}}");
+        public String getStreams() {
+            String r = "{\\\"streams\\\": {\\\"active-streams\\\": " + streams.getActiveStreams() +
+                    "}}";
             return r;
         }
 
@@ -294,8 +285,8 @@ public class CommonMessage implements Serializable {
          * @param TenantID
          *            the TenantID to set
          */
-        public void setPgStreams(pgStreams pgStreams) {
-            this.pgStreams = pgStreams;
+        public void setStreams(Streams streams) {
+            this.streams = streams;
         }
 
 
@@ -304,36 +295,19 @@ public class CommonMessage implements Serializable {
 
     };
     @JsonIgnoreProperties(ignoreUnknown = true)
-    public static class pgStreams {
-        @JsonProperty("pg-stream")
-        private Collection<pgStream> streams;
-
-        public Collection<pgStream> getStreams() {
-            return streams;
+    public static class Streams {
+        
+        @JsonProperty("active-streams")
+        private int activeStreams;
+        
+        public int getActiveStreams() {
+            return this.activeStreams;
         }
 
-        public void setStreams(Collection<pgStream> streams) {
-            this.streams = streams;
+        public void setActiveStreams(int activeStreams) {
+            this.activeStreams = activeStreams;
         }
+        
     };
 
-    @JsonIgnoreProperties(ignoreUnknown = true)
-    public static class pgStream{
-        public String getId() {
-            return id;
-        }
-        public void setId(String id) {
-            this.id = id;
-        }
-        public String getIsEnabled() {
-            return isEnabled;
-        }
-        public void setIsEnabled(String isEnabled) {
-            this.isEnabled = isEnabled;
-        }
-        @JsonProperty("id")
-        private String id;
-        @JsonProperty("is-enabled")
-        private String isEnabled;
-     };
 }
index ebc2706..341492f 100644 (file)
@@ -30,17 +30,16 @@ import java.util.Collection;
 import org.json.JSONObject;
 import org.junit.Before;
 import org.junit.Test;
-import org.onap.appc.listener.demo.model.CommonMessage.pgStream;
 
 public class TestCommonMessage {
 
     private CommonMessage commonMessage;
-    private CommonMessage.pgStreams pgStreams;
+    private CommonMessage.Payload payload;
 
     @Before
     public void setUp() {
         commonMessage = new CommonMessage();
-        pgStreams = new CommonMessage.pgStreams();
+        payload = new CommonMessage.Payload();
     }
 
     @Test
@@ -48,11 +47,4 @@ public class TestCommonMessage {
         assertTrue(commonMessage.toJson() instanceof JSONObject);
     }
 
-    @Test
-    public void testStreams() {
-        Collection<pgStream> streams = new ArrayList<>();
-        pgStreams.setStreams(streams);
-        assertSame(streams, pgStreams.getStreams());
-    }
-
 }
index 62ea83a..9cce23d 100644 (file)
@@ -39,7 +39,7 @@ import org.json.JSONObject;
 import org.junit.Before;
 import org.junit.Ignore;
 import org.junit.Test;
-import org.onap.appc.listener.demo.model.CommonMessage.pgStream;
+import org.onap.appc.listener.demo.model.CommonMessage.Streams;
 import org.onap.appc.listener.demo.model.IncomingMessage;
 import org.onap.appc.listener.demo.model.OutgoingMessage;
 import org.onap.appc.listener.demo.model.Status;
@@ -117,18 +117,13 @@ public class TestMessages {
     public void testPayload() {
         CommonMessage.Payload payload = new CommonMessage.Payload();
         payload.setGenericVnfId("VNF_ID");
-        CommonMessage.pgStream pgStream = new CommonMessage.pgStream();
-        pgStream.setId("ID");
-        pgStream.setIsEnabled("true");
-        CommonMessage.pgStreams pgStreams = new CommonMessage.pgStreams();
-        Collection<pgStream> collectionPgStreams = new ArrayList<pgStream>();
-        collectionPgStreams.add(pgStream);
-        pgStreams.setStreams(collectionPgStreams);
-        payload.setPgStreams(pgStreams);
+        CommonMessage.Streams streams = new CommonMessage.Streams();
+        streams.setActiveStreams(7);
+        payload.setStreams(streams);
         in.setPayload(payload);
         assertEquals("VNF_ID", in.getPayload().getGenericVnfId());
-        assertEquals("{\\\"pg-streams\\\": {\\\"pg-stream\\\":[{\\\"id\\\":\\\"ID\\\", \\\"is-enabled\\\":\\\"true\\\"}]}}",
-                in.getPayload().getPgStreams());
+        assertEquals("{\\\"streams\\\": {\\\"active-streams\\\": 7}}",
+                in.getPayload().getStreams());
     }
 
     @Test