appc.git
4 years agoFix for jackson annotation 21/89421/1 1.5.2
Patrick Brady [Wed, 5 Jun 2019 18:15:13 +0000 (11:15 -0700)]
Fix for jackson annotation

Fasterxml jackson annotations was not available during runtime
and was causing json property annotations to be ignored and
json was not parsing.

Change-Id: I7cbd71802851b748434159d98914184ae3f72a64
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1613

4 years agoFix for documentation of DistributeTrafficCheck 76/89376/1
Lukasz Rajewski [Wed, 5 Jun 2019 14:04:41 +0000 (16:04 +0200)]
Fix for documentation of DistributeTrafficCheck

Change-Id: I260ef22fb00755e6818868fdadd35bcd88162ffd
Signed-off-by: Lukasz Rajewski <lukasz.rajewski@orange.com>
Issue-ID: APPC-1447

4 years agoAPPC release note update 87/89287/1
Taka Cho [Fri, 31 May 2019 19:36:43 +0000 (15:36 -0400)]
APPC release note update

Updated Dublin release note

Issue-ID: APPC-1293
Change-Id: I86ebb4365aed65b90e13a46e8e691f39382ecfd4
Signed-off-by: Taka Cho <takamune.cho@att.com>
(cherry picked from commit 0fbad083a25a5982ccc2de26fc159cde834fb1b3)

4 years agoDocumentation for DistributeTraffic LCMs 45/89145/2
Lukasz Rajewski [Mon, 3 Jun 2019 13:21:29 +0000 (15:21 +0200)]
Documentation for DistributeTraffic LCMs

Documentation for Distribute Traffic and
Distribute Traffic Check LCMs

Change-Id: I8dc6ec3110c711857d8788f01edfcca87a887317
Signed-off-by: Lukasz Rajewski <lukasz.rajewski@orange.com>
Issue-ID: APPC-1447

4 years agoFix for null dmaap return status 51/89251/1
Patrick Brady [Tue, 4 Jun 2019 05:13:50 +0000 (22:13 -0700)]
Fix for null dmaap return status

The setResponse method was returning before actually
setting the status values in cases where the status
field was not first initialized. This behavior did
not make sense since the status field would never be
initialized in cases where the OutgoingMessage was
generated using the IncomingMessage.toOutgoing().

Change-Id: Ib399daf3644095a2eeffe718d0f6a27473b01ee9
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1619
(cherry picked from commit 62433c522bb1feddc2caa22868192edca0b4082f)

4 years agoInventoryNames in ansible adapter fixed 15/88515/1
Lukasz Rajewski [Mon, 27 May 2019 06:03:27 +0000 (08:03 +0200)]
InventoryNames in ansible adapter fixed

This change fixes support for InventoryNames parameter
in LCM request going to Ansible server. Also ansible
adapter DG has been modified to consider new parameter
added

Change-Id: I68aa8efa34b79ef2f669d81563510fea7bb0a730
Signed-off-by: Lukasz Rajewski <lukasz.rajewski@orange.com>
Issue-ID: APPC-1612

4 years agoIncrement versions after release 98/88498/2
Patrick Brady [Fri, 24 May 2019 20:51:58 +0000 (13:51 -0700)]
Increment versions after release

Change-Id: Ibbfb7a72fe793d06caa8be064f5b1dd768ca0dda
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1595

4 years agofix CDT doc image reference 50/88250/2 1.5.1
Taka Cho [Wed, 22 May 2019 13:33:56 +0000 (09:33 -0400)]
fix CDT doc image reference

rename to image41

Issue-ID: APPC-1295
Change-Id: Iee331769a9a0e46e87631c14849142033b855e34
Signed-off-by: Taka Cho <takamune.cho@att.com>
4 years agoFix escapeInternalJson method 49/88249/2
Patrick Brady [Tue, 21 May 2019 17:29:49 +0000 (10:29 -0700)]
Fix escapeInternalJson method

The method incorrectly handled cases where the json string contained
json objects internally. These cases should be handled correctly now.

Change-Id: I43b40414526bcb6577242ab737097dfb9119e618
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1576
(cherry picked from commit fc2018739d072a0287b84ff78c94572bce5aba7c)

4 years agoFix for support of InventoryNames 51/88251/1
Lukasz Rajewski [Wed, 22 May 2019 14:00:08 +0000 (16:00 +0200)]
Fix for support of InventoryNames

This change addes support for InventoryNames parameter
in LCM request going to Ansible server

Change-Id: I9aea0b5407460d5dc0b2691e73ba795f8fe2af15
Signed-off-by: Lukasz Rajewski <lukasz.rajewski@orange.com>
Issue-ID: APPC-1612

4 years agoupdate APPC CDT GUI guide 97/88197/1
Taka Cho [Tue, 21 May 2019 17:57:21 +0000 (13:57 -0400)]
update APPC CDT GUI guide

added Admin tab user
guide

Issue-ID: APPC-1295
Change-Id: I21c7d3163796f405f809fb6c8a47537b736b1277
Signed-off-by: Taka Cho <takamune.cho@att.com>
4 years agoFix base64 dependency 49/88049/2
Brian Freeman [Sun, 19 May 2019 21:54:44 +0000 (21:54 +0000)]
Fix base64 dependency

Issue-ID: APPC-1604
Change-Id: I7063bbfdcf1ca293d9775b7c21c3bc094ad02c3c
Signed-off-by: Brian Freeman <bf1936@att.com>
4 years agoUpdate message format for vFirewall 06/87706/1
Patrick Brady [Mon, 13 May 2019 23:16:58 +0000 (16:16 -0700)]
Update message format for vFirewall

The message format coming from policy has changed. This is the
corresponding update for appc to match the message format.

Change-Id: I8827e6c372be77dc69c0ee3579a002fde2515848
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1603

4 years agoAdd ConfigModify to if statement 79/87579/1
Patrick Brady [Fri, 10 May 2019 22:14:06 +0000 (15:14 -0700)]
Add ConfigModify to if statement

Requests from cdt with the action set to ConfigModify
did not have entries added to the device interface
protocol table. With this change the entry will be
made in the table.

Change-Id: I29835554a0ebf2fea29f1c8745b99ac1813c0d7d
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1593
(cherry picked from commit c3719d87ad36bd1fae457f34ec8aa3247915dc6f)

4 years agoIncrement version after release 92/87392/2
Patrick Brady [Thu, 9 May 2019 20:04:18 +0000 (13:04 -0700)]
Increment version after release

Change-Id: I42b9142f15d15a65c00208b671ecaeceb6f26467
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1595

4 years agoChange parent version 78/87278/3 1.5.0
Patrick Brady [Wed, 8 May 2019 19:57:09 +0000 (12:57 -0700)]
Change parent version

Change-Id: Iab2f1688569b315d157c578e2bd9accd39581bc5
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1601

4 years agoChange to release parent 05/87005/1
Patrick Brady [Mon, 6 May 2019 07:43:08 +0000 (00:43 -0700)]
Change to release parent

Change-Id: I26d499688dbff828a7928799efe7740b581a1b1f
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1595

4 years agoAdd method to escape json strings 79/86879/2
Patrick Brady [Thu, 2 May 2019 23:41:24 +0000 (16:41 -0700)]
Add method to escape json strings

All backslash escape characters are being stripped out of strings.
They need to be added back to strings containing json data.

Change-Id: Ic8d9ba95da904b96f65598752133971f8c324694
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1576

4 years agoFix for extra json quotes 77/86677/2
Patrick Brady [Tue, 30 Apr 2019 20:08:25 +0000 (13:08 -0700)]
Fix for extra json quotes

Substring method output was being lost, causing extra
quotes to stay in the String.

Change-Id: I35e9eee60756b7b743386600e3ab1d203cca036a
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1576

4 years agoFixed publish config issue 21/86721/1
Lathish [Tue, 30 Apr 2019 14:00:16 +0000 (14:00 +0000)]
Fixed publish config issue

Issue-ID: APPC-1588
Change-Id: I63e75c415d7f33c750eaad6799234e03741ad290
Signed-off-by: Lathish <lathishbabu.ganesan@est.tech>
(cherry picked from commit d1bddabef57ab3582d1b1c045c0554d1e476e52e)

4 years agoFixed public config issue in Audit 18/86718/1
Lathish [Tue, 30 Apr 2019 16:09:56 +0000 (16:09 +0000)]
Fixed public config issue in Audit

Issue-ID: APPC-1587
Change-Id: I7caa7fbf85f8a49beb5fc957c9372445f0d5e7ef
Signed-off-by: Lathish <lathishbabu.ganesan@est.tech>
(cherry picked from commit de85a6c50d48769ab74988b289d7dddf2bbbcebe)

5 years agoFixed the package name in Audit DG 03/86403/2
Lathish [Fri, 26 Apr 2019 14:19:46 +0000 (14:19 +0000)]
Fixed the package name in Audit DG

Issue-ID: APPC-1584
Change-Id: I07a2b18b66c6e446324b37b5112e1839c197e538
Signed-off-by: Lathish <lathishbabu.ganesan@est.tech>
5 years agoremove commons-codec hardcoded 17/86217/1
Taka Cho [Thu, 25 Apr 2019 01:21:46 +0000 (21:21 -0400)]
remove commons-codec hardcoded

remove 1.9 version
commons-codec

Change-Id: I8ea5ca9c017b2d2b8917e38e2666996c5227d40b
Issue-ID: APPC-1579
Signed-off-by: Taka Cho <takamune.cho@att.com>
5 years agoEscape quotes in json strings 87/85987/5
Patrick Brady [Mon, 22 Apr 2019 20:12:14 +0000 (13:12 -0700)]
Escape quotes in json strings

The JSONObject parser strips all text of backslash escape characters, even if it is
treaing the object as a string and not a series of json keys. If a string contains a
json object within it, the removal of these escape characters causes problems. Adding
the JSONObject.quote method on all strings to automatically add escape characters to
any strings which contain characters requiring escapes.

Change-Id: Ifac68844dd132971ba35803f1b9c03a5372bd500
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1576

5 years agoFixed issue with FileParameters support 32/85432/1
Lukasz Rajewski [Tue, 16 Apr 2019 09:20:38 +0000 (11:20 +0200)]
Fixed issue with FileParameters support

Generic_AnsibleDG has missing support for FileParameters
payload parameter. It is added with this fix.

Change-Id: I71570c87a6a24934f4f975afd5f36eebced4d3e8
Issue-ID: APPC-1574
Signed-off-by: Lukasz Rajewski <lukasz.rajewski@orange.com>
5 years agoadded test cases to MetricRegistryImpl.java 19/85019/2
Sandeep J [Thu, 11 Apr 2019 07:37:14 +0000 (13:07 +0530)]
added test cases to MetricRegistryImpl.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: I8804c14c88fe0857be7106edd621ee74f4dd1243
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded file to test DispatchingFuntionMetricImpl 24/85024/2
Sandeep J [Thu, 11 Apr 2019 08:04:41 +0000 (13:34 +0530)]
added file to test DispatchingFuntionMetricImpl

to increase code coverage

Issue-ID: APPC-1086
Change-Id: I179c0d74f9ed14a34a02bb9eb0f31c51ca3f415c
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded file to test DispatchingFunctionMetric.java 22/85022/2
Sandeep J [Thu, 11 Apr 2019 07:57:37 +0000 (13:27 +0530)]
added file to test DispatchingFunctionMetric.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: Id99ba5312e98987aea8d38040f6d8ce23264523a
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded file to test DefaultPrimitiveCounter.java 20/85020/2
Sandeep J [Thu, 11 Apr 2019 07:48:01 +0000 (13:18 +0530)]
added file to test DefaultPrimitiveCounter.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: I9af062fee4122acb0a87dbc9f0bd1cd3b5198e62
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded test case to TestRestartServer.java 39/84539/2
Sandeep J [Mon, 8 Apr 2019 15:07:02 +0000 (20:37 +0530)]
added test case to TestRestartServer.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: Id64f507cb3cb4102c79dfb5c454785ac2814cec5
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded file to test ActionIdentifier.java 21/84621/2
Sandeep J [Tue, 9 Apr 2019 07:52:46 +0000 (13:22 +0530)]
added file to test ActionIdentifier.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: Iba0884ae878488575cda665ed15cca5b301b6b03
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded file to test ScopOverlap.jav 10/84810/2
Sandeep J [Wed, 10 Apr 2019 07:43:17 +0000 (13:13 +0530)]
added file to test ScopOverlap.jav

to increase code coverage

Issue-ID: APPC-1086
Change-Id: I21695f6515653e79a7bc09a462ce181aa617105b
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded file to test Request.java 07/84807/2
Sandeep J [Wed, 10 Apr 2019 07:37:26 +0000 (13:07 +0530)]
added file to test Request.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: I0afa6d99ba65243bfbae419d075800ecc45aafb6
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoFix for Ansible Healthcheck bug 38/78938/7
Joss Armstrong [Thu, 21 Feb 2019 15:19:07 +0000 (15:19 +0000)]
Fix for Ansible Healthcheck bug

Update to directed graph and merge JSON template code

Issue-ID: APPC-1472
Change-Id: I4332ad74d34f455261b1c001339d0542be4514fc
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agoadded test case to TestConnectionBuilder.java 96/84496/2
Sandeep J [Mon, 8 Apr 2019 09:27:24 +0000 (14:57 +0530)]
added test case to TestConnectionBuilder.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: Ie7d84cc28ebd112c2ce224cd6c544939ef376ed1
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoremoved sonar vulnerabilities in ServiceExecutor 17/84617/1
Sandeep J [Tue, 9 Apr 2019 07:43:39 +0000 (13:13 +0530)]
removed sonar vulnerabilities in ServiceExecutor

to increase code coverage

Issue-ID: APPC-1567
Change-Id: Iada27e5e4d40d090275d35dfb3e586fe019cb207
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoRemoved unused imports 39/84439/1
Jegadeesh Babu [Sun, 7 Apr 2019 15:47:53 +0000 (21:17 +0530)]
Removed unused imports

Sonar fix

Issue-ID: APPC-1567
Change-Id: Iec6ce8b197e958e69e108708c056f00cca3b9c66
Signed-off-by: Jegadeesh Babu <jegabab1@in.ibm.com>
5 years agoadded test case to DmaapOutgoingMessageTest 36/84136/2
Sandeep J [Wed, 3 Apr 2019 19:12:33 +0000 (00:42 +0530)]
added test case to DmaapOutgoingMessageTest

to increase code coverage

Issue-ID: APPC-1086
Change-Id: Ia441f83ad6602a89d81e5c66b0120a6c857672c4
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded test cases to DBServiceTest.java 38/84138/2
Sandeep J [Wed, 3 Apr 2019 19:22:41 +0000 (00:52 +0530)]
added test cases to DBServiceTest.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: I149ad0ee6354822fcb9712fe12ad22885b65cf8e
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded test case to TestController.java 26/84226/2
Sandeep J [Thu, 4 Apr 2019 09:59:50 +0000 (15:29 +0530)]
added test case to TestController.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: Id6718c61982a477373c8a5af76f7c7d6a61c43c1
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded test case to InputBodyTest.java 28/84228/1
Sandeep J [Thu, 4 Apr 2019 10:07:27 +0000 (15:37 +0530)]
added test case to InputBodyTest.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: I3406fedf206902eba8374dbc47852bc28bfdeccf
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoRequestContext.java - sonar fixes 81/83881/2
Driptaroop Das [Mon, 1 Apr 2019 17:27:27 +0000 (22:57 +0530)]
RequestContext.java - sonar fixes

RequestContext.java - sonar fixes

Issue-ID: APPC-1564
Change-Id: I334c1f07403cf246efb3413639fdb26cc08556af
Signed-off-by: Driptaroop Das <driptaroop.das@in.ibm.com>
5 years agoExecuteNodeActionImpl is not instatiate 90/83890/3
Taka Cho [Mon, 1 Apr 2019 19:38:33 +0000 (15:38 -0400)]
ExecuteNodeActionImpl is not instatiate

Remove getVersionRelation
back to getVnfHierachy

Change-Id: Ia5c837bd6a75eb6397959f260a89cc5466ce3e42
Issue-ID: APPC-1542
Signed-off-by: Taka Cho <takamune.cho@att.com>
5 years agoAddtional Test Cases added InventoryModel.java 87/83887/2
Sudarshan Kumar [Mon, 1 Apr 2019 18:29:39 +0000 (23:59 +0530)]
Addtional Test Cases added InventoryModel.java

Addtional Test Cases added InventoryModel.java

Issue-ID: APPC-1372
Change-Id: If131ad2d9a5a906b9741426d0c22399c98c3524a
Signed-off-by: Sudarshan Kumar <sudars19@in.ibm.com>
5 years agoadded file to test CommonMessage.java 34/83934/2
Sandeep J [Tue, 2 Apr 2019 08:35:13 +0000 (14:05 +0530)]
added file to test CommonMessage.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: I4cf3a640031a60a34c829ecb039325d6194fa682
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded file to test IncomingMessage.java 43/83943/2
Sandeep J [Tue, 2 Apr 2019 08:54:30 +0000 (14:24 +0530)]
added file to test IncomingMessage.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: Id73082a54060af0b9a4ce8f3bda05cde824bf481
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded file to test DmaapOutgoingMessage.java 43/83443/3
Sandeep J [Wed, 27 Mar 2019 08:11:08 +0000 (13:41 +0530)]
added file to test DmaapOutgoingMessage.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: I81df38037a182db5135f8d6c7b462a42891f9d36
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoUsed constants to avoid dup of literals 98/83798/2
Jegadeesh Babu [Sun, 31 Mar 2019 07:05:47 +0000 (12:35 +0530)]
Used constants to avoid dup of literals

Sonar fix

Issue-ID: APPC-1562
Change-Id: Ic9d14b32f4deac975b46154a2ac8e4664ec11c52
Signed-off-by: Jegadeesh Babu <jegabab1@in.ibm.com>
5 years agoReordered the modifier as per java standard 02/83802/2
Jegadeesh Babu [Sun, 31 Mar 2019 07:48:19 +0000 (13:18 +0530)]
Reordered the modifier as per java standard

Sonar fix

Issue-ID: APPC-1563
Change-Id: I9a4b82ca67b5c7f5184457b95c347089de728658
Signed-off-by: Jegadeesh Babu <jegabab1@in.ibm.com>
5 years agoadded test case to RequestModelTest.java 37/83837/2
Sandeep J [Mon, 1 Apr 2019 07:55:58 +0000 (13:25 +0530)]
added test case to RequestModelTest.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: I56c2e94a888f0f01f0bed36fbc966dce0cb69b84
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded test case to RequestDataTest.java 39/83839/1
Sandeep J [Mon, 1 Apr 2019 08:01:24 +0000 (13:31 +0530)]
added test case to RequestDataTest.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: I646694445953c690fb4c8e336346deb3f5e3b4df
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoremove appc-test-dependency 51/83651/3
Taka Cho [Thu, 28 Mar 2019 19:06:50 +0000 (15:06 -0400)]
remove appc-test-dependency

there are two poms having
appc-test-dependency

Change-Id: I9e096601bf92c05ac6ff93ddd9d436c82a5ecb39
Issue-ID: APPC-1559
Signed-off-by: Taka Cho <takamune.cho@att.com>
5 years agoremove cassandra-drive-core 18/83518/3
Taka Cho [Wed, 27 Mar 2019 19:31:05 +0000 (15:31 -0400)]
remove cassandra-drive-core

remove cassandra-drive-core
from appc-yang-generator

Change-Id: Ied5ca0e393d22b5a4ee059dfe58904dd971df4f6
Issue-ID: APPC-1553
Signed-off-by: Taka Cho <takamune.cho@att.com>
5 years agoRemove test dependencies project 07/83407/3
Patrick Brady [Tue, 26 Mar 2019 19:12:24 +0000 (12:12 -0700)]
Remove test dependencies project

The test dependencies project is not used

Change-Id: I0a4f2440eede5a62421964b84f9502e00affcadf
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1559

5 years agoadded test case to DBServiceTest.java 80/83580/2
Sandeep J [Thu, 28 Mar 2019 09:59:15 +0000 (15:29 +0530)]
added test case to DBServiceTest.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: I02b723e7f9aa83e2f7f51aa5a9c8883ac149299c
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded file to test Input.java 44/83444/2
Sandeep J [Wed, 27 Mar 2019 08:20:06 +0000 (13:50 +0530)]
added file to test Input.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: I79d0fc71d512b440232ec31cb195c6728d11f5dc
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded test cases to TestVServerInfo.java 76/83576/2
Sandeep J [Thu, 28 Mar 2019 09:50:51 +0000 (15:20 +0530)]
added test cases to TestVServerInfo.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: Ib6fb537e576f928552763ec0e6d1abf2d556f00a
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded file to test RequestData.java 45/83445/2
Sandeep J [Wed, 27 Mar 2019 08:30:46 +0000 (14:00 +0530)]
added file to test RequestData.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: If2270ea76a0a15ae7c6f5d1d580574937be186fd
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded file to test RequestModel.java 70/83570/2
Sandeep J [Thu, 28 Mar 2019 09:21:43 +0000 (14:51 +0530)]
added file to test RequestModel.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: If2270ea76a0a15ae7c6f5d1d580512456be198fd
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded file to test ScopeOverlapModel.java 74/83574/1
Sandeep J [Thu, 28 Mar 2019 09:39:59 +0000 (15:09 +0530)]
added file to test ScopeOverlapModel.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: I293349c249082e176b211d0ffa8bee04cc7660b5
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoConfigComponentAdaptor.java - Sonar Fixes 11/83411/2
Driptaroop Das [Tue, 26 Mar 2019 20:04:20 +0000 (01:34 +0530)]
ConfigComponentAdaptor.java - Sonar Fixes

ConfigComponentAdaptor.java - Sonar Fixes

Issue-ID: APPC-1560
Change-Id: Ia22fc64e378ffb3a206eed256f0a9ab7365381cd
Signed-off-by: Driptaroop Das <driptaroop.das@in.ibm.com>
5 years agoUsed constants in the place of dup literals 03/83303/3
Jegadeesh Babu [Tue, 26 Mar 2019 08:01:39 +0000 (13:31 +0530)]
Used constants in the place of dup literals

Sonar fix

Issue-ID: APPC-1557
Change-Id: I4b52b9febabd0fae8aa098004aeba0ef9a085710
Signed-off-by: Jegadeesh Babu <jegabab1@in.ibm.com>
5 years agoUsed constants to replace duplicated literals 29/83229/5
Jegadeesh Babu [Mon, 25 Mar 2019 16:42:52 +0000 (22:12 +0530)]
Used constants to replace duplicated literals

Sonar Fix

Issue-ID: APPC-1555
Change-Id: I3943003c7fa37aed95e138f03a3fe4b8f48b75ce
Signed-off-by: Jegadeesh Babu <jegabab1@in.ibm.com>
5 years agoremove nexus-staging maven plugin 21/83521/1
Taka Cho [Wed, 27 Mar 2019 19:45:24 +0000 (15:45 -0400)]
remove nexus-staging maven plugin

remove nexus-staging-maven-plugin
on the top of pom file

Change-Id: I50b22c2d1e8e3e663314f701a22de5471224c5b3
Issue-ID: APPC-1561
Signed-off-by: Taka Cho <takamune.cho@att.com>
5 years agoFix incorrect passing of SvcLogicContext value 88/83188/2
Joss Armstrong [Mon, 25 Mar 2019 11:44:38 +0000 (11:44 +0000)]
Fix incorrect passing of SvcLogicContext value

EncyrptionToolDGWrapper changes for Multiple Ansible server
support not working when retrieving data from SvcLogicContext
used for querying DEVICE_AUTHENTICATION table.

Issue-ID: APPC-1545
Change-Id: I8f08910156d6e2b4ae6341c847bc773e4d15841e
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agoAdded constant to replace dup literals 09/83309/2
Jegadeesh Babu [Tue, 26 Mar 2019 08:19:01 +0000 (13:49 +0530)]
Added constant to replace dup literals

Sonar fix

Issue-ID: APPC-1558
Change-Id: I98e36669f5d247a8fe8a9c38d6e5724e76284487
Signed-off-by: Jegadeesh Babu <jegabab1@in.ibm.com>
5 years agoadded test cases to ArtifactHandlerProviderTest 04/83304/3
Sandeep J [Tue, 26 Mar 2019 08:11:32 +0000 (13:41 +0530)]
added test cases to ArtifactHandlerProviderTest

to increase code coverage

Issue-ID: APPC-1086
Change-Id: Ic03b32bc4c8b87a76db2e2aae45f7706f19e9bd4
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded test cases to TestVServerInfo.java 98/83298/3
Sandeep J [Tue, 26 Mar 2019 07:40:29 +0000 (13:10 +0530)]
added test cases to TestVServerInfo.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: I1141fa522e3c4943c2a51d9c585cdcaa0186b373
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded test case to DBServiceTest.java 06/83306/2
Sandeep J [Tue, 26 Mar 2019 08:18:52 +0000 (13:48 +0530)]
added test case to DBServiceTest.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: I202822e53c2086b5db41a8028410c07c46821d1d
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoremove cassandra-driver-core 71/82971/2
Taka Cho [Thu, 21 Mar 2019 18:37:55 +0000 (14:37 -0400)]
remove cassandra-driver-core

In appc-config-param,
remove cassandra-driver-core
to avoid security vulnerability
for guava and netty-handler

Change-Id: I660ae35c4abbc9537e9f9bf5e18fd630e111ca93
Issue-ID: APPC-1553
Signed-off-by: Taka Cho <takamune.cho@att.com>
5 years agoCreated constant to replace dup String literal 20/83220/1
Jegadeesh Babu [Mon, 25 Mar 2019 16:23:43 +0000 (21:53 +0530)]
Created constant to replace dup String literal

Sonar fix

Issue-ID: APPC-1554
Change-Id: I8ff882baf26e765b9b8bcf23bcc37b11a3567ded
Signed-off-by: Jegadeesh Babu <jegabab1@in.ibm.com>
5 years agoAdd back bundles 77/83077/2
Patrick Brady [Fri, 22 Mar 2019 22:05:06 +0000 (15:05 -0700)]
Add back bundles

The newest ccsdk update removed some bundles that
were required by appc. This adds bundle entries to
bring up those bundles.

Change-Id: I5ff802ee4837d1a5a6bcaffcb0805e41d95d6918
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: CCSDK-1156

5 years agoPotential Null pointer exception avoided 62/82962/2
Jegadeesh Babu [Thu, 21 Mar 2019 16:48:49 +0000 (22:18 +0530)]
Potential Null pointer exception avoided

Sonar fix

Issue-ID: APPC-1552
Change-Id: I8f5e6386bd96a136f49ba651aed8fb209bed9435
Signed-off-by: Jegadeesh Babu <jegabab1@in.ibm.com>
5 years agoadded test case to TimeTest.java 45/83045/2
Sandeep J [Fri, 22 Mar 2019 13:58:24 +0000 (19:28 +0530)]
added test case to TimeTest.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: I9ed0192a67d594691f45978d2166b0992a40c656
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded test cases to TestStructuredPropertyHelper 43/82943/3
Sandeep J [Thu, 21 Mar 2019 14:45:38 +0000 (20:15 +0530)]
added test cases to TestStructuredPropertyHelper

to increase code coverage

Issue-ID: APPC-1086
Change-Id: Ic3204a6de7c7024cfba61f3aa63716b0533f9ae9
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoModified code to avoid null pointer exception 59/82959/2
Jegadeesh Babu [Thu, 21 Mar 2019 16:22:29 +0000 (21:52 +0530)]
Modified code to avoid null pointer exception

Sonar fix

Issue-ID: APPC-1550
Change-Id: I6c6afcf13e33f06d70883a588574ed83a9e2dfdc
Signed-off-by: Jegadeesh Babu <jegabab1@in.ibm.com>
5 years agoadded test case to PoolTest.java 41/82941/2
Sandeep J [Thu, 21 Mar 2019 14:17:37 +0000 (19:47 +0530)]
added test case to PoolTest.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: I1389e3f6600bf8c09140a322c978a68c6fee5df1
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded test case to VmStatuschecker.java 39/82939/1
Sandeep J [Thu, 21 Mar 2019 13:56:25 +0000 (19:26 +0530)]
added test case to VmStatuschecker.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: Id1a3be46235af057c1f3f72cd2afd8ebbe377bc2
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoReplaced equals with equalsIgnoreCase method 90/82690/3
Jegadeesh Babu [Tue, 19 Mar 2019 16:19:32 +0000 (21:49 +0530)]
Replaced equals with equalsIgnoreCase method

Sonar fix

Issue-ID: APPC-1546
Change-Id: I27ca1efc97240419f206502860b63d8e625c0bf8
Signed-off-by: Jegadeesh Babu <jegabab1@in.ibm.com>
5 years agoModified code to avoid Null pointer exc 93/82693/3
Jegadeesh Babu [Tue, 19 Mar 2019 16:37:29 +0000 (22:07 +0530)]
Modified code to avoid Null pointer exc

Sonar fix

Issue-ID: APPC-1547
Change-Id: Ie242256130f255a05366774516cf503c2a3d47cc
Signed-off-by: Jegadeesh Babu <jegabab1@in.ibm.com>
5 years agoFix for incorrect handling of SQL results 94/82794/2
Joss Armstrong [Wed, 20 Mar 2019 13:03:26 +0000 (13:03 +0000)]
Fix for incorrect handling of SQL results

Corrected handling of SQL COUNT query

Issue-ID: APPC-1545
Change-Id: I8c246b97c8ed8b483e79ae0e3b2cb51f8b4b62be
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agoChange identifier in database query 06/82706/3
Joss Armstrong [Tue, 19 Mar 2019 18:26:44 +0000 (18:26 +0000)]
Change identifier in database query

Future release of MariaDB adds a keyword currently used as an
identifier

Issue-ID: APPC-1548
Change-Id: I4ced052e6acb816797024f5581f14f5f969d357f
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agoSuppression of long logs in GraphExecutor 49/82649/3
Joss Armstrong [Tue, 19 Mar 2019 09:24:44 +0000 (09:24 +0000)]
Suppression of long logs in GraphExecutor

Logging full configuration files to info log was causing
failures and timeouts on configuration operations in APPC.
Some were removed already under this JIRA but this one was missed.

Issue-ID: APPC-1489
Change-Id: I619f2d1140095859092d6ceff6c7cb44855fb2e1
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agoadded test cases to TestAppcProvider.java 35/82635/3
Sandeep J [Tue, 19 Mar 2019 08:02:17 +0000 (13:32 +0530)]
added test cases to TestAppcProvider.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: Iff273f586c3d6ac9fa3809ef605013f11d3d2178
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded file to test VServerInfo.java 41/82641/2
Sandeep J [Tue, 19 Mar 2019 08:22:55 +0000 (13:52 +0530)]
added file to test VServerInfo.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: Id430a90d0a186c9a065f514efd316af300f690a0
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoSshConnectionSshd - Sonar Fix 40/82540/2
Driptaroop Das [Sun, 17 Mar 2019 19:07:21 +0000 (00:37 +0530)]
SshConnectionSshd - Sonar Fix

SshConnectionSshd - Sonar Fix

Issue-ID: APPC-1543
Change-Id: Id02cd65f4dfeebb43c4eb637d50b649c684397c7
Signed-off-by: Driptaroop Das <driptaroop.das@in.ibm.com>
5 years agoRevert "upgrade mapper-asl" 13/82613/1
Patrick Brady [Mon, 18 Mar 2019 20:21:04 +0000 (13:21 -0700)]
Revert "upgrade mapper-asl"

The old version is a newer version of the dependency.

This reverts commit 651430451d2134d14daab15ebae29eccc878b52b.

Change-Id: I410e9debc0207c12ffa024ff48a69b5f482006de
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1531

5 years agoReplaced hardcoded value with constant defined 13/82413/2
Jegadeesh Babu [Fri, 15 Mar 2019 11:15:40 +0000 (16:45 +0530)]
Replaced hardcoded value with constant defined

Sonar fix

Issue-ID: APPC-1539
Change-Id: Id3891e50bdf89799d1310b37c80ca920d7bdc02c
Signed-off-by: Jegadeesh Babu <jegabab1@in.ibm.com>
5 years agoReplaced hardcoded with const variable 89/82589/1
Jegadeesh Babu [Mon, 18 Mar 2019 13:54:07 +0000 (19:24 +0530)]
Replaced hardcoded with const variable

Sonar fix

Issue-ID: APPC-1544
Change-Id: I19c7f33d4e7d1070fa84a33e4f997923c9c1f8e1
Signed-off-by: Jegadeesh Babu <jegabab1@in.ibm.com>
5 years agoRevert "upgrade databind artifact" 83/82483/2
Patrick Brady [Fri, 15 Mar 2019 19:54:11 +0000 (12:54 -0700)]
Revert "upgrade databind artifact"

Fasterxml databind is being brought in to karaf by opendaylight
and trying to force a different version for the appc components is
causing class errors.

This reverts commit 52cf1a81d591efb2b1ee4b8c5a70b137dfb6c212.

Change-Id: I6d0da2ed081e4abd4b83e8b11935ba43bee0e1aa
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1533

5 years agoupgrade async-http-client version 02/82302/3
Taka Cho [Thu, 14 Mar 2019 20:33:45 +0000 (16:33 -0400)]
upgrade async-http-client version

The installation dependencies can be removed because they
are not being used anymore.

Removing the async-http-client from being packaged into the
installer will remove the security vulnerability.

Change-Id: I555d083365a87753b6a406b0abf863c689d65449
Issue-ID: APPC-1538
Signed-off-by: Taka Cho <takamune.cho@att.com>
5 years agoadded test case to TestVmStatusChecker.java 69/82369/2
Sandeep J [Fri, 15 Mar 2019 06:18:59 +0000 (11:48 +0530)]
added test case to TestVmStatusChecker.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: Idf3acce4be6e950524d342466ee523b9b57b5b2c
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded test case to CapabilityModelTest.java 68/82368/2
Sandeep J [Fri, 15 Mar 2019 06:11:59 +0000 (11:41 +0530)]
added test case to CapabilityModelTest.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: I111df5be541166b00e8eefe292bcd41191df27c3
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded file to test Input.java 99/82299/3
Sandeep J [Thu, 14 Mar 2019 20:19:07 +0000 (01:49 +0530)]
added file to test Input.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: I0878084535f77d1be78c82248d597660bb57ddaa
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agodatabind upgrade artifact 88/82288/2
Taka Cho [Thu, 14 Mar 2019 19:08:38 +0000 (15:08 -0400)]
databind upgrade artifact

databine upgrade 2.8.11.3

Change-Id: Ide510410a3ce0727f3b74053cd915cbb655ce07d
Issue-ID: APPC-1533
Signed-off-by: Taka Cho <takamune.cho@att.com>
5 years agoadded test case to cover Parameters.java 00/82300/2
Sandeep J [Thu, 14 Mar 2019 20:22:52 +0000 (01:52 +0530)]
added test case to cover Parameters.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: Icf7850c8fa43a5d6e5128b00bf708f551c57d1f7
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded test case to VmTest.java 97/82297/2
Sandeep J [Thu, 14 Mar 2019 20:09:10 +0000 (01:39 +0530)]
added test case to VmTest.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: I21c87ab20f6c3faee200fcf2d25120175f58e2c5
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded test case to TunableParametersTest.java 96/82296/2
Sandeep J [Thu, 14 Mar 2019 20:05:20 +0000 (01:35 +0530)]
added test case to TunableParametersTest.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: I0ad33fb62276caeb91e08cd1d0aef7a2e2c39864
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoupgrade h2database 79/82279/2
Taka Cho [Thu, 14 Mar 2019 17:03:33 +0000 (13:03 -0400)]
upgrade h2database

upgrade to 199 version

Change-Id: Icc5086f50d275bd70fae0264390d93b2b7972cfa
Issue-ID: APPC-1530
Signed-off-by: Taka Cho <takamune.cho@att.com>
5 years agoRefactored local var which hides class variable 39/82239/3
Jegadeesh Babu [Thu, 14 Mar 2019 10:33:09 +0000 (16:03 +0530)]
Refactored local var which hides class variable

Sonar fix

Issue-ID: APPC-1536
Change-Id: I2aa494d4fb13f6422382232cb05c94c333650f85
Signed-off-by: Jegadeesh Babu <jegabab1@in.ibm.com>