Sandeep J [Tue, 19 Mar 2019 08:02:17 +0000 (13:32 +0530)]
added test cases to TestAppcProvider.java
to increase code coverage
Issue-ID: APPC-1086
Change-Id: Iff273f586c3d6ac9fa3809ef605013f11d3d2178
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
Sandeep J [Tue, 19 Mar 2019 08:22:55 +0000 (13:52 +0530)]
added file to test VServerInfo.java
to increase code coverage
Issue-ID: APPC-1086
Change-Id: Id430a90d0a186c9a065f514efd316af300f690a0
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
Driptaroop Das [Sun, 17 Mar 2019 19:07:21 +0000 (00:37 +0530)]
SshConnectionSshd - Sonar Fix
SshConnectionSshd - Sonar Fix
Issue-ID: APPC-1543
Change-Id: Id02cd65f4dfeebb43c4eb637d50b649c684397c7
Signed-off-by: Driptaroop Das <driptaroop.das@in.ibm.com>
Patrick Brady [Mon, 18 Mar 2019 20:21:04 +0000 (13:21 -0700)]
Revert "upgrade mapper-asl"
The old version is a newer version of the dependency.
This reverts commit
651430451d2134d14daab15ebae29eccc878b52b.
Change-Id: I410e9debc0207c12ffa024ff48a69b5f482006de
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1531
Jegadeesh Babu [Fri, 15 Mar 2019 11:15:40 +0000 (16:45 +0530)]
Replaced hardcoded value with constant defined
Sonar fix
Issue-ID: APPC-1539
Change-Id: Id3891e50bdf89799d1310b37c80ca920d7bdc02c
Signed-off-by: Jegadeesh Babu <jegabab1@in.ibm.com>
Jegadeesh Babu [Mon, 18 Mar 2019 13:54:07 +0000 (19:24 +0530)]
Replaced hardcoded with const variable
Sonar fix
Issue-ID: APPC-1544
Change-Id: I19c7f33d4e7d1070fa84a33e4f997923c9c1f8e1
Signed-off-by: Jegadeesh Babu <jegabab1@in.ibm.com>
Patrick Brady [Fri, 15 Mar 2019 19:54:11 +0000 (12:54 -0700)]
Revert "upgrade databind artifact"
Fasterxml databind is being brought in to karaf by opendaylight
and trying to force a different version for the appc components is
causing class errors.
This reverts commit
52cf1a81d591efb2b1ee4b8c5a70b137dfb6c212.
Change-Id: I6d0da2ed081e4abd4b83e8b11935ba43bee0e1aa
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1533
Taka Cho [Thu, 14 Mar 2019 20:33:45 +0000 (16:33 -0400)]
upgrade async-http-client version
The installation dependencies can be removed because they
are not being used anymore.
Removing the async-http-client from being packaged into the
installer will remove the security vulnerability.
Change-Id: I555d083365a87753b6a406b0abf863c689d65449
Issue-ID: APPC-1538
Signed-off-by: Taka Cho <takamune.cho@att.com>
Sandeep J [Fri, 15 Mar 2019 06:18:59 +0000 (11:48 +0530)]
added test case to TestVmStatusChecker.java
to increase code coverage
Issue-ID: APPC-1086
Change-Id: Idf3acce4be6e950524d342466ee523b9b57b5b2c
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
Sandeep J [Fri, 15 Mar 2019 06:11:59 +0000 (11:41 +0530)]
added test case to CapabilityModelTest.java
to increase code coverage
Issue-ID: APPC-1086
Change-Id: I111df5be541166b00e8eefe292bcd41191df27c3
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
Sandeep J [Thu, 14 Mar 2019 20:19:07 +0000 (01:49 +0530)]
added file to test Input.java
to increase code coverage
Issue-ID: APPC-1086
Change-Id: I0878084535f77d1be78c82248d597660bb57ddaa
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
Taka Cho [Thu, 14 Mar 2019 19:08:38 +0000 (15:08 -0400)]
databind upgrade artifact
databine upgrade 2.8.11.3
Change-Id: Ide510410a3ce0727f3b74053cd915cbb655ce07d
Issue-ID: APPC-1533
Signed-off-by: Taka Cho <takamune.cho@att.com>
Sandeep J [Thu, 14 Mar 2019 20:22:52 +0000 (01:52 +0530)]
added test case to cover Parameters.java
to increase code coverage
Issue-ID: APPC-1086
Change-Id: Icf7850c8fa43a5d6e5128b00bf708f551c57d1f7
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
Sandeep J [Thu, 14 Mar 2019 20:09:10 +0000 (01:39 +0530)]
added test case to VmTest.java
to increase code coverage
Issue-ID: APPC-1086
Change-Id: I21c87ab20f6c3faee200fcf2d25120175f58e2c5
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
Sandeep J [Thu, 14 Mar 2019 20:05:20 +0000 (01:35 +0530)]
added test case to TunableParametersTest.java
to increase code coverage
Issue-ID: APPC-1086
Change-Id: I0ad33fb62276caeb91e08cd1d0aef7a2e2c39864
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
Taka Cho [Thu, 14 Mar 2019 17:03:33 +0000 (13:03 -0400)]
upgrade h2database
upgrade to 199 version
Change-Id: Icc5086f50d275bd70fae0264390d93b2b7972cfa
Issue-ID: APPC-1530
Signed-off-by: Taka Cho <takamune.cho@att.com>
Jegadeesh Babu [Thu, 14 Mar 2019 10:33:09 +0000 (16:03 +0530)]
Refactored local var which hides class variable
Sonar fix
Issue-ID: APPC-1536
Change-Id: I2aa494d4fb13f6422382232cb05c94c333650f85
Signed-off-by: Jegadeesh Babu <jegabab1@in.ibm.com>
Jegadeesh Babu [Wed, 13 Mar 2019 13:34:49 +0000 (19:04 +0530)]
Handle exception
Sonar fix
Issue-ID: APPC-1535
Change-Id: Ic980f53362a87cc8674252d6a8c4cb0cc50035c3
Signed-off-by: Jegadeesh Babu <jegabab1@in.ibm.com>
Driptaroop Das [Wed, 6 Mar 2019 19:49:14 +0000 (01:19 +0530)]
Multiple Sonar Fixes
Multiple Sonar Fixes
Issue-ID: APPC-1525
Change-Id: I58b8adc0e53a00c6d3de05c921dafdd3dd9fe118
Signed-off-by: Driptaroop Das <driptaroop.das@in.ibm.com>
Sudarshan Kumar [Tue, 12 Mar 2019 09:51:19 +0000 (15:21 +0530)]
Added Junit Class for ParamsHandlerActivator
Added Junit Class for ParamsHandlerActivator
Issue-ID: APPC-1372
Change-Id: I1198cd62354e8781f4fe9e07676ad64fc7f3ccf9
Signed-off-by: Sudarshan Kumar <sudars19@in.ibm.com>
Taka Cho [Wed, 13 Mar 2019 18:40:15 +0000 (14:40 -0400)]
upgrade databind artifact
upgrade jackson's databind
from 2.8.11.2 to 2.8.11.3
Change-Id: I9bf3ab8021f91f6ed36bdffdacbaeeac78d2e87c
Issue-ID: APPC-1533
Signed-off-by: Taka Cho <takamune.cho@att.com>
osinstom [Fri, 8 Mar 2019 12:30:28 +0000 (13:30 +0100)]
Adding DistributeTrafficCheck LCM API
Issue-ID: APPC-1444
Change-Id: I26163c216184eb49daeea01cbb54f0b9803e1f95
Signed-off-by: Tomek Osinski <tomasz.osinski2@orange.com>
Taka Cho [Mon, 11 Mar 2019 20:22:03 +0000 (16:22 -0400)]
upgrade mapper-asl
move to 1.9.3 for mapper-asl
for securilty vulnerability
Change-Id: I9189a59ad96af9a9cd761941ed64ed9eae77743f
Issue-ID: APPC-1531
Signed-off-by: Taka Cho <takamune.cho@att.com>
Sandeep J [Tue, 12 Mar 2019 10:27:05 +0000 (15:57 +0530)]
added file to test CapabilityModel.java
to increase code coverage
Issue-ID: APPC-1086
Change-Id: I47987b8d304db6447fc34ce869f5b16f10c6c6e9
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
Sandeep J [Tue, 12 Mar 2019 08:16:38 +0000 (13:46 +0530)]
added file to test SDCArtifact.java
to increase code coverage
Issue-ID: APPC-1086
Change-Id: Id50d1ae6dd6323a6f3f0cb5a225cb141f143019c
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
Sandeep J [Tue, 12 Mar 2019 10:30:30 +0000 (16:00 +0530)]
added missing licence to CapabilityModel.java
added missing licence
Issue-ID: APPC-1086
Change-Id: I8062927427b4d61b9e96051facb7316c2be25233
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
Jegadeesh Babu [Fri, 8 Mar 2019 12:17:50 +0000 (17:47 +0530)]
Handled exception
Sonar fix
Issue-ID: APPC-1526
Change-Id: I04e8425625a4dd2a5561c80d4e685b32a21b6a70
Signed-off-by: Jegadeesh Babu <jegabab1@in.ibm.com>
Jegadeesh Babu [Mon, 11 Mar 2019 14:12:26 +0000 (19:42 +0530)]
Added logger statements
Sonar fix
Issue-ID: APPC-1529
Change-Id: Ibb3dd50ad85232f7c5474c075045523aac531899
Signed-off-by: Jegadeesh Babu <jegabab1@in.ibm.com>
Taka Cho [Mon, 11 Mar 2019 17:40:20 +0000 (13:40 -0400)]
upgrade to 197 for h2database
In order to remove the security
vulnerability for h2database
the version is going to use 197.
Change-Id: Ib761b986ccbed89854d7922a9336a47c3a8d368f
Issue-ID: APPC-1530
Signed-off-by: Taka Cho <takamune.cho@att.com>
Jegadeesh Babu [Fri, 8 Mar 2019 12:36:15 +0000 (18:06 +0530)]
Added logger
Sonar fix
Issue-ID: APPC-1527
Change-Id: Ic2708d67b6f2740ddabe834e56b09c11389b8894
Signed-off-by: Jegadeesh Babu <jegabab1@in.ibm.com>
Jegadeesh Babu [Tue, 12 Mar 2019 13:09:54 +0000 (18:39 +0530)]
Added logger
Sonar fix
Issue-ID: APPC-1532
Change-Id: I6c1ca46e0fb95d4eb41c3b6fd6a8e640ca047a00
Signed-off-by: Jegadeesh Babu <jegabab1@in.ibm.com>
Sudarshan Kumar [Mon, 11 Mar 2019 09:17:48 +0000 (14:47 +0530)]
Added Junit For VNFResolverDataReader
Added Junit Class for VNFResolverDataReader
Issue-ID: APPC-1372
Change-Id: I8236c89f95ffe6ffb61954456a7bab09082e47b2
Signed-off-by: Sudarshan Kumar <sudars19@in.ibm.com>
Sandeep J [Wed, 6 Mar 2019 10:03:08 +0000 (15:33 +0530)]
added file to test EnvVariables.java
to increase code coverage
Issue-ID: APPC-1086
Change-Id: I0ccef8fe411dec8a699152d7710ac83683c5cb72
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
Lathishbabu Ganesan [Thu, 7 Mar 2019 14:23:42 +0000 (09:23 -0500)]
Added test case for Metric builder
Issue-ID: APPC-1456
Change-Id: I814d1cdceaecc0e248ee2a0c9946069358ebbb06
Signed-off-by: Lathishbabu Ganesan <lathishbabu.ganesan@ericsson.com>
Sandeep J [Fri, 8 Mar 2019 10:34:23 +0000 (16:04 +0530)]
added test cases to VmStatusChecker.java
to increase code coverage
Issue-ID: APPC-1086
Change-Id: Ica373ebc3281c9f66d2c2690af30394b45ea09ea
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
Sandeep J [Thu, 7 Mar 2019 09:17:47 +0000 (14:47 +0530)]
added test case to TestDGGeneralDBService.java
to increase code coverage
Issue-ID: APPC-1086
Change-Id: Idfc3aa674b566f5e4e04e29396dd9c08607854b6
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
Sandeep J [Thu, 7 Mar 2019 09:06:18 +0000 (14:36 +0530)]
added file to test FqdnList.java
to increase code coverage
Issue-ID: APPC-1086
Change-Id: Ic2028fa37825facb1e8999a8328c0773eb41abcc
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
Sandeep J [Fri, 8 Mar 2019 10:01:02 +0000 (15:31 +0530)]
added file to test Parameters.java
to increase code coverage
Issue-ID: APPC-1086
Change-Id: I046d1154ce19801cbc18883799f71ec401baa1cb
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
Sudarshan Kumar [Fri, 8 Mar 2019 10:11:16 +0000 (15:41 +0530)]
Sonar Fix- NullPointer & removed unused variables
Sonar Fix- Handling NullPointerException and removed unused variables
Issue-ID: APPC-1399
Change-Id: Iac61f72e7c1547ee7cf5aeab82a621a380e109fa
Signed-off-by: Sudarshan Kumar <sudars19@in.ibm.com>
Sandeep J [Mon, 4 Mar 2019 07:41:42 +0000 (13:11 +0530)]
added test cases to TimeTest.java
to increase code coverage
Issue-ID: APPC-1086
Change-Id: Ie6bc65d604ee673964507858ae68b7438f314841
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
Dunietz, Irwin [Sun, 3 Mar 2019 17:20:53 +0000 (12:20 -0500)]
Update appc-dispatcher for >1 ansible servers
Change Transaction record update logic to handle null instance entry.
Issue-ID: APPC-1516
Change-Id: Ia87e08fbb61d4d0be38802e3e81b45773b1d9498
Signed-off-by: Dunietz, Irwin <irwin.dunietz@att.com>
Sandeep J [Mon, 4 Mar 2019 07:49:55 +0000 (13:19 +0530)]
added test cases to TestStructuredPropertyTestHelp
to increase code coverage
Issue-ID: APPC-1086
Change-Id: I4b1afa01afabf9bdd95ea6b80f3af335523155b4
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
Joss Armstrong [Tue, 5 Mar 2019 14:55:41 +0000 (14:55 +0000)]
Test coverage in RequestValidator
Increased coverage from 61% to 79%
Issue-ID: APPC-1436
Change-Id: I4a372d40b5593f32685b09c5240654dab0aee968
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
Joss Armstrong [Tue, 5 Mar 2019 14:18:59 +0000 (14:18 +0000)]
Test coverage in ArtifactHandlerClient
Increase coverage from 34% to 83%
Fix for Sonar major issue on branch coverage
Issue-ID: APPC-1436
Change-Id: Ie26e2cb71c833e4f086da2a238bd6f956bd85f33
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
Joss Armstrong [Tue, 5 Mar 2019 17:12:41 +0000 (17:12 +0000)]
Test coverage in ArtifactHandlerProvider
Increase coverage from 51% to 96%
Fix assertions and Sonar major branch coverage problem
Issue-ID: APPC-1335
Change-Id: I1edb662db199dda46972fdf37820aa1de1ad46fc
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
Sandeep J [Wed, 6 Mar 2019 11:40:14 +0000 (17:10 +0530)]
added file to test EscapeUtils.java
to increase code coverage
Issue-ID: APPC-1086
Change-Id: I3c98deea811048097be6f87449d0f58b43b29be6
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
Sandeep J [Wed, 6 Mar 2019 09:39:39 +0000 (15:09 +0530)]
added file to test Vnfcslist.java
to increase code coverage
Issue-ID: APPC-1086
Change-Id: Id574d909b674b1bdad8b96663d3fdb66cc276ecd
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
Modaboina, Kusumakumari (km583p) [Fri, 1 Mar 2019 20:38:31 +0000 (15:38 -0500)]
added skip hpervisor check and other adapterchange
Issue-ID: APPC-1378
Change-Id: Ia8db114af1347a9523676034fce56640f523e523
Signed-off-by: Modaboina, Kusumakumari (km583p) <km583p@us.att.com>
Lathishbabu Ganesan [Mon, 4 Mar 2019 17:18:30 +0000 (12:18 -0500)]
Added test case for Metric Activator
Increased coverage from 0% to 100%
Issue-ID: APPC-1522
Change-Id: Ie8936926ccb5556fffd15467039ad27f8b99f27e
Signed-off-by: Lathishbabu Ganesan <lathishbabu.ganesan@ericsson.com>
Sandeep J [Tue, 5 Mar 2019 10:36:15 +0000 (16:06 +0530)]
added file to test Vm.java
to increase code coverage
Issue-ID: APPC-1086
Change-Id: I251cbcaa1566ad405198a8b8f6669f783aef260e
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
Sandeep J [Tue, 5 Mar 2019 10:23:57 +0000 (15:53 +0530)]
added file to test TunableParameters.java
to increase code coverage
Issue-ID: APPC-1086
Change-Id: I7844c0c99f1c9ad6e58a6bc7d8b71aee1ff0bd55
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
Sandeep J [Mon, 4 Mar 2019 08:07:51 +0000 (13:37 +0530)]
added file to test ArtifactProcessorException.java
to increase code coverage
Issue-ID: APPC-1086
Change-Id: If5082027e00615c5633621fdd93be1fe13ca27c7
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
Lathishbabu Ganesan [Thu, 28 Feb 2019 16:48:43 +0000 (11:48 -0500)]
Added test case for Connection Factory
Increased the code coverage from 0% to 100%
Issue-ID: APPC-1515
Change-Id: I186f57ce78127c64cc120bcdaa61b418e67fb0de
Signed-off-by: Lathishbabu Ganesan <lathishbabu.ganesan@ericsson.com>
Joss Armstrong [Mon, 4 Mar 2019 09:52:33 +0000 (09:52 +0000)]
Test coverage in DefaultConfiguration
Increased coverage from 79% to 89%
Issue-ID: APPC-1520
Change-Id: I6a7fccb7768fe6eb996055be4d14bc366c228feb
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
Sandeep J [Fri, 1 Mar 2019 11:35:41 +0000 (17:05 +0530)]
added test case to TestStructuredPropertyHelper
to increase code coverage
Issue-ID: APPC-1086
Change-Id: Ibc33a99c5e2ad26c1232eadde505071b58d1fb6b
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
Sandeep J [Fri, 1 Mar 2019 11:01:24 +0000 (16:31 +0530)]
added test cases to CachedElementTest.java
to increase code coverage
Issue-ID: APPC-1086
Change-Id: Idfb3ce36d41fdec4a5286da63b8a9592c1c83a96
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
Jessica Wagantall [Sat, 2 Mar 2019 01:01:19 +0000 (17:01 -0800)]
Add missing INFO.yaml blocks
Add missing information so that the new verify
job passes. Fix indentation.
Change-Id: I93af9ea59d8c2466e80f9146a4371f5c8b509e2c
Issue-ID: CIMAN-134
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>
Joss Armstrong [Fri, 1 Mar 2019 17:20:00 +0000 (17:20 +0000)]
Test coverage for HttpClientTest
Added test coverage for untested class
Increased coverage from 0% to 89%
Issue-ID: APPC-1520
Change-Id: I113d515df3b6f6ef12565cf390f0bd2f2e8ac2f0
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
Joss Armstrong [Fri, 1 Mar 2019 16:41:24 +0000 (16:41 +0000)]
Test coverage in RestClientInvoker
Added test for untested class
Increased test coverage from 0% to 94%
Issue-ID: APPC-1520
Change-Id: I51610584cd203f5de7286c325332cade6f3c2bd6
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
Jegadeesh Babu [Fri, 1 Mar 2019 14:16:41 +0000 (19:46 +0530)]
Handled exception
Sonar fix
Issue-ID: APPC-1518
Change-Id: Ia052693a420bbd7b06048336d518a49e598b4265
Signed-off-by: Jegadeesh Babu <jegabab1@in.ibm.com>
Jegadeesh Babu [Fri, 1 Mar 2019 13:58:38 +0000 (19:28 +0530)]
Handled interrupted exception sonar fix
Sonar fix
Issue-ID: APPC-1517
Change-Id: I0a9fb64812c84963b08a53b09358f598d96eb014
Signed-off-by: Jegadeesh Babu <jegabab1@in.ibm.com>
Joss Armstrong [Fri, 1 Mar 2019 12:34:01 +0000 (12:34 +0000)]
Test coverage in ConfigComponentAdaptor
Increased coverage from 79% to 89%
Fixed indentation
Issue-ID: APPC-1497
Change-Id: I9cee309b916eff93887a8d2b7691f9a7c6ba204b
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
Jegadeesh Babu [Thu, 28 Feb 2019 13:38:15 +0000 (19:08 +0530)]
Added logger
Sonar fix
Issue-ID: APPC-1513
Change-Id: Ie6a28085288457b8bf8fea5c6d21313e61532f7c
Signed-off-by: Jegadeesh Babu <jegabab1@in.ibm.com>
Sonali Das [Wed, 27 Feb 2019 20:39:15 +0000 (15:39 -0500)]
Changes for design service
Issue-ID: APPC-1342
Change-Id: Iff66ff977b7ca6bbe0e83fa467b72d253d9200b8
Signed-off-by: Sonali Das <sd394g@att.com>
Sudarshan Kumar [Thu, 21 Feb 2019 17:21:01 +0000 (22:51 +0530)]
Added Junit Class For LicenseModelBuilder.java
Added Junit Class For LicenseModelBuilder.java
Issue-ID: APPC-1372
Change-Id: I9acb703ccec2775c5c64e0be3a14ea93eb85b868
Signed-off-by: Sudarshan Kumar <sudars19@in.ibm.com>
Joss Armstrong [Thu, 28 Feb 2019 07:38:46 +0000 (07:38 +0000)]
Test coverage in AppcProviderLcm
Increased coverage from 74% to 100%
Fixed Sonar major issue for branch coverage
Issue-ID: APPC-1509
Change-Id: I8d487b295af7930dfcf917970f9806ac37023853
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
Ganesh Chandrasekaran [Tue, 26 Feb 2019 01:23:58 +0000 (10:23 +0900)]
added GetTemplateConfig_Saltstack DG
Issue-ID: APPC-1101
Change-Id: I185caa7cbd23cf5ce7973d74f9b9cde896267433
Signed-off-by: Ganesh Chandrasekaran <ganesh.c@samsung.com>
Ganesh Chandrasekaran [Tue, 26 Feb 2019 01:07:05 +0000 (10:07 +0900)]
added new saltstack-adapter-1.0 DG
Issue-ID: APPC-1101
Change-Id: Id5df4a856f73dddcecf7f4751ed07bdfceadf85a
Signed-off-by: Ganesh Chandrasekaran <ganesh.c@samsung.com>
Joss Armstrong [Thu, 28 Feb 2019 12:38:37 +0000 (12:38 +0000)]
Test coverage in RestAdapterImpl
Increased coverage from 69% to 98%
Fixed Sonar major issue for branch coverage
Issue-ID: APPC-1512
Change-Id: Idb989cf6266b4e7c7dda1e9bca72483038649eda
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
Joss Armstrong [Thu, 28 Feb 2019 10:46:08 +0000 (10:46 +0000)]
Test coverage in TopologyService
Increased coverage from 80% to 97%
Fix Sonar major issue for branch coverage
Issue-ID: APPC-1509
Change-Id: I2f5af194b44e5871fc00c9cc12123fa6d6c1fd5d
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
Driptaroop Das [Wed, 27 Feb 2019 19:31:38 +0000 (01:01 +0530)]
CachedElement.java - Sonar Fixes
CachedElement.java - Sonar Fixes
Issue-ID: APPC-1508
Change-Id: I24bdb1ab1e3c00975eba4ea92dcf34b8e26849dc
Signed-off-by: Driptaroop Das <driptaroop.das@in.ibm.com>
Lathishbabu Ganesan [Tue, 26 Feb 2019 17:15:09 +0000 (12:15 -0500)]
Added test case for Rebuild Server
Issue-ID: APPC-1502
Change-Id: Idff986e1727e13c5a402184b416365328418c7ab
Signed-off-by: Lathishbabu Ganesan <lathishbabu.ganesan@ericsson.com>
Joss Armstrong [Thu, 28 Feb 2019 08:10:55 +0000 (08:10 +0000)]
Test coverage in MockQueryHelper
Increased coverage from 17% to 91%
Fixed Sonar major issue for branch coverage
Issue-ID: APPC-1509
Change-Id: I822053c74db8f16875448206a22048032d30ad45
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
Jegadeesh Babu [Wed, 27 Feb 2019 13:41:51 +0000 (19:11 +0530)]
Added null check to avoid null pointer exception
Sonar fix
Issue-ID: APPC-1505
Change-Id: Iefd8a45aacb6e8de50c16c36fe9ab551401ca417
Signed-off-by: Jegadeesh Babu <jegabab1@in.ibm.com>
Joss Armstrong [Wed, 27 Feb 2019 19:27:19 +0000 (19:27 +0000)]
Test coverage in ConfigResourceNode
Add >100 lines of coverage and increase from 71% to 99%
Increase branch coverage to fix Sonar major issue
Extract repeated strings to constants
Issue-ID: APPC-1504
Change-Id: Ib3b1e83d39f02befaede035b84a0ebef96b36cfd
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
Joss Armstrong [Wed, 27 Feb 2019 21:07:50 +0000 (21:07 +0000)]
Test coverage in FlowControlNode
Increase line coverage from 72% to 92%
Fix for Sonar major issue for branch coverage
Issue-ID: APPC-1499
Change-Id: Ie73b6c97fcf50421ca6a73a8273c09ace0faf67f
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
Patrick Brady [Wed, 27 Feb 2019 21:41:53 +0000 (13:41 -0800)]
Fix failing powermock tests
The version of javassist coming from opendaylight is not working correctly
with powermock. Adding a test scoped dependency for a working version of
javassist.
Test classes added in this commit are not new, they were temporarily
removed as part of https://gerrit.onap.org/r/#/c/79046/
Change-Id: I193873c0d4abd7b11592a95bff9a6b07cf2d7191
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1277
Jegadeesh Babu [Tue, 26 Feb 2019 10:16:27 +0000 (15:46 +0530)]
Handled interrupted exception
Sonar fix
Issue-ID: APPC-1490
Change-Id: I261e2d4739bf5a1d3f11dc1774b04da98a366c16
Signed-off-by: Jegadeesh Babu <jegabab1@in.ibm.com>
Joss Armstrong [Wed, 27 Feb 2019 09:59:54 +0000 (09:59 +0000)]
Test coverage in DBService
Increase coverage from 71% to 98%
Fix for Sonar major issue on branch coverage
Issue-ID: APPC-1499
Change-Id: I74261af92b3263a03d29d476ad097182e6112ad9
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
Joss Armstrong [Wed, 27 Feb 2019 08:07:43 +0000 (08:07 +0000)]
Test coverage for ObjectFactory
Increase coverage from 0% to 100%
Issue-ID: APPC-1499
Change-Id: Ia6209174b99acdeb03698eea9fe96d51a2cccd13
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
Lathishbabu Ganesan [Wed, 27 Feb 2019 14:29:34 +0000 (09:29 -0500)]
Added test cases for Sequence Generator class
Increased the code coverage from 0% to 100%
Issue-ID: APPC-1457
Change-Id: Id71298cb482a1c9ca00c3ced9685087e56c249ca
Signed-off-by: Lathishbabu Ganesan <lathishbabu.ganesan@ericsson.com>
Lathishbabu Ganesan [Tue, 26 Feb 2019 16:47:11 +0000 (11:47 -0500)]
Added test case for Stack Resource
Increased the coverage from 0% to 100%
Issue-ID: APPC-1501
Change-Id: Idb8d7b6efc7831dc0c6ca8094783cbc84ecfd14e
Signed-off-by: Lathishbabu Ganesan <lathishbabu.ganesan@ericsson.com>
Lathishbabu Ganesan [Wed, 27 Feb 2019 14:06:57 +0000 (09:06 -0500)]
Additional test case to cover Reboot scenario
Issue-ID: APPC-1507
Change-Id: I1afa62d34bec6cc3bb56abd4fa5ffc9a5beee67a
Signed-off-by: Lathishbabu Ganesan <lathishbabu.ganesan@ericsson.com>
Jegadeesh Babu [Wed, 27 Feb 2019 14:03:12 +0000 (19:33 +0530)]
Handled interrupted exception
Sonar fix
Issue-ID: APPC-1506
Change-Id: If1e6e2aee7a2345a8e228e9cd793d02aa6eb685e
Signed-off-by: Jegadeesh Babu <jegabab1@in.ibm.com>
Jegadeesh Babu [Mon, 18 Feb 2019 13:26:48 +0000 (18:56 +0530)]
Added Null check
Code to avoid null pointer Exception
Issue-ID: APPC-1451
Change-Id: I5e2324a2ddffbc50251ee93a1278cfb68e62a551
Signed-off-by: Jegadeesh Babu <jegabab1@in.ibm.com>
Joss Armstrong [Tue, 26 Feb 2019 11:05:43 +0000 (11:05 +0000)]
Line and branch coverage for Transaction
Increased line coverage from 54% to 99%
Added coverage for 50 branches resolving major Sonar issue
Issue-ID: APPC-1499
Change-Id: I10dba08c62247401ee4c9fb08fe65f3854445fb5
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
Jegadeesh Babu [Tue, 26 Feb 2019 11:22:23 +0000 (16:52 +0530)]
Replaced print statement with logger
Sonar Fix
Issue-ID: APPC-1500
Change-Id: I25e885297e3e3881e8164e2bbd6f608f808ac76b
Signed-off-by: Jegadeesh Babu <jegabab1@in.ibm.com>
Joss Armstrong [Tue, 26 Feb 2019 13:00:23 +0000 (13:00 +0000)]
Fix unit tests for PrecheckOption
Increased line coverage to 100%
Increased branch coverage to clear Sonar major warning
Removed console logging and cleaned up assertions
Issue-ID: APPC-1499
Change-Id: Ifc7163d2e112914749514099779bd5d75ba729c9
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
Joss Armstrong [Tue, 26 Feb 2019 12:40:24 +0000 (12:40 +0000)]
Fixed tests on PreCheck class
Replaced console printing with assertions
Added branch coverage to clear Sonar major warning
Increased line coverage to 100%
Issue-ID: APPC-1499
Change-Id: Ia027b9d7f414789816d80e12543d27a0baeed9c1
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
Joss Armstrong [Mon, 25 Feb 2019 14:35:44 +0000 (14:35 +0000)]
Fix for timeout error when logging >1MB data
Potentially large logs moved to TRACE level, INFO level
logs limited in size and related tests updated
Issue-ID: APPC-1489
Change-Id: I9ea85e64380479d835da03ed2af3e4ab96ece67e
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
Lathishbabu Ganesan [Tue, 26 Feb 2019 14:13:30 +0000 (09:13 -0500)]
Added test case for Attach volume class
Issue-ID: APPC-1467
Change-Id: Ifc902979c955df03ab847b4dd770bf737ff69eb9
Signed-off-by: Lathishbabu Ganesan <lathishbabu.ganesan@ericsson.com>
Lathishbabu Ganesan [Tue, 26 Feb 2019 15:22:17 +0000 (10:22 -0500)]
Added test case for Appc Provider
Increased the coverage from 0% to 96%
Issue-ID: APPC-1454
Change-Id: I5bfb97101dd7ef5e9c138694b783be8cdd511f0e
Signed-off-by: Lathishbabu Ganesan <lathishbabu.ganesan@ericsson.com>
Joss Armstrong [Mon, 25 Feb 2019 10:32:13 +0000 (10:32 +0000)]
Fix for casting/subclassing in MetricRegistry
Put in code to avoid cast exceptions from this class
and updated tests
Issue-ID: APPC-1480
Change-Id: I8b54d93e52eb523f08d13e874b4d18d05feede6b
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
Joss Armstrong [Tue, 26 Feb 2019 09:05:11 +0000 (09:05 +0000)]
Test coverage for CCAActivator
Increased coverage from 0% to 93%
Issue-ID: APPC-1497
Change-Id: Ie78ac50a08b47cac9bedb9d34b089ac3ad23ab22
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
Jegadeesh Babu [Tue, 26 Feb 2019 10:25:01 +0000 (15:55 +0530)]
Handled interrupted exception Rechecked
Rechecked sonar fix
Issue-ID: APPC-1492
Change-Id: I8cec7e0e0cb5614e959f6eaa35271f55ddbba24b
Signed-off-by: Jegadeesh Babu <jegabab1@in.ibm.com>
Jegadeesh Babu [Tue, 26 Feb 2019 11:03:35 +0000 (16:33 +0530)]
Added logger statement
Sonar vulnerabilty fix
Issue-ID: APPC-1498
Change-Id: I29de3443a5a96c4d4bc5c7bab24b4fdb7f3358d3
Signed-off-by: Jegadeesh Babu <jegabab1@in.ibm.com>
Joss Armstrong [Tue, 26 Feb 2019 11:50:20 +0000 (11:50 +0000)]
Test coverage for Parameters
Increased coverage to 100%
Issue-ID: APPC-1499
Change-Id: I982023d9f818320f709da552d668b68e5ce0f7b3
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
Joss Armstrong [Tue, 26 Feb 2019 11:40:14 +0000 (11:40 +0000)]
Test coverage for ActionIdentifier
Increased test coverage to 100%
Issue-ID: APPC-1499
Change-Id: I78eee1fdc64840898e1b76984855a43828ee93b4
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
Ganesh Chandrasekaran [Thu, 21 Feb 2019 04:54:41 +0000 (13:54 +0900)]
Update GetDevRunningConfig for SaltstackDG
Issue-ID: APPC-1101
Change-Id: Ie3cbfb05b1dd7a1ecc15e0d7b844801769836fab
Signed-off-by: Ganesh Chandrasekaran <ganesh.c@samsung.com>
Ganesh Chandrasekaran [Thu, 21 Feb 2019 04:41:26 +0000 (13:41 +0900)]
APPC Generic Saltstack DG addition
Issue-ID: APPC-1101
Change-Id: Ie240bb949481a7c59a508c2157a4ace95fe4a861
Signed-off-by: Ganesh Chandrasekaran <ganesh.c@samsung.com>
Code Review / appc.git / log