appc.git
5 years agoTest coverage in RequestValidatorImpl 28/79028/2
Joss Armstrong [Fri, 22 Feb 2019 16:17:28 +0000 (16:17 +0000)]
Test coverage in RequestValidatorImpl

Increased coverage from 78% to 89%

Issue-ID: APPC-1485
Change-Id: I2b4e87d0ae9b344ef59005bc19cd2600e4e041e8
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agoTest coverage in ExecuteNodeActionImpl 55/78955/7
Joss Armstrong [Thu, 21 Feb 2019 18:24:20 +0000 (18:24 +0000)]
Test coverage in ExecuteNodeActionImpl

Increase coverage from 42% to 92%

Issue-ID: APPC-1477
Change-Id: Ic9ef407663d0a79ccec8ed7045230c4d734a3cc4
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agoTest coverage in MetricRegistryImpl 63/78963/5
Joss Armstrong [Thu, 21 Feb 2019 19:16:35 +0000 (19:16 +0000)]
Test coverage in MetricRegistryImpl

Added test coverage for MetricRegistryImpl

Issue-ID: APPC-1478
Change-Id: I91eff5418ec14d294fa80af3d6d7025338b82072
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agoTest coverage in MessageAdapterImpl 11/79011/3
Joss Armstrong [Fri, 22 Feb 2019 12:13:27 +0000 (12:13 +0000)]
Test coverage in MessageAdapterImpl

Added test cases for untested portions of code

Issue-ID: APPC-1481
Change-Id: Id61ec5c5824c3d9fecbfb83d47bfa0164ae96759
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agoTest coverage in AbstractRequestHandlerImpl 20/79020/4
Joss Armstrong [Fri, 22 Feb 2019 14:56:40 +0000 (14:56 +0000)]
Test coverage in AbstractRequestHandlerImpl

Increased coverage from 72% to 95%

Issue-ID: APPC-1484
Change-Id: I1bbb8aaf1b7ca33b20d8768cacd14c7bdabe5caa
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agoTest coverage for RequestValidationPolicy 12/79012/4
Joss Armstrong [Fri, 22 Feb 2019 12:36:50 +0000 (12:36 +0000)]
Test coverage for RequestValidationPolicy

Added test cases for untested parts of code

Issue-ID: APPC-1482
Change-Id: I3dfa64b4eb1f69a08ca3346d75ae362affd55e0d
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agoError in ScheduledPublishingPolicyImpl 01/79001/4
Joss Armstrong [Fri, 22 Feb 2019 09:51:58 +0000 (09:51 +0000)]
Error in ScheduledPublishingPolicyImpl

Fix for error in code that causes failure in a
particular case

Issue-ID: APPC-1479
Change-Id: If9f8dc21d151ea3e06939ad4db4272f48a8e8b58
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agoResolved merge conflict 04/79004/2
Jegadeesh Babu [Fri, 22 Feb 2019 10:12:02 +0000 (15:42 +0530)]
Resolved merge conflict

Resolved conflict

Issue-ID: APPC-1474
Change-Id: I2c46a69b112aa3b3796fcb2939b34a8c604e5119
Signed-off-by: Jegadeesh Babu <jegabab1@in.ibm.com>
5 years agoSeperated assignment statement from expression 30/78830/3
Jegadeesh Babu [Wed, 20 Feb 2019 12:39:40 +0000 (18:09 +0530)]
Seperated assignment statement from expression

Sonar bug fix

Issue-ID: APPC-1468
Change-Id: I2ff7e01516cf7328357d2a48643947c782ce4fd9
Signed-off-by: Jegadeesh Babu <jegabab1@in.ibm.com>
5 years agoChange dg-mdsal to blueprint 43/77543/8
Patrick Brady [Tue, 29 Jan 2019 22:05:31 +0000 (14:05 -0800)]
Change dg-mdsal to blueprint

Change-Id: I8f9978dce4e7f483a35a338f8c57b854a7c5b29e
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1368

5 years agoChange appc-oam to blueprint 29/77529/7
Patrick Brady [Tue, 29 Jan 2019 18:18:27 +0000 (10:18 -0800)]
Change appc-oam to blueprint

Change-Id: I848953fd492ad05d178c7b2d85b191248b45fa36
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1368

5 years agoChange seq generator to blueprint 31/77531/8
Patrick Brady [Tue, 29 Jan 2019 18:41:18 +0000 (10:41 -0800)]
Change seq generator to blueprint

Change-Id: Ib46f149f3c4f7b838beb58f75bc20269ac945a3a
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1368

5 years agoRemove duplicate versions 58/76158/4
Patrick Brady [Tue, 22 Jan 2019 22:19:54 +0000 (14:19 -0800)]
Remove duplicate versions

These versions are inherited from opendaylight parent
poms. Removing the override for these inherited versions.

Change-Id: I83b374e4d8815e21fd48bedbe4dd46bc246e44a4
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1355

5 years agoSonar Fixes - ProviderStackOperation.java 98/78698/3
Driptaroop Das [Mon, 18 Feb 2019 18:46:57 +0000 (00:16 +0530)]
Sonar Fixes - ProviderStackOperation.java

Sonar Fixes - ProviderStackOperation.java

Issue-ID: APPC-1461
Change-Id: I31aef2c7328f1c3970e18a30530a9848bd5b6466
Signed-off-by: Driptaroop Das <driptaroop.das@in.ibm.com>
5 years agoTest coverage in LogPublisher 66/78966/1
Joss Armstrong [Thu, 21 Feb 2019 19:25:50 +0000 (19:25 +0000)]
Test coverage in LogPublisher

Added 100% coverage for LogPublisher

Issue-ID: APPC-1478
Change-Id: Iaf1d10826eb7cd622f63bf0a7de0b2420bb8f597
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agoIncrease coverage of Passwords from 42% to 98% 49/78949/2
Joss Armstrong [Thu, 21 Feb 2019 17:18:01 +0000 (17:18 +0000)]
Increase coverage of Passwords from 42% to 98%

Also fixed some issues around null values and logging

Issue-ID: APPC-1476
Change-Id: I0145b5c973fe9a624962744ff56fd691114779ba
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agoTest coverage for HttpClientUtil 43/78843/3
Joss Armstrong [Wed, 20 Feb 2019 13:59:56 +0000 (13:59 +0000)]
Test coverage for HttpClientUtil

Add new test class and increase coverage

Issue-ID: APPC-1462
Change-Id: Ie0de18d9c22c3913c5b57bc1f2de2e8758c26ed0
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agoAdded test case for Configuration class 49/78849/3
Lathishbabu Ganesan [Wed, 20 Feb 2019 15:16:29 +0000 (10:16 -0500)]
Added test case for Configuration class

Issue-ID: APPC-1449
Change-Id: I84bb511d121e3af1426d4422ad3ce520bb5fd29c
Signed-off-by: Lathishbabu Ganesan <lathishbabu.ganesan@ericsson.com>
5 years agoTest coverage in Mapper 38/78838/2
Joss Armstrong [Wed, 20 Feb 2019 13:47:46 +0000 (13:47 +0000)]
Test coverage in Mapper

Increased coverage to 98%

Issue-ID: APPC-1462
Change-Id: Ie6aa2dc885be4ede947c3f7856f93cf9f1efffa0
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agoTest coverage in LCM ProviderOperations 25/78825/2
Joss Armstrong [Wed, 20 Feb 2019 11:13:51 +0000 (11:13 +0000)]
Test coverage in LCM ProviderOperations

Added test cases

Issue-ID: APPC-1462
Change-Id: I577bcbb1f1ea36fdddbe30b115710588472bd45c
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agoRemoved prinstackTrace 27/78927/2
Jegadeesh Babu [Thu, 21 Feb 2019 13:57:41 +0000 (19:27 +0530)]
Removed prinstackTrace

Sonar fix

Issue-ID: APPC-1475
Change-Id: I0330868328589dded0db6afa7ae2fe75f0b6ada0
Signed-off-by: Jegadeesh Babu <jegabab1@in.ibm.com>
5 years agoTest coverage in OutgoingMessage 15/78815/3
Joss Armstrong [Wed, 20 Feb 2019 10:06:54 +0000 (10:06 +0000)]
Test coverage in OutgoingMessage

Increased coverage to 100%

Issue-ID: APPC-1462
Change-Id: I4b2646da01c20e9095c617d1f82c78fae30f2418
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agoHandled interrupted Exception 32/78832/2
Jegadeesh Babu [Wed, 20 Feb 2019 12:59:09 +0000 (18:29 +0530)]
Handled interrupted Exception

Sonar Bug Fix

Issue-ID: APPC-1469
Change-Id: I3f1fe6b620e8b01659e1b927b1f5fb667be20648
Signed-off-by: Jegadeesh Babu <jegabab1@in.ibm.com>
5 years agoSonar Fix : CoreManager.java 22/78822/2
Sudarshan Kumar [Wed, 20 Feb 2019 10:56:43 +0000 (16:26 +0530)]
Sonar Fix : CoreManager.java

Sonar Fix CoreManager.java - Removed printStackTrace

Issue-ID: APPC-1399
Change-Id: Id24936f8c41966e6f6c09348d762ba40487682da
Signed-off-by: Sudarshan Kumar <sudars19@in.ibm.com>
5 years agoSonar Fix : Time.java 17/78817/2
Sudarshan Kumar [Wed, 20 Feb 2019 10:36:07 +0000 (16:06 +0530)]
Sonar Fix : Time.java

Sonar Fix : Time.java - Removed printStackTrace

Issue-ID: APPC-1399
Change-Id: Icc39933cf656ffd79917596ce686f09b8c638843
Signed-off-by: Sudarshan Kumar <sudars19@in.ibm.com>
5 years agoAdded test case for Appc Provider client 50/78750/2
Lathishbabu Ganesan [Tue, 19 Feb 2019 12:29:58 +0000 (07:29 -0500)]
Added test case for Appc Provider client

Increased the coverage from 0% to 100%

Issue-ID: APPC-1455
Change-Id: I0e719bd084a985b63110f15681b6a87ec4affb4d
Signed-off-by: Lathishbabu Ganesan <lathishbabu.ganesan@ericsson.com>
5 years agoVulnerabilities Fix - XResponseProcessor.java 66/78366/5
Sudarshan Kumar [Wed, 13 Feb 2019 08:19:24 +0000 (13:49 +0530)]
Vulnerabilities Fix - XResponseProcessor.java

Removed printStacktrace and specified specific exception

Issue-ID: APPC-1399
Change-Id: I44c938cdd00a88ff76dfa36dbe49942f91546bb2
Signed-off-by: Sudarshan Kumar <sudars19@in.ibm.com>
5 years agoSonar Fix: Removed printStacktrace 45/78545/2
Sudarshan Kumar [Fri, 15 Feb 2019 10:18:06 +0000 (15:48 +0530)]
Sonar Fix: Removed printStacktrace

Sonar Fix: Removed printStacktrace

Issue-ID: APPC-1399
Change-Id: I0d33fac270a2082cc7b284c2df8e47fbf5b139a9
Signed-off-by: Sudarshan Kumar <sudars19@in.ibm.com>
5 years agoSonar Fixes - AAIResourceNode.java 95/78695/2
Driptaroop Das [Mon, 18 Feb 2019 18:21:42 +0000 (23:51 +0530)]
Sonar Fixes - AAIResourceNode.java

Sonar Fixes - AAIResourceNode.java

Issue-ID: APPC-1459
Change-Id: I19dd99bfc59feaf27b090440b6c1ff03d7fe16c0
Signed-off-by: Driptaroop Das <driptaroop.das@in.ibm.com>
5 years agoAdded test case for TestSshAdapterMock.java 40/78540/3
Sudarshan Kumar [Fri, 15 Feb 2019 08:16:22 +0000 (13:46 +0530)]
Added test case for TestSshAdapterMock.java

Added additional test case for TestSshAdapterMock.java

Issue-ID: APPC-1372
Change-Id: Ib2b6051cb8a47cc133b378d4fed6de326d37c4e5
Signed-off-by: Sudarshan Kumar <sudars19@in.ibm.com>
5 years agoTest coverage in EventHandlerImpl 67/78767/3
Joss Armstrong [Tue, 19 Feb 2019 16:34:23 +0000 (16:34 +0000)]
Test coverage in EventHandlerImpl

Added test cases for untested code

Issue-ID: APPC-1462
Change-Id: I492721a9c40678bb8700d30782cfa5949c1f22e9
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agoIncrease coverage in ControllerImpl 71/78771/1
Joss Armstrong [Tue, 19 Feb 2019 18:12:15 +0000 (18:12 +0000)]
Increase coverage in ControllerImpl

Coverage increased to 94%

Issue-ID: APPC-1462
Change-Id: I7e3af44d7627db7d09069c402e5aa47f518fd490
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agoCorrect line indent spacing 37/78637/2
Patrick Brady [Mon, 18 Feb 2019 09:39:30 +0000 (01:39 -0800)]
Correct line indent spacing

The indent spacing was incorrectly changed to 2 spaces
instead of 4 by https://gerrit.onap.org/r/#/c/78396/
The incorrect spacing change was causing merge conflicts
in another commit.

Change-Id: I6693b3bfaa5685318c8ada5d7984235c788b9504
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1420

5 years agoFix code error in ControllerImpl class 59/78759/2
Joss Armstrong [Tue, 19 Feb 2019 14:00:41 +0000 (14:00 +0000)]
Fix code error in ControllerImpl class

Put in correct check for null ListenerClass attribute

Issue-ID: APPC-1463
Change-Id: I55cd4327f4718c320e3feaf71db7ac23f59a0986
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agoTest coverage for CommonMessage 58/78758/2
Joss Armstrong [Tue, 19 Feb 2019 13:34:05 +0000 (13:34 +0000)]
Test coverage for CommonMessage

Increased coverage from 41% to 95%

Issue-ID: APPC-1462
Change-Id: I602a0178617f29ab34f7a4ab4400d6e5c442bd9d
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agoAdded test case for OutputMessage Plugin 63/78663/2
Lathishbabu Ganesan [Mon, 18 Feb 2019 14:07:19 +0000 (09:07 -0500)]
Added test case for OutputMessage Plugin

Increased the code coverage from 0% to 100%

Issue-ID: APPC-1431
Change-Id: Ic05b358428745698d0b4871b9c6213c9c8130c7c
Signed-off-by: Lathishbabu Ganesan <lathishbabu.ganesan@ericsson.com>
5 years agoTest coverage in design-services-provider 50/78650/5
Joss Armstrong [Mon, 18 Feb 2019 12:23:23 +0000 (12:23 +0000)]
Test coverage in design-services-provider

Add test cases to ArtifactHandlerClient

Issue-ID: APPC-1436
Change-Id: I0893526b6f3a532ec422b998bb9cc266850a52a7
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agoTest coverage for DesignServiceProvider 70/78670/2
Joss Armstrong [Mon, 18 Feb 2019 14:37:52 +0000 (14:37 +0000)]
Test coverage for DesignServiceProvider

Add 100% coverage for class

Issue-ID: APPC-1436
Change-Id: I7e20fa92e5d6b16f7b3c791538464575024fefc5
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agoAdded test case for License Data Access 76/78676/2
Lathishbabu Ganesan [Mon, 18 Feb 2019 14:59:16 +0000 (09:59 -0500)]
Added test case for License Data Access

Increased code coverage from 0% to 98%

Issue-ID: APPC-1450
Change-Id: I6fbf7ef905bac06ec5a8245eeb1bfb3d5b263b9f
Signed-off-by: Lathishbabu Ganesan <lathishbabu.ganesan@ericsson.com>
5 years agoTest coverage for SecureRestClientTM 83/78683/2
Joss Armstrong [Mon, 18 Feb 2019 16:04:36 +0000 (16:04 +0000)]
Test coverage for SecureRestClientTM

Added 100% coverage for class

Issue-ID: APPC-1436
Change-Id: I5522672d32720028744f03078287436eed8f2ce5
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agoAdded test case for DbService util 84/78684/2
Lathishbabu Ganesan [Mon, 18 Feb 2019 16:05:01 +0000 (11:05 -0500)]
Added test case for DbService util

Increased the coverage from 22% to 82%

Issue-ID: APPC-1448
Change-Id: I478367d6f5aac4a453b6d711a81c0ee5cefcdd36
Signed-off-by: Lathishbabu Ganesan <lathishbabu.ganesan@ericsson.com>
5 years agoAdded test case for RestActivator 42/78642/3
Lathishbabu Ganesan [Mon, 18 Feb 2019 11:25:52 +0000 (06:25 -0500)]
Added test case for RestActivator

Increased the coverage from 0% to 100%

Issue-ID: APPC-1428
Change-Id: Ic33666f14f4cefddf7b6216653229371607b4573
Signed-off-by: Lathishbabu Ganesan <lathishbabu.ganesan@ericsson.com>
5 years agoAdded test case for RestClient Invoker 50/78550/4
Lathishbabu Ganesan [Fri, 15 Feb 2019 11:45:00 +0000 (06:45 -0500)]
Added test case for RestClient Invoker

Increased the coverage from 0% to 92%

Issue-ID: APPC-1439
Change-Id: Icb1d51c3b62570e4f4294021b7ea92b325c085ee
Signed-off-by: Lathishbabu Ganesan <lathishbabu.ganesan@ericsson.com>
5 years agoAdded test case for Legacy Util class 52/78652/2
Lathishbabu Ganesan [Mon, 18 Feb 2019 12:42:57 +0000 (07:42 -0500)]
Added test case for Legacy Util class

Increased the test coverage from 0% to 97%

Issue-ID: APPC-1430
Change-Id: Id9045c3fc1c107e877a0e8bd7e977f6e271111ea
Signed-off-by: Lathishbabu Ganesan <lathishbabu.ganesan@ericsson.com>
5 years agoAdded test case for Flow Controller Activator 47/78647/2
Lathishbabu Ganesan [Mon, 18 Feb 2019 12:13:17 +0000 (07:13 -0500)]
Added test case for Flow Controller Activator

Increased the code coverage from 0% to 97%

Issue-ID: APPC-1429
Change-Id: Iada494daad7939b00c76fead73be864c6b40e045
Signed-off-by: Lathishbabu Ganesan <lathishbabu.ganesan@ericsson.com>
5 years agoAdded thread interrupt flag 61/78661/2
Jegadeesh Babu [Mon, 18 Feb 2019 13:51:27 +0000 (19:21 +0530)]
Added thread interrupt flag

Handled Interrupted exception

Issue-ID: APPC-1452
Change-Id: Ide8f4b37db52937932d08db7ce429a52b1bfe433
Signed-off-by: Jegadeesh Babu <jegabab1@in.ibm.com>
5 years agoJunit class TestSliAuditActivator.java added 70/78470/2
Sudarshan Kumar [Thu, 14 Feb 2019 11:15:24 +0000 (16:45 +0530)]
Junit class TestSliAuditActivator.java added

Junit class TestSliAuditActivator.java added

Issue-ID: APPC-1372
Change-Id: I9c34fdf596970be4554959f98c19534897792718
Signed-off-by: Sudarshan Kumar <sudars19@in.ibm.com>
5 years agoAdded Junit for RequestValidationException.Java 67/78467/2
Sudarshan Kumar [Thu, 14 Feb 2019 10:57:43 +0000 (16:27 +0530)]
Added Junit for RequestValidationException.Java

Added Junit for RequestValidationException.Java

Issue-ID: APPC-1372
Change-Id: Ie56b6ff0dc1a3c0fafbd954f658a08965b006519
Signed-off-by: Sudarshan Kumar <sudars19@in.ibm.com>
5 years agoSupport multiple Ansible servers 44/78444/4
Sonali Das [Wed, 13 Feb 2019 21:28:02 +0000 (16:28 -0500)]
Support multiple Ansible servers

Issue-ID: APPC-1364
Change-Id: I63cf89f5964bcfaba7d1f0b0eac2477f827b69fa
Signed-off-by: Sonali Das <sd394g@att.com>
Review Comment update

Issue-ID: APPC-1364
Change-Id: I03fa97d60c6497218c14b53531c2dea69c7fba34
Signed-off-by: Sonali Das <sd394g@att.com>
Review Comment update

Issue-ID: APPC-1364
Change-Id: I03fa97d60c6497218c14b53531c2dea69c7fba34
Signed-off-by: Sonali Das <sd394g@att.com>
Support multiple Ansible servers

Issue-ID: APPC-1364
Change-Id: I63cf89f5964bcfaba7d1f0b0eac2477f827b69fa
Signed-off-by: Sonali Das <sd394g@att.com>
Support multiple Ansible servers

Issue-ID: APPC-1364
Change-Id: I63cf89f5964bcfaba7d1f0b0eac2477f827b69fa
Signed-off-by: Sonali Das <sd394g@att.com>
5 years agoAdded fix for potential Multiplication overflow 99/78499/3
Jegadeesh Babu [Thu, 14 Feb 2019 14:23:57 +0000 (19:53 +0530)]
Added fix for potential Multiplication overflow

Sonar bug fix

Issue-ID: APPC-1438
Change-Id: I5d68c3b9659d8e538bd4a7a6a23aa77c293510f6
Signed-off-by: Jegadeesh Babu <jegabab1@in.ibm.com>
5 years agoAdded Test case for General Data Service 13/78513/3
Lathishbabu Ganesan [Thu, 14 Feb 2019 17:14:57 +0000 (12:14 -0500)]
Added Test case for General Data Service

Increased the coverage from 0% to 92%

Issue-ID: APPC-1427
Change-Id: I868993463f162da3ea81d9681db109afafb6c90c
Signed-off-by: Lathishbabu Ganesan <lathishbabu.ganesan@ericsson.com>
5 years agoAdded Junit for DBException.java 66/78466/3
Sudarshan Kumar [Thu, 14 Feb 2019 10:49:48 +0000 (16:19 +0530)]
Added Junit for DBException.java

Added Junit for DBException.java

Issue-ID: APPC-1372
Change-Id: Ie5637f33c6a2bc6f51d51f0f94fb780699b3880c
Signed-off-by: Sudarshan Kumar <sudars19@in.ibm.com>
5 years agoAdded test case for Config Generator 10/78510/2
Lathishbabu Ganesan [Thu, 14 Feb 2019 16:10:13 +0000 (11:10 -0500)]
Added test case for Config Generator

Increased the coverage from 0% to 97%

Issue-ID: APPC-1426
Change-Id: I667845ef9b36a85e5be51fd624028063b0f2ea77
Signed-off-by: Lathishbabu Ganesan <lathishbabu.ganesan@ericsson.com>
5 years agoAdded test cases for DME2 Client 63/77963/6
Lathishbabu Ganesan [Wed, 6 Feb 2019 15:38:14 +0000 (10:38 -0500)]
Added test cases for DME2 Client

Increased the coverage from 0% to 90%

Issue-ID: APPC-1395
Change-Id: I9651ab4326e500559e5bd9b99abdff84d93cfa1d
Signed-off-by: Lathishbabu Ganesan <lathishbabu.ganesan@ericsson.com>
5 years agoTest coverage in XInterfaceService 90/78490/4
Joss Armstrong [Thu, 14 Feb 2019 13:38:23 +0000 (13:38 +0000)]
Test coverage in XInterfaceService

Increased coverage from 68% to 100%

Issue-ID: APPC-1436
Change-Id: If9f1670ba9955325bf938d7edf3d7d67bb48088c
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agoTest coverage for XResponseProcessor 87/78487/3
Joss Armstrong [Thu, 14 Feb 2019 13:20:30 +0000 (13:20 +0000)]
Test coverage for XResponseProcessor

Increased coverage from 0% to 81%

Issue-ID: APPC-1436
Change-Id: I6b9805d2e048247759861ebcd65d74507c99aeb0
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agoCheck vm-capabilites on vnf-level OS requests 57/78257/4
Lori Keighron [Mon, 11 Feb 2019 22:21:37 +0000 (17:21 -0500)]
Check vm-capabilites on vnf-level OS requests

New per-vm capabilities checking is introduced for vnf-level OpenStack actions
Additional changes per initial review.
Additional changes in TestVnfc.java per second review.

Change-Id: Idd1d834df076c1e525f596b788b69ed63ba9e66b
Issue-ID: APPC-1380
Signed-off-by: Lori Keighron <lk2924@att.com>
5 years agoAdded test case for DgResolver Plugin 08/78508/2
Lathishbabu Ganesan [Thu, 14 Feb 2019 15:41:34 +0000 (10:41 -0500)]
Added test case for DgResolver Plugin

Increased the coverage from 0% to 94%

Issue-ID: APPC-1421
Change-Id: Ide813344cc2a00444bfd97fdeb9cbbe5a15eef08
Signed-off-by: Lathishbabu Ganesan <lathishbabu.ganesan@ericsson.com>
5 years agoAdded interrupt method to notify caller method 91/78491/6
Jegadeesh Babu [Thu, 14 Feb 2019 13:36:26 +0000 (19:06 +0530)]
Added interrupt method to notify caller method

Called interrupt method on current thread

Issue-ID: APPC-1437
Change-Id: I0dbb8cf01f285c01f96fe4f1c0396999e3361373
Signed-off-by: Jegadeesh Babu <jegabab1@in.ibm.com>
5 years agoTest coverage in ArtifactHandlerClient 82/78482/2
Joss Armstrong [Thu, 14 Feb 2019 12:59:20 +0000 (12:59 +0000)]
Test coverage in ArtifactHandlerClient

Added partial test coverage

Issue-ID: APPC-1436
Change-Id: Ic2520603b33f735cf1bd816544696c3fa29f0303
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agoTest coverage DmaapMessageAdapterFactoryImpl 75/78475/2
Joss Armstrong [Thu, 14 Feb 2019 12:05:54 +0000 (12:05 +0000)]
Test coverage DmaapMessageAdapterFactoryImpl

Increased coverage from 0% to 100%

Issue-ID: APPC-1422
Change-Id: I61e0af9d676749d2b36d7765de92ddc9b1df3396
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agoTest coverage DmaapMessageAdapterFactoryActivator 34/78334/4
Joss Armstrong [Tue, 12 Feb 2019 20:07:10 +0000 (20:07 +0000)]
Test coverage DmaapMessageAdapterFactoryActivator

Increased coverage from 0% to 100%

Issue-ID: APPC-1422
Change-Id: I246ddffe3d84682ddb37ca5e94abd0c7f5c7c312
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agoJunit for AppcAaiClientActivator 77/78177/5
Driptaroop Das [Sun, 10 Feb 2019 15:58:03 +0000 (21:28 +0530)]
Junit for AppcAaiClientActivator

Junit for AppcAaiClientActivator

Issue-ID: APPC-1410
Change-Id: I680a2790ed2d516a04f7fdbe138f4b88ec5ea91c
Signed-off-by: Driptaroop Das <driptaroop.das@in.ibm.com>
5 years agoCode block added to avoid Null pointer Exception 90/78390/4
Jegadeesh Babu [Wed, 13 Feb 2019 13:53:19 +0000 (19:23 +0530)]
Code block added to avoid Null pointer Exception

Added condition to avoid NullPointer Exception

Issue-ID: APPC-1425
Change-Id: I166633ccfcf51a8fcc8d4082aa8d2afa4b299398
Signed-off-by: Jegadeesh Babu <jegabab1@in.ibm.com>
5 years agoadded test case to TestAnsibleMessageParser.java 76/78376/4
Sandeep J [Wed, 13 Feb 2019 10:02:31 +0000 (15:32 +0530)]
added test case to TestAnsibleMessageParser.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: Ic0546d8cff108551d32bb7db71238e1c968d0bef
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded test cases to TestTenantCache.java 57/78457/2
Sandeep J [Thu, 14 Feb 2019 09:47:35 +0000 (15:17 +0530)]
added test cases to TestTenantCache.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: Ic7c8456b375426e831b3ba2f8e6148db9ba59d5f
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded test case to ProviderOperationFactoryTest 59/78459/2
Sandeep J [Thu, 14 Feb 2019 09:58:27 +0000 (15:28 +0530)]
added test case to ProviderOperationFactoryTest

to increase code coverage

Issue-ID: APPC-1086
Change-Id: Ic6f8fcebd31b111fdfc194e55bc74f8d8ac6f1fa
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoAdded test case for DesignServiceImpl Class 96/78396/3
Lathishbabu Ganesan [Wed, 13 Feb 2019 15:05:13 +0000 (10:05 -0500)]
Added test case for DesignServiceImpl Class

Increased the coverage from 0% to 97.5%

Issue-ID: APPC-1420
Change-Id: Iea12e07e91f6d84645dbbc060518c26c1695fd40
Signed-off-by: Lathishbabu Ganesan <lathishbabu.ganesan@ericsson.com>
5 years agoJunit for ArtifactHandlerInternalException 80/78180/3
Driptaroop Das [Sun, 10 Feb 2019 16:17:57 +0000 (21:47 +0530)]
Junit for ArtifactHandlerInternalException

Junit for ArtifactHandlerInternalException

Issue-ID: APPC-1412
Change-Id: Ib37177052fea56a31ed486772f0204931e2c9a34
Signed-off-by: Driptaroop Das <driptaroop.das@in.ibm.com>
5 years agoadded test case to TestRestartServer.java 62/78462/2
Sandeep J [Thu, 14 Feb 2019 10:26:16 +0000 (15:56 +0530)]
added test case to TestRestartServer.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: Id4297a81cc09b9df9ba5a6c15c0921f68c025864
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoJunit for AppcDataServiceActivator 79/78179/5
Driptaroop Das [Sun, 10 Feb 2019 16:04:31 +0000 (21:34 +0530)]
Junit for AppcDataServiceActivator

Junit for AppcDataServiceActivator

Issue-ID: APPC-1411
Change-Id: Iddccff7afd8960d82e2dec8217d385810a4b80c3
Signed-off-by: Driptaroop Das <driptaroop.das@in.ibm.com>
5 years agoadded test file to cover AnsibleResult.java 79/78379/2
Sandeep J [Wed, 13 Feb 2019 10:13:27 +0000 (15:43 +0530)]
added test file to cover AnsibleResult.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: I4c148c9b74177ebc455652ff37edba184e279b1c
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agomodified existing test case to increase coverage 72/78372/3
Sandeep J [Wed, 13 Feb 2019 09:27:55 +0000 (14:57 +0530)]
modified existing test case to increase coverage

changing constructor argument from 0 to 1 increases code coverage

Issue-ID: APPC-1086
Change-Id: Ic5f2d61bd96ef862c0b20d91c7b9af3f7ca1a081
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoAdded test case for Flow control Node 09/78309/4
Lathishbabu Ganesan [Tue, 12 Feb 2019 15:27:31 +0000 (10:27 -0500)]
Added test case for Flow control Node

Increased the test coverage from 0% to 77%

Issue-ID: APPC-1414
Change-Id: Ib65618e67af478bf577b103a27ebf0aa34f8bec3
Signed-off-by: Lathishbabu Ganesan <lathishbabu.ganesan@ericsson.com>
5 years agoReplaced prinstacktrace with logger 88/78388/2
Jegadeesh Babu [Wed, 13 Feb 2019 12:38:08 +0000 (18:08 +0530)]
Replaced prinstacktrace with logger

Replaced printStackTrace with logger

Issue-ID: APPC-1424
Change-Id: I582b497fe3f483ec14abf6b61f488204c02238b8
Signed-off-by: Jegadeesh Babu <jegabab1@in.ibm.com>
5 years agoFix broken unit test in DmaapProducerImpl 82/78382/1
Joss Armstrong [Wed, 13 Feb 2019 10:25:19 +0000 (10:25 +0000)]
Fix broken unit test in DmaapProducerImpl

Puts tests back to prior to commit Ie4817c5bdf514d4fe7f68b73812bbc2383c8cbbe
Issue-ID: APPC-1423
Change-Id: I2165c9a2ce83db1f9d185f083d41d6e5d7bce269
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agoTest Coverage in DmaapConsumerImpl 05/78305/3
Joss Armstrong [Tue, 12 Feb 2019 15:21:50 +0000 (15:21 +0000)]
Test Coverage in DmaapConsumerImpl

Increased coverage

Issue-ID: APPC-1415
Change-Id: I29e2d0883914aeec652a47436c86c6ea8e5ab7a5
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agoTest coverage in DmaapProducerImpl 17/78317/3
Joss Armstrong [Tue, 12 Feb 2019 17:33:13 +0000 (17:33 +0000)]
Test coverage in DmaapProducerImpl

Increased coverage to 80%

Issue-ID: APPC-1415
Change-Id: Ie4817c5bdf514d4fe7f68b73812bbc2383c8cbbe
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agoAdded unit test case for ProviderOperations 38/78238/5
Lathishbabu Ganesan [Mon, 11 Feb 2019 17:23:45 +0000 (12:23 -0500)]
Added unit test case for ProviderOperations

Increased the coverage from 0% to 86%

Issue-ID: APPC-1404
Change-Id: Ic9fdfe59c4dc60e57bdca1a501ac99a9207eb539
Signed-off-by: Lathishbabu Ganesan <lathishbabu.ganesan@ericsson.com>
5 years agoTest coverage in ServiceCatalogV3 83/78283/2
Joss Armstrong [Tue, 12 Feb 2019 11:04:19 +0000 (11:04 +0000)]
Test coverage in ServiceCatalogV3

Increased coverage from 44% to 94%

Issue-ID: APPC-1418
Change-Id: I0e534a5bc20caaae25b28902caa58f0c5d950c31
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agoTest coverage in ServiceCatalogv2 80/78280/3
Joss Armstrong [Tue, 12 Feb 2019 10:36:25 +0000 (10:36 +0000)]
Test coverage in ServiceCatalogv2

Increased coverage from 57% to 91%

Issue-ID: APPC-1418
Change-Id: I0f2b77bdb451d973d631f4c785b65de3bb84f02f
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agoAdded test coverage for GraphExecutor 91/78291/2
Joss Armstrong [Tue, 12 Feb 2019 13:23:00 +0000 (13:23 +0000)]
Added test coverage for GraphExecutor

Increased coverage to 97%

Issue-ID: APPC-1419
Change-Id: I3d505d53a95f4f8605041b21bf6c868b8652d7a5
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agoTest coverage in SshdDataAccessService 72/78272/1
Joss Armstrong [Tue, 12 Feb 2019 08:38:12 +0000 (08:38 +0000)]
Test coverage in SshdDataAccessService

Increase coverage from 45% to 93%

Issue-ID: APPC-1416
Change-Id: Icd9560f279b6dcd3986fcf28b16796a68b2ccb4f
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agoRemoved PrintStackTrace SshJcraftWrapper.java 04/78204/2
Sudarshan Kumar [Mon, 11 Feb 2019 12:19:55 +0000 (17:49 +0530)]
Removed PrintStackTrace SshJcraftWrapper.java

Removed PrintStackTrace SshJcraftWrapper.java

Issue-ID: APPC-1399
Change-Id: Ice16de4fd8d997643d4dea73a4ebacc75f2b2d49
Signed-off-by: Sudarshan Kumar <sudars19@in.ibm.com>
5 years agoAdded Junit Class for SnapshotDetails.java 96/78196/3
Sudarshan Kumar [Mon, 11 Feb 2019 09:59:42 +0000 (15:29 +0530)]
Added Junit Class for SnapshotDetails.java

Added Junit Class for SnapshotDetails.java

Issue-ID: APPC-1372
Change-Id: I97b15554ca81c39728f2cf4e963ec8ec4848001f
Signed-off-by: Sudarshan Kumar <sudars19@in.ibm.com>
5 years agoTest coverage in ssh adapter 42/78242/2
Joss Armstrong [Mon, 11 Feb 2019 18:31:34 +0000 (18:31 +0000)]
Test coverage in ssh adapter

Increased coverage of sshadaptersshd and sshconnection classes

Issue-ID: APPC-1416
Change-Id: I706f942f87d4497f35b2584c1360d571b43eba6c
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agoTest coverage in EventSenderDmaapImpl 22/78222/3
Joss Armstrong [Mon, 11 Feb 2019 14:55:10 +0000 (14:55 +0000)]
Test coverage in EventSenderDmaapImpl

Coverage increased from 10% to 92%

Issue-ID: APPC-1415
Change-Id: I846a24364bda29e754fa53ed518de92bf00693e6
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agoTest coverage in EncryptionToolDGWrapper 97/78197/3
Joss Armstrong [Mon, 11 Feb 2019 10:32:06 +0000 (10:32 +0000)]
Test coverage in EncryptionToolDGWrapper

Increased coverage from 28% to 100%

Issue-ID: APPC-1409
Change-Id: I8e91c3cd58feaa795be86233147553ad137b8f4e
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agoTest coverage for ParseAdminArtifact 09/78209/2
Joss Armstrong [Mon, 11 Feb 2019 12:59:49 +0000 (12:59 +0000)]
Test coverage for ParseAdminArtifact

Increased coverage from 65% to 85%

Issue-ID: APPC-1409
Change-Id: If39c07b3edbcaad6d618e54b27483323848410fe
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agoTest coverage in wrapperEncryptionTool 02/78202/2
Joss Armstrong [Mon, 11 Feb 2019 11:37:11 +0000 (11:37 +0000)]
Test coverage in wrapperEncryptionTool

Increased coverage from 0% to 81%

Issue-ID: APPC-1409
Change-Id: I1b4d285eff9fad8a60e855a97ff843078d628862
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agoTest coverage in encryptiontool package 24/78124/4
Joss Armstrong [Fri, 8 Feb 2019 16:29:32 +0000 (16:29 +0000)]
Test coverage in encryptiontool package

Increased coverage to 100%

Issue-ID: APPC-1409
Change-Id: Iff09cf04cbdb1cb4f7ad640102f8885a571f5ae0
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agoAdd junit coverage to MetadataCacheFactory class 86/78086/3
Zihmin Hoover [Thu, 7 Feb 2019 21:05:51 +0000 (16:05 -0500)]
Add junit coverage to MetadataCacheFactory class

Add more test runs to MetadataCacheFactoryTest class

Change-Id: I52871dfb876be91bd4600390af3bfee9d356e121
Issue-ID: APPC-1047
Signed-off-by: Zihmin Hoover <zh4590@att.com>
5 years agoTest coverage in workflow-impl 22/78122/2
Joss Armstrong [Fri, 8 Feb 2019 15:38:18 +0000 (15:38 +0000)]
Test coverage in workflow-impl

Increased package coverage to 83%

Issue-ID: APPC-1408
Change-Id: I24b634ee7926bac2a196256cd20362d2f7b93b76
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agoChanges to config bundle for vnf level enhancement 71/78071/5
George, Lina (lg941u) [Thu, 7 Feb 2019 16:33:37 +0000 (11:33 -0500)]
Changes to config bundle for vnf level enhancement

Issue-ID: APPC-1380
Change-Id: Icfdc202a4763b7e708007573505e5b3be9d1454e
Signed-off-by: George, Lina (lg941u) <lg941u@att.com>
5 years agoAdded Junit Class for CallableConsumer.java 03/78103/4
Sudarshan Kumar [Fri, 8 Feb 2019 09:30:34 +0000 (15:00 +0530)]
Added Junit Class for CallableConsumer.java

Added Junit Class for CallableConsumer.java

Issue-ID: APPC-1372
Change-Id: I3bdf3b66cf3c54835a9bf74076c47767ed03c1b0
Signed-off-by: Sudarshan Kumar <sudars19@in.ibm.com>
5 years agoansible adapter changes for multiple ansible servs 17/77617/5
Modaboina, Kusumakumari (km583p) [Thu, 31 Jan 2019 01:23:22 +0000 (20:23 -0500)]
ansible adapter changes for multiple ansible servs

Issue-ID: APPC-1365
Change-Id: Ie3d102d9efcef7ba98b1fb5920a73a6c64b01897
Signed-off-by: Modaboina, Kusumakumari (km583p) <km583p@us.att.com>
5 years agoTest coverage in transaction-recorder 01/78101/2
Joss Armstrong [Fri, 8 Feb 2019 08:38:45 +0000 (08:38 +0000)]
Test coverage in transaction-recorder

Increased coverage from 64% to 96%

Issue-ID: APPC-1403
Change-Id: Idbb94d5e8933ac65bfc68cec6996c5ac039e8748
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agoIncrease coverage in workflow.activator package 19/78119/2
Joss Armstrong [Fri, 8 Feb 2019 14:37:40 +0000 (14:37 +0000)]
Increase coverage in workflow.activator package

From 32% to 85%

Issue-ID: APPC-1408
Change-Id: I52447e5df9fd3a6ebdb257dbba9a83013bad6f05
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agoJunit Class Added for AuthenticationException.java 02/78102/2
Sudarshan Kumar [Fri, 8 Feb 2019 08:46:47 +0000 (14:16 +0530)]
Junit Class Added for AuthenticationException.java

Junit Class Added for AuthenticationException.java

Issue-ID: APPC-1372
Change-Id: If8473d5eef4cabb52f72c1debe84c22b99998aa5
Signed-off-by: Sudarshan Kumar <sudars19@in.ibm.com>
5 years agoAdded unit test cases for Worker class 57/78057/2
Lathishbabu Ganesan [Thu, 7 Feb 2019 13:34:20 +0000 (08:34 -0500)]
Added unit test cases for Worker class

Increased coverage from 0% to 100%

Issue-ID: APPC-1402
Change-Id: I2a0a05a29cce79004581f21fd56138485b631f78
Signed-off-by: Lathishbabu Ganesan <lathishbabu.ganesan@ericsson.com>