appc.git
6 years agoFix sonar block in Encryption Tool 23/10923/2
Skip Wonnell [Thu, 7 Sep 2017 19:42:29 +0000 (14:42 -0500)]
Fix sonar block in Encryption Tool

Fix blockers and other Sonar findings.
Update license text

Issue-ID: APPC-186
Change-Id: Ib45020d85bde95f79b112ebd85fedfe62469b58f
Signed-off-by: Skip Wonnell <skip@att.com>
6 years agoFix dblib DBResourceManager instantiation 27/10927/1
Marcus G K Williams [Thu, 7 Sep 2017 20:26:31 +0000 (13:26 -0700)]
Fix dblib DBResourceManager instantiation

Fix APPC Build, failing upstream and locally due to
change in CCSDK that changes dblib to use service
injection via Aries Blueprint. The change causing
this in CCSDK is https://gerrit.onap.org/r/#/c/7931/

Issue-Id: APPC-196
Change-Id: I9bcfb6d87b7527fd07cb76a242b272a5bc0ad07c
Signed-off-by: Marcus G K Williams <marcus.williams@intel.com>
6 years agoChange to CCSDK and ODL Carbon 81/10281/11
Patrick Brady [Tue, 5 Sep 2017 04:37:25 +0000 (21:37 -0700)]
Change to CCSDK and ODL Carbon

Change-Id: I49a0f436e366ff4a1b99705fb6bb5e7ba82e6ecc
Signed-off-by: Patrick Brady <pb071s@att.com>
Issue-Id: [APPC-91]
Issue-Id: [APPC-158]

6 years agoCode clean-up in ChefAdapterImpl.java 49/10049/1
Skip Wonnell [Sat, 2 Sep 2017 02:11:16 +0000 (21:11 -0500)]
Code clean-up in ChefAdapterImpl.java

Fix multiple issues found in Sonar Analysis

Issue-ID: APPC-156
Change-Id: I242c45a2eab7c4e31fb42ff9d17405aa3f210147
Signed-off-by: Skip Wonnell <skip@att.com>
6 years agoJunit Changes for APPC Params Bundle 97/9997/2
Chaturvedi, Anand (ac204h) [Fri, 1 Sep 2017 21:00:25 +0000 (17:00 -0400)]
Junit Changes for APPC Params Bundle

Issue-ID: APPC-168
Change-Id: Ie0ddf5905f90a409db111a1cfdf728a44737a158
Signed-off-by: Chaturvedi, Anand (ac204h) <ac204h@att.com>
6 years ago[JunitCases]for config audit and config generator. 53/9953/2
Chaturvedi, Anand (ac204h) [Thu, 31 Aug 2017 23:07:53 +0000 (19:07 -0400)]
[JunitCases]for config audit and config generator.

Change-Id: I7fc00ce3c8efab282954aab87db0b23da336d732
Issue-ID: APPC-189
Signed-off-by: Chaturvedi, Anand (ac204h) <ac204h@att.com>
6 years agoJunit Cases for Application Controller. 77/9977/2
Chaturvedi, Anand (ac204h) [Fri, 1 Sep 2017 19:35:26 +0000 (15:35 -0400)]
Junit Cases for Application Controller.

Issue-ID: APPC-168
Change-Id: Iacfc853bef0b641599c60055ac05b1fd090ee3f8
Signed-off-by: Chaturvedi, Anand (ac204h) <ac204h@att.com>
6 years ago[JunitCases]for config audit and config generator. 73/9773/2
Chaturvedi, Anand (ac204h) [Thu, 31 Aug 2017 23:07:53 +0000 (19:07 -0400)]
[JunitCases]for config audit and config generator.

Issue-ID: APPC-168
Change-Id: Ie6f5e13b63f3162530d71c60cf352a8bfcddf4ff
Signed-off-by: Chaturvedi, Anand (ac204h) <ac204h@att.com>
6 years agoFix classNotFound issue when executing dg-loader 23/9923/1
Hao Kuang [Fri, 1 Sep 2017 14:11:57 +0000 (14:11 +0000)]
Fix classNotFound issue when executing dg-loader

Change slf4j from transitive dependency to explicit dependency.

Issue-Id: APPC-188
Change-Id: I8054b5c4e0c0023be1fd6ae7a7e89799682f20fd
Signed-off-by: Hao Kuang <Hao.Kuang@amdocs.com>
6 years agoModify IaaS adapter URL parsing to include path 25/9525/7
RY303T [Wed, 30 Aug 2017 20:12:42 +0000 (16:12 -0400)]
Modify IaaS adapter URL parsing to include path

Modified the pattern in IdentityURL and VMURL to include optional path
Modified the toString in IdentityURL and VMURL to properly print the
full url string
Updated tests to include new URL format

Issue-ID: APPC-133
Change-Id: Ic7c272b70d4fe18c815d5dd5311f760d8b8953c1
Signed-off-by: RY303T <RY303T@att.com>
6 years agoUpdate ASDC References to SDC 1/2 09/9109/5
mojahidi [Tue, 29 Aug 2017 12:50:26 +0000 (18:20 +0530)]
Update ASDC References to SDC 1/2

This patch changes ASDC to SDC in APPC code, bundle
names and other pertinent places. This change
sanitizes SDC for Open Source. It
is the first in a two part change, the first
updates code mentions and artifacts. The second will
update database references.

Change-Id: Iffd73480cc325172b5d8969fe839728f1c88ef78
Issue-ID:APPC-179
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
6 years agoFix sonar blocker in ChefAdpater 95/9695/2
Skip Wonnell [Thu, 31 Aug 2017 14:27:46 +0000 (09:27 -0500)]
Fix sonar blocker in ChefAdpater

Issue-ID: APPC-156
Change-Id: Ic2cbb76bb639094386c14bd06e068c9d5ad7bd0d
Signed-off-by: Skip Wonnell <skip@att.com>
6 years agoAdd appc directory and index 09/9509/1
Scott Seabolt [Wed, 30 Aug 2017 18:15:26 +0000 (14:15 -0400)]
Add appc directory and index

Adding docs index directory

Issue-ID: [APPC-102]
Signed-off-by: Scott Seabolt <js9808@att.com>
Change-Id: I4882dc6ae042010edf6c999fc1ceb415c350beb0

6 years agoremoved att reference from pom file 57/9057/4
Kalpesh Chaniyara [Tue, 29 Aug 2017 08:38:52 +0000 (04:38 -0400)]
removed att reference from pom file

Removed att reference from the feature
repository in pom file

Issue-Id : APPC-177

Change-Id: Id2f7df836e3a0bd1204bdb93b72e9ac76d38fbba
Signed-off-by: Kalpesh Chaniyara <kalpeshkumar.chaniyara@amdocs.com>
6 years agoRemove catch throwable and error 37/9237/3
beili.zhou [Tue, 29 Aug 2017 22:33:57 +0000 (18:33 -0400)]
Remove catch throwable and error

Fix the following sonar blocker issue:
 - Catch Exception instead of Throwable
 - Catch Exception instead of Error

Issue-Id: APPC-175
Change-Id: I16a1018001b067216740ec11e5a97e52d714db69
Signed-off-by: beili.zhou <beili.zhou@amdocs.com>
6 years ago Increase unit test coverage of appc-metric module 59/9059/4
Abhai Singh [Tue, 29 Aug 2017 09:14:41 +0000 (14:44 +0530)]
 Increase unit test coverage of appc-metric module

Updated test class TestMetricServiceImpl with unit test cases

Change-Id: I4290f426259b837ad4db63efd8d64ba9989843cd
Issue-ID:APPC-176
Signed-off-by: Abhai Singh <Abhai.Singh@amdocs.com>
6 years agoAdded domain model package as bundle dependency 15/8915/4
Kalpesh Chaniyara [Mon, 28 Aug 2017 11:40:55 +0000 (17:10 +0530)]
Added domain model package as bundle dependency

Added org.openecomp.appc.domainmodel.lcm package
as the dependency for bundle appc-provider-bundle

Change-Id: I9130c36204dd595dceb5e04689014f40774b4f2c
Issue-Id:APPC-169
Signed-off-by: Kalpesh Chaniyara <kalpeshkumar.chaniyara@amdocs.com>
6 years agoInitial add of APPC client libraries 91/9291/3
Skip Wonnell [Wed, 30 Aug 2017 03:39:17 +0000 (22:39 -0500)]
Initial add of APPC client libraries

Issue-ID: APPC-180
Change-Id: Ie0be2b518b90bb7f9996e9260c43fef75d1a5821
Signed-off-by: Skip Wonnell <kw5258@att.com>
6 years agoChefAdapter code clean-up 95/9195/2
Skip Wonnell [Tue, 29 Aug 2017 19:16:20 +0000 (14:16 -0500)]
ChefAdapter code clean-up

Issue-ID: APPC-90
Change-Id: I582d6b0c81d5a89938fff6038dfcc221ccaf19c1
Signed-off-by: Skip Wonnell <kw5258@att.com>
6 years agoTruncate Service_Description field 33/9333/2
Abhai Singh [Wed, 30 Aug 2017 07:42:53 +0000 (13:12 +0530)]
Truncate Service_Description field

Updated ArtifactStorageService to truncate if length exceeds 255

Change-Id: If456802c3370553d9ed3a8942ff16b407f896ed2
Issue-ID:APPC-184
Signed-off-by: Abhai Singh <Abhai.Singh@amdocs.com>
6 years agoRemove duplicate code 33/9233/1
beili.zhou [Tue, 29 Aug 2017 22:06:38 +0000 (18:06 -0400)]
Remove duplicate code

Create a method for duplicated code to reduce code duplication in IAAS
adapter provider operation.

Issue-Id: APPC-175
Change-Id: Idfbfc7ffad433d0e7469b214e5b09d0dfd5dd7d2
Signed-off-by: beili.zhou <beili.zhou@amdocs.com>
6 years agoFix local build failure 09/9209/2
beili.zhou [Tue, 29 Aug 2017 20:26:56 +0000 (16:26 -0400)]
Fix local build failure

Fix local build is failing in appc-network-inventory-client-provider due to
missing dependency definition for PowerMockito.

Issue-Id: APPC-175
Change-Id: I47695277d6d635707cfd23246951ae22f02698f2
Signed-off-by: beili.zhou <beili.zhou@amdocs.com>
6 years agoRestAdapter code clean-up 97/8997/3
Skip Wonnell [Tue, 29 Aug 2017 01:59:46 +0000 (20:59 -0500)]
RestAdapter code clean-up

Issue-ID: APPC-90
Change-Id: I34b07327c82fb080d94d0fa6c70ae5cdfd8c5eb0
Signed-off-by: Skip Wonnell <kw5258@att.com>
6 years agoClean up directed graph java code 23/9023/1
Skip Wonnell [Tue, 29 Aug 2017 03:02:54 +0000 (22:02 -0500)]
Clean up directed graph java code

Issue-ID: APPC-90
Change-Id: I3ea4912523eed1fed85aa2e5909ec897bb13b72b
Signed-off-by: Skip Wonnell <kw5258@att.com>
6 years agoFix that APP-C LCM Command Running After OAM Stop 11/8811/3
Hao Kuang [Fri, 25 Aug 2017 16:15:26 +0000 (16:15 +0000)]
Fix that APP-C LCM Command Running After OAM Stop

The fix code does that waiting for threads in the queue completely
interrupted than let bundle:stop() method return.

Issue-Id: APPC-162
Change-Id: I8b34fc48fd2ae5ae1ad67d11ee3ad5f349171b47
Signed-off-by: Hao Kuang <Hao.Kuang@amdocs.com>
6 years agoJunit for APPC for Network Client 39/8839/3
Anand Chaturvedi [Fri, 25 Aug 2017 23:17:38 +0000 (19:17 -0400)]
Junit for APPC  for Network Client

Issue-ID: APPC-168
Change-Id: I0654a0d6123b5827458cd3e15e12a1b5b254f918
Signed-off-by: Anand Chaturvedi <ac204h@att.com>
6 years agoJunit Cases for APPC dataServices 35/8835/2
Anand Chaturvedi [Fri, 25 Aug 2017 20:15:07 +0000 (16:15 -0400)]
Junit Cases for APPC dataServices

Issue-ID: APPC-168
Change-Id: Ia5ae825f1c7919d93afb460cde7ae0fa2bcd0c6c
Author: Anand Chaturvedi <ac204h@att.com>
Date:   Fri Aug 25 15:41:42 2017 -0400
Signed-off-by: Anand Chaturvedi <ac204h@att.com>
6 years agoEnhance ASDC listener bundler start and stop 27/8827/3
beili.zhou [Fri, 25 Aug 2017 18:11:11 +0000 (14:11 -0400)]
Enhance ASDC listener bundler start and stop

Store ASDC listner start up initialization thread, to provide reference
for ASDC listener stop to terminate the thread if it is still running at
stopping time.
Add thread interrupt checking in initialization thread, to allow earlier
termination of the thread during stopping process.

Issue-Id: APPC-166
Change-Id: Ibc13afce251ce9344a4ad807d3927fc277bcbe6c
Signed-off-by: beili.zhou <beili.zhou@amdocs.com>
6 years agoAdded New Junit Cases for APPC Design Services 19/8819/1
Anand Chaturvedi [Thu, 24 Aug 2017 04:10:17 +0000 (00:10 -0400)]
Added New Junit Cases for APPC Design Services

Change-Id: Icc55aaadc1df1b8c368afaeb092a6c64a71202b7
Issue-ID: APPC-168
Signed-off-by: Anand Chaturvedi <ac204h@att.com>
6 years agoAdded New Junit Cases for APPC Design Services 65/8565/1
Anand Chaturvedi [Thu, 24 Aug 2017 04:10:17 +0000 (00:10 -0400)]
Added New Junit Cases for APPC Design Services

Issue-ID: APPC-168
Change-Id: Ib321bb77af3cb47abfce80d96f50a6b75b34b34e
Signed-off-by: Anand Chaturvedi <ac204h@att.com>
6 years agoRemove license plugin and files 99/8499/2
Skip Wonnell [Wed, 23 Aug 2017 20:32:22 +0000 (15:32 -0500)]
Remove license plugin and files

Change-Id: I5b7a1bf89bdecf480aa6e2defed497915c77e643
Issue-ID: APPC-96
Signed-off-by: Skip Wonnell <kw5258@att.com>
6 years agoAdd testing dependencies to dgraph pom 15/8315/4
Skip Wonnell [Tue, 22 Aug 2017 18:27:43 +0000 (13:27 -0500)]
Add testing dependencies to dgraph pom

Insert missing junit, mockito, and powermock dependencies in pom.

Change-Id: I74d19f9ec49edddf6f7c3a1608ee69dd698850a1
Issue-ID: APPC-165
Signed-off-by: Skip Wonnell <kw5258@att.com>
6 years agoFix appc-command-exectuor bundle fails to start 17/8317/2
Hao Kuang [Tue, 22 Aug 2017 19:13:01 +0000 (19:13 +0000)]
Fix appc-command-exectuor bundle fails to start

Fix that appc-command-executor-core bundle fails to load in karaf

Issue-Id: APPC-163
Change-Id: Ib3099a34e60ca59e7790ffe04f8a02869d995559
Signed-off-by: Hao Kuang <Hao.Kuang@amdocs.com>
6 years agoRename action Block/UnBlock and Update Orch 65/7565/16
mojahidi [Mon, 14 Aug 2017 07:20:45 +0000 (12:50 +0530)]
Rename action Block/UnBlock and Update Orch

StopApplication : Renamed block traffic action to StopApplication.
Transition of status in AAI will  be stopping on accepting request
followed by Stopped for Success and Error for error scenario’s
StartApplicaiton: Renamed  unblock traffic action to StartApplication.
Transition of status in AAI will be starting on accepting request
followed by Running for Success and Error for error scenario’s.
Refactored to handle actions on basis of ReadOnly,OrchestrationStatus,
BuiltIn and OperationalStatus instead of individual actions.

Change-Id: Ia7c6b233ac9a0aabeb9a1f7d715629917f6b7b86
Issue-ID:APPC-55
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
6 years agoUpdate license configuration to exclude Json files 97/8097/1
Skip Wonnell [Sat, 19 Aug 2017 21:07:45 +0000 (16:07 -0500)]
Update license configuration to exclude Json files

Fix the wildcard in the exclusion of files
during the process-sources phase.

Change-Id: If4b579ddd288655236e6d5cee14309a9d66acced
Issue-ID: APPC-161
Signed-off-by: Skip Wonnell <kw5258@att.com>
6 years agoSet sonar plugin version to 3.2 47/8047/2
Marcus G K Williams [Fri, 18 Aug 2017 22:03:51 +0000 (15:03 -0700)]
Set sonar plugin version to 3.2

Sonar plugin errors when using
newest version of plugin specificied
by oparent pom.xml.

Issue-Id: APPC-156
Change-Id: Iad830be0fc8ecac6bb1a515512f5c32a6f899996
Signed-off-by: Marcus G K Williams <marcus.williams@intel.com>
6 years agoFix ExecutionQueue cannot be cleaned 23/8023/5
Hao Kuang [Fri, 18 Aug 2017 16:07:56 +0000 (16:07 +0000)]
Fix ExecutionQueue cannot be cleaned

Fix that LCM Requests in Execution Queue continue after Stop OAM
request sent.
Fix that Appc-Ansible bundle cannot be fully stopped because
of NPE.

Issue-Id: APPC-159
Change-Id: I8f0a3a79a5c572ad84e66f71b4ddb47118704302
Signed-off-by: Hao Kuang <Hao.Kuang@amdocs.com>
6 years agoInitial commit for Sequence Generator 27/7627/9
Kalpesh Chaniyara [Tue, 15 Aug 2017 18:10:34 +0000 (23:40 +0530)]
Initial commit for Sequence Generator

Added sequence generator for start and stop
action with dependency model
Removed java check style from json files
from license maven plugin
JIRA Issues : APPC-33,APPC-106

Issue-Id : APPC-106
Change-Id: I7f12d39b705d77d559790a10b914b8108f5faa5e
Signed-off-by: Kalpesh Chaniyara <kalpeshkumar.chaniyara@amdocs.com>
6 years agoFix sonar blocker in DefaultConfiguration 99/7899/3
Skip Wonnell [Thu, 17 Aug 2017 16:53:24 +0000 (11:53 -0500)]
Fix sonar blocker in DefaultConfiguration

Update the equals() method with checks for
null and for class equality.

Issue-ID:  APPC-156
Change-Id: I7ee2ded5d18be560ee1d7bc63b936f22602ca0b4
Signed-off-by: Skip Wonnell <kw5258@att.com>
6 years agoInitial add of appc-directed-graph bundles 81/7681/2
Skip Wonnell [Wed, 16 Aug 2017 02:18:04 +0000 (21:18 -0500)]
Initial add of appc-directed-graph bundles

Directed Graph library

Additional JIRA Issues:  APPC-66, APPC-71, APPC-74

Issue-ID: APPC-65
Change-Id: I1bd643f7675dec19e562e99db65bafa0dcda6ef4
Signed-off-by: Skip Wonnell <kw5258@att.com>
6 years agoInitial adds artifact handler and design services 17/7517/4
Skip Wonnell [Mon, 14 Aug 2017 22:47:10 +0000 (17:47 -0500)]
Initial adds artifact handler and design services

asdc-artifact-handler: an interface to receive artifacts distributed
by SDC and persist them into the local database.

appc-design-services: an interface to manage VNF configuration
artifacts, primarily those generated by the configuration design tool.

Includes these user stories: APPC-28/85

Change-Id: Ib207070d4593554fa424fc69d9c77a6cd5349fec
Signed-off-by: Skip Wonnell <kw5258@att.com>
Issue-Id: APPC-9

6 years agoInitial commit for appc-config-audit bundle 75/7975/1
Skip Wonnell [Wed, 16 Aug 2017 00:57:50 +0000 (19:57 -0500)]
Initial commit for appc-config-audit bundle

This Bundle is used for Auditing against
a running configurition

Signed-off-by: Skip Wonnell <kw5258@att.com>
Issue-Id: APPC-22
Signed-off-by: Patrick Brady <pb071s@att.com>
Change-Id: Id19c65e351cc377d32d6533d3fa73415019652f0

6 years agoInitial commit for appc-config-adaptor 77/7677/5
Skip Wonnell [Wed, 16 Aug 2017 01:42:44 +0000 (20:42 -0500)]
Initial commit for appc-config-adaptor

This bundle contains utilities used by config-generator.

Change-Id: I04877ebe90536fd57368d00c033189c280e77c90
Signed-off-by: Skip Wonnell <kw5258@att.com>
Issue-ID: APPC-67

6 years agoInitial commit for config-generator bundle 67/7667/12
Skip Wonnell [Tue, 15 Aug 2017 23:07:13 +0000 (18:07 -0500)]
Initial commit for config-generator bundle

This bundle contains logic for creating the configuration,
reading templates, and merging the data together

Issue-ID: APPC-59
Change-Id: Ifd745964f659f075250d6acaf1b5f033da28e1c4
Signed-off-by: Skip Wonnell <kw5258@att.com>
6 years agoInitial commit for appc-flow-controller bundle 63/7663/10
Skip Wonnell [Tue, 15 Aug 2017 22:26:38 +0000 (17:26 -0500)]
Initial commit for appc-flow-controller bundle

This bundle contains the APPC orchestration control
for the directed graph for model driven transactions

Issue-ID: APPC-73
Change-Id: Ia812fe14b2d6aa46c3acd5b2bfab0c004507c628
Signed-off-by: Skip Wonnell <kw5258@att.com>
6 years agoInitial commit for appc-data-services bundle 61/7661/8
Skip Wonnell [Tue, 15 Aug 2017 22:05:27 +0000 (17:05 -0500)]
Initial commit for appc-data-services bundle

This bundle contains the generic execute nodes that
interact with the database.

Issue-ID: APPC-58
Change-Id: Ib1447443ed259f4133cd33d554a5ac43f2c3dd1b
Signed-off-by: Skip Wonnell <kw5258@att.com>
6 years agoFix APPC sonar coverage 57/7757/2
Marcus G K Williams [Wed, 16 Aug 2017 17:05:43 +0000 (10:05 -0700)]
Fix APPC sonar coverage

Issue-Id: APPC-156
Change-Id: Idccbf97538d05d173ebe74cef1442392c6a91486
Signed-off-by: Marcus G K Williams <marcus.williams@intel.com>
6 years ago[APPC-144] OAM operation abort messages 59/7759/3
beili.zhou [Wed, 16 Aug 2017 18:16:50 +0000 (14:16 -0400)]
[APPC-144] OAM operation abort messages

Provide abort audit log as well as notification when OAM operation is
interrupted by a new OAM operation request.
Fix missing ID in audit log for reject message.

Issue-Id: APPC-144
Change-Id: Ie87e19949be85c085444c753fdf061f4fc45e48f
Signed-off-by: beili.zhou <beili.zhou@amdocs.com>
6 years agoInitial commit for appc-encryption-tool bundle 23/7623/8
Skip Wonnell [Tue, 15 Aug 2017 17:43:03 +0000 (12:43 -0500)]
Initial commit for appc-encryption-tool bundle

appc-encryption-tool:  module to retrieve and store
encryped credentials

Change-Id: I3d45c662c9d58dbeec2ab7fffb51658c9ee0d5d3
Signed-off-by: Skip Wonnell <kw5258@att.com>
Issue-Id: APPC-67

6 years agoCreate and store Dependency model from Tosca 61/7561/3
Masal, Sushil (sm588m) [Sun, 13 Aug 2017 13:40:02 +0000 (19:10 +0530)]
Create and store Dependency model from Tosca

Updated asdc listerner bundle to create dependency model from tosca
artifact reveived from SDC.This dependency model will be in JSON
format and will be stored to ASDC_ARTIFACT table as new artifact.
Also ASDC_REFERENCE table  will be updated to with new artifact
details.
This commit also include bug fix for MDSALStore to handle all http
code for successful rest calls

Issue ID: APPC-32
Change-Id: Iaef6cdee67475917968a4bcdec131cd1bc4c4f41
Signed-off-by: Masal, Sushil (sm588m) <sushil.masal@amdocs.com>
6 years agoMerge "Action-Identifier to support vf-module-id"
Marcus Williams [Wed, 16 Aug 2017 00:54:38 +0000 (00:54 +0000)]
Merge "Action-Identifier to support vf-module-id"

6 years agoMerge "[APPC-127] NPE on execution of LCM action Lock"
Marcus Williams [Tue, 15 Aug 2017 19:53:35 +0000 (19:53 +0000)]
Merge "[APPC-127] NPE on execution of LCM action Lock"

6 years ago[APPC-143] OAM restart operation with stop error 31/7631/1
beili.zhou [Tue, 15 Aug 2017 18:39:58 +0000 (14:39 -0400)]
[APPC-143] OAM restart operation with stop error

Fix OAM restart operation does not report stop failure. And also remove
unused LCM OperationStatus and related comments.

Issue-Id: APPC-143
Change-Id: Ia2580717ef515856725e3e50c63b17404f123325
Signed-off-by: beili.zhou <beili.zhou@amdocs.com>
6 years agoAdded review comment 21/7521/3
Anand Chaturvedi [Tue, 15 Aug 2017 00:10:36 +0000 (20:10 -0400)]
Added review comment

Initial commit for Network-Inv and  AAI client

commit 61419e46211f1f1e763d4a84214c62a5e699bdf2
Author: Anand Chaturvedi <ac204h@att.com>
Date:   Mon Aug 14 19:54:11 2017 -0400
Issue-Id: APPC-21

    [OnapMigration] OnapMigration for APPC OutBound Services..

Change-Id: I7db4bcb52b050988b601f3abac544c43f34c677b
Signed-off-by: Anand Chaturvedi <ac204h@att.com>
6 years agoAction-Identifier to support vf-module-id 81/7581/1
Kalpesh Chaniyara [Tue, 15 Aug 2017 09:15:00 +0000 (14:45 +0530)]
Action-Identifier to support vf-module-id

As of now LCM Request Identifier supports
vnf-id, vnfc-name and vserver-id. This change
supports vf-module-id as action identifier
and its value is set in DG context with key
input.action-identifiers.vf-module-id when
invoking DG

Issue-Id : APPC-142
Change-Id: I65d44b073d32e39eaba183b8ce47584441921f3c
Signed-off-by: Kalpesh Chaniyara <kalpeshkumar.chaniyara@amdocs.com>
6 years ago[APPC-127] NPE on execution of LCM action Lock 47/7547/1
Kalpesh Chaniyara [Tue, 15 Aug 2017 05:14:15 +0000 (10:44 +0530)]
[APPC-127] NPE on execution of LCM action Lock

2 Constants classes were present under
same package in appc-dispatcher sub modules,
Moved one class under appc-request-handler-core
to different package

Issue-Id :APPC-127
Change-Id: I9bb9000b90862d245c2c8465495690a2635a741d
Signed-off-by: Kalpesh Chaniyara <kalpeshkumar.chaniyara@amdocs.com>
6 years agoInitial commit for appc-config-params 23/7423/4
Anand Chaturvedi [Sat, 12 Aug 2017 05:31:10 +0000 (01:31 -0400)]
Initial commit for appc-config-params

Change-Id: I5805591892184b4456dd30639417d783d353a6a3
Signed-off-by: Anand Chaturvedi <ac204h@att.com>
Issue-Id:APPC-9

6 years agoUpdate license plugin to exclude json files 37/7437/2
Skip Wonnell [Sun, 13 Aug 2017 20:19:32 +0000 (15:19 -0500)]
Update license plugin to exclude json files

Change-Id: I843185af796729c71ccc9aa822844436d4804c3f
Signed-off-by: Skip Wonnell <kw5258@att.com>
Issue-ID: APPC-87

6 years agoOAM operations 3 - JUnit tests 25/7425/4
beili.zhou [Sat, 12 Aug 2017 02:55:57 +0000 (22:55 -0400)]
OAM operations 3 - JUnit tests

OAM operations changes are large, need to be broken down to multiple
submission based on size and compilability. This is the third (last) set
which covers JUnit test cases.

Includes these user stories: APPC-39/41/43/44/45/46/52/77.

Issue Id: APPC-38
Change-Id: I2df5e6b371d05030fb18bdd48155e4bb23034997
Signed-off-by: beili.zhou <beili.zhou@amdocs.com>
6 years agoOAM operations 2 - oam 21/7421/3
beili.zhou [Sat, 12 Aug 2017 02:16:05 +0000 (22:16 -0400)]
OAM operations 2 - oam

OAM operations changes are large, need to break down to multiple
submissions based on size and compilability. This is the second set which
covers the following OAM operations: start, stop, restart,
maintenance-mode, and timeout of the operation along with error OAM
state.

Includes these user stories: APPC-39/41/43/44/45/46/52/77.

Issue Id: APPC-38
Change-Id: Iafad643c5ba2d2af24482b03db8f7a40397fa46e
Signed-off-by: beili.zhou <beili.zhou@amdocs.com>
6 years agoOAM operations 1 - miscellaneous 19/7419/3
beili.zhou [Sat, 12 Aug 2017 01:48:22 +0000 (21:48 -0400)]
OAM operations 1 - miscellaneous

OAM operations changes are large, need to break down to multiple
submissions based on size and compilability. This is the first set which
covers: feature installation, audit log message, listener instantiation
and etc.

Includes these user stories: APPC-39/41/43/44/45/46/52/77.

Issue Id: APPC-38
Change-Id: Ifc0f5bd2468732d04ae462be09a6ad720aefba2b
Signed-off-by: beili.zhou <beili.zhou@amdocs.com>
6 years agoMerge "[APPC-44] revert license line ending changes"
Marcus Williams [Fri, 11 Aug 2017 23:00:18 +0000 (23:00 +0000)]
Merge "[APPC-44] revert license line ending changes"

6 years ago[APPC-45] appc-dg-common start 95/7395/2
beili.zhou [Fri, 11 Aug 2017 19:43:00 +0000 (15:43 -0400)]
[APPC-45] appc-dg-common start

Fix appc-dg-common bundle start issue (does not occur at the APPC start
up) by using blueprint for its instantiation.

Issue-Id: APPC-45
Change-Id: I40887701269a44ba711a00aa12a551e672b34532
Signed-off-by: beili.zhou <beili.zhou@amdocs.com>
6 years ago[APPC-44] command executor feature installer 59/7359/4
beili.zhou [Fri, 11 Aug 2017 19:52:51 +0000 (15:52 -0400)]
[APPC-44] command executor feature installer

ONAP used karaf plugin installation which required each feature has
installer, this one is adding the feature installer for command
executor. Pre-change for APPC OAM operations.

Issue-Id: APPC-44
Change-Id: I02080f4ee52ee0e9794237e11ef86f4c330de420
Signed-off-by: beili.zhou <beili.zhou@amdocs.com>
6 years agoFixing dmaap authentication exception 77/7377/2
Patrick Brady [Fri, 11 Aug 2017 18:41:51 +0000 (11:41 -0700)]
Fixing dmaap authentication exception

Dmaap http client was incorrectly throwing an exception if
no authetication was present. This should not be since
dmaap does not require authentication.

Change-Id: If90ce1e52bf226bacc5a6c57bfe8aaa98e583bc5
Signed-off-by: Patrick Brady <pb071s@att.com>
Issue-Id: APPC-135

6 years ago[APPC-44] revert license line ending changes 93/7393/1
Joey Sullivan [Fri, 11 Aug 2017 19:07:16 +0000 (19:07 +0000)]
[APPC-44] revert license line ending changes

Issue-Id: APPC-44
Change-Id: Id9350fb7e19512ee380d6ca480d5ca9569fe3bd4
Signed-off-by: Joey Sullivan <joey.sullivan@amdocs.com>
6 years ago[APPC-44] APPC Lifecycle Management refactor 41/7241/5
beili.zhou [Thu, 10 Aug 2017 18:54:42 +0000 (14:54 -0400)]
[APPC-44] APPC Lifecycle Management refactor

Pull APPC lifecycle Management out of APPC dispatcher, so that it can be
used by both APPC dispatcher and APPC OAM. This is the pre-step of
introducing APPC OAM operations.

Issue-Id: APPC-44
Change-Id: Icbde399b5121fae9e1919cfdd5c77bbe55d61188
Signed-off-by: beili.zhou <beili.zhou@amdocs.com>
6 years ago[APPC-126] rename license diretory for windows 23/7023/1
beili.zhou [Tue, 8 Aug 2017 19:54:28 +0000 (15:54 -0400)]
[APPC-126] rename license diretory for windows

Change-Id: Ic93af88532864ca4f4e9d3024719c9f4fbd651a6
Signed-off-by: beili.zhou <beili.zhou@amdocs.com>
6 years ago[APPC-121]Fix VNF NumberFormatException 51/6751/1
beili.zhou [Fri, 4 Aug 2017 20:45:06 +0000 (16:45 -0400)]
[APPC-121]Fix VNF NumberFormatException

Change-Id: I14464adc0b11b909131232cdcb9d46cb0a01b000
Signed-off-by: beili.zhou <beili.zhou@amdocs.com>
6 years agoAvoid possible NEP in WorkingStateManagerImpl.java 75/6675/1
Skip Wonnell [Thu, 3 Aug 2017 19:58:41 +0000 (14:58 -0500)]
Avoid possible NEP in WorkingStateManagerImpl.java

Squashed commit of the following:

commit 7f62d9a1fa166aa55579795b7a592e22a6df3772
Author: Skip Wonnell <kw5258@att.com>
Date:   Thu Aug 3 13:22:22 2017 -0500

    [APPC-92] Fix sonar blocker issue

    Check vnfWorkingStateDto for null before dereference.

Change-Id: I4630df4bcd3d696041123e1fc0267c46a756425b
Signed-off-by: Skip Wonnell <kw5258@att.com>
Issue: APPC-92

6 years agoMerging in bug fixes 43/6343/9
Patrick Brady [Fri, 28 Jul 2017 18:29:23 +0000 (11:29 -0700)]
Merging in bug fixes

Change-Id: I85da90b9ba0d03149f42035a820c76ef0285e413
Signed-off-by: Patrick Brady <pb071s@att.com>
Issue: APPC-100

6 years agoAvoid possible NPEs in EventHandlerImpl.java 27/6427/2
Skip Wonnell [Mon, 31 Jul 2017 17:31:22 +0000 (12:31 -0500)]
Avoid possible NPEs in EventHandlerImpl.java

Change-Id: Id2c5fe1b07ecf1c6e7b70261daae8fa3955400e7
Signed-off-by: Skip Wonnell <kw5258@att.com>
Issue: APPC-98

6 years agoFix resource leak in ChefAdapterImpl.java 39/6139/2
Skip Wonnell [Fri, 21 Jul 2017 12:03:48 +0000 (08:03 -0400)]
Fix resource leak in ChefAdapterImpl.java

Convert to Closeable versions of HttpClient and HttpResponse
and instantiate both inside a TWR.

Change-Id: I37ac34bab545592f51fb054068065fa1c00f7224
Signed-off-by: Skip Wonnell <kw5258@att.com>
Issue: APPC-94

6 years ago[APPC-93] Resource leak in appc.adapter.chef.chefclient.Utils 95/6095/3
Skip Wonnell [Thu, 20 Jul 2017 02:02:57 +0000 (22:02 -0400)]
[APPC-93] Resource leak in appc.adapter.chef.chefclient.Utils

Place instantiation of FileReader and BufferedReader inside a TWR

Change-Id: Ibc0fffa76e536bdccca92731dc7ebc878faf67a1
Signed-off-by: Skip Wonnell <kw5258@att.com>
6 years agoApplying license changes to all files 57/6057/5
Patrick Brady [Wed, 19 Jul 2017 19:09:28 +0000 (12:09 -0700)]
Applying license changes to all files

[APPC-87] Fix Maven License Plugin

Change-Id: I23a95b6c1020618d05f17c63c72152cf86e4d4a0
Signed-off-by: Patrick Brady <pb071s@att.com>
6 years agoAdding custom license for maven license plugin 53/6053/3
Patrick Brady [Wed, 19 Jul 2017 18:22:32 +0000 (11:22 -0700)]
Adding custom license for maven license plugin

[APPC-87] Fix Maven License Plugin

Change-Id: If19274f46b2eaf83539642d313130bdcfa6a9eb7
Signed-off-by: Patrick Brady <pb071s@att.com>
6 years agoRefactor POM to inherit from oparent 77/5177/3
Gary Wu [Wed, 21 Jun 2017 23:51:59 +0000 (16:51 -0700)]
Refactor POM to inherit from oparent

Refactor POM to inherit from oparent.
Remove local settings related to nexus and checkstyle.

Issue-id: APPC-78
Change-Id: I52167488d5d9216f351f306348ca77544cac9def
Signed-off-by: Gary Wu <gary.i.wu@huawei.com>
6 years ago[APPC-16] update the chef adapter 85/5785/1
root [Thu, 13 Jul 2017 13:43:35 +0000 (09:43 -0400)]
[APPC-16] update the chef adapter

Change-Id: I712b42f0e09a250cd06ec3a67561ca2ce062f760
Signed-off-by: root <jh245g@att.com>
6 years ago[feature/APPC-7] ansible server commit 99/5699/4
ecnoel [Thu, 6 Jul 2017 14:02:01 +0000 (09:02 -0500)]
[feature/APPC-7] ansible server commit

Change-Id: I87b4843ca5d646e390d985be27aa1e3b94491d07
Signed-off-by: ecnoel <eric.noel@att.com>
Signed-off-by: Patrick Brady <pb071s@att.com>
6 years agoChanging to sdnc snapshot version [APPC-15] 91/5191/1
Patrick Brady [Thu, 22 Jun 2017 17:30:40 +0000 (10:30 -0700)]
Changing to sdnc snapshot version [APPC-15]

Sdnc docker images do not seem to contain non-snapshot artifacts.
Switching to use snapshot artifacts should fix the problem.

Change-Id: Ie1e1c3b53ccfee9976c03d9f0934aef7f272eeb5
Signed-off-by: Patrick Brady <pb071s@att.com>
6 years agoUpdating sdnc version [APPC-15] 31/5131/1
Patrick Brady [Tue, 20 Jun 2017 20:20:12 +0000 (13:20 -0700)]
Updating sdnc version [APPC-15]

Change-Id: I523cc2ce8ec9ddbb606b2e41520dd161a13fcea9
Signed-off-by: Patrick Brady <pb071s@att.com>
6 years ago[feature/APPC-6] 45/5045/2
Ashwin Sridharan [Thu, 15 Jun 2017 03:11:25 +0000 (23:11 -0400)]
[feature/APPC-6]

Added Ansible Adapter Extension for APP-C

Change-Id: I4580fe5ebec526186fff5520fc7d12bff49f3fa4
Signed-off-by: Ashwin Sridharan <asridharan@research.att.com>
Signed-off-by: Patrick Brady <pb071s@att.com>
6 years agoUpdating licenses in all files 71/4771/5
Patrick Brady [Wed, 7 Jun 2017 05:35:43 +0000 (22:35 -0700)]
Updating licenses in all files

Change-Id: Ic229be3cc3e4751b9bfbd3c5c08db84ec8e7e0cb
Signed-off-by: Patrick Brady <pb071s@att.com>
6 years agoRemove duplicated dependencies 89/4589/2
Victor Morales [Thu, 1 Jun 2017 19:14:11 +0000 (14:14 -0500)]
Remove duplicated dependencies

It was removed some duplicated entries from the pom.xml file of
appc-chef-adapter-bundle project

Change-Id: Idab32dcffcaa18af249ff4354453856ab378de2e
Signed-off-by: Victor Morales <victor.morales@intel.com>
6 years agoFixing logic in an if statement 73/4673/1
Patrick Brady [Mon, 5 Jun 2017 20:44:20 +0000 (13:44 -0700)]
Fixing logic in an if statement

Change-Id: Ibc50b5e56953ce6ceed11b21e9d2042d5a540cad
Signed-off-by: Patrick Brady <pb071s@att.com>
6 years agoMerge of new rebased code 83/4583/4
Patrick Brady [Thu, 1 Jun 2017 17:45:37 +0000 (10:45 -0700)]
Merge of new rebased code

Change-Id: I9b8d1f69eb3e0af1935ed8304fea4bf54c1aac47
Signed-off-by: Patrick Brady <pb071s@att.com>
6 years agoRemove commented methods/fields in APPC 27/3827/2
Marcus G K Williams [Tue, 2 May 2017 22:11:04 +0000 (15:11 -0700)]
Remove commented methods/fields in APPC

Taking a stab at removing numerous
commented out methods and fields.
Almost all of what is removed is
commented code with no explanation.

Change-Id: I61cb1d7100ae6c75f6d42f500ade0504c97b760c
Signed-off-by: Marcus G K Williams <marcus.williams@intel.com>
6 years agoFix compilation errors in Eclipse 99/3999/2
Gary Wu [Tue, 9 May 2017 04:04:32 +0000 (21:04 -0700)]
Fix compilation errors in Eclipse

Change-Id: Ic5aa1977199237e006376231ae3970ece7f2cd26
Signed-off-by: Gary Wu <gary.i.wu@huawei.com>
6 years agoEnable NETCONF Adapter bundle logging 25/3825/4
Marcus G K Williams [Tue, 2 May 2017 22:14:39 +0000 (15:14 -0700)]
Enable NETCONF Adapter bundle logging

Change-Id: If746c9a29066f8cbf7c27b280a44665144fe96d9
Signed-off-by: Marcus G K Williams <marcus.williams@intel.com>
6 years agoMerge "Remove unused class StreamHelper"
Patrick Brady [Tue, 16 May 2017 19:56:46 +0000 (19:56 +0000)]
Merge "Remove unused class StreamHelper"

6 years agoRefactor CommandTask classes to be immutable 01/4001/2
Gary Wu [Tue, 9 May 2017 06:04:31 +0000 (23:04 -0700)]
Refactor CommandTask classes to be immutable

Refactor CommandTask and its subclasses to be immutable.
Also made CommandResponse immutable.

Change-Id: I9ea1b57fdff677b163c0fe9ad5d48f24b781a08f
Signed-off-by: Gary Wu <gary.i.wu@huawei.com>
6 years agoMigrate to Java 8 Time API 79/3979/5
Gary Wu [Mon, 8 May 2017 19:59:44 +0000 (12:59 -0700)]
Migrate to Java 8 Time API

Migrate the uses of the old Date class in CommonHeader,
RuntimeContext, QueueMessage, and TransactionRecord to
Java 8 Time API.

Change-Id: I3b0c18b2e63cdab06e37587d2010cb7f626a0396
Signed-off-by: Gary Wu <gary.i.wu@huawei.com>
7 years agoRemove unused class StreamHelper 95/3995/1
Gary Wu [Mon, 8 May 2017 23:13:34 +0000 (16:13 -0700)]
Remove unused class StreamHelper

Change-Id: I217ef6d42065f029434e55aeed259604ce68689a
Signed-off-by: Gary Wu <gary.i.wu@huawei.com>
7 years agoMerge "Remove unused CONFIGURATION_METHOD_NAME"
Patrick Brady [Mon, 8 May 2017 18:52:10 +0000 (18:52 +0000)]
Merge "Remove unused CONFIGURATION_METHOD_NAME"

7 years agoRemove commented out logger in APPC 19/3819/3
Marcus G K Williams [Tue, 2 May 2017 17:29:39 +0000 (10:29 -0700)]
Remove commented out logger in APPC

Change-Id: Ib1b9bb1797180118ee1e5c0de18aafa2089c514b
Signed-off-by: Marcus G K Williams <marcus.williams@intel.com>
7 years agoRemove unused CONFIGURATION_METHOD_NAME 17/3817/1
Marcus G K Williams [Tue, 2 May 2017 16:43:45 +0000 (09:43 -0700)]
Remove unused CONFIGURATION_METHOD_NAME

Change-Id: Ifa9b1855dd22c9453c145ed8faf6c16c38b6a17a
Signed-off-by: Marcus G K Williams <marcus.williams@intel.com>
7 years agoMake Flags immutable 91/3591/2
Gary Wu [Fri, 21 Apr 2017 19:34:25 +0000 (12:34 -0700)]
Make Flags immutable

Change-Id: Ib2e06d41d4e1eb6fb40144258067d2c71ac1d620
Signed-off-by: Gary Wu <gary.i.wu@huawei.com>
7 years agoRemove CommandExecutorInput 87/3587/3
Gary Wu [Fri, 21 Apr 2017 18:51:01 +0000 (11:51 -0700)]
Remove CommandExecutorInput

CommandExecutorInput.getTtl() was never called. Once that
is removed, CommandExecutorInput only contains a single
RuntimeContext object.  This change removes CommandExecutorInput
and replaces its uses with RuntimeContext directly.

Change-Id: Ib8145b7f844d4b9ea294622e7cf4bdfc3aefcd0a
Signed-off-by: Gary Wu <gary.i.wu@huawei.com>
7 years agoadd some comments 31/3731/2
Cheng (Ian) Liu [Wed, 26 Apr 2017 20:26:25 +0000 (15:26 -0500)]
add some comments

Change-Id: If01eec50c638ac03828d562f2204309aabb6635a
Signed-off-by: Cheng (Ian) Liu <lch.ian12@gmail.com>
7 years agoRemoving java source and target properties 25/3725/3
Patrick Brady [Wed, 26 Apr 2017 16:05:54 +0000 (09:05 -0700)]
Removing java source and target properties

Change-Id: Ifecb7859b2826a296e5b79e32088069543a27e61
Signed-off-by: Patrick Brady <pb071s@att.com>