appc.git
5 years agoTest coverage in transaction-recorder 01/78101/2
Joss Armstrong [Fri, 8 Feb 2019 08:38:45 +0000 (08:38 +0000)]
Test coverage in transaction-recorder

Increased coverage from 64% to 96%

Issue-ID: APPC-1403
Change-Id: Idbb94d5e8933ac65bfc68cec6996c5ac039e8748
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agoIncrease coverage in workflow.activator package 19/78119/2
Joss Armstrong [Fri, 8 Feb 2019 14:37:40 +0000 (14:37 +0000)]
Increase coverage in workflow.activator package

From 32% to 85%

Issue-ID: APPC-1408
Change-Id: I52447e5df9fd3a6ebdb257dbba9a83013bad6f05
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agoJunit Class Added for AuthenticationException.java 02/78102/2
Sudarshan Kumar [Fri, 8 Feb 2019 08:46:47 +0000 (14:16 +0530)]
Junit Class Added for AuthenticationException.java

Junit Class Added for AuthenticationException.java

Issue-ID: APPC-1372
Change-Id: If8473d5eef4cabb52f72c1debe84c22b99998aa5
Signed-off-by: Sudarshan Kumar <sudars19@in.ibm.com>
5 years agoAdded unit test cases for Worker class 57/78057/2
Lathishbabu Ganesan [Thu, 7 Feb 2019 13:34:20 +0000 (08:34 -0500)]
Added unit test cases for Worker class

Increased coverage from 0% to 100%

Issue-ID: APPC-1402
Change-Id: I2a0a05a29cce79004581f21fd56138485b631f78
Signed-off-by: Lathishbabu Ganesan <lathishbabu.ganesan@ericsson.com>
5 years agoAdded test coverage aaiinterfaceruleshandler 61/77961/4
Lathishbabu Ganesan [Wed, 6 Feb 2019 15:08:30 +0000 (10:08 -0500)]
Added test coverage aaiinterfaceruleshandler

Increase from 31% to 87%

Issue-ID: APPC-1366
Change-Id: Ib9d643c128e3dd76f658577fd8d25763e8d8dd25
Signed-off-by: Lathishbabu Ganesan <lathishbabu.ganesan@ericsson.com>
5 years agoCoverage in lock-manager 41/78041/2
Joss Armstrong [Thu, 7 Feb 2019 10:33:35 +0000 (10:33 +0000)]
Coverage in lock-manager

Increased package coverage to 93%

Issue-ID: APPC-1400
Change-Id: I4ff2a02466fc7a178c4d411ca4647b1c3877b405
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agoVulnerabilities Fix - ParamsHandlerActivator.java 40/78040/3
Sudarshan Kumar [Thu, 7 Feb 2019 10:27:15 +0000 (15:57 +0530)]
Vulnerabilities Fix - ParamsHandlerActivator.java

Removed printStackTrace and put logger

Issue-ID: APPC-1399
Change-Id: I0217b530cde6b6d22b09210eeb65697006d60795
Signed-off-by: Sudarshan Kumar <sudars19@in.ibm.com>
5 years agoVulnerabilities Fix - ParamsHandlerConstant.java 39/78039/2
Sudarshan Kumar [Thu, 7 Feb 2019 10:09:53 +0000 (15:39 +0530)]
Vulnerabilities Fix - ParamsHandlerConstant.java

Vulnerabilities Fix - Added final to all the constant variables

Issue-ID: APPC-1399
Change-Id: I20ce67627f3d1752c4896cfa42e0f4cb88bf8059
Signed-off-by: Sudarshan Kumar <sudars19@in.ibm.com>
5 years agoCoverage for lockmanager.sql.optimistic package 55/78055/3
Joss Armstrong [Thu, 7 Feb 2019 13:32:20 +0000 (13:32 +0000)]
Coverage for lockmanager.sql.optimistic package

Increased coverage from 54% to 95%

Issue-ID: APPC-1400
Change-Id: Ic71a090ff9e292a9d9856f50561f348a77653e4f
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agoTest coverage in lockmanager.sql.pessimistic 62/78062/2
Joss Armstrong [Thu, 7 Feb 2019 14:46:51 +0000 (14:46 +0000)]
Test coverage in lockmanager.sql.pessimistic

Increased package coverage from 52% to 98%

Issue-ID: APPC-1400
Change-Id: Iabce54c1004f4c5f1729d11b2ae40003d202625e
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agoNew test class for QueueManager 11/78011/4
Joss Armstrong [Wed, 6 Feb 2019 21:53:57 +0000 (21:53 +0000)]
New test class for QueueManager

Increase test coverage from 8% to 84%

Issue-ID: APPC-1396
Change-Id: I82fa20559e37fa387dbc7efa0bc24ba93139a973
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agoAdded unit test cases for Instar client class 45/78045/4
Lathishbabu Ganesan [Thu, 7 Feb 2019 11:52:38 +0000 (06:52 -0500)]
Added unit test cases for Instar client class

Increased Test coverage from 0% to 100%

Issue-ID: APPC-1401
Change-Id: I4b1151d63b2aadf9a98cb147ec9fb4725e817ca2
Signed-off-by: Lathishbabu Ganesan <lathishbabu.ganesan@ericsson.com>
5 years agoadded test case to TestDataTool.java 28/78028/3
Sandeep J [Thu, 7 Feb 2019 07:05:57 +0000 (12:35 +0530)]
added test case to TestDataTool.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: I1602078de42c9815fe81b76425939752610446aa
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded test cases to TestSshConnectionMock.java 29/78029/3
Sandeep J [Thu, 7 Feb 2019 07:15:14 +0000 (12:45 +0530)]
added test cases to TestSshConnectionMock.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: Iea79d58378564cb0ab847a9ff55a30b8d20833c7
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded test file to cover ResponseKey.java 30/78030/2
Sandeep J [Thu, 7 Feb 2019 07:24:53 +0000 (12:54 +0530)]
added test file to cover ResponseKey.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: I7408e9eeda6f52f6ba3aae437ca75c3647d97de0
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoAdd coverage for executionqueue helper package 78/77978/5
Joss Armstrong [Wed, 6 Feb 2019 18:14:04 +0000 (18:14 +0000)]
Add coverage for executionqueue helper package

New test file giving 100% coverage

Issue-ID: APPC-1396
Change-Id: I597a778e4c128f745335ad243c0fa8cc8b0b1e45
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agoImprove testing in ExecutionQueueServiceImpl 85/77985/2
Joss Armstrong [Wed, 6 Feb 2019 18:31:58 +0000 (18:31 +0000)]
Improve testing in ExecutionQueueServiceImpl

Increased coverage to 100%

Issue-ID: APPC-1396
Change-Id: Ie9c2bd14d83f43e4fc41dacfd45a596ec46b1d95
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agoAdd coverage for untested DBHelper class 71/77971/2
Joss Armstrong [Wed, 6 Feb 2019 17:11:16 +0000 (17:11 +0000)]
Add coverage for untested DBHelper class

Added tests and provided coverage of 95%

Issue-ID: APPC-1394
Change-Id: Id63e78a72fe49d3a36af786192dc2359f3d3e334
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agoTest coverage for DBConnectionPool 68/77968/2
Joss Armstrong [Wed, 6 Feb 2019 16:53:34 +0000 (16:53 +0000)]
Test coverage for DBConnectionPool

Increased class coverage to 100%

Issue-ID: APPC-1394
Change-Id: I7c8adb081b7342a5a18d3a2ca0238625317c6b4d
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agoIncrease coverage in AppcDatabaseConnectionPool 60/77960/2
Joss Armstrong [Wed, 6 Feb 2019 14:58:20 +0000 (14:58 +0000)]
Increase coverage in AppcDatabaseConnectionPool

Add test cases and increase coverage to 94%

Issue-ID: APPC-1394
Change-Id: I7ec2b0cb4fe5a22ebd8020eb7f5636075e1c5ac5
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agoReduce unit test duration from 40s to 4s 46/77946/4
Joss Armstrong [Wed, 6 Feb 2019 10:34:35 +0000 (10:34 +0000)]
Reduce unit test duration from 40s to 4s

Mocked retry delay value to a lower value to
reduce test time

Issue-ID: APPC-1393
Change-Id: I98ea66b4cd0cc47d1861544bb70ec4c0e665e394
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agofix bug for readResource in AAI 02/77802/7
Neha Sood [Mon, 4 Feb 2019 17:24:37 +0000 (12:24 -0500)]
fix bug for readResource in AAI

fix bug for readResource in AaiService

Change-Id: I20a6564f3bbc16ab5deb3e0e40a75a105343965d
Issue-ID: APPC-1379
Signed-off-by: Neha Sood <ns189k@att.com>
5 years agoTest coverage for AppcNetconfAdapterActivator 72/77872/3
Joss Armstrong [Tue, 5 Feb 2019 13:59:47 +0000 (13:59 +0000)]
Test coverage for AppcNetconfAdapterActivator

Added 100% coverage for untested class. Moved other test
file to correct package.

Issue-ID: APPC-1389
Change-Id: I73e768f21d5cda8865f891c63b9ad3f3ea2cce80
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agoadded test case to ConfigResourceNodeTest 35/77935/4
Sandeep J [Wed, 6 Feb 2019 09:50:00 +0000 (15:20 +0530)]
added test case to ConfigResourceNodeTest

to increase code coverage

Issue-ID: APPC-1086
Change-Id: I69a92c10c3c2543a45ebf333e708286ffb6ac454
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded test case to TestDGGeneralDBService.java 27/77927/2
Sandeep J [Wed, 6 Feb 2019 07:50:30 +0000 (13:20 +0530)]
added test case to TestDGGeneralDBService.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: I5c88e11546158129ff0e97ced38ebd23635535e2
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoImprove testing and coverage of netconf class 87/77887/2
Joss Armstrong [Tue, 5 Feb 2019 16:18:40 +0000 (16:18 +0000)]
Improve testing and coverage of netconf class

Test now covers main success flows and increased coverage

Issue-ID: APPC-1390
Change-Id: I951d5ac3426ae6d6aa3567c80aef5a5bb95fa1c7
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agoadd test file for VNFOperationalStateValidatorImpl 69/77769/4
Sandeep J [Mon, 4 Feb 2019 10:19:36 +0000 (15:49 +0530)]
add test file for VNFOperationalStateValidatorImpl

to increase code coverage

Issue-ID: APPC-1086
Change-Id: I65861398bb166baa8689934a23ecb7da248bbca6
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoVolume - Junit Test case added 96/77696/4
Sudarshan Kumar [Fri, 1 Feb 2019 07:43:05 +0000 (13:13 +0530)]
Volume - Junit Test case added

Volume - Junit Test case added

Issue-ID: APPC-1372
Change-Id: I44a262819ddc3f0f3319e320ef3bf01ef8ca1e13
Signed-off-by: Sudarshan Kumar <sudars19@in.ibm.com>
5 years agoTest coverage in rest-healthcheck-adapter 61/77861/3
Joss Armstrong [Tue, 5 Feb 2019 09:39:45 +0000 (09:39 +0000)]
Test coverage in rest-healthcheck-adapter

Increased coverage

Issue-ID: APPC-1387
Change-Id: Idafa0d7dbd5cb740728197bc3b4c232bdbef0821
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agoImprove test coverage of reboot 70/77770/4
Joss Armstrong [Mon, 4 Feb 2019 10:31:04 +0000 (10:31 +0000)]
Improve test coverage of reboot

Increase line coverage from 20% to 73%

Issue-ID: APPC-1374
Change-Id: I219261a228f42df56f6988b2d5dc157e6fb10c42
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agoIncrease coverage of EvacuateServer 84/77784/3
Joss Armstrong [Mon, 4 Feb 2019 13:27:18 +0000 (13:27 +0000)]
Increase coverage of EvacuateServer

Increased line coverage of class

Issue-ID: APPC-1374
Change-Id: Ica44ff92a446e8b380162675d0f0f79e30ad6e73
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agoAdd coverage for seqgen-provider 01/77801/5
Joss Armstrong [Mon, 4 Feb 2019 17:20:41 +0000 (17:20 +0000)]
Add coverage for seqgen-provider

Added coverage for untested package

Issue-ID: APPC-1386
Change-Id: I6b6d74c54982dd327176a2e1e5f3c873be9dbb89
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agoAdditional test case added ResponseContext.java 00/77800/4
Sudarshan Kumar [Mon, 4 Feb 2019 17:18:30 +0000 (22:48 +0530)]
Additional test case added ResponseContext.java

Additional junit test case added for ResponseContext.java

Issue-ID: APPC-1372
Change-Id: Iaa9455d80e84c46c39ffce066abe3aedfb56a58d
Signed-off-by: Sudarshan Kumar <sudars19@in.ibm.com>
5 years agoEncryption tool changes for multiple ansibleserver 08/77608/6
George, Lina (lg941u) [Wed, 30 Jan 2019 21:01:19 +0000 (16:01 -0500)]
Encryption tool changes for multiple ansibleserver

Issue-ID: APPC-1342
Change-Id: Ib1ff7845ad65cf13c06a96d6dcce023b06064dfa
Signed-off-by: George, Lina (lg941u) <lg941u@att.com>
5 years agoJunit test class added for TemplateException.java 72/77772/3
Sudarshan Kumar [Mon, 4 Feb 2019 10:36:38 +0000 (16:06 +0530)]
Junit test class added for TemplateException.java

Junit test class added for TemplateException.java

Issue-ID: APPC-1372
Change-Id: I94d97e4b173c51a34a0320f3e24761582fc39101
Signed-off-by: Sudarshan Kumar <sudars19@in.ibm.com>
5 years agomade changes to existing test case 52/77852/3
Sandeep J [Tue, 5 Feb 2019 07:59:02 +0000 (13:29 +0530)]
made changes to existing test case

to increase code coverage

Issue-ID: APPC-1086
Change-Id: I72df9d78b439ff5d8b610d87a5295f5dce3fba59
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoVolume_ - Junit Test case added 99/77699/4
Sudarshan Kumar [Fri, 1 Feb 2019 07:59:51 +0000 (13:29 +0530)]
Volume_ - Junit Test case added

Volume_ - Junit Test case added

Issue-ID: APPC-1372
Change-Id: Ie35baff6161aaeecd25e2055ef40f3a6d5b0000b
Signed-off-by: Sudarshan Kumar <sudars19@in.ibm.com>
5 years agolistener bundle change for multiple ansible 24/77624/7
Balaji, Ramya (rb111y) [Thu, 31 Jan 2019 03:26:13 +0000 (22:26 -0500)]
listener bundle change for multiple ansible

Changes to event listener and dependent
bundles

Issue-ID: APPC-1376
Change-Id: I26e9f6f39caa2a0b0ad46a3a61d21db9f0c05d47
Signed-off-by: Balaji, Ramya (rb111y) <rb111y@att.com>
5 years agoSdc Listener Platform hardening changes 83/77783/2
Balaji, Ramya (rb111y) [Mon, 4 Feb 2019 12:57:11 +0000 (07:57 -0500)]
Sdc Listener Platform hardening changes

Issue-ID: APPC-1382
Change-Id: Ib4928843a8f169d856aaa1afa49fcfa127ba4990
Signed-off-by: Balaji, Ramya (rb111y) <rb111y@att.com>
5 years agoAdded Junit class for ProtocolException.java 63/77863/5
Sudarshan Kumar [Tue, 5 Feb 2019 09:42:25 +0000 (15:12 +0530)]
Added Junit class for ProtocolException.java

Added Junit class for ProtocolException.java

Issue-ID: APPC-1372
Change-Id: I695c7dca1cf92c2aa9354c6738042b20f949a215
Signed-off-by: Sudarshan Kumar <sudars19@in.ibm.com>
5 years agoadded test case to TestSshConnectionMock.java 53/77853/2
Sandeep J [Tue, 5 Feb 2019 08:13:51 +0000 (13:43 +0530)]
added test case to TestSshConnectionMock.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: Icbfd25c82b28783ea2afb7c6cd0411d72f6db12b
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded test file to cover TemplateException.java 58/77858/2
Sandeep J [Tue, 5 Feb 2019 09:08:08 +0000 (14:38 +0530)]
added test file to cover TemplateException.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: I21877b15110502d75b05fa57eb179fb462e1e755
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoTest coverage in netconf-oldconnector 68/77868/2
Joss Armstrong [Tue, 5 Feb 2019 12:16:19 +0000 (12:16 +0000)]
Test coverage in netconf-oldconnector

Increased coverage from 0% to 92% for package

Issue-ID: APPC-1388
Change-Id: I9f332f799f67937a40c09bdf724701ef80bbad89
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agoadded test case to TestSnapShot.java 97/77697/3
Sandeep J [Fri, 1 Feb 2019 07:45:16 +0000 (13:15 +0530)]
added test case to TestSnapShot.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: Iecc9f217c7f230311daf14ba49e3106ce31d017a
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded test case to TestTemplate.java 98/77698/4
Sandeep J [Fri, 1 Feb 2019 07:51:29 +0000 (13:21 +0530)]
added test case to TestTemplate.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: Ie6fdd33aab4ef6f0395d98375a26e83c750a06ce
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded test file to cover VnfType.java 71/77771/2
Sandeep J [Mon, 4 Feb 2019 10:37:13 +0000 (16:07 +0530)]
added test file to cover VnfType.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: Ia85fd2a0fab0de8b5fbf770ce58b4f308a1e5d74
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agomodified existing test case to increase coverage 74/77774/1
Sandeep J [Mon, 4 Feb 2019 10:55:32 +0000 (16:25 +0530)]
modified existing test case to increase coverage

to increase code coverage

Issue-ID: APPC-1086
Change-Id: Ic028f65e2d62529a91de069050aec11db09b6014
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoAdd test coverage for AttachVolumeServer 17/77717/2
Joss Armstrong [Fri, 1 Feb 2019 12:44:39 +0000 (12:44 +0000)]
Add test coverage for AttachVolumeServer

New test file to cover success flow in class

Issue-ID: APPC-1374
Change-Id: I576f523225e5ac427b972e78a8392496a71b6bfa
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agoTest coverage for DetachVolumeServer 22/77722/2
Joss Armstrong [Fri, 1 Feb 2019 14:49:12 +0000 (14:49 +0000)]
Test coverage for DetachVolumeServer

Added new test file for untested class

Issue-ID: APPC-1374
Change-Id: I334d53df87efb6a25a6f76a1660dd43c98d143b3
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agoTest coverage for SnapshotStack 26/77726/2
Joss Armstrong [Fri, 1 Feb 2019 15:26:27 +0000 (15:26 +0000)]
Test coverage for SnapshotStack

Added new test file for untested class

Issue-ID: APPC-1374
Change-Id: I6323eb60df3f0966bfa78291ffb3d1b277399ef2
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agoTest coverage for RestoreStack 30/77730/2
Joss Armstrong [Fri, 1 Feb 2019 17:00:51 +0000 (17:00 +0000)]
Test coverage for RestoreStack

Added new test file for untested class

Issue-ID: APPC-1374
Change-Id: Ie180b5a8f10aaa8aa7ea8b83b403a2eab1885818
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agoUpdate rest return parameters 38/77738/2
Patrick Brady [Fri, 1 Feb 2019 20:18:10 +0000 (12:18 -0800)]
Update rest return parameters

Change-Id: If5d860a37a87ac0feb6452173cf147bbafa079b3
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1381

5 years agoDocs add restconf use instructions 35/77735/2
Patrick Brady [Fri, 1 Feb 2019 19:00:49 +0000 (11:00 -0800)]
Docs add restconf use instructions

Add usage instructions for rest adapter to the
user guide.

Change-Id: I3fe1b9661c82ff789969987ddc18d7687fd41107
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1274

5 years agoadded test file to cover Resources.java 94/77694/1
Sandeep J [Fri, 1 Feb 2019 07:39:27 +0000 (13:09 +0530)]
added test file to cover Resources.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: I65861398bb166baa8691034a17ecb7da248bbca9
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoParameters - Junit Test case added 35/77635/2
Sudarshan Kumar [Thu, 31 Jan 2019 08:04:36 +0000 (13:34 +0530)]
Parameters - Junit Test case added

Parameters - Junit Test case added

Issue-ID: APPC-1372
Change-Id: I04aa72f49066b214f8294bf7592b203f4d10479c
Signed-off-by: Sudarshan Kumar <sudars19@in.ibm.com>
5 years agoadded test file to cover Resources_.java 34/77634/2
Sandeep J [Thu, 31 Jan 2019 07:59:01 +0000 (13:29 +0530)]
added test file to cover Resources_.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: I9bc51094d3588adbe50089bf85f6f04cf05f99fd
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded test file to cover Resources__.java 32/77632/2
Sandeep J [Thu, 31 Jan 2019 07:50:24 +0000 (13:20 +0530)]
added test file to cover Resources__.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: I3fedafa767942bb6427407d65b2eaf2cff4fd88f
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoMetadata - Junit Test Case Added 33/77633/2
Sudarshan Kumar [Thu, 31 Jan 2019 07:56:03 +0000 (13:26 +0530)]
Metadata - Junit Test Case Added

Metadata - Junit Test Case Added

Issue-ID: APPC-1372
Change-Id: Iaaefd6161a7657f7997ce0e90558f75866ec006b
Signed-off-by: Sudarshan Kumar <sudars19@in.ibm.com>
5 years agoadded test file for ResourceRegistry.java 31/77631/2
Sandeep J [Thu, 31 Jan 2019 07:40:40 +0000 (13:10 +0530)]
added test file for ResourceRegistry.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: Ifa3e0fc4f01293f31ba9ede6cbf6c545da318863
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadd one note in release note 19/77619/2
Taka Cho [Thu, 31 Jan 2019 02:08:59 +0000 (21:08 -0500)]
add one note in release note

A note is added for R3 Mtn release

Change-Id: I58b435d279601cf90b951b12b7fdc2e2397676b1
Issue-ID: APPC-1375
Signed-off-by: Taka Cho <takamune.cho@att.com>
5 years agoremove the old python files 01/77601/3
Taka Cho [Wed, 30 Jan 2019 19:33:29 +0000 (14:33 -0500)]
remove the old python files

Since ansible container build moved to
CCSDK/distribution/ansible_server, the files under
this directory will be removed

Change-Id: Iac2303c3430e2952d59732960a7462f6253a0ecc
Issue-ID: CCSDK-1009
Signed-off-by: Taka Cho <takamune.cho@att.com>
5 years agoData-Junit Test Case Added 60/77560/4
Sudarshan Kumar [Wed, 30 Jan 2019 07:45:51 +0000 (13:15 +0530)]
Data-Junit Test Case Added

Data-Junit Test Case Added

Issue-ID: APPC-1372
Change-Id: Ib0a8c0c66d23bedd213df17d517c10add0ee18a9
Signed-off-by: Sudarshan Kumar <sudars19@in.ibm.com>
5 years agoEnvironment-Junit Test Case Added 57/77557/3
Sudarshan Kumar [Wed, 30 Jan 2019 07:00:37 +0000 (12:30 +0530)]
Environment-Junit Test Case Added

Environment-Junit Test Case Added

Issue-ID: APPC-1372
Change-Id: I571f2417eb69e5d7c3ec451ef0b778eb79dde92e
Signed-off-by: Sudarshan Kumar <sudars19@in.ibm.com>
5 years agoMultiple Sonar Fixes 11/76111/3
Driptaroop Das [Tue, 22 Jan 2019 09:47:52 +0000 (15:17 +0530)]
Multiple Sonar Fixes

Multiple Sonar Fixes

Issue-ID: APPC-1353
Change-Id: I5bdf2119e886a58606bf6192b97c9ae43e4e0069
Signed-off-by: Driptaroop Das <driptaroop.das@in.ibm.com>
5 years agoTest coverage in aai-client-provider 79/77579/5
Joss Armstrong [Wed, 30 Jan 2019 13:51:13 +0000 (13:51 +0000)]
Test coverage in aai-client-provider

Increase coverage to 91%

Issue-ID: APPC-1373
Change-Id: I5de0f532a50bbcd1bf5c305d758a6d1fd95fa3c1
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agoadded test file to cover AaiVnfInfo.java 99/77499/4
Sandeep J [Wed, 30 Jan 2019 10:17:18 +0000 (15:47 +0530)]
added test file to cover AaiVnfInfo.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: Iafee5909c1ab1a10ff031563dd9502e09cfe11a4
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded test file to cover AaiVmInfo.java 97/77497/4
Sandeep J [Tue, 29 Jan 2019 09:03:13 +0000 (14:33 +0530)]
added test file to cover AaiVmInfo.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: Ia2ac99d527475e3612296d42c0ebe5fc8cc16c04
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded test file for AaiVnfcInfo.java 61/77561/1
Sandeep J [Wed, 30 Jan 2019 08:02:03 +0000 (13:32 +0530)]
added test file for AaiVnfcInfo.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: I52f403259d7c8e2d7222f5e4769751cd4907b279
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded test case to TestDGGeneralDBService 96/77496/1
Sandeep J [Tue, 29 Jan 2019 08:40:53 +0000 (14:10 +0530)]
added test case to TestDGGeneralDBService

to increase code coverage

Issue-ID: APPC-1086
Change-Id: I1e1d12fd230ea45b3618e41a7416a35cbf64fe0c
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoUpdated: Repeated sentence removed 36/76336/2
Manish Kumar [Fri, 25 Jan 2019 06:57:20 +0000 (12:27 +0530)]
Updated: Repeated sentence removed

Issue-ID: DOC-389

Change-Id: I9f28ff81c69b9184414d7a6a8dce158701af8060
Signed-off-by: Manish Kumar <manishjpiet@gmail.com>
5 years agoadded mockito version to pom file 53/76253/4
Sandeep J [Thu, 24 Jan 2019 07:40:12 +0000 (13:10 +0530)]
added mockito version to pom file

added missing mockito version

Issue-ID: APPC-1360
Change-Id: Ice6d69aaa496437f815477aca372f6f8beb46fd9
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoFix ServiceExecutorImpl 23/76223/3
Joss Armstrong [Wed, 23 Jan 2019 18:17:31 +0000 (18:17 +0000)]
Fix ServiceExecutorImpl

Code change to fix handling of vserver-id

Issue-ID: APPC-1358
Change-Id: I463fceda2321b5006100b12644708d22fe25a04e
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agoadded test case to TestDGGeneralDBService.java 63/76263/2
Sandeep J [Thu, 24 Jan 2019 09:24:06 +0000 (14:54 +0530)]
added test case to TestDGGeneralDBService.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: Icc459b97d2b15e204c3002a237752af9fe34cb20
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoTest coverage for sdc-listener-bundle 94/76194/9
Lathishbabu Ganesan [Wed, 23 Jan 2019 11:37:41 +0000 (06:37 -0500)]
Test coverage for sdc-listener-bundle

Increased from 41.9% to 71%

Issue-ID: APPC-1325
Change-Id: I33c336a2fff30422e436c26226519332a0a8b55c
Signed-off-by: Lathishbabu Ganesan <lathishbabu.ganesan@ericsson.com>
5 years agoadd R3 Mtn Release in release doc. 21/76221/2
Taka Cho [Wed, 23 Jan 2019 18:10:49 +0000 (13:10 -0500)]
add R3 Mtn Release in release doc.

added bug fixes items for R3
Maintenance Release document

Change-Id: I4eccf6717c28b5f6727cfdd67eca17bffc1e2ceb
Issue-ID: APPC-1356
Signed-off-by: Taka Cho <takamune.cho@att.com>
5 years agoadded test case to SeqnceGeneratorInputBuilderTest 08/76208/2
Sandeep J [Wed, 23 Jan 2019 16:41:29 +0000 (22:11 +0530)]
added test case to SeqnceGeneratorInputBuilderTest

to increase code coverage

Issue-ID: APPC-1086
Change-Id: I92d70ffe615bb0116d5928cda954b287ea807b99
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoTest coverage in appc-interfaces-services package 01/76201/2
Joss Armstrong [Wed, 23 Jan 2019 15:09:18 +0000 (15:09 +0000)]
Test coverage in appc-interfaces-services package

Increased coverage from 0% to 100%

Issue-ID: APPC-1354
Change-Id: Ifb8478104af432b5baf11d21e66f490dcd70b5a9
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agoTest coverage in interface-services-executorImpl 96/76196/1
Joss Armstrong [Wed, 23 Jan 2019 12:38:05 +0000 (12:38 +0000)]
Test coverage in interface-services-executorImpl

Increased coverage from 39% to 93%

Issue-ID: APPC-1354
Change-Id: I372be6e61e6041dbf81607d4386fc5123fa5ee79
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agoTest coverage in artifact-handler-utils package 45/76145/4
Joss Armstrong [Tue, 22 Jan 2019 17:45:41 +0000 (17:45 +0000)]
Test coverage in artifact-handler-utils package

Increased coverage from 21% to 91%

Issue-ID: APPC-1335
Change-Id: Ib0ed16e6e0ef01c83666491644564d1c6f341160
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agoIncrease coverage in artifact-handler-node package 30/76130/4
Joss Armstrong [Tue, 22 Jan 2019 14:16:57 +0000 (14:16 +0000)]
Increase coverage in artifact-handler-node package

Increased coverage from 56% to 93%

Issue-ID: APPC-1335
Change-Id: I65ed7979141a035444ff45e7540d7fb022d24355
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agoCoverage for appc-artifact-handler package 92/76092/2
Joss Armstrong [Mon, 21 Jan 2019 20:29:19 +0000 (20:29 +0000)]
Coverage for appc-artifact-handler package

Increased coverage from 0% to 95%

Issue-ID: APPC-1335
Change-Id: I3c2e1f22009c47cda983e61eda7e98c48564ee98
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agoAdded Junit test file for RequestInfo.java 22/75622/3
ezhil [Thu, 10 Jan 2019 13:50:16 +0000 (19:20 +0530)]
Added Junit test file for RequestInfo.java

Change-Id: I715d86976b1a328ce463701add3967a559ae1b7e
Issue-ID: APPC-1320
Signed-off-by: ezhil <ezhrajam@in.ibm.com>
5 years agoCorrect unit tests for DBService class 65/76065/3
Joss Armstrong [Mon, 21 Jan 2019 13:02:33 +0000 (13:02 +0000)]
Correct unit tests for DBService class

Increased test coverage from 74% to 92%
in DBService class

Issue-ID: APPC-1335
Change-Id: Iabd792eb104429d5090e0099dba463e8ad6d499a
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agoNetwork Inventory Cient Platform Hardening 33/76033/4
Balaji, Ramya (rb111y) [Sun, 20 Jan 2019 02:28:38 +0000 (21:28 -0500)]
Network Inventory Cient Platform Hardening

Renamed class files to be more meaningful
and synched up directories

Issue-ID: APPC-1338
Change-Id: I5eee7c96013e8733fb14e4b0a1de88d4c9611a0f
Signed-off-by: Balaji, Ramya (rb111y) <rb111y@att.com>
5 years agoUpdate install-feature for pre-install 09/76009/3
Patrick Brady [Fri, 18 Jan 2019 20:28:08 +0000 (12:28 -0800)]
Update install-feature for pre-install

Since the feature zip files will be extracted during docker build,
the install-features scripts need to be modified so that the script
will not fail when the zip file does not exist, since the zip file
will have already been unzipped.

Change-Id: I441064226db956addae5c2f238114ce3965c13ef
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1337

5 years agoadd new committter Joss Armstrong 64/75964/3
Taka Cho [Thu, 17 Jan 2019 22:07:04 +0000 (17:07 -0500)]
add new committter Joss Armstrong

Modify INFO.yaml for new committer

Change-Id: Ibdee209785944ad5ae4f8c497df483b6b993a782
Issue-ID: APPC-1333
Signed-off-by: Taka Cho <takamune.cho@att.com>
5 years agoadded test case to TestDGGeneralDBService 73/75973/2
Sandeep J [Fri, 18 Jan 2019 07:54:42 +0000 (13:24 +0530)]
added test case to TestDGGeneralDBService

to increase code coverage

Issue-ID: APPC-1086
Change-Id: I2e5908c7f4728ff9cd33d11ddf6b398c0a472bdd
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agomade changes to existing test case 82/75882/7
Sandeep J [Wed, 16 Jan 2019 15:58:31 +0000 (21:28 +0530)]
made changes to existing test case

to increase code coverage

Issue-ID: APPC-1086
Change-Id: I521d6770ee383d78a005bd9ce8c77c6682e14678
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded test file for SequenceGeneratorInputBuilder 23/75923/4
Sandeep J [Thu, 17 Jan 2019 09:56:30 +0000 (15:26 +0530)]
added test file for SequenceGeneratorInputBuilder

to increase code coverage

Issue-ID: APPC-1086
Change-Id: Ibebd0df80d998c596aa1b5e06950898a735d2256
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded test cases to ConfigComponentAdaptorTest 29/75929/3
Sandeep J [Thu, 17 Jan 2019 10:55:05 +0000 (16:25 +0530)]
added test cases to ConfigComponentAdaptorTest

to increase code coverage

Issue-ID: APPC-1086
Change-Id: I41734fcfc86da21114daacedaab02fbb2de86504
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoFix intermittent time based test failures 26/75926/3
Joss Armstrong [Thu, 17 Jan 2019 10:21:13 +0000 (10:21 +0000)]
Fix intermittent time based test failures

Fix bug in test code causing intermittent failure
and tidy up test code in package

Issue-ID: APPC-1331
Change-Id: Ic03b189a797ed6b88c868ec21c79ef037224fcb7
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agoFix unit tests for appc-command-executor-core 19/75919/6
Joss Armstrong [Thu, 17 Jan 2019 08:08:00 +0000 (08:08 +0000)]
Fix unit tests for appc-command-executor-core

Increase line coverage of package from 43% to 93%

Issue-ID: APPC-1329
Change-Id: I0a4e2a0a85f6761becde4a74609358267530d92d
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agoTest coverage for appc-workflow-management-core 36/75936/3
Joss Armstrong [Thu, 17 Jan 2019 12:52:30 +0000 (12:52 +0000)]
Test coverage for appc-workflow-management-core

Increase test coverage from 2% to 73%

Issue-ID: APPC-1332
Change-Id: I41567d3b5108581bbdce95671366a57323c7b1a4
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agoAdded junit test file for ResponseTest.java 70/75570/5
ezhil [Wed, 9 Jan 2019 16:34:04 +0000 (22:04 +0530)]
Added junit test file for ResponseTest.java

Change-Id: I89a6669bb6ce209e0f01b616530b87ee2048f3f3
Issue-ID: APPC-1316
Signed-off-by: ezhil <ezhrajam@in.ibm.com>
5 years agoadded test case to ConfigResourceNode.java 80/75880/4
Sandeep J [Wed, 16 Jan 2019 15:46:49 +0000 (21:16 +0530)]
added test case to ConfigResourceNode.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: I3d49e11a910b42a9e0ec17768a79c43dfc018c34
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded test cases to TestDGGeneralDBService 79/75879/4
Sandeep J [Wed, 16 Jan 2019 15:27:52 +0000 (20:57 +0530)]
added test cases to TestDGGeneralDBService

to increase code coverage

Issue-ID: APPC-1086
Change-Id: I5c765135fad3720818d76a87b7ebe1691dc39155
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoRemove deprecated mock implementations of LCM 59/75859/1
Joss Armstrong [Wed, 16 Jan 2019 09:55:37 +0000 (09:55 +0000)]
Remove deprecated mock implementations of LCM

Removal of deprecated code

Issue-ID: APPC-1328
Change-Id: I075ed20b648b78c51cbfcb123958340ab379ac09
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agoFix unit tests in provider-lcm-service 03/75703/4
Joss Armstrong [Fri, 11 Jan 2019 22:33:49 +0000 (22:33 +0000)]
Fix unit tests in provider-lcm-service

Increased line coverage from 69% to 87%
Removed PrepareForTest annotations for classes under test

Issue-ID: APPC-1326
Change-Id: I75be7235f4c13b0f395843907958d7391a333a32
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agoFix VM Snapshot error during image validation 40/75740/2
Joss Armstrong [Mon, 14 Jan 2019 12:24:00 +0000 (12:24 +0000)]
Fix VM Snapshot error during image validation

prefix image name with 'in:' and surround with quotes
to deal with change to Glance that no longer supports
image names including colons passed as plain strings

Issue-ID: APPC-869
Change-Id: If81accc3edd7b4805eb965b11f466df9654d6010
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agoFixed sonar issue in ProviderAdapterImpl 90/75190/5
ezhil [Wed, 2 Jan 2019 16:05:26 +0000 (21:35 +0530)]
Fixed sonar issue in ProviderAdapterImpl

Change-Id: I0a2e6f4ad94ad3c172ca15b0111892d38b188a55
Issue-ID: APPC-1299
Signed-off-by: ezhil <ezhrajam@in.ibm.com>