Test coverage in artifact-handler-utils package

Increased coverage from 21% to 91%

Issue-ID: APPC-1335
Change-Id: Ib0ed16e6e0ef01c83666491644564d1c6f341160
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>

diff --git a/appc-inbound/appc-artifact-handler/provider/src/test/java/org/onap/appc/artifact/handler/utils/ArtifactHandlerProviderUtilTest.java b/appc-inbound/appc-artifact-handler/provider/src/test/java/org/onap/appc/artifact/handler/utils/ArtifactHandlerProviderUtilTest.java
index dc55bb6..552d811 100644 (file)
--- a/appc-inbound/appc-artifact-handler/provider/src/test/java/org/onap/appc/artifact/handler/utils/ArtifactHandlerProviderUtilTest.java
+++ b/appc-inbound/appc-artifact-handler/provider/src/test/java/org/onap/appc/artifact/handler/utils/ArtifactHandlerProviderUtilTest.java
@@ -5,6 +5,8 @@
  * Copyright (C) 2017-2018 AT&T Intellectual Property. All rights reserved.
  * ================================================================================
  * Copyright (C) 2017 Amdocs
+ * ================================================================================
+ * Modifications Copyright (C) 2019 Ericsson
  * =============================================================================
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -23,11 +25,20 @@
 
 package org.onap.appc.artifact.handler.utils;
 
+import static org.junit.Assert.assertNull;
 import static org.junit.Assert.assertTrue;
+import java.io.IOException;
 import java.nio.charset.Charset;
 import org.apache.commons.io.IOUtils;
 import org.json.JSONObject;
 import org.junit.Test;
+import org.junit.Ignore;
+import org.mockito.Mockito;
+import org.opendaylight.yang.gen.v1.org.onap.appc.artifacthandler.rev170321.UploadartifactInput;
+import org.opendaylight.yang.gen.v1.org.onap.appc.artifacthandler.rev170321.UploadartifactInputBuilder;
+import org.opendaylight.yang.gen.v1.org.onap.appc.artifacthandler.rev170321.UploadartifactOutput;
+import org.opendaylight.yang.gen.v1.org.onap.appc.artifacthandler.rev170321.document.parameters.DocumentParameters;
+import org.opendaylight.yang.gen.v1.org.onap.appc.artifacthandler.rev170321.request.information.RequestInformation;
 import org.powermock.reflect.Whitebox;
 
 public class ArtifactHandlerProviderUtilTest {
@@ -44,6 +55,7 @@ public class ArtifactHandlerProviderUtilTest {
         ahprovider.processTemplate(obj.toString());
     }
 
+    @Ignore
     @Test(expected = Exception.class)
     public void testcreateDummyRequestData() throws Exception {
         String artifact_conetent = IOUtils.toString(ArtifactHandlerProviderUtilTest.class.getClassLoader()
@@ -77,5 +89,49 @@ public class ArtifactHandlerProviderUtilTest {
         EscapeUtils.escapeSql(str);
         assertTrue(true);
     }
+
+    @Test
+    public void testEscapeUtilsNull() throws Exception {
+        String str = null;
+        assertNull(EscapeUtils.escapeSql(str));
+    }
+
+    @Test
+    public void testDummyData() throws IOException {
+        String artifactContent = IOUtils.toString(ArtifactHandlerProviderUtilTest.class.getClassLoader()
+                .getResourceAsStream("templates/reference_template.json"), Charset.defaultCharset());
+        ArtifactHandlerProviderUtil ahprovider = Mockito.spy(new ArtifactHandlerProviderUtil());
+        UploadartifactInputBuilder builder = new UploadartifactInputBuilder();
+        DocumentParameters mockDocumentParameters = Mockito.mock(DocumentParameters.class);
+        Mockito.doReturn(artifactContent).when(mockDocumentParameters).getArtifactContents();
+        Mockito.doReturn("ARTIFACT NAME").when(mockDocumentParameters).getArtifactName();
+        builder.setDocumentParameters(mockDocumentParameters);
+        RequestInformation mockRequestInformation = Mockito.mock(RequestInformation.class);
+        Mockito.doReturn("REQUEST ID").when(mockRequestInformation).getRequestId();
+        Mockito.doReturn(SdcArtifactHandlerConstants.DESIGN_TOOL).when(mockRequestInformation).getSource();
+        builder.setRequestInformation(mockRequestInformation);
+        UploadartifactInput uploadArtifactInput = builder.build();
+        Whitebox.setInternalState(ahprovider, "templateData", uploadArtifactInput);
+        assertTrue(ahprovider.createDummyRequestData().startsWith("{\"input\": {\"document-parameters\":{\"service-uuid\":\"TLSUUIDREQUEST ID\""));
+    }
+
+    @Test
+    public void testRequestData() throws IOException {
+        String artifactContent = IOUtils.toString(ArtifactHandlerProviderUtilTest.class.getClassLoader()
+                .getResourceAsStream("templates/reference_template.json"), Charset.defaultCharset());
+        ArtifactHandlerProviderUtil ahprovider = Mockito.spy(new ArtifactHandlerProviderUtil());
+        UploadartifactInputBuilder builder = new UploadartifactInputBuilder();
+        DocumentParameters mockDocumentParameters = Mockito.mock(DocumentParameters.class);
+        Mockito.doReturn(artifactContent).when(mockDocumentParameters).getArtifactContents();
+        Mockito.doReturn("ARTIFACT NAME").when(mockDocumentParameters).getArtifactName();
+        builder.setDocumentParameters(mockDocumentParameters);
+        RequestInformation mockRequestInformation = Mockito.mock(RequestInformation.class);
+        Mockito.doReturn("REQUEST ID").when(mockRequestInformation).getRequestId();
+        Mockito.doReturn(SdcArtifactHandlerConstants.DESIGN_TOOL).when(mockRequestInformation).getSource();
+        builder.setRequestInformation(mockRequestInformation);
+        UploadartifactInput uploadArtifactInput = builder.build();
+        Whitebox.setInternalState(ahprovider, "templateData", uploadArtifactInput);
+        assertTrue(ahprovider.createDummyRequestData().startsWith("{\"input\": {\"document-parameters\":{\"service-uuid\":\"TLSUUIDREQUEST ID\""));
+    }
 }