Balaji, Ramya (rb111y) [Mon, 4 Feb 2019 12:57:11 +0000 (07:57 -0500)]
Sdc Listener Platform hardening changes
Issue-ID: APPC-1382
Change-Id: Ib4928843a8f169d856aaa1afa49fcfa127ba4990
Signed-off-by: Balaji, Ramya (rb111y) <rb111y@att.com>
Sudarshan Kumar [Tue, 5 Feb 2019 09:42:25 +0000 (15:12 +0530)]
Added Junit class for ProtocolException.java
Added Junit class for ProtocolException.java
Issue-ID: APPC-1372
Change-Id: I695c7dca1cf92c2aa9354c6738042b20f949a215
Signed-off-by: Sudarshan Kumar <sudars19@in.ibm.com>
Sandeep J [Tue, 5 Feb 2019 08:13:51 +0000 (13:43 +0530)]
added test case to TestSshConnectionMock.java
to increase code coverage
Issue-ID: APPC-1086
Change-Id: Icbfd25c82b28783ea2afb7c6cd0411d72f6db12b
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
Sandeep J [Tue, 5 Feb 2019 09:08:08 +0000 (14:38 +0530)]
added test file to cover TemplateException.java
to increase code coverage
Issue-ID: APPC-1086
Change-Id: I21877b15110502d75b05fa57eb179fb462e1e755
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
Joss Armstrong [Tue, 5 Feb 2019 12:16:19 +0000 (12:16 +0000)]
Test coverage in netconf-oldconnector
Increased coverage from 0% to 92% for package
Issue-ID: APPC-1388
Change-Id: I9f332f799f67937a40c09bdf724701ef80bbad89
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
Sandeep J [Fri, 1 Feb 2019 07:45:16 +0000 (13:15 +0530)]
added test case to TestSnapShot.java
to increase code coverage
Issue-ID: APPC-1086
Change-Id: Iecc9f217c7f230311daf14ba49e3106ce31d017a
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
Sandeep J [Fri, 1 Feb 2019 07:51:29 +0000 (13:21 +0530)]
added test case to TestTemplate.java
to increase code coverage
Issue-ID: APPC-1086
Change-Id: Ie6fdd33aab4ef6f0395d98375a26e83c750a06ce
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
Sandeep J [Mon, 4 Feb 2019 10:37:13 +0000 (16:07 +0530)]
added test file to cover VnfType.java
to increase code coverage
Issue-ID: APPC-1086
Change-Id: Ia85fd2a0fab0de8b5fbf770ce58b4f308a1e5d74
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
Sandeep J [Mon, 4 Feb 2019 10:55:32 +0000 (16:25 +0530)]
modified existing test case to increase coverage
to increase code coverage
Issue-ID: APPC-1086
Change-Id: Ic028f65e2d62529a91de069050aec11db09b6014
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
Joss Armstrong [Fri, 1 Feb 2019 12:44:39 +0000 (12:44 +0000)]
Add test coverage for AttachVolumeServer
New test file to cover success flow in class
Issue-ID: APPC-1374
Change-Id: I576f523225e5ac427b972e78a8392496a71b6bfa
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
Joss Armstrong [Fri, 1 Feb 2019 14:49:12 +0000 (14:49 +0000)]
Test coverage for DetachVolumeServer
Added new test file for untested class
Issue-ID: APPC-1374
Change-Id: I334d53df87efb6a25a6f76a1660dd43c98d143b3
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
Joss Armstrong [Fri, 1 Feb 2019 15:26:27 +0000 (15:26 +0000)]
Test coverage for SnapshotStack
Added new test file for untested class
Issue-ID: APPC-1374
Change-Id: I6323eb60df3f0966bfa78291ffb3d1b277399ef2
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
Joss Armstrong [Fri, 1 Feb 2019 17:00:51 +0000 (17:00 +0000)]
Test coverage for RestoreStack
Added new test file for untested class
Issue-ID: APPC-1374
Change-Id: Ie180b5a8f10aaa8aa7ea8b83b403a2eab1885818
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
Patrick Brady [Fri, 1 Feb 2019 20:18:10 +0000 (12:18 -0800)]
Update rest return parameters
Change-Id: If5d860a37a87ac0feb6452173cf147bbafa079b3
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1381
Patrick Brady [Fri, 1 Feb 2019 19:00:49 +0000 (11:00 -0800)]
Docs add restconf use instructions
Add usage instructions for rest adapter to the
user guide.
Change-Id: I3fe1b9661c82ff789969987ddc18d7687fd41107
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1274
Sandeep J [Fri, 1 Feb 2019 07:39:27 +0000 (13:09 +0530)]
added test file to cover Resources.java
to increase code coverage
Issue-ID: APPC-1086
Change-Id: I65861398bb166baa8691034a17ecb7da248bbca9
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
Sudarshan Kumar [Thu, 31 Jan 2019 08:04:36 +0000 (13:34 +0530)]
Parameters - Junit Test case added
Parameters - Junit Test case added
Issue-ID: APPC-1372
Change-Id: I04aa72f49066b214f8294bf7592b203f4d10479c
Signed-off-by: Sudarshan Kumar <sudars19@in.ibm.com>
Sandeep J [Thu, 31 Jan 2019 07:59:01 +0000 (13:29 +0530)]
added test file to cover Resources_.java
to increase code coverage
Issue-ID: APPC-1086
Change-Id: I9bc51094d3588adbe50089bf85f6f04cf05f99fd
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
Sandeep J [Thu, 31 Jan 2019 07:50:24 +0000 (13:20 +0530)]
added test file to cover Resources__.java
to increase code coverage
Issue-ID: APPC-1086
Change-Id: I3fedafa767942bb6427407d65b2eaf2cff4fd88f
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
Sudarshan Kumar [Thu, 31 Jan 2019 07:56:03 +0000 (13:26 +0530)]
Metadata - Junit Test Case Added
Metadata - Junit Test Case Added
Issue-ID: APPC-1372
Change-Id: Iaaefd6161a7657f7997ce0e90558f75866ec006b
Signed-off-by: Sudarshan Kumar <sudars19@in.ibm.com>
Sandeep J [Thu, 31 Jan 2019 07:40:40 +0000 (13:10 +0530)]
added test file for ResourceRegistry.java
to increase code coverage
Issue-ID: APPC-1086
Change-Id: Ifa3e0fc4f01293f31ba9ede6cbf6c545da318863
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
Taka Cho [Thu, 31 Jan 2019 02:08:59 +0000 (21:08 -0500)]
add one note in release note
A note is added for R3 Mtn release
Change-Id: I58b435d279601cf90b951b12b7fdc2e2397676b1
Issue-ID: APPC-1375
Signed-off-by: Taka Cho <takamune.cho@att.com>
Taka Cho [Wed, 30 Jan 2019 19:33:29 +0000 (14:33 -0500)]
remove the old python files
Since ansible container build moved to
CCSDK/distribution/ansible_server, the files under
this directory will be removed
Change-Id: Iac2303c3430e2952d59732960a7462f6253a0ecc
Issue-ID: CCSDK-1009
Signed-off-by: Taka Cho <takamune.cho@att.com>
Sudarshan Kumar [Wed, 30 Jan 2019 07:45:51 +0000 (13:15 +0530)]
Data-Junit Test Case Added
Data-Junit Test Case Added
Issue-ID: APPC-1372
Change-Id: Ib0a8c0c66d23bedd213df17d517c10add0ee18a9
Signed-off-by: Sudarshan Kumar <sudars19@in.ibm.com>
Sudarshan Kumar [Wed, 30 Jan 2019 07:00:37 +0000 (12:30 +0530)]
Environment-Junit Test Case Added
Environment-Junit Test Case Added
Issue-ID: APPC-1372
Change-Id: I571f2417eb69e5d7c3ec451ef0b778eb79dde92e
Signed-off-by: Sudarshan Kumar <sudars19@in.ibm.com>
Driptaroop Das [Tue, 22 Jan 2019 09:47:52 +0000 (15:17 +0530)]
Multiple Sonar Fixes
Multiple Sonar Fixes
Issue-ID: APPC-1353
Change-Id: I5bdf2119e886a58606bf6192b97c9ae43e4e0069
Signed-off-by: Driptaroop Das <driptaroop.das@in.ibm.com>
Joss Armstrong [Wed, 30 Jan 2019 13:51:13 +0000 (13:51 +0000)]
Test coverage in aai-client-provider
Increase coverage to 91%
Issue-ID: APPC-1373
Change-Id: I5de0f532a50bbcd1bf5c305d758a6d1fd95fa3c1
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
Sandeep J [Wed, 30 Jan 2019 10:17:18 +0000 (15:47 +0530)]
added test file to cover AaiVnfInfo.java
to increase code coverage
Issue-ID: APPC-1086
Change-Id: Iafee5909c1ab1a10ff031563dd9502e09cfe11a4
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
Sandeep J [Tue, 29 Jan 2019 09:03:13 +0000 (14:33 +0530)]
added test file to cover AaiVmInfo.java
to increase code coverage
Issue-ID: APPC-1086
Change-Id: Ia2ac99d527475e3612296d42c0ebe5fc8cc16c04
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
Sandeep J [Wed, 30 Jan 2019 08:02:03 +0000 (13:32 +0530)]
added test file for AaiVnfcInfo.java
to increase code coverage
Issue-ID: APPC-1086
Change-Id: I52f403259d7c8e2d7222f5e4769751cd4907b279
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
Sandeep J [Tue, 29 Jan 2019 08:40:53 +0000 (14:10 +0530)]
added test case to TestDGGeneralDBService
to increase code coverage
Issue-ID: APPC-1086
Change-Id: I1e1d12fd230ea45b3618e41a7416a35cbf64fe0c
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
Manish Kumar [Fri, 25 Jan 2019 06:57:20 +0000 (12:27 +0530)]
Updated: Repeated sentence removed
Issue-ID: DOC-389
Change-Id: I9f28ff81c69b9184414d7a6a8dce158701af8060
Signed-off-by: Manish Kumar <manishjpiet@gmail.com>
Sandeep J [Thu, 24 Jan 2019 07:40:12 +0000 (13:10 +0530)]
added mockito version to pom file
added missing mockito version
Issue-ID: APPC-1360
Change-Id: Ice6d69aaa496437f815477aca372f6f8beb46fd9
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
Joss Armstrong [Wed, 23 Jan 2019 18:17:31 +0000 (18:17 +0000)]
Fix ServiceExecutorImpl
Code change to fix handling of vserver-id
Issue-ID: APPC-1358
Change-Id: I463fceda2321b5006100b12644708d22fe25a04e
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
Sandeep J [Thu, 24 Jan 2019 09:24:06 +0000 (14:54 +0530)]
added test case to TestDGGeneralDBService.java
to increase code coverage
Issue-ID: APPC-1086
Change-Id: Icc459b97d2b15e204c3002a237752af9fe34cb20
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
Lathishbabu Ganesan [Wed, 23 Jan 2019 11:37:41 +0000 (06:37 -0500)]
Test coverage for sdc-listener-bundle
Increased from 41.9% to 71%
Issue-ID: APPC-1325
Change-Id: I33c336a2fff30422e436c26226519332a0a8b55c
Signed-off-by: Lathishbabu Ganesan <lathishbabu.ganesan@ericsson.com>
Taka Cho [Wed, 23 Jan 2019 18:10:49 +0000 (13:10 -0500)]
add R3 Mtn Release in release doc.
added bug fixes items for R3
Maintenance Release document
Change-Id: I4eccf6717c28b5f6727cfdd67eca17bffc1e2ceb
Issue-ID: APPC-1356
Signed-off-by: Taka Cho <takamune.cho@att.com>
Sandeep J [Wed, 23 Jan 2019 16:41:29 +0000 (22:11 +0530)]
added test case to SeqnceGeneratorInputBuilderTest
to increase code coverage
Issue-ID: APPC-1086
Change-Id: I92d70ffe615bb0116d5928cda954b287ea807b99
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
Joss Armstrong [Wed, 23 Jan 2019 15:09:18 +0000 (15:09 +0000)]
Test coverage in appc-interfaces-services package
Increased coverage from 0% to 100%
Issue-ID: APPC-1354
Change-Id: Ifb8478104af432b5baf11d21e66f490dcd70b5a9
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
Joss Armstrong [Wed, 23 Jan 2019 12:38:05 +0000 (12:38 +0000)]
Test coverage in interface-services-executorImpl
Increased coverage from 39% to 93%
Issue-ID: APPC-1354
Change-Id: I372be6e61e6041dbf81607d4386fc5123fa5ee79
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
Joss Armstrong [Tue, 22 Jan 2019 17:45:41 +0000 (17:45 +0000)]
Test coverage in artifact-handler-utils package
Increased coverage from 21% to 91%
Issue-ID: APPC-1335
Change-Id: Ib0ed16e6e0ef01c83666491644564d1c6f341160
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
Joss Armstrong [Tue, 22 Jan 2019 14:16:57 +0000 (14:16 +0000)]
Increase coverage in artifact-handler-node package
Increased coverage from 56% to 93%
Issue-ID: APPC-1335
Change-Id: I65ed7979141a035444ff45e7540d7fb022d24355
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
Joss Armstrong [Mon, 21 Jan 2019 20:29:19 +0000 (20:29 +0000)]
Coverage for appc-artifact-handler package
Increased coverage from 0% to 95%
Issue-ID: APPC-1335
Change-Id: I3c2e1f22009c47cda983e61eda7e98c48564ee98
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
ezhil [Thu, 10 Jan 2019 13:50:16 +0000 (19:20 +0530)]
Added Junit test file for RequestInfo.java
Change-Id: I715d86976b1a328ce463701add3967a559ae1b7e
Issue-ID: APPC-1320
Signed-off-by: ezhil <ezhrajam@in.ibm.com>
Joss Armstrong [Mon, 21 Jan 2019 13:02:33 +0000 (13:02 +0000)]
Correct unit tests for DBService class
Increased test coverage from 74% to 92%
in DBService class
Issue-ID: APPC-1335
Change-Id: Iabd792eb104429d5090e0099dba463e8ad6d499a
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
Balaji, Ramya (rb111y) [Sun, 20 Jan 2019 02:28:38 +0000 (21:28 -0500)]
Network Inventory Cient Platform Hardening
Renamed class files to be more meaningful
and synched up directories
Issue-ID: APPC-1338
Change-Id: I5eee7c96013e8733fb14e4b0a1de88d4c9611a0f
Signed-off-by: Balaji, Ramya (rb111y) <rb111y@att.com>
Patrick Brady [Fri, 18 Jan 2019 20:28:08 +0000 (12:28 -0800)]
Update install-feature for pre-install
Since the feature zip files will be extracted during docker build,
the install-features scripts need to be modified so that the script
will not fail when the zip file does not exist, since the zip file
will have already been unzipped.
Change-Id: I441064226db956addae5c2f238114ce3965c13ef
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1337
Taka Cho [Thu, 17 Jan 2019 22:07:04 +0000 (17:07 -0500)]
add new committter Joss Armstrong
Modify INFO.yaml for new committer
Change-Id: Ibdee209785944ad5ae4f8c497df483b6b993a782
Issue-ID: APPC-1333
Signed-off-by: Taka Cho <takamune.cho@att.com>
Sandeep J [Fri, 18 Jan 2019 07:54:42 +0000 (13:24 +0530)]
added test case to TestDGGeneralDBService
to increase code coverage
Issue-ID: APPC-1086
Change-Id: I2e5908c7f4728ff9cd33d11ddf6b398c0a472bdd
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
Sandeep J [Wed, 16 Jan 2019 15:58:31 +0000 (21:28 +0530)]
made changes to existing test case
to increase code coverage
Issue-ID: APPC-1086
Change-Id: I521d6770ee383d78a005bd9ce8c77c6682e14678
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
Sandeep J [Thu, 17 Jan 2019 09:56:30 +0000 (15:26 +0530)]
added test file for SequenceGeneratorInputBuilder
to increase code coverage
Issue-ID: APPC-1086
Change-Id: Ibebd0df80d998c596aa1b5e06950898a735d2256
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
Sandeep J [Thu, 17 Jan 2019 10:55:05 +0000 (16:25 +0530)]
added test cases to ConfigComponentAdaptorTest
to increase code coverage
Issue-ID: APPC-1086
Change-Id: I41734fcfc86da21114daacedaab02fbb2de86504
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
Joss Armstrong [Thu, 17 Jan 2019 10:21:13 +0000 (10:21 +0000)]
Fix intermittent time based test failures
Fix bug in test code causing intermittent failure
and tidy up test code in package
Issue-ID: APPC-1331
Change-Id: Ic03b189a797ed6b88c868ec21c79ef037224fcb7
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
Joss Armstrong [Thu, 17 Jan 2019 08:08:00 +0000 (08:08 +0000)]
Fix unit tests for appc-command-executor-core
Increase line coverage of package from 43% to 93%
Issue-ID: APPC-1329
Change-Id: I0a4e2a0a85f6761becde4a74609358267530d92d
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
Joss Armstrong [Thu, 17 Jan 2019 12:52:30 +0000 (12:52 +0000)]
Test coverage for appc-workflow-management-core
Increase test coverage from 2% to 73%
Issue-ID: APPC-1332
Change-Id: I41567d3b5108581bbdce95671366a57323c7b1a4
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
ezhil [Wed, 9 Jan 2019 16:34:04 +0000 (22:04 +0530)]
Added junit test file for ResponseTest.java
Change-Id: I89a6669bb6ce209e0f01b616530b87ee2048f3f3
Issue-ID: APPC-1316
Signed-off-by: ezhil <ezhrajam@in.ibm.com>
Sandeep J [Wed, 16 Jan 2019 15:46:49 +0000 (21:16 +0530)]
added test case to ConfigResourceNode.java
to increase code coverage
Issue-ID: APPC-1086
Change-Id: I3d49e11a910b42a9e0ec17768a79c43dfc018c34
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
Sandeep J [Wed, 16 Jan 2019 15:27:52 +0000 (20:57 +0530)]
added test cases to TestDGGeneralDBService
to increase code coverage
Issue-ID: APPC-1086
Change-Id: I5c765135fad3720818d76a87b7ebe1691dc39155
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
Joss Armstrong [Wed, 16 Jan 2019 09:55:37 +0000 (09:55 +0000)]
Remove deprecated mock implementations of LCM
Removal of deprecated code
Issue-ID: APPC-1328
Change-Id: I075ed20b648b78c51cbfcb123958340ab379ac09
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
Joss Armstrong [Fri, 11 Jan 2019 22:33:49 +0000 (22:33 +0000)]
Fix unit tests in provider-lcm-service
Increased line coverage from 69% to 87%
Removed PrepareForTest annotations for classes under test
Issue-ID: APPC-1326
Change-Id: I75be7235f4c13b0f395843907958d7391a333a32
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
Joss Armstrong [Mon, 14 Jan 2019 12:24:00 +0000 (12:24 +0000)]
Fix VM Snapshot error during image validation
prefix image name with 'in:' and surround with quotes
to deal with change to Glance that no longer supports
image names including colons passed as plain strings
Issue-ID: APPC-869
Change-Id: If81accc3edd7b4805eb965b11f466df9654d6010
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
ezhil [Wed, 2 Jan 2019 16:05:26 +0000 (21:35 +0530)]
Fixed sonar issue in ProviderAdapterImpl
Change-Id: I0a2e6f4ad94ad3c172ca15b0111892d38b188a55
Issue-ID: APPC-1299
Signed-off-by: ezhil <ezhrajam@in.ibm.com>
Joss Armstrong [Fri, 11 Jan 2019 16:50:12 +0000 (16:50 +0000)]
Fix for unit tests in appc-data-access-lib
Increased test coverage from 32% to 82%
Removed PrepareForTest annotation from class under test
Issue-ID: APPC-1324
Change-Id: I58f7e495d0405d994132eea20ebae248d8887238
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
Joss Armstrong [Fri, 11 Jan 2019 15:18:03 +0000 (15:18 +0000)]
Fix unit test with @PrepareForTest annotation
Removed annotation and fixed tests.
Increased package line coverage from 50% to 88%
Issue-ID: APPC-1323
Change-Id: Iae5441e5e6243755f8ec6ab178668a5c985eaf6a
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
Joss Armstrong [Fri, 11 Jan 2019 10:41:59 +0000 (10:41 +0000)]
Add code coverage for metric-service-policy code
Increased line coverage from 0% to 79%
Issue-ID: APPC-1321
Change-Id: I79f65d97055248b73da875e9591bd2c6e86afca4
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
ezhil [Wed, 9 Jan 2019 16:00:51 +0000 (21:30 +0530)]
Added JUNIT test for PreCheckOption.java
Change-Id: Id50d6b00a1c86ca5a350dc0f5f36f0decc28d413
Issue-ID: APPC-1314
Signed-off-by: ezhil <ezhrajam@in.ibm.com>
Joss Armstrong [Wed, 9 Jan 2019 15:30:17 +0000 (15:30 +0000)]
Test coverage in appc-dg-ssh
Increased line coverage from 49% to 93%
Issue-ID: APPC-1313
Change-Id: I2f27742fd996cd6d07668fd61c887e29f2140818
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
Joss Armstrong [Wed, 9 Jan 2019 19:17:28 +0000 (19:17 +0000)]
Test coverage for appc-provider-topology
Increased line coverage from 0% to 86%
Issue-ID: APPC-1317
Change-Id: I2297634d50a389c8c250981656e00a9bb2741ea3
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
ezhil [Wed, 9 Jan 2019 16:15:52 +0000 (21:45 +0530)]
Added Junit test file for ActionIdentifier.java
Change-Id: Ia9a2a0df159448354ed094875e5ba16316a87432
Issue-ID: APPC-1315
Signed-off-by: ezhil <ezhrajam@in.ibm.com>
ezhil [Tue, 8 Jan 2019 17:56:55 +0000 (23:26 +0530)]
Added test file to Transaction.java
Change-Id: I75419387c7b36790c5e41f9577672bcb1c65eba4
Issue-ID: APPC-1307
Signed-off-by: ezhil <ezhrajam@in.ibm.com>
Joss Armstrong [Wed, 9 Jan 2019 11:26:59 +0000 (11:26 +0000)]
Test Coverage in appc-dg-netconf
Increased coverage from 22% to 97%
Issue-ID: APPC-1311
Change-Id: I631cfdb29e4c374f0f015d3a81b4918eed6894ec
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
Joss Armstrong [Tue, 8 Jan 2019 22:00:43 +0000 (22:00 +0000)]
Test coverage in appc-dg-mdsal-bundle
Increase test coverage from 11% to 77%
Issue-ID: APPC-1308
Change-Id: I5cb45e2879bcf97a182687276fdf926f769b0e51
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
Patrick Brady [Tue, 8 Jan 2019 20:25:10 +0000 (12:25 -0800)]
Change parent version to appc snapshot
Changing to the current release snapshot version of
the appc parents instead of the previous release version.
This allows updated changes to parents to be in builds.
Change-Id: I6cec484012c2cb48ee1ea7f10fd058d017f00947
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1304
Joss Armstrong [Mon, 7 Jan 2019 14:42:38 +0000 (14:42 +0000)]
Increase unit test coverage in appc-dg-aai project
Increased line coverage from 11% to 93%
Issue-ID: APPC-1305
Change-Id: Iab844f4b6a048eee884c92d397c87159d38b0aa5
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
Patrick Brady [Mon, 7 Jan 2019 16:41:15 +0000 (08:41 -0800)]
Update parent pom version
Update the parent version to appc parent 1.4.1
Change-Id: I185d086595bed6410f7fd6b8c139cc6300e4467e
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1304
Patrick Brady [Thu, 3 Jan 2019 19:21:43 +0000 (11:21 -0800)]
Fixes feature install on latest ccsdk
Updated rest adapter to resolve dependencies the same way that other
appc features do. This fixed the karaf crash during install.
Added necessary dependencies as embedded or karaf bundles to other
appc features, as needed.
Change-Id: Id04d08cd09c2ff0cae0db8ecbc61405da10882d7
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1304
Balaji, Ramya (rb111y) [Thu, 3 Jan 2019 21:15:00 +0000 (16:15 -0500)]
Dependency changes to overcome
linkage error
Issue-ID: APPC-1289
Change-Id: I7a424430bc3510c87b087913fad8992378e27a1b
Signed-off-by: Balaji, Ramya (rb111y) <rb111y@att.com>
Arundathi Patil [Mon, 3 Dec 2018 09:58:33 +0000 (15:28 +0530)]
Sonar Fix: AAIResourceNode.java
Fixed sonar issues/code-smells across this file.
Issue-ID: APPC-1265
Change-Id: Id0339b89f05ba3d55d6b01a0c885fabcadcd86da
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
ezhil [Thu, 3 Jan 2019 16:42:43 +0000 (22:12 +0530)]
Fixed sonar issue in Utils.java
Change-Id: I5edf48443c10f08200b0ea376194a9a8fc6dc29a
Issue-ID: APPC-1302
Signed-off-by: ezhil <ezhrajam@in.ibm.com>
Joss Armstrong [Thu, 3 Jan 2019 16:14:54 +0000 (16:14 +0000)]
Increase code coverage in appc-dg-dependency-model
Increased coverage of sub-project from 50% to 80%
Issue-ID: APPC-1301
Change-Id: Ib69b010cd34302a8a9c3b9a291bcbc351babd731
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
ezhil [Wed, 2 Jan 2019 12:00:40 +0000 (17:30 +0530)]
Fixed sonar in SequenceGeneratorDBservices.java
Change-Id: I9931d24771399dedb8c7884d1009d6c3cb84ba16
Issue-ID: APPC-1297
Signed-off-by: ezhil <ezhrajam@in.ibm.com>
ezhil [Wed, 2 Jan 2019 12:12:58 +0000 (17:42 +0530)]
Fixed sonar issues in CreateSapshot.java
Change-Id: Ib3c1e84cdbec3e2698f55b13c038afdf9e51d294
Issue-ID: APPC-1298
Signed-off-by: ezhil <ezhrajam@in.ibm.com>
Joss Armstrong [Mon, 31 Dec 2018 16:18:34 +0000 (16:18 +0000)]
Fix for test coverage in dg common impl package
Increased test coverage from 42% to 73%
Issue-ID: APPC-1296
Change-Id: Ib36c86c325bbc49a14a8ae7076a3b3da14c89b6f
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
Joss Armstrong [Thu, 20 Dec 2018 09:42:37 +0000 (09:42 +0000)]
Test coverage in OAM and OAM message-adapter
Increased coverage from 19% to 96% for
oam package.
Increased coverage from 14% to 93% for
oam.message-adapter package.
Issue-ID: APPC-1290
Change-Id: I91c313ba42b49718445463a524bf80ac0734b0a9
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
Joss Armstrong [Wed, 19 Dec 2018 14:15:04 +0000 (14:15 +0000)]
Fix for test coverage in oam.utils package
Removed 'PrepareForTest' annotations which were preventing test
coverage of classes in appc.oam.utils package.
Added unit tests for untested code.
Increased line coverage of the package from 49% to 83%.
Issue-ID: APPC-1287
Change-Id: I893de5281f8c46e92269be895ef304bbf87c88b9
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
Arundathi Patil [Mon, 17 Dec 2018 18:25:28 +0000 (23:55 +0530)]
Sonar fix: ServiceCatalogV3.java
Fixed sonar issues/code-smells across this file
Issue-ID: APPC-1281
Change-Id: I118fe3da8ae3ac3c46ad5f2128353e332387086c
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
Arundathi Patil [Mon, 17 Dec 2018 17:56:39 +0000 (23:26 +0530)]
Sonar Fix: ConnectionBuilder.java
Fixed sonar issues/code-smells across this file
Issue-ID: APPC-1278
Change-Id: Ic81337c3a2f8c60f5a25adfc10fb4416311de08d
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
Arundathi Patil [Mon, 17 Dec 2018 18:06:08 +0000 (23:36 +0530)]
Sonar Fix: ChefResponse.java
Fixed sonar issues/code-smells across this file.
Issue-ID: APPC-1279
Change-Id: I50d5de26d69928037882686452aecd3deb6edbec
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
Arundathi Patil [Mon, 17 Dec 2018 18:12:57 +0000 (23:42 +0530)]
Sonar fix: ProviderAdapter.java
Fixed sonar issues/code-smells across this file.
Issue-ID: APPC-1280
Change-Id: I168acf475095b7ef1a40cc1662d844470f045a5d
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
Joss Armstrong [Tue, 18 Dec 2018 14:59:41 +0000 (14:59 +0000)]
Fix for APPC-1286
Increased test coverage from 49% to 73% for package.
Added coverage for 4 classes that were previously at 0% coverage.
Refactored slow running code into a method that can be mocked
to speed up execution of unit tests.
Issue-ID: APPC-1286
Change-Id: I3ebe5f6bfbc59228b57d20a3c45081e40ee8e31e
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
Joss Armstrong [Mon, 17 Dec 2018 13:12:45 +0000 (13:12 +0000)]
Fix for OOM-1538
This is APPC code change, values.yaml in OOM project also requires
update. This is using EncryptionTool class already present in APPC
for decryption of password. Alternative may be to use the CryptoUtils
class from SO to have common encrypted string?
Issue-ID: OOM-1538
Change-Id: I8201dd2587604c19ac584c7af1a9281ab96340d2
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
Taka Cho [Fri, 14 Dec 2018 16:22:25 +0000 (11:22 -0500)]
add config modify LCM sample request
per user request, adding one LCM:config-modify
request sample
Change-Id: I9902c19feae704b4b97838b71bab691154b3f68f
Issue-ID: APPC-1273
Signed-off-by: Taka Cho <takamune.cho@att.com>
Balaji, Ramya (rb111y) [Fri, 23 Nov 2018 18:25:21 +0000 (13:25 -0500)]
Possible fix for NoClassDefFoundError
Changed package structure, pom file
for Utils classto expose it under
export-package for DMaap adapter bundle
Issue-ID: APPC-1247
Change-Id: I1662d3af027982a87c063cabee77a645f2bc3afa
Signed-off-by: Balaji, Ramya (rb111y) <rb111y@att.com>
Joss Armstrong [Tue, 11 Dec 2018 16:57:24 +0000 (16:57 +0000)]
Fix for APPC-1271
Replaced slow running tests which wait for timeout
Testing time reduced from 22 seconds to 0.5 seconds
Improved tests and line coverage increased from 26% to 96%
Issue-ID: APPC-1271
Change-Id: I88713e5c819e5ce1bf695f6de3834db7c3007285
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
Sandeep J [Wed, 28 Nov 2018 12:54:21 +0000 (18:24 +0530)]
formatted code in LRUCacheTest.java
and removed unused imports
Issue-ID: APPC-1086
Change-Id: I18009404898a938ec23be77bfcf94084f4e9badd
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
Joss Armstrong [Mon, 10 Dec 2018 16:28:51 +0000 (16:28 +0000)]
Further fixes for APPC-1270
Fixed >100 sonar issues
Increased line coverage from 26% to 87%
Improved testing
Removal of redundant code in class under test
Issue-ID: APPC-1270
Change-Id: I63f53f03be815bb951d650df2f77999e5629ad75
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
Joss Armstrong [Thu, 6 Dec 2018 17:17:46 +0000 (17:17 +0000)]
Fix for APPC-1270
Reduced testing time from 90 seconds to 2 seconds
Removed code smell for multiple instance/static references
Added assertions and coverage for success scenarios for
all methods
Line coverage increased from 55% to 84%
Moved construction of objects to protected methods to
facilitate testing
Issue-ID: APPC-1270
Change-Id: I7945c069c703d2ea3fac9ffa33927856170656c9
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
Joss Armstrong [Tue, 4 Dec 2018 18:13:22 +0000 (18:13 +0000)]
Unit test fixes for APPC-1267
Removed code smell for <65% branch coverage - now 86%.
Test cases now cover success scenarios for all methods.
Coverage increased to 97%.
Removed classloader code and unnecessary resource files
Moved construction of objects to protected methods to
facilitate testing.
Issue-ID: APPC-1267
Change-Id: I07656a5464410ca5ca3cca55cefd54c03a711385
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
Joss Armstrong [Wed, 5 Dec 2018 14:24:48 +0000 (14:24 +0000)]
Unit tests for APPC-1268
Added unit tests for AppcProviderLcm class and increase
line coverage from 0% to 80%
Issue-ID: APPC-1268
Change-Id: Ic0657a5c1b90daff9507d6f7b4e9ea2fbc7c67b5
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
Joss Armstrong [Fri, 30 Nov 2018 14:12:38 +0000 (14:12 +0000)]
Fix for APPC-1264
Fixed broken unit tests. Improved unit testing and increased
line and branch coverage. Deleted unused and duplicated
files used in tests.
Issue-ID: APPC-1264
Change-Id: Idea7d46f4a6c9c591617fb973a8d33e5275e4579
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
Code Review / appc.git / log