super(Action.ConfigScaleOut);
logger.debug("ConfigScaleOutService starts");
}
+
public ConfigScaleOutOutputBuilder process(ConfigScaleOutInput input) {
CommonHeader commonHeader = input.getCommonHeader();
ActionIdentifiers actionIdentifiers = input.getActionIdentifiers();
validate(commonHeader, input.getAction(), actionIdentifiers, payload);
if (status == null) {
- proceedAction(commonHeader,actionIdentifiers,payload);
+ proceedAction(commonHeader, actionIdentifiers, payload);
}
ConfigScaleOutOutputBuilder outputBuilder = new ConfigScaleOutOutputBuilder();
// validate payload
String keyName = "payload";
-// if (payload == null) {
-// status = buildStatusForParamName(LCMCommandStatus.MISSING_MANDATORY_PARAMETER, keyName);
-// return;
-// }
- if (payload !=null) {
+ if (payload == null) {
+ status = buildStatusForParamName(LCMCommandStatus.MISSING_MANDATORY_PARAMETER, keyName);
+ return;
+ }
+// if (payload !=null) {
String payloadString = payload.getValue();
status = validateMustHaveParamValue(
- payloadString == null ? payloadString : payloadString.trim(), "payload");
+ payloadString == null ? payloadString : payloadString.trim(), "payload");
if (status != null) {
return;
}
try {
Map<String, String> payloadMap = JsonUtil.convertJsonStringToFlatMap(payloadString);
validateMustHaveParamValue(payloadMap.get(keyName), keyName);
+ validateMustHaveParamValue(payloadMap.get("payload.request-parameters.vf-module-id"), "vf-module-id");
} catch (IOException e) {
logger.error(String.format("ConfigScaleOutService (%s) got IOException when converting payload", rpcName), e);
status = buildStatusForErrorMsg(LCMCommandStatus.UNEXPECTED_ERROR, e.getMessage());
}
}
- }
+
+// }
void proceedAction(CommonHeader commonHeader,
ActionIdentifiers actionIdentifiers,
import org.mockito.Mockito;
import org.mockito.internal.util.reflection.Whitebox;
import org.mockito.runners.MockitoJUnitRunner;
+import org.onap.appc.util.JsonUtil;
import org.opendaylight.yang.gen.v1.org.onap.appc.lcm.rev160108.*;
import org.opendaylight.yang.gen.v1.org.onap.appc.lcm.rev160108.action.identifiers.ActionIdentifiers;
import org.opendaylight.yang.gen.v1.org.onap.appc.lcm.rev160108.common.header.CommonHeader;
import org.onap.appc.requesthandler.objects.RequestHandlerOutput;
import org.onap.appc.requesthandler.objects.RequestHandlerInput;
+import java.util.Map;
+
import static org.mockito.Matchers.any;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.spy;
private ConfigScaleOutService configscaleoutServiceAction;
@Before
public void setUp() throws Exception {
+
configscaleoutServiceAction = spy(new ConfigScaleOutService());
}
configscaleoutServiceAction.validate(mockCommonHeader, Action.ConfigScaleOut, mockAI, null);
Mockito.verify(configscaleoutServiceAction, times(1)).validateExcludedActIds(any(), any());
status = (Status) Whitebox.getInternalState(configscaleoutServiceAction, "status");
- Assert.assertTrue("Should skip Payload",true);
+ Assert.assertEquals("should return missing parameter",
+ Integer.valueOf(LCMCommandStatus.MISSING_MANDATORY_PARAMETER.getResponseCode()), status.getCode());
// test empty payload
Mockito.doReturn("").when(mockPayload).getValue();
configscaleoutServiceAction.validate(mockCommonHeader, Action.ConfigScaleOut, mockAI, mockPayload);
status = (Status) Whitebox.getInternalState(configscaleoutServiceAction, "status");
- Assert.assertTrue("Should skip Payload",true);
+ Assert.assertEquals("should return invalid parameter",
+ Integer.valueOf(LCMCommandStatus.INVALID_INPUT_PARAMETER.getResponseCode()), status.getCode());
// test space payload
Mockito.doReturn(" ").when(mockPayload).getValue();
configscaleoutServiceAction.validate(mockCommonHeader, Action.ConfigScaleOut, mockAI, mockPayload);
status = (Status) Whitebox.getInternalState(configscaleoutServiceAction, "status");
- Assert.assertTrue("Should skip Payload",true);
+ Assert.assertEquals("should return invalid parameter",
+ Integer.valueOf(LCMCommandStatus.INVALID_INPUT_PARAMETER.getResponseCode()), status.getCode());
}
}