Fix sonar issues for APPC 53/26653/2
authorTaka <tc012c@att.com>
Wed, 20 Dec 2017 18:07:21 +0000 (13:07 -0500)
committerSkip Wonnell <skip@att.com>
Thu, 21 Dec 2017 16:02:38 +0000 (16:02 +0000)
Change-Id: I386f6794215eb69b8547fa06193ad78f951b327b
Issue-ID: APPC-323
Signed-off-by: Taka <tc012c@att.com>
23 files changed:
appc-adapters/appc-ansible-adapter/appc-ansible-adapter-bundle/src/main/java/org/onap/appc/adapter/ansible/model/AnsibleResult.java
appc-adapters/appc-ansible-adapter/appc-ansible-adapter-bundle/src/main/java/org/onap/appc/adapter/ansible/model/AnsibleResultCodes.java
appc-adapters/appc-ansible-adapter/appc-ansible-adapter-bundle/src/main/java/org/onap/appc/adapter/ansible/model/AnsibleServerEmulator.java
appc-adapters/appc-iaas-adapter/appc-iaas-adapter-bundle/src/main/java/org/onap/appc/adapter/iaas/impl/TenantCache.java
appc-adapters/appc-iaas-adapter/appc-iaas-adapter-bundle/src/main/java/org/onap/appc/adapter/openstack/heat/StackResource.java
appc-client/client-kit/src/main/java/org/onap/appc/client/lcm/impl/business/CoreAsyncResponseHandlerImpl.java
appc-client/client-lib/src/main/java/org/onap/appc/client/impl/protocol/MessageWriter.java
appc-config/appc-config-adaptor/provider/src/main/java/org/onap/appc/ccadaptor/ConfigComponentAdaptor.java
appc-config/appc-encryption-tool/provider/src/main/java/org/onap/appc/encryptiontool/EncryptionToolActivator.java
appc-config/appc-encryption-tool/provider/src/main/java/org/onap/appc/encryptiontool/wrapper/DbServiceUtil.java
appc-dispatcher/appc-dispatcher-common/domain-model-lib/src/main/java/org/onap/appc/domainmodel/lcm/RuntimeContext.java
appc-dispatcher/appc-dispatcher-common/execution-queue-management-lib/src/main/java/org/onap/appc/executionqueue/helper/Util.java
appc-inbound/appc-artifact-handler/provider/src/main/java/org/onap/appc/artifact/handler/ArtifactHandlerProvider.java
appc-inbound/appc-design-services/provider/src/main/java/org/onap/appc/design/data/DesignRequest.java
appc-inbound/appc-design-services/provider/src/main/java/org/onap/appc/design/dbervices/DbService.java
appc-inbound/appc-design-services/provider/src/main/java/org/onap/appc/design/dbervices/DesignDBService.java
appc-inbound/appc-design-services/provider/src/main/java/org/onap/appc/design/dbervices/RequestValidator.java
appc-inbound/appc-design-services/provider/src/main/java/org/onap/appc/design/services/DesignServiceProvider.java
appc-inbound/appc-design-services/provider/src/main/java/org/onap/appc/design/services/impl/DesignServicesImpl.java
appc-inbound/appc-design-services/provider/src/main/java/org/onap/appc/design/services/util/ArtifactHandlerClient.java
appc-inbound/appc-design-services/provider/src/main/java/org/onap/appc/design/validator/ValidatorResponseProcessor.java
appc-inbound/appc-design-services/provider/src/main/java/org/onap/appc/design/validator/ValidatorService.java
appc-inbound/appc-design-services/provider/src/main/java/org/onap/appc/design/xinterface/XResponseProcessor.java

index a4bbcbe..6b7369c 100644 (file)
@@ -27,59 +27,59 @@ package org.onap.appc.adapter.ansible.model;
 
 /* Simple class to store code and message returned by POST/GET to an Ansible Server */
 public class AnsibleResult{
-    private int StatusCode;
-    private String StatusMessage;
-    private String Results;
+    private int statusCode;
+    private String statusMessage;
+    private String results;
     
 
     public    AnsibleResult(){
-       StatusCode = -1;
-       StatusMessage = "UNKNOWN";
-       Results = "UNKNOWN";
+       statusCode = -1;
+       statusMessage = "UNKNOWN";
+       results = "UNKNOWN";
 
     }
 
     // constructor
     public AnsibleResult(int code, String message, String result){
-       StatusCode = code;
-       StatusMessage = message;
-       Results = result;
+       statusCode = code;
+       statusMessage = message;
+       results = result;
     }
 
     //*************************************************
     // Various set methods
     public void setStatusCode(int code){
-       this.StatusCode = code;
+       this.statusCode = code;
     }
 
     public void setStatusMessage(String message){
-       this.StatusMessage = message;
+       this.statusMessage = message;
     }
 
     public void setResults(String results){
-       this.Results = results;
+       this.results = results;
     }
     
 
     void set(int code, String message, String results){
-       this.StatusCode = code;
-       this.StatusMessage = message;
-       this.Results = results;
+       this.statusCode = code;
+       this.statusMessage = message;
+       this.results = results;
 
     }
 
     //*********************************************
     // Various get methods
     public int getStatusCode(){
-       return this.StatusCode;
+       return this.statusCode;
     }
 
     public String getStatusMessage(){
-       return this.StatusMessage;
+       return this.statusMessage;
     }
 
     public String getResults(){
-       return this.Results;
+       return this.results;
     }
 
 
index 986ad3e..5d44f6d 100644 (file)
@@ -53,9 +53,9 @@ public enum AnsibleResultCodes{
     INITRESPONSE(0),
     FINALRESPONSE(1); 
     
-    private final Set<Integer> InitCodes = new HashSet<Integer>(Arrays.asList(100, 101));
-    private final Set<Integer> FinalCodes = new HashSet<Integer>(Arrays.asList(200, 500));
-    private final ArrayList<Set<Integer>>CodeSets = new ArrayList<Set<Integer>>(Arrays.asList(InitCodes, FinalCodes));
+    private final Set<Integer> initCodes = new HashSet<Integer>(Arrays.asList(100, 101));
+    private final Set<Integer> finalCodes = new HashSet<Integer>(Arrays.asList(200, 500));
+    private final ArrayList<Set<Integer>>codeSets = new ArrayList<Set<Integer>>(Arrays.asList(initCodes, finalCodes));
     
     private  final Set<String> MessageSet = new HashSet<String>(Arrays.asList("PENDING", "FINISHED", "TERMINATED"));
 
@@ -72,7 +72,7 @@ public enum AnsibleResultCodes{
 
 
     public boolean checkValidCode(int Type, int Code){
-       Set<Integer>CodeSet = CodeSets.get(Type);
+       Set<Integer>CodeSet = codeSets.get(Type);
        if (CodeSet.contains(Code)){
            return true;
        }
@@ -83,7 +83,7 @@ public enum AnsibleResultCodes{
 
 
     public String getValidCodes(int Type){
-       Set<Integer>CodeSet = CodeSets.get(Type);
+       Set<Integer>CodeSet = codeSets.get(Type);
        
        Iterator iter = CodeSet.iterator();
        String ValidCodes = "[ ";
index c430743..7b7d955 100644 (file)
@@ -35,12 +35,9 @@ package org.onap.appc.adapter.ansible.model;
 import java.util.*;
 import java.util.regex.Pattern;
 import java.util.regex.Matcher;
-import com.google.common.base.Strings;
 
 import org.json.JSONObject;
-import org.json.JSONArray;
 import org.json.JSONException;
-import org.onap.appc.exceptions.APPCException;
 import org.onap.appc.adapter.ansible.model.AnsibleResult;
 
 public class AnsibleServerEmulator {
index 659202d..3f59503 100644 (file)
@@ -28,8 +28,6 @@ import java.io.IOException;
 import java.util.HashMap;
 import java.util.Map;
 import java.util.Properties;
-import java.util.regex.Matcher;
-import java.util.regex.Pattern;
 import org.onap.appc.Constants;
 import org.onap.appc.configuration.Configuration;
 import org.onap.appc.configuration.ConfigurationFactory;
@@ -45,9 +43,7 @@ import com.att.cdp.zones.ContextFactory;
 import com.att.cdp.zones.Provider;
 import com.att.eelf.configuration.EELFLogger;
 import com.att.eelf.configuration.EELFManager;
-import com.woorea.openstack.connector.JaxRs20Connector;
 // import com.sun.jersey.api.client.ClientHandlerException;
-import com.woorea.openstack.keystone.model.Access.Service.Endpoint;
 
 /**
  * This class maintains a cache of tenants within a specific provider.
index 5add047..302943b 100644 (file)
@@ -24,9 +24,6 @@
 
 package org.onap.appc.adapter.openstack.heat;
 
-import org.onap.appc.adapter.openstack.heat.model.CreateSnapshotParams;
-import org.onap.appc.adapter.openstack.heat.model.Snapshot;
-import com.woorea.openstack.base.client.Entity;
 import com.woorea.openstack.base.client.HttpMethod;
 import com.woorea.openstack.base.client.OpenStackClient;
 import com.woorea.openstack.base.client.OpenStackRequest;
index 96e21d8..be43d02 100644 (file)
@@ -24,7 +24,6 @@
 
 package org.onap.appc.client.lcm.impl.business;
 
-import org.onap.appc.client.impl.core.CoreException;
 import org.onap.appc.client.impl.core.ICoreAsyncResponseHandler;
 import org.onap.appc.client.lcm.api.ResponseHandler;
 import org.onap.appc.client.lcm.exceptions.AppcClientException;
index 0849bc4..0f4aa09 100644 (file)
@@ -25,7 +25,6 @@
 package org.onap.appc.client.impl.protocol;
 
 import org.onap.appc.client.impl.core.MessageContext;
-import com.fasterxml.jackson.databind.JsonNode;
 
 public interface MessageWriter {
 
index 1434b3d..f0bf5c5 100644 (file)
@@ -30,20 +30,14 @@ import java.net.HttpURLConnection;
 import java.util.HashMap;
 import java.util.Map;
 import java.util.Properties;
-import java.util.regex.Matcher;
-import java.util.regex.Pattern;
 import java.util.StringTokenizer;
 import java.util.NoSuchElementException;
-import java.io.StringReader;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
 import org.onap.ccsdk.sli.core.sli.SvcLogicAdaptor;
 import org.onap.ccsdk.sli.core.sli.SvcLogicContext;
 import com.sun.jersey.api.client.Client;
 import com.sun.jersey.api.client.ClientResponse;
 import com.sun.jersey.api.client.WebResource;
 import com.sun.jersey.core.util.Base64;
-import org.jdom.input.SAXBuilder;
 import com.att.eelf.configuration.EELFLogger;
 import com.att.eelf.configuration.EELFManager;
 
index 58279e8..164a8b5 100644 (file)
@@ -28,7 +28,6 @@ import com.att.eelf.configuration.EELFLogger;
 import com.att.eelf.configuration.EELFManager;
 import org.onap.appc.configuration.Configuration;
 import org.onap.appc.configuration.ConfigurationFactory;
-import org.onap.appc.executionqueue.impl.QueueManager;
 
 import java.util.concurrent.Executors;
 import java.util.concurrent.ThreadFactory;
index d5ccd45..51f286e 100644 (file)
 
 package org.onap.appc.artifact.handler;
 
-import java.util.HashMap;
 import java.util.concurrent.ExecutionException;
 import java.util.concurrent.ExecutorService;
 import java.util.concurrent.Executors;
 import java.util.concurrent.Future;
 
-import org.json.JSONArray;
-import org.json.JSONObject;
 import org.opendaylight.controller.md.sal.binding.api.DataBroker;
 import org.opendaylight.controller.md.sal.binding.api.DataChangeListener;
 import org.opendaylight.controller.md.sal.binding.api.WriteTransaction;
@@ -54,10 +51,8 @@ import org.opendaylight.yangtools.yang.binding.DataObject;
 import org.opendaylight.yangtools.yang.binding.InstanceIdentifier;
 import org.opendaylight.yangtools.yang.common.RpcResult;
 import org.opendaylight.yangtools.yang.common.RpcResultBuilder;
-import org.onap.appc.artifact.handler.node.ArtifactHandlerNode;
 import org.onap.appc.artifact.handler.utils.ArtifactHandlerProviderUtil;
 import org.onap.appc.artifact.handler.utils.SdcArtifactHandlerConstants;
-import org.onap.ccsdk.sli.core.sli.SvcLogicContext;
 
 import com.att.eelf.configuration.EELFLogger;
 import com.att.eelf.configuration.EELFManager;
index d61de02..8a5b543 100644 (file)
 
 package org.onap.appc.design.data;
 
-import java.io.File;
-import java.net.URL;
-import java.sql.SQLException;
-import java.util.ArrayList;
-import java.util.List;
-import java.util.Properties;
-
-import javax.sql.rowset.CachedRowSet;
-
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
 
 import com.fasterxml.jackson.annotation.JsonProperty;
 
-import org.onap.appc.design.services.util.DesignServiceConstants;
-import org.onap.ccsdk.sli.core.dblib.DBResourceManager;
-import org.onap.ccsdk.sli.core.dblib.DbLibService;
-
 public class DesignRequest{
 
 
index a234919..888e76a 100644 (file)
 package org.onap.appc.design.dbervices;
 
 import java.sql.ResultSet;
-import java.sql.SQLException;
 import java.util.ArrayList;
-import java.util.Properties;
-import java.util.UUID;
 
 import org.onap.ccsdk.sli.core.sli.provider.SvcLogicService;
 import org.onap.ccsdk.sli.core.dblib.DBResourceManager;
index 1d895e7..3b87461 100644 (file)
@@ -25,7 +25,6 @@
 package org.onap.appc.design.dbervices;
 
 import java.io.IOException;
-import java.security.SecureRandom;
 import java.sql.ResultSet;
 import java.sql.SQLException;
 import java.util.ArrayList;
@@ -46,7 +45,6 @@ import com.att.eelf.configuration.EELFManager;
 import com.fasterxml.jackson.core.JsonProcessingException;
 import com.fasterxml.jackson.databind.JsonNode;
 import com.fasterxml.jackson.databind.ObjectMapper;
-import com.fasterxml.jackson.databind.node.ObjectNode;
 
 public class DesignDBService {
 
index f41bbac..d5cb35f 100644 (file)
 
 package org.onap.appc.design.services;
 
-import java.util.concurrent.Future;
 import org.opendaylight.controller.md.sal.binding.api.DataBroker;
 import org.opendaylight.controller.sal.binding.api.BindingAwareBroker.RpcRegistration;
 import org.opendaylight.controller.sal.binding.api.RpcProviderRegistry;
 import org.opendaylight.yang.gen.v1.org.onap.appc.rev170627.DesignServicesService;
-import org.opendaylight.yangtools.yang.common.RpcResult;
 import org.onap.appc.design.services.impl.DesignServicesImpl;
 
 import com.att.eelf.configuration.EELFLogger;
index 1787618..0016a52 100644 (file)
@@ -49,7 +49,6 @@ import org.onap.appc.design.xinterface.XResponseProcessor;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
-import com.google.common.collect.Lists;
 import com.google.common.util.concurrent.Futures;
 
 public class DesignServicesImpl implements DesignServicesService {
index b250fac..8cd7ebb 100644 (file)
@@ -28,9 +28,7 @@ import java.io.FileInputStream;
 import java.io.IOException;
 import java.io.InputStream;
 import java.net.URI;
-import java.nio.charset.Charset;
 import java.security.SecureRandom;
-import java.util.ArrayList;
 import java.util.HashMap;
 import java.util.Properties;
 
@@ -39,7 +37,6 @@ import javax.net.ssl.SSLContext;
 import javax.ws.rs.HttpMethod;
 import javax.ws.rs.core.MediaType;
 
-import org.onap.ccsdk.sli.core.sli.SvcLogicContext;
 import com.sun.jersey.api.client.Client;
 import com.sun.jersey.api.client.ClientResponse;
 import com.sun.jersey.api.client.WebResource;
index 6660dd8..d3d77e9 100644 (file)
 package org.onap.appc.design.validator;
 
 import java.io.ByteArrayInputStream;
-import java.io.File;
-import java.io.FileInputStream;
 import java.io.IOException;
 import java.io.InputStream;
 import java.io.InputStreamReader;
 import java.io.Reader;
-import java.io.StringWriter;
-import java.nio.charset.StandardCharsets;
 
 import javax.xml.parsers.DocumentBuilder;
 import javax.xml.parsers.DocumentBuilderFactory;
 import javax.xml.parsers.ParserConfigurationException;
-import javax.xml.validation.Validator;
 
 import org.apache.velocity.Template;
-import org.apache.velocity.VelocityContext;
 import org.apache.velocity.app.Velocity;
 import org.apache.velocity.app.VelocityEngine;
 import org.apache.velocity.exception.MethodInvocationException;
@@ -51,7 +45,6 @@ import org.apache.velocity.runtime.resource.util.StringResourceRepository;
 import org.onap.appc.design.services.util.DesignServiceConstants;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
-import org.w3c.dom.Document;
 import org.xml.sax.InputSource;
 import org.xml.sax.SAXException;
 
index aa72e2f..9b4547b 100644 (file)
 
 package org.onap.appc.design.xinterface;
 
-import java.io.File;
-import java.io.IOException;
-
-import com.google.common.base.Charsets;
-import com.google.common.io.Files;
-
 public class XResponseProcessor {
 
     public String parseResponse(Object execute, String action) {