AAIAuthCore-replace duplicate literal by constant 99/75599/1
authorDriptaroop Das <driptaroop.das@in.ibm.com>
Thu, 10 Jan 2019 06:36:06 +0000 (12:06 +0530)
committerDriptaroop Das <driptaroop.das@in.ibm.com>
Thu, 10 Jan 2019 06:36:20 +0000 (12:06 +0530)
Sonar Fix (AAIAuthCore.java - Define a constant instead of duplicating this literal "AAI_4001" 3 times.)

Issue-ID: AAI-2065
Change-Id: Ic9c343f814dc220fe118b21ae08f29a65a337da7
Signed-off-by: Driptaroop Das <driptaroop.das@in.ibm.com>
aai-core/src/main/java/org/onap/aai/auth/AAIAuthCore.java

index 1572ec7..5097ef4 100644 (file)
@@ -53,6 +53,8 @@ public final class AAIAuthCore {
 
        private static final EELFLogger LOGGER = EELFManager.getInstance().getLogger(AAIAuthCore.class);
 
+       private static final String ERROR_CODE_AAI_4001 = "AAI_4001";
+
        private String globalAuthFileName = AAIConstants.AAI_AUTH_CONFIG_FILENAME;
        
        private final Pattern AUTH_POLICY_PATTERN;
@@ -161,11 +163,11 @@ public final class AAIAuthCore {
                                }       
                        }
                } catch (FileNotFoundException e) {
-                       ErrorLogHelper.logError("AAI_4001", globalAuthFileName + ". Exception: " + e);
+                       ErrorLogHelper.logError(ERROR_CODE_AAI_4001, globalAuthFileName + ". Exception: " + e);
                } catch (JsonProcessingException e) {
-                       ErrorLogHelper.logError("AAI_4001", globalAuthFileName + ". Not valid JSON: " + e);
+                       ErrorLogHelper.logError(ERROR_CODE_AAI_4001, globalAuthFileName + ". Not valid JSON: " + e);
                } catch (Exception e) {
-                       ErrorLogHelper.logError("AAI_4001", globalAuthFileName + ". Exception caught: " + e);
+                       ErrorLogHelper.logError(ERROR_CODE_AAI_4001, globalAuthFileName + ". Exception caught: " + e);
                }
        }