Merge "Function.java-sonar fix"
authorJonathan Gathman <jonathan.gathman@att.com>
Wed, 6 Nov 2019 13:39:53 +0000 (13:39 +0000)
committerGerrit Code Review <gerrit@onap.org>
Wed, 6 Nov 2019 13:39:53 +0000 (13:39 +0000)
1  2 
auth/auth-cass/src/main/java/org/onap/aaf/auth/dao/hl/Function.java

@@@ -96,10 -96,10 +96,10 @@@ public class Function 
          E("Executed"),D("Denied"),P("Pending"),L("Lapsed");
  
          private String desc;
-         public final static Result<OP_STATUS> RE = Result.ok(OP_STATUS.E);
-         public final static Result<OP_STATUS> RD = Result.ok(OP_STATUS.D);
-         public final static Result<OP_STATUS> RP = Result.ok(OP_STATUS.P);
-         public final static Result<OP_STATUS> RL = Result.ok(OP_STATUS.L);
+         public static final Result<OP_STATUS> RE = Result.ok(OP_STATUS.E);
+         public static final Result<OP_STATUS> RD = Result.ok(OP_STATUS.D);
+         public static final Result<OP_STATUS> RP = Result.ok(OP_STATUS.P);
+         public static final Result<OP_STATUS> RL = Result.ok(OP_STATUS.L);
  
          private OP_STATUS(String desc) {
              this.desc = desc;
          }
  
          // VALIDATIONS done... Add NS
 -        if ((rq = q.nsDAO().create(trans, namespace.data())).notOK()) {
 +        rq = q.nsDAO().create(trans, namespace.data());
 +        if (rq.notOK()) {
              return Result.err(rq);
          }