fix minor SONAR bug

Issue-ID: AAF-835
Change-Id: I46bc1fcd083a26fe45f10f6f69913840fe4cdbaf
Signed-off-by: Instrumental <jonathan.gathman@att.com>

diff --git a/cadi/aaf/src/main/java/org/onap/aaf/cadi/register/RegistrationCreator.java b/cadi/aaf/src/main/java/org/onap/aaf/cadi/register/RegistrationCreator.java
index 5221d8e..f4e0a68 100644 (file)
--- a/cadi/aaf/src/main/java/org/onap/aaf/cadi/register/RegistrationCreator.java
+++ b/cadi/aaf/src/main/java/org/onap/aaf/cadi/register/RegistrationCreator.java
@@ -99,7 +99,8 @@ public class RegistrationCreator {
                                if (protocol!=null) {
                                        locate.setProtocol(protocol);
                                                List<String> ls = locate.getSubprotocol();
-                                               if(ls==null || ls.isEmpty()) {
+                                               // ls cannot be null, per generated getSubprotocol code
+                                               if(ls.isEmpty()) {
                                                String subprotocols = access.getProperty(Config.AAF_LOCATOR_SUBPROTOCOL + dot_le, null);
                                                if(subprotocols==null) {
                                                        subprotocols = access.getProperty(Config.CADI_PROTOCOLS, null);