Sonar Fix: MiscID.java

Fixed sonar issues/code-smells across this file

Issue-ID: AAF-734
Change-Id: I572f1e942ee9be9297b3ccdd616ca1c6d1d1eddf
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>

diff --git a/auth/auth-batch/src/main/java/org/onap/aaf/auth/batch/helpers/MiscID.java b/auth/auth-batch/src/main/java/org/onap/aaf/auth/batch/helpers/MiscID.java
index 35f03c7..4d46c20 100644 (file)
--- a/auth/auth-batch/src/main/java/org/onap/aaf/auth/batch/helpers/MiscID.java
+++ b/auth/auth-batch/src/main/java/org/onap/aaf/auth/batch/helpers/MiscID.java
@@ -53,6 +53,7 @@ public class MiscID  {
     public String sponsor;
     public String created;
     public String renewal;
+    public static String SELECT_QUERY = "SELECT ";
 
     private static final String FIELD_STRING = "id,created,sponsor,renewal";
     
@@ -85,15 +86,15 @@ public class MiscID  {
     
 
     public static void load(Trans trans, Session session ) {
-        load(trans, session,"SELECT " + FIELD_STRING + " FROM authz.miscid;",data);
+        load(trans, session,SELECT_QUERY + FIELD_STRING + " FROM authz.miscid;",data);
     }
 
     public static void load(Trans trans, Session session, Map<String,MiscID> map ) {
-        load(trans, session,"SELECT " + FIELD_STRING + " FROM authz.miscid;",map);
+        load(trans, session,SELECT_QUERY + FIELD_STRING + " FROM authz.miscid;",map);
     }
 
     public static void loadOne(Trans trans, Session session, String id ) {
-        load(trans, session,"SELECT " + FIELD_STRING + " FROM authz.miscid WHERE id ='" + id + "';", data);
+        load(trans, session,SELECT_QUERY + FIELD_STRING + " FROM authz.miscid WHERE id ='" + id + "';", data);
     }
 
     public static void load(Trans trans, Session session, String query, Map<String,MiscID> map) {