cps.git
2 years agoRemove "isTagged" mapping method 83/134083/1
lukegleeson [Wed, 12 Apr 2023 13:04:47 +0000 (14:04 +0100)]
Remove "isTagged" mapping method

Remove redundant mapping method causing sonarqube violation

Issue-ID: CPS-1394
Signed-off-by: lukegleeson <luke.gleeson@est.tech>
Change-Id: Ie3ed1411c05fcc3671e547b80b41826dcd6e1fab

2 years agoMerge "Expose endpoint to accept bulk request"
Sourabh Sourabh [Wed, 12 Apr 2023 12:57:52 +0000 (12:57 +0000)]
Merge "Expose endpoint to accept bulk request"

2 years agoMigrate query tests to integration-test module #3 27/134027/5
danielhanrahan [Wed, 5 Apr 2023 16:11:24 +0000 (17:11 +0100)]
Migrate query tests to integration-test module #3

Issue-ID: CPS-1597
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: I1d92355f272271424a7014057d251cf88eac0203

2 years agoMerge "Migrate query tests to integration-test module #2"
Sourabh Sourabh [Wed, 12 Apr 2023 12:14:17 +0000 (12:14 +0000)]
Merge "Migrate query tests to integration-test module #2"

2 years agoPerformance tests for getDataNodes and queryDataNodes 10/133510/10
danielhanrahan [Tue, 28 Mar 2023 15:43:10 +0000 (16:43 +0100)]
Performance tests for getDataNodes and queryDataNodes

- Generate openroadm data from a single innerNode.json template
- Double the number of openroadm device nodes (25 -> 50) in tests
- Add new performance tests for getDataNodes and queryDataNodes to
  integration-test module, using openroadm and bookstore data
- Remove old performance tests from cps-ri

Issue-ID: CPS-1524
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: Id9ec2a86d984d6c50c9ae6093e7a62729cb851da

2 years agoMigrate query tests to integration-test module #2 26/134026/5
danielhanrahan [Tue, 4 Apr 2023 18:00:44 +0000 (19:00 +0100)]
Migrate query tests to integration-test module #2

- Migrate some query tests to integration-test
- Edit bookstore model to add integer leaf-list 'editions'
- Lower cps-ri code coverage

Issue-ID: CPS-1597
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: If50bf15ad7d7f147448f6b60d464efc1cdc91005

2 years agoMerge "Migrate query tests to integration-test module #1"
Toine Siebelink [Tue, 11 Apr 2023 16:29:28 +0000 (16:29 +0000)]
Merge "Migrate query tests to integration-test module #1"

2 years agoMerge "Populate Dataspace field of DataNode"
Toine Siebelink [Tue, 11 Apr 2023 16:26:59 +0000 (16:26 +0000)]
Merge "Populate Dataspace field of DataNode"

2 years agoMigrate query tests to integration-test module #1 25/134025/3
danielhanrahan [Wed, 5 Apr 2023 15:41:55 +0000 (16:41 +0100)]
Migrate query tests to integration-test module #1

Issue-ID: CPS-1597
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: I0403641e2e5293571c61a58aa2b67b144cf68ac4

2 years agoMerge "[CPS] Fix SonarQube Violations / Improve Coverage - Recurring task"
Toine Siebelink [Tue, 11 Apr 2023 15:51:43 +0000 (15:51 +0000)]
Merge "[CPS] Fix SonarQube Violations / Improve Coverage - Recurring task"

2 years ago[CPS] Fix SonarQube Violations / Improve Coverage - Recurring task 02/134002/3
raviteja.karumuri [Tue, 4 Apr 2023 00:14:11 +0000 (01:14 +0100)]
[CPS] Fix SonarQube Violations / Improve Coverage - Recurring task

Issue-ID: CPS-475
Signed-off-by: raviteja.karumuri <raviteja.karumuri@est.tech>
Change-Id: I7429e1563608159b5592a2dc52ab5383f11a8ab3

2 years agoPopulate Dataspace field of DataNode 23/134023/2
danielhanrahan [Wed, 5 Apr 2023 15:16:56 +0000 (16:16 +0100)]
Populate Dataspace field of DataNode

Issue-ID: CPS-1603
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: I85aca8bccc28d36aa4cefa0a32cb9bdf2156618a

2 years agoMerge "Migrate query tests to integration-test module #4"
Sourabh Sourabh [Tue, 11 Apr 2023 09:06:58 +0000 (09:06 +0000)]
Merge "Migrate query tests to integration-test module #4"

2 years ago[CPS] Bump minor version - Step12 41/134041/2
mpriyank [Fri, 7 Apr 2023 09:12:31 +0000 (10:12 +0100)]
[CPS] Bump minor version - Step12

- bump minor cps version from 3.2.7-SNAPSHOT to 3.3.0-SNAPSHOT which is
  step11 of the release process

Issue-ID: CPS-1610
Change-Id: I74f20a7a7fa1edad417c40a09a60fecc0a96ccb7
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2 years agoToggle subscription persistence for model loader 37/134037/1
lukegleeson [Thu, 6 Apr 2023 14:36:40 +0000 (15:36 +0100)]
Toggle subscription persistence for model loader

Current implementation will attempt to persist the subscription model for subscription create events even when the model loader is disabled which causes a persistence error. Subscription Model will now be persisted based on whether the model loader is enabled

Issue-ID: CPS-1394
Signed-off-by: lukegleeson <luke.gleeson@est.tech>
Change-Id: I8f8cfc47996eed6b95fd3958996f16c8395dc341

2 years agoMigrate query tests to integration-test module #4 28/134028/1
danielhanrahan [Wed, 5 Apr 2023 16:33:05 +0000 (17:33 +0100)]
Migrate query tests to integration-test module #4

Issue-ID: CPS-1597
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: Id3b4a3829b6f9aec1a649ed0001d7c11db91ccfe

2 years agoExpose endpoint to accept bulk request 17/134017/1
leventecsanyi [Wed, 5 Apr 2023 10:57:14 +0000 (12:57 +0200)]
Expose endpoint to accept bulk request

 - added wiremock mapping for testing/demo

Issue-ID: CPS-1555
Change-Id: I82af6c43e80a346efcd84aae8945572aa37a6875
Signed-off-by: leventecsanyi <levente.csanyi@est.tech>
2 years agoMerge "Add Query Spec to integration-test package"
Priyank Maheshwari [Tue, 4 Apr 2023 14:58:34 +0000 (14:58 +0000)]
Merge "Add Query Spec to integration-test package"

2 years agoMerge "500 Error Response on NCMP ID-Searches Testing"
Luke Gleeson [Tue, 4 Apr 2023 14:04:53 +0000 (14:04 +0000)]
Merge "500 Error Response on NCMP ID-Searches Testing"

2 years agoAdd Query Spec to integration-test package 00/134000/1
lukegleeson [Tue, 4 Apr 2023 09:17:18 +0000 (10:17 +0100)]
Add Query Spec to integration-test package

Issue-ID: CPS-1598
Signed-off-by: lukegleeson <luke.gleeson@est.tech>
Change-Id: Ifab8863eae4a3ee07ba3d6096e73f9f98077584d

2 years agoMerge "Persist SubscriptionEvent"
Priyank Maheshwari [Mon, 3 Apr 2023 15:22:28 +0000 (15:22 +0000)]
Merge "Persist SubscriptionEvent"

2 years ago500 Error Response on NCMP ID-Searches Testing 55/133955/5
seanbeirne [Thu, 30 Mar 2023 18:16:28 +0000 (19:16 +0100)]
500 Error Response on NCMP ID-Searches Testing

Issue-ID: CPS-1563
Signed-off-by: seanbeirne <sean.beirne@est.tech>
Change-Id: Idc393e90d31b369095bc2b122537e17a4464a364

2 years agoRemove docs/conf.yaml 80/133980/1
danielhanrahan [Fri, 31 Mar 2023 12:41:53 +0000 (13:41 +0100)]
Remove docs/conf.yaml

Change to ONAP pipeline is causing docs-rules job to fail if
docs/conf.yaml file exists. So we remove it.

Issue-ID: CPS-1596
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: I4aa576c698162b2a99ca1459d9d192b88c3ac9b6

2 years agoMerge "Update performance test timings"
Toine Siebelink [Thu, 30 Mar 2023 15:51:00 +0000 (15:51 +0000)]
Merge "Update performance test timings"

2 years agoMerge "[CPS] Improve code coverage for Class 'SubscriptionModelLoader'"
Toine Siebelink [Thu, 30 Mar 2023 15:44:23 +0000 (15:44 +0000)]
Merge "[CPS] Improve code coverage for Class 'SubscriptionModelLoader'"

2 years agoPersist SubscriptionEvent 01/133801/3
lukegleeson [Thu, 23 Mar 2023 17:36:15 +0000 (17:36 +0000)]
Persist SubscriptionEvent

- Updated subscription.yang to subscription name instead of client name
- Implemented Mapper for SubscriptionEvent to yang model version
- Implemented Subscription Persistence for storing subscriptions
- Minor changes to existing variable names

Issue-ID: CPS-1394
Signed-off-by: lukegleeson <luke.gleeson@est.tech>
Change-Id: Ibe066006a913cb7f6e52b6fa8a851e976a338ac3

2 years agoFix assertion in integration-test performance tests 46/133946/1
danielhanrahan [Thu, 30 Mar 2023 14:10:55 +0000 (15:10 +0100)]
Fix assertion in integration-test performance tests

Issue-ID: CPS-1587
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: I044e4c81ce9972bb7979b494496d74beb733c5ed

2 years agoUpdate performance test timings 43/133943/1
danielhanrahan [Thu, 30 Mar 2023 13:37:51 +0000 (14:37 +0100)]
Update performance test timings

Issue-ID: CPS-1524
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: Iaa8e9a0ca3170a2b487df312834245d609fdfe13

2 years ago[CPS] Improve code coverage for Class 'SubscriptionModelLoader' 20/133920/3
raviteja.karumuri [Thu, 30 Mar 2023 11:21:58 +0000 (12:21 +0100)]
[CPS] Improve code coverage for Class 'SubscriptionModelLoader'

Issue-ID: CPS-1584
Signed-off-by: raviteja.karumuri <raviteja.karumuri@est.tech>
Change-Id: Ief2b14cc90c24db50a95f1c62661b1918413408e

2 years ago[CPS] Fix SonarQube Violations / Improve Coverage - Recurring task 53/133853/2
raviteja.karumuri [Fri, 24 Mar 2023 17:50:58 +0000 (17:50 +0000)]
[CPS] Fix SonarQube Violations / Improve Coverage - Recurring task

Issue-ID: CPS-475
Signed-off-by: raviteja.karumuri <raviteja.karumuri@est.tech>
Change-Id: Id3507fb24c4c6eb002a9ae6fed553daa2fca7895

2 years agoEnhanced logging for bug 56/133856/1
mpriyank [Mon, 27 Mar 2023 11:54:45 +0000 (12:54 +0100)]
Enhanced logging for bug

- Added minor logging and temporarily converted some debug logs to info
  level

Issue-ID: CPS-1566
Change-Id: I2c706ecd601b06f2a92388b318a44640c682bdd1
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2 years agoMerge "Fixes for CM-handle de-registration test script"
Toine Siebelink [Mon, 27 Mar 2023 08:17:34 +0000 (08:17 +0000)]
Merge "Fixes for CM-handle de-registration test script"

2 years agoPrepare the next drop by bumping patch version 64/133764/2
halil.cakal [Thu, 23 Mar 2023 12:44:27 +0000 (12:44 +0000)]
Prepare the next drop by bumping patch version

- Bumping modules up to 3.2.7-SNAPSHOT
- Update version.properties and release notes

Issue-ID: CPS-1577
Change-Id: Ib223c8bea164c42caceaba31a13f43c77d55c48c
Signed-off-by: halil.cakal <halil.cakal@est.tech>
2 years agoMerge "Add 3.2.6-container.yaml file to releases folder"
Priyank Maheshwari [Thu, 23 Mar 2023 12:20:50 +0000 (12:20 +0000)]
Merge "Add 3.2.6-container.yaml file to releases folder"

2 years agoAdd 3.2.6-container.yaml file to releases folder 59/133759/2
halil.cakal [Thu, 23 Mar 2023 11:33:06 +0000 (11:33 +0000)]
Add 3.2.6-container.yaml file to releases folder

- Add container yaml for cps maven docker stage master

Issue-ID: CPS-1576
Change-Id: Iee530e0cd679f98013475b1d706d8d217dd074fa
Signed-off-by: halil.cakal <halil.cakal@est.tech>
2 years agoAdd 3.2.6.yaml file to releases folder 57/133757/2
halil.cakal [Thu, 23 Mar 2023 11:08:36 +0000 (11:08 +0000)]
Add 3.2.6.yaml file to releases folder

- Add yaml file for cps maven stage master

Issue-ID: CPS-1575
Change-Id: I04b2285b4011c72dd8b15008d271bdaf5852271c
Signed-off-by: halil.cakal <halil.cakal@est.tech>
2 years agoNCMP Inventory documentation update 45/133545/7
seanbeirne [Mon, 6 Mar 2023 09:12:49 +0000 (09:12 +0000)]
NCMP Inventory documentation update

- Updated release notes

Issue-ID: CPS-1494
Signed-off-by: seanbeirne <sean.beirne@est.tech>
Change-Id: I43fc285da9d6699326d5e0a933fdb3c5c7abcb12

2 years agoFixes for CM-handle de-registration test script 34/133734/2
danielhanrahan [Mon, 13 Mar 2023 18:39:12 +0000 (18:39 +0000)]
Fixes for CM-handle de-registration test script

- Fixed dmi-plugin-stub port
- Removed unneeded test cases
- Added pushd/popd so script can be run from any directory
- Added metrics-reports to .gitignore

Issue-ID: CPS-1552
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: I0ff3549449687a919faf1c2f3172fbea6178a658

2 years agoMerge "500 Error Reponse on NCMP inventory cmhandle search"
Luke Gleeson [Wed, 22 Mar 2023 15:52:20 +0000 (15:52 +0000)]
Merge "500 Error Reponse on NCMP inventory cmhandle search"

2 years ago500 Error Reponse on NCMP inventory cmhandle search 18/133718/3
seanbeirne [Tue, 21 Mar 2023 14:34:02 +0000 (14:34 +0000)]
500 Error Reponse on NCMP inventory cmhandle search

Issue-ID: CPS-1563
Signed-off-by: seanbeirne <sean.beirne@est.tech>
Change-Id: I5579e8e852c20ce61a6684140198e989f7876d79

2 years agoUpdate documnetation 30/133730/1
mpriyank [Wed, 22 Mar 2023 12:08:55 +0000 (12:08 +0000)]
Update documnetation

- update release notes and sync the openapi specs as per the latest
  changes

Issue-ID: CPS-1572
Change-Id: I1dedad736664e3bdd164ba371270c1cf4586515d
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2 years agoMerge "Subscription model with status and predicates"
Priyank Maheshwari [Wed, 22 Mar 2023 11:28:02 +0000 (11:28 +0000)]
Merge "Subscription model with status and predicates"

2 years agoMerge "Add event to mapper as well"
Luke Gleeson [Wed, 22 Mar 2023 10:27:39 +0000 (10:27 +0000)]
Merge "Add event to mapper as well"

2 years agoMerge "Query data nodes across all anchors under one dataspace"
Priyank Maheshwari [Wed, 22 Mar 2023 09:49:47 +0000 (09:49 +0000)]
Merge "Query data nodes across all anchors under one dataspace"

2 years agoSubscription model with status and predicates 23/133623/11
emaclee [Mon, 13 Mar 2023 09:27:24 +0000 (09:27 +0000)]
Subscription model with status and predicates

Issue-ID: CPS-1497
Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
Change-Id: I4a81389797620eac9b67f31ddcbb4d5168d742ce

2 years agoAdd event to mapper as well 12/133712/3
mpriyank [Tue, 21 Mar 2023 09:59:00 +0000 (09:59 +0000)]
Add event to mapper as well

- Explicitly add event to the mapper
- Also parameterized the cm-events topic to be overridden later

Issue-ID: CPS-1554
Change-Id: Ia6e75117dbb4214648d40318989c4c5fe6fd69f1
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2 years agoQuery data nodes across all anchors under one dataspace 15/132715/23
rajesh.kumar [Wed, 14 Dec 2022 14:27:29 +0000 (14:27 +0000)]
Query data nodes across all anchors under one dataspace

Issue-ID: CPS-1396
Change-ID: I73f97f986a817d423f93a8d922dcd9647b1412ab
Signed-off-by: rajesh.kumar <rk00747546@techmahindra.com>
2 years agoScript to fully automate CM-handle de-registration 36/133636/3
sourabh_sourabh [Mon, 20 Mar 2023 15:53:44 +0000 (15:53 +0000)]
Script to fully automate CM-handle de-registration

Issue-ID: CPS-1552
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: Ie1ea0cf410f78f1a8675c30d2e278a407afc0d0a
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
2 years agoScript to diff metrics reports 35/133635/3
danielhanrahan [Sun, 5 Mar 2023 12:20:40 +0000 (12:20 +0000)]
Script to diff metrics reports

- Added Python script to subtract metrics reports
- Moved scripts to test-tools/ folder

Issue-ID: CPS-1551
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: I4547eb523135dfc0441b5d47ab7f81b184bf836a

2 years agoMerge "CPS-1526 Fix response message for PATCH operation"
Luke Gleeson [Mon, 20 Mar 2023 15:27:38 +0000 (15:27 +0000)]
Merge "CPS-1526 Fix response message for PATCH operation"

2 years agoCPS-1526 Fix response message for PATCH operation 42/133542/13
arpitsingh [Fri, 3 Mar 2023 16:08:57 +0000 (21:38 +0530)]
CPS-1526 Fix response message for PATCH operation

- Fixed the Response code and message when trying to update multiple
  data trees at once
- Response code changed to 400
- Since the patch operation across multiple data trees is not
  supported when xpath is set to root node xpath, appropriate message is
  returned in response
- Existing functionality of updating one data node with root node xpath
  remains as it is.
- Updated API documentation and release notes

Issue-ID: CPS-1526
Signed-off-by: arpitsingh <as00745003@techmahindra.com>
Change-Id: I5d25a06bb5d407316ccfb2f85877cbe56a9f6f31

2 years agoAvc Event prop rename 98/133698/1
mpriyank [Mon, 20 Mar 2023 10:55:32 +0000 (10:55 +0000)]
Avc Event prop rename

- rename the eventTarget property as eventSource as per the schema in
  the spike
- fixed the integration test and sample file

Issue-ID: CPS-1554
Change-Id: Ieb8b749c6f64d69d87cacadae17a4589e9908cf2
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2 years agoMerge "Enable all Sphinx build warnings as errors"
Toine Siebelink [Mon, 20 Mar 2023 09:26:59 +0000 (09:26 +0000)]
Merge "Enable all Sphinx build warnings as errors"

2 years agoEnable all Sphinx build warnings as errors 75/133675/2
Cédric Ollivier [Wed, 15 Mar 2023 20:40:48 +0000 (21:40 +0100)]
Enable all Sphinx build warnings as errors

It also fixes several issues to pass the gate.
Please note that .. code-block :: json content must be json.

Issue-ID: DOC-798
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
Change-Id: I38a751b67ab70a5ed5d61cdd49fe914c7b9270cd

2 years agoMerge "Enhance DMI Data AVC Event schema"
Luke Gleeson [Wed, 15 Mar 2023 10:51:38 +0000 (10:51 +0000)]
Merge "Enhance DMI Data AVC Event schema"

2 years agoMerge "Forward Subscription Information to DMI Plugin(s)"
Priyank Maheshwari [Wed, 15 Mar 2023 09:37:04 +0000 (09:37 +0000)]
Merge "Forward Subscription Information to DMI Plugin(s)"

2 years agoReduce dataspace/anchor lookups in CpsDataService 27/133627/6
danielhanrahan [Tue, 7 Mar 2023 20:53:04 +0000 (20:53 +0000)]
Reduce dataspace/anchor lookups in CpsDataService

- Use Anchor object instead of names in processDataUpdatedEventAsync
- Use Anchor object instead of names in buildDataNodes
- Avoid unnecessary ArrayList copy in updateDataNodesAndDescendants

Issue-ID: CPS-1536
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: I46936a655a3d151357e55b68e1c4161e07100e84

2 years agoMerge "Fetch fragment entities using recursive SQL query"
Toine Siebelink [Tue, 14 Mar 2023 16:27:11 +0000 (16:27 +0000)]
Merge "Fetch fragment entities using recursive SQL query"

2 years agoMerge "subscription-registry node in subscription loader"
Priyank Maheshwari [Tue, 14 Mar 2023 15:47:14 +0000 (15:47 +0000)]
Merge "subscription-registry node in subscription loader"

2 years agoEnhance DMI Data AVC Event schema 52/133652/1
mpriyank [Tue, 14 Mar 2023 13:51:15 +0000 (13:51 +0000)]
Enhance DMI Data AVC Event schema

- Enhancing the DMI Data Avc Event to have the event section as Object
  at the moment.

Issue-ID: CPS-1554
Change-Id: I7f9e1d66ab146f4133886188cd3e4049ac17c76b
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2 years agosubscription-registry node in subscription loader 33/133633/2
lukegleeson [Mon, 13 Mar 2023 15:00:19 +0000 (15:00 +0000)]
subscription-registry node in subscription loader

Adding top node subscription-registry for the adding of subscriptions

Issue-ID: CPS-1548
Signed-off-by: lukegleeson <luke.gleeson@est.tech>
Change-Id: I4107293ce023e4c53dbb8b5d3feb0922cc3d4817

2 years agoForward Subscription Information to DMI Plugin(s) 31/133431/9
lukegleeson [Thu, 23 Feb 2023 11:43:13 +0000 (11:43 +0000)]
Forward Subscription Information to DMI Plugin(s)

Note: Implemented common EventsPublisher class

Issue-ID: CPS-1431
Signed-off-by: lukegleeson <luke.gleeson@est.tech>
Change-Id: I292a95f2c990a140f5fd63622ca4eba3f8284b9e

2 years agoFetch fragment entities using recursive SQL query 11/133511/12
danielhanrahan [Wed, 8 Mar 2023 13:50:34 +0000 (13:50 +0000)]
Fetch fragment entities using recursive SQL query

- Add SQL query that can fetch needed fragments to any given depth
- Update getFragmentEntities to use new query
- Remove now unused FragmentRepositoryMultiPathQuery
- Remove unused TempTableCreator method
- Result: getDataNodesForMultipleXpaths is up to 10 times faster

Issue-ID: CPS-1525
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: I07cbc9da5ab994ce7e0c2b02d7ca05089f05dab0

2 years agoMerge "Reduce dataspace/anchor lookups in CpsDataPersistenceService"
Toine Siebelink [Mon, 13 Mar 2023 14:18:02 +0000 (14:18 +0000)]
Merge "Reduce dataspace/anchor lookups in CpsDataPersistenceService"

2 years agoMerge "Add new metrics to the get data node method"
Toine Siebelink [Mon, 13 Mar 2023 14:09:27 +0000 (14:09 +0000)]
Merge "Add new metrics to the get data node method"

2 years agoReduce dataspace/anchor lookups in CpsDataPersistenceService 99/133599/5
danielhanrahan [Tue, 7 Mar 2023 20:35:14 +0000 (20:35 +0000)]
Reduce dataspace/anchor lookups in CpsDataPersistenceService

- Remove unneeded calls to DataspaceRepository::getByName
- Remove unneeded calls to AnchorRepository::getByDataspaceAndName
- Refactor FragmentRepository

Issue-ID: CPS-1536
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: I2121f6247070ee4a7c000e06ec66a6278b758540

2 years agoMake single deleteDataNode use plural deleteDataNodes 82/133582/7
danielhanrahan [Fri, 10 Mar 2023 13:27:01 +0000 (13:27 +0000)]
Make single deleteDataNode use plural deleteDataNodes

- Make deleteDataNode and deleteListDataNode call deleteDataNodes
- Add onlySupportListDeletion option to deleteDataNodes to support
  original deleteListDataNode behaviour
- Allow delete root xpath in deleteDataNodes
- Fix incorrect use of PathParsingException in deleteDataNode
- Update performance tests timings

Issue-ID: CPS-1523
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: I92c3c3ce606a5ab2cb8e6779d1ee0f9853529982

2 years agoAdd schema_set_yang_resources index to tests 11/133611/4
danielhanrahan [Thu, 9 Mar 2023 17:26:34 +0000 (17:26 +0000)]
Add schema_set_yang_resources index to tests

- Add missing index to liquibase test-changelog.yaml

Issue-ID: CPS-1535
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: I2f8ee9f66b3f433be2f61e17759f0f6c9f2e4707

2 years agoBump CPS version 19/133619/1
mpriyank [Fri, 10 Mar 2023 13:48:20 +0000 (13:48 +0000)]
Bump CPS version

- bump cps version to 3.2.6-snapshot

Issue-ID: CPS-1547
Change-Id: I397b8e5f22269c270c2fa7823713869b478622f9
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2 years agoAdd container yaml 18/133618/1
mpriyank [Fri, 10 Mar 2023 12:50:47 +0000 (12:50 +0000)]
Add container yaml

- add container yaml for 3.2.5

Issue-ID: CPS-1546
Change-Id: I1d505c67cfdfbc83f461fb561557783b43615df3
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2 years agomaven stage yaml 17/133617/1
mpriyank [Fri, 10 Mar 2023 12:33:27 +0000 (12:33 +0000)]
maven stage yaml

- add maven stage yaml file for 3.2.5 cps-core

Issue-ID: CPS-1546
Change-Id: Ic167b58b2770de6e025e704311cf32435ad27e5c
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2 years agoRelease notes update 14/133614/1
mpriyank [Fri, 10 Mar 2023 11:48:23 +0000 (11:48 +0000)]
Release notes update

- add release notes for introduction of the control switch

Issue-ID: CPS-1545
Change-Id: I738b2f8ceea089af5eebd362c03ca2eb13f351d8
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2 years agoIntroduce control switch 13/133613/1
mpriyank [Fri, 10 Mar 2023 10:07:19 +0000 (10:07 +0000)]
Introduce control switch

- introduced a control switch and keeping it as false due to init issues

Issue-ID: CPS-1537
Change-Id: I8455a5ff6fea09527c6f810ffbc620b4e38c488c
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2 years agoBump CPS version 10/133610/1
mpriyank [Thu, 9 Mar 2023 17:58:31 +0000 (17:58 +0000)]
Bump CPS version

- bump the CPS version from 3.2.4-SNAPSHOT to 3.2.5-SNAPSHOT

Issue-ID: CPS-1543
Change-Id: I28e46fdeff86c71bd1ad89ae9aaef8ddb4994bfc
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2 years agoAdd container yaml 09/133609/1
mpriyank [Thu, 9 Mar 2023 17:23:42 +0000 (17:23 +0000)]
Add container yaml

- Step 6 of the release process to add container YAML file

Issue-ID: CPS-1542
Change-Id: I244dfaec50828e0135350589d848ca79b300971f
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2 years agoAdd Maven yaml 08/133608/1
mpriyank [Thu, 9 Mar 2023 17:05:38 +0000 (17:05 +0000)]
Add Maven yaml

- Step 5 of the release process to add maven yaml

Issue-ID: CPS-1542
Change-Id: I793c942af949a4be1c1d9c0efd573e30158fea8e
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2 years agoRelease notes for the bugs 05/133605/1
mpriyank [Thu, 9 Mar 2023 16:33:02 +0000 (16:33 +0000)]
Release notes for the bugs

- Release notes

Issue-ID: CPS-1541
Change-Id: I0339dff64c695cb0c9b605a38572696895a09683
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2 years agoBug:SubscriptionModelLoader.getFileContentAsString 04/133604/2
emaclee [Thu, 9 Mar 2023 15:50:32 +0000 (15:50 +0000)]
Bug:SubscriptionModelLoader.getFileContentAsString

Issue-ID: CPS-1537
Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
Change-Id: Icc88a8bf40830853a208e79658f3c590185ad051

2 years agoMerge "Create Base and Sample Performance Integration Tests"
Sourabh Sourabh [Thu, 9 Mar 2023 13:01:12 +0000 (13:01 +0000)]
Merge "Create Base and Sample Performance Integration Tests"

2 years agoCreate Base and Sample Performance Integration Tests 78/133478/4
ToineSiebelink [Tue, 28 Feb 2023 18:12:51 +0000 (18:12 +0000)]
Create Base and Sample Performance Integration Tests

- added data (folders) for different models and json data
- added base and data for cps-ncmp (registry) specific test cases
- integrated Ahila's (large) openroadm model and data
  (corrected version provided by Lee Anjella)
- created profiles to exclude/include *PerfTest
- fixed dependency test check
- included integration test for overall coverage
- increased margings in existing perf test to reduce nordix intermitten failures

Issue-ID: CPS-1516
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
Change-Id: Ia82826f610636c14aa7e8939b385c278e5039817

2 years agoAdd new metrics to the get data node method 93/133593/2
kissand [Thu, 2 Mar 2023 12:30:17 +0000 (13:30 +0100)]
Add new metrics to the get data node method

Issue-ID: CPS-1509
Change-Id: I2eded9a23b56f5263591c710c7a707cf281f93d7
Signed-off-by: kissand <andras.zoltan.kiss@est.tech>
2 years agoMerge "[CPS] Add configurable params for topic"
Toine Siebelink [Wed, 8 Mar 2023 18:07:13 +0000 (18:07 +0000)]
Merge "[CPS] Add configurable params for topic"

2 years ago[CPS] Add configurable params for topic 85/133585/3
mpriyank [Wed, 8 Mar 2023 15:29:57 +0000 (15:29 +0000)]
[CPS] Add configurable params for topic

- Configurable parameter for topic dmi-cm-events

Issue-ID: CPS-1538
Change-Id: I5396ee8f50f33ea3c117291a314f10c1870966bc
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2 years agoMerge "Add index to schema_set_yang_resources table"
Sourabh Sourabh [Wed, 8 Mar 2023 09:52:59 +0000 (09:52 +0000)]
Merge "Add index to schema_set_yang_resources table"

2 years agoMerge "Update CPSarchitecture release notes"
Luke Gleeson [Wed, 8 Mar 2023 09:45:45 +0000 (09:45 +0000)]
Merge "Update CPSarchitecture release notes"

2 years agoAdd index to schema_set_yang_resources table 72/133572/2
danielhanrahan [Tue, 7 Mar 2023 16:56:08 +0000 (16:56 +0000)]
Add index to schema_set_yang_resources table

Currently, the database is sequentially scanning when deleting from
schema_set_yang_resources table as there are no indexes on the table.
Adding an index doubles performance of NCMP CM-handle deregistration.

Issue-ID: CPS-1535
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: Ia6ac7ef95d1662f49a77fc72112f1e29a67079ff

2 years agoDrop temp table when transaction finishes 70/133570/1
danielhanrahan [Thu, 2 Mar 2023 23:27:09 +0000 (23:27 +0000)]
Drop temp table when transaction finishes

By default, temp tables are persisted until the end of the session.
This causes "Out of shared memory" errors in the database, which then
auto-vacuums the orphaned temp tables to free memory. To fix this, we
drop temp tables when the transaction finishes, using ON COMMIT DROP.

Issue-ID: CPS-1533
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: Iac47d85e9621531a4a95b99c4becc8cc95242721

2 years agoRelease process stage 7 66/133566/1
seanbeirne [Tue, 7 Mar 2023 13:42:04 +0000 (13:42 +0000)]
Release process stage 7

Issue-ID: CPS-1529
Signed-off-by: seanbeirne <sean.beirne@est.tech>
Change-Id: Ie6c6276f4612b919762479d2461b4e72cb886245

2 years agoRelease process stage 6 63/133563/2
seanbeirne [Tue, 7 Mar 2023 11:20:56 +0000 (11:20 +0000)]
Release process stage 6

Issue-ID: CPS-1529
Signed-off-by: seanbeirne <sean.beirne@est.tech>
Change-Id: I32fd42c2fc11279710f9d88b8c41df5e8b3a6d1b

2 years agoRelease process step 5 61/133561/2
seanbeirne [Tue, 7 Mar 2023 10:36:18 +0000 (10:36 +0000)]
Release process step 5

Issue-ID: CPS-1529
Signed-off-by: seanbeirne <sean.beirne@est.tech>
Change-Id: I338f7bbaea92a4e6bdbbb6f632976ac81a6f5c63

2 years agoUpdate CPSarchitecture release notes 57/133557/1
emaclee [Tue, 7 Mar 2023 09:29:11 +0000 (09:29 +0000)]
Update CPSarchitecture release notes

Issue-ID: CPS-1532
Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
Change-Id: If82b02e7ee4d28299f0c362ad483988a6358c1aa

2 years agoMerge "JAVA onboarding of YANG model"
Priyank Maheshwari [Mon, 6 Mar 2023 09:56:23 +0000 (09:56 +0000)]
Merge "JAVA onboarding of YANG model"

2 years agoJAVA onboarding of YANG model 17/133217/16
emaclee [Thu, 9 Feb 2023 15:17:13 +0000 (15:17 +0000)]
JAVA onboarding of YANG model

- removed docker compose init container
- removed init container script files
- created new model loader class to onboard YANG model which
  runs after the application has set up
- new model loader class is created in new package in
  cps-service (org.onap.cps.ncmp.init)

Issue-ID: CPS-1467
Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
Change-Id: I35fe82817aff7783520acf8db66ad504271026bd

2 years agoRefactor cmHandle(ID) queries 22/133522/4
seanbeirne [Thu, 23 Feb 2023 15:16:38 +0000 (15:16 +0000)]
Refactor cmHandle(ID) queries

- first execute cm-handle id search only
- get cm handles for ids only when needed using multiple-get-method
- use Collection interface where posisble (instead of Set)
- use java Function to combine multiple queries in a more genric way

Issue-ID: CPS-1494
Signed-off-by: seanbeirne <sean.beirne@est.tech>
Change-Id: Icfcb8ec94f75e261303aaee5c9034b920c01f3c4

2 years agoAdd DataNodeNotFoundException to deleteDataNodes 82/133482/2
danielhanrahan [Tue, 28 Feb 2023 16:25:08 +0000 (16:25 +0000)]
Add DataNodeNotFoundException to deleteDataNodes

Current implementation of NCMP handle de-registration relies on
DataNodeNotFoundException being thrown to report errors.

- Make deleteDataNodes throw DataNodeFoundExceptionBatch
- Update performance test timings

Issue-ID: CPS-1481
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: Ib833bdb4a23d24e1784bdaf4e5e5e8a9acb41c54

2 years agoSkip deleting list xpaths that are list elements 20/133420/4
danielhanrahan [Sun, 26 Feb 2023 14:27:06 +0000 (14:27 +0000)]
Skip deleting list xpaths that are list elements

List elements cannot be lists. Filtering list elements before trying
to delete lists by xpaths doubles performance when deleting list
elements (which doubles performance of CM handle de-registration).

Issue-ID: CPS-1511
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: Ieb6002212d006396d468f27f853708b5aa1e31f2

2 years agoMerge "Expand CPS Service Integration Test (framework)"
Toine Siebelink [Mon, 27 Feb 2023 17:21:26 +0000 (17:21 +0000)]
Merge "Expand CPS Service Integration Test (framework)"

2 years agoExpand CPS Service Integration Test (framework) 01/133401/4
ToineSiebelink [Thu, 23 Feb 2023 15:49:40 +0000 (15:49 +0000)]
Expand CPS Service Integration Test (framework)

- Created package structure
- Created several test bases
- Created complete test set for Admin service
- Created first test for Data service
- Added human-readable toString() to FetchDescendantsOption for test reporting and debuging purposes
- Renamed fetch descendants (enum) direct children option for consistency with others options
- TODO: Add sample performance test (and base)

Issue-ID: CPS-475
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
Change-Id: I75317686161be41662b6bf81314a9cd425ddd6eb

2 years agoImprove performance for update data nodes 88/133388/4
danielhanrahan [Tue, 21 Feb 2023 22:55:05 +0000 (22:55 +0000)]
Improve performance for update data nodes

- Extract method getFragmentEntities from getDataNodes
- Remove unused code from getFragmentEntity
- Use bulk getFragmentEntities in updateDataNodesAndDescendants
- Update performance test timings

Issue-ID: CPS-1504
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: Icd2c6a0e6009e152de43090cbc23a21349703da2

2 years agoRevert "Omit descendants when not need in ncmp inventory queries" 99/133399/1
lukegleeson [Thu, 23 Feb 2023 14:08:10 +0000 (14:08 +0000)]
Revert "Omit descendants when not need in ncmp inventory queries"

This reverts commit eba77598601a7e3430f9582dfe433495ded3244c.

Signed-off-by: lukegleeson <luke.gleeson@est.tech>
Change-Id: I76a0d1252177c4115de9190ee7f3bb6d15c4e19a