Dominik Mizyn [Fri, 16 Aug 2019 07:57:01 +0000 (09:57 +0200)]
Portal Spring Boot version Hibernate implementation
Create classes that represent tables in the original database.
Issue-ID: PORTAL-705
Change-Id: I86c768dd4b73c8cddeaab9960b89ed658921c00f
Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>
Dominik Mizyn [Fri, 16 Aug 2019 07:55:30 +0000 (09:55 +0200)]
Portal Spring Boot version Hibernate implementation
Create classes that represent tables in the original database.
Issue-ID: PORTAL-705
Change-Id: Ib9c6c40b77d2500c96d06ab477ab44bd93d1fe83
Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>
Dominik Mizyn [Fri, 16 Aug 2019 07:53:53 +0000 (09:53 +0200)]
Portal Spring Boot version Hibernate implementation
Create classes that represent tables in the original database.
Issue-ID: PORTAL-705
Change-Id: Ic5ff544a367ae51356a7196ac591f53b7d837265
Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>
Dominik Mizyn [Fri, 16 Aug 2019 07:51:43 +0000 (09:51 +0200)]
Portal Spring Boot version Hibernate implementation
Create classes that represent tables in the original database.
Issue-ID: PORTAL-705
Change-Id: Icd4a3e2c1f0ed97ddc34baa1463d9806b442e359
Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>
Dominik Mizyn [Fri, 16 Aug 2019 07:47:35 +0000 (09:47 +0200)]
Portal Spring Boot version Hibernate implementation
Create classes that represent tables in the original database.
Issue-ID: PORTAL-705
Change-Id: I48be45d542506b61b0acc8b517b46fde97b80452
Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>
Dominik Mizyn [Fri, 16 Aug 2019 07:45:10 +0000 (09:45 +0200)]
Portal Spring Boot version Hibernate implementation
Create classes that represent tables in the original database.
Issue-ID: PORTAL-705
Change-Id: I69bfbf24fe045cd130f0e23f9654f19c47e629ab
Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>
Dominik Mizyn [Fri, 16 Aug 2019 07:41:21 +0000 (09:41 +0200)]
Portal Spring Boot version Hibernate implementation
Create classes that represent tables in the original database.
Issue-ID: PORTAL-705
Change-Id: I2189657c6101c8e853ef060bed6206e38924f08f
Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>
Dominik Mizyn [Fri, 16 Aug 2019 07:38:51 +0000 (09:38 +0200)]
Portal Spring Boot version Hibernate implementation
Create classes that represent tables in the original database.
Issue-ID: PORTAL-705
Change-Id: I3bb0ca52fba266d590dfe85dabf1c1d52b8d7fc4
Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>
Parshad Patel [Wed, 14 Aug 2019 05:58:35 +0000 (14:58 +0900)]
Sonar fix in ecomp-portal-BE-common
Override "equals(Object obj)" to comply with the contract of the "compareTo(T o)" method
Make "auditTrail" transient or serializable
Reduce the number of conditional operators (4) used in the expression (maximum allowed 3)
Issue-ID: PORTAL-562
Change-Id: Ic867eca2d2f57d68bbc902f27bf0eb9753aeeaa1
Signed-off-by: Parshad Patel <pars.patel@samsung.com>
Welch, Lorraine (lb2391) [Wed, 14 Aug 2019 14:38:50 +0000 (10:38 -0400)]
Changed DB script back to Dublin
Issue-ID: PORTAL-700
Signed-off-by: Welch, Lorraine (lb2391) <lb2391@att.com>
Change-Id: Ib4587a01b72ff48e7e45967cb202d6acf153d9b6
Manoop Talasila [Tue, 13 Aug 2019 18:21:35 +0000 (18:21 +0000)]
Merge "Fix sonar issues in portal"
Manoop Talasila [Tue, 13 Aug 2019 18:21:26 +0000 (18:21 +0000)]
Merge "AppsControllerExternalRequest class fix"
Manoop Talasila [Tue, 13 Aug 2019 18:21:12 +0000 (18:21 +0000)]
Merge "Create module for Portal Spring Boot version"
Manoop Talasila [Tue, 13 Aug 2019 18:21:01 +0000 (18:21 +0000)]
Merge "ExternalRoleDetails class fix"
Manoop Talasila [Tue, 13 Aug 2019 18:20:55 +0000 (18:20 +0000)]
Merge "EPUserUtils class fix"
Manoop Talasila [Tue, 13 Aug 2019 18:20:50 +0000 (18:20 +0000)]
Merge "SchedulerRestInterface class fix"
Manoop Talasila [Tue, 13 Aug 2019 18:20:45 +0000 (18:20 +0000)]
Merge "NotificationCleanupConfig class fix"
Manoop Talasila [Tue, 13 Aug 2019 18:20:39 +0000 (18:20 +0000)]
Merge "SchedulerController class fix"
Parshad Patel [Tue, 6 Aug 2019 10:41:24 +0000 (19:41 +0900)]
Fix sonar issues in portal
Use a logger to log this exception
Make sure creating this cookie without the "secure" flag is safe here
Either re-interrupt this method or rethrow the "InterruptedException"
Issue-ID: PORTAL-562
Change-Id: I91d6adce835d9adec4328642e8445f074f7d2d57
Signed-off-by: Parshad Patel <pars.patel@samsung.com>
Dominik Mizyn [Tue, 6 Aug 2019 07:10:46 +0000 (09:10 +0200)]
AppsControllerExternalRequest class fix
Sonar errors fix in class AppsControllerExternalRequest
Issue-ID: PORTAL-664
Change-Id: If89e9fa62525c46abc369df4bf4c760cee3abb8a
Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>
Dominik Mizyn [Tue, 6 Aug 2019 06:43:07 +0000 (08:43 +0200)]
Create module for Portal Spring Boot version
Create module for Portal Spring Boot version
Issue-ID: PORTAL-681
Change-Id: I1e8398b36a0ffe3b884d9c2f66c45e5e5edecc20
Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>
Manoop Talasila [Mon, 5 Aug 2019 18:35:31 +0000 (18:35 +0000)]
Merge "Fix for NullPointerException in ecomp-portal-BE-common"
Manoop Talasila [Mon, 5 Aug 2019 18:34:45 +0000 (18:34 +0000)]
Merge "Fix copy&paste typo in b2bWhenScrollEnds"
Manoop Talasila [Thu, 1 Aug 2019 19:06:19 +0000 (15:06 -0400)]
Release latest portal docker images
Commenting the line as we do not want the build number to be part of portal_tag
Issue-ID: PORTAL-685
Signed-off-by: Manoop Talasila <talasila@research.att.com>
Change-Id: I086937664c57b3c5ea022d7e21fbec0efc26a49f
Manoop Talasila [Thu, 1 Aug 2019 17:20:11 +0000 (17:20 +0000)]
Merge "Updated Dubline Release Notes"
Sunder Tattavarada [Thu, 1 Aug 2019 16:24:26 +0000 (16:24 +0000)]
Merge "Release latest portal docker images"
Welch, Lorraine (lb2391) [Thu, 1 Aug 2019 15:25:48 +0000 (11:25 -0400)]
Updated Dubline Release Notes
Issue-ID: PORTAL-592
Signed-off-by: Welch, Lorraine (lb2391) <lb2391@att.com>
Change-Id: Ied0c6b28e10630d6917b174b65a72448e01c63e4
Manoop Talasila [Thu, 1 Aug 2019 15:19:17 +0000 (11:19 -0400)]
Release latest portal docker images
update env file to tag "elalto" docker versions for now to test
Issue-ID: PORTAL-685
Signed-off-by: Manoop Talasila <talasila@research.att.com>
Change-Id: I10edbddb4325a29e176a5513360333a3f5e6dcfa
Lorraine Welch [Thu, 1 Aug 2019 14:55:39 +0000 (14:55 +0000)]
Merge "Release latest portal docker images"
Lorraine Welch [Thu, 1 Aug 2019 14:26:01 +0000 (14:26 +0000)]
Merge "Enable jscript code coverage for accessment"
Lorraine Welch [Thu, 1 Aug 2019 14:25:55 +0000 (14:25 +0000)]
Merge "Update oparent version"
Artem Naluzhnyy [Thu, 1 Aug 2019 11:20:25 +0000 (13:20 +0200)]
Fix copy&paste typo in b2bWhenScrollEnds
Coverity-scan: CID-192000
Issue-ID: PORTAL-684
Signed-off-by: Artem Naluzhnyy <A.Naluzhnyy@samsung.com>
Change-Id: I582732835a39240dafb9bed9a8ddd4a564b071b3
Parshad Patel [Thu, 1 Aug 2019 10:55:05 +0000 (19:55 +0900)]
Fix for NullPointerException in ecomp-portal-BE-common
A "NullPointerException" could be thrown; "epUser" is nullable here
Either log or rethrow this exception
Issue-ID: PORTAL-562
Change-Id: I11a72534f75efec474f49f8a5cb66affb810348f
Signed-off-by: Parshad Patel <pars.patel@samsung.com>
Manoop Talasila [Wed, 31 Jul 2019 21:31:48 +0000 (17:31 -0400)]
Release latest portal docker images
update env file to 2.6.0 to build 2.6.0-SNAPSHOT docker versions for now to test
Issue-ID: PORTAL-685
Signed-off-by: Manoop Talasila <talasila@research.att.com>
Change-Id: I8019c7183b2d7579556c9c0daf5ac8e910b6ec42
Manoop Talasila [Wed, 31 Jul 2019 20:50:20 +0000 (16:50 -0400)]
Enable jscript code coverage for accessment
Issue-ID: PORTAL-678
Signed-off-by: Manoop Talasila <talasila@research.att.com>
Change-Id: I18a987dc2fbec7b10b3394cd46c36b21a0008aa7
Manoop Talasila [Wed, 31 Jul 2019 20:20:38 +0000 (20:20 +0000)]
Merge "Fix typo in addNewUser()"
Manoop Talasila [Wed, 31 Jul 2019 20:20:33 +0000 (20:20 +0000)]
Merge "Fix typo in isCssReady()"
Manoop Talasila [Wed, 31 Jul 2019 20:17:56 +0000 (20:17 +0000)]
Merge "Fix null pointer exception"
Manoop Talasila [Wed, 31 Jul 2019 20:16:48 +0000 (20:16 +0000)]
Merge "General sonar fixes"
Manoop Talasila [Wed, 31 Jul 2019 19:26:05 +0000 (15:26 -0400)]
Update oparent version
Update oparent version to 2.0.0
Issue-ID: PORTAL-679
Signed-off-by: Manoop Talasila <talasila@research.att.com>
Change-Id: I228a14b62ae0c4d388594558be1f9dbfc0346711
Artem Naluzhnyy [Tue, 30 Jul 2019 10:50:02 +0000 (12:50 +0200)]
Fix typo in addNewUser()
Coverity-scan: CID-192094
Issue-ID: PORTAL-684
Signed-off-by: Artem Naluzhnyy <A.Naluzhnyy@samsung.com>
Change-Id: If6dccd56be6c755771be7bf3724ee66ed10ac606
Artem Naluzhnyy [Tue, 30 Jul 2019 09:01:06 +0000 (11:01 +0200)]
Fix typo in isCssReady()
Coverity-scan: CID-192115
Issue-ID: PORTAL-16
Signed-off-by: Artem Naluzhnyy <A.Naluzhnyy@samsung.com>
Change-Id: If4aacbb6e7f2cdf6895a1ca6130247b8238414ef
Arindam Mondal [Tue, 23 Jul 2019 10:12:40 +0000 (19:12 +0900)]
Fix null pointer exception
+) Fix NPE
++) implement equals instead of ==
Issue-ID: PORTAL-680
Change-Id: I3a0df60b6171b114afc841b40838f6a4484370ee
Signed-off-by: arind.mondal <arind.mondal@samsung.com>
Manoop Talasila [Mon, 22 Jul 2019 19:32:45 +0000 (19:32 +0000)]
Merge "XSS Vulnerability fix in DashboardController"
Manoop Talasila [Mon, 22 Jul 2019 19:32:31 +0000 (19:32 +0000)]
Merge "XSS Vulnerability fix in ExternalAccessRolesControllerDashboardController"
Manoop Talasila [Mon, 22 Jul 2019 19:32:19 +0000 (19:32 +0000)]
Merge "XSS Vulnerability fix in AuxApiRequestMapperController"
Manoop Talasila [Mon, 22 Jul 2019 19:32:04 +0000 (19:32 +0000)]
Merge "XSS Vulnerability fix in SharedContextRestController"
Manoop Talasila [Mon, 22 Jul 2019 19:31:46 +0000 (19:31 +0000)]
Merge "XSS Vulnerability fix in WidgetsController"
Manoop Talasila [Mon, 22 Jul 2019 19:31:14 +0000 (19:31 +0000)]
Merge "XSS Vulnerability fix in AuditLogController"
Manoop Talasila [Mon, 22 Jul 2019 19:30:16 +0000 (19:30 +0000)]
Merge "XSS Vulnerability fix in AppContactUsController"
Manoop Talasila [Mon, 22 Jul 2019 19:29:25 +0000 (19:29 +0000)]
Merge "XSS Vulnerability fix in AppsController"
Arindam Mondal [Fri, 19 Jul 2019 04:58:03 +0000 (13:58 +0900)]
General sonar fixes
+) removed unused imports and done formatting
Issue-ID: PORTAL-680
Change-Id: I1f6ceca61dfc59726cc9e5f7ad802e5c9b0f4d6e
Signed-off-by: arindamm <arind.mondal@samsung.com>
Lorraine Welch [Fri, 19 Jul 2019 17:25:12 +0000 (17:25 +0000)]
Merge "NoClassDefFoundError javax/xml/bind/ValidationException"
Dominik Mizyn [Tue, 16 Jul 2019 11:00:07 +0000 (13:00 +0200)]
EPUserUtils class fix
Sonar errors EPUserUtils class fix
Issue-ID: PORTAL-667
Change-Id: I7a8a39ac52ee2da5d2c2ab0016a8bbea0acb4d21
Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>
Dominik Mizyn [Tue, 16 Jul 2019 10:40:11 +0000 (12:40 +0200)]
SchedulerRestInterface class fix
SchedulerRestInterface sonar errors class fix
Issue-ID: PORTAL-666
Change-Id: Ia060191cfccaf325101c5824233d2fa5ed00aca6
Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>
Dominik Mizyn [Tue, 16 Jul 2019 10:12:20 +0000 (12:12 +0200)]
ExternalRoleDetails class fix
Sonar errors in ExternalRoleDetails class
Issue-ID: PORTAL-665
Change-Id: I08b19539a4ca154caf8d75f52e3f04ca6ebc1d8f
Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>
Dominik Mizyn [Tue, 16 Jul 2019 08:48:10 +0000 (10:48 +0200)]
NotificationCleanupConfig class fix
Sonar errors fix in NotificationCleanupConfig class
Issue-ID: PORTAL-663
Change-Id: I8b5f5e9c024fe0c11240367c7154cafd7d885e4a
Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>
Dominik Mizyn [Mon, 15 Jul 2019 14:21:32 +0000 (16:21 +0200)]
SchedulerController class fix
Sonar errors fix.
Issue-ID: PORTAL-662
Change-Id: I87cb3e5721c93749e6a791a2c147bbe0d64f08d1
Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>
Dominik Mizyn [Mon, 15 Jul 2019 14:03:16 +0000 (16:03 +0200)]
XSS Vulnerability fix in DashboardController
Custom data validator used to fix this issue.
Issue-ID: OJSI-15
Change-Id: I84bfb81e5d87f80211d46d1141cbf8e4075660fe
Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>
Dominik Mizyn [Mon, 15 Jul 2019 12:03:18 +0000 (14:03 +0200)]
XSS Vulnerability fix in ExternalAccessRolesControllerDashboardController
Custom data validator used to fix this issue.
Issue-ID: OJSI-15
Change-Id: I9a978846ffc50d840a676b994aa4fb89248b5372
Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>
Dominik Mizyn [Mon, 15 Jul 2019 10:32:27 +0000 (12:32 +0200)]
XSS Vulnerability fix in AuxApiRequestMapperController
Custom data validotor is used to valid incoming data.
Issue-ID: OJSI-15
Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>
Change-Id: I1b2a1fe0fcb6278a7b12017479243009142c2cbd
Dominik Mizyn [Fri, 12 Jul 2019 14:12:19 +0000 (16:12 +0200)]
NoClassDefFoundError javax/xml/bind/ValidationException
Add dependency to pom.xml file
Issue-ID: PORTAL-660
Change-Id: I02e21024d10cca71b2f090117fb0afdf0b29578b
Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>
Dominik Mizyn [Fri, 12 Jul 2019 13:32:57 +0000 (15:32 +0200)]
Unused classes delete from Portal
These classes are unused anywhere in the Portal project.
Issue-ID: PORTAL-655
Change-Id: If92d0df0efb0b5120190a44c46b2fed31ba32b89
Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>
Dominik Mizyn [Thu, 6 Jun 2019 10:28:51 +0000 (12:28 +0200)]
XSS Vulnerability fix in SharedContextRestController
Custom data validator used to secure this class
Issue-ID: OJSI-15
Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>
Change-Id: I231731b9deb60310b698d70179cddd471cffd7fb
Dominik Mizyn [Thu, 6 Jun 2019 09:39:35 +0000 (11:39 +0200)]
XSS Vulnerability fix in WidgetsController
Custom data validator used to fix this issue.
Issue-ID: OJSI-15
Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>
Change-Id: I0113097b2118656780f4f9bca8b4ee99e85b6f6d
Dominik Mizyn [Thu, 6 Jun 2019 09:30:09 +0000 (11:30 +0200)]
XSS Vulnerability fix in AuditLogController
Custom data validator used to fix this issue.
Issue-ID: OJSI-15
Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>
Change-Id: Iafaca1806cf7106b91efdfd9cb40132020b114f2
Dominik Mizyn [Thu, 6 Jun 2019 09:18:50 +0000 (11:18 +0200)]
XSS Vulnerability fix in AppContactUsController
Custom data validator used to fix this issue.
Issue-ID: OJSI-15
Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>
Change-Id: Ie8df4df552cfe53e3839c7021284f0226ea56a39
Dominik Mizyn [Thu, 6 Jun 2019 08:52:16 +0000 (10:52 +0200)]
XSS Vulnerability fix in AppsController
Custom XSS filter used to fix thisa issue.
DataValidator upgrade to single instance of ValidatorFactory;
Issue-ID: OJSI-15
Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>
Change-Id: I7222cfb84e1e5bb240619aac9c7bca85d215229a
Dominik Mizyn [Thu, 11 Jul 2019 13:01:43 +0000 (15:01 +0200)]
CRLF fix in your-angular-app.rst file
Fix CRLF
Issue-ID: PORTAL-659
Change-Id: I562115ec29306e8a73b31f1f0e62e05b54cfdd9d
Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>
Krzysztof Opasiak [Wed, 10 Jul 2019 17:59:13 +0000 (19:59 +0200)]
Revert "Fix sql injection vulnerability"
This reverts commit
941133a42bad6a1d73c63913a950d1e4bc814fde.
This is required because this commit breaks the portal unit test due
to some other changes that happen between verify job and merge of that commit.
Issue-ID: OJSI-174
Change-Id: Ieb53f8ba23e2b1b05c67ec4d7d51c6d5107cfb87
Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com>
Sunder Tattavarada [Wed, 10 Jul 2019 15:30:16 +0000 (15:30 +0000)]
Merge "LanguageServiceImpl logging vulnerability fix"
Sunder Tattavarada [Wed, 10 Jul 2019 15:27:08 +0000 (15:27 +0000)]
Merge "EPAppServiceImpl class fix."
Manoop Talasila [Tue, 9 Jul 2019 15:29:40 +0000 (15:29 +0000)]
Merge "SharedContext class DB constraints"
Manoop Talasila [Tue, 9 Jul 2019 15:29:29 +0000 (15:29 +0000)]
Merge "FunctionalMenuRole class DB constraints"
Manoop Talasila [Tue, 9 Jul 2019 15:29:19 +0000 (15:29 +0000)]
Merge "PortalAdmin class DB constraints"
Manoop Talasila [Tue, 9 Jul 2019 15:29:07 +0000 (15:29 +0000)]
Merge "FavoritesFunctionalMenuItemJson class DB constraints"
Manoop Talasila [Tue, 9 Jul 2019 15:28:35 +0000 (15:28 +0000)]
Merge "EpNotificationItem class DB constraints"
Manoop Talasila [Tue, 9 Jul 2019 15:28:20 +0000 (15:28 +0000)]
Merge "EpRoleNotificationItem class DB constraints"
Manoop Talasila [Tue, 9 Jul 2019 15:27:48 +0000 (15:27 +0000)]
Merge "ExtractJar sonar issues fix"
Manoop Talasila [Tue, 9 Jul 2019 15:24:10 +0000 (15:24 +0000)]
Merge "CommonWidget class DB constraints"
Sunder Tattavarada [Tue, 9 Jul 2019 14:48:26 +0000 (14:48 +0000)]
Merge "XSS Vulnerability fix in PortalAdminController"
Sunder Tattavarada [Mon, 8 Jul 2019 19:28:28 +0000 (19:28 +0000)]
Merge "Fix sql injection vulnerability"
Sunder Tattavarada [Mon, 8 Jul 2019 19:28:02 +0000 (19:28 +0000)]
Merge "Fix sql injection vulnerability"
Sunder Tattavarada [Mon, 8 Jul 2019 19:27:46 +0000 (19:27 +0000)]
Merge "Fix sql injection vulnerability"
Sunder Tattavarada [Mon, 8 Jul 2019 19:26:49 +0000 (19:26 +0000)]
Merge "Fix sql injection vulnerability"
Sunder Tattavarada [Mon, 8 Jul 2019 19:26:38 +0000 (19:26 +0000)]
Merge "Fix sql injection vulnerability"
Dominik Mizyn [Fri, 5 Jul 2019 12:33:53 +0000 (14:33 +0200)]
XSS Vulnerability fix in PortalAdminController
Custom data validator used to fix this issue.
Issue-ID: OJSI-15
Change-Id: I224887d31e4e2d7301544194ef44ba38e66e047d
Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>
Dominik Mizyn [Wed, 3 Jul 2019 13:25:01 +0000 (15:25 +0200)]
AuthUtil method isAccessAllowed() argument change
Change argument length to match argument length from to sdk version.
Issue-ID: PORTAL-656
Change-Id: I6fe28800e0baccaab43419d3aa0d8c43b1ebe771
Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>
Dominik Mizyn [Mon, 1 Jul 2019 10:08:24 +0000 (12:08 +0200)]
LanguageServiceImpl logging vulnerability fix
Sonar issue: "Use a logger to log this exception" fix
This patch also minor code issues
Issue-ID: PORTAL-622
Change-Id: I304285ca7837bcf929249f7c6b93b6de9cf8fae5
Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>
Dominik Mizyn [Mon, 1 Jul 2019 09:52:31 +0000 (11:52 +0200)]
EPAppServiceImpl class fix.
Sonar issues fix:
Remove this unused "logger" private field.
Remove this unused "syncRests" private field.
unused imports delete and unneeded fields initialization fix.
StringBuilder performance fix.
Issue-ID: PORTAL-620
Change-Id: Ibd1cf732b216594b47801767d0a98e59b0aba200
Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>
Dominik Orliński [Mon, 17 Jun 2019 09:53:27 +0000 (11:53 +0200)]
Fix sql injection vulnerability
Use a variable binding instead of concatenation.
Issue-ID: OJSI-174
Signed-off-by: Dominik Orliński <d.orlinski@samsung.com>
Change-Id: Ia655ccf79800c132b3ac466016b8fdfd9f9c27bd
Dominik Orliński [Mon, 17 Jun 2019 09:53:25 +0000 (11:53 +0200)]
Fix sql injection vulnerability
Use a variable binding instead of concatenation.
Issue-ID: OJSI-174
Signed-off-by: Dominik Orliński <d.orlinski@samsung.com>
Change-Id: I9dcec677ee9edd0d274a486af37eb950d8e828cf
Dominik Orliński [Mon, 17 Jun 2019 09:53:22 +0000 (11:53 +0200)]
Fix sql injection vulnerability
Use a variable binding instead of concatenation.
Issue-ID: OJSI-174
Signed-off-by: Dominik Orliński <d.orlinski@samsung.com>
Change-Id: I8d72c819004f05fbbf464cde73b405f2028c7bb6
Dominik Mizyn [Fri, 21 Jun 2019 11:07:43 +0000 (13:07 +0200)]
PeerBroadcastSocket sonar issues fix and code refactor
Sonar issues fix and code refactor.
Session data save moved to another method.
Rest of code don't really do anything.
Issue-ID: PORTAL-624
Change-Id: I53b36377f2d2645d8c24ad2384959f0599e07303
Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>
Dominik Mizyn [Fri, 21 Jun 2019 10:27:38 +0000 (12:27 +0200)]
ONAPWelcomeController sonar issue fix
String viewName and getter/setter can be romoved from his class.
ONAPWelcomeController Overrides this field 1 to 1.
Issue-ID: PORTAL-652
Change-Id: Idbb41f52a63c6ea681f6ba7753991d766849e3a2
Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>
Dominik Mizyn [Fri, 21 Jun 2019 10:12:06 +0000 (12:12 +0200)]
ONAPLoginController sonar issues fix.
Sonar issues fix plus @Autowired in constructor not in fields.
Issue-ID: PORTAL-651
Change-Id: I99329b986877d040c6fdda9daf42a5c501a39605
Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>
Dominik Mizyn [Fri, 21 Jun 2019 09:49:41 +0000 (11:49 +0200)]
SimpleLoginStrategy sonar issues fix
"Either remove or fill this block of code."
"Move the "" string literal on the left side of this string comparison."
"Define and throw a dedicated exception instead of using a generic one."
Issue-ID: PORTAL-650
Change-Id: I92018287a6f585020f0ae6f042b1bb1de84a5e14
Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>
Dominik Mizyn [Fri, 21 Jun 2019 09:31:35 +0000 (11:31 +0200)]
OpenIdConnectLoginStrategy sonar issues fix
Redundant suppression("rawtypes") removed.
Sonar issue:
Move the "" string literal on the left side of this string comparison.
Define and throw a dedicated exception instead of using a generic one.
Issue-ID: PORTAL-649
Change-Id: Ia2c80ad4848c22c94a2db731425250784d382841
Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>
Dominik Orliński [Mon, 17 Jun 2019 09:53:35 +0000 (11:53 +0200)]
Fix sql injection vulnerability
Use a variable binding instead of concatenation.
Issue-ID: OJSI-174
Signed-off-by: Dominik Orliński <d.orlinski@samsung.com>
Change-Id: I0574e882e4d500408b6a6bab8986822669cba5d4
Dominik Orliński [Mon, 17 Jun 2019 09:53:38 +0000 (11:53 +0200)]
Fix sql injection vulnerability
Use a variable binding instead of concatenation.
Change test 'getAppRolesForNonCentralizedPartnerAppTest'.
Issue-ID: OJSI-174
Signed-off-by: Dominik Orliński <d.orlinski@samsung.com>
Change-Id: Ia75da49ed582836a47b5fdcddab62fbe02e36e72