sdc.git
4 years agoRemove Proprietary notices 77/91777/1
Ofir Sonsino [Sun, 21 Jul 2019 10:16:39 +0000 (13:16 +0300)]
Remove Proprietary notices

Change-Id: I038ed4b764d592d013d8b4b2ae3b69b2961c518a
Issue-ID: SDC-2471
Signed-off-by: Ofir Sonsino <os0695@intl.att.com>
4 years agoAllow relative path for SOL004 descriptors import 63/91363/2
andre.schmid [Fri, 12 Jul 2019 12:33:10 +0000 (12:33 +0000)]
Allow relative path for SOL004 descriptors import

Allow the use of relative path on SOL004 descriptors imports. Resolves
imports with "/", "../" or "./" entries during validation and package
processing.
Validate if the reference is inside the package.
Fix problem where imported descriptor files, described as a non string
scalar yaml entry, were not being checked by the validator.

Change-Id: Ie5a32736b6090b4adf178e8714f7460bcd068def
Issue-ID: SDC-2422
Signed-off-by: andre.schmid <andre.schmid@est.tech>
4 years agoSDC alignment SOL004 2.6.1 42/91742/2
bilal.iqbal [Fri, 19 Jul 2019 13:39:52 +0000 (13:39 +0000)]
SDC alignment SOL004 2.6.1

Updating TOSCA.meta metadata Created-by key to Created-By
Issue-ID: SDC-2402

Change-Id: Ice17dac288d745292bdd8d296bd1ae3eedbff223
Signed-off-by: bilal.iqbal <bilal.iqbal@est.tech>
4 years agoRemove duplicated entries on error-configuration.yaml 36/91536/2
vasraz [Tue, 16 Jul 2019 13:36:27 +0000 (13:36 +0000)]
Remove duplicated entries on error-configuration.yaml

Change-Id: Ie9caf4a01283df368fd441f8ddecc82b84caa861
Issue-ID: SDC-2455
Signed-off-by: vasraz <vasyl.razinkov@est.tech>
4 years agocatalog-be servlets refactoring 54/91354/7
Piotr Darosz [Wed, 10 Jul 2019 11:14:39 +0000 (13:14 +0200)]
catalog-be servlets refactoring

Add constructor injection to servlets inside catalog-be project

Change-Id: I46c85f932cbcc275ce82ce64ec1978ffec98ea9b
Issue-ID: SDC-2442
Signed-off-by: Piotr Darosz <piotr.darosz@nokia.com>
4 years agoAdd unit test for PackageNotFoundErrorBuilder 49/91149/3
m.kowalski3 [Wed, 10 Jul 2019 10:51:42 +0000 (12:51 +0200)]
Add unit test for PackageNotFoundErrorBuilder

Issue-ID: SDC-2327
Signed-off-by: Marcin Kowalski <m.kowalski3@partner.samsung.com>
Change-Id: I7b553f8eb03b7a1bd8d059ea12dcbdff79100f03

4 years agofixing warnings from checkstyle in catalog-fe 11/91511/5
Bartosz Gardziejewski [Tue, 16 Jul 2019 09:09:50 +0000 (11:09 +0200)]
fixing warnings from checkstyle in catalog-fe

Issue-ID: SDC-2454
Signed-off-by: Bartosz Gardziejewski <bartosz.gardziejewski@nokia.com>
Change-Id: I1fbeccb8c661233b81fea787457631f4a898fd46

4 years agofixing warnings from checkstyle in common-app-api 33/91533/5
Bartosz Gardziejewski [Tue, 16 Jul 2019 13:09:21 +0000 (15:09 +0200)]
fixing warnings from checkstyle in common-app-api

Issue-ID: SDC-2454
Signed-off-by: Bartosz Gardziejewski <bartosz.gardziejewski@nokia.com>
Change-Id: I17c562380e39f3eab6b3bff45a4a12fe8a586cec

4 years agoFix checkstyle violations in sdc-main/common 32/91532/2
michal.banka [Tue, 16 Jul 2019 11:51:00 +0000 (13:51 +0200)]
Fix checkstyle violations in sdc-main/common

Change-Id: I3e132cf4bffd77f9910bf6eff2026c3267873b11
Issue-ID: SDC-2454
Signed-off-by: michal.banka <michal.banka@nokia.com>
4 years agoupgrade to ONAP-UI 45/91445/2
Arielk [Sun, 7 Jul 2019 09:56:11 +0000 (12:56 +0300)]
upgrade to ONAP-UI

Change-Id: Iddc6a62cc0b7981daa5ceb2422b967c95b031422
Issue-ID: SDC-2411
Signed-off-by: Arielk <Ariel.Kenan@amdocs.com>
4 years agoFixing build 30/91530/1
Wojciech Sliwka [Tue, 16 Jul 2019 12:02:03 +0000 (14:02 +0200)]
Fixing build

Change-Id: Ia75cdf511e44347294bb646add89b6c1f60f239c
Issue-ID: SDC-2403
Signed-off-by: Wojciech Sliwka <wojciech.sliwka@nokia.com>
4 years agoConstructor injection in asdctool 07/90707/2
Piotr Darosz [Mon, 1 Jul 2019 06:23:51 +0000 (08:23 +0200)]
Constructor injection in asdctool

Use constructor injection where possible

Change-Id: Ibc80850166406a6e3230f555818988109e6ca776
Issue-ID: SDC-2403
Signed-off-by: Piotr Darosz <piotr.darosz@nokia.com>
4 years agoAdd Lombok support to Repository 04/90704/2
noahs [Sun, 30 Jun 2019 07:28:41 +0000 (10:28 +0300)]
Add Lombok support to Repository

add @Data annotation

Change-Id: I0a56a2f1978035a00eb4edafd5ecc7db6a7301a4
Issue-ID: SDC-2401
Signed-off-by: noahs <noah.shogan@amdocs.com>
4 years agoAdd unit tests for UploadInvalidErrorBuilder 62/91262/2
m.kowalski3 [Thu, 11 Jul 2019 13:45:02 +0000 (15:45 +0200)]
Add unit tests for UploadInvalidErrorBuilder

Issue-ID: SDC-2327
Signed-off-by: Marcin Kowalski <m.kowalski3@partner.samsung.com>
Change-Id: Icf5f64c77f373d27df438bc6bc89a9e1e67eaf0c

4 years agoAdd unit tests for NicInternalNetworkErrorBuilder and OnboardingMethodErrorBuilder 91/90891/2
m.kowalski3 [Thu, 4 Jul 2019 11:08:24 +0000 (13:08 +0200)]
Add unit tests for NicInternalNetworkErrorBuilder and OnboardingMethodErrorBuilder

Issue-ID: SDC-2327
Signed-off-by: Marcin Kowalski <m.kowalski3@partner.samsung.com>
Change-Id: I46e64b3a7a533a20c4e0e5a98aa99c488fa71a6b

4 years agoComponentCache & ComponentCassandraDao removal 43/90443/7
Tomasz Golabek [Tue, 25 Jun 2019 12:30:23 +0000 (14:30 +0200)]
ComponentCache & ComponentCassandraDao removal

Also removed all classes uses these two.

Change-Id: I6793c3c935ae61c5c65f70d3541c542edf188ab4
Issue-ID: SDC-2389
Signed-off-by: Tomasz Golabek <tomasz.golabek@nokia.com>
4 years agoMaven staging plugin removed 31/91331/2
Tomasz Golabek [Fri, 12 Jul 2019 10:18:04 +0000 (12:18 +0200)]
Maven staging plugin removed

Required by global-jjb

Change-Id: I0ceca8fabd5e6c67cf702fbfb4d78866c0df4027
Issue-ID: SDC-2444
Signed-off-by: Tomasz Golabek <tomasz.golabek@nokia.com>
4 years agoFixed banned dependency 53/91353/1
Piotr Darosz [Fri, 12 Jul 2019 11:58:55 +0000 (13:58 +0200)]
Fixed banned dependency

Upgrade onap-tosca-datatype snapshot dependency version to non-snapshot

Change-Id: I54f1dae17b8c9bb13407a6313581b682fbadbefc
Issue-ID: SDC-2447
Signed-off-by: Piotr Darosz <piotr.darosz@nokia.com>
4 years agoAdded oparent to sdc main 65/91065/6
Tomasz Golabek [Tue, 9 Jul 2019 06:42:59 +0000 (08:42 +0200)]
Added oparent to sdc main

Removed errors regarding to a missing license and others.
Started locally and executed basic api tests

Change-Id: Iea37613defc97f7b40613d60c10990841cb2a209
Issue-ID: SDC-2419
Signed-off-by: Tomasz Golabek <tomasz.golabek@nokia.com>
4 years agoFixed the startup.sh script in the sdc-onboard-db-init-docker. 93/91093/2
k.kedron [Tue, 9 Jul 2019 13:44:54 +0000 (15:44 +0200)]
Fixed the startup.sh script in the sdc-onboard-db-init-docker.

Changed the instruction order to get the cqlsh command status.

Issue-ID: SDC-2425
Signed-off-by: Krystian Kedron <k.kedron@partner.samsung.com>
Change-Id: I173244af91e091d5cbb6979a8c5819b2646d6196

4 years agoCorrected typos in chef scripts. 88/91088/3
k.kedron [Tue, 9 Jul 2019 11:02:08 +0000 (13:02 +0200)]
Corrected typos in chef scripts.

Corrected typos and checkstyles.

Issue-ID: SDC-2424
Signed-off-by: Krystian Kedron <k.kedron@partner.samsung.com>
Change-Id: If2464645dad7da3fa7706e35e4ccace3ece6aeb4

4 years agoAdd unit test for PackageInvalidErrorBuilder 90/91090/1
m.kowalski3 [Tue, 9 Jul 2019 13:03:08 +0000 (15:03 +0200)]
Add unit test for PackageInvalidErrorBuilder

Issue-ID: SDC-2327
Signed-off-by: Marcin Kowalski <m.kowalski3@partner.samsung.com>
Change-Id: I3ca7aa5ac07acd472e9ddd359e74064bf29186c0

4 years agoIncrrct intrfc type populated in tosca for S proxy 63/91063/2
Mojahidul Islam [Tue, 9 Jul 2019 05:46:35 +0000 (11:16 +0530)]
Incrrct intrfc type populated in tosca for S proxy

Incorrect interface type is populated in tosca for Service proxy for Local interface operations

Change-Id: If7933d6537a14567297e716f154c2a48f7f34797
Issue-ID: SDC-2423
Signed-off-by: Mojahidul Islam <mojahidul.islam@amdocs.com>
4 years agoMove import handling to service template 06/91006/3
ojasdubey [Mon, 8 Jul 2019 07:37:18 +0000 (13:07 +0530)]
Move import handling to service template

Moving the handling of all import formats parsing
to ServiceTemplate class to make it generic and
reusable

Change-Id: I80595c3654a625275549a3bb3afe8ba7c9455aff
Issue-ID: SDC-2421
Signed-off-by: ojasdubey <ojas.dubey@amdocs.com>
4 years agoAdd validation of non referenced file in package 36/90936/2
andre.schmid [Mon, 8 Jul 2019 08:51:50 +0000 (08:51 +0000)]
Add validation of non referenced file in package

Add the validation specified in SOL004, that all files in the package
should be listed in the Manifest file.
Fix Validator related Test class, adapting to the new validation.
Create a manifest builder to help the tests.
Fix minor typos.
Update .gitignore to remove ajcore files.

Change-Id: Ib9a99bf3d7905349e0ec8fef8fd960028bb83f8d
Issue-ID: SDC-2412
Signed-off-by: andre.schmid <andre.schmid@est.tech>
4 years agoAdd unit test for OrchestrationTemplateNotFoundErrorBuilder 42/90942/2
m.kowalski3 [Fri, 5 Jul 2019 11:08:43 +0000 (13:08 +0200)]
Add unit test for OrchestrationTemplateNotFoundErrorBuilder

Issue-ID: SDC-2327
Signed-off-by: Marcin Kowalski <m.kowalski3@partner.samsung.com>
Change-Id: Ia8f606848a7ebe405b4ac4a7935d7df1c001452f

4 years agoImproved unit tests for ComponentValidationUtils and Sonar fixes. 81/90781/2
k.kedron [Tue, 2 Jul 2019 10:55:35 +0000 (12:55 +0200)]
Improved unit tests for ComponentValidationUtils and Sonar fixes.

Improved unit tests for ComponentValidationUtils.
Checkstyle for ComponentValidationUtils.
Add a private constructor to hide the implicit public one
in the ComponentValidationUtils.

Issue-ID: SDC-2327
Signed-off-by: Krystian Kedron <k.kedron@partner.samsung.com>
Change-Id: I8a2f2f7b9a5e6475a4e28d13f3acab333b4af6da

4 years agoAutowired annotation for openecomp-be 72/90772/2
Tomasz Golabek [Tue, 2 Jul 2019 10:07:50 +0000 (12:07 +0200)]
Autowired annotation for openecomp-be

Injection of the properties moved to the constructor replacing
field annotations.

Change-Id: I5ea031c9ab414859d810cb8686de3ce6ccebfd0a
Issue-ID: SDC-2406
Signed-off-by: Tomasz Golabek <tomasz.golabek@nokia.com>
4 years agoRemove field injection in catalog-dao 46/90646/3
Wojciech Sliwka [Fri, 28 Jun 2019 07:20:55 +0000 (09:20 +0200)]
Remove field injection in catalog-dao

Change-Id: I96ac13d3b50737518924a3aaa9b320adbba241eb
Issue-ID: SDC-2398
Signed-off-by: Wojciech Sliwka <wojciech.sliwka@nokia.com>
4 years agoRemove field injection in catalog-dao 82/90582/3
Wojciech Sliwka [Thu, 27 Jun 2019 10:35:47 +0000 (12:35 +0200)]
Remove field injection in catalog-dao

Change-Id: I24c3a898fa34491e80074944614722fbb3085515
Issue-ID: SDC-2398
Signed-off-by: Wojciech Sliwka <wojciech.sliwka@nokia.com>
4 years agoPM-Mapper Policy Model support 69/90669/6
rajendrajaiswal [Fri, 28 Jun 2019 13:59:43 +0000 (14:59 +0100)]
PM-Mapper Policy Model support

Change-Id: I3603c4a5b05b0dc528b0dd57eabea8947f9e8fbb
Issue-ID: SDC-2104
Signed-off-by: rajendrajaiswal <rajendra.jaiswal@ericsson.com>
4 years agoImproved the ConfigurationRepositoryTest. 92/90892/2
k.kedron [Thu, 4 Jul 2019 11:09:38 +0000 (13:09 +0200)]
Improved the ConfigurationRepositoryTest.

Checkstyle for CliConfigurationImpTest.
Improved the ConfigurationRepositoryTest
to not has an influence on other tests.

Issue-ID: SDC-2327
Signed-off-by: Krystian Kedron <k.kedron@partner.samsung.com>
Change-Id: I74b95617ad1b17c26a8d6237c7e7469ef2213596

4 years agoAdd unit tests for: 15/90715/2
m.kowalski3 [Mon, 1 Jul 2019 10:46:31 +0000 (12:46 +0200)]
Add unit tests for:
-MonitoringUploadErrorBuilder
-NicErrorBuilder
-VendorSoftwareProductInvalidErrorBuilder

Issue-ID: SDC-2327
Signed-off-by: Marcin Kowalski <m.kowalski3@partner.samsung.com>
Change-Id: I4e34f6f511e27a5f33e96f5bc482cca7765a66e8

4 years agoAdd unit test for InformationArtifactCreationErrorBuilder 95/90595/2
m.kowalski3 [Thu, 27 Jun 2019 13:42:55 +0000 (15:42 +0200)]
Add unit test for InformationArtifactCreationErrorBuilder

Issue-ID: SDC-2327
Signed-off-by: Marcin Kowalski <m.kowalski3@partner.samsung.com>
Change-Id: I1c2f53de62ac9dcbc264b900769a68eab1749b49

4 years agoAdd unit test for ProcessManagerImpl 89/90589/2
m.kowalski3 [Thu, 27 Jun 2019 12:22:26 +0000 (14:22 +0200)]
Add unit test for ProcessManagerImpl

Issue-ID: SDC-2327
Signed-off-by: Marcin Kowalski <m.kowalski3@partner.samsung.com>
Change-Id: I16dc6f67707d520e0e6678255ab70c726be596c5

4 years agoAdded unit tests for ConfigurationRepository 07/90507/2
Piotr Borelowski [Wed, 26 Jun 2019 11:16:01 +0000 (13:16 +0200)]
Added unit tests for ConfigurationRepository

Improved the unit test coverage
in onap-configuration-management-core project

Issue-ID: SDC-2327
Signed-off-by: Piotr Borelowski <p.borelowski@partner.samsung.com>
Change-Id: Ib448d3f318a89d65d4b6ae912e3ca38a31b86146

4 years agoFix artifact implementation proxy node type 68/90568/2
ojasdubey [Thu, 27 Jun 2019 07:03:35 +0000 (12:33 +0530)]
Fix artifact implementation proxy node type

Removing the operation implementation from proxy
node type in parent service tosca as it will be
present in the proxy node template

Change-Id: Id414d6cdd5f5f4ccb1d7c235fbc8b7cdf1ec4147
Issue-ID: SDC-2395
Signed-off-by: ojasdubey <ojas.dubey@amdocs.com>
4 years agoAdd unit tests for: 06/90506/2
m.kowalski3 [Wed, 26 Jun 2019 11:01:30 +0000 (13:01 +0200)]
Add unit tests for:
-DeploymentFlavorErrorBuilder
-DuplicateComputeInComponentErrorBuilder
-FileCreationErrorBuilder
-ImageErrorBuilder

Issue-ID: SDC-2327
Signed-off-by: Marcin Kowalski <m.kowalski3@partner.samsung.com>
Change-Id: I0af9da852bb953e93f6e4383725c1c56944d8f33

4 years agoAdd unit tests for OrchestrationTemplateCandidateManagerImpl 52/90452/2
m.kowalski3 [Tue, 25 Jun 2019 13:38:38 +0000 (15:38 +0200)]
Add unit tests for OrchestrationTemplateCandidateManagerImpl

Issue-ID: SDC-2327
Signed-off-by: Marcin Kowalski <m.kowalski3@partner.samsung.com>
Change-Id: I80b9e404a98e23e135ae12e4d24ee2c7f66fef11

4 years agoHighlight Windows-specific parts 82/90382/3
kaihlavi [Mon, 24 Jun 2019 13:13:07 +0000 (16:13 +0300)]
Highlight Windows-specific parts

Change-Id: I8da91c11d772d7b2ec487506431d172d414ddace
Issue-ID: SDC-2386
Signed-off-by: kaihlavi <l.kaihlavirt@partner.samsung.com>
4 years agoAdd unit tests for ComponentDependencyModelErrorBuilder 73/90373/2
m.kowalski3 [Mon, 24 Jun 2019 11:30:43 +0000 (13:30 +0200)]
Add unit tests for ComponentDependencyModelErrorBuilder

Issue-ID: SDC-2327
Signed-off-by: Marcin Kowalski <m.kowalski3@partner.samsung.com>
Change-Id: I48a1b56d3d193dd5a85d4331c31b1913d0997ec3

4 years agoUpgrade jackson-databind 75/89875/3
Piotr Darosz [Fri, 14 Jun 2019 09:39:33 +0000 (11:39 +0200)]
Upgrade jackson-databind

Upgrade jackson-databind version.

Change-Id: Ica3cd492404150786f212f126463af51fc95b071
Issue-ID: SDC-2262
Signed-off-by: Piotr Darosz <piotr.darosz@nokia.com>
4 years agoAdd unit tests for HealthCheckService 99/90299/2
m.kowalski3 [Fri, 21 Jun 2019 11:36:27 +0000 (13:36 +0200)]
Add unit tests for HealthCheckService

Issue-ID: SDC-2327
Signed-off-by: Marcin Kowalski <m.kowalski3@partner.samsung.com>
Change-Id: Ia72210625c45b4e9b7bd5d26aa52893167133a93

4 years agoFix for Cassandra init 59/90359/4
Ofir Sonsino [Sun, 23 Jun 2019 13:20:50 +0000 (16:20 +0300)]
Fix for Cassandra init

Change-Id: If266342c3c126d79e5d99a70f4ed3908e4e7a166
Issue-ID: SDC-2371
Signed-off-by: Ofir Sonsino <os0695@intl.att.com>
4 years agoAdd unit tests for: 77/90377/2
m.kowalski3 [Mon, 24 Jun 2019 12:53:49 +0000 (14:53 +0200)]
Add unit tests for:
-ComponentErrorBuilder
-ComputeErrorBuilder
-CreatePackageForNonFinalVendorSoftwareProductErrorBuilder

Issue-ID: SDC-2327
Signed-off-by: Marcin Kowalski <m.kowalski3@partner.samsung.com>
Change-Id: I465619c8e4b9819c4706a38633a9e1d6bf5551ab

4 years agoAdd unit test for CompositionEntityDataManagerImpl 32/90432/2
m.kowalski3 [Tue, 25 Jun 2019 10:07:36 +0000 (12:07 +0200)]
Add unit test for CompositionEntityDataManagerImpl

Issue-ID: SDC-2327
Signed-off-by: Marcin Kowalski <m.kowalski3@partner.samsung.com>
Change-Id: I77efe6d3da88de11ea41484d5ce17d736d6d142b

4 years agoFix known issues title in release notes 93/90393/2
Ofir Sonsino [Mon, 24 Jun 2019 15:07:49 +0000 (18:07 +0300)]
Fix known issues title in release notes

Change-Id: I8df008da029d2fb5987d4fbfb6fc60b0670bcf1d
Issue-ID: SDC-2387
Signed-off-by: Ofir Sonsino <os0695@intl.att.com>
4 years agoRevert "add automated fadeout to sdc splashscreen" 92/90392/1
kaihlavi [Mon, 24 Jun 2019 15:01:18 +0000 (18:01 +0300)]
Revert "add automated fadeout to sdc splashscreen"

Issue-ID: SDC-2384
This reverts commit 4f514b1c3f1c688345c750281097925ac22417ca.
Signed-off-by: kaihlavi <l.kaihlavirt@partner.samsung.com>
Change-Id: I4f35c5771795750c6af71c41c7d8dc08001e833c

4 years agoAdd the known issues to release notes 86/90386/1
Ofir Sonsino [Mon, 24 Jun 2019 13:29:53 +0000 (16:29 +0300)]
Add the known issues to release notes

Change-Id: Ibdef9f205ed48a0f6c461ae2f8e16a0165a660c0
Issue-ID: SDC-2387
Signed-off-by: Ofir Sonsino <os0695@intl.att.com>
4 years agofixing CsarUtilsTest 67/90367/2
Bartosz Gardziejewski [Mon, 24 Jun 2019 06:58:36 +0000 (08:58 +0200)]
fixing CsarUtilsTest

Issue-ID: SDC-1795
Signed-off-by: Bartosz Gardziejewski <bartosz.gardziejewski@nokia.com>
Change-Id: Id4a95fdc0ce9dee133ece1d2f105b2e28813e733

4 years agoFix node filter properties value 65/90365/2
talio [Mon, 24 Jun 2019 06:49:23 +0000 (09:49 +0300)]
Fix node filter properties value

fix node filter properties value to be list<map<string, list>>

Change-Id: Iafb31c4f94f10d0493ef2bce622019958a995639
Issue-ID: SDC-2381
Signed-off-by: talio <tali.orenbach@amdocs.com>
4 years agoFixed bug - implementation path under interfaces 26/90226/2
Mojahidul Islam [Thu, 20 Jun 2019 12:15:08 +0000 (17:45 +0530)]
Fixed bug - implementation path under interfaces

the path of the implementation under interfaces points to a non-existing path

Change-Id: Iec0c2119c405bf14a1ddec99a0462f29b91f8ea3
Issue-ID: SDC-2377
Signed-off-by: Mojahidul Islam <mojahidul.islam@amdocs.com>
4 years agoExportImportMenu tests 59/89559/4
Tomasz Golabek [Fri, 7 Jun 2019 07:28:23 +0000 (09:28 +0200)]
ExportImportMenu tests

Main class tested and refactored

Change-Id: I379a18c289b613cdc7ecbb1617618af96ffa275b
Issue-ID: SDC-2326
Signed-off-by: Tomasz Golabek <tomasz.golabek@nokia.com>
4 years agorefactoring CsarUtilsTest 18/89118/4
Bartosz Gardziejewski [Mon, 3 Jun 2019 06:41:43 +0000 (08:41 +0200)]
refactoring CsarUtilsTest

Issue-ID: SDC-1795
Signed-off-by: Bartosz Gardziejewski <bartosz.gardziejewski@nokia.com>
Change-Id: Ia25a7b4fa8837c5c06e29cfa46386347f3af0c80

4 years agoAdd Lombok support to RelationshipType 57/90357/2
noahs [Sun, 23 Jun 2019 08:55:42 +0000 (11:55 +0300)]
Add Lombok support to RelationshipType

add @Data annotation

Change-Id: I185a32166a6efe9d221c260a0f25d958dec2690e
Issue-ID: SDC-2380
Signed-off-by: noahs <noah.shogan@amdocs.com>
4 years agoFix minor documentation issues 08/89908/4
kaihlavi [Fri, 14 Jun 2019 15:09:11 +0000 (18:09 +0300)]
Fix minor documentation issues

 - change "sdc-main" to "sdc" (there is no such project as sdc-main)
 - correct typos and grammar

Issue-ID: SDC-2368
Signed-off-by: kaihlavi <l.kaihlavirt@partner.samsung.com>
Change-Id: I883d06df2fdde13e46ec7cbfe93d19f5587b8de0

4 years agoClean up MdcData and ImportMetadata 47/89247/4
Tomasz Golabek [Tue, 4 Jun 2019 13:31:47 +0000 (15:31 +0200)]
Clean up MdcData and ImportMetadata

Removed duplicated class. Added assertions to check the logic.

Change-Id: Ia953ee0c88d71214cf620cdd286f6ecdd3f3d26d
Issue-ID: SDC-2326
Signed-off-by: Tomasz Golabek <tomasz.golabek@nokia.com>
4 years agoTestNG and BeanShell update 04/90004/2
Piotr Darosz [Mon, 17 Jun 2019 11:59:02 +0000 (13:59 +0200)]
TestNG and BeanShell update

Upgrade TestNG version to migrate to newer version of BeanShell.

Change-Id: I687a1a9af9921f573da19ec657d18853b5704786
Issue-ID: SDC-2266
Signed-off-by: Piotr Darosz <piotr.darosz@nokia.com>
4 years agoOptimize Dockerfile to reduce SDC image size 71/89971/2
Satoshi Fujii [Mon, 17 Jun 2019 04:25:22 +0000 (13:25 +0900)]
Optimize Dockerfile to reduce SDC image size

Use --chown flag at ADD command instead of executing chown

Issue-ID: SDC-2366
Signed-off-by: Satoshi Fujii <fujii-satoshi@jp.fujitsu.com>
Change-Id: I5aa36da91e45bad5f6ae0bd817a3cdf8186668d8

4 years agoUpgrade jetty version 99/89699/2
Piotr Darosz [Tue, 11 Jun 2019 13:24:22 +0000 (15:24 +0200)]
Upgrade jetty version

Upgrade jetty-http component to current version.

Change-Id: I0bc8636b31973a865ffa1205866828c33cc15e4b
Issue-ID: SDC-2268
Signed-off-by: Piotr Darosz <piotr.darosz@nokia.com>
4 years agofix sonar null pointer 27/89627/2
k.kazak [Mon, 10 Jun 2019 07:21:44 +0000 (09:21 +0200)]
fix sonar null pointer

NoveServerNamingConventionGuideLineValidator: potential null pointer fixed
Test for this use-case added

Change-Id: I3180bc6c159d1b690f0be0370abbd1fefe70045f
Issue-ID: SO-1811
Signed-off-by: k.kazak <k.kazak@samsung.com>
4 years agoUpgrade libthrift 94/89794/3
Piotr Darosz [Thu, 13 Jun 2019 10:56:13 +0000 (12:56 +0200)]
Upgrade libthrift

Upgrade libthrift to the newest version.

Change-Id: I371acaec6d2e3f79f997c86a0b6051d3612f88db
Issue-ID: SDC-2264
Signed-off-by: Piotr Darosz <piotr.darosz@nokia.com>
4 years agoUpgrade netty 72/89772/4
Piotr Darosz [Thu, 13 Jun 2019 05:42:06 +0000 (07:42 +0200)]
Upgrade netty

Upgrade netty-related dependencies.

Change-Id: I040287114e21b6d61b84425bd4c15996af27b13c
Issue-ID: SDC-2263
Signed-off-by: Piotr Darosz <piotr.darosz@nokia.com>
4 years agoIssue-ID: SDC-2370 07/90007/2
Avi Ziv [Mon, 17 Jun 2019 10:04:58 +0000 (13:04 +0300)]
Issue-ID: SDC-2370

Signed-off-by: dfx1971 <avi.ziv@amdocs.com>
Change-Id: Ibfe11277ab9a6f9eb0c402190e41ef94e6ae55f3

4 years agoUpdated package version 80/89380/7
Tomasz Golabek [Wed, 5 Jun 2019 14:14:17 +0000 (16:14 +0200)]
Updated package version

Apache POI version changed to latest. Was tested manually using asdctool

Change-Id: I8c71a22ef6c7a9dde5afdf6b9890310ef1a2c748
Issue-ID: SDC-2270
Signed-off-by: Tomasz Golabek <tomasz.golabek@nokia.com>
4 years agoChange-Id: Ia2e7429fab8ea4e73bcdd4b0a74c966ec80e7023 99/89999/2
dfx1971 [Mon, 17 Jun 2019 10:04:58 +0000 (13:04 +0300)]
Change-Id: Ia2e7429fab8ea4e73bcdd4b0a74c966ec80e7023
Issue-ID: SDC-2372
Signed-off-by: Avi Ziv <avi.ziv@amdocs.com>
Change-Id: Iedd93871297f214216664961d27d48d98abf3e17
Signed-off-by: Avi Ziv <avi.ziv@amdocs.com>
4 years agoAdd property uid in declaration 52/89952/2
talio [Sun, 16 Jun 2019 13:56:36 +0000 (16:56 +0300)]
Add property uid in declaration

Add property uid when declaring property to policy, in order to get the policies list in UI

Change-Id: I227bfcdcf40483b1e308877e9b2ae41106e20e29
Issue-ID: SDC-2369
Signed-off-by: talio <tali.orenbach@amdocs.com>
4 years agoAdd lombok support to simple classes 79/89979/2
Oren Kleks [Mon, 17 Jun 2019 07:20:57 +0000 (10:20 +0300)]
Add lombok support to simple classes

Change-Id: I98ced4b0f30c3b676e02de08ccab0c06bc7b8965
Issue-ID: SDC-2354
Signed-off-by: shrek2000 <orenkle@amdocs.com>
4 years agoBeanUtils upgrade to 1.9.x 77/89977/1
Oren Kleks [Mon, 17 Jun 2019 06:43:05 +0000 (09:43 +0300)]
BeanUtils upgrade to 1.9.x

Transitive dependency to beanutils 1.8.3 removed.
Refactor of existing usage of beanutils proposed.

Change-Id: Ice5a996dc6f782d787309bd9c604335710627b2c
Issue-ID: SDC-2269
Signed-off-by: shrek2000 <orenkle@amdocs.com>
4 years agoBeanUtils upgrade to 1.9.x 93/89693/4
Tomasz Golabek [Tue, 11 Jun 2019 11:41:48 +0000 (13:41 +0200)]
BeanUtils upgrade to 1.9.x

Transitive dependency to beanutils 1.8.3 removed.
Refactor of existing usage of beanutils proposed.

Change-Id: I6614a5794979225376338c778b25f71911ae9c50
Issue-ID: SDC-2269
Signed-off-by: Tomasz Golabek <tomasz.golabek@nokia.com>
4 years agoUpdate the CsarInfoTest. 75/89675/5
k.kedron [Tue, 11 Jun 2019 08:46:26 +0000 (10:46 +0200)]
Update the CsarInfoTest.

Used common ZipUtil.readData instead local load method.
Fix checkstyle (variable named).

Issue-ID: SDC-2327
Signed-off-by: Krystian Kedron <k.kedron@partner.samsung.com>
Change-Id: I6adaed83e45d43268b174fde0ba6ee991e3fb2b0

4 years agoAdded unit tests for SpringCLITool 86/89786/2
Oren Kleks [Thu, 13 Jun 2019 08:32:34 +0000 (11:32 +0300)]
Added unit tests for SpringCLITool

Improved the unit test coverage in the package
org.openecomp.sdc.asdctool.cli

Fixed the build

Change-Id: Iea7395b169acb912489466f9cdf90ac88cc42b8f
Issue-ID: SDC-2327
Signed-off-by: shrek2000 <orenkle@amdocs.com>
Signed-off-by: Piotr Borelowski <p.borelowski@partner.samsung.com>
4 years agoUpgrade SDC from Titan to Janus Graph 65/89765/2
shrikantawachar [Wed, 12 Jun 2019 17:35:50 +0000 (23:05 +0530)]
Upgrade SDC from Titan to Janus Graph

Upgrade SDC from Titan to Janus Graph

Change-Id: I6ba55643f05e83ac3b63cb9b72b69d3bf700aeab
Issue-ID: SDC-2296
Signed-off-by: shrikantawachar <shrikant.awachar@amdocs.com>
4 years agoAdded unit tests for SpringCLITool 35/89635/2
Piotr Borelowski [Mon, 10 Jun 2019 11:29:13 +0000 (13:29 +0200)]
Added unit tests for SpringCLITool

Improved the unit test coverage in the package
org.openecomp.sdc.asdctool.cli

Issue-ID: SDC-2327
Signed-off-by: Piotr Borelowski <p.borelowski@partner.samsung.com>
Change-Id: Ie5b262587ae704952eb75f8f4008f4d321a4acbd

4 years agoUpgrade SDC from Titan to Janus Graph 68/88068/8
shrikantawachar [Mon, 20 May 2019 06:41:54 +0000 (12:11 +0530)]
Upgrade SDC from Titan to Janus Graph

Upgrade SDC from Titan to Janus Graph

Change-Id: I67fb8b8e60cc6751697bc5ff2f06754c92803786
Issue-ID: SDC-2296
Signed-off-by: shrikantawachar <shrikant.awachar@amdocs.com>
4 years agoAdd lombok support to simple classes 63/89363/4
avigaffa [Tue, 11 Jun 2019 12:56:32 +0000 (15:56 +0300)]
Add lombok support to simple classes

Change-Id: Iec40668537af0fad0d43a599af9ed65d4e5aefbd
Issue-ID: SDC-2354
Signed-off-by: avigaffa <avi.gaffa@amdocs.com>
4 years agoAdd DCAE_TOSCA_LAB_VIP to env template 66/89566/4
kaihlavi [Fri, 7 Jun 2019 08:25:58 +0000 (11:25 +0300)]
Add DCAE_TOSCA_LAB_VIP to env template

 Add DCAE_TOSCA_LAB_VIP to Template.json to ensure
 the generated environments/CSIT.json for CSIT docker
 setup starts up properly to enable DCAE-BE communication
 to tosca-app container

 Tabs removed and indents aligned

Issue-ID: SDC-2358
Signed-off-by: kaihlavi <l.kaihlavirt@partner.samsung.com>
Change-Id: If509563097f9c53b70483eb205d7a363ee46bb35

4 years agoRemove DCAE references from core SDC 04/89504/2
kaihlavi [Thu, 6 Jun 2019 11:52:02 +0000 (14:52 +0300)]
Remove DCAE references from core SDC

 Remove DCAE-related versions and docker_run.sh functionality
 (these should be handled in dt-be-main)

 Note that this change cancels https://gerrit.onap.org/r/#/c/sdc/+/88549/

Change-Id: I9c04331af6f05443ae4c7378b7072edd110fdc6d
Issue-ID: SDC-2357
Signed-off-by: kaihlavi <l.kaihlavirt@partner.samsung.com>
4 years agoAdded unit tests for CLITool 82/89582/3
Piotr Borelowski [Fri, 7 Jun 2019 11:59:19 +0000 (13:59 +0200)]
Added unit tests for CLITool

Improved the unit test coverage in the package
org.openecomp.sdc.asdctool.cli

Issue-ID: SDC-2327
Signed-off-by: Piotr Borelowski <p.borelowski@partner.samsung.com>
Change-Id: I06bc14882d7e608b9e7beef49f310b708290a7f5

4 years agoAdd lombok support to simple classes 95/89695/1
avigaffa [Tue, 11 Jun 2019 11:29:20 +0000 (14:29 +0300)]
Add lombok support to simple classes

Change-Id: I02d45d887e0bfe5838ad2f492f4220f5bbee5eca
Issue-ID: SDC-2354
Signed-off-by: avigaffa <avi.gaffa@amdocs.com>
4 years agoAdd new unit test for CsarInfo. 91/89691/1
Oren Kleks [Tue, 11 Jun 2019 10:09:12 +0000 (13:09 +0300)]
Add new unit test for CsarInfo.

Change-Id: Id624bddd7204a2fadae33f9f7b8aadebe9be2df6
Issue-ID: SDC-2327
Signed-off-by: shrek2000 <orenkle@amdocs.com>
4 years agoFix INFO.yaml lint issues 96/89296/2
Jessica Wagantall [Tue, 4 Jun 2019 23:00:46 +0000 (16:00 -0700)]
Fix INFO.yaml lint issues

- Fixed indentation issues
- Fixed duplication key issues

Issue-ID: CIMAN-246
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>
Change-Id: I3a1bf4217ae2173a8f1156cebae56f27eef45845

4 years agoAdd new unit test for CsarInfo. 69/88869/4
k.kedron [Thu, 30 May 2019 11:05:18 +0000 (13:05 +0200)]
Add new unit test for CsarInfo.

Issue-ID: SDC-2327
Signed-off-by: Krystian Kedron <k.kedron@partner.samsung.com>
Change-Id: Icda5004063b9a5e52b9308a164bf1e1477361c92

4 years agoImprove unit test in the NonConfigResourceTest and various sonar fixes. 59/89259/2
k.kedron [Tue, 4 Jun 2019 14:21:03 +0000 (16:21 +0200)]
Improve unit test in the NonConfigResourceTest and various sonar fixes.

Improve the NonConfigResourceTest.
Remove the throws the Exception in CliConfigurationImp constructor.
ConfigurationImpl class:
- Replace the string to chart in indexOf method.
- Extract the assigment out from expression

Issue-ID: SDC-2327
Signed-off-by: Krystian Kedron <k.kedron@partner.samsung.com>
Change-Id: If72a75e6a2d81a9ea74e3ae1af94b16a8489a29a

4 years agoAdd unit tests for MutableHttpServletRequest 42/89142/4
m.kowalski3 [Mon, 3 Jun 2019 13:15:36 +0000 (15:15 +0200)]
Add unit tests for MutableHttpServletRequest

Issue-ID: SDC-2327
Signed-off-by: Marcin Kowalski <m.kowalski3@partner.samsung.com>
Change-Id: Ic6e68ff3bc10eefa9143a5c7fcac9dcb91d384af

4 years agoAdd lombok support to simple classes 73/89373/3
avigaffa [Wed, 5 Jun 2019 13:22:01 +0000 (16:22 +0300)]
Add lombok support to simple classes

Change-Id: I80c5a691f61c16ffc7d146e11a08cda317f31539
Issue-ID: SDC-2354
Signed-off-by: avigaffa <avi.gaffa@amdocs.com>
4 years agoFix Service proxy node template 74/89574/3
ojasdubey [Fri, 7 Jun 2019 11:06:39 +0000 (16:36 +0530)]
Fix Service proxy node template

Fixes for issues:
1. Declared properties of VFCs not
appearing in proxy node template
2. Proper value resolution of
proxy properties

Change-Id: I4b5bedc7e2a4b4071f3adb4dfe909db80575c25a
Issue-ID: SDC-2359
Signed-off-by: ojasdubey <ojas.dubey@amdocs.com>
4 years agoInheritance in ComponentException 21/88321/5
Tomasz Golabek [Wed, 22 May 2019 14:41:09 +0000 (16:41 +0200)]
Inheritance in ComponentException

ComponentException was split into ByActionStatus and ByResponseFormat exceptions.
Test added for ComponentLockAspectTest in passing

Change-Id: I89c9ee966b8b4445e791af897bd60cdb845b845b
Issue-ID: SDC-2321
Signed-off-by: Tomasz Golabek <tomasz.golabek@nokia.com>
4 years agoAdd lombok support to simple classes 79/89379/2
shrek2000 [Wed, 5 Jun 2019 14:13:18 +0000 (17:13 +0300)]
Add lombok support to simple classes

Change-Id: I1d39f6bc0513189ce0f3581ddc51e9f557d2dadc
Issue-ID: SDC-2354
Signed-off-by: shrek2000 <orenkle@amdocs.com>
4 years agoAdd lombok support to simple classes 78/89378/2
Oren Kleks [Wed, 5 Jun 2019 14:10:53 +0000 (17:10 +0300)]
Add lombok support to simple classes

Change-Id: Ie4c25fd87b3e302f7dd19f4d0156524398e1af55
Issue-ID: SDC-2354
Signed-off-by: shrek2000 <orenkle@amdocs.com>
4 years agoAdd lombok support to simple classes 81/89381/2
shrek2000 [Wed, 5 Jun 2019 14:15:38 +0000 (17:15 +0300)]
Add lombok support to simple classes

Change-Id: I76b00170ba5304bf82df3903cc381d46d7f0f513
Issue-ID: SDC-2354
Signed-off-by: shrek2000 <orenkle@amdocs.com>
4 years agoFix static list value issue 69/89369/4
talio [Wed, 5 Jun 2019 13:11:11 +0000 (16:11 +0300)]
Fix static list value issue

Change-Id: I976404e172aae756248cb4e3fe367e1c00c72168
Issue-ID: SDC-2355
Signed-off-by: talio <tali.orenbach@amdocs.com>
4 years agoAdd lombok support to simple classes 65/89365/2
avigaffa [Wed, 5 Jun 2019 12:26:51 +0000 (15:26 +0300)]
Add lombok support to simple classes

Change-Id: I2d1a7d63e7f80aa766ac71df9c808dcda35d68e3
Issue-ID: SDC-2354
Signed-off-by: avigaffa <avi.gaffa@amdocs.com>
4 years agoAdd lombok support to simple classes 47/89347/2
shrek2000 [Wed, 5 Jun 2019 11:02:47 +0000 (14:02 +0300)]
Add lombok support to simple classes

Change-Id: Id4db17168cce9a6a02138c2c6bd74971159994dc
Issue-ID: SDC-2354
Signed-off-by: shrek2000 <orenkle@amdocs.com>
4 years agoAdd lombok support to simple classes 49/89349/2
shrek2000 [Wed, 5 Jun 2019 11:18:14 +0000 (14:18 +0300)]
Add lombok support to simple classes

Change-Id: Ic48b301b2e45815bfb9e71d26626ad89cb61d753
Issue-ID: SDC-2354
Signed-off-by: shrek2000 <orenkle@amdocs.com>
4 years agoAdd lombok support to simple classes 52/89352/2
shrek2000 [Wed, 5 Jun 2019 11:23:10 +0000 (14:23 +0300)]
Add lombok support to simple classes

Change-Id: I7060b515880159261fd228bdcfe5e75f84e2d99b
Issue-ID: SDC-2354
Signed-off-by: shrek2000 <orenkle@amdocs.com>
4 years agoAdd lombok support to simple classes 48/89348/2
shrek2000 [Wed, 5 Jun 2019 11:13:24 +0000 (14:13 +0300)]
Add lombok support to simple classes

Change-Id: Ic3956c9c6f4fddf412a2216de3d79a2cb2d779b0
Issue-ID: SDC-2354
Signed-off-by: shrek2000 <orenkle@amdocs.com>
4 years agoAdd new unit and refactor tests for YamlTemplateParsingHandler. 51/89151/2
k.kedron [Mon, 3 Jun 2019 14:29:50 +0000 (16:29 +0200)]
Add new unit and refactor tests for YamlTemplateParsingHandler.

Issue-ID: SDC-2327
Signed-off-by: Krystian Kedron <k.kedron@partner.samsung.com>
Change-Id: Id3c8b6df65beddedf822748f517bd48585014df9

4 years agoAdd lombok support to simple classes 43/89343/1
avigaffa [Wed, 5 Jun 2019 10:18:13 +0000 (13:18 +0300)]
Add lombok support to simple classes

Change-Id: I04ba3d45335933f9a8547267e99ec163543a3a8e
Issue-ID: SDC-2354
Signed-off-by: avigaffa <avi.gaffa@amdocs.com>
4 years agoAdd lombok support to simple classes 42/89342/1
avigaffa [Wed, 5 Jun 2019 10:13:44 +0000 (13:13 +0300)]
Add lombok support to simple classes

Change-Id: Ibaa1711ff6b2a64e6e591f0938874e31f713bfe8
Issue-ID: SDC-2354
Signed-off-by: avigaffa <avi.gaffa@amdocs.com>