Liam Fallon [Fri, 10 Sep 2021 10:14:25 +0000 (10:14 +0000)]
Merge "Add Delete Instantiation Functionality."
danielhanrahan [Wed, 8 Sep 2021 09:49:44 +0000 (10:49 +0100)]
Ensure that login in policy-gui works with AAF
Add CLAMP SSL cert and key to Docker image
Change nginx port from 8080 to 2443 and enable SSL
Update README to include instructions on certificate login
Issue-ID: POLICY-3615
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: I5211d30c420d75a94621399f33763b8156c50b5b
brunomilitzer [Mon, 30 Aug 2021 17:46:53 +0000 (18:46 +0100)]
Add Delete Instantiation Functionality.
Update UI to centralize Instantiation Management
Created Delete button to delete the instantiations
Fixed Change Order State Functionality
Issue-ID: POLICY-3558
Change-Id: I2efb00ce041ab4fc217e06ed72385ad8ea1b10fb
Signed-off-by: brunomilitzer <bruno.militzer@est.tech>
liamfallon [Thu, 9 Sep 2021 20:54:21 +0000 (21:54 +0100)]
Remove blank line from INFO.yaml
Issue-ID: POLICY-3587
Change-Id: Iebe527c5533633face5ba859a51123f9fe6fdf08
Signed-off-by: liamfallon <liam.fallon@est.tech>
liamfallon [Thu, 9 Sep 2021 15:14:59 +0000 (16:14 +0100)]
Point at released policy-parent
Issue-ID: POLICY-3587
Change-Id: I33000b3a514af99208b380973485f0c6048b39fb
Signed-off-by: liamfallon <liam.fallon@est.tech>
Pamela Dragosh [Thu, 9 Sep 2021 13:41:20 +0000 (13:41 +0000)]
Merge "Fix sonar issue in policy/gui"
Pamela Dragosh [Thu, 9 Sep 2021 13:38:16 +0000 (13:38 +0000)]
Merge "Update INFO.yaml"
Ram Krishna Verma [Wed, 8 Sep 2021 19:18:00 +0000 (15:18 -0400)]
Fix sonar issue in policy/gui
Issue-ID: POLICY-3077
Change-Id: Ia4a1a12ab286d40205ec5a81d130c4845cd93cea
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
liamfallon [Wed, 8 Sep 2021 12:20:06 +0000 (13:20 +0100)]
Update INFO.yaml
Update the INFO.yaml file with latest information.
Issue-ID: POLICY-3552
Change-Id: I454ebb9bd0589dd43563fe6df8a97e0c741d13f3
Signed-off-by: liamfallon <liam.fallon@est.tech>
danielhanrahan [Mon, 30 Aug 2021 16:35:18 +0000 (17:35 +0100)]
Make gui-pdp-monitoring work in Docker image
Serve PDP Monitoring HTML using nginx in Docker image
Don't serve HTML content from PdpMonitoringServer
Remove unused dependencies in gui-pdp-monitoring
Add proxy setting for local dev testing with npm start
Issue-ID: POLICY-3603
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: I9a4c2b250a1f0460892a367a3b5bbb59e0e92411
Jim Hahn [Thu, 2 Sep 2021 14:33:31 +0000 (14:33 +0000)]
Merge "Fix static web resource paths in gui-editor-apex"
Jorge Hernandez [Thu, 2 Sep 2021 13:35:36 +0000 (13:35 +0000)]
Merge "Add docker image generation to maven for policy-gui"
Jorge Hernandez [Thu, 2 Sep 2021 13:34:24 +0000 (13:34 +0000)]
Merge "Add missing JS import in gui-editor-apex"
danielhanrahan [Mon, 30 Aug 2021 16:13:56 +0000 (17:13 +0100)]
Fix static web resource paths in gui-editor-apex
Some relative paths in the HTML/CSS are incorrect in the build
Issue-ID: POLICY-3601
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: Ifb9f4b428f3732cd601a3128df27d720a55f88fa
Ram Krishna Verma [Wed, 1 Sep 2021 19:00:24 +0000 (15:00 -0400)]
Fix sonar issues in policy/gui
Issue-ID: POLICY-3095
Change-Id: Ida760b380acbc5784f685e0a4c95c09f017ebf57
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
danielhanrahan [Mon, 30 Aug 2021 15:56:58 +0000 (16:56 +0100)]
Add missing JS import in gui-editor-apex
There is a missing import for apexUtils_escapeHtml (used on line 53),
preventing the context schema table from loading
Issue-ID: POLICY-3602
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: Id08864c93201007ee353f054f0580024af1d878a
danielhanrahan [Fri, 20 Aug 2021 15:55:19 +0000 (16:55 +0100)]
Add docker image generation to maven for policy-gui
Add maven uber-jar artifact for gui-editor-apex
Add maven tarball artifact for gui-clamp
Create docker image containing nginx and policy GUIs
Issue-ID: POLICY-3574
Change-Id: I06e5ed6fb610e0746f376114f628bb9b1a530cab
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Ram Krishna Verma [Fri, 27 Aug 2021 20:11:39 +0000 (16:11 -0400)]
Fix sonar issues in policy/gui
Issue-ID: POLICY-3077
Change-Id: Idcd08427cbff2cfdd8ba99db7cf32a0f5c978415
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
Ram Krishna Verma [Thu, 26 Aug 2021 19:44:12 +0000 (15:44 -0400)]
Fix sonar issues
Issue-ID: POLICY-3077
Change-Id: Iae7bad7bc69bc4c5cd974e8439f8f433a43123d0
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
brunomilitzer [Thu, 19 Aug 2021 16:20:13 +0000 (17:20 +0100)]
ADD State Change CL Instantiation
Will Apply Unit Tests on POLICY-3537, since focus is to
get the functionalities completed.
Issue-ID: POLICY-3425
Change-Id: I926bb1a213e71dee56c0fc5df4779a4f1b633383
Signed-off-by: brunomilitzer <bruno.militzer@est.tech>
saul.gill [Mon, 9 Aug 2021 13:19:33 +0000 (14:19 +0100)]
Add error handling and refactoring
Added error for when common or instance props can't be retrieved
Added error for monitoring when control loops can't be retrieved
Made node templates collapsed by default when editing properties
Added single service function to get common or instance properties
Issue-ID: POLICY-3439
Change-Id: I74560a06aae1a820862f977d5e7ac86597a093c0
Signed-off-by: saul.gill <saul.gill@est.tech>
brunomilitzer [Tue, 27 Jul 2021 16:47:25 +0000 (17:47 +0100)]
Add Instance Properties Form
Added save button to update paramaters
Added service to retrieve paramaters;
Added service to upload instance paramaters
Issue-ID: POLICY-3436
Change-Id: I82e7545b12160f2e7937db2fdb3857c66ea0b858
Signed-off-by: brunomilitzer <bruno.militzer@est.tech>
saul.gill [Mon, 26 Jul 2021 16:33:24 +0000 (17:33 +0100)]
Added Common Parameter Form
Added save button for user edits
Added commission button to push up edits
Added service to retrieve common parameters
Issue-ID: POLICY-3439
Change-Id: Ia355f36bf263bb1385db363a267c53af86504905
Signed-off-by: saul.gill <saul.gill@est.tech>
Jim Hahn [Tue, 20 Jul 2021 13:44:23 +0000 (13:44 +0000)]
Merge "Added Commissioning Template Editor"
saul.gill [Mon, 12 Jul 2021 16:10:10 +0000 (17:10 +0100)]
Added Commissioning Template Editor
Added a new modal to allow editing of the tosca template
Json schema from the backend generates a for the user
Added Decommissioning capability while viewing template
Added service for decommissioning
Issue-ID: POLICY-3439
Change-Id: Ic5bec9ea26aa8df468d36a893faa06f88d248dd5
Signed-off-by: saul.gill <saul.gill@est.tech>
Jim Hahn [Fri, 16 Jul 2021 14:04:54 +0000 (10:04 -0400)]
Use lombok annotations in gui
Issue-ID: POLICY-3395
Change-Id: I7820877522875a3caf47e3b7409eb4f7fb15ba2b
Signed-off-by: Jim Hahn <jrh3@att.com>
brunomilitzer [Thu, 8 Jul 2021 14:33:55 +0000 (15:33 +0100)]
Add Upload Control Loop Instantiation
Created Functionality to Upload JSON file to Control Loop Instantiation.
Issue-ID: POLICY-3436
Change-Id: Iefd538c91154b7e61615ab63b440378e2feea502
Signed-off-by: brunomilitzer <bruno.militzer@est.tech>
brunomilitzer [Fri, 2 Jul 2021 15:26:03 +0000 (16:26 +0100)]
Update React NPM dependencies
Updated React UI and React UI Lib dependencies to the latest version.
Issue-ID: POLICY-3354
Change-Id: I12e0bb7e01d426928e3184fcd49f461f775a369a
Signed-off-by: brunomilitzer <bruno.militzer@est.tech>
saul.gill [Fri, 2 Jul 2021 16:10:54 +0000 (17:10 +0100)]
Changed components to be service-centric
Moved endpoints to ControlLoopService.js
Refactored components and tests
Issue-ID: POLICY-3424
Change-Id: I70d48750250eecd651b845ef0c726617983f75f5
Signed-off-by: saul.gill <saul.gill@est.tech>
Jim Hahn [Mon, 28 Jun 2021 18:23:51 +0000 (18:23 +0000)]
Merge "Fix merge jobs failing"
arkadiusz.adamski [Mon, 28 Jun 2021 16:45:45 +0000 (17:45 +0100)]
Fix merge jobs failing
- add npm publish url
Issue-ID: POLICY-3388
Signed-off-by: arkadiusz.adamski <aadamski@est.tech>
Change-Id: Ie14bda34d30b452501d61b9a3acd384ac06c8a6c
Ajith Sreekumar [Mon, 28 Jun 2021 10:26:49 +0000 (10:26 +0000)]
Merge "Add Tosca Monitoring App to Policy Gui"
Jim Hahn [Fri, 25 Jun 2021 17:18:12 +0000 (17:18 +0000)]
Merge "Fix merge jobs failing"
Ram Krishna Verma [Fri, 25 Jun 2021 14:54:13 +0000 (14:54 +0000)]
Merge "Update gui for checkstyle 8.43"
arkadiusz.adamski [Fri, 25 Jun 2021 13:41:26 +0000 (14:41 +0100)]
Fix merge jobs failing
- fix library version
Issue-ID: POLICY-3388
Signed-off-by: arkadiusz.adamski <aadamski@est.tech>
Change-Id: Id338b7f4e3d95bad8c78134c6a8e14ddb954b2f5
arkadiusz.adamski [Thu, 24 Jun 2021 16:10:13 +0000 (17:10 +0100)]
Fix merge jobs failing
- fix library version
Issue-ID: POLICY-3388
Signed-off-by: arkadiusz.adamski <aadamski@est.tech>
Change-Id: I2b5267c17d439b06c4eb91e174be705c7adfa5a6
liamfallon [Thu, 24 Jun 2021 16:18:02 +0000 (17:18 +0100)]
Update gui for checkstyle 8.43
Issue-ID: POLICY-3206
Change-Id: I5b80398352d03a0fe2853690b6b0d3019d204a7e
Signed-off-by: liamfallon <liam.fallon@est.tech>
brunomilitzer [Fri, 18 Jun 2021 15:07:16 +0000 (16:07 +0100)]
Add Tosca Monitoring App to Policy Gui
Implemented the prototype monitoring gui onto the policy gui
Issue-ID: POLICY-3357
Change-Id: Iabf25cd6c26d4e65a7a963cdd79c25aa91c39736
Signed-off-by: brunomilitzer <bruno.militzer@est.tech>
arkadiusz.adamski [Thu, 24 Jun 2021 15:14:50 +0000 (16:14 +0100)]
Fix merge jobs failing
- fix library version
Issue-ID: POLICY-3388
Signed-off-by: arkadiusz.adamski <aadamski@est.tech>
Change-Id: Ia50a9ada9c9d1eab17954c82005e368cd9bea8ec
Jim Hahn [Thu, 24 Jun 2021 14:47:25 +0000 (14:47 +0000)]
Merge "Fix merge jobs failing"
arkadiusz.adamski [Wed, 23 Jun 2021 17:08:38 +0000 (18:08 +0100)]
Fix merge jobs failing
- fix import addresses
Issue-ID: POLICY-3388
Signed-off-by: arkadiusz.adamski <aadamski@est.tech>
Change-Id: I6d4813f017b6fc2e656bb4d514601b3be1380be5
saul.gill [Wed, 23 Jun 2021 15:54:10 +0000 (16:54 +0100)]
Added jest/enzyme tests for new components
Tests and snapshots added for reference
Single package added to package.json
Issue-ID: POLICY-3423
Change-Id: Ica0045bb80f587856f6e2392c3d846b6416cce21
Signed-off-by: saul.gill <saul.gill@est.tech>
Liam Fallon [Wed, 23 Jun 2021 07:34:09 +0000 (07:34 +0000)]
Merge "Added Tosca File Upload Functionality"
saul.gill [Thu, 17 Jun 2021 08:11:55 +0000 (09:11 +0100)]
Added Tosca File Upload Functionality
Added 2 new components
One deals with the file upload to commissioning
Other deals with display of the ui elements
Issue-ID: POLICY-3222
Change-Id: I3b20489bb9e5c499f842cc8adde8147d3e3e8de0
Signed-off-by: saul.gill <saul.gill@est.tech>
arkadiusz.adamski [Wed, 16 Jun 2021 15:34:14 +0000 (16:34 +0100)]
Increase code coverage on gui
- increase code coverage on gui js
Issue-ID: POLICY-3351
Signed-off-by: arkadiusz.adamski <aadamski@est.tech>
Change-Id: I4c633b0a46f75ceb3f6a4721e8311d938168982e
Liam Fallon [Wed, 16 Jun 2021 07:05:53 +0000 (07:05 +0000)]
Merge "Increase code coverage on gui"
Pamela Dragosh [Tue, 15 Jun 2021 15:02:56 +0000 (15:02 +0000)]
Merge "Fix sonar in policy/gui"
arkadiusz.adamski [Tue, 15 Jun 2021 10:53:55 +0000 (11:53 +0100)]
Increase code coverage on gui
- increase code coverage on gui js
Issue-ID: POLICY-3351
Signed-off-by: arkadiusz.adamski <aadamski@est.tech>
Change-Id: I5c24e6f02c401fd1eaee819105673cfcf1c81e13
Ram Krishna Verma [Fri, 11 Jun 2021 20:01:27 +0000 (16:01 -0400)]
Fix sonar in policy/gui
use "var" for local variables
Issue-ID: POLICY-3077
Change-Id: I6e31317bfda3d2b9bdde038cec709a3398f2f655
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
saul.gill [Thu, 3 Jun 2021 17:06:18 +0000 (18:06 +0100)]
Added GET Tosca Service Template components
Added in header, using existing styling
Integrated with existing FE
Issue-ID: POLICY-3222
Change-Id: I5b6a9f4be3296b2969baa559a7a48c87d2ab9258
Signed-off-by: saul.gill <saul.gill@est.tech>
brunomilitzer [Fri, 4 Jun 2021 13:40:46 +0000 (14:40 +0100)]
MERGE Clamp UI-React repo to Policy Gui Repo
According to a Diff differences from one repo to the other, there was some missing changes from the original clamp repo to the policy gui repo.
Issue-ID: POLICY-3267
Change-Id: I9a71841732dc5c3d9623bca9c1384866f4c826a6
Signed-off-by: brunomilitzer <bruno.militzer@est.tech>
Liam Fallon [Fri, 4 Jun 2021 08:54:38 +0000 (08:54 +0000)]
Merge "Increase code coverage on gui.editors.apex.rest"
arkadiusz.adamski [Thu, 3 Jun 2021 12:47:15 +0000 (13:47 +0100)]
Increase code coverage on gui.editors.apex.rest
- increase code coverage on gui.editors.apex.rest
Issue-ID: POLICY-3351
Signed-off-by: arkadiusz.adamski <aadamski@est.tech>
Change-Id: I481ecea3b77ec4e7b7fbdd0475becec0ccea11dc
brunomilitzer [Fri, 28 May 2021 16:01:46 +0000 (17:01 +0100)]
Refactor .gitignore file to remove irrelevant info
Issue-ID: POLICY-3325
Change-Id: Ie3d1ee46c9ac351ba9438b4b0a2bcaa47486d7ac
Signed-off-by: brunomilitzer <bruno.militzer@est.tech>
Jim Hahn [Fri, 28 May 2021 12:48:13 +0000 (12:48 +0000)]
Merge "React Front-End UI"
brunomilitzer [Tue, 18 May 2021 11:50:32 +0000 (12:50 +0100)]
React Front-End UI
This commit is to move the React front end files from the Clamp Policy Repo to the Onap Gui Policy Repo.
Also created the added Maven featue to compile the React project via Node and NPM, and copy the production files to the target directory.
Fixed in gitignore that was ignoring the contents inside the logs/ directory.
Reformated JS spacing files from 4 spaces to 2 spaces.
Fixed Broken JEST test
Applied Jim's Code Review as well updated Node Version from 12.18 to 14.17 accross the modules. Unfortunately cannot apply NPM version since it broke npm install.
Fixed ONAP Job Builder Linting Error
Applied Jim's Second Code Review
Issue-ID: POLICY-3218
Signed-off-by: brunomilitzer <bruno.militzer@est.tech>
Change-Id: I01f95c350d27d72f941c835592fd596472601d6e
arkadiusz.adamski [Thu, 20 May 2021 16:33:18 +0000 (17:33 +0100)]
gui-editor-apex doesn't contain webapp correctly
- change location of css, js and html files in jar.
Issue-ID: POLICY-3322
Signed-off-by: arkadiusz.adamski <aadamski@est.tech>
Change-Id: I712e84cc3a923bdfd6f7857afec914a37f47a54d
Ram Krishna Verma [Wed, 12 May 2021 18:34:02 +0000 (18:34 +0000)]
Merge "Create module to hold CLAMP client code"
brunomilitzer [Mon, 10 May 2021 15:51:15 +0000 (16:51 +0100)]
Create module to hold CLAMP client code
Issue-ID: POLICY-3218
Change-Id: Icc74332c71b69a059178985b5b63b3bfff7ff956
Signed-off-by: brunomilitzer <bruno.militzer@est.tech>
Jim Hahn [Mon, 10 May 2021 16:52:21 +0000 (12:52 -0400)]
Fix sonars in policy-gui
Fixed:
- use "var"
Only fixed the ones I saw visually, as SonarLint wouldn't run -
something about missing node.js.
Issue-ID: POLICY-3094
Change-Id: I594d424b42ce446d86724d75b1dd9ec868c14f2b
Signed-off-by: Jim Hahn <jrh3@att.com>
arkadiusz.adamski [Fri, 23 Apr 2021 11:49:50 +0000 (12:49 +0100)]
Fix gui-editor-apex fails to start
- fix NullPointerException when gui-editor is started with command line
- clean up code
Issue-ID: POLICY-3235
Signed-off-by: arkadiusz.adamski <aadamski@est.tech>
Change-Id: Ia05a4a808c3fa266e702f627959a382b0344f5db
Jim Hahn [Thu, 15 Apr 2021 20:06:59 +0000 (16:06 -0400)]
Address plugin-not-found issues
Removed references to archetype-packaging and lifecycle-mapping, where
unnecessary due to pom inheritance.
Issue-ID: POLICY-3136
Change-Id: Iae3278accea933a18224f10b63a01658948b39db
Signed-off-by: Jim Hahn <jrh3@att.com>
Jim Hahn [Tue, 13 Apr 2021 18:02:37 +0000 (14:02 -0400)]
Update version of maven resources plugin
Policy parent specifies a newer version of the maven resources plugin.
Modified the pom to work with it. According to the docs, copy-resources
is only needed when copying from directories outside of
src/main/resources.
Issue-ID: POLICY-3182
Change-Id: Icb125914dd0fc15a9b2da4290b7e06338a0fae4a
Signed-off-by: Jim Hahn <jrh3@att.com>
Jim Hahn [Fri, 9 Apr 2021 18:52:54 +0000 (14:52 -0400)]
Use alternate repo for npm
Also updated version of npm, as 6.14.4 does not appear within the repo.
Issue-ID: POLICY-3182
Change-Id: I61ec07ad525d165828bb7c97af00bb740d939cc3
Signed-off-by: Jim Hahn <jrh3@att.com>
Jim Hahn [Thu, 8 Apr 2021 20:59:55 +0000 (16:59 -0400)]
Upgrade dependencies in gui
The gui builds are failing, because the policy dependencies cannot be
found. Upgraded the dependency versions to the latest policy snapshots.
Issue-ID: POLICY-3180
Change-Id: Id90addb5a15bbdaa4842c1751ac0022f38417e49
Signed-off-by: Jim Hahn <jrh3@att.com>
mkidd [Mon, 29 Mar 2021 08:16:18 +0000 (10:16 +0200)]
Fix sonarqube code Bug
ApexEditorParameters has a URI that sonar does not like, hard coding the leading forward slash removes the complaint
ApexEditorMain was receiving args and a print stream in the form of System.err and then System.out, both of these were null values, while Sonar sees System.out or err as a bug as it should be a logger, simply passing null in its place is not an issue to sonar
BeanBase.java Removed an if statement that always asserted to be true, as it is inside an if statement that confirmed that condition.
removed an accessibility change as sonar sees this as a violation
Issue-ID: POLICY-3095
Signed-off-by: mkidd <michael.kidd@est.tech>
Change-Id: I1bbdfe9cc6db085195e95da3dbfbc8b29d9a5ff5
Signed-off-by: mkidd <michael.kidd@est.tech>
mkidd [Wed, 24 Mar 2021 12:26:31 +0000 (12:26 +0000)]
Fix sonarqube code smells
Making changed regarding code smells. Some variables being declared twice while in scope.
renaming some modelFileName in ApexFiles.js that is being declared while there is a constant with the same name.
renamed some of the for loop control variables so that sonarqube doesnt see it as an issue
Made changes based on reviews
Issue-ID: POLICY-3095
Change-Id: If38934247a4e4ff9c48043feb3adde5505c46993
Signed-off-by: mkidd <michael.kidd@est.tech>
mkidd [Thu, 11 Mar 2021 13:23:18 +0000 (13:23 +0000)]
Fix tests code smells - less assertions per test
ApexEditorRestResourceTest.java - separate test methods into smaller methods so that less assertions are made per method
Issue-ID: POLICY-3095
Change-Id: Ic7f54916a130dbb403102dec51e6e2fec708f0cf
Signed-off-by: mkidd <michael.kidd@est.tech>
Liam Fallon [Thu, 11 Mar 2021 05:59:34 +0000 (05:59 +0000)]
Merge "fix code smells and vulnerabilities monitoring"
mkidd [Thu, 4 Mar 2021 15:27:27 +0000 (15:27 +0000)]
fix code smells and vulnerabilities monitoring
removed / from start of Rest path, hard coded it - resolves code smell issue
small code smell changes regarding passing variables to functions that have access to the variable from its current scope
reintroduced data parameter being passed in MonitoringUtils.js, can look into this more later
fixed pom for parent version, commons step up
Issue-ID: POLICY-3095
Signed-off-by: mkidd <michael.kidd@est.tech>
Change-Id: Id8b6a8b41e9b3c2f362821750d3fa728b93336a0
Signed-off-by: mkidd <michael.kidd@est.tech>
mkidd [Wed, 10 Mar 2021 14:15:43 +0000 (14:15 +0000)]
pom file changes for snapshot
pointed parent to 3.3.1-SNAPSHOT
pointed policy.common to 1.8.1-SNAPSHOT
pointed policy.models to 2.4.2-SNAPSHOT
Issue-ID: POLICY-3095
Signed-off-by: mkidd <michael.kidd@est.tech>
Change-Id: Ic5ebe398abb289c7fba6e8de14bf5d11a5c0e449
Signed-off-by: mkidd <michael.kidd@est.tech>
mkidd [Mon, 1 Mar 2021 11:13:06 +0000 (11:13 +0000)]
fix code smells and vulnerabilities
used await method inside an if statement that now runs the same code as the accompanying finally block.
removed unused variables from ApexContextAlbumEditForm.js
refactored vars that were redelared - this was not needed as there were variables of this name within scope
added ! operator
Issue-ID: POLICY-3095
Signed-off-by: mkidd <michael.kidd@est.tech>
Change-Id: Idadf4dd6938be5410fef62140de8b265bbaca138
mkidd [Fri, 26 Feb 2021 18:27:03 +0000 (18:27 +0000)]
fix bugs in MonitoringChart.js
removed redundant variables that re declared themselves
refactored coded that repeated as a function
Issue-ID: POLICY-3095
Signed-off-by: mkidd <michael.kidd@est.tech>
Change-Id: I14be896ecb8d2f50ee5dc0c61009c6c2cab3e442
Ram Krishna Verma [Wed, 24 Feb 2021 15:38:27 +0000 (10:38 -0500)]
Update info.yaml in gui
Issue-ID: POLICY-3028
Change-Id: I1e2fcc49f28a8fe620f39326dbe820bfc993e4da
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
Jim Hahn [Mon, 22 Feb 2021 13:45:44 +0000 (13:45 +0000)]
Merge "Refactor Policy-Gui to use Instant from Date"
rameshiyer27 [Wed, 17 Feb 2021 18:17:01 +0000 (18:17 +0000)]
Refactor Policy-Gui to use Instant from Date
Issue-ID: POLICY-3069
Signed-off-by: zrrmmua <ramesh.murugan.iyer@est.tech>
Change-Id: Ie91e60667707df110c53b65fdac8918acb07f6e1
Jim Hahn [Thu, 11 Feb 2021 20:55:33 +0000 (15:55 -0500)]
Fix sonars in gui
Addressed the following issues (java only):
- assignment to static field
- expression is always true
- duplicate character in regex
- duplicate code
- remove Thread.sleep() from junit test
Issue-ID: POLICY-3063
Change-Id: I70951ed47defad5baa6c957852663688e51fa88a
Signed-off-by: Jim Hahn <jrh3@att.com>
waynedunican [Fri, 19 Feb 2021 16:28:23 +0000 (16:28 +0000)]
Fix policy-gui build failures
maven-resources-plugin has been updated to v3.2.0. This is causing our
gui build to fail, due to it not allowing more than a certain number of
files to be copied. Reverted to v3.1.0 in apex-editor to fix this issue.
Issue-ID: POLICY-3063
Change-Id: I7b8a207f63de82ed44747c5d2c470b5345cb84c6
Signed-off-by: waynedunican <wayne.dunican@est.tech>
Jim Hahn [Mon, 9 Nov 2020 16:19:55 +0000 (16:19 +0000)]
Merge "Update dependencies in policy/gui"
waynedunican [Thu, 5 Nov 2020 16:06:54 +0000 (16:06 +0000)]
Update dependencies in policy/gui
Update dependencies in gui-pdp-monitoring and gui-editor-apex to align with Node version. Deprecated dependencies removed.
Issue-ID: POLICY-2886
Change-Id: I62137b85d8ca56cd2cdeeeae5ee62ed18b5306ee
Signed-off-by: waynedunican <wayne.dunican@est.tech>
Pamela Dragosh [Fri, 6 Nov 2020 16:02:27 +0000 (11:02 -0500)]
Fix upcoming checkstyle issues
When we upgrade to oparent, these will fail as oparent upgrades
to 8.37 of puppycrawl which fixes a few bugs that should have
flagged these previously.
Issue-ID: POLICY-2887
Change-Id: Iaf0cf4966efc8655a2ea78d9b607ab0df91dd56b
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Jim Hahn [Tue, 27 Oct 2020 20:27:56 +0000 (16:27 -0400)]
Point to snapshot versions
Issue-ID: POLICY-2875
Change-Id: I2fe7e65beaaab70c888e258b2d45ce91d1339423
Signed-off-by: Jim Hahn <jrh3@att.com>
Pamela Dragosh [Tue, 20 Oct 2020 12:12:07 +0000 (08:12 -0400)]
Point gui to models 2.3.6 SNAPSHOT
Issue-ID: POLICY-2869
Change-Id: Ie8787c6d906043a063bc862cdb59986c58a57e4a
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Pamela Dragosh [Wed, 7 Oct 2020 20:31:22 +0000 (16:31 -0400)]
Point to latest models snapshot 2.3.3
Issue-ID: POLICY-2839
Change-Id: Ifdf4be2ee15af8cde32bbbbac0dd0a5e7244ab25
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
waynedunican [Mon, 21 Sep 2020 08:19:42 +0000 (09:19 +0100)]
JS Testing added for apex-editor
Last apex-editor/pom.xml change to exclude the /dist folder
Issue-ID: POLICY-2783
Change-Id: I076aac4e503c7e5f2ea39fa9291153be4b119808
Signed-off-by: waynedunican <wayne.dunican@est.tech>
liamfallon [Wed, 30 Sep 2020 14:56:24 +0000 (15:56 +0100)]
Pick up userId from apex editor URL
The userId must be picked up from the URL passed to the policy editor
and then passed to the server.
Issue-ID: POLICY-2850
Change-Id: I98948f2e0a2bf8090926751ee98c26c46d272fcf
Signed-off-by: liamfallon <liam.fallon@est.tech>
Pamela Dragosh [Thu, 24 Sep 2020 14:05:38 +0000 (10:05 -0400)]
Point to latest SNAPSHOTS
Issue-ID: POLICY-2789
Change-Id: Ia696e3a7336e8ff12804d5c2e04d3996e5aadcdf
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
liamfallon [Tue, 15 Sep 2020 15:13:54 +0000 (16:13 +0100)]
Exclude unit test files from released artifacts
The node.js code and repos are used only during unit test and should not
be included in the released artifacts. Not having them in the released
artifacts also eliminates a number of security and licensing issues with
node.js modules.
Issue-ID: POLICY-2825
Change-Id: Icb9c0a0e3d1ebb01aa9b6346ce51f0c76c5cdd0f
Signed-off-by: liamfallon <liam.fallon@est.tech>
liamfallon [Fri, 11 Sep 2020 13:28:32 +0000 (14:28 +0100)]
Add TOSCA support to Apex editor
The APEX editor now loads, saves, and downloads files in TOSCA format,
the same as the apex-pdp does.
The non-standard TOSCA handling for file upload has been refactored to
be aligned with the Policy Frameowkr TOSCA support.
Issue-ID: POLICY-2621
Change-Id: I1ec7475cbcc6ffc23de92687c9f284ac7dfbdd80
Signed-off-by: liamfallon <liam.fallon@est.tech>
Ram Krishna Verma [Tue, 8 Sep 2020 17:26:13 +0000 (17:26 +0000)]
Merge "Cosmetic changes to the apex-editor GUI"
Jim Hahn [Tue, 8 Sep 2020 17:17:12 +0000 (17:17 +0000)]
Merge "JavaScript tests for apex-editor"
liamfallon [Tue, 8 Sep 2020 14:35:27 +0000 (15:35 +0100)]
Cosmetic changes to the apex-editor GUI
Some minor changes to remove some eclipse warnings and to tidy the the
tets and formatting in the APEX policy editor GUI.
Issue-ID: POLICY-2621
Change-Id: Ib9b9b054fbe146feec4e477434097094e8ecae26
Signed-off-by: liamfallon <liam.fallon@est.tech>
waynedunican [Mon, 7 Sep 2020 11:21:03 +0000 (12:21 +0100)]
JavaScript tests for apex-editor
JavaScript tests added to improve code coverage for policy-gui
Issue-ID: POLICY-2783
Change-Id: Ie12fb6089b872842bb5c668a8126675f89772d79
Signed-off-by: waynedunican <wayne.dunican@est.tech>
Jim Hahn [Fri, 4 Sep 2020 13:46:30 +0000 (09:46 -0400)]
Use released parent 3.2.0 in gui
Issue-ID: POLICY-2789
Change-Id: Id81b09c0b0c8b0d088f1b813cb0858d28236d4d5
Signed-off-by: Jim Hahn <jrh3@att.com>
waynedunican [Mon, 24 Aug 2020 12:36:15 +0000 (13:36 +0100)]
Jest JS Coverage
Edited SonarCloud lcov reports path. Removed from pdp-monitoring
pom.xml. Added node binary source executable path and sources sonar
properties to pom.xml.
Issue-ID: POLICY-2610
Change-Id: I6354e65d358ca5e9bd8c18f032330aa5063a0889
Signed-off-by: waynedunican <wayne.dunican@est.tech>
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
waynedunican [Wed, 19 Aug 2020 15:56:32 +0000 (16:56 +0100)]
JS Coverage Report directory
Moved the generated Jest Coverage report from policy-gui/gui-pdp-monitoring/src/webapp/coverage to policy-gui/target/code-coverage in order for SonarCloud to display the JS Code Coverage results.
Issue-ID: POLICY-2610
Change-Id: I1d86203afa45ad1b0a51d729fec4326607585988
Signed-off-by: waynedunican <wayne.dunican@est.tech>
Jim Hahn [Tue, 18 Aug 2020 13:12:19 +0000 (13:12 +0000)]
Merge "JavaScript coverage SonarCloud"
waynedunican [Tue, 18 Aug 2020 08:30:07 +0000 (09:30 +0100)]
JavaScript coverage SonarCloud
Added to pom.xml for SonarCloud to point to lcov reports generated by Jest coverage.
Issue-ID: POLICY-2610
Change-Id: I2954517cb0b91d8e43e3c2065f4776258e391cea
Signed-off-by: waynedunican <wayne.dunican@est.tech>
KrupaNagabhushan [Mon, 10 Aug 2020 17:42:48 +0000 (18:42 +0100)]
Passing userId to upload policy
Issue-ID: POLICY-2751
Signed-off-by: KrupaNagabhushan <krupa.nagabhushan@est.tech>
Change-Id: Ifc91bba369161a63f2ad759dcdc014bb12837e88
Ajith Sreekumar [Mon, 10 Aug 2020 14:33:18 +0000 (14:33 +0000)]
Merge "Upload policy feature"