Fix sonarqube code Bug 81/119981/1
authormkidd <michael.kidd@est.tech>
Mon, 29 Mar 2021 08:16:18 +0000 (10:16 +0200)
committermkidd <michael.kidd@est.tech>
Mon, 29 Mar 2021 08:47:40 +0000 (10:47 +0200)
commit098e9903bfbf2861ac932f32b24a18ee370d7cc3
treeb63e75d04a8358b9a9b281f0f1bb11fff787e4e9
parentaabae2a75c606a8f44fd5e0b38d840bf8cd767dc
Fix sonarqube code Bug

ApexEditorParameters has a URI that sonar does not like, hard coding the leading forward slash removes the complaint
ApexEditorMain was receiving args and a print stream in the form of System.err and then System.out, both of these were null values, while Sonar sees System.out or err as a bug as it should be a logger, simply passing null in its place is not an issue to sonar
BeanBase.java Removed an if statement that always asserted to be true, as it is inside an if statement that confirmed that condition.
removed an accessibility change as sonar sees this as a violation

Issue-ID: POLICY-3095
Signed-off-by: mkidd <michael.kidd@est.tech>
Change-Id: I1bbdfe9cc6db085195e95da3dbfbc8b29d9a5ff5
Signed-off-by: mkidd <michael.kidd@est.tech>
gui-editors/gui-editor-apex/src/main/java/org/onap/policy/gui/editors/apex/rest/ApexEditorMain.java
gui-editors/gui-editor-apex/src/main/java/org/onap/policy/gui/editors/apex/rest/ApexEditorParameters.java
gui-editors/gui-editor-apex/src/main/java/org/onap/policy/gui/editors/apex/rest/handling/bean/BeanBase.java