cps.git
2 years agoChange default use of Model Loader to TRUE 08/134508/1
emaclee [Tue, 9 May 2023 08:18:05 +0000 (09:18 +0100)]
Change default use of  Model Loader to TRUE

Issue-Id: CPS-1688
Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
Change-Id: I18bb5e3ad45ccdf5f3a1e88dd5a34dc830e06f4a

2 years agoMerge "Use recursive SQL to fetch descendants in CpsPath queries (CPS-1664 #4)"
Sourabh Sourabh [Mon, 8 May 2023 09:57:37 +0000 (09:57 +0000)]
Merge "Use recursive SQL to fetch descendants in CpsPath queries (CPS-1664 #4)"

2 years agoMerge "Fix and refactor query across anchors (CPS-1664 #3)"
Sourabh Sourabh [Mon, 8 May 2023 09:51:19 +0000 (09:51 +0000)]
Merge "Fix and refactor query across anchors (CPS-1664 #3)"

2 years agoMerge "[CPS] RI: Code Refactoring # Replace '[\s\S]' to '.' as it is same as '.'...
Toine Siebelink [Mon, 8 May 2023 09:26:46 +0000 (09:26 +0000)]
Merge "[CPS] RI: Code Refactoring # Replace '[\s\S]' to '.' as it is same as '.' while grouping in regex # Updated the groovy files to add 'assert' and to replace deprecated method # Removed deprecated 'storeDataNode' method."

2 years agoMerge "Don't handle ancestor-axis using regex quickfind (CPS-1664 #2)"
Sourabh Sourabh [Mon, 8 May 2023 09:06:32 +0000 (09:06 +0000)]
Merge "Don't handle ancestor-axis using regex quickfind (CPS-1664 #2)"

2 years ago[CPS] RI: Code Refactoring 90/134490/1
raviteja.karumuri [Fri, 5 May 2023 13:52:07 +0000 (14:52 +0100)]
[CPS] RI: Code Refactoring
# Replace '[\s\S]' to '.' as it is same as '.' while grouping in regex
# Updated the groovy files to add 'assert' and to replace deprecated method
# Removed deprecated 'storeDataNode' method.

Issue-ID: CPS-1594
Signed-off-by: raviteja.karumuri <raviteja.karumuri@est.tech>
Change-Id: Iaa5f8b0cc8d66473c993060a8fc5a54e37e373b1

2 years agoFragment Entity does not represent the correct relationship with Anchor 88/134488/1
danielhanrahan [Thu, 4 May 2023 22:19:19 +0000 (23:19 +0100)]
Fragment Entity does not represent the correct relationship with Anchor

FragmentEntity incorrectly has OneToOne relationship to AnchorEntity,
instead of ManyToOne. The reason this has not caused errors so far is
that Liquibase is being used to generate database definition, not JPA.

Issue-ID: CPS-863
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: I8d3c5dc19193a84fa59526de7f2cbab7ab20a8fc

2 years agoUse recursive SQL to fetch descendants in CpsPath queries (CPS-1664 #4) 75/134475/8
danielhanrahan [Wed, 3 May 2023 18:51:27 +0000 (19:51 +0100)]
Use recursive SQL to fetch descendants in CpsPath queries (CPS-1664 #4)

- Add recursive SQL method to fetch descendants from queries.
  This changes worst-case complexity from quadratic to linear,
  resulting in extremely large performance increase for large
  number of datanodes.
- Remove RegexQuickFind algorithm as it is no longer faster.
- Updated query performance test timings

Issue-ID: CPS-1664
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: If5f0b54a88af1cb681006bbeca7043345dcdc8da

2 years agoFix and refactor query across anchors (CPS-1664 #3) 74/134474/6
danielhanrahan [Tue, 2 May 2023 19:01:34 +0000 (20:01 +0100)]
Fix and refactor query across anchors (CPS-1664 #3)

- Fix CPS-1580: Query Across All Anchors Does NOT Filter on Dataspace
- Fix CPS-1582: NullPointerException in queryDataNodesAcrossAnchors
- Improve performance of queryDataNodesAcrossAnchors
- Refactor queryDataNodes
- Refactor FragmentQueryBuilder

Issue-ID: CPS-1580
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: I8b83d4c580280d8719ab2ac33f3914f53e798774

2 years agoDon't handle ancestor-axis using regex quickfind (CPS-1664 #2) 73/134473/6
danielhanrahan [Tue, 2 May 2023 20:37:56 +0000 (21:37 +0100)]
Don't handle ancestor-axis using regex quickfind (CPS-1664 #2)

This is a preparatory patch to make refactoring easier in CPS-1664 #3

Issue-ID: CPS-1664
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: I1f94fef137ae41f7dedc585d8314f13493885d1b

2 years agoMerge "Sensible equals and hashCode for FragmentEntity (CPS-1664 #1)"
Toine Siebelink [Thu, 4 May 2023 14:14:08 +0000 (14:14 +0000)]
Merge "Sensible equals and hashCode for FragmentEntity (CPS-1664 #1)"

2 years agoFix for quickfind with descendants incl. list entries 81/134481/2
ToineSiebelink [Thu, 4 May 2023 10:35:41 +0000 (11:35 +0100)]
Fix for quickfind with descendants incl. list entries

- add specialized regex
- fixed legacy issues with absolute paths (added ^ in regex's)
- split into 2 methods for normal queries and quickfind
- fixed order of private methods

Issue-ID: CPS-1671
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
Change-Id: I785a230cd0e3e0359e3cbb0fa754a21b6e2be7ff

2 years agoSensible equals and hashCode for FragmentEntity (CPS-1664 #1) 72/134472/3
danielhanrahan [Wed, 3 May 2023 14:07:34 +0000 (15:07 +0100)]
Sensible equals and hashCode for FragmentEntity (CPS-1664 #1)

Include Anchor and Xpath in equals and hashCode methods for
FragmentEntity. (This also requires adding equals and hashCode for
AnchorEntity and DataspaceEntity.) The combination of dataspace,
anchor, and xpath uniquely identify a fragment/datanode.
This allows FragmentEntity objects returned from query across anchors
to be stored in Set collections.
Performance was observed to be unaffected by the change.

Issue-ID: CPS-1664
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: I2c7e3957e392af36f5230d08c9bbd550f44e7444

2 years agoRefactor datatrore handling in API requests 42/134442/4
ToineSiebelink [Wed, 3 May 2023 17:21:46 +0000 (18:21 +0100)]
Refactor datatrore handling in API requests

- Fully parameterized datastore(name)
- Improved controler testing to verify all parameter handling
- Simplified service inject (alwasy using contructors instead of @AutoWire)
- Added delay to fix isuse with intermitting failign test
  that tests invocation of a method that is executed on a separate thread

Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
Change-Id: Iba5d118d2484badee9c7c90ec7694882f6557d16

2 years agoBump CPS version to 3.3.2-SNAPSHOT 41/134441/1
mpriyank [Wed, 3 May 2023 10:10:08 +0000 (11:10 +0100)]
Bump CPS version to 3.3.2-SNAPSHOT

- Update version properties as well as we prepare for the next release.

Issue-ID: CPS-1666
Change-Id: I44e44ac1755c44d7050ce30c9e40f83628fe9338
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2 years agoMerge "Add container yaml for 3.3.1"
Sourabh Sourabh [Wed, 3 May 2023 09:54:31 +0000 (09:54 +0000)]
Merge "Add container yaml for 3.3.1"

2 years agoMerge "canUseRegexQuickfind does not test for contains-condition"
Toine Siebelink [Wed, 3 May 2023 09:52:00 +0000 (09:52 +0000)]
Merge "canUseRegexQuickfind does not test for contains-condition"

2 years agoAdd container yaml for 3.3.1 39/134439/1
mpriyank [Wed, 3 May 2023 09:36:30 +0000 (10:36 +0100)]
Add container yaml for 3.3.1

- Step 6 of the release process

Change-Id: I18185934b9c9e801d0269652658ae3965da5b119
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2 years agocanUseRegexQuickfind does not test for contains-condition 25/134425/2
danielhanrahan [Tue, 2 May 2023 17:00:53 +0000 (18:00 +0100)]
canUseRegexQuickfind does not test for contains-condition

This bug causes queries using contains-condition to return wrong
results, when INCLUDE_ALL_DESCENDANTS option is set.

Issue-ID: CPS-1663
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: If323e0e3b54d8c9a213dffda46897b2efb01fe2a

2 years agoAdd maven stage yaml for 3.3.1 37/134437/1
mpriyank [Wed, 3 May 2023 09:17:09 +0000 (10:17 +0100)]
Add maven stage yaml for 3.3.1

- Step 5 of the release process

Change-Id: I5b796f909395e10c0b4f783358496719f0d4b492
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2 years agoUpdate release docs 19/134419/2
mpriyank [Tue, 2 May 2023 14:58:55 +0000 (15:58 +0100)]
Update release docs

- Also synched up the API changes in openapi yml file
- Step 1 and 2 of the release process

Issue-ID: CPS-1662
Change-Id: I5b9485497a27a3dee8639faedfa9c1bd8ed3265e
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2 years agoAlign the hazelcast cluster names 99/134399/2
mpriyank [Fri, 28 Apr 2023 14:02:00 +0000 (15:02 +0100)]
Align the hazelcast cluster names

- We need to align the hazelcast cluster names as members of the same
  cluster can join each other. We will still have exclusivity as the
  instance names and configs are different for each distributed object.
- Exposing env variable to override the cluster name depending on the
  env it is run on.
- Modified test cases to validate the cluster names as well

Issue-ID: CPS-1637
Change-Id: Ib0f8c80dc9b2268f976b0c2d3ccd6d64792d4781
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2 years agoMerge "Add document for support for contains condition to cps-path"
Luke Gleeson [Fri, 28 Apr 2023 13:59:06 +0000 (13:59 +0000)]
Merge "Add document for support for contains condition to cps-path"

2 years agoTimeout for Subscription Create Partial Response 24/134124/12
lukegleeson [Thu, 6 Apr 2023 14:28:56 +0000 (15:28 +0100)]
Timeout for Subscription Create Partial Response

- Implemented default 30s timeout for DMI Responses
- Placeholders have been TODO'd for Outcome Response generation and Persisted Subscription Updating
- Refactored common HazelcastCacheConfig methods
- Some tests required a blocking variable due to seperate thread usage

Issue-ID: CPS-1599
Signed-off-by: lukegleeson <luke.gleeson@est.tech>
Change-Id: I2b1a35e93939daa0524d379ac4736d714ef61a6f

2 years agoMerge "Add retry mechanism on Subscription loader"
Luke Gleeson [Thu, 27 Apr 2023 15:26:21 +0000 (15:26 +0000)]
Merge "Add retry mechanism on Subscription loader"

2 years agoAdd retry mechanism on Subscription loader 83/134183/9
emaclee [Sun, 16 Apr 2023 16:48:15 +0000 (17:48 +0100)]
Add retry mechanism on Subscription loader

Issue-ID: CPS-1568
Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
Change-Id: I35697c260cc1a774f50d12552996b39f812fc2de

2 years agoCPS-1553 :REST endpoint to accept collection of cm handles for GET operation 58/133858/21
sourabh_sourabh [Mon, 27 Mar 2023 13:36:20 +0000 (14:36 +0100)]
CPS-1553 :REST endpoint to accept collection of cm handles for GET operation

-Introduced an interface having all un-implemented or default defination
of any method that is further extended or implemented by abstract or
stubbed controller.
-Exposed an endpoint to accept bulk request
-Modified an existing methods for more readability. (Parameterized datasource for ... methods)
-Code impl. for getResourceDataFromDmi method to send bulk request to
new proposed dmi-plugin endpoint that would accept bulk request.
-We need to investigate a groovy test that fails only into onap CICD pipeline.
For now it's commented out by added TODO tag.  (org/onap/cps/ncmp/rest/controller/NetworkCmProxyControllerSpec.groovy:205)

Issue-ID: CPS-1553

Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
Change-Id: Ieac39690956e3a0eab41068db57c5d93a16d04f0
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
2 years agoAdd document for support for contains condition to cps-path 82/134382/3
Rudrangi Anupriya [Thu, 27 Apr 2023 06:34:52 +0000 (12:04 +0530)]
Add document for support for contains condition to cps-path

Issue-ID: CPS-1272
Change-Id: I32c03d5ed80e5d16d4b5c0f726539a6da487abd6
Signed-off-by: Rudrangi Anupriya <ra00745022@techmahindra.com>
2 years agoMerge "Ordering of leaf elements to support combination of AND/OR in cps-path"
Luke Gleeson [Thu, 27 Apr 2023 09:02:23 +0000 (09:02 +0000)]
Merge "Ordering of leaf elements to support combination of AND/OR in cps-path"

2 years ago[CPS] RI, Service: Code Refactoring 56/134356/3
raviteja.karumuri [Tue, 25 Apr 2023 18:41:29 +0000 (19:41 +0100)]
[CPS] RI, Service: Code Refactoring

# Remove unused method "updateDataNodeAndDescendants"
# Remove unused production code

Issue-ID: CPS-1594
Signed-off-by: raviteja.karumuri <raviteja.karumuri@est.tech>
Change-Id: Id909e9da3e9181c181dfdfe62f051451d8e488a2

2 years agoOrdering of leaf elements to support combination of AND/OR in cps-path 14/134314/4
Rudrangi Anupriya [Tue, 25 Apr 2023 07:43:16 +0000 (13:13 +0530)]
Ordering of leaf elements to support combination of AND/OR in cps-path

Issue-ID: CPS-1629
Change-Id: Ib9df87e8171f4d53c49d80d27e3c6cf75aa3b209
Signed-off-by: Rudrangi Anupriya <ra00745022@techmahindra.com>
2 years agoMerge "Remove 32K limit from queries with collection parameters"
Toine Siebelink [Tue, 25 Apr 2023 15:22:20 +0000 (15:22 +0000)]
Merge "Remove 32K limit from queries with collection parameters"

2 years agoExtend capability of distributed cache 93/134293/5
mpriyank [Mon, 24 Apr 2023 11:51:24 +0000 (12:51 +0100)]
Extend capability of distributed cache

- Extend cache configs to be able to work in stanalone mode as well as
  in cluster mode in kubernetes.
- Expose the parameters to enable or disable the feature.
- to make it work in standalone mode autodiscovery config will take care , and
  to run it on kubernetes enable the kubernetes option and provide the
  service name property.

Issue-ID: CPS-1637
Change-Id: I704c4aa11e65b17b5be80048e4246079014d8bb7
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2 years agoRemove 32K limit from queries with collection parameters 28/134128/7
danielhanrahan [Thu, 13 Apr 2023 20:01:58 +0000 (21:01 +0100)]
Remove 32K limit from queries with collection parameters

SQL queries taking collection parameters currently create a seperate
query parameter for each collection element. There is a limit of
around 2^15 (32,768) query parameters.
Postgres DB natively supports array types, in which the whole array
is transmitted in binary as a single parameter. Changing queries to
use arrays removes the 32K limit on queries.

- Add support for Postgres arrays to queries
- Change repository methods to use arrays, and provide overloaded
  versions taking collection parameters
- Update tests to reflect 32K limit being lifted

Issue-ID: CPS-1573
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: I64f2aeaedbe54bfe12e3079cba0f2216759142c3

2 years agoMerge "Use exact type for objectUnderTest in groovy tests"
Sourabh Sourabh [Mon, 24 Apr 2023 09:08:29 +0000 (09:08 +0000)]
Merge "Use exact type for objectUnderTest in groovy tests"

2 years agoMerge "Add cascade delete fragments to liquibase test config"
Toine Siebelink [Mon, 24 Apr 2023 08:02:01 +0000 (08:02 +0000)]
Merge "Add cascade delete fragments to liquibase test config"

2 years agoMerge "Add contains condition support to cps-path"
Luke Gleeson [Fri, 21 Apr 2023 14:31:07 +0000 (14:31 +0000)]
Merge "Add contains condition support to cps-path"

2 years agoAdd cascade delete fragments to liquibase test config 68/134268/1
danielhanrahan [Fri, 21 Apr 2023 10:08:01 +0000 (11:08 +0100)]
Add cascade delete fragments to liquibase test config

Cascade delete was added to fragments table in main DB changelog,
but not to integration-test changelog.

Issue-ID: CPS-1617
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: If85f120dfdc4bf3e9c8a1dde2b982378560d418a

2 years agoUse exact type for objectUnderTest in groovy tests 67/134267/1
danielhanrahan [Fri, 21 Apr 2023 09:54:11 +0000 (10:54 +0100)]
Use exact type for objectUnderTest in groovy tests

Intelli-J doesn't know the type of objectUnderTest since it is
assigned in setup function. Thus many IDE features such as as
JavaDocs and error detection of wrong arguments are unavailable.
By setting the exact type, all IDE features are enabled.

Issue-ID: CPS-1621
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: I3dabf82ef9d07b3c18f9820fa768344c2eeec1b6

2 years agoAdd contains condition support to cps-path 45/134045/12
Rudrangi Anupriya [Mon, 17 Apr 2023 08:49:46 +0000 (14:19 +0530)]
Add contains condition support to cps-path

Issue-ID: CPS-1272
Change-Id: Ic81d1322cacc64a8752916324b801d02be47d34f
Signed-off-by: Rudrangi Anupriya <ra00745022@techmahindra.com>
2 years agoAlign dependencies with DMI-Plugin 65/134265/2
ToineSiebelink [Thu, 20 Apr 2023 17:15:54 +0000 (18:15 +0100)]
Align dependencies with DMI-Plugin

- Use bom for testcontainer versions
- Remove 'version' jib-maven-plugin.version (i.e. use latest or defined by oparent?)
- remove 'version from swagger-codegen-maven-plugin (i.e. use latest or defined by oparent?)

Issue-ID: CPS-1627

Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
Change-Id: Ic76302ae39e9ed723af3d6d496046daa9eccbd42

2 years agoMerge "Correct documentation for GET node API"
Luke Gleeson [Thu, 20 Apr 2023 15:42:58 +0000 (15:42 +0000)]
Merge "Correct documentation for GET node API"

2 years agoMerge "3.0.0 Release Step 7"
Priyank Maheshwari [Thu, 20 Apr 2023 15:37:24 +0000 (15:37 +0000)]
Merge "3.0.0 Release Step 7"

2 years agoMerge "3.3.0 Release Step 6"
Priyank Maheshwari [Thu, 20 Apr 2023 15:04:41 +0000 (15:04 +0000)]
Merge "3.3.0 Release Step 6"

2 years ago3.0.0 Release Step 7 64/134264/2
lukegleeson [Thu, 20 Apr 2023 14:32:12 +0000 (15:32 +0100)]
3.0.0 Release Step 7

Issue-ID: CPS-1631
Signed-off-by: lukegleeson <luke.gleeson@est.tech>
Change-Id: I9d9ea58a769d7b577a90bacf29191aaf4efb6b41

2 years agoMerge "3.3.0 Release Step 5"
Priyank Maheshwari [Thu, 20 Apr 2023 14:36:29 +0000 (14:36 +0000)]
Merge "3.3.0 Release Step 5"

2 years ago3.3.0 Release Step 6 63/134263/2
lukegleeson [Thu, 20 Apr 2023 14:17:10 +0000 (15:17 +0100)]
3.3.0 Release Step 6

Issue-ID: CPS-1631
Signed-off-by: lukegleeson <luke.gleeson@est.tech>
Change-Id: I1ab690a2f43666328be9bf420aacc1d66760ae28

2 years ago3.3.0 Release Step 5 61/134261/2
lukegleeson [Thu, 20 Apr 2023 13:45:46 +0000 (14:45 +0100)]
3.3.0 Release Step 5

Issue-ID: CPS-1631
Signed-off-by: lukegleeson <luke.gleeson@est.tech>
Change-Id: I7fa3efa3d3fd79eb9a14710832d88ff81cf001a6

2 years agoMigrate hibernate-types to hypersistence-utils 49/134249/2
danielhanrahan [Thu, 20 Apr 2023 11:26:47 +0000 (12:26 +0100)]
Migrate hibernate-types to hypersistence-utils

There is newer release of the dependency that provides JSONB support.
The newer version provides additional features, such as Postgres
arrays. It was renamed from hibernate-types to hypersistence-utils.

Issue-ID: CPS-1573
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: Iab556850041b592a8c4d515270dfe4bd9547957a

2 years agoMerge "3.3.0 Release Steps 1 & 2"
Priyank Maheshwari [Thu, 20 Apr 2023 13:31:21 +0000 (13:31 +0000)]
Merge "3.3.0 Release Steps 1 & 2"

2 years ago3.3.0 Release Steps 1 & 2 59/134259/1
lukegleeson [Thu, 20 Apr 2023 13:11:20 +0000 (14:11 +0100)]
3.3.0 Release Steps 1 & 2

Issue-ID: CPS-1631
Signed-off-by: lukegleeson <luke.gleeson@est.tech>
Change-Id: I69e8725dd54b3e21718ae0f9da8b7d262845f579

2 years agoCorrect documentation for GET node API 21/134221/3
emaclee [Tue, 18 Apr 2023 13:49:24 +0000 (14:49 +0100)]
Correct documentation for GET node API

- Add new section on documentation to describe XPath
- Correct doc description on GET node API

Issue-ID: CPS-1607
Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
Change-Id: I23e4ccd1185a2d93fbb0b9e02e9daab949c0f952

2 years agoUpgrade Liquibase to 4.16.0 39/134239/1
lukegleeson [Wed, 19 Apr 2023 14:16:48 +0000 (15:16 +0100)]
Upgrade Liquibase to 4.16.0

Issue-ID: CPS-1627
Signed-off-by: lukegleeson <luke.gleeson@est.tech>
Change-Id: I3f45948b3a483e450b84c53da2e35dd5dc5f686e

2 years agoAddtional dependency updates 35/134235/1
ToineSiebelink [Wed, 19 Apr 2023 11:04:50 +0000 (12:04 +0100)]
Addtional dependency updates

-Allign org.onap.oparent.checkstyle version with oparent version
-Move org.springdoc version control to dependcy mgmt module

Issue-ID: CPS-1627

Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
Change-Id: I0ce3e6bb18341fac1e3d4bd6d7290bcc3bf28f50

2 years agoUpdate spingboot dependencies 23/134223/1
ToineSiebelink [Tue, 18 Apr 2023 13:58:51 +0000 (14:58 +0100)]
Update spingboot dependencies

Issue-ID: CPS-1627

Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
Change-Id: I9a9b4a9593ae2800270dafd319e8b4d27d9e0b3b

2 years agoMerge "Add patch operation for update node leaves"
Priyank Maheshwari [Mon, 17 Apr 2023 15:09:52 +0000 (15:09 +0000)]
Merge "Add patch operation for update node leaves"

2 years agoRemove CollectionUtils dependency 89/134189/3
lukegleeson [Mon, 17 Apr 2023 11:22:07 +0000 (12:22 +0100)]
Remove CollectionUtils dependency

Remove dependency creating pipeline issue

Issue-ID: CPS-1626
Signed-off-by: lukegleeson <luke.gleeson@est.tech>
Change-Id: I64a6019a8196aa98dd3874d08f373c4fb9e3b8c9

2 years ago[CPS] Removing the duplicate producer code 33/134133/4
raviteja.karumuri [Thu, 13 Apr 2023 20:36:55 +0000 (21:36 +0100)]
[CPS] Removing the duplicate producer code

# Using the existing 'EventPublisher' class and deleting the duplicated producer classes.

Issue-ID: CPS-1557
Signed-off-by: raviteja.karumuri <raviteja.karumuri@est.tech>
Change-Id: I6dd8e9c9d9dbec06a2c9464fc2d382fa89f6fc32

2 years agoMerge "[CPS] Re-structuring the packages for better understanding"
Toine Siebelink [Mon, 17 Apr 2023 09:36:00 +0000 (09:36 +0000)]
Merge "[CPS] Re-structuring the packages for better understanding"

2 years agoUse cascade delete in fragments table 11/134111/6
danielhanrahan [Fri, 3 Mar 2023 08:53:56 +0000 (08:53 +0000)]
Use cascade delete in fragments table

- Add Liquibase change to cascade delete fragments
- Remove cascade delete logic from FragmentNativeRepository
- Remove unused method deleteFragmentEntity

Issue-ID: CPS-1617
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: Iecf4f3022b402e0328609ddc11a879c83e5d7f30

2 years agoRemove @NotNull from repository methods 27/134127/4
danielhanrahan [Thu, 13 Apr 2023 16:27:03 +0000 (17:27 +0100)]
Remove @NotNull from repository methods

Issue-ID: CPS-1573
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: I55312bdc5454ed9ca60441b3968d19a61028eb66

2 years agoAdd tests for 32K limit for collection parameters 26/134126/4
danielhanrahan [Thu, 13 Apr 2023 17:53:59 +0000 (18:53 +0100)]
Add tests for 32K limit for collection parameters

SQL queries taking collection parameters currently create a seperate
query parameter for each collection element. There is a limit of
around 2^15 (32,768) query parameters.

- Add tests for cps-service methods exceeding the collection size limit

Issue-ID: CPS-1573
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: I7169b3604f4dd0bb23bba8ff33f0102c43052c03

2 years agoAdd OR operator to cps-path 52/132852/31
Rudrangi Anupriya [Thu, 13 Apr 2023 17:19:06 +0000 (22:49 +0530)]
Add OR operator to cps-path

Issue-ID: CPS-1215
Change-Id: I91fdf5bddcc4fc12a8cf9dbce75f77c832c55871
Signed-off-by: Rudrangi Anupriya <ra00745022@techmahindra.com>
2 years ago[CPS] Re-structuring the packages for better understanding 89/134089/5
raviteja.karumuri [Wed, 12 Apr 2023 15:25:19 +0000 (16:25 +0100)]
[CPS] Re-structuring the packages for better understanding

Issue-ID: CPS-1557
Signed-off-by: raviteja.karumuri <raviteja.karumuri@est.tech>
Change-Id: I16be74808eea6e3ce24574ae24ce082063bd0de9

2 years agoAdd patch operation for update node leaves 34/134034/2
halil.cakal [Thu, 6 Apr 2023 11:03:35 +0000 (12:03 +0100)]
Add patch operation for update node leaves

Issue-ID: CPS-1602
Change-Id: Ie67e6cb6810cd6ea05f3a11f7b195f0f23d39138
Signed-off-by: halil.cakal <halil.cakal@est.tech>
2 years agoMigrate query tests to integration-test module #6 79/133979/17
danielhanrahan [Tue, 4 Apr 2023 13:56:09 +0000 (14:56 +0100)]
Migrate query tests to integration-test module #6

- Remove old tests and broken test data, where fragments in
  ANCHOR-005 have parent fragments in ANCHOR-004
- Migrate tests to new test framework using bookstore model
- Add two bookstore anchors to test querying across both
- Add bookstore data to another test dataspace, to verify querying
  across anchors should be limited to one dataspace
- Lower minimum module coverage, since cps-ri tests are now in
  integration-test
- @Ignore failing tests for now

Issue-ID: CPS-1595
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: I808de288961cb84a486052f9e1dc8fed5f2afe03

2 years agoMerge "Remove "isTagged" mapping method"
Priyank Maheshwari [Thu, 13 Apr 2023 08:43:35 +0000 (08:43 +0000)]
Merge "Remove "isTagged" mapping method"

2 years agoMigrate query tests to integration-test module #5 67/134067/7
danielhanrahan [Tue, 11 Apr 2023 13:36:31 +0000 (14:36 +0100)]
Migrate query tests to integration-test module #5

- Migrate query tests for composite keys to integration-test
- Add addresses with composite key to bookstore model

Issue-ID: CPS-1597
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: I6f8dfc2c44ae6ba3bac1cce804841671ef5a009d

2 years agoRemove "isTagged" mapping method 83/134083/1
lukegleeson [Wed, 12 Apr 2023 13:04:47 +0000 (14:04 +0100)]
Remove "isTagged" mapping method

Remove redundant mapping method causing sonarqube violation

Issue-ID: CPS-1394
Signed-off-by: lukegleeson <luke.gleeson@est.tech>
Change-Id: Ie3ed1411c05fcc3671e547b80b41826dcd6e1fab

2 years agoMerge "Expose endpoint to accept bulk request"
Sourabh Sourabh [Wed, 12 Apr 2023 12:57:52 +0000 (12:57 +0000)]
Merge "Expose endpoint to accept bulk request"

2 years agoMigrate query tests to integration-test module #3 27/134027/5
danielhanrahan [Wed, 5 Apr 2023 16:11:24 +0000 (17:11 +0100)]
Migrate query tests to integration-test module #3

Issue-ID: CPS-1597
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: I1d92355f272271424a7014057d251cf88eac0203

2 years agoMerge "Migrate query tests to integration-test module #2"
Sourabh Sourabh [Wed, 12 Apr 2023 12:14:17 +0000 (12:14 +0000)]
Merge "Migrate query tests to integration-test module #2"

2 years agoPerformance tests for getDataNodes and queryDataNodes 10/133510/10
danielhanrahan [Tue, 28 Mar 2023 15:43:10 +0000 (16:43 +0100)]
Performance tests for getDataNodes and queryDataNodes

- Generate openroadm data from a single innerNode.json template
- Double the number of openroadm device nodes (25 -> 50) in tests
- Add new performance tests for getDataNodes and queryDataNodes to
  integration-test module, using openroadm and bookstore data
- Remove old performance tests from cps-ri

Issue-ID: CPS-1524
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: Id9ec2a86d984d6c50c9ae6093e7a62729cb851da

2 years agoMigrate query tests to integration-test module #2 26/134026/5
danielhanrahan [Tue, 4 Apr 2023 18:00:44 +0000 (19:00 +0100)]
Migrate query tests to integration-test module #2

- Migrate some query tests to integration-test
- Edit bookstore model to add integer leaf-list 'editions'
- Lower cps-ri code coverage

Issue-ID: CPS-1597
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: If50bf15ad7d7f147448f6b60d464efc1cdc91005

2 years agoMerge "Migrate query tests to integration-test module #1"
Toine Siebelink [Tue, 11 Apr 2023 16:29:28 +0000 (16:29 +0000)]
Merge "Migrate query tests to integration-test module #1"

2 years agoMerge "Populate Dataspace field of DataNode"
Toine Siebelink [Tue, 11 Apr 2023 16:26:59 +0000 (16:26 +0000)]
Merge "Populate Dataspace field of DataNode"

2 years agoMigrate query tests to integration-test module #1 25/134025/3
danielhanrahan [Wed, 5 Apr 2023 15:41:55 +0000 (16:41 +0100)]
Migrate query tests to integration-test module #1

Issue-ID: CPS-1597
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: I0403641e2e5293571c61a58aa2b67b144cf68ac4

2 years agoMerge "[CPS] Fix SonarQube Violations / Improve Coverage - Recurring task"
Toine Siebelink [Tue, 11 Apr 2023 15:51:43 +0000 (15:51 +0000)]
Merge "[CPS] Fix SonarQube Violations / Improve Coverage - Recurring task"

2 years ago[CPS] Fix SonarQube Violations / Improve Coverage - Recurring task 02/134002/3
raviteja.karumuri [Tue, 4 Apr 2023 00:14:11 +0000 (01:14 +0100)]
[CPS] Fix SonarQube Violations / Improve Coverage - Recurring task

Issue-ID: CPS-475
Signed-off-by: raviteja.karumuri <raviteja.karumuri@est.tech>
Change-Id: I7429e1563608159b5592a2dc52ab5383f11a8ab3

2 years agoPopulate Dataspace field of DataNode 23/134023/2
danielhanrahan [Wed, 5 Apr 2023 15:16:56 +0000 (16:16 +0100)]
Populate Dataspace field of DataNode

Issue-ID: CPS-1603
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: I85aca8bccc28d36aa4cefa0a32cb9bdf2156618a

2 years agoMerge "Migrate query tests to integration-test module #4"
Sourabh Sourabh [Tue, 11 Apr 2023 09:06:58 +0000 (09:06 +0000)]
Merge "Migrate query tests to integration-test module #4"

2 years ago[CPS] Bump minor version - Step12 41/134041/2
mpriyank [Fri, 7 Apr 2023 09:12:31 +0000 (10:12 +0100)]
[CPS] Bump minor version - Step12

- bump minor cps version from 3.2.7-SNAPSHOT to 3.3.0-SNAPSHOT which is
  step11 of the release process

Issue-ID: CPS-1610
Change-Id: I74f20a7a7fa1edad417c40a09a60fecc0a96ccb7
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2 years agoToggle subscription persistence for model loader 37/134037/1
lukegleeson [Thu, 6 Apr 2023 14:36:40 +0000 (15:36 +0100)]
Toggle subscription persistence for model loader

Current implementation will attempt to persist the subscription model for subscription create events even when the model loader is disabled which causes a persistence error. Subscription Model will now be persisted based on whether the model loader is enabled

Issue-ID: CPS-1394
Signed-off-by: lukegleeson <luke.gleeson@est.tech>
Change-Id: I8f8cfc47996eed6b95fd3958996f16c8395dc341

2 years agoMigrate query tests to integration-test module #4 28/134028/1
danielhanrahan [Wed, 5 Apr 2023 16:33:05 +0000 (17:33 +0100)]
Migrate query tests to integration-test module #4

Issue-ID: CPS-1597
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: Id3b4a3829b6f9aec1a649ed0001d7c11db91ccfe

2 years agoExpose endpoint to accept bulk request 17/134017/1
leventecsanyi [Wed, 5 Apr 2023 10:57:14 +0000 (12:57 +0200)]
Expose endpoint to accept bulk request

 - added wiremock mapping for testing/demo

Issue-ID: CPS-1555
Change-Id: I82af6c43e80a346efcd84aae8945572aa37a6875
Signed-off-by: leventecsanyi <levente.csanyi@est.tech>
2 years agoMerge "Add Query Spec to integration-test package"
Priyank Maheshwari [Tue, 4 Apr 2023 14:58:34 +0000 (14:58 +0000)]
Merge "Add Query Spec to integration-test package"

2 years agoMerge "500 Error Response on NCMP ID-Searches Testing"
Luke Gleeson [Tue, 4 Apr 2023 14:04:53 +0000 (14:04 +0000)]
Merge "500 Error Response on NCMP ID-Searches Testing"

2 years agoAdd Query Spec to integration-test package 00/134000/1
lukegleeson [Tue, 4 Apr 2023 09:17:18 +0000 (10:17 +0100)]
Add Query Spec to integration-test package

Issue-ID: CPS-1598
Signed-off-by: lukegleeson <luke.gleeson@est.tech>
Change-Id: Ifab8863eae4a3ee07ba3d6096e73f9f98077584d

2 years agoMerge "Persist SubscriptionEvent"
Priyank Maheshwari [Mon, 3 Apr 2023 15:22:28 +0000 (15:22 +0000)]
Merge "Persist SubscriptionEvent"

2 years ago500 Error Response on NCMP ID-Searches Testing 55/133955/5
seanbeirne [Thu, 30 Mar 2023 18:16:28 +0000 (19:16 +0100)]
500 Error Response on NCMP ID-Searches Testing

Issue-ID: CPS-1563
Signed-off-by: seanbeirne <sean.beirne@est.tech>
Change-Id: Idc393e90d31b369095bc2b122537e17a4464a364

2 years agoRemove docs/conf.yaml 80/133980/1
danielhanrahan [Fri, 31 Mar 2023 12:41:53 +0000 (13:41 +0100)]
Remove docs/conf.yaml

Change to ONAP pipeline is causing docs-rules job to fail if
docs/conf.yaml file exists. So we remove it.

Issue-ID: CPS-1596
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: I4aa576c698162b2a99ca1459d9d192b88c3ac9b6

2 years agoMerge "Update performance test timings"
Toine Siebelink [Thu, 30 Mar 2023 15:51:00 +0000 (15:51 +0000)]
Merge "Update performance test timings"

2 years agoMerge "[CPS] Improve code coverage for Class 'SubscriptionModelLoader'"
Toine Siebelink [Thu, 30 Mar 2023 15:44:23 +0000 (15:44 +0000)]
Merge "[CPS] Improve code coverage for Class 'SubscriptionModelLoader'"

2 years agoPersist SubscriptionEvent 01/133801/3
lukegleeson [Thu, 23 Mar 2023 17:36:15 +0000 (17:36 +0000)]
Persist SubscriptionEvent

- Updated subscription.yang to subscription name instead of client name
- Implemented Mapper for SubscriptionEvent to yang model version
- Implemented Subscription Persistence for storing subscriptions
- Minor changes to existing variable names

Issue-ID: CPS-1394
Signed-off-by: lukegleeson <luke.gleeson@est.tech>
Change-Id: Ibe066006a913cb7f6e52b6fa8a851e976a338ac3

2 years agoFix assertion in integration-test performance tests 46/133946/1
danielhanrahan [Thu, 30 Mar 2023 14:10:55 +0000 (15:10 +0100)]
Fix assertion in integration-test performance tests

Issue-ID: CPS-1587
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: I044e4c81ce9972bb7979b494496d74beb733c5ed

2 years agoUpdate performance test timings 43/133943/1
danielhanrahan [Thu, 30 Mar 2023 13:37:51 +0000 (14:37 +0100)]
Update performance test timings

Issue-ID: CPS-1524
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: Iaa8e9a0ca3170a2b487df312834245d609fdfe13

2 years ago[CPS] Improve code coverage for Class 'SubscriptionModelLoader' 20/133920/3
raviteja.karumuri [Thu, 30 Mar 2023 11:21:58 +0000 (12:21 +0100)]
[CPS] Improve code coverage for Class 'SubscriptionModelLoader'

Issue-ID: CPS-1584
Signed-off-by: raviteja.karumuri <raviteja.karumuri@est.tech>
Change-Id: Ief2b14cc90c24db50a95f1c62661b1918413408e

2 years ago[CPS] Fix SonarQube Violations / Improve Coverage - Recurring task 53/133853/2
raviteja.karumuri [Fri, 24 Mar 2023 17:50:58 +0000 (17:50 +0000)]
[CPS] Fix SonarQube Violations / Improve Coverage - Recurring task

Issue-ID: CPS-475
Signed-off-by: raviteja.karumuri <raviteja.karumuri@est.tech>
Change-Id: Id3507fb24c4c6eb002a9ae6fed553daa2fca7895

2 years agoEnhanced logging for bug 56/133856/1
mpriyank [Mon, 27 Mar 2023 11:54:45 +0000 (12:54 +0100)]
Enhanced logging for bug

- Added minor logging and temporarily converted some debug logs to info
  level

Issue-ID: CPS-1566
Change-Id: I2c706ecd601b06f2a92388b318a44640c682bdd1
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2 years agoMerge "Fixes for CM-handle de-registration test script"
Toine Siebelink [Mon, 27 Mar 2023 08:17:34 +0000 (08:17 +0000)]
Merge "Fixes for CM-handle de-registration test script"