shashikanth [Tue, 26 Sep 2017 08:11:49 +0000 (13:41 +0530)]
Fix Blocker/Critical sonar issues
Fix Blocker/Critical sonar issues in appc module
https://sonar.onap.org/component_issues?id=org.openecomp.appc%3Aappc#resolved=false|severities=BLOCKER|fileUuids=AV36PknS89V-MRZU58_f
Fixed issue Close "FileInputStream".
Issue-Id: APPC-186
Change-Id: I2fab5e54735992a4cbf2972628574edd17905fe3
Signed-off-by: shashikanth.vh <shashikanth.vh@huawei.com>
mojahidi [Tue, 26 Sep 2017 12:09:23 +0000 (17:39 +0530)]
Increased test coverage for appc-java-client
Added Junit test cases to increase test coverage for appc-java-client
Change-Id: I31154acea348f50da5df47262611bfb108a4ed3a
Issue-ID:APPC-223
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
sanchitap [Wed, 27 Sep 2017 06:56:01 +0000 (12:26 +0530)]
Sonar Critical Fix
ProviderStackOperation.java: L98 and L178
Sonar link:https://sonar.onap.org/component_issues/index?id=org.openecomp.appc%3Aappc#resolved=false|severities=CRITICAL|rules=squid%3AS2184
Change-Id: Id73e2153b13716706b0dce4204d8c7519855afe5
Issue-Id :APPC-237
Signed-off-by: sanchitap <sanchita@techmahindra.com>
Patrick Brady [Wed, 27 Sep 2017 20:52:25 +0000 (13:52 -0700)]
Revert Increase coverage of SDC Event Listener
This reverts commit
8b88bb6f258cf8af9d1658a0514eba6daa31f93c.
The commit is causing test failures and blocks all jobs.
Change-Id: I1e82f74d34bc4201690beea89bebe61c9d3845e2
Signed-off-by: Patrick Brady <pb071s@att.com>
Issue-id: APPC-228
Marcus G K Williams [Tue, 26 Sep 2017 20:35:23 +0000 (13:35 -0700)]
Update appc parent pom verson
Updating parent pom to latest
version in ccsdk parent.
Issue-Id: CCSDK-104
Change-Id: If7c9573f30dac43bf4d0337a349208824d49f1a2
Signed-off-by: Marcus G K Williams <marcus.williams@intel.com>
Summers, Gregory (gs2953) [Tue, 26 Sep 2017 21:12:27 +0000 (16:12 -0500)]
Fix Sonar blocker issue for resource leak
Issue-ID: APPC-186
Change-Id: I6177d3976e4e91a6f29bee21558dc603aed44f1f
Signed-off-by: Summers, Gregory (gs2953) <gs2953@att.com>
Hao Kuang [Mon, 25 Sep 2017 22:19:44 +0000 (22:19 +0000)]
Add junits for dg-util to increase test coverage
Issue-Id: APPC-228
Change-Id: I805127d7b57bc88e97151e9a4e217fe384a33ffb
Signed-off-by: Hao Kuang <Hao.Kuang@amdocs.com>
amshegokar [Tue, 26 Sep 2017 10:53:38 +0000 (16:23 +0530)]
Sonar Blocker
Link: https://sonar.onap.org/component_issues/index?id=org.openecomp.appc%3Aappc#resolved=false|severities=BLOCKER|rules=squid%3AS2095
Change-Id: Id73e2153b13716706b0dce4204d8c7519850afe5
Issue-ID: APPC-236
Signed-off-by: amshegokar <AS00500801@techmahindra.com>
Abhai Singh [Mon, 25 Sep 2017 12:09:30 +0000 (17:39 +0530)]
[APPC-232] Increase coverage of SDC Event Listener
Updated unit test in SdcCallbackTest
Issue-Id :APPC-232
Change-Id: Ifa6d998d97de7637e9addc3c6e90984c3accc72d
Signed-off-by: Abhai Singh <Abhai.Singh@amdocs.com>
Summers, Gregory (gs2953) [Tue, 19 Sep 2017 15:27:30 +0000 (10:27 -0500)]
Fix Sonar Blocker for resource leak
Issue-ID: APPC-186
Change-Id: Id73e2153b13716706b0dce4204d8c7519840afe3
Signed-off-by: Summers, Gregory (gs2953) <gs2953@att.com>
beili.zhou [Fri, 22 Sep 2017 21:16:48 +0000 (17:16 -0400)]
Increase sonar coverage for LifecycleManagement
Add Junit tests in state-machine-lib
Issue-Id: APPC-225
Change-Id: I54b307663f1e593d597f1c93ed800ea657959030
Signed-off-by: beili.zhou <beili.zhou@amdocs.com>
beili.zhou [Fri, 22 Sep 2017 15:12:11 +0000 (11:12 -0400)]
Fix VM_Start(2.0.0) and VM_Stop(2.0.0) DG
VM_Start DG was submitted with Rebuild_VM DG content
VM_Stop DG needs an extra block for success path
Issue-Id: APPC-217
Change-Id: I69c43576f1e266383b98383879b936b8f4b9c9c4
Signed-off-by: beili.zhou <beili.zhou@amdocs.com>
amshegokar [Thu, 21 Sep 2017 13:51:47 +0000 (19:21 +0530)]
Sonar Blocker
for blocker APP-C Common. Sonar Link:https://sonar.onap.org/component_issues/index?id=org.openecomp.appc%3Aappc#severities=BLOCKER|rules=squid%3AS2097
Change-Id: I65ee1745f5fd5a7f7ac3365704943b22a9341e8a
Issue-ID: APPC-224
Signed-off-by: amshegokar <AS00500801@techmahindra.com>
Scott Seabolt [Wed, 20 Sep 2017 14:33:30 +0000 (10:33 -0400)]
Updated APPC Documentation
Updated APPC Guides and index.rst for documentation cleanup purposes
Issue-ID: [APPC-102]
Change-Id: I22e249e4fa6be1bf621a0627edc550e983930380
Signed-off-by: Scott Seabolt <js9808@att.com>
amshegokar [Wed, 20 Sep 2017 08:48:03 +0000 (14:18 +0530)]
Sonar Blocker
For rest healthcheck Adapter-bundle
Change-Id: Ic499d7af6c90cd692e8362ba4f7d2f5d62d48422
Issue-ID: APPC-216
Signed-off-by: Shubhada Ramkrishna Vaze <SV00449682@TechMahindra.com>
Signed-off-by: Skip Wonnell <skip@att.com>
shashikanth [Mon, 18 Sep 2017 09:14:59 +0000 (14:44 +0530)]
Fix Blocker/Critical sonar issues
Fix Blocker/Critical sonar issues in appc module
https://sonar.onap.org/issues/search#issues=AV36Pm5i89V-MRZU59OH
Fixed NullPointerException might be thrown as 'data' is nullable here
Issue-Id: APPC-186
Change-Id: I65ee1745f5fd5a7f7ac3365704943b25a9341e8a
Signed-off-by: shashikanth.vh <shashikanth.vh@huawei.com>
Shubhada Ramkrishna Vaze [Wed, 20 Sep 2017 07:49:55 +0000 (13:19 +0530)]
Sonar Blocker
Sonar Blocker for PrecheckOption.java
Change-Id: Ic499d7af6c90cd692e8362ba4f7d2f5d65d48471
Issue-ID: APPC-223
Signed-off-by: Shubhada Ramkrishna Vaze <SV00449682@TechMahindra.com>
Ramya Balaji [Wed, 20 Sep 2017 00:58:45 +0000 (20:58 -0400)]
Changes to ProtocolReference table insert
Added Code to check if record exists previously in table. If so, make an update else insert.
Issue-ID:APPC-220
Change-Id: I3825128d8381a4f0c7e62926be6ecec9ab178194
Signed-off-by: Ramya Balaji <rb111y@att.com>
beili.zhou [Tue, 19 Sep 2017 17:14:53 +0000 (13:14 -0400)]
Add APPC VM_Start(2.0.0) and VM_Stop(2.0.0) DGs
Issue-Id: APPC-217
Change-Id: If7b087b715630fcb8d9d5cb3effdd10548ab00be
Signed-off-by: beili.zhou <beili.zhou@amdocs.com>
shashikanth [Mon, 18 Sep 2017 10:53:55 +0000 (16:23 +0530)]
Fix Blocker/Critical sonar issues
Fix Blocker/Critical sonar issues in appc module
https://sonar.onap.org/component_issues?id=org.openecomp.appc%3Aappc#resolved=false|severities=BLOCKER
Fixed null pointer exceptions for localContext and removed redundant check for localContext
Issue-Id: APPC-186
Change-Id: I38223655d69b89f6828fbdc7f3f388031e22f412
Signed-off-by: shashikanth.vh <shashikanth.vh@huawei.com>
mojahidi [Tue, 12 Sep 2017 12:19:10 +0000 (17:49 +0530)]
Removed TOSCA_CSAR and upgrade sdc version
removed TOSCA_CSAR from ArtifactfactProcessorFactory to stop listening tosca_csar artifacts
upgrade the sdc client version compatible for 1710 release
Change-Id: Id6db5831a1f625fd8fc040bfd50c6662486730f4
Issue-ID:APPC-203
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
shashikanth [Mon, 18 Sep 2017 09:59:53 +0000 (15:29 +0530)]
Fix Blocker/Critical sonar issues
Fix Blocker/Critical sonar issues in appc module
https://sonar.onap.org/component_issues?id=org.openecomp.appc%3Aappc#resolved=false|severities=BLOCKER
Redundent if condition removed from DGGeneralDBService.java
Issue-Id: APPC-92
Change-Id: I9b963759e562dc0744b3742a70905a417c3c444a
Signed-off-by: shashikanth.vh <shashikanth.vh@huawei.com>
shashikanth [Mon, 18 Sep 2017 08:23:55 +0000 (13:53 +0530)]
Fix Blocker/Critical sonar issues
Fix Blocker/Critical sonar issues in appc module
https://sonar.onap.org/component_issues?id=org.openecomp.appc%3Aappc#resolved=false|severities=BLOCKER
Fixed null pointer exceptions for QueryStatus and db string.
Issue-Id: APPC-92
Change-Id: Ic499d7af6c90cd692e8362ba4f7d2f5d65d49471
Signed-off-by: shashikanth.vh <shashikanth.vh@huawei.com>
amshegokar [Mon, 18 Sep 2017 06:44:28 +0000 (12:14 +0530)]
Sonar Blocker
Sonar Blocker for appc client-simulator
Change-Id: Ia7c4d115e2fcbd29eb132791958286b097118431
Issue-ID: APPC-210
Signed-off-by: amshegokar <AS00500801@techmahindra.com>
amshegokar [Mon, 18 Sep 2017 06:17:25 +0000 (11:47 +0530)]
Sonar Blocker
Sonar Blocker for appc-sdc-listener-bundle
Change-Id: Ia7c4d115e2fcbd29eb132791958286b077118431
Issue-ID: APPC-209
Signed-off-by: amshegokar <AS00500801@techmahindra.com>
Skip Wonnell [Mon, 18 Sep 2017 04:11:45 +0000 (23:11 -0500)]
Add LICENSE.txt to root directory
Change-Id: Ib0fc208632783058a4088fe41c5056f2531997d1
Issue-ID: APPC-90
Signed-off-by: Skip Wonnell <skip@att.com>
Marcus G K Williams [Fri, 8 Sep 2017 00:16:09 +0000 (17:16 -0700)]
Add Unit Tests for appc-chef-adapter
Issue-Id: APPC-181
Change-Id: Iee824ca929ea46944ac1673e709074687ad812f9
Signed-off-by: Marcus G K Williams <marcus.williams@intel.com>
Marcus G K Williams [Fri, 8 Sep 2017 00:17:07 +0000 (17:17 -0700)]
Fix/Add unit tests for appc-rest-adapter
Refactored RestAdapterImpl.java and added
RequestFactory.java to enable cleaner
unit tests. Added unit tests.
Issue-Id: APPC-182
Change-Id: I129a9145ac028eda3257ef8c26f67b87f12c683f
Signed-off-by: Marcus G K Williams <marcus.williams@intel.com>
sanchitap [Fri, 15 Sep 2017 06:24:44 +0000 (11:54 +0530)]
Sonar Blocker fix
Redundent if condition removed from DGXMLLoadNActive.java L70 & L102
Change-Id: Ia7c4d115e2fcbd29eb132791958286b077118441
Issue-ID: APPC-202
Signed-off-by: sanchitap <sanchita@techmahindra.com>
Patrick Brady [Wed, 13 Sep 2017 07:11:21 +0000 (00:11 -0700)]
Changing to mariadb java client
Changing from the mysql java connector to the
mariadb java client.
Change-Id: I2f9b1f5da37424d529e196f9b6b8d0bf4f1f9d2f
Signed-off-by: Patrick Brady <pb071s@att.com>
Issue-id: APPC-198
rb111y [Tue, 5 Sep 2017 20:18:36 +0000 (16:18 -0400)]
Updated DG and dg loader textfile
Updated dg_activate.txt to point to correct rpc.
Also made updates to Restart DG for invalid action
level.
Issue-ID : APPC-197
Change-Id: Ia7c4d115e2fcbd29eb132791958286b077115441
Signed-off-by: Ramya Balaji <rb111y@att.com>
Skip Wonnell [Thu, 14 Sep 2017 14:50:07 +0000 (09:50 -0500)]
Update TTL calculation to use milliseconds
Code used mix of seconds and milliseconds
calculate TTL. Updated to use consistent
units. Also added a new test file to
increase code coverage.
Issue-ID: APPC-207
Issue-ID: APPC-181
Change-Id: I07687ac30fa2e75cedb027ec2bb71f6914d42075
Signed-off-by: Skip Wonnell <skip@att.com>
Scott Seabolt [Wed, 13 Sep 2017 21:31:44 +0000 (17:31 -0400)]
Updated APPC Documentation
Updated APPC Guides and index.rst to reflect docs properly and removed conf.py as it is not needed
Issue-ID: [APPC-102]
Change-Id: I89bf3bc9fa289d9b15205f8cd5da890ae8b29776
Signed-off-by: Scott Seabolt <js9808@att.com>
Patrick Brady [Wed, 13 Sep 2017 06:55:40 +0000 (23:55 -0700)]
Correcting incorrect package import
Change-Id: I1e8738d321769ca713f32ece2b650487d3fdcfdf
Signed-off-by: Patrick Brady <pb071s@att.com>
Issue-id: APPC-91
Issue-id: APPC-158
mojahidi [Tue, 12 Sep 2017 13:23:34 +0000 (18:53 +0530)]
validate mandatry vnfc vm info is absent in invent
when the vnfc SMP is mandatory in the
dependency-info block but its corresponding vm details/info is not present in the inventory info validation error should be thrown
Issue-ID:APPC-204
Change-Id: I606da8ce086423cf3f23c87ab0166bfb9935875b
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
Patrick Brady [Tue, 12 Sep 2017 17:29:40 +0000 (10:29 -0700)]
Correcting maven staging plugin
Change-Id: I5dd7e431568520fa7d6e65cba435aeadc3444482
Signed-off-by: Patrick Brady <pb071s@att.com>
Issue-id: APPC-91
Issue-id: APPC-158
Ramya Balaji [Mon, 11 Sep 2017 19:50:25 +0000 (15:50 -0400)]
Junit Cases for Artifact Handler.
Issue-ID : APPC-168
Change-Id: Id2b211d5656ffa8d5f326c30d745bc497e76f4d0
Signed-off-by: Ramya Balaji <rb111y@att.com>
Patrick Brady [Mon, 11 Sep 2017 03:12:40 +0000 (20:12 -0700)]
Correcting problems related to ccsdk,new odl
Some imports and dependencies needed to be updated which no
longer exist in the new ODl version
Change-Id: I57c52b73810d3f9770b764a2afe4147d3120a87b
Signed-off-by: Patrick Brady <pb071s@att.com>
Issue-id: APPC-91
Issue-id: APPC-158
Scott Seabolt [Fri, 8 Sep 2017 19:08:33 +0000 (15:08 -0400)]
Add APPC API Guide and APPC Client Library Guide
Update index.rst to reflect new docs added
Issue-ID: [APPC-102]
Change-Id: Id07852a9318cd8168c26f074f9ab3b6b6c441232
Signed-off-by: Scott Seabolt <js9808@att.com>
Jessica Wagantall [Fri, 8 Sep 2017 21:32:54 +0000 (14:32 -0700)]
Cleanup project's name in Sonar
The name parameter in the root pom.xml should
match the project name in gerrit to reflect consistency
in Sonar.
Change-Id: Iede5b1c1bf5e1459e01048e900cbfb46d5f3ded8
Issue-id: CIMAN-65
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>
Skip Wonnell [Thu, 7 Sep 2017 19:42:29 +0000 (14:42 -0500)]
Fix sonar block in Encryption Tool
Fix blockers and other Sonar findings.
Update license text
Issue-ID: APPC-186
Change-Id: Ib45020d85bde95f79b112ebd85fedfe62469b58f
Signed-off-by: Skip Wonnell <skip@att.com>
Marcus G K Williams [Thu, 7 Sep 2017 20:26:31 +0000 (13:26 -0700)]
Fix dblib DBResourceManager instantiation
Fix APPC Build, failing upstream and locally due to
change in CCSDK that changes dblib to use service
injection via Aries Blueprint. The change causing
this in CCSDK is https://gerrit.onap.org/r/#/c/7931/
Issue-Id: APPC-196
Change-Id: I9bcfb6d87b7527fd07cb76a242b272a5bc0ad07c
Signed-off-by: Marcus G K Williams <marcus.williams@intel.com>
Patrick Brady [Tue, 5 Sep 2017 04:37:25 +0000 (21:37 -0700)]
Change to CCSDK and ODL Carbon
Change-Id: I49a0f436e366ff4a1b99705fb6bb5e7ba82e6ecc
Signed-off-by: Patrick Brady <pb071s@att.com>
Issue-Id: [APPC-91]
Issue-Id: [APPC-158]
Skip Wonnell [Sat, 2 Sep 2017 02:11:16 +0000 (21:11 -0500)]
Code clean-up in ChefAdapterImpl.java
Fix multiple issues found in Sonar Analysis
Issue-ID: APPC-156
Change-Id: I242c45a2eab7c4e31fb42ff9d17405aa3f210147
Signed-off-by: Skip Wonnell <skip@att.com>
Chaturvedi, Anand (ac204h) [Fri, 1 Sep 2017 21:00:25 +0000 (17:00 -0400)]
Junit Changes for APPC Params Bundle
Issue-ID: APPC-168
Change-Id: Ie0ddf5905f90a409db111a1cfdf728a44737a158
Signed-off-by: Chaturvedi, Anand (ac204h) <ac204h@att.com>
Chaturvedi, Anand (ac204h) [Thu, 31 Aug 2017 23:07:53 +0000 (19:07 -0400)]
[JunitCases]for config audit and config generator.
Change-Id: I7fc00ce3c8efab282954aab87db0b23da336d732
Issue-ID: APPC-189
Signed-off-by: Chaturvedi, Anand (ac204h) <ac204h@att.com>
Chaturvedi, Anand (ac204h) [Fri, 1 Sep 2017 19:35:26 +0000 (15:35 -0400)]
Junit Cases for Application Controller.
Issue-ID: APPC-168
Change-Id: Iacfc853bef0b641599c60055ac05b1fd090ee3f8
Signed-off-by: Chaturvedi, Anand (ac204h) <ac204h@att.com>
Chaturvedi, Anand (ac204h) [Thu, 31 Aug 2017 23:07:53 +0000 (19:07 -0400)]
[JunitCases]for config audit and config generator.
Issue-ID: APPC-168
Change-Id: Ie6f5e13b63f3162530d71c60cf352a8bfcddf4ff
Signed-off-by: Chaturvedi, Anand (ac204h) <ac204h@att.com>
Hao Kuang [Fri, 1 Sep 2017 14:11:57 +0000 (14:11 +0000)]
Fix classNotFound issue when executing dg-loader
Change slf4j from transitive dependency to explicit dependency.
Issue-Id: APPC-188
Change-Id: I8054b5c4e0c0023be1fd6ae7a7e89799682f20fd
Signed-off-by: Hao Kuang <Hao.Kuang@amdocs.com>
RY303T [Wed, 30 Aug 2017 20:12:42 +0000 (16:12 -0400)]
Modify IaaS adapter URL parsing to include path
Modified the pattern in IdentityURL and VMURL to include optional path
Modified the toString in IdentityURL and VMURL to properly print the
full url string
Updated tests to include new URL format
Issue-ID: APPC-133
Change-Id: Ic7c272b70d4fe18c815d5dd5311f760d8b8953c1
Signed-off-by: RY303T <RY303T@att.com>
mojahidi [Tue, 29 Aug 2017 12:50:26 +0000 (18:20 +0530)]
Update ASDC References to SDC 1/2
This patch changes ASDC to SDC in APPC code, bundle
names and other pertinent places. This change
sanitizes SDC for Open Source. It
is the first in a two part change, the first
updates code mentions and artifacts. The second will
update database references.
Change-Id: Iffd73480cc325172b5d8969fe839728f1c88ef78
Issue-ID:APPC-179
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
Skip Wonnell [Thu, 31 Aug 2017 14:27:46 +0000 (09:27 -0500)]
Fix sonar blocker in ChefAdpater
Issue-ID: APPC-156
Change-Id: Ic2cbb76bb639094386c14bd06e068c9d5ad7bd0d
Signed-off-by: Skip Wonnell <skip@att.com>
Scott Seabolt [Wed, 30 Aug 2017 18:15:26 +0000 (14:15 -0400)]
Add appc directory and index
Adding docs index directory
Issue-ID: [APPC-102]
Signed-off-by: Scott Seabolt <js9808@att.com>
Change-Id: I4882dc6ae042010edf6c999fc1ceb415c350beb0
Kalpesh Chaniyara [Tue, 29 Aug 2017 08:38:52 +0000 (04:38 -0400)]
removed att reference from pom file
Removed att reference from the feature
repository in pom file
Issue-Id : APPC-177
Change-Id: Id2f7df836e3a0bd1204bdb93b72e9ac76d38fbba
Signed-off-by: Kalpesh Chaniyara <kalpeshkumar.chaniyara@amdocs.com>
beili.zhou [Tue, 29 Aug 2017 22:33:57 +0000 (18:33 -0400)]
Remove catch throwable and error
Fix the following sonar blocker issue:
- Catch Exception instead of Throwable
- Catch Exception instead of Error
Issue-Id: APPC-175
Change-Id: I16a1018001b067216740ec11e5a97e52d714db69
Signed-off-by: beili.zhou <beili.zhou@amdocs.com>
Abhai Singh [Tue, 29 Aug 2017 09:14:41 +0000 (14:44 +0530)]
Increase unit test coverage of appc-metric module
Updated test class TestMetricServiceImpl with unit test cases
Change-Id: I4290f426259b837ad4db63efd8d64ba9989843cd
Issue-ID:APPC-176
Signed-off-by: Abhai Singh <Abhai.Singh@amdocs.com>
Kalpesh Chaniyara [Mon, 28 Aug 2017 11:40:55 +0000 (17:10 +0530)]
Added domain model package as bundle dependency
Added org.openecomp.appc.domainmodel.lcm package
as the dependency for bundle appc-provider-bundle
Change-Id: I9130c36204dd595dceb5e04689014f40774b4f2c
Issue-Id:APPC-169
Signed-off-by: Kalpesh Chaniyara <kalpeshkumar.chaniyara@amdocs.com>
Skip Wonnell [Wed, 30 Aug 2017 03:39:17 +0000 (22:39 -0500)]
Initial add of APPC client libraries
Issue-ID: APPC-180
Change-Id: Ie0be2b518b90bb7f9996e9260c43fef75d1a5821
Signed-off-by: Skip Wonnell <kw5258@att.com>
Skip Wonnell [Tue, 29 Aug 2017 19:16:20 +0000 (14:16 -0500)]
ChefAdapter code clean-up
Issue-ID: APPC-90
Change-Id: I582d6b0c81d5a89938fff6038dfcc221ccaf19c1
Signed-off-by: Skip Wonnell <kw5258@att.com>
Abhai Singh [Wed, 30 Aug 2017 07:42:53 +0000 (13:12 +0530)]
Truncate Service_Description field
Updated ArtifactStorageService to truncate if length exceeds 255
Change-Id: If456802c3370553d9ed3a8942ff16b407f896ed2
Issue-ID:APPC-184
Signed-off-by: Abhai Singh <Abhai.Singh@amdocs.com>
beili.zhou [Tue, 29 Aug 2017 22:06:38 +0000 (18:06 -0400)]
Remove duplicate code
Create a method for duplicated code to reduce code duplication in IAAS
adapter provider operation.
Issue-Id: APPC-175
Change-Id: Idfbfc7ffad433d0e7469b214e5b09d0dfd5dd7d2
Signed-off-by: beili.zhou <beili.zhou@amdocs.com>
beili.zhou [Tue, 29 Aug 2017 20:26:56 +0000 (16:26 -0400)]
Fix local build failure
Fix local build is failing in appc-network-inventory-client-provider due to
missing dependency definition for PowerMockito.
Issue-Id: APPC-175
Change-Id: I47695277d6d635707cfd23246951ae22f02698f2
Signed-off-by: beili.zhou <beili.zhou@amdocs.com>
Skip Wonnell [Tue, 29 Aug 2017 01:59:46 +0000 (20:59 -0500)]
RestAdapter code clean-up
Issue-ID: APPC-90
Change-Id: I34b07327c82fb080d94d0fa6c70ae5cdfd8c5eb0
Signed-off-by: Skip Wonnell <kw5258@att.com>
Skip Wonnell [Tue, 29 Aug 2017 03:02:54 +0000 (22:02 -0500)]
Clean up directed graph java code
Issue-ID: APPC-90
Change-Id: I3ea4912523eed1fed85aa2e5909ec897bb13b72b
Signed-off-by: Skip Wonnell <kw5258@att.com>
Hao Kuang [Fri, 25 Aug 2017 16:15:26 +0000 (16:15 +0000)]
Fix that APP-C LCM Command Running After OAM Stop
The fix code does that waiting for threads in the queue completely
interrupted than let bundle:stop() method return.
Issue-Id: APPC-162
Change-Id: I8b34fc48fd2ae5ae1ad67d11ee3ad5f349171b47
Signed-off-by: Hao Kuang <Hao.Kuang@amdocs.com>
Anand Chaturvedi [Fri, 25 Aug 2017 23:17:38 +0000 (19:17 -0400)]
Junit for APPC for Network Client
Issue-ID: APPC-168
Change-Id: I0654a0d6123b5827458cd3e15e12a1b5b254f918
Signed-off-by: Anand Chaturvedi <ac204h@att.com>
Anand Chaturvedi [Fri, 25 Aug 2017 20:15:07 +0000 (16:15 -0400)]
Junit Cases for APPC dataServices
Issue-ID: APPC-168
Change-Id: Ia5ae825f1c7919d93afb460cde7ae0fa2bcd0c6c
Author: Anand Chaturvedi <ac204h@att.com>
Date: Fri Aug 25 15:41:42 2017 -0400
Signed-off-by: Anand Chaturvedi <ac204h@att.com>
beili.zhou [Fri, 25 Aug 2017 18:11:11 +0000 (14:11 -0400)]
Enhance ASDC listener bundler start and stop
Store ASDC listner start up initialization thread, to provide reference
for ASDC listener stop to terminate the thread if it is still running at
stopping time.
Add thread interrupt checking in initialization thread, to allow earlier
termination of the thread during stopping process.
Issue-Id: APPC-166
Change-Id: Ibc13afce251ce9344a4ad807d3927fc277bcbe6c
Signed-off-by: beili.zhou <beili.zhou@amdocs.com>
Anand Chaturvedi [Thu, 24 Aug 2017 04:10:17 +0000 (00:10 -0400)]
Added New Junit Cases for APPC Design Services
Change-Id: Icc55aaadc1df1b8c368afaeb092a6c64a71202b7
Issue-ID: APPC-168
Signed-off-by: Anand Chaturvedi <ac204h@att.com>
Anand Chaturvedi [Thu, 24 Aug 2017 04:10:17 +0000 (00:10 -0400)]
Added New Junit Cases for APPC Design Services
Issue-ID: APPC-168
Change-Id: Ib321bb77af3cb47abfce80d96f50a6b75b34b34e
Signed-off-by: Anand Chaturvedi <ac204h@att.com>
Skip Wonnell [Wed, 23 Aug 2017 20:32:22 +0000 (15:32 -0500)]
Remove license plugin and files
Change-Id: I5b7a1bf89bdecf480aa6e2defed497915c77e643
Issue-ID: APPC-96
Signed-off-by: Skip Wonnell <kw5258@att.com>
Skip Wonnell [Tue, 22 Aug 2017 18:27:43 +0000 (13:27 -0500)]
Add testing dependencies to dgraph pom
Insert missing junit, mockito, and powermock dependencies in pom.
Change-Id: I74d19f9ec49edddf6f7c3a1608ee69dd698850a1
Issue-ID: APPC-165
Signed-off-by: Skip Wonnell <kw5258@att.com>
Hao Kuang [Tue, 22 Aug 2017 19:13:01 +0000 (19:13 +0000)]
Fix appc-command-exectuor bundle fails to start
Fix that appc-command-executor-core bundle fails to load in karaf
Issue-Id: APPC-163
Change-Id: Ib3099a34e60ca59e7790ffe04f8a02869d995559
Signed-off-by: Hao Kuang <Hao.Kuang@amdocs.com>
mojahidi [Mon, 14 Aug 2017 07:20:45 +0000 (12:50 +0530)]
Rename action Block/UnBlock and Update Orch
StopApplication : Renamed block traffic action to StopApplication.
Transition of status in AAI will be stopping on accepting request
followed by Stopped for Success and Error for error scenario’s
StartApplicaiton: Renamed unblock traffic action to StartApplication.
Transition of status in AAI will be starting on accepting request
followed by Running for Success and Error for error scenario’s.
Refactored to handle actions on basis of ReadOnly,OrchestrationStatus,
BuiltIn and OperationalStatus instead of individual actions.
Change-Id: Ia7c6b233ac9a0aabeb9a1f7d715629917f6b7b86
Issue-ID:APPC-55
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
Skip Wonnell [Sat, 19 Aug 2017 21:07:45 +0000 (16:07 -0500)]
Update license configuration to exclude Json files
Fix the wildcard in the exclusion of files
during the process-sources phase.
Change-Id: If4b579ddd288655236e6d5cee14309a9d66acced
Issue-ID: APPC-161
Signed-off-by: Skip Wonnell <kw5258@att.com>
Marcus G K Williams [Fri, 18 Aug 2017 22:03:51 +0000 (15:03 -0700)]
Set sonar plugin version to 3.2
Sonar plugin errors when using
newest version of plugin specificied
by oparent pom.xml.
Issue-Id: APPC-156
Change-Id: Iad830be0fc8ecac6bb1a515512f5c32a6f899996
Signed-off-by: Marcus G K Williams <marcus.williams@intel.com>
Hao Kuang [Fri, 18 Aug 2017 16:07:56 +0000 (16:07 +0000)]
Fix ExecutionQueue cannot be cleaned
Fix that LCM Requests in Execution Queue continue after Stop OAM
request sent.
Fix that Appc-Ansible bundle cannot be fully stopped because
of NPE.
Issue-Id: APPC-159
Change-Id: I8f0a3a79a5c572ad84e66f71b4ddb47118704302
Signed-off-by: Hao Kuang <Hao.Kuang@amdocs.com>
Kalpesh Chaniyara [Tue, 15 Aug 2017 18:10:34 +0000 (23:40 +0530)]
Initial commit for Sequence Generator
Added sequence generator for start and stop
action with dependency model
Removed java check style from json files
from license maven plugin
JIRA Issues : APPC-33,APPC-106
Issue-Id : APPC-106
Change-Id: I7f12d39b705d77d559790a10b914b8108f5faa5e
Signed-off-by: Kalpesh Chaniyara <kalpeshkumar.chaniyara@amdocs.com>
Skip Wonnell [Thu, 17 Aug 2017 16:53:24 +0000 (11:53 -0500)]
Fix sonar blocker in DefaultConfiguration
Update the equals() method with checks for
null and for class equality.
Issue-ID: APPC-156
Change-Id: I7ee2ded5d18be560ee1d7bc63b936f22602ca0b4
Signed-off-by: Skip Wonnell <kw5258@att.com>
Skip Wonnell [Wed, 16 Aug 2017 02:18:04 +0000 (21:18 -0500)]
Initial add of appc-directed-graph bundles
Directed Graph library
Additional JIRA Issues: APPC-66, APPC-71, APPC-74
Issue-ID: APPC-65
Change-Id: I1bd643f7675dec19e562e99db65bafa0dcda6ef4
Signed-off-by: Skip Wonnell <kw5258@att.com>
Skip Wonnell [Mon, 14 Aug 2017 22:47:10 +0000 (17:47 -0500)]
Initial adds artifact handler and design services
asdc-artifact-handler: an interface to receive artifacts distributed
by SDC and persist them into the local database.
appc-design-services: an interface to manage VNF configuration
artifacts, primarily those generated by the configuration design tool.
Includes these user stories: APPC-28/85
Change-Id: Ib207070d4593554fa424fc69d9c77a6cd5349fec
Signed-off-by: Skip Wonnell <kw5258@att.com>
Issue-Id: APPC-9
Skip Wonnell [Wed, 16 Aug 2017 00:57:50 +0000 (19:57 -0500)]
Initial commit for appc-config-audit bundle
This Bundle is used for Auditing against
a running configurition
Signed-off-by: Skip Wonnell <kw5258@att.com>
Issue-Id: APPC-22
Signed-off-by: Patrick Brady <pb071s@att.com>
Change-Id: Id19c65e351cc377d32d6533d3fa73415019652f0
Skip Wonnell [Wed, 16 Aug 2017 01:42:44 +0000 (20:42 -0500)]
Initial commit for appc-config-adaptor
This bundle contains utilities used by config-generator.
Change-Id: I04877ebe90536fd57368d00c033189c280e77c90
Signed-off-by: Skip Wonnell <kw5258@att.com>
Issue-ID: APPC-67
Skip Wonnell [Tue, 15 Aug 2017 23:07:13 +0000 (18:07 -0500)]
Initial commit for config-generator bundle
This bundle contains logic for creating the configuration,
reading templates, and merging the data together
Issue-ID: APPC-59
Change-Id: Ifd745964f659f075250d6acaf1b5f033da28e1c4
Signed-off-by: Skip Wonnell <kw5258@att.com>
Skip Wonnell [Tue, 15 Aug 2017 22:26:38 +0000 (17:26 -0500)]
Initial commit for appc-flow-controller bundle
This bundle contains the APPC orchestration control
for the directed graph for model driven transactions
Issue-ID: APPC-73
Change-Id: Ia812fe14b2d6aa46c3acd5b2bfab0c004507c628
Signed-off-by: Skip Wonnell <kw5258@att.com>
Skip Wonnell [Tue, 15 Aug 2017 22:05:27 +0000 (17:05 -0500)]
Initial commit for appc-data-services bundle
This bundle contains the generic execute nodes that
interact with the database.
Issue-ID: APPC-58
Change-Id: Ib1447443ed259f4133cd33d554a5ac43f2c3dd1b
Signed-off-by: Skip Wonnell <kw5258@att.com>
Marcus G K Williams [Wed, 16 Aug 2017 17:05:43 +0000 (10:05 -0700)]
Fix APPC sonar coverage
Issue-Id: APPC-156
Change-Id: Idccbf97538d05d173ebe74cef1442392c6a91486
Signed-off-by: Marcus G K Williams <marcus.williams@intel.com>
beili.zhou [Wed, 16 Aug 2017 18:16:50 +0000 (14:16 -0400)]
[APPC-144] OAM operation abort messages
Provide abort audit log as well as notification when OAM operation is
interrupted by a new OAM operation request.
Fix missing ID in audit log for reject message.
Issue-Id: APPC-144
Change-Id: Ie87e19949be85c085444c753fdf061f4fc45e48f
Signed-off-by: beili.zhou <beili.zhou@amdocs.com>
Skip Wonnell [Tue, 15 Aug 2017 17:43:03 +0000 (12:43 -0500)]
Initial commit for appc-encryption-tool bundle
appc-encryption-tool: module to retrieve and store
encryped credentials
Change-Id: I3d45c662c9d58dbeec2ab7fffb51658c9ee0d5d3
Signed-off-by: Skip Wonnell <kw5258@att.com>
Issue-Id: APPC-67
Masal, Sushil (sm588m) [Sun, 13 Aug 2017 13:40:02 +0000 (19:10 +0530)]
Create and store Dependency model from Tosca
Updated asdc listerner bundle to create dependency model from tosca
artifact reveived from SDC.This dependency model will be in JSON
format and will be stored to ASDC_ARTIFACT table as new artifact.
Also ASDC_REFERENCE table will be updated to with new artifact
details.
This commit also include bug fix for MDSALStore to handle all http
code for successful rest calls
Issue ID: APPC-32
Change-Id: Iaef6cdee67475917968a4bcdec131cd1bc4c4f41
Signed-off-by: Masal, Sushil (sm588m) <sushil.masal@amdocs.com>
Marcus Williams [Wed, 16 Aug 2017 00:54:38 +0000 (00:54 +0000)]
Merge "Action-Identifier to support vf-module-id"
Marcus Williams [Tue, 15 Aug 2017 19:53:35 +0000 (19:53 +0000)]
Merge "[APPC-127] NPE on execution of LCM action Lock"
beili.zhou [Tue, 15 Aug 2017 18:39:58 +0000 (14:39 -0400)]
[APPC-143] OAM restart operation with stop error
Fix OAM restart operation does not report stop failure. And also remove
unused LCM OperationStatus and related comments.
Issue-Id: APPC-143
Change-Id: Ia2580717ef515856725e3e50c63b17404f123325
Signed-off-by: beili.zhou <beili.zhou@amdocs.com>
Anand Chaturvedi [Tue, 15 Aug 2017 00:10:36 +0000 (20:10 -0400)]
Added review comment
Initial commit for Network-Inv and AAI client
commit
61419e46211f1f1e763d4a84214c62a5e699bdf2
Author: Anand Chaturvedi <ac204h@att.com>
Date: Mon Aug 14 19:54:11 2017 -0400
Issue-Id: APPC-21
[OnapMigration] OnapMigration for APPC OutBound Services..
Change-Id: I7db4bcb52b050988b601f3abac544c43f34c677b
Signed-off-by: Anand Chaturvedi <ac204h@att.com>
Kalpesh Chaniyara [Tue, 15 Aug 2017 09:15:00 +0000 (14:45 +0530)]
Action-Identifier to support vf-module-id
As of now LCM Request Identifier supports
vnf-id, vnfc-name and vserver-id. This change
supports vf-module-id as action identifier
and its value is set in DG context with key
input.action-identifiers.vf-module-id when
invoking DG
Issue-Id : APPC-142
Change-Id: I65d44b073d32e39eaba183b8ce47584441921f3c
Signed-off-by: Kalpesh Chaniyara <kalpeshkumar.chaniyara@amdocs.com>
Kalpesh Chaniyara [Tue, 15 Aug 2017 05:14:15 +0000 (10:44 +0530)]
[APPC-127] NPE on execution of LCM action Lock
2 Constants classes were present under
same package in appc-dispatcher sub modules,
Moved one class under appc-request-handler-core
to different package
Issue-Id :APPC-127
Change-Id: I9bb9000b90862d245c2c8465495690a2635a741d
Signed-off-by: Kalpesh Chaniyara <kalpeshkumar.chaniyara@amdocs.com>
Anand Chaturvedi [Sat, 12 Aug 2017 05:31:10 +0000 (01:31 -0400)]
Initial commit for appc-config-params
Change-Id: I5805591892184b4456dd30639417d783d353a6a3
Signed-off-by: Anand Chaturvedi <ac204h@att.com>
Issue-Id:APPC-9
Skip Wonnell [Sun, 13 Aug 2017 20:19:32 +0000 (15:19 -0500)]
Update license plugin to exclude json files
Change-Id: I843185af796729c71ccc9aa822844436d4804c3f
Signed-off-by: Skip Wonnell <kw5258@att.com>
Issue-ID: APPC-87
beili.zhou [Sat, 12 Aug 2017 02:55:57 +0000 (22:55 -0400)]
OAM operations 3 - JUnit tests
OAM operations changes are large, need to be broken down to multiple
submission based on size and compilability. This is the third (last) set
which covers JUnit test cases.
Includes these user stories: APPC-39/41/43/44/45/46/52/77.
Issue Id: APPC-38
Change-Id: I2df5e6b371d05030fb18bdd48155e4bb23034997
Signed-off-by: beili.zhou <beili.zhou@amdocs.com>
beili.zhou [Sat, 12 Aug 2017 02:16:05 +0000 (22:16 -0400)]
OAM operations 2 - oam
OAM operations changes are large, need to break down to multiple
submissions based on size and compilability. This is the second set which
covers the following OAM operations: start, stop, restart,
maintenance-mode, and timeout of the operation along with error OAM
state.
Includes these user stories: APPC-39/41/43/44/45/46/52/77.
Issue Id: APPC-38
Change-Id: Iafad643c5ba2d2af24482b03db8f7a40397fa46e
Signed-off-by: beili.zhou <beili.zhou@amdocs.com>