Patrick Brady [Wed, 17 Jul 2019 22:02:37 +0000 (15:02 -0700)]
Replace Lists with new ArrayList
The Lists.newArrayList method is not being used here in a
way that provides significant benefit over new ArrayList
and Lists was causing a class not found exception.
Change-Id: I61bbfc5e55cb283c10f3681a7e336ae346347d03
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1613
Patrick Brady [Wed, 17 Jul 2019 20:22:35 +0000 (13:22 -0700)]
Fixes for parameterized sql queries
The old non-parameterized queries would treat null entries in the SvcLogicContext
as "null" string values. The parameterized query treats these as NULL sql values.
This change keeps those values as "null" strings.
Change-Id: Iee7f7a1861bdd82dc65d59db2be7862b49cf1207
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1639
Sudarshan Kumar [Thu, 11 Jul 2019 12:54:46 +0000 (18:24 +0530)]
Sonar Fix - Removed unnecessary cast to Date
Sonar Fix - Removed unnecessary cast to Date
Issue-ID: APPC-1629
Change-Id: Ie37c511ac63abd71708700b376a836e4ed03e92f
Signed-off-by: Sudarshan Kumar <sudars19@in.ibm.com>
Sudarshan Kumar [Fri, 12 Jul 2019 10:50:50 +0000 (16:20 +0530)]
Sonar Fix - Removed unused Variable Utils.java
Sonar Fix - Removed unused Variable Utils.java
Issue-ID: APPC-1629
Change-Id: I557c065ff835834f5eed5eb80bd7136e182217f5
Signed-off-by: Sudarshan Kumar <sudars19@in.ibm.com>
Sudarshan Kumar [Fri, 5 Jul 2019 10:37:36 +0000 (16:07 +0530)]
Sonar Fix - String comparison
Sonar Fix - String comparison
Issue-ID: APPC-1629
Change-Id: I8ea38dfaf629c2be624552a1cf0b0f0e877117cb
Signed-off-by: Sudarshan Kumar <sudars19@in.ibm.com>
Sudarshan Kumar [Fri, 5 Jul 2019 13:08:38 +0000 (18:38 +0530)]
Sonar Fix - String Comparison
Sonar Fix - String Comparison
Issue-ID: APPC-1629
Change-Id: Ia13da99f101d479aba7009ba4dffc201aa9a3ffe
Signed-off-by: Sudarshan Kumar <sudars19@in.ibm.com>
jegadeeshbabu1 [Tue, 9 Jul 2019 06:08:14 +0000 (11:38 +0530)]
Marked field transient
Handled non-serializable fields
Issue-ID: APPC-1637
Change-Id: I3398620e396c3f8bc1504eca8d312bc35d3bbbfd
Signed-off-by: jegadeeshbabu1 <jegabab1@in.ibm.com>
jegadeeshbabu1 [Thu, 4 Jul 2019 16:12:37 +0000 (21:42 +0530)]
Adhered serializable class contracts
Marked member transient
Issue-ID: APPC-1634
Change-Id: I7bbbf941e692c2755122f3d40a7ca79c59f21749
Signed-off-by: jegadeeshbabu1 <jegabab1@in.ibm.com>
jegadeeshbabu1 [Sun, 7 Jul 2019 16:49:24 +0000 (22:19 +0530)]
Updated to be an instance variable
Removed static keyword
Issue-ID: APPC-1636
Change-Id: I507d306f50acc010db4d944a078b4d15f5c719a4
Signed-off-by: jegadeeshbabu1 <jegabab1@in.ibm.com>
Sudarshan Kumar [Tue, 9 Jul 2019 11:21:26 +0000 (16:51 +0530)]
Sonar Fix- Removed Unused private field
Sonar Fix- Removed Unused private field
Issue-ID: APPC-1629
Change-Id: Iaab259140e29200473147097c552f75783e5cd0d
Signed-off-by: Sudarshan Kumar <sudars19@in.ibm.com>
Lathish [Wed, 19 Jun 2019 15:48:09 +0000 (15:48 +0000)]
Fixed netconf-xml parsing issue
Issue-ID: APPC-1624
Change-Id: I12aa5f1a42d5e09b5eb8886132ea9e5a2c84ef5e
Signed-off-by: Lathish <lathishbabu.ganesan@est.tech>
Patrick Brady [Wed, 19 Jun 2019 19:35:08 +0000 (12:35 -0700)]
Parameterized queries
Convert all database queries to use java sql
parameterized queries to reduce risk of sql
injection attack.
Change-Id: I15876ce3a2f2e2dfbd6578f5141367deed75d097
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: OJSI-25
Taka Cho [Wed, 19 Jun 2019 18:29:33 +0000 (14:29 -0400)]
update appc release note
fix appc cluster issue
release new appc docker
Issue-ID: APPC-1293
Change-Id: Id4897669e29f3c7c156a3c4c945825758c268a51
Signed-off-by: Taka Cho <takamune.cho@att.com>
Lathish [Tue, 18 Jun 2019 10:16:16 +0000 (10:16 +0000)]
Added cvaas file name in Audit and Sync
Issue-ID: APPC-1590
Change-Id: I09345570fe6cd158102844070e62df7fb1a7aed9
Signed-off-by: Lathish <lathishbabu.ganesan@est.tech>
Taka Cho [Fri, 14 Jun 2019 18:42:56 +0000 (14:42 -0400)]
fix document error
missing underline
Issue-ID: APPC-1595
Change-Id: Ia1eb87c5f34c43c56e037e9bf925857ecbb9d758
Signed-off-by: Taka Cho <takamune.cho@att.com>
Taka Cho [Thu, 6 Jun 2019 13:52:30 +0000 (09:52 -0400)]
update dublin release note
remove known-issue
APPC-1613
Issue-ID: APPC-1293
Change-Id: Ibacdb95bdc94bee2449596948055bbff3bd51e9e
Signed-off-by: Taka Cho <takamune.cho@att.com>
Lathish [Mon, 10 Jun 2019 13:43:55 +0000 (13:43 +0000)]
Fixed incorrect error message
Issue-ID: APPC-1623
Change-Id: Ib6c58be5e5ddb41c39788208238234335f72e7ea
Signed-off-by: Lathish <lathishbabu.ganesan@est.tech>
Krzysztof Opasiak [Wed, 5 Jun 2019 21:33:16 +0000 (23:33 +0200)]
Document OJSI-185 vulnerability
Issue-ID: OJSI-185
Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com>
Change-Id: I6cbe6a6cb0129bd4ac6ccba35cf018f4a04f80e5
Krzysztof Opasiak [Wed, 5 Jun 2019 21:32:50 +0000 (23:32 +0200)]
Document OJSI-113 vulnerability
Issue-ID: OJSI-113
Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com>
Change-Id: I9d0c35e01dd4f2b42bd115455863ca2d0b8dc3c7
Krzysztof Opasiak [Wed, 5 Jun 2019 21:32:21 +0000 (23:32 +0200)]
Document OJSI-112 vulnerability
Issue-ID: OJSI-112
Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com>
Change-Id: Id28f332ddcdd5c69f5a82758d05c10d19606faff
Krzysztof Opasiak [Wed, 5 Jun 2019 21:31:54 +0000 (23:31 +0200)]
Document OJSI-95 vulnerability
Issue-ID: OJSI-95
Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com>
Change-Id: Ica05a626601673f672cc0be6a8c6cdcbe94323f8
Krzysztof Opasiak [Wed, 5 Jun 2019 21:30:42 +0000 (23:30 +0200)]
Document OJSI-63 (CVE-2019-12124) vulnerability
Issue-ID: OJSI-63
Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com>
Change-Id: Ide989877e0f2765302ad423c0b421e972b4e8046
Krzysztof Opasiak [Wed, 5 Jun 2019 21:30:08 +0000 (23:30 +0200)]
Document OJSI-29 vulnerability
Issue-ID: OJSI-29
Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com>
Change-Id: Ib8f54aa42fc78198c8b0043b2aa79580a5950672
Krzysztof Opasiak [Wed, 5 Jun 2019 21:29:16 +0000 (23:29 +0200)]
Document OJSI-25 (CVE-2019-12316) vulnerability
Issue-ID: OJSI-25
Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com>
Change-Id: Ia880184484aadea9147fcac301c87063a00f92ab
Krzysztof Opasiak [Wed, 5 Jun 2019 21:28:26 +0000 (23:28 +0200)]
Document fixed OJSI-104 vulnerability
Issue-ID: OJSI-104
Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com>
Change-Id: I42365c3038eb38f170b1543d9f78d68b2e5c9de4
Krzysztof Opasiak [Wed, 5 Jun 2019 21:27:39 +0000 (23:27 +0200)]
Document fixed OJSI-146 vulnerability
Issue-ID: OJSI-146
Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com>
Change-Id: I9e02cc26f7cfa9c11941b4ce4aef5de561f4b764
Krzysztof Opasiak [Wed, 5 Jun 2019 21:11:16 +0000 (23:11 +0200)]
Improve security release notes
In order to provide users with more details of project's state in
terms of security let's divide the security release notes into three
sections:
- Fixed Security Issues
Contains a list of security fixes merged during this
release (especially those reported via OJSI tickets).
- Known Security Issues
Contains a list of vulnerabilities detected in project during
release which have not been fixed yet and thus should be mitigated
by the user.
- Known Vulnerabilities in Used Modules
Contains information about NexusIQ scan results
Issue-ID: SECCOM-238
Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com>
Change-Id: I9fee2338091ed5a879e0989d13501008d7d6013f
Patrick Brady [Wed, 5 Jun 2019 18:15:13 +0000 (11:15 -0700)]
Fix for jackson annotation
Fasterxml jackson annotations was not available during runtime
and was causing json property annotations to be ignored and
json was not parsing.
Change-Id: I1cb48e6fc54fc39d24bde1683cb141f1f64c9906
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1613
Lukasz Rajewski [Wed, 5 Jun 2019 14:04:41 +0000 (16:04 +0200)]
Fix for documentation of DistributeTrafficCheck
Change-Id: I260ef22fb00755e6818868fdadd35bcd88162ffd
Signed-off-by: Lukasz Rajewski <lukasz.rajewski@orange.com>
Issue-ID: APPC-1447
Lukasz Rajewski [Mon, 3 Jun 2019 13:21:29 +0000 (15:21 +0200)]
Documentation for DistributeTraffic LCMs
Documentation for Distribute Traffic and
Distribute Traffic Check LCMs
Change-Id: I8dc6ec3110c711857d8788f01edfcca87a887317
Signed-off-by: Lukasz Rajewski <lukasz.rajewski@orange.com>
Issue-ID: APPC-1447
(cherry picked from commit
284d93a4770224956138eec224479fef9d356fff)
Taka Cho [Fri, 31 May 2019 19:36:43 +0000 (15:36 -0400)]
APPC release note update
Updated Dublin release note
Issue-ID: APPC-1293
Change-Id: I86ebb4365aed65b90e13a46e8e691f39382ecfd4
Signed-off-by: Taka Cho <takamune.cho@att.com>
Patrick Brady [Tue, 4 Jun 2019 05:13:50 +0000 (22:13 -0700)]
Fix for null dmaap return status
The setResponse method was returning before actually
setting the status values in cases where the status
field was not first initialized. This behavior did
not make sense since the status field would never be
initialized in cases where the OutgoingMessage was
generated using the IncomingMessage.toOutgoing().
Change-Id: Ib399daf3644095a2eeffe718d0f6a27473b01ee9
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1619
Lukasz Rajewski [Mon, 27 May 2019 06:03:27 +0000 (08:03 +0200)]
InventoryNames in ansible adapter fixed
This change fixes support for InventoryNames parameter
in LCM request going to Ansible server. Also ansible
adapter DG has been modified to consider new parameter
added
Change-Id: I68aa8efa34b79ef2f669d81563510fea7bb0a730
Signed-off-by: Lukasz Rajewski <lukasz.rajewski@orange.com>
Issue-ID: APPC-1612
(cherry picked from commit
7155b808084ff6e49f6eef01ac7defd9a7754a3a)
Taka Cho [Wed, 22 May 2019 13:33:56 +0000 (09:33 -0400)]
fix CDT doc image reference
rename to image41
Issue-ID: APPC-1295
Change-Id: Iee331769a9a0e46e87631c14849142033b855e34
Signed-off-by: Taka Cho <takamune.cho@att.com>
Lukasz Rajewski [Wed, 22 May 2019 14:00:08 +0000 (16:00 +0200)]
Fix for support of InventoryNames
This change addes support for InventoryNames parameter
in LCM request going to Ansible server
Change-Id: I9aea0b5407460d5dc0b2691e73ba795f8fe2af15
Signed-off-by: Lukasz Rajewski <lukasz.rajewski@orange.com>
Issue-ID: APPC-1612
Patrick Brady [Tue, 21 May 2019 17:29:49 +0000 (10:29 -0700)]
Fix escapeInternalJson method
The method incorrectly handled cases where the json string contained
json objects internally. These cases should be handled correctly now.
Change-Id: I43b40414526bcb6577242ab737097dfb9119e618
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1576
Taka Cho [Tue, 21 May 2019 17:57:21 +0000 (13:57 -0400)]
update APPC CDT GUI guide
added Admin tab user
guide
Issue-ID: APPC-1295
Change-Id: I21c7d3163796f405f809fb6c8a47537b736b1277
Signed-off-by: Taka Cho <takamune.cho@att.com>
Taka Cho [Sun, 19 May 2019 21:15:27 +0000 (17:15 -0400)]
resolve base64 class not found
add commons-codec in embedded-dependency
in event listener pom file
Issue-ID: APPC-1604
Change-Id: I7006ed41d412b1dcf21dd64987a84d1ad04c9093
Signed-off-by: Taka Cho <takamune.cho@att.com>
Patrick Brady [Tue, 21 May 2019 06:12:51 +0000 (23:12 -0700)]
Update parent version
Update the parent version to match the new 2.*
parent versioning.
Change-Id: I77280d8cf12de1de20c01249491dc85243f5d655
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1601
Patrick Brady [Mon, 13 May 2019 23:16:58 +0000 (16:16 -0700)]
Update message format for vFirewall
The message format coming from policy has changed. This is the
corresponding update for appc to match the message format.
Change-Id: I8827e6c372be77dc69c0ee3579a002fde2515848
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1603
Patrick Brady [Fri, 10 May 2019 22:14:06 +0000 (15:14 -0700)]
Add ConfigModify to if statement
Requests from cdt with the action set to ConfigModify
did not have entries added to the device interface
protocol table. With this change the entry will be
made in the table.
Change-Id: I29835554a0ebf2fea29f1c8745b99ac1813c0d7d
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1593
Patrick Brady [Wed, 8 May 2019 22:14:49 +0000 (15:14 -0700)]
Change rest healthcheck to use appc parent poms
Change appc-rest-healthcheck over to the new style
of features using the org.onap.appc.parent pom files
as parents.
Change-Id: I781754f3ad5c31a937d17449ff46320d60db4975
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1586
Patrick Brady [Thu, 2 May 2019 23:41:24 +0000 (16:41 -0700)]
Add method to escape json strings
All backslash escape characters are being stripped out of strings.
They need to be added back to strings containing json data.
Change-Id: Ic8d9ba95da904b96f65598752133971f8c324694
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1576
Patrick Brady [Tue, 30 Apr 2019 20:08:25 +0000 (13:08 -0700)]
Fix for extra json quotes
Substring method output was being lost, causing extra
quotes to stay in the String.
Change-Id: I35e9eee60756b7b743386600e3ab1d203cca036a
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1576
Lathish [Tue, 30 Apr 2019 14:00:16 +0000 (14:00 +0000)]
Fixed publish config issue
Issue-ID: APPC-1588
Change-Id: I63e75c415d7f33c750eaad6799234e03741ad290
Signed-off-by: Lathish <lathishbabu.ganesan@est.tech>
Lathish [Tue, 30 Apr 2019 16:09:56 +0000 (16:09 +0000)]
Fixed public config issue in Audit
Issue-ID: APPC-1587
Change-Id: I7caa7fbf85f8a49beb5fc957c9372445f0d5e7ef
Signed-off-by: Lathish <lathishbabu.ganesan@est.tech>
Patrick Brady [Fri, 26 Apr 2019 19:36:25 +0000 (12:36 -0700)]
Increment snapshot version
Change from 1.5.0-SNAPSHOT to 1.6.0-SNAPSHOT to prepare
for next development cycle.
Change-Id: I187785ab4b11a37815289d20ba802c48e86cee7f
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1585
Lathish [Fri, 26 Apr 2019 14:19:46 +0000 (14:19 +0000)]
Fixed the package name in Audit DG
Issue-ID: APPC-1584
Change-Id: I07a2b18b66c6e446324b37b5112e1839c197e538
Signed-off-by: Lathish <lathishbabu.ganesan@est.tech>
Taka Cho [Thu, 25 Apr 2019 01:21:46 +0000 (21:21 -0400)]
remove commons-codec hardcoded
remove 1.9 version
commons-codec
Change-Id: I8ea5ca9c017b2d2b8917e38e2666996c5227d40b
Issue-ID: APPC-1579
Signed-off-by: Taka Cho <takamune.cho@att.com>
Patrick Brady [Mon, 22 Apr 2019 20:12:14 +0000 (13:12 -0700)]
Escape quotes in json strings
The JSONObject parser strips all text of backslash escape characters, even if it is
treaing the object as a string and not a series of json keys. If a string contains a
json object within it, the removal of these escape characters causes problems. Adding
the JSONObject.quote method on all strings to automatically add escape characters to
any strings which contain characters requiring escapes.
Change-Id: Ifac68844dd132971ba35803f1b9c03a5372bd500
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1576
Lukasz Rajewski [Tue, 16 Apr 2019 09:20:38 +0000 (11:20 +0200)]
Fixed issue with FileParameters support
Generic_AnsibleDG has missing support for FileParameters
payload parameter. It is added with this fix.
Change-Id: I71570c87a6a24934f4f975afd5f36eebced4d3e8
Issue-ID: APPC-1574
Signed-off-by: Lukasz Rajewski <lukasz.rajewski@orange.com>
Sandeep J [Thu, 11 Apr 2019 07:37:14 +0000 (13:07 +0530)]
added test cases to MetricRegistryImpl.java
to increase code coverage
Issue-ID: APPC-1086
Change-Id: I8804c14c88fe0857be7106edd621ee74f4dd1243
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
Sandeep J [Thu, 11 Apr 2019 08:04:41 +0000 (13:34 +0530)]
added file to test DispatchingFuntionMetricImpl
to increase code coverage
Issue-ID: APPC-1086
Change-Id: I179c0d74f9ed14a34a02bb9eb0f31c51ca3f415c
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
Sandeep J [Thu, 11 Apr 2019 07:57:37 +0000 (13:27 +0530)]
added file to test DispatchingFunctionMetric.java
to increase code coverage
Issue-ID: APPC-1086
Change-Id: Id99ba5312e98987aea8d38040f6d8ce23264523a
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
Sandeep J [Thu, 11 Apr 2019 07:48:01 +0000 (13:18 +0530)]
added file to test DefaultPrimitiveCounter.java
to increase code coverage
Issue-ID: APPC-1086
Change-Id: I9af062fee4122acb0a87dbc9f0bd1cd3b5198e62
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
Sandeep J [Mon, 8 Apr 2019 15:07:02 +0000 (20:37 +0530)]
added test case to TestRestartServer.java
to increase code coverage
Issue-ID: APPC-1086
Change-Id: Id64f507cb3cb4102c79dfb5c454785ac2814cec5
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
Sandeep J [Tue, 9 Apr 2019 07:52:46 +0000 (13:22 +0530)]
added file to test ActionIdentifier.java
to increase code coverage
Issue-ID: APPC-1086
Change-Id: Iba0884ae878488575cda665ed15cca5b301b6b03
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
Sandeep J [Wed, 10 Apr 2019 07:43:17 +0000 (13:13 +0530)]
added file to test ScopOverlap.jav
to increase code coverage
Issue-ID: APPC-1086
Change-Id: I21695f6515653e79a7bc09a462ce181aa617105b
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
Sandeep J [Wed, 10 Apr 2019 07:37:26 +0000 (13:07 +0530)]
added file to test Request.java
to increase code coverage
Issue-ID: APPC-1086
Change-Id: I0afa6d99ba65243bfbae419d075800ecc45aafb6
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
Joss Armstrong [Thu, 21 Feb 2019 15:19:07 +0000 (15:19 +0000)]
Fix for Ansible Healthcheck bug
Update to directed graph and merge JSON template code
Issue-ID: APPC-1472
Change-Id: I4332ad74d34f455261b1c001339d0542be4514fc
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
Sandeep J [Mon, 8 Apr 2019 09:27:24 +0000 (14:57 +0530)]
added test case to TestConnectionBuilder.java
to increase code coverage
Issue-ID: APPC-1086
Change-Id: Ie7d84cc28ebd112c2ce224cd6c544939ef376ed1
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
Sandeep J [Tue, 9 Apr 2019 07:43:39 +0000 (13:13 +0530)]
removed sonar vulnerabilities in ServiceExecutor
to increase code coverage
Issue-ID: APPC-1567
Change-Id: Iada27e5e4d40d090275d35dfb3e586fe019cb207
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
Jegadeesh Babu [Sun, 7 Apr 2019 15:47:53 +0000 (21:17 +0530)]
Removed unused imports
Sonar fix
Issue-ID: APPC-1567
Change-Id: Iec6ce8b197e958e69e108708c056f00cca3b9c66
Signed-off-by: Jegadeesh Babu <jegabab1@in.ibm.com>
Sandeep J [Wed, 3 Apr 2019 19:12:33 +0000 (00:42 +0530)]
added test case to DmaapOutgoingMessageTest
to increase code coverage
Issue-ID: APPC-1086
Change-Id: Ia441f83ad6602a89d81e5c66b0120a6c857672c4
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
Sandeep J [Wed, 3 Apr 2019 19:22:41 +0000 (00:52 +0530)]
added test cases to DBServiceTest.java
to increase code coverage
Issue-ID: APPC-1086
Change-Id: I149ad0ee6354822fcb9712fe12ad22885b65cf8e
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
Sandeep J [Thu, 4 Apr 2019 09:59:50 +0000 (15:29 +0530)]
added test case to TestController.java
to increase code coverage
Issue-ID: APPC-1086
Change-Id: Id6718c61982a477373c8a5af76f7c7d6a61c43c1
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
Sandeep J [Thu, 4 Apr 2019 10:07:27 +0000 (15:37 +0530)]
added test case to InputBodyTest.java
to increase code coverage
Issue-ID: APPC-1086
Change-Id: I3406fedf206902eba8374dbc47852bc28bfdeccf
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
Driptaroop Das [Mon, 1 Apr 2019 17:27:27 +0000 (22:57 +0530)]
RequestContext.java - sonar fixes
RequestContext.java - sonar fixes
Issue-ID: APPC-1564
Change-Id: I334c1f07403cf246efb3413639fdb26cc08556af
Signed-off-by: Driptaroop Das <driptaroop.das@in.ibm.com>
Taka Cho [Mon, 1 Apr 2019 19:38:33 +0000 (15:38 -0400)]
ExecuteNodeActionImpl is not instatiate
Remove getVersionRelation
back to getVnfHierachy
Change-Id: Ia5c837bd6a75eb6397959f260a89cc5466ce3e42
Issue-ID: APPC-1542
Signed-off-by: Taka Cho <takamune.cho@att.com>
Sudarshan Kumar [Mon, 1 Apr 2019 18:29:39 +0000 (23:59 +0530)]
Addtional Test Cases added InventoryModel.java
Addtional Test Cases added InventoryModel.java
Issue-ID: APPC-1372
Change-Id: If131ad2d9a5a906b9741426d0c22399c98c3524a
Signed-off-by: Sudarshan Kumar <sudars19@in.ibm.com>
Sandeep J [Tue, 2 Apr 2019 08:35:13 +0000 (14:05 +0530)]
added file to test CommonMessage.java
to increase code coverage
Issue-ID: APPC-1086
Change-Id: I4cf3a640031a60a34c829ecb039325d6194fa682
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
Sandeep J [Tue, 2 Apr 2019 08:54:30 +0000 (14:24 +0530)]
added file to test IncomingMessage.java
to increase code coverage
Issue-ID: APPC-1086
Change-Id: Id73082a54060af0b9a4ce8f3bda05cde824bf481
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
Sandeep J [Wed, 27 Mar 2019 08:11:08 +0000 (13:41 +0530)]
added file to test DmaapOutgoingMessage.java
to increase code coverage
Issue-ID: APPC-1086
Change-Id: I81df38037a182db5135f8d6c7b462a42891f9d36
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
Jegadeesh Babu [Sun, 31 Mar 2019 07:05:47 +0000 (12:35 +0530)]
Used constants to avoid dup of literals
Sonar fix
Issue-ID: APPC-1562
Change-Id: Ic9d14b32f4deac975b46154a2ac8e4664ec11c52
Signed-off-by: Jegadeesh Babu <jegabab1@in.ibm.com>
Jegadeesh Babu [Sun, 31 Mar 2019 07:48:19 +0000 (13:18 +0530)]
Reordered the modifier as per java standard
Sonar fix
Issue-ID: APPC-1563
Change-Id: I9a4b82ca67b5c7f5184457b95c347089de728658
Signed-off-by: Jegadeesh Babu <jegabab1@in.ibm.com>
Sandeep J [Mon, 1 Apr 2019 07:55:58 +0000 (13:25 +0530)]
added test case to RequestModelTest.java
to increase code coverage
Issue-ID: APPC-1086
Change-Id: I56c2e94a888f0f01f0bed36fbc966dce0cb69b84
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
Sandeep J [Mon, 1 Apr 2019 08:01:24 +0000 (13:31 +0530)]
added test case to RequestDataTest.java
to increase code coverage
Issue-ID: APPC-1086
Change-Id: I646694445953c690fb4c8e336346deb3f5e3b4df
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
Taka Cho [Thu, 28 Mar 2019 19:06:50 +0000 (15:06 -0400)]
remove appc-test-dependency
there are two poms having
appc-test-dependency
Change-Id: I9e096601bf92c05ac6ff93ddd9d436c82a5ecb39
Issue-ID: APPC-1559
Signed-off-by: Taka Cho <takamune.cho@att.com>
Taka Cho [Wed, 27 Mar 2019 19:31:05 +0000 (15:31 -0400)]
remove cassandra-drive-core
remove cassandra-drive-core
from appc-yang-generator
Change-Id: Ied5ca0e393d22b5a4ee059dfe58904dd971df4f6
Issue-ID: APPC-1553
Signed-off-by: Taka Cho <takamune.cho@att.com>
Patrick Brady [Tue, 26 Mar 2019 19:12:24 +0000 (12:12 -0700)]
Remove test dependencies project
The test dependencies project is not used
Change-Id: I0a4f2440eede5a62421964b84f9502e00affcadf
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1559
Sandeep J [Thu, 28 Mar 2019 09:59:15 +0000 (15:29 +0530)]
added test case to DBServiceTest.java
to increase code coverage
Issue-ID: APPC-1086
Change-Id: I02b723e7f9aa83e2f7f51aa5a9c8883ac149299c
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
Sandeep J [Wed, 27 Mar 2019 08:20:06 +0000 (13:50 +0530)]
added file to test Input.java
to increase code coverage
Issue-ID: APPC-1086
Change-Id: I79d0fc71d512b440232ec31cb195c6728d11f5dc
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
Sandeep J [Thu, 28 Mar 2019 09:50:51 +0000 (15:20 +0530)]
added test cases to TestVServerInfo.java
to increase code coverage
Issue-ID: APPC-1086
Change-Id: Ib6fb537e576f928552763ec0e6d1abf2d556f00a
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
Sandeep J [Wed, 27 Mar 2019 08:30:46 +0000 (14:00 +0530)]
added file to test RequestData.java
to increase code coverage
Issue-ID: APPC-1086
Change-Id: If2270ea76a0a15ae7c6f5d1d580574937be186fd
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
Sandeep J [Thu, 28 Mar 2019 09:21:43 +0000 (14:51 +0530)]
added file to test RequestModel.java
to increase code coverage
Issue-ID: APPC-1086
Change-Id: If2270ea76a0a15ae7c6f5d1d580512456be198fd
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
Sandeep J [Thu, 28 Mar 2019 09:39:59 +0000 (15:09 +0530)]
added file to test ScopeOverlapModel.java
to increase code coverage
Issue-ID: APPC-1086
Change-Id: I293349c249082e176b211d0ffa8bee04cc7660b5
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
Driptaroop Das [Tue, 26 Mar 2019 20:04:20 +0000 (01:34 +0530)]
ConfigComponentAdaptor.java - Sonar Fixes
ConfigComponentAdaptor.java - Sonar Fixes
Issue-ID: APPC-1560
Change-Id: Ia22fc64e378ffb3a206eed256f0a9ab7365381cd
Signed-off-by: Driptaroop Das <driptaroop.das@in.ibm.com>
Jegadeesh Babu [Tue, 26 Mar 2019 08:01:39 +0000 (13:31 +0530)]
Used constants in the place of dup literals
Sonar fix
Issue-ID: APPC-1557
Change-Id: I4b52b9febabd0fae8aa098004aeba0ef9a085710
Signed-off-by: Jegadeesh Babu <jegabab1@in.ibm.com>
Jegadeesh Babu [Mon, 25 Mar 2019 16:42:52 +0000 (22:12 +0530)]
Used constants to replace duplicated literals
Sonar Fix
Issue-ID: APPC-1555
Change-Id: I3943003c7fa37aed95e138f03a3fe4b8f48b75ce
Signed-off-by: Jegadeesh Babu <jegabab1@in.ibm.com>
Taka Cho [Wed, 27 Mar 2019 19:45:24 +0000 (15:45 -0400)]
remove nexus-staging maven plugin
remove nexus-staging-maven-plugin
on the top of pom file
Change-Id: I50b22c2d1e8e3e663314f701a22de5471224c5b3
Issue-ID: APPC-1561
Signed-off-by: Taka Cho <takamune.cho@att.com>
Joss Armstrong [Mon, 25 Mar 2019 11:44:38 +0000 (11:44 +0000)]
Fix incorrect passing of SvcLogicContext value
EncyrptionToolDGWrapper changes for Multiple Ansible server
support not working when retrieving data from SvcLogicContext
used for querying DEVICE_AUTHENTICATION table.
Issue-ID: APPC-1545
Change-Id: I8f08910156d6e2b4ae6341c847bc773e4d15841e
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
Jegadeesh Babu [Tue, 26 Mar 2019 08:19:01 +0000 (13:49 +0530)]
Added constant to replace dup literals
Sonar fix
Issue-ID: APPC-1558
Change-Id: I98e36669f5d247a8fe8a9c38d6e5724e76284487
Signed-off-by: Jegadeesh Babu <jegabab1@in.ibm.com>
Sandeep J [Tue, 26 Mar 2019 08:11:32 +0000 (13:41 +0530)]
added test cases to ArtifactHandlerProviderTest
to increase code coverage
Issue-ID: APPC-1086
Change-Id: Ic03b32bc4c8b87a76db2e2aae45f7706f19e9bd4
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
Sandeep J [Tue, 26 Mar 2019 07:40:29 +0000 (13:10 +0530)]
added test cases to TestVServerInfo.java
to increase code coverage
Issue-ID: APPC-1086
Change-Id: I1141fa522e3c4943c2a51d9c585cdcaa0186b373
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
Sandeep J [Tue, 26 Mar 2019 08:18:52 +0000 (13:48 +0530)]
added test case to DBServiceTest.java
to increase code coverage
Issue-ID: APPC-1086
Change-Id: I202822e53c2086b5db41a8028410c07c46821d1d
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
Taka Cho [Thu, 21 Mar 2019 18:37:55 +0000 (14:37 -0400)]
remove cassandra-driver-core
In appc-config-param,
remove cassandra-driver-core
to avoid security vulnerability
for guava and netty-handler
Change-Id: I660ae35c4abbc9537e9f9bf5e18fd630e111ca93
Issue-ID: APPC-1553
Signed-off-by: Taka Cho <takamune.cho@att.com>
Jegadeesh Babu [Mon, 25 Mar 2019 16:23:43 +0000 (21:53 +0530)]
Created constant to replace dup String literal
Sonar fix
Issue-ID: APPC-1554
Change-Id: I8ff882baf26e765b9b8bcf23bcc37b11a3567ded
Signed-off-by: Jegadeesh Babu <jegabab1@in.ibm.com>
Patrick Brady [Fri, 22 Mar 2019 22:05:06 +0000 (15:05 -0700)]
Add back bundles
The newest ccsdk update removed some bundles that
were required by appc. This adds bundle entries to
bring up those bundles.
Change-Id: I5ff802ee4837d1a5a6bcaffcb0805e41d95d6918
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: CCSDK-1156
Jegadeesh Babu [Thu, 21 Mar 2019 16:48:49 +0000 (22:18 +0530)]
Potential Null pointer exception avoided
Sonar fix
Issue-ID: APPC-1552
Change-Id: I8f5e6386bd96a136f49ba651aed8fb209bed9435
Signed-off-by: Jegadeesh Babu <jegabab1@in.ibm.com>
Sandeep J [Fri, 22 Mar 2019 13:58:24 +0000 (19:28 +0530)]
added test case to TimeTest.java
to increase code coverage
Issue-ID: APPC-1086
Change-Id: I9ed0192a67d594691f45978d2166b0992a40c656
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>