cps.git
10 months agoMerge "Adjust performance test timings"
Toine Siebelink [Tue, 14 Nov 2023 15:51:39 +0000 (15:51 +0000)]
Merge "Adjust performance test timings"

10 months agoMerge "Fix PASS/FAIL reporting in performance test summary"
Lee Anjella Macabuhay [Tue, 14 Nov 2023 15:06:28 +0000 (15:06 +0000)]
Merge "Fix PASS/FAIL reporting in performance test summary"

10 months agoMerge "Add DMI trustlevel at registration"
Lee Anjella Macabuhay [Tue, 14 Nov 2023 10:47:42 +0000 (10:47 +0000)]
Merge "Add DMI trustlevel at registration"

10 months agoAdjust performance test timings 12/136512/1
danielhanrahan [Mon, 13 Nov 2023 18:17:21 +0000 (18:17 +0000)]
Adjust performance test timings

New limits for time and memory are based on analyzing 40 previous
performance job runs. Test limits are chosen so that individual
test cases would pass 95% of the the time.

Issue-ID: CPS-1884
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: Iadca27eb1f9482016759070e5afdc70c53f9d043

10 months agoFix PASS/FAIL reporting in performance test summary 11/136511/1
danielhanrahan [Mon, 13 Nov 2023 19:17:45 +0000 (19:17 +0000)]
Fix PASS/FAIL reporting in performance test summary

Performance test summary says PASS even if the memory limit
is exceeded. It currently only looks at time.

Issue-ID: CPS-1753
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: I6b9d5ae8e8f560459ba77cdb8fe8b889d0dc7a8a

10 months agoAdd DMI trustlevel at registration 20/136420/2
seanbeirne [Thu, 9 Nov 2023 11:00:47 +0000 (11:00 +0000)]
Add DMI trustlevel at registration

-Re-introduce trustLevelPerDmiPlugin to registration process

Issue-ID: CPS-1902
Signed-off-by: seanbeirne <sean.beirne@est.tech>
Change-Id: Ic3f154aca60c3e1244ff4fd9a4c4865964884b31

10 months agoUpdate Architecture rule to add cache package 31/136431/1
danielhanrahan [Fri, 10 Nov 2023 15:12:22 +0000 (15:12 +0000)]
Update Architecture rule to add cache package

- Modify test to allow org.onap.cps.cache package to access CPS classes
- Update archunit to avoid exceptions during build related to Java 17

Issue-ID: CPS-1958
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: If74dd897b8e41b83e41ea2a35e087ee56beb3088

10 months agoBump CPS to 3.4.1-SNAPSHOT 24/136424/1
mpriyank [Thu, 9 Nov 2023 14:11:26 +0000 (14:11 +0000)]
Bump CPS to 3.4.1-SNAPSHOT

- bumped CPS to 3.4.1-SNAPSHOT
- updated the release notes

Issue-ID: CPS-1962
Change-Id: Iee9fa03a1890ac5d4c1204d0851a255c5b897720
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
10 months agoAdd container yaml for CPS 23/136423/1
mpriyank [Thu, 9 Nov 2023 13:15:28 +0000 (13:15 +0000)]
Add container yaml for CPS

- added container yaml to release the docker images for CPS 3.4.0

Issue-ID: CPS-1962
Change-Id: I811c755fd508cd97e298b9b03a21f89b7ec05843
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
10 months agoAdd maven stage yaml for CPS 22/136422/1
mpriyank [Thu, 9 Nov 2023 12:56:40 +0000 (12:56 +0000)]
Add maven stage yaml for CPS

- maven stage yaml to release 3.4.0 CPS

Issue-ID: CPS-1962
Change-Id: I112a351d2e72af06e42cd4c1dafa2169220de523
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
10 months agoRelease notes update 21/136421/1
mpriyank [Thu, 9 Nov 2023 12:12:38 +0000 (12:12 +0000)]
Release notes update

- Added section for new delhi release now for the latest code

Issue-ID: CPS-1962
Change-Id: I43ebad1095831490ce6722dd535da31cfad24516
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
10 months agoMerge "Remove CPS-Temporal from RTD"
Lee Anjella Macabuhay [Thu, 9 Nov 2023 11:44:11 +0000 (11:44 +0000)]
Merge "Remove CPS-Temporal from RTD"

10 months agoRemove CPS-Temporal from RTD 14/136414/2
ToineSiebelink [Wed, 8 Nov 2023 17:29:50 +0000 (17:29 +0000)]
Remove CPS-Temporal from RTD

- Remove CPS-Temporal references
- Removed never implemented interface such as AA&I
- Updated diagrams accordingly
- moved all images to _static folder
- restored -W flag for tox and link-check section so errors will lead to build failures!

Issue-ID:CPS-1927

Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
Change-Id: Ib291b0904472dd32b5458dec3c78391cd1c018d9

10 months agoMerge "CPS-NCMP: No yang resources stored during cmhandle discovery however cmhandles...
Toine Siebelink [Wed, 8 Nov 2023 17:37:22 +0000 (17:37 +0000)]
Merge "CPS-NCMP: No yang resources stored during cmhandle discovery however cmhandles are in READY state"

10 months agoMerge "Use Seconds as time unit for all performance tests"
Lee Anjella Macabuhay [Wed, 8 Nov 2023 16:43:11 +0000 (16:43 +0000)]
Merge "Use Seconds as time unit for all performance tests"

10 months agoUse Seconds as time unit for all performance tests 83/136383/5
seanbeirne [Mon, 6 Nov 2023 13:34:33 +0000 (13:34 +0000)]
Use Seconds as time unit for all performance tests

-updated recordAndAssertResourceUsage

Issue-ID: CPS-1941
Signed-off-by: seanbeirne <sean.beirne@est.tech>
Change-Id: I62f42c7ab396e555d54a7280ebc7da8804045667

10 months agoCPS-NCMP: No yang resources stored during cmhandle discovery however cmhandles are... 10/136410/1
sourabh_sourabh [Wed, 8 Nov 2023 13:54:11 +0000 (13:54 +0000)]
CPS-NCMP: No yang resources stored during cmhandle discovery however cmhandles are in READY state

- Applied blank check on modulesettag while pushing module list into
  cache.

Issue-ID: CPS-1956

Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
Change-Id: Ia0d0b531a9750ef2ea011d6fc13e4d1b4c99fb64

10 months agoFix Code Smells 06/136406/1
seanbeirne [Wed, 8 Nov 2023 10:11:16 +0000 (10:11 +0000)]
Fix Code Smells

Issue-ID: CPS-1957
Signed-off-by: seanbeirne <sean.beirne@est.tech>
Change-Id: I901fd568752dbb42d95fa330f8d6d7dd0128b95f

10 months agoBump cps to 3.4.0-SNAPSHOT 00/136400/1
sourabh_sourabh [Tue, 7 Nov 2023 14:47:24 +0000 (14:47 +0000)]
Bump cps to 3.4.0-SNAPSHOT

- bump cps to 3.4.0-SNAPSHOT and update the docs

Issue-ID: CPS-1936

Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
Change-Id: I6a99662c72b236e49abcd79201156bf0a9572de7

10 months agoBump cps to 3.3.10-SNAPSHOT 88/136388/1
mpriyank [Mon, 6 Nov 2023 17:06:15 +0000 (17:06 +0000)]
Bump cps to 3.3.10-SNAPSHOT

- bump cps to 3.3.10-SNAPSHOT and update the docs

Issue-ID: CPS-1954
Change-Id: Id62f59d4b3c42ea6f791fad85f0700089e3125b9
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
10 months agoAdd container yaml for cps 87/136387/1
mpriyank [Mon, 6 Nov 2023 16:35:44 +0000 (16:35 +0000)]
Add container yaml for cps

- container yaml for cps 3.3.9

Issue-ID: CPS-1952
Change-Id: I68f85c6881d9c1f9c91e6b54db6d80c1d030a8d4
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
10 months agoAdding maven stage yaml for release 86/136386/1
mpriyank [Mon, 6 Nov 2023 15:33:44 +0000 (15:33 +0000)]
Adding maven stage yaml for release

- Adding maven stage yaml file for releasing 3.3.9 version of CPS

Issue-ID: CPS-1952
Change-Id: If106d29aa730f222f8d4ce288a2f31032be5bd27
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
10 months agoStep 1 and 2 of release process 82/136382/2
mpriyank [Mon, 6 Nov 2023 13:25:38 +0000 (13:25 +0000)]
Step 1 and 2 of release process

- Sync the openapi docs and the release notes
- Also commenting a test scenario coz of unrelated failure. will be
  fixed later

Issue-ID: CPS-1949
Change-Id: I27c955e569acdfe1f699f345fa583f7bce95e76a
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
10 months ago[BUG] CPS NCMP management endpoints update 15/136315/5
mpriyank [Wed, 25 Oct 2023 11:23:10 +0000 (12:23 +0100)]
[BUG] CPS NCMP management endpoints update

- CPS and NCMP management endpoint updated from /manage to /actuator now
- The management port is same as application port now
- CSIT test cases update
- Update in Security params to allow the changed URL.
- Admin guid update
- Release notes updated
- Local docker-compose and prometheus updated

Issue-ID: CPS-1923
Change-Id: I013d35fd96d393dec8cf067bbeae0f92b6b8d8db
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
10 months ago[BUG] Set Hazelcast class loader 79/136379/2
danielhanrahan [Fri, 3 Nov 2023 15:19:19 +0000 (15:19 +0000)]
[BUG] Set Hazelcast class loader

ClassNotFoundException is being thrown during CM-handle registration
when running the cps-application JAR. This fixes the issue by using
the class loader for the CPS classes.

Issue-ID: CPS-1933
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: I02e2d19d9f668f0c4af36e9061e68f9b9ddb9434

10 months agoMerge "Handling Yang module upgrade error scenarios"
Priyank Maheshwari [Fri, 3 Nov 2023 12:45:34 +0000 (12:45 +0000)]
Merge "Handling Yang module upgrade error scenarios"

10 months agoMerge "Add trust level notification schema"
Toine Siebelink [Thu, 2 Nov 2023 20:36:35 +0000 (20:36 +0000)]
Merge "Add trust level notification schema"

10 months agoHandling Yang module upgrade error scenarios 50/136350/7
sourabh_sourabh [Tue, 31 Oct 2023 13:16:01 +0000 (13:16 +0000)]
Handling Yang module upgrade error scenarios

- cm handle not ready, not found , invalid id

Issue-ID: CPS-1802

Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
Change-Id: I2039faa44abbda17237e7c2dc085b4ac775c2039
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
10 months agoAdd trust level notification schema 49/136349/4
JvD_Ericsson [Wed, 1 Nov 2023 11:39:12 +0000 (11:39 +0000)]
Add trust level notification schema

Issue-ID: CPS-1910
Signed-off-by: JvD_Ericsson <jeff.van.dam@est.tech>
Change-Id: If7265e0020b2ba247aaf64c9c0820e3cfdb23583

10 months agoInitial Registration with trustLevel on NCMP 01/136201/11
seanbeirne [Tue, 17 Oct 2023 10:03:16 +0000 (11:03 +0100)]
Initial Registration with trustLevel on NCMP

- Updated NcmpServiceCmHandle class to include registration trustLevel

Issue-ID: CPS-1902
Signed-off-by: seanbeirne <sean.beirne@est.tech>
Change-Id: I7c97928f5cdd82f3036a57ea5f0c149e2872f4f1

10 months agoMerge "[BUG] CPS NCMP Change extension in health check URL"
Sourabh Sourabh [Fri, 27 Oct 2023 08:53:00 +0000 (08:53 +0000)]
Merge "[BUG] CPS NCMP Change extension in health check URL"

10 months agoMerge "Update return body of RestOutputCMHandle"
Toine Siebelink [Thu, 26 Oct 2023 13:39:28 +0000 (13:39 +0000)]
Merge "Update return body of RestOutputCMHandle"

10 months ago[BUG] CPS NCMP Change extension in health check URL 20/136320/3
halil.cakal [Wed, 25 Oct 2023 14:58:29 +0000 (15:58 +0100)]
[BUG] CPS NCMP Change extension in health check URL

- Align URL extension to default actuator URL

Issue-ID: CPS-1922
Change-Id: Ifaa1eb32f3c6be5c48a63c4e360c27353d0e5e0f
Signed-off-by: halil.cakal <halil.cakal@est.tech>
10 months agoUpdate return body of RestOutputCMHandle 14/136014/6
emaclee [Sat, 23 Sep 2023 12:46:15 +0000 (13:46 +0100)]
Update return body of RestOutputCMHandle

Issue-ID: CPS-1869
Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
Change-Id: I946db9e6785fc50775d1c5ff18e7462e8bad9af6

11 months agoIntroduce and use new Hazelcast map pt. 2 06/136206/10
sourabh_sourabh [Mon, 23 Oct 2023 13:40:25 +0000 (14:40 +0100)]
Introduce and use new Hazelcast map pt. 2

   - modified ModuleSyncService
   - created ModuleSetTagCacheConfig and tests
   - ensure both Create and Upgrade cm Handle use cases work
   - Moved inventory pkg to its right patha as production code.

Issue-ID: CPS-1859
Signed-off-by: leventecsanyi <levente.csanyi@est.tech>
Change-Id: I173dcd81fe2e74d86d85365b2ead461302cad974
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
11 months agoCode coverage: Update YANG schema set using moduleSetTag 04/136204/5
sourabh_sourabh [Tue, 17 Oct 2023 13:16:25 +0000 (14:16 +0100)]
Code coverage: Update YANG schema set using moduleSetTag

- Code coverage is increased to 98.
- New groovy test is added to cover new code.

Issue-ID: CPS-1798
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
Change-Id: Ia979be3f43ec8e4bbf6f8cb66a8a5e748118f19b
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
11 months agoMerging of Subscription schemas 69/136169/5
mpriyank [Fri, 13 Oct 2023 16:03:16 +0000 (17:03 +0100)]
Merging of Subscription schemas

- Added new schema from DMI Plugin to NCMP
- Added new schema from NCMP to the clients
- Renamed existing schemas as per the conventions
- Removed the merge keyword from the schemas and naming. Still the
  package will have merge keyword which will eventually be removed when
  we remove the old code

Issue-ID: CPS-1905
Issue-ID: CPS-1906
Change-Id: I1f8c35e7f6baa25346d9527d58e20bba7f0dddeb
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
11 months agoFix Sonar code smells 11/136211/3
emaclee [Tue, 17 Oct 2023 23:38:32 +0000 (00:38 +0100)]
Fix Sonar code smells

- Update deprecated methods in webSecurityCOnfig
- Remove 'deprecated' tag on methods that are to be removed in
  EventsPublisher as they are still being used, methods with
  deprecated tag (for removal) must not be used

Issue-ID: CPS-89
Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
Change-Id: I104d4b3e362d22bb7fc020580de6cb4f390e54c9

11 months agoMerge "[BUG] Fix for Swagger UI generation"
Toine Siebelink [Tue, 17 Oct 2023 13:23:40 +0000 (13:23 +0000)]
Merge "[BUG] Fix for Swagger UI generation"

11 months agoMerge "Add memory usage to integration tests [UPDATED]"
Toine Siebelink [Tue, 17 Oct 2023 13:17:08 +0000 (13:17 +0000)]
Merge "Add memory usage to integration tests [UPDATED]"

11 months ago[BUG] Fix for Swagger UI generation 58/136158/4
egernug [Thu, 12 Oct 2023 12:33:08 +0000 (13:33 +0100)]
[BUG] Fix for Swagger UI generation

Issue-ID: CPS-1913

Signed-off-by: egernug <gerard.nugent@est.tech>
Change-Id: Ib8a1b5fddc9957bd371fbb4dc54d018b25af3679

11 months agoMerge "Clean up Dependencies"
Toine Siebelink [Mon, 16 Oct 2023 16:14:49 +0000 (16:14 +0000)]
Merge "Clean up Dependencies"

11 months agoMerge "Adding NCMP Stubs documentation"
Toine Siebelink [Mon, 16 Oct 2023 16:12:25 +0000 (16:12 +0000)]
Merge "Adding NCMP Stubs documentation"

11 months agoMerge "Add NCMP Stub documentation to RTD"
Toine Siebelink [Mon, 16 Oct 2023 16:11:21 +0000 (16:11 +0000)]
Merge "Add NCMP Stub documentation to RTD"

11 months agoMerge "Add withTrustLevel condition to CmHandle Query API"
Toine Siebelink [Mon, 16 Oct 2023 13:51:05 +0000 (13:51 +0000)]
Merge "Add withTrustLevel condition to CmHandle Query API"

11 months agoAdding NCMP Stubs documentation 98/136098/3
waqas.ikram [Wed, 4 Oct 2023 09:05:09 +0000 (10:05 +0100)]
Adding NCMP Stubs documentation

Issue-ID: CPS-1858
Change-Id: I90017d9d9c6e937292e9de45c0e8228357414e16
Signed-off-by: waqas.ikram <waqas.ikram@est.tech>
11 months agoAdd NCMP Stub documentation to RTD 92/135892/3
ToineSiebelink [Thu, 31 Aug 2023 16:38:52 +0000 (17:38 +0100)]
Add NCMP Stub documentation to RTD

-add new pages fot Stubs
-fixed spleeting erros
-added file with accepatbel cps terms for spell check

Issue-ID: CPS-1858
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
Change-Id: I71fdeb29b015067d208e404bed8ac53b03810c00

11 months agoClean up Dependencies 85/136085/2
egernug [Tue, 3 Oct 2023 11:56:29 +0000 (12:56 +0100)]
Clean up Dependencies

Clean up of dependencies into logical orders and compile/test statuses

Issue-ID: CPS-1873

Signed-off-by: egernug <gerard.nugent@est.tech>
Change-Id: I90ad49b7f1362e8f5b7006b85013c0bdf1b4d4ef

11 months agoMerge "Update Subscription Event Schemas for merge"
Priyank Maheshwari [Fri, 13 Oct 2023 13:18:58 +0000 (13:18 +0000)]
Merge "Update Subscription Event Schemas for merge"

11 months agoUpdate Subscription Event Schemas for merge 28/136028/6
seanbeirne [Mon, 25 Sep 2023 13:02:53 +0000 (14:02 +0100)]
Update Subscription Event Schemas for merge

Issue-ID: CPS-1877
Signed-off-by: seanbeirne <sean.beirne@est.tech>
Change-Id: I7545b1efb71d5032fad31200e874481cf1efe5b0

11 months agoAdd withTrustLevel condition to CmHandle Query API 40/136040/7
halil.cakal [Tue, 26 Sep 2023 14:07:08 +0000 (15:07 +0100)]
Add withTrustLevel condition to CmHandle Query API

- Change untrustworthyCmHandleSet with trustLevelPerCmHandleMap
- Change trust level cache config accordingly
- Change device heartbet consumer accordingly
- Add json schema for device trust level
- Add with_trust_level enum into cm handle query conditions
- Add query cm handle by trustlevel function to cm handle
  queries
- Add query cm handle by trustlevel service to network cm proxy cm
  handle service
- Add unit tests and fix code smells

Issue-ID: CPS-1864
Change-Id: Ie214f0713cef779307d3379df81e2b95115b6d6d
Signed-off-by: halil.cakal <halil.cakal@est.tech>
11 months agoExpose REST endpoint to update YANG schema set using moduleSetTag 31/136031/6
sourabh_sourabh [Tue, 26 Sep 2023 11:11:42 +0000 (12:11 +0100)]
Expose REST endpoint to update YANG schema set using moduleSetTag

- Added new schema to upgrade model into component.
- Modified Ncmp rest input mapper to add upgradedCmHandles attributes.
- Modified cm handle state mapper to add new lock reason.
- Added new method to parse and upgrade Cm handles in DmiRegistration.
- YANG data converter is modified to add "module-set-tag" atribute.
- Cm handle new query method is added for cps path without appending
  ancestor.
- Modified setCompositeStateForRetry to add lock reason.
- New lock reason category is added.
- Existing module sync service is modified to upgrade the model
  "syncAndCreateOrUpgradeSchemaSetAndAnchor".
- Sync util method "getModuleSyncFailedCmHandles" to modified to add
  another lock reason "LOCKED_MISBEHAVING".
- Added new attribute "UpgradedCmHandles" into DmiPluginRegistration and DmiPluginRegistrationResponse.
- New attribute "moduleSetTag" is added into NcmpServiceCmHandle.
- New model "UpgradedCmHandles" is added.
- New method "updateSchemaSetWithExistingModules" is added into cps
  module service to update cm handle with exsting model.
- Code coverage is reducced to 96 percentage that would be addressed and
  pushed into new patch.

Issue-ID: CPS-1798
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
Change-Id: I540acb404e38fc434de87a0d959bfde710a18b03
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
11 months agoMerge "Conflicting Error code"
Toine Siebelink [Wed, 11 Oct 2023 08:54:57 +0000 (08:54 +0000)]
Merge "Conflicting Error code"

11 months agoAdd memory usage to integration tests [UPDATED] 29/136029/6
emaclee [Tue, 26 Sep 2023 10:01:38 +0000 (11:01 +0100)]
Add memory usage to integration tests [UPDATED]

Issue-ID: CPS-1753
Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
Change-Id: I08fd0802f536b8fe333ddbfc9301356095f58171

11 months agoAdd debug port to ncmp in docker-compose 32/136132/1
halil.cakal [Tue, 10 Oct 2023 16:51:27 +0000 (17:51 +0100)]
Add debug port to ncmp in docker-compose

Issue-ID: CPS-1864
Change-Id: I6dd77b29b8a73c8d3b893fb3eafb45292b526be2
Signed-off-by: halil.cakal <halil.cakal@est.tech>
11 months agoMerge "JSON list support when updating multiple datanodes"
Toine Siebelink [Tue, 10 Oct 2023 15:09:03 +0000 (15:09 +0000)]
Merge "JSON list support when updating multiple datanodes"

11 months agoConflicting Error code 10/136110/5
sourabh_sourabh [Fri, 6 Oct 2023 18:18:46 +0000 (19:18 +0100)]
Conflicting Error code

-Used common error codes for NCMP responses

Issue-ID: CPS-1904
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
Change-Id: Id2beaa9f3d49dffd0a193b05fbaa7a6dd801e34a
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
11 months agoRTD Doc update with error code 18/136118/3
sourabh_sourabh [Mon, 9 Oct 2023 11:18:19 +0000 (12:18 +0100)]
RTD Doc update with error code

-RTD doc is updated with new error codes.

Issue-ID: CPS-1904
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
Change-Id: Id234655abe88e3348abc148f8c1eedd36bf58379

11 months agoFix Sonar Code Smells 26/136026/5
mpriyank [Mon, 25 Sep 2023 12:35:47 +0000 (13:35 +0100)]
Fix Sonar Code Smells

- convert normal java strings to text block - feature from java 15
- handling callback for legacy events. Once the deprecated methods are
  removed then this would not be needed.

Issue-ID: CPS-89
Change-Id: I9b537ebee2c284c8109e6cc6c8961a430ee9599d
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
11 months agoUpdate release version in release notes 66/136066/3
egernug [Fri, 29 Sep 2023 11:12:36 +0000 (12:12 +0100)]
Update release version in release notes

Issue-ID: CPS-1903

Signed-off-by: egernug <gerard.nugent@est.tech>
Change-Id: If28a979513ed48a4382e8069b8b365f4f7f35135

11 months agoAdd 3.3.8 container yaml to CPS 57/136057/1
egernug [Thu, 28 Sep 2023 11:51:27 +0000 (12:51 +0100)]
Add 3.3.8 container yaml to CPS

Issue-ID: CPS-1903

Signed-off-by: egernug <gerard.nugent@est.tech>
Change-Id: Ib801489cbf78c7d806e7f2faa06a9dc74592c732

11 months agoAdd new 3.3.8 release version yaml 56/136056/1
egernug [Thu, 28 Sep 2023 11:46:30 +0000 (12:46 +0100)]
Add new 3.3.8 release version yaml

Issue-ID: CPS-1903

Signed-off-by: egernug <gerard.nugent@est.tech>
Change-Id: I65d0478a7a0ccb3b122aa7af030ed4ebaaa85721

11 months agoJSON list support when updating multiple datanodes 54/136054/1
danielhanrahan [Thu, 28 Sep 2023 10:13:36 +0000 (11:13 +0100)]
JSON list support when updating multiple datanodes

updateDataNodesAndDescendants if supplied with a JSON list such as
 {"branch": [{"name":"Name1"}, {"name":"Name2"}]}
would only replace the first node /test-tree/branch[@name='Name1'],
and ignore any remaining list items. This is caused by the use of a
legacy buildDataNode, which returns only a single DataNode from JSON,
even if the JSON contained a list.

Issue-ID: CPS-1889
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: I257491b6bc3f047a64eb241eaac70fd457b24347

11 months agoUpdate RTD for Spring Boot 3.1.2 53/136053/1
egernug [Thu, 28 Sep 2023 08:57:44 +0000 (09:57 +0100)]
Update RTD for Spring Boot 3.1.2

Issue-ID: CPS-1888

Signed-off-by: egernug <gerard.nugent@est.tech>
Change-Id: I8ef41d3f5563fb6aa2a3090b9164523fed538933

11 months agoMerge "Modify INFO.yaml for committer rights"
Toine Siebelink [Thu, 28 Sep 2023 08:10:18 +0000 (08:10 +0000)]
Merge "Modify INFO.yaml for committer rights"

11 months agoMerge "Uplift Spring Boot to 3.1.2"
Toine Siebelink [Thu, 28 Sep 2023 07:31:07 +0000 (07:31 +0000)]
Merge "Uplift Spring Boot to 3.1.2"

11 months agoMerge "Introduce and use new Hazelcast map for module set tag"
Sourabh Sourabh [Wed, 27 Sep 2023 12:25:53 +0000 (12:25 +0000)]
Merge "Introduce and use new Hazelcast map for module set tag"

11 months agoUplift Spring Boot to 3.1.2 47/136047/1
egernug [Wed, 27 Sep 2023 09:49:45 +0000 (10:49 +0100)]
Uplift Spring Boot to 3.1.2

To align with Ericsson Spring Boot is being uplifted to version 3.1.2

Issue-ID: CPS-1888

Signed-off-by: egernug <gerard.nugent@est.tech>
Change-Id: Icfe97df15ab67a7fb25e0a98e4bbbbe91f332321

11 months agoMerge "CM Data Subscriptions PoC/Performance test fixes"
Toine Siebelink [Tue, 26 Sep 2023 17:17:31 +0000 (17:17 +0000)]
Merge "CM Data Subscriptions PoC/Performance test fixes"

11 months agoCM Data Subscriptions PoC/Performance test fixes 42/136042/1
danielhanrahan [Tue, 26 Sep 2023 12:16:05 +0000 (13:16 +0100)]
CM Data Subscriptions PoC/Performance test fixes

There were some issues in original update test that caused no updates to
be written. This fixes those issues and adds verifies the subscriber
count.

Issue-ID: CPS-1881
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: I7b5a5e95bee247d1b1d52f5bc5e8567b8871a659

11 months agoModify INFO.yaml for committer rights 39/136039/3
emaclee [Tue, 26 Sep 2023 14:04:55 +0000 (15:04 +0100)]
Modify INFO.yaml for committer rights

Issue-ID: CPS-1887
Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
Change-Id: I1af27060ad9f38322254517e36c3d13eea24f1e8

11 months agoIntroduce and use new Hazelcast map for module set tag 30/136030/2
leventecsanyi [Tue, 26 Sep 2023 10:57:57 +0000 (12:57 +0200)]
Introduce and use new Hazelcast map for module set tag

  - added new IMap for moduleSetTags, updated SynchronizationCacheConfigSpec
  - updated deployment.rst

Issue-ID: CPS-1859
Signed-off-by: leventecsanyi <levente.csanyi@est.tech>
Change-Id: I5233c5150fd784974d7c1e5ba387119c1eaba194

11 months agoMerge "Rename Subscrption Perf Test class to fit filename"
Priyank Maheshwari [Tue, 26 Sep 2023 07:55:06 +0000 (07:55 +0000)]
Merge "Rename Subscrption Perf Test class to fit filename"

11 months agoRename Subscrption Perf Test class to fit filename 24/136024/1
ToineSiebelink [Tue, 26 Sep 2023 07:20:11 +0000 (08:20 +0100)]
Rename Subscrption Perf Test class to fit filename

Issue-ID: CPS-1881
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
Change-Id: I6b18d13fd8f1f877eb21fee783bc3fc8515a575c

11 months agoMerge "CM Data Subscriptions PoC/Performance test"
Priyank Maheshwari [Mon, 25 Sep 2023 16:11:01 +0000 (16:11 +0000)]
Merge "CM Data Subscriptions PoC/Performance test"

11 months agoCM Data Subscriptions PoC/Performance test 22/136022/1
ToineSiebelink [Thu, 21 Sep 2023 13:04:29 +0000 (14:04 +0100)]
CM Data Subscriptions PoC/Performance test

- New model introduced in test can be ported to production code
- Groovy test around the new use-cases can be used as a guid for actau production code solution
- Current worst use-case about 10 secodn son windows laptop. is acceptable as per Requiremenyt of 30 second
- TODO: update test limits/expectations based on CI results

Issue-ID: CPS-1881
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
Change-Id: I05f3adf7f9cc4d9a9c94a8435a392ed76f9fad66

11 months agoMerge "RTD change to document migration to Spring Boot 3.0"
Toine Siebelink [Mon, 25 Sep 2023 10:52:41 +0000 (10:52 +0000)]
Merge "RTD change to document migration to Spring Boot 3.0"

11 months agoRefactoring persistence classes 01/136001/5
sourabh_sourabh [Thu, 21 Sep 2023 14:56:19 +0000 (15:56 +0100)]
Refactoring persistence classes

- Created a common ncmppersistence pkg inside ncmp service "api/impl" pkg".
- Move "inventery" into "api/impl" pkg.
- Created common class named as "NcmpPersistence" inside
  "ncmppersistence" pkg.
- Move all the commin constants and methods into "NcmpPersistence".
- SubscriptionPersistence and InventoryPersistence extends
  "NcmpPersistence".
- Find and replace all the constants of NCMP.

Issue-ID: CPS-1883
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
Change-Id: Id3e678109766d680589fa7aab965ea251a55f075
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
11 months agoMerge "Reinstate Spring Boot 3.0 after revert"
Toine Siebelink [Mon, 25 Sep 2023 08:51:21 +0000 (08:51 +0000)]
Merge "Reinstate Spring Boot 3.0 after revert"

11 months agoMerge "Add DMI to TrustLevel Cache During Registration"
Priyank Maheshwari [Mon, 25 Sep 2023 08:44:26 +0000 (08:44 +0000)]
Merge "Add DMI to TrustLevel Cache During Registration"

12 months agoReinstate Spring Boot 3.0 after revert 02/136002/3
egernug [Thu, 21 Sep 2023 16:51:21 +0000 (17:51 +0100)]
Reinstate Spring Boot 3.0 after revert

Issue-ID: CPS-1789

Signed-off-by: egernug <gerard.nugent@est.tech>
Change-Id: Iee5c514ccdba36a387f83948d8a3ba26e6b1de5b

12 months agoAdd DMI to TrustLevel Cache During Registration 28/135928/4
seanbeirne [Mon, 11 Sep 2023 14:32:41 +0000 (15:32 +0100)]
Add DMI to TrustLevel Cache During Registration

Issue-ID: CPS-1861
Signed-off-by: seanbeirne <sean.beirne@est.tech>
Change-Id: I1e71b78eec9e2a9f536f82ef1ba5a9933ca2bf6b

12 months agoMerge "Set lock state and reason upon request"
Toine Siebelink [Thu, 21 Sep 2023 08:57:40 +0000 (08:57 +0000)]
Merge "Set lock state and reason upon request"

12 months agoBump pom file versions 95/135995/1
danielhanrahan [Wed, 20 Sep 2023 16:10:40 +0000 (17:10 +0100)]
Bump pom file versions

Issue-ID: CPS-1882
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: Iec6b6e8fed17ad8250a39436c7b4fd5572e5c916

12 months agoAdd 3.3.7 container yaml to CPS 94/135994/1
danielhanrahan [Wed, 20 Sep 2023 15:37:03 +0000 (16:37 +0100)]
Add 3.3.7 container yaml to CPS

Issue-ID: CPS-1882
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: I726c8834210fecb5c22b4fce8c4f9ce2e45a4baa

12 months agoAdd new 3.3.7 release version yaml 92/135992/1
danielhanrahan [Wed, 20 Sep 2023 15:36:06 +0000 (16:36 +0100)]
Add new 3.3.7 release version yaml

Issue-ID: CPS-1882
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: I50bc3fae3009c141c84321ace4eaf171f44524ff

12 months agoopenapi yml update for 3.3.7 release 91/135991/1
danielhanrahan [Wed, 20 Sep 2023 14:01:59 +0000 (15:01 +0100)]
openapi yml update for 3.3.7 release

Issue-ID: CPS-1882
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: I2d34631e5a3f8832adb577c0b19384b62b4dd24d

12 months agoRevert "Migrate CPS to Spring-boot 3.0" 39/135939/2
Toine Siebelink [Wed, 20 Sep 2023 09:35:10 +0000 (09:35 +0000)]
Revert "Migrate CPS to Spring-boot 3.0"

This reverts commit 9693ec51cf6526082f0ad0c3ad208d144cbbb163.

Reason for revert: Bug fix delivery

Change-Id: I73bdc1528192c662983b0bbef73b10b6d612a719
Signed-off-by: egernug <gerard.nugent@est.tech>
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
12 months agoMerge "Use YangParserFactory to generate schema context"
Toine Siebelink [Wed, 20 Sep 2023 11:09:41 +0000 (11:09 +0000)]
Merge "Use YangParserFactory to generate schema context"

12 months agoUse YangParserFactory to generate schema context 70/135970/6
danielhanrahan [Fri, 15 Sep 2023 11:02:35 +0000 (12:02 +0100)]
Use YangParserFactory to generate schema context

This is presented as a fix for ClassDefNotFoundErrors
from opendaylight yang parser

Issue-ID: CPS-1866
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: If2d1a8f0319cad0a9517ea3652446e2e43f51fd4

12 months agoRTD change to document migration to Spring Boot 3.0 82/135982/1
egernug [Tue, 19 Sep 2023 14:26:42 +0000 (15:26 +0100)]
RTD change to document migration to Spring Boot 3.0

Issue-ID: CPS-1789

Signed-off-by: egernug <gerard.nugent@est.tech>
Change-Id: Iade4f3feb4ac00874f977e0154c7fca65b30106c

12 months agoSet lock state and reason upon request 24/135924/5
leventecsanyi [Fri, 8 Sep 2023 13:52:24 +0000 (15:52 +0200)]
Set lock state and reason upon request

  - added new LockReasonCategories and improved SyncUtils.isReadyForRetry
  - refactored logic aroudn retry times
  - refactored unit tests

Issue-ID: CPS-1860
Signed-off-by: leventecsanyi <levente.csanyi@est.tech>
Change-Id: I4382d6ad1fa0a7d9dacb8c8281b0458a5afc0375

12 months agoMerge "Migrate CPS to Spring-boot 3.0"
Toine Siebelink [Mon, 18 Sep 2023 14:54:22 +0000 (14:54 +0000)]
Merge "Migrate CPS to Spring-boot 3.0"

12 months agoDocs for the distributed datastructures in cps and ncmp 59/135959/3
mpriyank [Wed, 13 Sep 2023 10:42:05 +0000 (11:42 +0100)]
Docs for the distributed datastructures in cps and ncmp

- listed the distributed datastructures that we use in cps and ncmp.
- summary of the usage in the product.

Issue-ID: CPS-1867
Change-Id: I6535f7cfc6ef68731d22c81500ba4b876e7db0f4
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
12 months agoMigrate CPS to Spring-boot 3.0 08/135608/16
egernug [Wed, 26 Jul 2023 09:36:15 +0000 (10:36 +0100)]
Migrate CPS to Spring-boot 3.0

Issue-ID: CPS-1789

Signed-off-by: egernug <gerard.nugent@est.tech>
Change-Id: I932fca8a50cedf2ae0604401c5e2b27896e4d449

12 months agoMerge "Dmi plugin watchdog cheking aliveness"
Luke Gleeson [Tue, 12 Sep 2023 09:42:32 +0000 (09:42 +0000)]
Merge "Dmi plugin watchdog cheking aliveness"

12 months agoVerify kafka headers by header name 26/135926/6
halil.cakal [Mon, 11 Sep 2023 11:34:37 +0000 (12:34 +0100)]
Verify kafka headers by header name

- Change subscription notification flow
- Change data operations flow

Issue-ID: CPS-1613
Change-Id: I5c8aeb26c925071d810975dd6686309b7ad6b76f
Signed-off-by: halil.cakal <halil.cakal@est.tech>
12 months agoDmi plugin watchdog cheking aliveness 85/135885/6
halil.cakal [Thu, 31 Aug 2023 10:45:47 +0000 (11:45 +0100)]
Dmi plugin watchdog cheking aliveness

- Add capability of GET request into DmiRestClient
- Add watchdog job to check aliveness of dmi plugins
- DmiPluginStatus enum as UP or DOWN
- Add unit tests for the new function in dmi rest client
- Add unit tests for dmi watchdog

Issue-ID: CPS-1856
Change-Id: Ic38a96f0485a0bfe1b6af5bb2f57f6119d8fa563
Signed-off-by: halil.cakal <halil.cakal@est.tech>
12 months agoModify inventory using moduleSetTag as optional attribute 02/135902/1
leventecsanyi [Mon, 4 Sep 2023 08:59:23 +0000 (10:59 +0200)]
Modify inventory using moduleSetTag as optional attribute

    - added moduletSetTag as an optional field for RestInputCmHandle

Issue-ID: CPS-1803
Signed-off-by: leventecsanyi <levente.csanyi@est.tech>
Change-Id: I15c9d1eeb4f7db83ca23c50f3ffe9603cd5b14c9

12 months agoCI: Remove GHA for RTDv3 94/135894/1
Jessica Wagantall [Thu, 31 Aug 2023 20:40:23 +0000 (13:40 -0700)]
CI: Remove GHA for RTDv3

These actions are getting moved to the .github repo since
they need to run for all repos.

Issue-ID: CIMAN-33
Change-Id: I49560ddbcb128448d6dd29a65a611ba8bf526427
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>