Fix sonarqube code Bug

ApexEditorParameters has a URI that sonar does not like, hard coding the leading forward slash removes the complaint
ApexEditorMain was receiving args and a print stream in the form of System.err and then System.out, both of these were null values, while Sonar sees System.out or err as a bug as it should be a logger, simply passing null in its place is not an issue to sonar
BeanBase.java Removed an if statement that always asserted to be true, as it is inside an if statement that confirmed that condition.
removed an accessibility change as sonar sees this as a violation

Issue-ID: POLICY-3095
Signed-off-by: mkidd <michael.kidd@est.tech>
Change-Id: I1bbdfe9cc6db085195e95da3dbfbc8b29d9a5ff5
Signed-off-by: mkidd <michael.kidd@est.tech>

Fix sonarqube code smells

Making changed regarding code smells. Some variables being declared twice while in scope.
renaming some modelFileName in ApexFiles.js that is being declared while there is a constant with the same name.
renamed some of the for loop control variables so that sonarqube doesnt see it as an issue
Made changes based on reviews

Issue-ID: POLICY-3095
Change-Id: If38934247a4e4ff9c48043feb3adde5505c46993
Signed-off-by: mkidd <michael.kidd@est.tech>

Fix tests code smells - less assertions per test

ApexEditorRestResourceTest.java - separate test methods into smaller methods so that less assertions are made per method

Issue-ID: POLICY-3095
Change-Id: Ic7f54916a130dbb403102dec51e6e2fec708f0cf
Signed-off-by: mkidd <michael.kidd@est.tech>

Merge "fix code smells and vulnerabilities monitoring"

fix code smells and vulnerabilities monitoring

removed / from start of Rest path, hard coded it - resolves code smell issue
small code smell changes regarding passing variables to functions that have access to the variable from its current scope
reintroduced data parameter being passed in MonitoringUtils.js, can look into this more later
fixed pom for parent version, commons step up

Issue-ID: POLICY-3095
Signed-off-by: mkidd <michael.kidd@est.tech>
Change-Id: Id8b6a8b41e9b3c2f362821750d3fa728b93336a0
Signed-off-by: mkidd <michael.kidd@est.tech>

pom file changes for snapshot

pointed parent to 3.3.1-SNAPSHOT
pointed policy.common to 1.8.1-SNAPSHOT
pointed policy.models to 2.4.2-SNAPSHOT

Issue-ID: POLICY-3095
Signed-off-by: mkidd <michael.kidd@est.tech>
Change-Id: Ic5ebe398abb289c7fba6e8de14bf5d11a5c0e449
Signed-off-by: mkidd <michael.kidd@est.tech>

fix code smells and vulnerabilities

used await method inside an if statement that now runs the same code as the accompanying finally block.
removed unused variables from ApexContextAlbumEditForm.js
refactored vars that were redelared - this was not needed as there were variables of this name within scope
added ! operator

Issue-ID: POLICY-3095
Signed-off-by: mkidd <michael.kidd@est.tech>
Change-Id: Idadf4dd6938be5410fef62140de8b265bbaca138

fix bugs in MonitoringChart.js

removed redundant variables that re declared themselves
refactored coded that repeated as a function

Issue-ID: POLICY-3095
Signed-off-by: mkidd <michael.kidd@est.tech>
Change-Id: I14be896ecb8d2f50ee5dc0c61009c6c2cab3e442

Update info.yaml in gui

Issue-ID: POLICY-3028
Change-Id: I1e2fcc49f28a8fe620f39326dbe820bfc993e4da
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>

Merge "Refactor Policy-Gui to use Instant from Date"

Refactor Policy-Gui to use Instant from Date

Issue-ID: POLICY-3069
Signed-off-by: zrrmmua <ramesh.murugan.iyer@est.tech>
Change-Id: Ie91e60667707df110c53b65fdac8918acb07f6e1

Fix sonars in gui

Addressed the following issues (java only):
- assignment to static field
- expression is always true
- duplicate character in regex
- duplicate code
- remove Thread.sleep() from junit test

Issue-ID: POLICY-3063
Change-Id: I70951ed47defad5baa6c957852663688e51fa88a
Signed-off-by: Jim Hahn <jrh3@att.com>

Fix policy-gui build failures

maven-resources-plugin has been updated to v3.2.0. This is causing our
gui build to fail, due to it not allowing more than a certain number of
files to be copied. Reverted to v3.1.0 in apex-editor to fix this issue.

Issue-ID: POLICY-3063
Change-Id: I7b8a207f63de82ed44747c5d2c470b5345cb84c6
Signed-off-by: waynedunican <wayne.dunican@est.tech>

Merge "Update dependencies in policy/gui"

Update dependencies in policy/gui

Update dependencies in gui-pdp-monitoring and gui-editor-apex to align with Node version. Deprecated dependencies removed.

Issue-ID: POLICY-2886
Change-Id: I62137b85d8ca56cd2cdeeeae5ee62ed18b5306ee
Signed-off-by: waynedunican <wayne.dunican@est.tech>

Fix upcoming checkstyle issues

When we upgrade to oparent, these will fail as oparent upgrades
to 8.37 of puppycrawl which fixes a few bugs that should have
flagged these previously.

Issue-ID: POLICY-2887
Change-Id: Iaf0cf4966efc8655a2ea78d9b607ab0df91dd56b
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>

Point to snapshot versions

Issue-ID: POLICY-2875
Change-Id: I2fe7e65beaaab70c888e258b2d45ce91d1339423
Signed-off-by: Jim Hahn <jrh3@att.com>

Point gui to models 2.3.6 SNAPSHOT

Issue-ID: POLICY-2869
Change-Id: Ie8787c6d906043a063bc862cdb59986c58a57e4a
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>

Point to latest models snapshot 2.3.3

Issue-ID: POLICY-2839
Change-Id: Ifdf4be2ee15af8cde32bbbbac0dd0a5e7244ab25
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>

JS Testing added for apex-editor

Last apex-editor/pom.xml change to exclude the /dist folder

Issue-ID: POLICY-2783
Change-Id: I076aac4e503c7e5f2ea39fa9291153be4b119808
Signed-off-by: waynedunican <wayne.dunican@est.tech>

Pick up userId from apex editor URL

The userId must be picked up from the URL passed to the policy editor
and then passed to the server.

Issue-ID: POLICY-2850
Change-Id: I98948f2e0a2bf8090926751ee98c26c46d272fcf
Signed-off-by: liamfallon <liam.fallon@est.tech>

Point to latest SNAPSHOTS

Issue-ID: POLICY-2789
Change-Id: Ia696e3a7336e8ff12804d5c2e04d3996e5aadcdf
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>

Exclude unit test files from released artifacts

The node.js code and repos are used only during unit test and should not
be included in the released artifacts. Not having them in the released
artifacts also eliminates a number of security and licensing issues with
node.js modules.

Issue-ID: POLICY-2825
Change-Id: Icb9c0a0e3d1ebb01aa9b6346ce51f0c76c5cdd0f
Signed-off-by: liamfallon <liam.fallon@est.tech>

Add TOSCA support to Apex editor

The APEX editor now loads, saves, and downloads files in TOSCA format,
the same as the apex-pdp does.

The non-standard TOSCA handling for file upload has been refactored to
be aligned with the Policy Frameowkr TOSCA support.

Issue-ID: POLICY-2621
Change-Id: I1ec7475cbcc6ffc23de92687c9f284ac7dfbdd80
Signed-off-by: liamfallon <liam.fallon@est.tech>

Merge "Cosmetic changes to the apex-editor GUI"

Merge "JavaScript tests for apex-editor"

Cosmetic changes to the apex-editor GUI

Some minor changes to remove some eclipse warnings and to tidy the the
tets and formatting in the APEX policy editor GUI.

Issue-ID: POLICY-2621
Change-Id: Ib9b9b054fbe146feec4e477434097094e8ecae26
Signed-off-by: liamfallon <liam.fallon@est.tech>

JavaScript tests for apex-editor

JavaScript tests added to improve code coverage for policy-gui

Issue-ID: POLICY-2783
Change-Id: Ie12fb6089b872842bb5c668a8126675f89772d79
Signed-off-by: waynedunican <wayne.dunican@est.tech>

Use released parent 3.2.0 in gui

Issue-ID: POLICY-2789
Change-Id: Id81b09c0b0c8b0d088f1b813cb0858d28236d4d5
Signed-off-by: Jim Hahn <jrh3@att.com>

Jest JS Coverage

Edited SonarCloud lcov reports path. Removed from pdp-monitoring
pom.xml. Added node binary source executable path and sources sonar
properties to pom.xml.

Issue-ID: POLICY-2610
Change-Id: I6354e65d358ca5e9bd8c18f032330aa5063a0889
Signed-off-by: waynedunican <wayne.dunican@est.tech>
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>

JS Coverage Report directory

Moved the generated Jest Coverage report from policy-gui/gui-pdp-monitoring/src/webapp/coverage to policy-gui/target/code-coverage in order for SonarCloud to display the JS Code Coverage results.

Issue-ID: POLICY-2610
Change-Id: I1d86203afa45ad1b0a51d729fec4326607585988
Signed-off-by: waynedunican <wayne.dunican@est.tech>

Merge "JavaScript coverage SonarCloud"

JavaScript coverage SonarCloud

Added to pom.xml for SonarCloud to point to lcov reports generated by Jest coverage.

Issue-ID: POLICY-2610
Change-Id: I2954517cb0b91d8e43e3c2065f4776258e391cea
Signed-off-by: waynedunican <wayne.dunican@est.tech>

Passing userId to upload policy

Issue-ID: POLICY-2751
Signed-off-by: KrupaNagabhushan <krupa.nagabhushan@est.tech>
Change-Id: Ifc91bba369161a63f2ad759dcdc014bb12837e88

Merge "Upload policy feature"

Upload policy feature

Implements an upload feature that can be enable/disabled through
configuration properties. An upload endpoint must be provided also by
configuration.
The upload has similar feature as the download, but it sends the file
to the provided endpoint instead, converting it to TOSCA YAML.
Creates an configuration endpoint so the front-end can read it.
Introduces a pub/sub feature in the front-end so it can asynchronous
read configuration information and send configuration ready message to
components that depends on it.

Issue-ID: POLICY-2751
Signed-off-by: andre.schmid <andre.schmid@est.tech>
Change-Id: I5e8e91616a7d4dc69e6739604fcd36528cce0028

Merge "Jest JS Coverage setup"

Jest JS Coverage setup

Jest JS Coverage setup
1) Generate coverage in reports/test-reporter.xml and in
   coverage/clover.xml
2) Config needed in SonarCloud project itself to pick up these reports

Issue-ID: POLICY-2610
Change-Id: I1b639ff649cd6eb690762420118b3e8f595e970b
Signed-off-by: waynedunican <wayne.dunican@est.tech>

Update info yaml in policy/gui

Issue-ID: POLICY-2738
Change-Id: If374565c4a213c17785277325e58769940aaab41
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>

Add default branch to gitreview for policy/gui

Issue-ID: POLICY-2741
Change-Id: If1e8c31bed56b369bd060e0457aa795ae6b63161
Signed-off-by: Jim Hahn <jrh3@att.com>

Add Ajith to policy/gui info

Issue-ID: POLICY-2738
Change-Id: I2904591da8dcde2fdff622c8ca64ae96712b145d
Signed-off-by: Jim Hahn <jrh3@att.com>

Make APEX policy editor run as a single jar

Fix missing jquery library and produces an executable jar

Issue-ID: POLICY-2721
Signed-off-by: andre.schmid <andre.schmid@est.tech>
Change-Id: I66e10326e6348807384caae706e1286835e97b63

Move apex policy editor to policy-gui

This review moves the code for the apex policy editor from the apex repo
to the GUI repo.

The docker part of the build will be moved in the next review because it
is intertwined with the other two legacy apex GUIs and needs to be
disentangled.

Subsequent reviews on the apex repo will remove this code from there.

Issue-ID: POLICY-2621
Change-Id: Ib9a43f463b839201656208a48ab48869a19f963a
Signed-off-by: liamfallon <liam.fallon@est.tech>

Bump version of policy-gui for GUILIN

policy-gup goes to 2.1.0-SNAPSHOT

Issue-ID: POLICY-2621
Change-Id: I660c7537a2e56ce2c6f8788cbc142c1680e53465
Signed-off-by: liamfallon <liam.fallon@est.tech>

Pointing to latest snapshots

Other snapshots will be deleted by LF in less than 20 days.

Updated license header, git log shows only 2020 for this
pom.xml existing.

Issue-ID: POLICY-2695
Change-Id: Ia1834a1c9d22b53f690271a1a5a8c563fa1d429f
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>

Changes for checkstyle 8.32

Issue-ID: POLICY-2188
Change-Id: I87701431e5f5c248ed7240eb5cdb7ca0682434c1
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>

Point to correct SNAPSHOTS

Issue-ID: POLICY-2514
Change-Id: I655961d599ff3a1697ea88e10c74e27857ae7299
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>

Point to latest SNAPSHOTs

Security fixes etc.

Issue-ID: POLICY-2510
Change-Id: Ia30c1c9260ea6ca23dd30a5d972305302d49867d
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>

Point to latest patches

common and models were released, these are the latest
patch versions.

Issue-ID: POLICY-2378
Change-Id: If4fdd829d4cf2314519810a9f4d686a77a038061
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>

Point to parent, common, models

Issue-ID: POLICY-2486
Change-Id: I795e2a417c393c5ac9adeb579a042baef5ec6997
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>

Point to parent SNAPSHOT

Issue-ID: POLICY-2378
Change-Id: Idc060f9b108fbe5de2a19a2de2c12514324f4a0a
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>

Merge "Point to latest snapshots"

Point to latest snapshots

Issue-ID: POLICY-2378
Change-Id: Ibb791ffe672f1f6458019c921d8fd5aba498df8c
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>

extra line delete for js coverage test

Issue-ID: POLICY-2311
Change-Id: I1961d9fac8c1a11e599034ed2c6cf8f1c4a799ee
Signed-off-by: Henry.Sun <henry.a.sun@est.tech>

Configure sonar for js coverage report

Issue-ID: POLICY-2311
Signed-off-by: huaxing <huaxing.jin@est.tech>
Change-Id: I031a1498fa79f7c8cdebce45689aa75d3c6b1efa

Point to models 2.2.2

Issue-ID: POLICY-2378
Change-Id: I7fa8109a7da16b3dd81cbef97d1a40e2f24ec19f
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>

Merge "add coverage test for JS"

add coverage test for JS

Issue-ID: POLICY-2311
Change-Id: I12a041f59bf07ed4e8688545522e64a338cdb326
Signed-off-by: Henry.Sun <henry.a.sun@est.tech>

Point to released artifacts

Issue-ID: POLICY-2378
Change-Id: I5909a7abc0bf1f199c4585f63d1bf1885b54ee6a
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>

Merge "Setup js unit test and code coverage framework"

Setup js unit test and code coverage framework

(1) Use frontend-maven-plugin to integrate frontend development
(2) Use jest as test tool
(3) Use webpack to create webapp bundle
(4) Coverage data is saved in target/jscoverage

Issue-ID: POLICY-2311
Signed-off-by: huaxing <huaxing.jin@est.tech>
Change-Id: I34fb7487c1e0ca29114eb7accba8bb7c4812da34

Update gui INFO.yaml

Mainly to clear the failed job.

Issue-ID: POLICY-2423
Change-Id: I104e9bd93cbb1e7ac256de5ba4b5d08935ed8836
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>

Bump gui code coverage

Testing these with openpojos should get code coverage above
55%.

Issue-ID: POLICY-2420
Change-Id: I9e7ef6f42f04d5c9f090f9b6cd305950a8180f3c
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>

Create PDP Monitoring GUI Model

Monitorning GUI to monitor PDPs Statistics, including
Web and Rest Server by embeded jetty.

Issue-ID: POLICY-2311
Signed-off-by: Hengye <yehui.wang@est.tech>
Change-Id: I9bd0d50eaa7ae4dbd07d17389da2cf107e854c61

Update info yaml & pom of policy/gui

Issue-ID: POLICY-2334
Change-Id: I8692951b2ea760b3fa531ce63e8907392fcbacac
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>

Use policy/parent release

Policy parent v2.0.0

Issue-ID: POLICY-1213
Change-Id: I6701f4d1165bc594d49391f1cad37452066040eb
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>

Setup checkstyle and coverage

Removed redundant version.

Added checkstyle and code coverage declarations.

Added ignore of idea and checkstyle.

Issue-ID: POLICY-1136
Change-Id: Ia2f2428577ba0bf992cba8a5ad5f68d34d5deff8
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>

Changing artifactId for consistency

Change-Id: Id79b9988646917a925a89044c216cd4614e722ee
Issue-ID: POLICY-847
Signed-off-by: ramverma <ram.krishna.verma@ericsson.com>

Change pom to refer policy parent

Change-Id: I85a8b8a1ff8385f2d24025b18e3629e60922a106
Issue-ID: POLICY-847
Signed-off-by: ramverma <ram.krishna.verma@ericsson.com>

Merge "Update gui repo"

Update gui repo

Update the license, readme and version to 2.0.0

Issue-ID: POLICY-771
Change-Id: Ia52913de464e416c920397e81c4b0f9efb1b21f3
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>

Add INFO.yaml file

Add INFO.yaml to list:
- Project description
- Properties
- PTL information
- Meeting information
- Committer information

Change-Id: I4114188dad3b0368037d49d6f9673d9f7127c022
Issue-ID: CIMAN-134
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>

Update oparent version to 1.1.0

Directive from ONAP project that all repos should be updated.
Change vierified with a build with .m2 /org/onap cleared.

Change-Id: I38e19b2b07214f66a7d92acba5c8611200b5a02f
Issue-ID: POLICY-693
Signed-off-by: liamfallon <liam.fallon@ericsson.com>

Cleanup project's name in Sonar

The name parameter in the root pom.xml should
match the project name in gerrit to reflect consistency
in Sonar.

Change-Id: I8eb3515188959bd10d72f29d183c33260d3bb17d
Issue-id: CIMAN-65
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>

Removing duplicate version entries

Eclipse generates warnings for these values which are set in oparent.

Issue-ID: POLICY-216
Change-Id: I80d18daf5a23fa61d914de8344e91368e9f26da2
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>

Add missing properties and distributionManagement

Also the version.properties

In order for the release jobs to execute successfully and the
stage-site jobs to also succeed.

Change-Id: Iaa8faa9c2e3cdad5ffbd067b0704831d2c7298bc
Issue-Id: POLICY-139
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>

First commit, adding parent pom

Issue-ID: POLICY-139
Change-Id: I7e2e3cd72f14b6c01be17d3aaf1e5a09272c87e9
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>

Initial empty repository