Fix sonar issues

[dcaegen2/platform.git] / mod / bpgenerator / onap / src / test / java / org / onap / blueprintgenerator / test / ExternalCertificateParametersFactoryServiceTest.java

diff --git a/mod/bpgenerator/onap/src/test/java/org/onap/blueprintgenerator/test/ExternalCertificateParametersFactoryServiceTest.java b/mod/bpgenerator/onap/src/test/java/org/onap/blueprintgenerator/test/ExternalCertificateParametersFactoryServiceTest.java
index 021bc49..85563d8 100644 (file)
--- a/mod/bpgenerator/onap/src/test/java/org/onap/blueprintgenerator/test/ExternalCertificateParametersFactoryServiceTest.java
+++ b/mod/bpgenerator/onap/src/test/java/org/onap/blueprintgenerator/test/ExternalCertificateParametersFactoryServiceTest.java
@@ -1,22 +1,22 @@
 /*============LICENSE_START=======================================================
- org.onap.dcae
- ================================================================================
- Copyright (c) 2020 Nokia Intellectual Property. All rights reserved.
- Copyright (c) 2020 AT&T Intellectual Property. All rights reserved.
- ================================================================================
- Licensed under the Apache License, Version 2.0 (the "License");
- you may not use this file except in compliance with the License.
- You may obtain a copy of the License at
-
- http://www.apache.org/licenses/LICENSE-2.0
-
- Unless required by applicable law or agreed to in writing, software
- distributed under the License is distributed on an "AS IS" BASIS,
- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- See the License for the specific language governing permissions and
- limitations under the License.
- ============LICENSE_END=========================================================
- */
+org.onap.dcae
+================================================================================
+Copyright (c) 2020-2021 Nokia Intellectual Property. All rights reserved.
+Copyright (c) 2020 AT&T Intellectual Property. All rights reserved.
+================================================================================
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+============LICENSE_END=========================================================
+*/
 
 package org.onap.blueprintgenerator.test;
 
@@ -26,23 +26,29 @@ import org.onap.blueprintgenerator.service.common.ExternalCertificateParametersF
 import org.junit.Test;
 import org.springframework.beans.factory.annotation.Autowired;
 
-
-import java.util.LinkedHashMap;
 import java.util.Map;
 
 import static org.junit.Assert.assertEquals;
 import static org.onap.blueprintgenerator.constants.Constants.COMMON_NAME_FIELD;
 import static org.onap.blueprintgenerator.constants.Constants.SANS_FIELD;
 
-public class ExternalCertificateParametersFactoryServiceTest extends BlueprintGeneratorTests{
+/**
+ * Test for External Certificate Parameters Factory Service
+ */
+public class ExternalCertificateParametersFactoryServiceTest extends BlueprintGeneratorTests {
 
-    private static final String PREFIXED_COMMON_NAME_FIELD = Constants.INPUT_PREFIX + COMMON_NAME_FIELD;
+    private static final String PREFIXED_COMMON_NAME_FIELD =
+        Constants.INPUT_PREFIX + COMMON_NAME_FIELD;
     private static final String PREFIXED_SANS_FIELD = Constants.INPUT_PREFIX + SANS_FIELD;
     private static final String DEFAULT = "default";
 
     @Autowired
     private ExternalCertificateParametersFactoryService externalCertificateParametersFactoryService;
 
+    /**
+     * Test case to create  External Certificate Properties
+     *
+     */
     @Test
     public void shouldCreateExternalCertificatePropertiesObject() {
 
@@ -51,11 +57,17 @@ public class ExternalCertificateParametersFactoryServiceTest extends BlueprintGe
         assertEquals(result.getSans().getBpInputName(), PREFIXED_SANS_FIELD);
     }
 
+    /**
+     * Test case to create Correct Input List with Default Values from Component Spec
+     *
+     */
     @Test
     public void shouldCreateCorrectInputListWithDefaultValuesTakenFromComponentSpec() {
 
-        Map<String, LinkedHashMap<String, Object>> result = externalCertificateParametersFactoryService.createInputList();
-        assertEquals(Constants.DEFAULT_COMMON_NAME, result.get(PREFIXED_COMMON_NAME_FIELD).get(DEFAULT));
+        Map<String, Map<String, Object>> result =
+            externalCertificateParametersFactoryService.createInputList();
+        assertEquals(
+            Constants.DEFAULT_COMMON_NAME, result.get(PREFIXED_COMMON_NAME_FIELD).get(DEFAULT));
         assertEquals(Constants.DEFAULT_SANS, result.get(PREFIXED_SANS_FIELD).get(DEFAULT));
     }
 }