Fix sonar issues 24/118524/4
authorJoanna Jeremicz <joanna.jeremicz@nokia.com>
Thu, 25 Feb 2021 14:24:34 +0000 (15:24 +0100)
committerJoanna Jeremicz <joanna.jeremicz@nokia.com>
Tue, 2 Mar 2021 11:53:02 +0000 (12:53 +0100)
commit72c2d38329865afa6692454b4fb90ab6f8a70638
tree3aaaddd2d37fee4e2fa41a8c790a6f3ae975ec35
parent87f19cde0f6532f5138822fa6f188b763a123235
Fix sonar issues
- Use Map instead of LinkedHashMap when possible
- Rename some constants
- Remove some commented lines
- Add logger
- Other minor improvements and refactor

Issue-ID: DCAEGEN2-2636
Signed-off-by: Joanna Jeremicz <joanna.jeremicz@nokia.com>
Change-Id: I7a03cee453b3d254c4ff0fdf51c60a0ae4a61c42
40 files changed:
mod/bpgenerator/common/pom.xml
mod/bpgenerator/common/src/main/java/org/onap/blueprintgenerator/constants/Constants.java
mod/bpgenerator/common/src/main/java/org/onap/blueprintgenerator/model/base/Blueprint.java
mod/bpgenerator/common/src/main/java/org/onap/blueprintgenerator/model/common/GetInput.java
mod/bpgenerator/common/src/main/java/org/onap/blueprintgenerator/model/componentspec/base/Auxilary.java
mod/bpgenerator/common/src/main/java/org/onap/blueprintgenerator/service/base/BlueprintHelperService.java
mod/bpgenerator/common/src/main/java/org/onap/blueprintgenerator/service/base/BlueprintService.java
mod/bpgenerator/common/src/main/java/org/onap/blueprintgenerator/service/base/FixesService.java
mod/bpgenerator/coverage/pom.xml
mod/bpgenerator/onap-executable/pom.xml
mod/bpgenerator/onap/pom.xml
mod/bpgenerator/onap/src/main/java/org/onap/blueprintgenerator/service/InfoService.java
mod/bpgenerator/onap/src/main/java/org/onap/blueprintgenerator/service/common/AppConfigService.java
mod/bpgenerator/onap/src/main/java/org/onap/blueprintgenerator/service/common/DmaapService.java
mod/bpgenerator/onap/src/main/java/org/onap/blueprintgenerator/service/common/ExternalCertificateParametersFactoryService.java
mod/bpgenerator/onap/src/main/java/org/onap/blueprintgenerator/service/common/ExternalTlsInfoFactoryService.java
mod/bpgenerator/onap/src/main/java/org/onap/blueprintgenerator/service/common/InterfacesService.java
mod/bpgenerator/onap/src/main/java/org/onap/blueprintgenerator/service/common/NodeService.java
mod/bpgenerator/onap/src/main/java/org/onap/blueprintgenerator/service/common/PgaasNodeService.java
mod/bpgenerator/onap/src/main/java/org/onap/blueprintgenerator/service/common/PolicyNodeService.java
mod/bpgenerator/onap/src/main/java/org/onap/blueprintgenerator/service/common/PropertiesService.java
mod/bpgenerator/onap/src/main/java/org/onap/blueprintgenerator/service/common/QuotationService.java
mod/bpgenerator/onap/src/main/java/org/onap/blueprintgenerator/service/common/ResourceConfigService.java
mod/bpgenerator/onap/src/main/java/org/onap/blueprintgenerator/service/common/StartInputsService.java
mod/bpgenerator/onap/src/main/java/org/onap/blueprintgenerator/service/common/StartService.java
mod/bpgenerator/onap/src/main/java/org/onap/blueprintgenerator/service/common/StreamService.java
mod/bpgenerator/onap/src/main/java/org/onap/blueprintgenerator/service/common/kafka/KafkaStreamService.java
mod/bpgenerator/onap/src/main/java/org/onap/blueprintgenerator/service/dmaap/DmaapBlueprintCreatorService.java
mod/bpgenerator/onap/src/main/java/org/onap/blueprintgenerator/service/dmaap/StreamsService.java
mod/bpgenerator/onap/src/main/java/org/onap/blueprintgenerator/service/onap/OnapBlueprintCreatorService.java
mod/bpgenerator/onap/src/test/java/org/onap/blueprintgenerator/service/common/AppConfigServiceTest.java
mod/bpgenerator/onap/src/test/java/org/onap/blueprintgenerator/service/common/PropertiesServiceTest.java
mod/bpgenerator/onap/src/test/java/org/onap/blueprintgenerator/service/common/StreamServiceTest.java
mod/bpgenerator/onap/src/test/java/org/onap/blueprintgenerator/service/common/kafka/KafkaStreamServiceTest.java
mod/bpgenerator/onap/src/test/java/org/onap/blueprintgenerator/test/ExternalCertificateParametersFactoryServiceTest.java
mod/bpgenerator/onap/src/test/java/org/onap/blueprintgenerator/test/OnapBlueprintCreatorServiceTest.java
mod/bpgenerator/onap/src/test/java/org/onap/blueprintgenerator/test/OnapTestUtils.java
mod/bpgenerator/onap/src/test/java/org/onap/blueprintgenerator/test/TlsInfoTest.java
mod/bpgenerator/pom.xml
mod/bpgenerator/version.properties