Fix sonar issues

[dcaegen2/platform.git] / mod / bpgenerator / onap / src / main / java / org / onap / blueprintgenerator / service / common / QuotationService.java

diff --git a/mod/bpgenerator/onap/src/main/java/org/onap/blueprintgenerator/service/common/QuotationService.java b/mod/bpgenerator/onap/src/main/java/org/onap/blueprintgenerator/service/common/QuotationService.java
index c79ec56..fef4447 100644 (file)
--- a/mod/bpgenerator/onap/src/main/java/org/onap/blueprintgenerator/service/common/QuotationService.java
+++ b/mod/bpgenerator/onap/src/main/java/org/onap/blueprintgenerator/service/common/QuotationService.java
@@ -4,6 +4,7 @@
  *  *  org.onap.dcae
  *  *  ================================================================================
  *  *  Copyright (c) 2020  AT&T Intellectual Property. All rights reserved.
+ *  *  Copyright (c) 2021 Nokia. All rights reserved.
  *  *  ================================================================================
  *  *  Licensed under the Apache License, Version 2.0 (the "License");
  *  *  you may not use this file except in compliance with the License.
@@ -23,29 +24,30 @@
 
 package org.onap.blueprintgenerator.service.common;
 
+import java.util.Map;
 import org.onap.blueprintgenerator.model.common.OnapBlueprint;
 import org.springframework.stereotype.Service;
 
-import java.util.LinkedHashMap;
-
 /**
  * @author : Ravi Mantena
- * @date 10/16/2020
- * Application: ONAP - Blueprint Generator
- * Common ONAP Service used by ONAP and DMAAP Blueprint to set Quotations of generated Blueprint
+ * @date 10/16/2020 Application: ONAP - Blueprint Generator Common ONAP Service to set Quotations of
+ * generated Blueprint
  */
-
-
 @Service
 public class QuotationService {
 
-    // Method to add Quotes for String Types
+    /**
+     * Adds Quotes for String Types for generated Blueprint
+     *
+     * @param bp Blueprint
+     * @return
+     */
     public OnapBlueprint setQuotations(OnapBlueprint bp) {
-        for(String s: bp.getInputs().keySet()) {
-            LinkedHashMap<String, Object> temp = bp.getInputs().get(s);
-            if(temp.get("type") == "string") {
+        for (String s : bp.getInputs().keySet()) {
+            Map<String, Object> temp = bp.getInputs().get(s);
+            if (temp.get("type") == "string") {
                 String def = (String) temp.get("default");
-                if(def != null){
+                if (def != null) {
                     def = def.replaceAll("\"$", "").replaceAll("^\"", "");
                 }
                 def = '"' + def + '"';
@@ -55,5 +57,4 @@ public class QuotationService {
         }
         return bp;
     }
-
 }