Fix sonar issues

[dcaegen2/platform.git] / mod / bpgenerator / onap / src / main / java / org / onap / blueprintgenerator / service / common / ExternalCertificateParametersFactoryService.java

diff --git a/mod/bpgenerator/onap/src/main/java/org/onap/blueprintgenerator/service/common/ExternalCertificateParametersFactoryService.java b/mod/bpgenerator/onap/src/main/java/org/onap/blueprintgenerator/service/common/ExternalCertificateParametersFactoryService.java
index 300aa5d..1e3386c 100644 (file)
--- a/mod/bpgenerator/onap/src/main/java/org/onap/blueprintgenerator/service/common/ExternalCertificateParametersFactoryService.java
+++ b/mod/bpgenerator/onap/src/main/java/org/onap/blueprintgenerator/service/common/ExternalCertificateParametersFactoryService.java
@@ -4,7 +4,7 @@
  *  *  org.onap.dcae
  *  *  ================================================================================
  *  *  Copyright (c) 2020  AT&T Intellectual Property. All rights reserved.
- *  *  Copyright (c) 2020  Nokia. All rights reserved.
+ *  *  Copyright (c) 2020-2021  Nokia. All rights reserved.
  *  *  ================================================================================
  *  *  Licensed under the Apache License, Version 2.0 (the "License");
  *  *  you may not use this file except in compliance with the License.
@@ -35,40 +35,52 @@ import java.util.Map;
 
 /**
  * @author : Ravi Mantena
- * @date 10/16/2020 Application: ONAP - Blueprint Generator Common ONAP Service used by ONAP and DMAAP Blueprint to add
- * External Certificate Parameters
+ * @date 10/16/2020 Application: ONAP - Blueprint Generator Common ONAP Service used by ONAP and
+ * DMAAP Blueprint to add Common ONAP Service to add External Certificate Parameters Factory
  */
-
-
 @Service
-public class ExternalCertificateParametersFactoryService extends ExternalCertificateDataFactoryService {
+public class ExternalCertificateParametersFactoryService
+    extends ExternalCertificateDataFactoryService {
 
     @Autowired
     private BlueprintHelperService blueprintHelperService;
 
-    // method to create external certificate parameters
+    /**
+     * Creates external certificate parameters
+     *
+     * @return
+     */
     public ExternalCertificateParameters create() {
-        ExternalCertificateParameters externalCertificateParameters = new ExternalCertificateParameters();
-        externalCertificateParameters.setCommonName(createPrefixedGetInput(Constants.COMMON_NAME_FIELD));
+        ExternalCertificateParameters externalCertificateParameters =
+            new ExternalCertificateParameters();
+        externalCertificateParameters.setCommonName(
+            createPrefixedGetInput(Constants.COMMON_NAME_FIELD));
         externalCertificateParameters.setSans(createPrefixedGetInput(Constants.SANS_FIELD));
         return externalCertificateParameters;
     }
 
-    // method to create input list for external certificate parameters factory
-    public Map<String, LinkedHashMap<String, Object>> createInputList() {
-        Map<String, LinkedHashMap<String, Object>> retInputs = new LinkedHashMap<>();
+    /**
+     * Creates input list for external certificate parameters factory
+     *
+     * @return
+     */
+    public Map<String, Map<String, Object>> createInputList() {
+        Map<String, Map<String, Object>> retInputs = new LinkedHashMap<>();
 
-        LinkedHashMap<String, Object> commonNameInputMap = blueprintHelperService
-            .createStringInput("Common name which should be present in certificate.", Constants.DEFAULT_COMMON_NAME);
+        Map<String, Object> commonNameInputMap =
+            blueprintHelperService.createStringInput(
+                "Common name which should be present in certificate.",
+                Constants.DEFAULT_COMMON_NAME);
         retInputs.put(addPrefix(Constants.COMMON_NAME_FIELD), commonNameInputMap);
 
-        LinkedHashMap<String, Object> sansInputMap = blueprintHelperService
-            .createStringInput("\"List of Subject Alternative Names (SANs) which should be present in certificate. " +
-                "Delimiter - , Should contain a common_name value and other FQDNs under which the given "
-                + "component is accessible.\"", Constants.DEFAULT_SANS);
+        Map<String, Object> sansInputMap =
+            blueprintHelperService.createStringInput(
+                "\"List of Subject Alternative Names (SANs) which should be present in certificate. "
+                    + "Delimiter - , Should contain a common_name value and other FQDNs under which the given "
+                    + "component is accessible.\"",
+                Constants.DEFAULT_SANS);
         retInputs.put(addPrefix(Constants.SANS_FIELD), sansInputMap);
 
         return retInputs;
     }
-
 }