Merge "Part 1: Refactor CPS Delta code to utility class"
[cps.git] / integration-test / src / test / groovy / org / onap / cps / integration / performance / ncmp / CmHandleQueryPerfTest.groovy
index d95ac73..fc9dfa9 100644 (file)
@@ -1,6 +1,6 @@
 /*
  *  ============LICENSE_START=======================================================
- *  Copyright (C) 2023-2024 Nordix Foundation
+ *  Copyright (C) 2023-2025 OpenInfra Foundation Europe. All rights reserved.
  *  ================================================================================
  *  Licensed under the Apache License, Version 2.0 (the 'License');
  *  you may not use this file except in compliance with the License.
 
 package org.onap.cps.integration.performance.ncmp
 
-import org.apache.commons.lang3.StringUtils
-import org.onap.cps.ncmp.api.impl.inventory.CmHandleState
-import org.onap.cps.ncmp.api.impl.inventory.sync.ModuleSyncService
-import org.onap.cps.ncmp.api.impl.utils.YangDataConverter
-import org.onap.cps.spi.FetchDescendantsOption
-import org.onap.cps.spi.model.DataNode
-import org.springframework.beans.factory.annotation.Autowired
-
-import java.util.stream.Collectors
 import org.onap.cps.api.CpsQueryService
-import org.onap.cps.integration.ResourceMeter
 import org.onap.cps.integration.performance.base.NcmpPerfTestBase
 
-import static org.onap.cps.spi.FetchDescendantsOption.OMIT_DESCENDANTS
-import static org.onap.cps.spi.FetchDescendantsOption.INCLUDE_ALL_DESCENDANTS
+import java.util.stream.Collectors
 
-class CmHandleQueryPerfTest extends NcmpPerfTestBase {
+import static org.onap.cps.api.parameters.FetchDescendantsOption.INCLUDE_ALL_DESCENDANTS
+import static org.onap.cps.api.parameters.FetchDescendantsOption.OMIT_DESCENDANTS
 
-    static def MILLISECONDS = 0.001
+class CmHandleQueryPerfTest extends NcmpPerfTestBase {
 
     CpsQueryService objectUnderTest
-    ResourceMeter resourceMeter = new ResourceMeter()
 
     def setup() { objectUnderTest = cpsQueryService }
 
     def 'JVM warmup.'() {
         when: 'the JVM is warmed up'
-            def iterations = 2500 // set this to 15000 for very accurate results (but test takes much longer)
+            def iterations = TOTAL_CM_HANDLES * 0.1
             resourceMeter.start()
             (1..iterations).forEach {
-                cpsDataService.getDataNodes(NCMP_PERFORMANCE_TEST_DATASPACE, REGISTRY_ANCHOR,
-                        '/dmi-registry/cm-handles[@id="cm-' + it + '"]', OMIT_DESCENDANTS)
-                objectUnderTest.queryDataNodes(NCMP_PERFORMANCE_TEST_DATASPACE, REGISTRY_ANCHOR,
-                        '/dmi-registry/cm-handles[@alternate-id="alt-' + it + '"]', OMIT_DESCENDANTS)
+                cpsDataService.getDataNodes(NCMP_PERFORMANCE_TEST_DATASPACE, REGISTRY_ANCHOR, "/dmi-registry/cm-handles[@id='cm-${it}']", OMIT_DESCENDANTS)
+                objectUnderTest.queryDataNodes(NCMP_PERFORMANCE_TEST_DATASPACE, REGISTRY_ANCHOR, "/dmi-registry/cm-handles[@alternate-id='alt-${it}']", OMIT_DESCENDANTS)
             }
             resourceMeter.stop()
         then: 'resource usage is as expected'
-            recordAndAssertResourceUsage('JVM warmup for CmHandleQueryPerfTest',
-                    30, resourceMeter.totalTimeInSeconds,
-                    300, resourceMeter.totalMemoryUsageInMB)
+            recordAndAssertResourceUsage('NCMP:JVM warmup for CmHandleQueryPerfTest', 42, resourceMeter.totalTimeInSeconds, resourceMeter.totalMemoryUsageInMB)
     }
 
     def 'Query CM Handle IDs by a property name and value.'() {
@@ -74,7 +59,7 @@ class CmHandleQueryPerfTest extends NcmpPerfTestBase {
             resourceMeter.stop()
             def durationInSeconds = resourceMeter.getTotalTimeInSeconds()
         then: 'the required operations are performed within required time'
-            recordAndAssertResourceUsage("CpsPath Registry attributes Query", 2, durationInSeconds, 300, resourceMeter.getTotalMemoryUsageInMB())
+            recordAndAssertResourceUsage('NCMP:CpsPath Registry attributes Query', 3, durationInSeconds, resourceMeter.getTotalMemoryUsageInMB(), REFERENCE_GRAPH)
         and: 'all nodes are returned'
             result.size() == TOTAL_CM_HANDLES
         and: 'the tree contains all the expected descendants too'
@@ -90,53 +75,38 @@ class CmHandleQueryPerfTest extends NcmpPerfTestBase {
                         '/dmi-registry/cm-handles[@id="cm-' + it + '"]', OMIT_DESCENDANTS).size()
             }
             resourceMeter.stop()
-        then:
+        then: '100 data node have been found'
             assert count == 100
         and: 'average performance is as expected'
-            def averageResponseTime = resourceMeter.totalTimeInSeconds / 100
-            recordAndAssertResourceUsage('Look up CM-handle by id',
-                    expectedAverageResponseTime, averageResponseTime,
-                    15, resourceMeter.totalMemoryUsageInMB)
-        where:
-            expectedAverageResponseTime = 1 * MILLISECONDS
+            recordAndAssertResourceUsage('NCMP:Look up CM-handle by id', 0.58, resourceMeter.totalTimeInSeconds, resourceMeter.totalMemoryUsageInMB)
     }
 
-    def 'CM-handle is looked up by alternate-id.'() {
-        when: 'CM-handles are looked up by alternate-id 100 times'
+    def 'CM-handle is looked up by alternate id.'() {
+        when: 'CM-handles are looked up by alternate id 100 times'
             int count = 0
             resourceMeter.start()
             (1..100).each {
                 count += cpsQueryService.queryDataNodes(NCMP_PERFORMANCE_TEST_DATASPACE, REGISTRY_ANCHOR,
-                        '/dmi-registry/cm-handles[@alternate-id="alt-' + it + '"]', OMIT_DESCENDANTS).size()
+                        "/dmi-registry/cm-handles[@alternate-id='alt-${it}']", OMIT_DESCENDANTS).size()
             }
             resourceMeter.stop()
-        then:
+        then: 'all alternate ids are resolved correctly'
             assert count == 100
         and: 'average performance is as expected'
-            def averageResponseTime = resourceMeter.totalTimeInSeconds / 100
-            recordAndAssertResourceUsage('Look up CM-handle by alternate-id',
-                    expectedAverageResponseTime, averageResponseTime,
-                    15, resourceMeter.totalMemoryUsageInMB)
-        where:
-            expectedAverageResponseTime = 10 * MILLISECONDS
+            recordAndAssertResourceUsage('NCMP:Look up CM-handle by alternate-id', 1.6, resourceMeter.totalTimeInSeconds, resourceMeter.totalMemoryUsageInMB, REFERENCE_GRAPH)
     }
 
-    def 'A batch of CM-handles is looked up by alternate-id.'() {
-        given: 'a CPS Path Query to look up 100 alternate-ids in a single operation'
+    def 'A batch of CM-handles is looked up by alternate id.'() {
+        given: 'a CPS Path Query to look up 100 alternate ids in a single operation'
             def cpsPathQuery = '/dmi-registry/cm-handles[' + (1..100).collect { "@alternate-id='alt-${it}'" }.join(' or ') + ']'
-        when: 'CM-handles are looked up by alternate-ids in a single query'
+        when: 'CM-handles are looked up by alternate ids in a single query'
             resourceMeter.start()
             def count = cpsQueryService.queryDataNodes(NCMP_PERFORMANCE_TEST_DATASPACE, REGISTRY_ANCHOR, cpsPathQuery, OMIT_DESCENDANTS).size()
             resourceMeter.stop()
         then: 'expected amount of data was returned'
             assert count == 100
         then: 'average performance is as expected'
-            def averageResponseTime = resourceMeter.totalTimeInSeconds / 100
-            recordAndAssertResourceUsage('Batch look up CM-handle by alternate-id',
-                    expectedAverageResponseTime, averageResponseTime,
-                    15, resourceMeter.totalMemoryUsageInMB)
-        where:
-            expectedAverageResponseTime = 1 * MILLISECONDS
+            recordAndAssertResourceUsage('NCMP:Batch look up CM-handle by alternate-id', 0.24, resourceMeter.totalTimeInSeconds, resourceMeter.totalMemoryUsageInMB)
     }
 
     def 'Find any CM-handle given moduleSetTag when there are 20K READY handles with same moduleSetTag.'() {
@@ -153,11 +123,7 @@ class CmHandleQueryPerfTest extends NcmpPerfTestBase {
             assert count == TOTAL_CM_HANDLES * 100
         then: 'average performance is as expected'
             def averageResponseTime = resourceMeter.totalTimeInSeconds / 100
-            recordAndAssertResourceUsage('Look up CM-handles by module-set-tag',
-                    expectedAverageResponseTime, averageResponseTime,
-                    500, resourceMeter.totalMemoryUsageInMB)
-        where:
-            expectedAverageResponseTime = 100 * MILLISECONDS
+            recordAndAssertResourceUsage('NCMP:Look up CM-handles by module-set-tag', 0.26, averageResponseTime, resourceMeter.totalMemoryUsageInMB)
     }
 
 }